)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4352feefb243097c7aeabfa46a850c6ab0489e17","unresolved":false,"context_lines":[{"line_number":29,"context_line":"value."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"APIImpact"},{"line_number":32,"context_line":"DocImpact"},{"line_number":33,"context_line":"Related-Bug: #1596611"},{"line_number":34,"context_line":"Change-Id: I26e22bce7edd1f93b2ac0048b61b14f858938537"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a461143_da7db2b2","line":32,"updated":"2017-01-26 19:53:57.000000000","message":"you must provide a draft text here explaining what to put/update in docs","commit_id":"d21261cd68234b12abb1a313e0a3b486f2fb2add"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"594f5fea0275fa776c6dbc2521c318fccb595107","unresolved":false,"context_lines":[{"line_number":29,"context_line":"value."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"APIImpact"},{"line_number":32,"context_line":"DocImpact"},{"line_number":33,"context_line":"Related-Bug: #1596611"},{"line_number":34,"context_line":"Change-Id: I26e22bce7edd1f93b2ac0048b61b14f858938537"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a430d35_052566aa","line":32,"in_reply_to":"3a461143_da7db2b2","updated":"2017-02-03 02:10:54.000000000","message":"Done","commit_id":"d21261cd68234b12abb1a313e0a3b486f2fb2add"}],"neutron/agent/l3/dvr_edge_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d440fe049ef3f80e316420deff267fd3f682d744","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        if not self.get_ex_gw_port():"},{"line_number":204,"context_line":"            return"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        if not self.snat_namespace:"},{"line_number":207,"context_line":"            LOG.debug(\"DVR router: snat namespace not existed.\")"},{"line_number":208,"context_line":"            return"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_8471457a","line":206,"updated":"2017-01-25 03:20:41.000000000","message":"This isn\u0027t checking for existence","commit_id":"36484eaefc3d97b8e868d687dce85ece3c433ae8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"16ed1eb4b84be42efef3d51e4eeb55dccdddbafe","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        if not self.get_ex_gw_port():"},{"line_number":204,"context_line":"            return"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        if not self.snat_namespace:"},{"line_number":207,"context_line":"            LOG.debug(\"DVR router: snat namespace not existed.\")"},{"line_number":208,"context_line":"            return"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_cc82afc8","line":206,"in_reply_to":"5a3905b3_8471457a","updated":"2017-01-25 13:03:40.000000000","message":"Done","commit_id":"36484eaefc3d97b8e868d687dce85ece3c433ae8"}],"neutron/agent/l3/router_info.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d440fe049ef3f80e316420deff267fd3f682d744","unresolved":false,"context_lines":[{"line_number":914,"context_line":"        rate \u003d self.router[\u0027external_gateway_info\u0027][\u0027rate_limit\u0027]"},{"line_number":915,"context_line":"        for ip_addr in ex_gw_port[\u0027fixed_ips\u0027]:"},{"line_number":916,"context_line":"            ex_gw_ip \u003d ip_addr[\u0027ip_address\u0027]"},{"line_number":917,"context_line":"            if netaddr.IPAddress(ex_gw_ip).version \u003d\u003d 4:"},{"line_number":918,"context_line":"                if self._snat_enabled:"},{"line_number":919,"context_line":"                    self._set_gateway_ip_rate_limit(tc_wrapper, ex_gw_ip, rate)"},{"line_number":920,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_a4f561cc","line":917,"updated":"2017-01-25 03:20:41.000000000","message":"There\u0027s a constant for \u00274\u0027 in the neutron_lib constants file","commit_id":"36484eaefc3d97b8e868d687dce85ece3c433ae8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"16ed1eb4b84be42efef3d51e4eeb55dccdddbafe","unresolved":false,"context_lines":[{"line_number":914,"context_line":"        rate \u003d self.router[\u0027external_gateway_info\u0027][\u0027rate_limit\u0027]"},{"line_number":915,"context_line":"        for ip_addr in ex_gw_port[\u0027fixed_ips\u0027]:"},{"line_number":916,"context_line":"            ex_gw_ip \u003d ip_addr[\u0027ip_address\u0027]"},{"line_number":917,"context_line":"            if netaddr.IPAddress(ex_gw_ip).version \u003d\u003d 4:"},{"line_number":918,"context_line":"                if self._snat_enabled:"},{"line_number":919,"context_line":"                    self._set_gateway_ip_rate_limit(tc_wrapper, ex_gw_ip, rate)"},{"line_number":920,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_b0910d55","line":917,"in_reply_to":"5a3905b3_a4f561cc","updated":"2017-01-25 13:03:40.000000000","message":"Done","commit_id":"36484eaefc3d97b8e868d687dce85ece3c433ae8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d440fe049ef3f80e316420deff267fd3f682d744","unresolved":false,"context_lines":[{"line_number":915,"context_line":"        for ip_addr in ex_gw_port[\u0027fixed_ips\u0027]:"},{"line_number":916,"context_line":"            ex_gw_ip \u003d ip_addr[\u0027ip_address\u0027]"},{"line_number":917,"context_line":"            if netaddr.IPAddress(ex_gw_ip).version \u003d\u003d 4:"},{"line_number":918,"context_line":"                if self._snat_enabled:"},{"line_number":919,"context_line":"                    self._set_gateway_ip_rate_limit(tc_wrapper, ex_gw_ip, rate)"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"    def _set_gateway_ip_rate_limit(self, tc_wrapper, ex_gw_ip, rate):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_a4e3a104","line":918,"updated":"2017-01-25 03:20:41.000000000","message":"This check should be after L912, else we\u0027re doing some unnecessary work.\n\nif not self._snat_enabled:\n    return\n\nThe teardown code could check it to and do nothing since no rules would have been added.","commit_id":"36484eaefc3d97b8e868d687dce85ece3c433ae8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"16ed1eb4b84be42efef3d51e4eeb55dccdddbafe","unresolved":false,"context_lines":[{"line_number":915,"context_line":"        for ip_addr in ex_gw_port[\u0027fixed_ips\u0027]:"},{"line_number":916,"context_line":"            ex_gw_ip \u003d ip_addr[\u0027ip_address\u0027]"},{"line_number":917,"context_line":"            if netaddr.IPAddress(ex_gw_ip).version \u003d\u003d 4:"},{"line_number":918,"context_line":"                if self._snat_enabled:"},{"line_number":919,"context_line":"                    self._set_gateway_ip_rate_limit(tc_wrapper, ex_gw_ip, rate)"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"    def _set_gateway_ip_rate_limit(self, tc_wrapper, ex_gw_ip, rate):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_d075b932","line":918,"in_reply_to":"5a3905b3_a4e3a104","updated":"2017-01-25 13:03:40.000000000","message":"Done","commit_id":"36484eaefc3d97b8e868d687dce85ece3c433ae8"}],"neutron/common/exceptions.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"882543a089e91a89ed1a4e173a80b806b424cc09","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class RouterQosBindingNotFound(e.NotFound):"},{"line_number":64,"context_line":"    message \u003d _(\"QoS binding for router %(fip_id)s and policy \""},{"line_number":65,"context_line":"                \"%(policy_id)s could not be found.\")"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_4b69e9bb","line":64,"range":{"start_line":64,"start_character":42,"end_line":64,"end_character":48},"updated":"2018-06-08 15:17:49.000000000","message":"s/router_id","commit_id":"cfca0b7b48383dc2e6dca1fd3e61f9d9ef4b846c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"58bf3ff58df6d9511bf185584468a25a205d0f4a","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class RouterQosBindingNotFound(e.NotFound):"},{"line_number":64,"context_line":"    message \u003d _(\"QoS binding for router %(fip_id)s and policy \""},{"line_number":65,"context_line":"                \"%(policy_id)s could not be found.\")"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_646c0f36","line":64,"range":{"start_line":64,"start_character":42,"end_line":64,"end_character":48},"in_reply_to":"5f7c97a3_4b69e9bb","updated":"2018-06-09 12:05:17.000000000","message":"Done","commit_id":"cfca0b7b48383dc2e6dca1fd3e61f9d9ef4b846c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7edc5800ac9ebde6ca98aea9d45f14fd71c07823","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"class RouterQosBindingNotFound(exceptions.NotFound):"},{"line_number":125,"context_line":"    message \u003d _(\"QoS binding for router %(router_id)s and policy \""},{"line_number":126,"context_line":"                \"%(policy_id)s could not be found.\")"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"3f79a3b5_bf173754","line":125,"range":{"start_line":125,"start_character":33,"end_line":125,"end_character":39},"updated":"2018-10-18 08:36:01.000000000","message":"\"for router\u0027s gateway\" to be strict","commit_id":"362c8938677fc14e1aecf0fed5f25e5d28310fd2"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"da0663dc453f6850a9f8ca9f98219a552cf0ff02","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"class RouterQosBindingNotFound(exceptions.NotFound):"},{"line_number":125,"context_line":"    message \u003d _(\"QoS binding for router %(router_id)s and policy \""},{"line_number":126,"context_line":"                \"%(policy_id)s could not be found.\")"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"3f79a3b5_aff18666","line":125,"range":{"start_line":125,"start_character":33,"end_line":125,"end_character":39},"in_reply_to":"3f79a3b5_bf173754","updated":"2018-10-25 03:08:23.000000000","message":"Done","commit_id":"362c8938677fc14e1aecf0fed5f25e5d28310fd2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7edc5800ac9ebde6ca98aea9d45f14fd71c07823","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"class RouterQosBindingError(exceptions.NeutronException):"},{"line_number":130,"context_line":"    message \u003d _(\"QoS binding for router %(router_id)s and policy \""},{"line_number":131,"context_line":"                \"%(policy_id)s could not be created: %(db_error)s.\")"}],"source_content_type":"text/x-python","patch_set":30,"id":"3f79a3b5_df1a337a","line":130,"range":{"start_line":130,"start_character":33,"end_line":130,"end_character":39},"updated":"2018-10-18 08:36:01.000000000","message":"same here","commit_id":"362c8938677fc14e1aecf0fed5f25e5d28310fd2"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"da0663dc453f6850a9f8ca9f98219a552cf0ff02","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"class RouterQosBindingError(exceptions.NeutronException):"},{"line_number":130,"context_line":"    message \u003d _(\"QoS binding for router %(router_id)s and policy \""},{"line_number":131,"context_line":"                \"%(policy_id)s could not be created: %(db_error)s.\")"}],"source_content_type":"text/x-python","patch_set":30,"id":"3f79a3b5_4f90f2f3","line":130,"range":{"start_line":130,"start_character":33,"end_line":130,"end_character":39},"in_reply_to":"3f79a3b5_df1a337a","updated":"2018-10-25 03:08:23.000000000","message":"Done","commit_id":"362c8938677fc14e1aecf0fed5f25e5d28310fd2"}],"neutron/db/gateway_rate_limit_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d440fe049ef3f80e316420deff267fd3f682d744","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":"gateway_opts \u003d ["},{"line_number":28,"context_line":"    cfg.BoolOpt(\u0027enable_gateway_rate_limit\u0027,"},{"line_number":29,"context_line":"                default\u003dFalse,"},{"line_number":30,"context_line":"                help\u003d_(\"Whether enable gateway rate limit.\")),"},{"line_number":31,"context_line":"    cfg.IntOpt(\u0027gateway_rate_limit_default_rate\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_24bed1d4","line":28,"updated":"2017-01-25 03:20:41.000000000","message":"Same questions as the FIP change","commit_id":"36484eaefc3d97b8e868d687dce85ece3c433ae8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"16ed1eb4b84be42efef3d51e4eeb55dccdddbafe","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":"gateway_opts \u003d ["},{"line_number":28,"context_line":"    cfg.BoolOpt(\u0027enable_gateway_rate_limit\u0027,"},{"line_number":29,"context_line":"                default\u003dFalse,"},{"line_number":30,"context_line":"                help\u003d_(\"Whether enable gateway rate limit.\")),"},{"line_number":31,"context_line":"    cfg.IntOpt(\u0027gateway_rate_limit_default_rate\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_10a021a5","line":28,"in_reply_to":"5a3905b3_24bed1d4","updated":"2017-01-25 13:03:40.000000000","message":"Please see my comment there. : )\nhttps://review.openstack.org/#/c/424466/1/neutron/db/fip_rate_limit_db.py@26","commit_id":"36484eaefc3d97b8e868d687dce85ece3c433ae8"}],"neutron/db/l3_gateway_ip_qos.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"7c41269a0639763d54acb6fbc1d4371c4d8041fb","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@resource_extend.has_resource_extenders"},{"line_number":32,"context_line":"class gateway_ip_qos_dbonly_mixin(l3_gwmode_db.L3_NAT_dbonly_mixin):"},{"line_number":33,"context_line":"    \"\"\"Mixin class to add router gateway IP\u0027s QoS extra attributes.\"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_2e435b41","line":32,"range":{"start_line":32,"start_character":6,"end_line":32,"end_character":33},"updated":"2018-06-08 16:36:04.000000000","message":"Pascal case ?","commit_id":"cfca0b7b48383dc2e6dca1fd3e61f9d9ef4b846c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"58bf3ff58df6d9511bf185584468a25a205d0f4a","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@resource_extend.has_resource_extenders"},{"line_number":32,"context_line":"class gateway_ip_qos_dbonly_mixin(l3_gwmode_db.L3_NAT_dbonly_mixin):"},{"line_number":33,"context_line":"    \"\"\"Mixin class to add router gateway IP\u0027s QoS extra attributes.\"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_d30fe7dd","line":32,"range":{"start_line":32,"start_character":6,"end_line":32,"end_character":33},"in_reply_to":"5f7c97a3_2e435b41","updated":"2018-06-09 12:05:17.000000000","message":"Done","commit_id":"cfca0b7b48383dc2e6dca1fd3e61f9d9ef4b846c"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"7c41269a0639763d54acb6fbc1d4371c4d8041fb","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            router_res[l3_apidef.EXTERNAL_GW_INFO].update("},{"line_number":41,"context_line":"                {qos_consts.QOS_POLICY_ID: policy_id})"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _get_policy_obj(self, context, policy_id):"},{"line_number":44,"context_line":"        obj \u003d policy_object.QosPolicy.get_object(context, id\u003dpolicy_id)"},{"line_number":45,"context_line":"        if obj is None:"},{"line_number":46,"context_line":"            raise n_exc.QosPolicyNotFound(policy_id\u003dpolicy_id)"},{"line_number":47,"context_line":"        return obj"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def _create_gw_ip_qos_db(self, context, router_id, policy_id):"},{"line_number":50,"context_line":"        policy \u003d self._get_policy_obj(context, policy_id)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_0efe9fae","line":47,"range":{"start_line":43,"start_character":4,"end_line":47,"end_character":18},"updated":"2018-06-08 16:36:04.000000000","message":"this method need a better home since its there in [1] and [2].\n\n[1]. https://github.com/openstack/neutron/blob/master/neutron/db/l3_fip_qos.py#L37-L41\n\n[2]. https://github.com/openstack/neutron/blob/master/neutron/services/qos/qos_plugin.py#L226-L240\n\nwould be  better to have one home and use it every where.\nobjects/policy.py would be better place I guess.","commit_id":"cfca0b7b48383dc2e6dca1fd3e61f9d9ef4b846c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"58bf3ff58df6d9511bf185584468a25a205d0f4a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            router_res[l3_apidef.EXTERNAL_GW_INFO].update("},{"line_number":41,"context_line":"                {qos_consts.QOS_POLICY_ID: policy_id})"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _get_policy_obj(self, context, policy_id):"},{"line_number":44,"context_line":"        obj \u003d policy_object.QosPolicy.get_object(context, id\u003dpolicy_id)"},{"line_number":45,"context_line":"        if obj is None:"},{"line_number":46,"context_line":"            raise n_exc.QosPolicyNotFound(policy_id\u003dpolicy_id)"},{"line_number":47,"context_line":"        return obj"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def _create_gw_ip_qos_db(self, context, router_id, policy_id):"},{"line_number":50,"context_line":"        policy \u003d self._get_policy_obj(context, policy_id)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_d3284734","line":47,"range":{"start_line":43,"start_character":4,"end_line":47,"end_character":18},"in_reply_to":"5f7c97a3_0efe9fae","updated":"2018-06-09 12:05:17.000000000","message":"Done","commit_id":"cfca0b7b48383dc2e6dca1fd3e61f9d9ef4b846c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"882543a089e91a89ed1a4e173a80b806b424cc09","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                                          router_id,"},{"line_number":88,"context_line":"                                          old_qos_policy_id)"},{"line_number":89,"context_line":"            if not new_qos_policy_id:"},{"line_number":90,"context_line":"                return"},{"line_number":91,"context_line":"        if new_qos_policy_id:"},{"line_number":92,"context_line":"            self._create_gw_ip_qos_db("},{"line_number":93,"context_line":"                context, router_id, new_qos_policy_id)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_6b914552","line":90,"updated":"2018-06-08 15:17:49.000000000","message":"Technically you don\u0027t need this as L91 checks too.","commit_id":"cfca0b7b48383dc2e6dca1fd3e61f9d9ef4b846c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"58bf3ff58df6d9511bf185584468a25a205d0f4a","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                                          router_id,"},{"line_number":88,"context_line":"                                          old_qos_policy_id)"},{"line_number":89,"context_line":"            if not new_qos_policy_id:"},{"line_number":90,"context_line":"                return"},{"line_number":91,"context_line":"        if new_qos_policy_id:"},{"line_number":92,"context_line":"            self._create_gw_ip_qos_db("},{"line_number":93,"context_line":"                context, router_id, new_qos_policy_id)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_73f853c3","line":90,"in_reply_to":"5f7c97a3_6b914552","updated":"2018-06-09 12:05:17.000000000","message":"Done","commit_id":"cfca0b7b48383dc2e6dca1fd3e61f9d9ef4b846c"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"7c41269a0639763d54acb6fbc1d4371c4d8041fb","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                router_gateway_policy_binding \u003d ("},{"line_number":105,"context_line":"                    self._get_router_gateway_policy_binding("},{"line_number":106,"context_line":"                        context, rtr[\u0027id\u0027]))"},{"line_number":107,"context_line":"                qos_policy_id \u003d None"},{"line_number":108,"context_line":"                if router_gateway_policy_binding:"},{"line_number":109,"context_line":"                    qos_policy_id \u003d router_gateway_policy_binding.policy_id"},{"line_number":110,"context_line":"                rtr[\u0027gw_port\u0027][qos_consts.QOS_POLICY_ID] \u003d qos_policy_id"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_ce898726","line":107,"range":{"start_line":107,"start_character":16,"end_line":107,"end_character":36},"updated":"2018-06-08 16:36:04.000000000","message":"this can be removed and L110 can be modified as\nrtr[\u0027gw_port\u0027][qos_consts.QOS_POLICY_ID] \u003d qos_policy_id or None \n\nNote: this comment don\u0027t contribute to -1 for this patch","commit_id":"cfca0b7b48383dc2e6dca1fd3e61f9d9ef4b846c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"194dc71ce61e4223c3dfe5fb70b6bf2a54e52bae","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                router_gateway_policy_binding \u003d ("},{"line_number":105,"context_line":"                    self._get_router_gateway_policy_binding("},{"line_number":106,"context_line":"                        context, rtr[\u0027id\u0027]))"},{"line_number":107,"context_line":"                qos_policy_id \u003d None"},{"line_number":108,"context_line":"                if router_gateway_policy_binding:"},{"line_number":109,"context_line":"                    qos_policy_id \u003d router_gateway_policy_binding.policy_id"},{"line_number":110,"context_line":"                rtr[\u0027gw_port\u0027][qos_consts.QOS_POLICY_ID] \u003d qos_policy_id"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_af4f4933","line":107,"range":{"start_line":107,"start_character":16,"end_line":107,"end_character":36},"in_reply_to":"5f7c97a3_53fbd7bc","updated":"2018-06-11 11:26:36.000000000","message":"This can not work: http://logs.openstack.org/68/424468/14/check/neutron-functional/9764bde/logs/testr_results.html.gz","commit_id":"cfca0b7b48383dc2e6dca1fd3e61f9d9ef4b846c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"58bf3ff58df6d9511bf185584468a25a205d0f4a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                router_gateway_policy_binding \u003d ("},{"line_number":105,"context_line":"                    self._get_router_gateway_policy_binding("},{"line_number":106,"context_line":"                        context, rtr[\u0027id\u0027]))"},{"line_number":107,"context_line":"                qos_policy_id \u003d None"},{"line_number":108,"context_line":"                if router_gateway_policy_binding:"},{"line_number":109,"context_line":"                    qos_policy_id \u003d router_gateway_policy_binding.policy_id"},{"line_number":110,"context_line":"                rtr[\u0027gw_port\u0027][qos_consts.QOS_POLICY_ID] \u003d qos_policy_id"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_53fbd7bc","line":107,"range":{"start_line":107,"start_character":16,"end_line":107,"end_character":36},"in_reply_to":"5f7c97a3_ce898726","updated":"2018-06-09 12:05:17.000000000","message":"Done","commit_id":"cfca0b7b48383dc2e6dca1fd3e61f9d9ef4b846c"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"7c41269a0639763d54acb6fbc1d4371c4d8041fb","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        return routers"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"class gateway_ip_qos_db_mixin(gateway_ip_qos_dbonly_mixin,"},{"line_number":115,"context_line":"                              l3_db.L3_NAT_db_mixin):"},{"line_number":116,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_eec00353","line":114,"range":{"start_line":114,"start_character":6,"end_line":114,"end_character":29},"updated":"2018-06-08 16:36:04.000000000","message":"pascal case ?","commit_id":"cfca0b7b48383dc2e6dca1fd3e61f9d9ef4b846c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"58bf3ff58df6d9511bf185584468a25a205d0f4a","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        return routers"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"class gateway_ip_qos_db_mixin(gateway_ip_qos_dbonly_mixin,"},{"line_number":115,"context_line":"                              l3_db.L3_NAT_db_mixin):"},{"line_number":116,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_f32d4346","line":114,"range":{"start_line":114,"start_character":6,"end_line":114,"end_character":29},"in_reply_to":"5f7c97a3_eec00353","updated":"2018-06-09 12:05:17.000000000","message":"Done","commit_id":"cfca0b7b48383dc2e6dca1fd3e61f9d9ef4b846c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e6449098d8be5b2ece099fc630bc300adac16f01","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                {qos_consts.QOS_POLICY_ID: policy_id})"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @property"},{"line_number":47,"context_line":"    def _is_gw_ip_qos_supported(self):"},{"line_number":48,"context_line":"        if self._gw_ip_qos is None:"},{"line_number":49,"context_line":"            # Check L3 service plugin"},{"line_number":50,"context_line":"            self._gw_ip_qos \u003d extensions.is_extension_supported("}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_51d048c8","line":47,"updated":"2018-09-09 07:49:04.000000000","message":"property should be IMO named using noun, so for example \"gw_ip_qos_supported\"","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"8bd672378936f1f9c003ab244292137e2d7ae234","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                {qos_consts.QOS_POLICY_ID: policy_id})"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @property"},{"line_number":47,"context_line":"    def _is_gw_ip_qos_supported(self):"},{"line_number":48,"context_line":"        if self._gw_ip_qos is None:"},{"line_number":49,"context_line":"            # Check L3 service plugin"},{"line_number":50,"context_line":"            self._gw_ip_qos \u003d extensions.is_extension_supported("}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_9d5fce0d","line":47,"in_reply_to":"3f79a3b5_51d048c8","updated":"2018-09-10 01:11:43.000000000","message":"Here is similar to these properties:\nhttps://github.com/openstack/neutron/blob/master/neutron/db/l3_db.py#L110\nhttps://github.com/openstack/neutron/blob/master/neutron/db/l3_db.py#L120","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e6449098d8be5b2ece099fc630bc300adac16f01","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Calls superclass, pass router db object for avoiding re-loading"},{"line_number":68,"context_line":"        super(L3_gw_ip_qos_dbonly_mixin, self)._update_router_gw_info("},{"line_number":69,"context_line":"            context, router_id, info, router)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if self._is_gw_ip_qos_supported and router.gw_port:"},{"line_number":72,"context_line":"            self._check_and_update_router_gw(context, router_id, info, router)"}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_31e6ecb1","line":69,"updated":"2018-09-09 07:49:04.000000000","message":"You can probably do something like:\n\n    router \u003d super(L3_gw_ip_qos_dbonly_mixin, self)._update_router_gw_info(\n            context, router_id, info, router)\n\nand then L64-65 will not be necessary","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"8bd672378936f1f9c003ab244292137e2d7ae234","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Calls superclass, pass router db object for avoiding re-loading"},{"line_number":68,"context_line":"        super(L3_gw_ip_qos_dbonly_mixin, self)._update_router_gw_info("},{"line_number":69,"context_line":"            context, router_id, info, router)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if self._is_gw_ip_qos_supported and router.gw_port:"},{"line_number":72,"context_line":"            self._check_and_update_router_gw(context, router_id, info, router)"}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_bd5aca1a","line":69,"in_reply_to":"3f79a3b5_31e6ecb1","updated":"2018-09-10 01:11:43.000000000","message":"Done","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"70799843b10d9dffd66251281492f91bcb9ea8c8","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Calls superclass, pass router db object for avoiding re-loading"},{"line_number":68,"context_line":"        super(L3_gw_ip_qos_dbonly_mixin, self)._update_router_gw_info("},{"line_number":69,"context_line":"            context, router_id, info, router)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if self._is_gw_ip_qos_supported and router.gw_port:"},{"line_number":72,"context_line":"            self._check_and_update_router_gw(context, router_id, info, router)"}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_3ee7bf11","line":69,"in_reply_to":"3f79a3b5_bd5aca1a","updated":"2018-09-20 00:52:53.000000000","message":"done","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"7f3a6d84c603934c7e461428433054fb0f64f945","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        super(L3_gw_ip_qos_dbonly_mixin, self)._update_router_gw_info("},{"line_number":69,"context_line":"            context, router_id, info, router)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if self._is_gw_ip_qos_supported and router.gw_port:"},{"line_number":72,"context_line":"            self._check_and_update_router_gw(context, router_id, info, router)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        return router"}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_7a78037d","line":71,"range":{"start_line":71,"start_character":44,"end_line":71,"end_character":58},"updated":"2018-09-18 18:48:46.000000000","message":"If the request is to clear the router gateway, router.gw_port will be None so we won\u0027t proceed to _check_and_update_router_gw in here? The problem is that the qos_policy_id in the db won\u0027t be clean up properly since _delete_gw_ip_qos_db is never called.","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4986ef84632c3fd1a70dfe33351bfcfea9d93b16","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        super(L3_gw_ip_qos_dbonly_mixin, self)._update_router_gw_info("},{"line_number":69,"context_line":"            context, router_id, info, router)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if self._is_gw_ip_qos_supported and router.gw_port:"},{"line_number":72,"context_line":"            self._check_and_update_router_gw(context, router_id, info, router)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        return router"}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_ef5d2f16","line":71,"range":{"start_line":71,"start_character":44,"end_line":71,"end_character":58},"in_reply_to":"3f79a3b5_7a78037d","updated":"2018-09-19 01:56:50.000000000","message":"Yes, my original thoughts is keeping that binding until the router was deleted. If user reset the gateway, it can reuse the original policy binding, and the policy_id can be changed during the reset gateway.\nSo unless user unset the router gateway qos policy explicitly, we keep the qos binding to save some duplicated re-binding work.\nMaybe I should add some notes here .","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"75d85880c5deeec67bf787b6eff3f5d444a7f7ac","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            context, router_id, info, router)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if self._is_gw_ip_qos_supported and router.gw_port:"},{"line_number":72,"context_line":"            self._check_and_update_router_gw(context, router_id, info, router)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        return router"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_c848782f","line":72,"range":{"start_line":72,"start_character":17,"end_line":72,"end_character":44},"updated":"2018-09-18 18:06:49.000000000","message":"IMHO, we can rename this method to make it clear that this method is for updating the qos policy. How about something like _update_router_gw_qos_policy?","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4986ef84632c3fd1a70dfe33351bfcfea9d93b16","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            context, router_id, info, router)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if self._is_gw_ip_qos_supported and router.gw_port:"},{"line_number":72,"context_line":"            self._check_and_update_router_gw(context, router_id, info, router)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        return router"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_cf3ab396","line":72,"range":{"start_line":72,"start_character":17,"end_line":72,"end_character":44},"in_reply_to":"3f79a3b5_c848782f","updated":"2018-09-19 01:56:50.000000000","message":"Done, will change it.","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"70799843b10d9dffd66251281492f91bcb9ea8c8","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            context, router_id, info, router)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if self._is_gw_ip_qos_supported and router.gw_port:"},{"line_number":72,"context_line":"            self._check_and_update_router_gw(context, router_id, info, router)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        return router"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_febe27d2","line":72,"range":{"start_line":72,"start_character":17,"end_line":72,"end_character":44},"in_reply_to":"3f79a3b5_cf3ab396","updated":"2018-09-20 00:52:53.000000000","message":"done","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"75d85880c5deeec67bf787b6eff3f5d444a7f7ac","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        router \u003d self._get_router(context, router_id)"},{"line_number":78,"context_line":"        return router.qos_policy_binding"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _check_and_update_router_gw(self, context, router_id, info, router):"},{"line_number":81,"context_line":"        if not info or qos_consts.QOS_POLICY_ID not in info:"},{"line_number":82,"context_line":"            return"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_0393b1a4","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":35},"updated":"2018-09-18 18:06:49.000000000","message":"A suggestion here. Perhaps, it incurs a significant re-writing of code so I am fine to treat it as future work.\n\nIn the light of adopting OVO for hiding DB access code [1], I think it is better to include qos_policy_id as part of the router object (as what we currently did for network [2]). Then, most of the implementation of this method can be moved to the OVO object. Ideally, the router object should encapsulate and hide the logic to read/write the qos_policy_id from/to DB.\n\n[1] https://blueprints.launchpad.net/neutron/+spec/adopt-oslo-versioned-objects-for-db\n[2] https://github.com/openstack/neutron/blob/ef3344767a1367cf576344c798b7aa4e417962a7/neutron/objects/network.py#L217","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4986ef84632c3fd1a70dfe33351bfcfea9d93b16","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        router \u003d self._get_router(context, router_id)"},{"line_number":78,"context_line":"        return router.qos_policy_binding"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _check_and_update_router_gw(self, context, router_id, info, router):"},{"line_number":81,"context_line":"        if not info or qos_consts.QOS_POLICY_ID not in info:"},{"line_number":82,"context_line":"            return"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_2fc48791","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":35},"in_reply_to":"3f79a3b5_0393b1a4","updated":"2018-09-19 01:56:50.000000000","message":"Yes, it make sense to me. But for now seems there is no router gateway OVO object (correct me if I\u0027m wrong), and add qos_policy_id to router seems too aggressive for it, since this policy is only used for router gateway IPs.","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"4d36e2624d01383ea7015c36fad652c1ab468f7c","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _check_and_update_router_gw(self, context, router_id, info, router):"},{"line_number":81,"context_line":"        if not info or qos_consts.QOS_POLICY_ID not in info:"},{"line_number":82,"context_line":"            return"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        new_qos_policy_id \u003d info.get(qos_consts.QOS_POLICY_ID)"},{"line_number":85,"context_line":"        if router.qos_policy_binding:"}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_1a4c6f3d","line":82,"range":{"start_line":82,"start_character":12,"end_line":82,"end_character":18},"updated":"2018-09-18 19:29:41.000000000","message":"Should we proceed to delete the gateway IP qos policy in this case?","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4986ef84632c3fd1a70dfe33351bfcfea9d93b16","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _check_and_update_router_gw(self, context, router_id, info, router):"},{"line_number":81,"context_line":"        if not info or qos_consts.QOS_POLICY_ID not in info:"},{"line_number":82,"context_line":"            return"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        new_qos_policy_id \u003d info.get(qos_consts.QOS_POLICY_ID)"},{"line_number":85,"context_line":"        if router.qos_policy_binding:"}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_8f403b08","line":82,"range":{"start_line":82,"start_character":12,"end_line":82,"end_character":18},"in_reply_to":"3f79a3b5_1a4c6f3d","updated":"2018-09-19 01:56:50.000000000","message":"Please see my comments above Line 72.","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e6449098d8be5b2ece099fc630bc300adac16f01","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        if not info or qos_consts.QOS_POLICY_ID not in info:"},{"line_number":82,"context_line":"            return"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        new_qos_policy_id \u003d info.get(qos_consts.QOS_POLICY_ID)"},{"line_number":85,"context_line":"        if router.qos_policy_binding:"},{"line_number":86,"context_line":"            old_qos_policy_id \u003d router.qos_policy_binding.policy_id"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_51e9287c","line":84,"updated":"2018-09-09 07:49:04.000000000","message":"You can use\n\n    info[qos_const.QOS_POLICY_ID]\n\nhere as You already checked that this key is in info above","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"8bd672378936f1f9c003ab244292137e2d7ae234","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        if not info or qos_consts.QOS_POLICY_ID not in info:"},{"line_number":82,"context_line":"            return"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        new_qos_policy_id \u003d info.get(qos_consts.QOS_POLICY_ID)"},{"line_number":85,"context_line":"        if router.qos_policy_binding:"},{"line_number":86,"context_line":"            old_qos_policy_id \u003d router.qos_policy_binding.policy_id"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_9db4ae37","line":84,"in_reply_to":"3f79a3b5_51e9287c","updated":"2018-09-10 01:11:43.000000000","message":"Done","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"70799843b10d9dffd66251281492f91bcb9ea8c8","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        if not info or qos_consts.QOS_POLICY_ID not in info:"},{"line_number":82,"context_line":"            return"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        new_qos_policy_id \u003d info.get(qos_consts.QOS_POLICY_ID)"},{"line_number":85,"context_line":"        if router.qos_policy_binding:"},{"line_number":86,"context_line":"            old_qos_policy_id \u003d router.qos_policy_binding.policy_id"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_9eb13304","line":84,"in_reply_to":"3f79a3b5_9db4ae37","updated":"2018-09-20 00:52:53.000000000","message":"done","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"75d85880c5deeec67bf787b6eff3f5d444a7f7ac","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                                          router_id,"},{"line_number":93,"context_line":"                                          old_qos_policy_id)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":96,"context_line":"            context.session.refresh(router)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        if new_qos_policy_id:"}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_2057d503","line":95,"range":{"start_line":95,"start_character":29,"end_line":95,"end_character":34},"updated":"2018-09-18 18:06:49.000000000","message":"So, it looks _delete_gw_ip_qos_db and _create_gw_ip_qos_db are done in two separated db transaction? If yes, my question is whether it is possible combine them into a single transaction so that this operation is more atomic?","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4986ef84632c3fd1a70dfe33351bfcfea9d93b16","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                                          router_id,"},{"line_number":93,"context_line":"                                          old_qos_policy_id)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":96,"context_line":"            context.session.refresh(router)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        if new_qos_policy_id:"}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_cfa4f3bb","line":95,"range":{"start_line":95,"start_character":29,"end_line":95,"end_character":34},"in_reply_to":"3f79a3b5_2057d503","updated":"2018-09-19 01:56:50.000000000","message":"This transaction here is to reload router DB object with new (or remove) the policy attribute. And for clear router gateway policy, here will only call `delete`. And the `create` and `delete` db transaction seems implicitly in the OVO object, see line 56 and 60. So the combine seems not necessary.","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e6449098d8be5b2ece099fc630bc300adac16f01","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        if not self._is_gw_ip_qos_supported:"},{"line_number":108,"context_line":"            return routers"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        for rtr in routers:"},{"line_number":111,"context_line":"            gw_port_id \u003d rtr[\u0027gw_port_id\u0027]"},{"line_number":112,"context_line":"            # Collect gw ports only if available"},{"line_number":113,"context_line":"            if gw_port_id and gw_ports.get(gw_port_id):"}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_d1f45857","line":110,"range":{"start_line":110,"start_character":12,"end_line":110,"end_character":15},"updated":"2018-09-09 07:49:04.000000000","message":"nit: this shortcut is IMO not necessary","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"8bd672378936f1f9c003ab244292137e2d7ae234","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        if not self._is_gw_ip_qos_supported:"},{"line_number":108,"context_line":"            return routers"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        for rtr in routers:"},{"line_number":111,"context_line":"            gw_port_id \u003d rtr[\u0027gw_port_id\u0027]"},{"line_number":112,"context_line":"            # Collect gw ports only if available"},{"line_number":113,"context_line":"            if gw_port_id and gw_ports.get(gw_port_id):"}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_5d9b76c7","line":110,"range":{"start_line":110,"start_character":12,"end_line":110,"end_character":15},"in_reply_to":"3f79a3b5_d1f45857","updated":"2018-09-10 01:11:43.000000000","message":"Something similar to this line:\nhttps://github.com/openstack/neutron/blob/master/neutron/db/l3_gwmode_db.py#L90","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a01c0b793d2375367b8177e923058fbc25fe2adc","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                self, qos_gateway_ip.ALIAS)"},{"line_number":52,"context_line":"        return self._gw_ip_qos"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def _create_gw_ip_qos_db(self, context, router_id, policy_id):"},{"line_number":55,"context_line":"        policy \u003d policy_object.QosPolicy.get_policy_obj(context, policy_id)"},{"line_number":56,"context_line":"        policy.attach_router(router_id)"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"3f79a3b5_398827c4","line":54,"range":{"start_line":54,"start_character":9,"end_line":54,"end_character":28},"updated":"2018-09-20 21:35:27.000000000","message":"its more of a attach, may be _attach_qos_to_router or _attach_qos_to_gw would make easy for reviewers to understand the purpose.\n\nNote: This comment won\u0027t contribute to -1 if given.","commit_id":"48f81c35eedeb86aa71db0b5c917b795632bb101"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"60a4804bd843f5a386e464b51b9c68fd198086a5","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                self, qos_gateway_ip.ALIAS)"},{"line_number":52,"context_line":"        return self._gw_ip_qos"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def _create_gw_ip_qos_db(self, context, router_id, policy_id):"},{"line_number":55,"context_line":"        policy \u003d policy_object.QosPolicy.get_policy_obj(context, policy_id)"},{"line_number":56,"context_line":"        policy.attach_router(router_id)"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"3f79a3b5_d0a77da7","line":54,"range":{"start_line":54,"start_character":9,"end_line":54,"end_character":28},"in_reply_to":"3f79a3b5_398827c4","updated":"2018-09-21 02:52:30.000000000","message":"Let\u0027s do not mixed the function name with QosPolicy object.","commit_id":"48f81c35eedeb86aa71db0b5c917b795632bb101"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a01c0b793d2375367b8177e923058fbc25fe2adc","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        policy \u003d policy_object.QosPolicy.get_policy_obj(context, policy_id)"},{"line_number":56,"context_line":"        policy.attach_router(router_id)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _delete_gw_ip_qos_db(self, context, router_id, policy_id):"},{"line_number":59,"context_line":"        policy \u003d policy_object.QosPolicy.get_policy_obj(context, policy_id)"},{"line_number":60,"context_line":"        policy.detach_router(router_id)"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"3f79a3b5_99b61b89","line":58,"range":{"start_line":58,"start_character":9,"end_line":58,"end_character":28},"updated":"2018-09-20 21:35:27.000000000","message":"same here _detach_qos_from_gw/router.\n\nNote: this comment won\u0027t contribute to -1 if given.","commit_id":"48f81c35eedeb86aa71db0b5c917b795632bb101"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"60a4804bd843f5a386e464b51b9c68fd198086a5","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        policy \u003d policy_object.QosPolicy.get_policy_obj(context, policy_id)"},{"line_number":56,"context_line":"        policy.attach_router(router_id)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _delete_gw_ip_qos_db(self, context, router_id, policy_id):"},{"line_number":59,"context_line":"        policy \u003d policy_object.QosPolicy.get_policy_obj(context, policy_id)"},{"line_number":60,"context_line":"        policy.detach_router(router_id)"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"3f79a3b5_90b7c5d8","line":58,"range":{"start_line":58,"start_character":9,"end_line":58,"end_character":28},"in_reply_to":"3f79a3b5_99b61b89","updated":"2018-09-21 02:52:30.000000000","message":"ditto","commit_id":"48f81c35eedeb86aa71db0b5c917b795632bb101"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a01c0b793d2375367b8177e923058fbc25fe2adc","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            # to be done, then directly return here."},{"line_number":84,"context_line":"            return"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        new_qos_policy_id \u003d info[qos_consts.QOS_POLICY_ID]"},{"line_number":87,"context_line":"        if router.qos_policy_binding:"},{"line_number":88,"context_line":"            old_qos_policy_id \u003d router.qos_policy_binding.policy_id"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"3f79a3b5_5fc0637c","line":86,"range":{"start_line":86,"start_character":28,"end_line":86,"end_character":58},"updated":"2018-09-20 21:35:27.000000000","message":"info.get(qos_consts.QOS_POLICY_ID) to be safe for L100","commit_id":"48f81c35eedeb86aa71db0b5c917b795632bb101"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"60a4804bd843f5a386e464b51b9c68fd198086a5","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            # to be done, then directly return here."},{"line_number":84,"context_line":"            return"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        new_qos_policy_id \u003d info[qos_consts.QOS_POLICY_ID]"},{"line_number":87,"context_line":"        if router.qos_policy_binding:"},{"line_number":88,"context_line":"            old_qos_policy_id \u003d router.qos_policy_binding.policy_id"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"3f79a3b5_10941543","line":86,"range":{"start_line":86,"start_character":28,"end_line":86,"end_character":58},"in_reply_to":"3f79a3b5_5fc0637c","updated":"2018-09-21 02:52:30.000000000","message":"Line 79 ensure that, and just rewrite to this as Slawek Kaplonski suggested here:\nhttps://review.openstack.org/#/c/424468/24/neutron/db/l3_gateway_ip_qos.py@84","commit_id":"48f81c35eedeb86aa71db0b5c917b795632bb101"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a01c0b793d2375367b8177e923058fbc25fe2adc","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        for rtr in routers:"},{"line_number":113,"context_line":"            gw_port_id \u003d rtr[\u0027gw_port_id\u0027]"},{"line_number":114,"context_line":"            # Collect gw ports only if available"},{"line_number":115,"context_line":"            if gw_port_id and gw_ports.get(gw_port_id):"},{"line_number":116,"context_line":"                rtr[\u0027gw_port\u0027] \u003d gw_ports[gw_port_id]"},{"line_number":117,"context_line":"                router_gateway_policy_binding \u003d ("},{"line_number":118,"context_line":"                    self._get_router_gateway_policy_binding("}],"source_content_type":"text/x-python","patch_set":26,"id":"3f79a3b5_bf5f37e3","line":115,"range":{"start_line":115,"start_character":15,"end_line":115,"end_character":54},"updated":"2018-09-20 21:35:27.000000000","message":"what if these id\u0027s are different ?","commit_id":"48f81c35eedeb86aa71db0b5c917b795632bb101"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"60a4804bd843f5a386e464b51b9c68fd198086a5","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        for rtr in routers:"},{"line_number":113,"context_line":"            gw_port_id \u003d rtr[\u0027gw_port_id\u0027]"},{"line_number":114,"context_line":"            # Collect gw ports only if available"},{"line_number":115,"context_line":"            if gw_port_id and gw_ports.get(gw_port_id):"},{"line_number":116,"context_line":"                rtr[\u0027gw_port\u0027] \u003d gw_ports[gw_port_id]"},{"line_number":117,"context_line":"                router_gateway_policy_binding \u003d ("},{"line_number":118,"context_line":"                    self._get_router_gateway_policy_binding("}],"source_content_type":"text/x-python","patch_set":26,"id":"3f79a3b5_b08c4135","line":115,"range":{"start_line":115,"start_character":15,"end_line":115,"end_character":54},"in_reply_to":"3f79a3b5_bf5f37e3","updated":"2018-09-21 02:52:30.000000000","message":"Similar code here: https://github.com/openstack/neutron/blob/master/neutron/db/l3_gwmode_db.py#L91-L93\n\nAFAIK, the router gateway will never change such port id.","commit_id":"48f81c35eedeb86aa71db0b5c917b795632bb101"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a01c0b793d2375367b8177e923058fbc25fe2adc","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                qos_policy_id \u003d None"},{"line_number":121,"context_line":"                if router_gateway_policy_binding:"},{"line_number":122,"context_line":"                    qos_policy_id \u003d router_gateway_policy_binding.policy_id"},{"line_number":123,"context_line":"                rtr[\u0027gw_port\u0027][qos_consts.QOS_POLICY_ID] \u003d qos_policy_id"},{"line_number":124,"context_line":"        return routers"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"3f79a3b5_3f732782","line":123,"range":{"start_line":123,"start_character":59,"end_line":123,"end_character":72},"updated":"2018-09-20 21:35:27.000000000","message":"qos_policy_id or None then L120 can be removed.","commit_id":"48f81c35eedeb86aa71db0b5c917b795632bb101"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"60a4804bd843f5a386e464b51b9c68fd198086a5","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                qos_policy_id \u003d None"},{"line_number":121,"context_line":"                if router_gateway_policy_binding:"},{"line_number":122,"context_line":"                    qos_policy_id \u003d router_gateway_policy_binding.policy_id"},{"line_number":123,"context_line":"                rtr[\u0027gw_port\u0027][qos_consts.QOS_POLICY_ID] \u003d qos_policy_id"},{"line_number":124,"context_line":"        return routers"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"3f79a3b5_107df51a","line":123,"range":{"start_line":123,"start_character":59,"end_line":123,"end_character":72},"in_reply_to":"3f79a3b5_3f732782","updated":"2018-09-21 02:52:30.000000000","message":"No, if line 121 check failed, the `qos_policy_id` will be unknow.","commit_id":"48f81c35eedeb86aa71db0b5c917b795632bb101"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a01c0b793d2375367b8177e923058fbc25fe2adc","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class L3_gw_ip_qos_db_mixin(L3_gw_ip_qos_dbonly_mixin,"},{"line_number":128,"context_line":"                            l3_db.L3_NAT_db_mixin):"},{"line_number":129,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f79a3b5_b9ef5785","line":129,"range":{"start_line":128,"start_character":2,"end_line":129,"end_character":8},"updated":"2018-09-20 21:35:27.000000000","message":"leaving a comment about why this inherited class is needed would help developers later !","commit_id":"48f81c35eedeb86aa71db0b5c917b795632bb101"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"60a4804bd843f5a386e464b51b9c68fd198086a5","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class L3_gw_ip_qos_db_mixin(L3_gw_ip_qos_dbonly_mixin,"},{"line_number":128,"context_line":"                            l3_db.L3_NAT_db_mixin):"},{"line_number":129,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f79a3b5_70b0e9dc","line":129,"range":{"start_line":128,"start_character":2,"end_line":129,"end_character":8},"in_reply_to":"3f79a3b5_b9ef5785","updated":"2018-09-21 02:52:30.000000000","message":"OK, will do that once I rebase the patch.","commit_id":"48f81c35eedeb86aa71db0b5c917b795632bb101"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7edc5800ac9ebde6ca98aea9d45f14fd71c07823","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _get_router_gateway_policy_binding(self, context, router_id):"},{"line_number":75,"context_line":"        router \u003d self._get_router(context, router_id)"},{"line_number":76,"context_line":"        return router.qos_policy_binding"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _update_router_gw_qos_policy(self, context, router_id, info, router):"},{"line_number":79,"context_line":"        if not info or qos_consts.QOS_POLICY_ID not in info:"}],"source_content_type":"text/x-python","patch_set":30,"id":"3f79a3b5_72d67b29","line":76,"updated":"2018-10-18 08:36:01.000000000","message":"can it be that router object don\u0027t have \"qos_policy_binding\"? Like You assumed probably in L41?","commit_id":"362c8938677fc14e1aecf0fed5f25e5d28310fd2"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0dd0f526da68fbc3a751c07552697e4ef379edbf","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _get_router_gateway_policy_binding(self, context, router_id):"},{"line_number":75,"context_line":"        router \u003d self._get_router(context, router_id)"},{"line_number":76,"context_line":"        return router.qos_policy_binding"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _update_router_gw_qos_policy(self, context, router_id, info, router):"},{"line_number":79,"context_line":"        if not info or qos_consts.QOS_POLICY_ID not in info:"}],"source_content_type":"text/x-python","patch_set":30,"id":"3f79a3b5_f8ffcd66","line":76,"in_reply_to":"3f79a3b5_72d67b29","updated":"2018-10-18 09:32:13.000000000","message":"If this extension is enabled, this router_db\u0027s qos_policy_binding will be None or the binding object. It will have that qos_policy_binding attribute.\nLine 41 is to verify whether it is None, if not then Line 42 can work. Here is only used for Line 118, if it is not None then Line 122 can work. All these two places are to ensure that we are not trying to get the attribute (policy_id) from a None object.","commit_id":"362c8938677fc14e1aecf0fed5f25e5d28310fd2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d4fee2a42163e0f05db4fcc1572abb3fb12d87b9","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        if new_qos_policy_id:"},{"line_number":101,"context_line":"            self._create_gw_ip_qos_db("},{"line_number":102,"context_line":"                context, router_id, new_qos_policy_id)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def _build_routers_list(self, context, routers, gw_ports):"},{"line_number":105,"context_line":"        routers \u003d super(L3_gw_ip_qos_dbonly_mixin,"}],"source_content_type":"text/x-python","patch_set":33,"id":"3f79a3b5_b0ba2fdd","line":102,"updated":"2018-11-26 12:16:21.000000000","message":"At this point, I don\u0027t know if the router will have the qos policy information. The DB will be updated, but not the \"router\" object.","commit_id":"99901f761d12e1488f8ca2039422ea1409cb218a"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"5dae8b9343298816b53008211ef689f998356a76","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        if new_qos_policy_id:"},{"line_number":101,"context_line":"            self._create_gw_ip_qos_db("},{"line_number":102,"context_line":"                context, router_id, new_qos_policy_id)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def _build_routers_list(self, context, routers, gw_ports):"},{"line_number":105,"context_line":"        routers \u003d super(L3_gw_ip_qos_dbonly_mixin,"}],"source_content_type":"text/x-python","patch_set":33,"id":"3f79a3b5_eb3afc2f","line":102,"in_reply_to":"3f79a3b5_b0ba2fdd","updated":"2018-11-26 13:37:25.000000000","message":"Line 39 extend the router API dict. Router object does not have the qos policy information, it is in the router gateway info.","commit_id":"99901f761d12e1488f8ca2039422ea1409cb218a"}],"neutron/db/l3_gwmode_db.py":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"75d85880c5deeec67bf787b6eff3f5d444a7f7ac","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def _extend_router_dict_gw_mode(router_res, router_db):"},{"line_number":46,"context_line":"        if router_db.gw_port_id:"},{"line_number":47,"context_line":"            nw_id \u003d router_db.gw_port[\u0027network_id\u0027]"},{"line_number":48,"context_line":"            router_res[l3_apidef.EXTERNAL_GW_INFO].update({"},{"line_number":49,"context_line":"                \u0027network_id\u0027: nw_id,"},{"line_number":50,"context_line":"                \u0027enable_snat\u0027: router_db.enable_snat,"},{"line_number":51,"context_line":"                \u0027external_fixed_ips\u0027: ["}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_749ed9b8","line":48,"range":{"start_line":48,"start_character":23,"end_line":48,"end_character":49},"updated":"2018-09-18 18:06:49.000000000","message":"Just wondering. Are you sure this key is pre-existed?","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4986ef84632c3fd1a70dfe33351bfcfea9d93b16","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def _extend_router_dict_gw_mode(router_res, router_db):"},{"line_number":46,"context_line":"        if router_db.gw_port_id:"},{"line_number":47,"context_line":"            nw_id \u003d router_db.gw_port[\u0027network_id\u0027]"},{"line_number":48,"context_line":"            router_res[l3_apidef.EXTERNAL_GW_INFO].update({"},{"line_number":49,"context_line":"                \u0027network_id\u0027: nw_id,"},{"line_number":50,"context_line":"                \u0027enable_snat\u0027: router_db.enable_snat,"},{"line_number":51,"context_line":"                \u0027external_fixed_ips\u0027: ["}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_cf2e33f9","line":48,"range":{"start_line":48,"start_character":23,"end_line":48,"end_character":49},"in_reply_to":"3f79a3b5_749ed9b8","updated":"2018-09-19 01:56:50.000000000","message":"This line:\nhttps://github.com/openstack/neutron/blob/master/neutron/db/l3_db.py#L205","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"}],"neutron/db/migration/alembic_migrations/versions/newton/expand/195176fb410d_router_port_rate_limit.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"64cead1ca8422378c1d93bef6299ec46bcd14b34","unresolved":false,"context_lines":[{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    op.add_column(\u0027routerports\u0027, sa.Column(u\u0027rate_limit\u0027,"},{"line_number":34,"context_line":"                                           sa.Integer(), autoincrement\u003dFalse,"},{"line_number":35,"context_line":"                                           nullable\u003dFalse, default\u003d0))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_f692fbf4","line":35,"range":{"start_line":35,"start_character":59,"end_line":35,"end_character":68},"updated":"2017-01-24 07:20:29.000000000","message":"default is useless in migrations, use server_default instead. For reference http://docs.openstack.org/developer/neutron/devref/db_layer.html#difference-between-default-and-server-default-parameters-for-columns","commit_id":"36484eaefc3d97b8e868d687dce85ece3c433ae8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"16ed1eb4b84be42efef3d51e4eeb55dccdddbafe","unresolved":false,"context_lines":[{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    op.add_column(\u0027routerports\u0027, sa.Column(u\u0027rate_limit\u0027,"},{"line_number":34,"context_line":"                                           sa.Integer(), autoincrement\u003dFalse,"},{"line_number":35,"context_line":"                                           nullable\u003dFalse, default\u003d0))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_f0ed55f0","line":35,"range":{"start_line":35,"start_character":59,"end_line":35,"end_character":68},"in_reply_to":"5a3905b3_f692fbf4","updated":"2017-01-25 13:03:40.000000000","message":"Done","commit_id":"36484eaefc3d97b8e868d687dce85ece3c433ae8"}],"neutron/db/migration/alembic_migrations/versions/rocky/expand/195176fb410d_router_gateway_ip_qos.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9d86dfcc4a46c96bbbc2bd949d63b0a9b6ace98f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"revision \u003d \u0027195176fb410d\u0027"},{"line_number":34,"context_line":"down_revision \u003d \u002761663558142c\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# milestone identifier, used by neutron-db-manage"},{"line_number":37,"context_line":"neutron_milestone \u003d [migration.ROCKY]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def upgrade():"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_1cb61427","line":37,"range":{"start_line":36,"start_character":0,"end_line":37,"end_character":37},"updated":"2018-07-13 11:44:31.000000000","message":"we don\u0027t update milestones in every patches","commit_id":"f03ad5a8304548fbfeaf563a8c9edc0d713b128d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"7df3f127adeafe7f72887fc0306de1f6f5d394b7","unresolved":false,"context_lines":[{"line_number":33,"context_line":"revision \u003d \u0027195176fb410d\u0027"},{"line_number":34,"context_line":"down_revision \u003d \u002761663558142c\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# milestone identifier, used by neutron-db-manage"},{"line_number":37,"context_line":"neutron_milestone \u003d [migration.ROCKY]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def upgrade():"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_fb4c63ca","line":37,"range":{"start_line":36,"start_character":0,"end_line":37,"end_character":37},"in_reply_to":"5f7c97a3_1cb61427","updated":"2018-07-16 02:26:54.000000000","message":"Done","commit_id":"f03ad5a8304548fbfeaf563a8c9edc0d713b128d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c076af052c8add88fcb97fa557d443f865d48411","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        sa.Column(\u0027router_id\u0027,"},{"line_number":43,"context_line":"                  sa.String(length\u003ddb_const.UUID_FIELD_SIZE),"},{"line_number":44,"context_line":"                  sa.ForeignKey(\u0027routers.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":45,"context_line":"                  nullable\u003dFalse, unique\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":32,"id":"3f79a3b5_48f51a51","line":45,"updated":"2018-11-09 10:59:39.000000000","message":"I\u0027m not an sqlalchemy expert but shouldn\u0027t You declare that those columns are primary_key, like it is defined in db model?","commit_id":"3f48c465940a51139bd08552b194e7a5df17afe0"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"5dae8b9343298816b53008211ef689f998356a76","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        sa.Column(\u0027router_id\u0027,"},{"line_number":43,"context_line":"                  sa.String(length\u003ddb_const.UUID_FIELD_SIZE),"},{"line_number":44,"context_line":"                  sa.ForeignKey(\u0027routers.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":45,"context_line":"                  nullable\u003dFalse, unique\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":32,"id":"3f79a3b5_6b7d8ce3","line":45,"in_reply_to":"3f79a3b5_301b7f84","updated":"2018-11-26 13:37:25.000000000","message":"Forget this one...\nDone","commit_id":"3f48c465940a51139bd08552b194e7a5df17afe0"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a962204c642ea01a10ecd0ecfc81e3548555b34f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        sa.Column(\u0027router_id\u0027,"},{"line_number":43,"context_line":"                  sa.String(length\u003ddb_const.UUID_FIELD_SIZE),"},{"line_number":44,"context_line":"                  sa.ForeignKey(\u0027routers.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":45,"context_line":"                  nullable\u003dFalse, unique\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":32,"id":"3f79a3b5_d08d4829","line":45,"in_reply_to":"3f79a3b5_48f51a51","updated":"2018-11-09 17:11:48.000000000","message":"Fip qos policy binding was doing the same thing.\nhttps://github.com/openstack/neutron/blob/master/neutron/db/migration/alembic_migrations/versions/queens/expand/594422d373ee_fip_qos.py","commit_id":"3f48c465940a51139bd08552b194e7a5df17afe0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d4fee2a42163e0f05db4fcc1572abb3fb12d87b9","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        sa.Column(\u0027router_id\u0027,"},{"line_number":43,"context_line":"                  sa.String(length\u003ddb_const.UUID_FIELD_SIZE),"},{"line_number":44,"context_line":"                  sa.ForeignKey(\u0027routers.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":45,"context_line":"                  nullable\u003dFalse, unique\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":32,"id":"3f79a3b5_301b7f84","line":45,"in_reply_to":"3f79a3b5_d08d4829","updated":"2018-11-26 12:16:21.000000000","message":"But this is not correct (regardless of what has been done previously). Both declarations should be the same.","commit_id":"3f48c465940a51139bd08552b194e7a5df17afe0"}],"neutron/db/qos/models.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"7c41269a0639763d54acb6fbc1d4371c4d8041fb","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                               cascade\u003d\u0027delete\u0027, lazy\u003d\u0027joined\u0027))"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"class QosRouterGatewayIPPolicyBinding(model_base.BASEV2):"},{"line_number":80,"context_line":"    __tablename__ \u003d \u0027qos_router_gw_policy_bindings\u0027"},{"line_number":81,"context_line":"    policy_id \u003d sa.Column(sa.String(db_const.UUID_FIELD_SIZE),"},{"line_number":82,"context_line":"                          sa.ForeignKey(\u0027qos_policies.id\u0027,"},{"line_number":83,"context_line":"                                        ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":84,"context_line":"                          nullable\u003dFalse,"},{"line_number":85,"context_line":"                          primary_key\u003dTrue)"},{"line_number":86,"context_line":"    router_id \u003d sa.Column(sa.String(db_const.UUID_FIELD_SIZE),"},{"line_number":87,"context_line":"                       sa.ForeignKey(\u0027routers.id\u0027,"},{"line_number":88,"context_line":"                                     ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":89,"context_line":"                       nullable\u003dFalse,"},{"line_number":90,"context_line":"                       unique\u003dTrue,"},{"line_number":91,"context_line":"                       primary_key\u003dTrue)"},{"line_number":92,"context_line":"    revises_on_change \u003d (\u0027router\u0027, )"},{"line_number":93,"context_line":"    router \u003d sa.orm.relationship("},{"line_number":94,"context_line":"        l3.Router, load_on_pending\u003dTrue,"},{"line_number":95,"context_line":"        backref\u003dsa.orm.backref(\"qos_policy_binding\", uselist\u003dFalse,"},{"line_number":96,"context_line":"                               cascade\u003d\u0027delete\u0027, lazy\u003d\u0027joined\u0027))"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"class QosPortPolicyBinding(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_8e306f57","line":96,"range":{"start_line":79,"start_character":1,"end_line":96,"end_character":64},"updated":"2018-06-08 16:36:04.000000000","message":"as router has many ports and theoretically each port can have qos_policy, i don\u0027t get why this is even needed,\n\ngateway_port_id, policy can be retrieved from port_id ?\n\nIMO, router_gateway_id instead of router_id would make more sense, since each port can theoretically have qos_policy. this is specific to gateway port only ? Note: I am thinking of case when each router port would be allowed to have different qos policy.","commit_id":"cfca0b7b48383dc2e6dca1fd3e61f9d9ef4b846c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"58bf3ff58df6d9511bf185584468a25a205d0f4a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                               cascade\u003d\u0027delete\u0027, lazy\u003d\u0027joined\u0027))"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"class QosRouterGatewayIPPolicyBinding(model_base.BASEV2):"},{"line_number":80,"context_line":"    __tablename__ \u003d \u0027qos_router_gw_policy_bindings\u0027"},{"line_number":81,"context_line":"    policy_id \u003d sa.Column(sa.String(db_const.UUID_FIELD_SIZE),"},{"line_number":82,"context_line":"                          sa.ForeignKey(\u0027qos_policies.id\u0027,"},{"line_number":83,"context_line":"                                        ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":84,"context_line":"                          nullable\u003dFalse,"},{"line_number":85,"context_line":"                          primary_key\u003dTrue)"},{"line_number":86,"context_line":"    router_id \u003d sa.Column(sa.String(db_const.UUID_FIELD_SIZE),"},{"line_number":87,"context_line":"                       sa.ForeignKey(\u0027routers.id\u0027,"},{"line_number":88,"context_line":"                                     ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":89,"context_line":"                       nullable\u003dFalse,"},{"line_number":90,"context_line":"                       unique\u003dTrue,"},{"line_number":91,"context_line":"                       primary_key\u003dTrue)"},{"line_number":92,"context_line":"    revises_on_change \u003d (\u0027router\u0027, )"},{"line_number":93,"context_line":"    router \u003d sa.orm.relationship("},{"line_number":94,"context_line":"        l3.Router, load_on_pending\u003dTrue,"},{"line_number":95,"context_line":"        backref\u003dsa.orm.backref(\"qos_policy_binding\", uselist\u003dFalse,"},{"line_number":96,"context_line":"                               cascade\u003d\u0027delete\u0027, lazy\u003d\u0027joined\u0027))"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"class QosPortPolicyBinding(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_b3c7cb98","line":96,"range":{"start_line":79,"start_character":1,"end_line":96,"end_character":64},"in_reply_to":"5f7c97a3_8e306f57","updated":"2018-06-09 12:05:17.000000000","message":"Acctually router gateway port now can be associated with a qos policy. But that is in the L2 perspective. It will limit all the traffic through the gateway port.\n\nThis implementation and the floating IP qos are all in L3 view, we limit the L3 IP traffic, for this patch its SNAT.\n\nBecause router has no gateway_id or router_gateway_id, its only have the gateway_port_id. Do we really needs to introduce such name? So, in order to avoid confusion, I just set the binding attribute to `router_id`. It is worth noting that in the API extension the qos_policy_id is set in the attribute gateway_info. But in the DB level, we have no gaway_info table, we just use the router_id for the new table `qos_router_gw_policy_bindings`.","commit_id":"cfca0b7b48383dc2e6dca1fd3e61f9d9ef4b846c"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"75d85880c5deeec67bf787b6eff3f5d444a7f7ac","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                          nullable\u003dFalse,"},{"line_number":85,"context_line":"                          primary_key\u003dTrue)"},{"line_number":86,"context_line":"    router_id \u003d sa.Column(sa.String(db_const.UUID_FIELD_SIZE),"},{"line_number":87,"context_line":"                       sa.ForeignKey(\u0027routers.id\u0027,"},{"line_number":88,"context_line":"                                     ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":89,"context_line":"                       nullable\u003dFalse,"},{"line_number":90,"context_line":"                       unique\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_f4d7494e","line":87,"range":{"start_line":87,"start_character":23,"end_line":87,"end_character":25},"updated":"2018-09-18 18:06:49.000000000","message":"nit: align indentation","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"70799843b10d9dffd66251281492f91bcb9ea8c8","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                          nullable\u003dFalse,"},{"line_number":85,"context_line":"                          primary_key\u003dTrue)"},{"line_number":86,"context_line":"    router_id \u003d sa.Column(sa.String(db_const.UUID_FIELD_SIZE),"},{"line_number":87,"context_line":"                       sa.ForeignKey(\u0027routers.id\u0027,"},{"line_number":88,"context_line":"                                     ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":89,"context_line":"                       nullable\u003dFalse,"},{"line_number":90,"context_line":"                       unique\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_beb42ff2","line":87,"range":{"start_line":87,"start_character":23,"end_line":87,"end_character":25},"in_reply_to":"3f79a3b5_b4930a00","updated":"2018-09-20 00:52:53.000000000","message":"done","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4986ef84632c3fd1a70dfe33351bfcfea9d93b16","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                          nullable\u003dFalse,"},{"line_number":85,"context_line":"                          primary_key\u003dTrue)"},{"line_number":86,"context_line":"    router_id \u003d sa.Column(sa.String(db_const.UUID_FIELD_SIZE),"},{"line_number":87,"context_line":"                       sa.ForeignKey(\u0027routers.id\u0027,"},{"line_number":88,"context_line":"                                     ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":89,"context_line":"                       nullable\u003dFalse,"},{"line_number":90,"context_line":"                       unique\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_b4930a00","line":87,"range":{"start_line":87,"start_character":23,"end_line":87,"end_character":25},"in_reply_to":"3f79a3b5_f4d7494e","updated":"2018-09-19 01:56:50.000000000","message":"Done, will change this.","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d4fee2a42163e0f05db4fcc1572abb3fb12d87b9","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                          sa.ForeignKey(\u0027qos_policies.id\u0027,"},{"line_number":83,"context_line":"                                        ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":84,"context_line":"                          nullable\u003dFalse,"},{"line_number":85,"context_line":"                          primary_key\u003dTrue)"},{"line_number":86,"context_line":"    router_id \u003d sa.Column(sa.String(db_const.UUID_FIELD_SIZE),"},{"line_number":87,"context_line":"                          sa.ForeignKey(\u0027routers.id\u0027,"},{"line_number":88,"context_line":"                                        ondelete\u003d\u0027CASCADE\u0027),"}],"source_content_type":"text/x-python","patch_set":33,"id":"3f79a3b5_f04bc77c","line":85,"range":{"start_line":85,"start_character":26,"end_line":85,"end_character":42},"updated":"2018-11-26 12:16:21.000000000","message":"policy_id and router_id are not primary keys.\n\nrouter_id is unique, and that\u0027s what we need to build the table index, because this is the parameter used to look for a register.","commit_id":"99901f761d12e1488f8ca2039422ea1409cb218a"}],"neutron/extensions/gateway_rate_limit.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d440fe049ef3f80e316420deff267fd3f682d744","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class Gateway_rate_limit(extensions.ExtensionDescriptor):"},{"line_number":51,"context_line":"    \"\"\"Extension class supporting virtual router in HA mode.\"\"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @classmethod"},{"line_number":54,"context_line":"    def get_name(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_248c1135","line":51,"range":{"start_line":51,"start_character":52,"end_line":51,"end_character":54},"updated":"2017-01-25 03:20:41.000000000","message":"more than just HA it seems","commit_id":"36484eaefc3d97b8e868d687dce85ece3c433ae8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"16ed1eb4b84be42efef3d51e4eeb55dccdddbafe","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class Gateway_rate_limit(extensions.ExtensionDescriptor):"},{"line_number":51,"context_line":"    \"\"\"Extension class supporting virtual router in HA mode.\"\"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @classmethod"},{"line_number":54,"context_line":"    def get_name(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_d0f059cc","line":51,"range":{"start_line":51,"start_character":52,"end_line":51,"end_character":54},"in_reply_to":"5a3905b3_248c1135","updated":"2017-01-25 13:03:40.000000000","message":"Done","commit_id":"36484eaefc3d97b8e868d687dce85ece3c433ae8"}],"neutron/extensions/qos_gateway_ip.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"ef2428c4e81e9a18fd634e8e875046c1f3cd7331","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                        \u0027required\u0027: False"},{"line_number":46,"context_line":"                    },"},{"line_number":47,"context_line":"                    qos_consts.QOS_POLICY_ID: {"},{"line_number":48,"context_line":"                        \u0027allow_post\u0027: True,"},{"line_number":49,"context_line":"                        \u0027allow_put\u0027: True,"},{"line_number":50,"context_line":"                        \u0027is_visible\u0027: True,"},{"line_number":51,"context_line":"                        \u0027default\u0027: None,"},{"line_number":52,"context_line":"                        \u0027validate\u0027: {\u0027type:uuid_or_none\u0027: None}"},{"line_number":53,"context_line":"                    }"},{"line_number":54,"context_line":"                }"},{"line_number":55,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f7c97a3_d43931cf","line":52,"range":{"start_line":48,"start_character":24,"end_line":52,"end_character":63},"updated":"2018-06-20 07:39:52.000000000","message":"The \"type:dict_or_nodata\" validator cannot manage these parameter definitions, right? I gave same comment into the patch of neutron-lib so let\u0027s discuss in the patch if you have some questions.","commit_id":"66f843aad26d5a5271c9bafe03edc1dd2aa9603e"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"7a7ff2088ed182d0bc7df404ee8ee0772d6a5dca","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                        \u0027required\u0027: False"},{"line_number":46,"context_line":"                    },"},{"line_number":47,"context_line":"                    qos_consts.QOS_POLICY_ID: {"},{"line_number":48,"context_line":"                        \u0027allow_post\u0027: True,"},{"line_number":49,"context_line":"                        \u0027allow_put\u0027: True,"},{"line_number":50,"context_line":"                        \u0027is_visible\u0027: True,"},{"line_number":51,"context_line":"                        \u0027default\u0027: None,"},{"line_number":52,"context_line":"                        \u0027validate\u0027: {\u0027type:uuid_or_none\u0027: None}"},{"line_number":53,"context_line":"                    }"},{"line_number":54,"context_line":"                }"},{"line_number":55,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f7c97a3_f8f3fb07","line":52,"range":{"start_line":48,"start_character":24,"end_line":52,"end_character":63},"in_reply_to":"5f7c97a3_d43931cf","updated":"2018-06-20 11:26:34.000000000","message":"It\u0027s not `dict_or_nodata` here.  The validate is `uuid_or_none`.\n\nAnd, again, this just works fine, no need to optimize.","commit_id":"66f843aad26d5a5271c9bafe03edc1dd2aa9603e"}],"neutron/objects/qos/binding.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e6449098d8be5b2ece099fc630bc300adac16f01","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"@base.NeutronObjectRegistry.register"},{"line_number":71,"context_line":"class QosPolicyRouterGatewayIPBinding(base.NeutronDbObject):"},{"line_number":72,"context_line":"    # Version 1.0: Initial version"},{"line_number":73,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_519e0806","line":71,"range":{"start_line":71,"start_character":6,"end_line":71,"end_character":37},"updated":"2018-09-09 07:49:04.000000000","message":"I\u0027m not sure if that \"IP\" is necessary as in fact You bind QoS policy to router\u0027s gateway not to gateway\u0027s IP address, right?","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"8bd672378936f1f9c003ab244292137e2d7ae234","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"@base.NeutronObjectRegistry.register"},{"line_number":71,"context_line":"class QosPolicyRouterGatewayIPBinding(base.NeutronDbObject):"},{"line_number":72,"context_line":"    # Version 1.0: Initial version"},{"line_number":73,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_fda922dc","line":71,"range":{"start_line":71,"start_character":6,"end_line":71,"end_character":37},"in_reply_to":"3f79a3b5_519e0806","updated":"2018-09-10 01:11:43.000000000","message":"I think adding the ``IP`` here is to distinguish binding qos policy to ``router gateway port`` and ``router gateway IP``. People may think QosPolicyRouterGatewayBinding is binding the qos to the gateway port. Add the ``IP`` to make it different.","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"ee55acc1952e7f896ba9e162903a3ba5a6e9672a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    }"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    primary_keys \u003d [\u0027policy_id\u0027, \u0027router_id\u0027]"},{"line_number":83,"context_line":"    fields_no_update \u003d [\u0027policy_id\u0027, \u0027router_id\u0027]"}],"source_content_type":"text/x-python","patch_set":31,"id":"3f79a3b5_c8f59153","line":83,"range":{"start_line":83,"start_character":4,"end_line":83,"end_character":20},"updated":"2018-10-29 19:11:14.000000000","message":"Nit: fields_no_update will contain primary_keys by default, so this looks redundant.","commit_id":"561815c46bb5fca7928997f40865a0a6a0d695fc"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0d79c3ea52683124eff611c0040c47effe45e44f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    }"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    primary_keys \u003d [\u0027policy_id\u0027, \u0027router_id\u0027]"},{"line_number":83,"context_line":"    fields_no_update \u003d [\u0027policy_id\u0027, \u0027router_id\u0027]"}],"source_content_type":"text/x-python","patch_set":31,"id":"3f79a3b5_183e6ce2","line":83,"range":{"start_line":83,"start_character":4,"end_line":83,"end_character":20},"in_reply_to":"3f79a3b5_c8f59153","updated":"2018-10-30 14:18:19.000000000","message":"IMO, it\u0027s a client side restrict condition, users try to update these keys will be directly limited. It will have no chance to update the DB primary_keys.","commit_id":"561815c46bb5fca7928997f40865a0a6a0d695fc"}],"neutron/objects/qos/policy.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a01c0b793d2375367b8177e923058fbc25fe2adc","unresolved":false,"context_lines":[{"line_number":307,"context_line":"    def detach_router(self, router_id):"},{"line_number":308,"context_line":"        deleted \u003d binding.QosPolicyRouterGatewayIPBinding.delete_objects("},{"line_number":309,"context_line":"            self.obj_context, router_id\u003drouter_id)"},{"line_number":310,"context_line":"        if not deleted:"},{"line_number":311,"context_line":"            raise exceptions.RouterQosBindingNotFound(router_id\u003drouter_id,"},{"line_number":312,"context_line":"                                                      policy_id\u003dself.id)"},{"line_number":313,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"3f79a3b5_bfd2d732","line":310,"range":{"start_line":310,"start_character":8,"end_line":310,"end_character":22},"updated":"2018-09-20 21:35:27.000000000","message":"since it returns the count if deleted \u003c\u003d 0 : ?","commit_id":"48f81c35eedeb86aa71db0b5c917b795632bb101"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"60a4804bd843f5a386e464b51b9c68fd198086a5","unresolved":false,"context_lines":[{"line_number":307,"context_line":"    def detach_router(self, router_id):"},{"line_number":308,"context_line":"        deleted \u003d binding.QosPolicyRouterGatewayIPBinding.delete_objects("},{"line_number":309,"context_line":"            self.obj_context, router_id\u003drouter_id)"},{"line_number":310,"context_line":"        if not deleted:"},{"line_number":311,"context_line":"            raise exceptions.RouterQosBindingNotFound(router_id\u003drouter_id,"},{"line_number":312,"context_line":"                                                      policy_id\u003dself.id)"},{"line_number":313,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"3f79a3b5_f0bb99ba","line":310,"range":{"start_line":310,"start_character":8,"end_line":310,"end_character":22},"in_reply_to":"3f79a3b5_bfd2d732","updated":"2018-09-21 02:52:30.000000000","message":"It\u0027s a 1-1 relation here.","commit_id":"48f81c35eedeb86aa71db0b5c917b795632bb101"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"d632c96b67cedd1e62e618dc0cb3ebbd7b5d960d","unresolved":false,"context_lines":[{"line_number":307,"context_line":"    def detach_router(self, router_id):"},{"line_number":308,"context_line":"        deleted \u003d binding.QosPolicyRouterGatewayIPBinding.delete_objects("},{"line_number":309,"context_line":"            self.obj_context, router_id\u003drouter_id)"},{"line_number":310,"context_line":"        if not deleted:"},{"line_number":311,"context_line":"            raise exceptions.RouterQosBindingNotFound(router_id\u003drouter_id,"},{"line_number":312,"context_line":"                                                      policy_id\u003dself.id)"},{"line_number":313,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"3f79a3b5_30a6aa11","line":310,"range":{"start_line":310,"start_character":8,"end_line":310,"end_character":22},"in_reply_to":"3f79a3b5_f0bb99ba","updated":"2018-09-25 15:11:39.000000000","message":"then also it\u0027ll be an int of value 1 ? it\u0027ll work either way.","commit_id":"48f81c35eedeb86aa71db0b5c917b795632bb101"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a01c0b793d2375367b8177e923058fbc25fe2adc","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        deleted \u003d binding.QosPolicyRouterGatewayIPBinding.delete_objects("},{"line_number":309,"context_line":"            self.obj_context, router_id\u003drouter_id)"},{"line_number":310,"context_line":"        if not deleted:"},{"line_number":311,"context_line":"            raise exceptions.RouterQosBindingNotFound(router_id\u003drouter_id,"},{"line_number":312,"context_line":"                                                      policy_id\u003dself.id)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def set_default(self):"},{"line_number":315,"context_line":"        if not self.get_default():"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f79a3b5_7fad1f82","line":312,"range":{"start_line":311,"start_character":11,"end_line":312,"end_character":71},"updated":"2018-09-20 21:35:27.000000000","message":"looking at relationship, samerouter_id can be added with different policy_ids ? correct me if that\u0027s wrong, in this case delete_objects is called on router_id so all entries with same router_id but with different policy id would be deleted ? but exception raised for only one ? \n\nIMO, if its just gonna be exactly one object ? then do obj get_object(context, router_id\u003drouter_id, policy_id\u003dself.id) with primary key including router_id and self.id and then just call obj.delete() or make sure only len if it deleted only one object.","commit_id":"48f81c35eedeb86aa71db0b5c917b795632bb101"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"60a4804bd843f5a386e464b51b9c68fd198086a5","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        deleted \u003d binding.QosPolicyRouterGatewayIPBinding.delete_objects("},{"line_number":309,"context_line":"            self.obj_context, router_id\u003drouter_id)"},{"line_number":310,"context_line":"        if not deleted:"},{"line_number":311,"context_line":"            raise exceptions.RouterQosBindingNotFound(router_id\u003drouter_id,"},{"line_number":312,"context_line":"                                                      policy_id\u003dself.id)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def set_default(self):"},{"line_number":315,"context_line":"        if not self.get_default():"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f79a3b5_d0c0dd2d","line":312,"range":{"start_line":311,"start_character":11,"end_line":312,"end_character":71},"in_reply_to":"3f79a3b5_7fad1f82","updated":"2018-09-21 02:52:30.000000000","message":"It\u0027s a 1-1 relation here.","commit_id":"48f81c35eedeb86aa71db0b5c917b795632bb101"}],"neutron/tests/unit/extensions/test_l3.py":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"ee55acc1952e7f896ba9e162903a3ba5a6e9672a","unresolved":false,"context_lines":[{"line_number":381,"context_line":"    def _add_external_gateway_to_router(self, router_id, network_id,"},{"line_number":382,"context_line":"                                        expected_code\u003dexc.HTTPOk.code,"},{"line_number":383,"context_line":"                                        neutron_context\u003dNone, ext_ips\u003dNone,"},{"line_number":384,"context_line":"                                        policy_id\u003dNone,"},{"line_number":385,"context_line":"                                        is_remove\u003dFalse):"},{"line_number":386,"context_line":"        ext_ips \u003d ext_ips or []"},{"line_number":387,"context_line":"        body \u003d {\u0027router\u0027:"},{"line_number":388,"context_line":"                {\u0027external_gateway_info\u0027: {\u0027network_id\u0027: network_id}}}"}],"source_content_type":"text/x-python","patch_set":31,"id":"3f79a3b5_2b619fd4","line":385,"range":{"start_line":384,"start_character":0,"end_line":385,"end_character":55},"updated":"2018-10-29 19:11:14.000000000","message":"Nit: we can combine these two parameters into one as following:\n\n    def _add_external_gateway_to_router(self, router_id, network_id,\n                                        expected_code\u003dexc.HTTPOk.code,\n                                        neutron_context\u003dNone, ext_ips\u003dNone,\n                                        **kwargs):\n        ...\n        if \u0027policy_id\u0027 in kwargs:\n            body[\u0027router\u0027][\u0027external_gateway_info\u0027][\n                \u0027qos_policy_id\u0027] \u003d kwargs.pop(\u0027policy_id\u0027)\n        ...\n\nThen, the caller can pass \u0027policy_id\u003dNone\u0027 if they want to remove the policy_id, and skip this parameter if they want to leave it untouched.","commit_id":"561815c46bb5fca7928997f40865a0a6a0d695fc"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0d79c3ea52683124eff611c0040c47effe45e44f","unresolved":false,"context_lines":[{"line_number":381,"context_line":"    def _add_external_gateway_to_router(self, router_id, network_id,"},{"line_number":382,"context_line":"                                        expected_code\u003dexc.HTTPOk.code,"},{"line_number":383,"context_line":"                                        neutron_context\u003dNone, ext_ips\u003dNone,"},{"line_number":384,"context_line":"                                        policy_id\u003dNone,"},{"line_number":385,"context_line":"                                        is_remove\u003dFalse):"},{"line_number":386,"context_line":"        ext_ips \u003d ext_ips or []"},{"line_number":387,"context_line":"        body \u003d {\u0027router\u0027:"},{"line_number":388,"context_line":"                {\u0027external_gateway_info\u0027: {\u0027network_id\u0027: network_id}}}"}],"source_content_type":"text/x-python","patch_set":31,"id":"3f79a3b5_537285b1","line":385,"range":{"start_line":384,"start_character":0,"end_line":385,"end_character":55},"in_reply_to":"3f79a3b5_2b619fd4","updated":"2018-10-30 14:18:19.000000000","message":"Done","commit_id":"561815c46bb5fca7928997f40865a0a6a0d695fc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7fc8e4a997032ba45bf6b85997f36d12358cced0","unresolved":false,"context_lines":[{"line_number":3464,"context_line":"            events.AFTER_UPDATE)"},{"line_number":3465,"context_line":"        with mock.patch.object(plugin.l3_rpc_notifier,"},{"line_number":3466,"context_line":"                               \u0027routers_updated\u0027) as chk_method:"},{"line_number":3467,"context_line":"            with self.router() as router:"},{"line_number":3468,"context_line":"                with self.subnet(cidr\u003d\u00271.1.1.0/24\u0027) as subnet:"},{"line_number":3469,"context_line":"                    self._set_net_external(subnet[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":3470,"context_line":"                    router_id \u003d router[\u0027router\u0027][\u0027id\u0027]"},{"line_number":3471,"context_line":"                    self._add_external_gateway_to_router("}],"source_content_type":"text/x-python","patch_set":34,"id":"3f79a3b5_84efa4b0","line":3468,"range":{"start_line":3467,"start_character":12,"end_line":3468,"end_character":62},"updated":"2018-11-27 08:25:45.000000000","message":"nit: You would have less indentations if You would do this in one \"with\" statement","commit_id":"741a161e28d4701a8cedbe3e9437e97f62492d50"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7fc8e4a997032ba45bf6b85997f36d12358cced0","unresolved":false,"context_lines":[{"line_number":3483,"context_line":"                                p[\u0027device_id\u0027] \u003d\u003d router_id):"},{"line_number":3484,"context_line":"                            gw_port_id \u003d p[\u0027id\u0027]"},{"line_number":3485,"context_line":"                    self.assertIsNotNone(gw_port_id)"},{"line_number":3486,"context_line":"                    gw_ip_len \u003d 1"},{"line_number":3487,"context_line":"                    if gw_ip_change:"},{"line_number":3488,"context_line":"                        gw_ip_len +\u003d 1"},{"line_number":3489,"context_line":"                        data \u003d {\u0027port\u0027: {\u0027fixed_ips\u0027: ["}],"source_content_type":"text/x-python","patch_set":34,"id":"3f79a3b5_84348448","line":3486,"range":{"start_line":3486,"start_character":20,"end_line":3486,"end_character":29},"updated":"2018-11-27 08:25:45.000000000","message":"TBH I\u0027m a bit lost reading this test, You are using \"gw_ip_len\" and \"gateway_ip_len\" variables here - what is the difference between them?","commit_id":"741a161e28d4701a8cedbe3e9437e97f62492d50"}],"neutron/tests/unit/extensions/test_qos_gateway_ip.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"7c41269a0639763d54acb6fbc1d4371c4d8041fb","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            ext_mgr\u003dext_mgr,"},{"line_number":131,"context_line":"            service_plugins\u003dservice_plugins)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        self.setup_notification_driver()"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"class GatewayIPQoSDBSepTestCase(test_l3.L3BaseForSepTests,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_ce4bc784","line":133,"range":{"start_line":133,"start_character":19,"end_line":133,"end_character":38},"updated":"2018-06-08 16:36:04.000000000","message":"I recall, this notification_driver option was deprecated, I doubt this will add interest to existing technical debt, but need to verify","commit_id":"cfca0b7b48383dc2e6dca1fd3e61f9d9ef4b846c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"58bf3ff58df6d9511bf185584468a25a205d0f4a","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            ext_mgr\u003dext_mgr,"},{"line_number":131,"context_line":"            service_plugins\u003dservice_plugins)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        self.setup_notification_driver()"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"class GatewayIPQoSDBSepTestCase(test_l3.L3BaseForSepTests,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_f3e8e316","line":133,"range":{"start_line":133,"start_character":19,"end_line":133,"end_character":38},"in_reply_to":"5f7c97a3_ce4bc784","updated":"2018-06-09 12:05:17.000000000","message":"There is no deprecated mark:\nhttps://github.com/openstack/neutron/blob/master/doc/source/admin/archives/adv-operational-features.rst","commit_id":"cfca0b7b48383dc2e6dca1fd3e61f9d9ef4b846c"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"48efdc3f43d62b40e25294ead9e131a13c12813c","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            ext_mgr\u003dext_mgr,"},{"line_number":131,"context_line":"            service_plugins\u003dservice_plugins)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        self.setup_notification_driver()"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"class GatewayIPQoSDBSepTestCase(test_l3.L3BaseForSepTests,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_88711e10","line":133,"range":{"start_line":133,"start_character":19,"end_line":133,"end_character":38},"in_reply_to":"5f7c97a3_f3e8e316","updated":"2018-06-11 16:28:47.000000000","message":"my bad i think it was just for qos, the use of notification driver was deprecated","commit_id":"cfca0b7b48383dc2e6dca1fd3e61f9d9ef4b846c"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"4d36e2624d01383ea7015c36fad652c1ab468f7c","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            self.assertEqual("},{"line_number":107,"context_line":"                policy_obj.id,"},{"line_number":108,"context_line":"                res[\u0027router\u0027][\u0027external_gateway_info\u0027].get("},{"line_number":109,"context_line":"                    qos_consts.QOS_POLICY_ID))"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"class GatewayIPQoSDBIntTestCase(test_l3.L3BaseForIntTests,"}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_1d2d498e","line":109,"updated":"2018-09-18 19:29:41.000000000","message":"Perhaps do another update of router gateway and set the qos_policy_id back to none? The goal is to assure that the qos_policy_id that was set before is correctly unset.","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4986ef84632c3fd1a70dfe33351bfcfea9d93b16","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            self.assertEqual("},{"line_number":107,"context_line":"                policy_obj.id,"},{"line_number":108,"context_line":"                res[\u0027router\u0027][\u0027external_gateway_info\u0027].get("},{"line_number":109,"context_line":"                    qos_consts.QOS_POLICY_ID))"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"class GatewayIPQoSDBIntTestCase(test_l3.L3BaseForIntTests,"}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_cf095395","line":109,"in_reply_to":"3f79a3b5_1d2d498e","updated":"2018-09-19 01:56:50.000000000","message":"Done, will add such case.","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"70799843b10d9dffd66251281492f91bcb9ea8c8","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            self.assertEqual("},{"line_number":107,"context_line":"                policy_obj.id,"},{"line_number":108,"context_line":"                res[\u0027router\u0027][\u0027external_gateway_info\u0027].get("},{"line_number":109,"context_line":"                    qos_consts.QOS_POLICY_ID))"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"class GatewayIPQoSDBIntTestCase(test_l3.L3BaseForIntTests,"}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_fea387af","line":109,"in_reply_to":"3f79a3b5_cf095395","updated":"2018-09-20 00:52:53.000000000","message":"done","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a01c0b793d2375367b8177e923058fbc25fe2adc","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class GatewayIPQoSDBTestCaseBase(object):"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_create_router_gateway_with_qos_policy(self):"},{"line_number":66,"context_line":"        ctx \u003d context.get_admin_context()"},{"line_number":67,"context_line":"        policy_obj \u003d policy.QosPolicy(ctx,"},{"line_number":68,"context_line":"                                      id\u003duuidutils.generate_uuid(),"},{"line_number":69,"context_line":"                                      project_id\u003d\u0027tenant\u0027, name\u003d\u0027pol1\u0027,"},{"line_number":70,"context_line":"                                      rules\u003d[])"},{"line_number":71,"context_line":"        policy_obj.create()"},{"line_number":72,"context_line":"        with self.subnet(cidr\u003d\u002711.0.0.0/24\u0027) as public_sub,\\"},{"line_number":73,"context_line":"                self.router() as r:"},{"line_number":74,"context_line":"            self._set_net_external(public_sub[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":75,"context_line":"            res \u003d self._add_external_gateway_to_router("},{"line_number":76,"context_line":"                r[\u0027router\u0027][\u0027id\u0027],"},{"line_number":77,"context_line":"                public_sub[\u0027subnet\u0027][\u0027network_id\u0027],"},{"line_number":78,"context_line":"                policy_id\u003dpolicy_obj.id)"},{"line_number":79,"context_line":"            self.assertEqual("},{"line_number":80,"context_line":"                policy_obj.id,"},{"line_number":81,"context_line":"                res[\u0027router\u0027][\u0027external_gateway_info\u0027].get("},{"line_number":82,"context_line":"                    qos_consts.QOS_POLICY_ID))"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def test_update_router_gateway_with_qos_policy(self):"},{"line_number":85,"context_line":"        ctx \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f79a3b5_4a7d031a","line":82,"range":{"start_line":65,"start_character":3,"end_line":82,"end_character":46},"updated":"2018-09-20 21:35:27.000000000","message":"this test case can be dropped its already covered in the test below L102-109","commit_id":"48f81c35eedeb86aa71db0b5c917b795632bb101"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"60a4804bd843f5a386e464b51b9c68fd198086a5","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class GatewayIPQoSDBTestCaseBase(object):"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_create_router_gateway_with_qos_policy(self):"},{"line_number":66,"context_line":"        ctx \u003d context.get_admin_context()"},{"line_number":67,"context_line":"        policy_obj \u003d policy.QosPolicy(ctx,"},{"line_number":68,"context_line":"                                      id\u003duuidutils.generate_uuid(),"},{"line_number":69,"context_line":"                                      project_id\u003d\u0027tenant\u0027, name\u003d\u0027pol1\u0027,"},{"line_number":70,"context_line":"                                      rules\u003d[])"},{"line_number":71,"context_line":"        policy_obj.create()"},{"line_number":72,"context_line":"        with self.subnet(cidr\u003d\u002711.0.0.0/24\u0027) as public_sub,\\"},{"line_number":73,"context_line":"                self.router() as r:"},{"line_number":74,"context_line":"            self._set_net_external(public_sub[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":75,"context_line":"            res \u003d self._add_external_gateway_to_router("},{"line_number":76,"context_line":"                r[\u0027router\u0027][\u0027id\u0027],"},{"line_number":77,"context_line":"                public_sub[\u0027subnet\u0027][\u0027network_id\u0027],"},{"line_number":78,"context_line":"                policy_id\u003dpolicy_obj.id)"},{"line_number":79,"context_line":"            self.assertEqual("},{"line_number":80,"context_line":"                policy_obj.id,"},{"line_number":81,"context_line":"                res[\u0027router\u0027][\u0027external_gateway_info\u0027].get("},{"line_number":82,"context_line":"                    qos_consts.QOS_POLICY_ID))"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def test_update_router_gateway_with_qos_policy(self):"},{"line_number":85,"context_line":"        ctx \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f79a3b5_b008c190","line":82,"range":{"start_line":65,"start_character":3,"end_line":82,"end_character":46},"in_reply_to":"3f79a3b5_4a7d031a","updated":"2018-09-21 02:52:30.000000000","message":"It\u0027s different. Here is changing `no gateway` to `have gateway with qos`.\nAnd line 102-109, is `have gateway without qos` to `have gateway with qos`.","commit_id":"48f81c35eedeb86aa71db0b5c917b795632bb101"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"d632c96b67cedd1e62e618dc0cb3ebbd7b5d960d","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class GatewayIPQoSDBTestCaseBase(object):"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_create_router_gateway_with_qos_policy(self):"},{"line_number":66,"context_line":"        ctx \u003d context.get_admin_context()"},{"line_number":67,"context_line":"        policy_obj \u003d policy.QosPolicy(ctx,"},{"line_number":68,"context_line":"                                      id\u003duuidutils.generate_uuid(),"},{"line_number":69,"context_line":"                                      project_id\u003d\u0027tenant\u0027, name\u003d\u0027pol1\u0027,"},{"line_number":70,"context_line":"                                      rules\u003d[])"},{"line_number":71,"context_line":"        policy_obj.create()"},{"line_number":72,"context_line":"        with self.subnet(cidr\u003d\u002711.0.0.0/24\u0027) as public_sub,\\"},{"line_number":73,"context_line":"                self.router() as r:"},{"line_number":74,"context_line":"            self._set_net_external(public_sub[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":75,"context_line":"            res \u003d self._add_external_gateway_to_router("},{"line_number":76,"context_line":"                r[\u0027router\u0027][\u0027id\u0027],"},{"line_number":77,"context_line":"                public_sub[\u0027subnet\u0027][\u0027network_id\u0027],"},{"line_number":78,"context_line":"                policy_id\u003dpolicy_obj.id)"},{"line_number":79,"context_line":"            self.assertEqual("},{"line_number":80,"context_line":"                policy_obj.id,"},{"line_number":81,"context_line":"                res[\u0027router\u0027][\u0027external_gateway_info\u0027].get("},{"line_number":82,"context_line":"                    qos_consts.QOS_POLICY_ID))"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def test_update_router_gateway_with_qos_policy(self):"},{"line_number":85,"context_line":"        ctx \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f79a3b5_70a2e2af","line":82,"range":{"start_line":65,"start_character":3,"end_line":82,"end_character":46},"in_reply_to":"3f79a3b5_b008c190","updated":"2018-09-25 15:11:39.000000000","message":"somehow this is tested in test below only difference that has two add_external_gateway_to_router calls L94 and L102, IMO, not very different but if other reviewers agree im ok with it","commit_id":"48f81c35eedeb86aa71db0b5c917b795632bb101"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a01c0b793d2375367b8177e923058fbc25fe2adc","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    def test_clear_router_gateway_and_create_with_old_qos_policy_implicitly("},{"line_number":112,"context_line":"            self):"},{"line_number":113,"context_line":"        ctx \u003d context.get_admin_context()"},{"line_number":114,"context_line":"        policy_obj \u003d policy.QosPolicy(ctx,"},{"line_number":115,"context_line":"                                      id\u003duuidutils.generate_uuid(),"},{"line_number":116,"context_line":"                                      project_id\u003d\u0027tenant\u0027, name\u003d\u0027pol1\u0027,"},{"line_number":117,"context_line":"                                      rules\u003d[])"},{"line_number":118,"context_line":"        policy_obj.create()"},{"line_number":119,"context_line":"        with self.subnet(cidr\u003d\u002711.0.0.0/24\u0027) as public_sub,\\"},{"line_number":120,"context_line":"                self.router() as r:"},{"line_number":121,"context_line":"            self._set_net_external(public_sub[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":122,"context_line":"            res \u003d self._add_external_gateway_to_router("},{"line_number":123,"context_line":"                r[\u0027router\u0027][\u0027id\u0027],"},{"line_number":124,"context_line":"                public_sub[\u0027subnet\u0027][\u0027network_id\u0027],"},{"line_number":125,"context_line":"                policy_id\u003dpolicy_obj.id)"},{"line_number":126,"context_line":"            self.assertEqual("},{"line_number":127,"context_line":"                policy_obj.id,"},{"line_number":128,"context_line":"                res[\u0027router\u0027][\u0027external_gateway_info\u0027].get("},{"line_number":129,"context_line":"                    qos_consts.QOS_POLICY_ID))"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"            # Clear router gateway"},{"line_number":132,"context_line":"            self._remove_external_gateway_from_router("}],"source_content_type":"text/x-python","patch_set":26,"id":"3f79a3b5_c59a64c3","line":129,"range":{"start_line":114,"start_character":8,"end_line":129,"end_character":46},"updated":"2018-09-20 21:35:27.000000000","message":"common code used in many test can be moved one helped and use it in all other tests ?","commit_id":"48f81c35eedeb86aa71db0b5c917b795632bb101"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"60a4804bd843f5a386e464b51b9c68fd198086a5","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    def test_clear_router_gateway_and_create_with_old_qos_policy_implicitly("},{"line_number":112,"context_line":"            self):"},{"line_number":113,"context_line":"        ctx \u003d context.get_admin_context()"},{"line_number":114,"context_line":"        policy_obj \u003d policy.QosPolicy(ctx,"},{"line_number":115,"context_line":"                                      id\u003duuidutils.generate_uuid(),"},{"line_number":116,"context_line":"                                      project_id\u003d\u0027tenant\u0027, name\u003d\u0027pol1\u0027,"},{"line_number":117,"context_line":"                                      rules\u003d[])"},{"line_number":118,"context_line":"        policy_obj.create()"},{"line_number":119,"context_line":"        with self.subnet(cidr\u003d\u002711.0.0.0/24\u0027) as public_sub,\\"},{"line_number":120,"context_line":"                self.router() as r:"},{"line_number":121,"context_line":"            self._set_net_external(public_sub[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":122,"context_line":"            res \u003d self._add_external_gateway_to_router("},{"line_number":123,"context_line":"                r[\u0027router\u0027][\u0027id\u0027],"},{"line_number":124,"context_line":"                public_sub[\u0027subnet\u0027][\u0027network_id\u0027],"},{"line_number":125,"context_line":"                policy_id\u003dpolicy_obj.id)"},{"line_number":126,"context_line":"            self.assertEqual("},{"line_number":127,"context_line":"                policy_obj.id,"},{"line_number":128,"context_line":"                res[\u0027router\u0027][\u0027external_gateway_info\u0027].get("},{"line_number":129,"context_line":"                    qos_consts.QOS_POLICY_ID))"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"            # Clear router gateway"},{"line_number":132,"context_line":"            self._remove_external_gateway_from_router("}],"source_content_type":"text/x-python","patch_set":26,"id":"3f79a3b5_10f9757e","line":129,"range":{"start_line":114,"start_character":8,"end_line":129,"end_character":46},"in_reply_to":"3f79a3b5_c59a64c3","updated":"2018-09-21 02:52:30.000000000","message":"Yes, I noticed that, but there are many differences under the `with` section. Acctually only 3 lines are same for the tests, the real test scenarios are varied.","commit_id":"48f81c35eedeb86aa71db0b5c917b795632bb101"}],"releasenotes/notes/gateway-rate-limit-905bee1ed60c6b8e.yaml":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"7c41269a0639763d54acb6fbc1d4371c4d8041fb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Implementation of router gateway IP rate limit, a new parameter"},{"line_number":4,"context_line":"    ``qos_policy_id`` was added to L3 router gateway related API."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"5f7c97a3_8e362f02","line":3,"range":{"start_line":3,"start_character":29,"end_line":3,"end_character":50},"updated":"2018-06-08 16:36:04.000000000","message":"is it really limited to rate limit ?, since policy can have different rules, technically it depends on backends (if that support different rules or not) so I guess release note should be generic, saying extending router gateway to add QoS policy.","commit_id":"cfca0b7b48383dc2e6dca1fd3e61f9d9ef4b846c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"58bf3ff58df6d9511bf185584468a25a205d0f4a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Implementation of router gateway IP rate limit, a new parameter"},{"line_number":4,"context_line":"    ``qos_policy_id`` was added to L3 router gateway related API."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"5f7c97a3_13eebf21","line":3,"range":{"start_line":3,"start_character":29,"end_line":3,"end_character":50},"in_reply_to":"5f7c97a3_8e362f02","updated":"2018-06-09 12:05:17.000000000","message":"Done","commit_id":"cfca0b7b48383dc2e6dca1fd3e61f9d9ef4b846c"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"75d85880c5deeec67bf787b6eff3f5d444a7f7ac","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Extending neutron server side router gateway, a new parameter"},{"line_number":4,"context_line":"    ``qos_policy_id`` was added to L3 router gateway related API."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"3f79a3b5_14a525b4","line":4,"updated":"2018-09-18 18:06:49.000000000","message":"IMO, it is better to include more details in the release note. For example, explain what are the meaning of this new parameter would be useful.","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4986ef84632c3fd1a70dfe33351bfcfea9d93b16","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Extending neutron server side router gateway, a new parameter"},{"line_number":4,"context_line":"    ``qos_policy_id`` was added to L3 router gateway related API."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"3f79a3b5_14f51e51","line":4,"in_reply_to":"3f79a3b5_14a525b4","updated":"2018-09-19 01:56:50.000000000","message":"Done","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"70799843b10d9dffd66251281492f91bcb9ea8c8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Extending neutron server side router gateway, a new parameter"},{"line_number":4,"context_line":"    ``qos_policy_id`` was added to L3 router gateway related API."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"3f79a3b5_9ea613c0","line":4,"in_reply_to":"3f79a3b5_14f51e51","updated":"2018-09-20 00:52:53.000000000","message":"done","commit_id":"c6a93832ae4dc0c2ff0ff1d841e4e87785559202"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d25dbbc7d85a810ffba2fc2e9abc10443a0063ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"3f79a3b5_302243b9","line":9,"updated":"2018-11-30 02:25:30.000000000","message":"Please also see my comment to https://review.openstack.org/#/c/568526/26/releasenotes/notes/gateway-ip-qos-agent-extension-dfb1d30f85cce18b.yaml\n\nThis is what I propose for the release note:\n\n---\nfeatures:\n   - |\n     A new attribute ``qos_policy_id`` is added to the L3 router gateway. \n\n     * It enables users to associate QoS policies to L3 router gateways to control the rate of transmission of the associated SNAT traffic.\n     * At the moment, only bandwidth limit rules are supported in the QoS polices.\n     * To enable this feature, the ``qos`` service plugin has to be configured in the Neutron server and the ``gateway_ip_qos`` extension has to be configured in the L3 agents. Please refer to the ``QoS`` section of the ``OpenStack Networking Guide`` for more specific details.","commit_id":"058c212a4362c7c388f81b675f982df5c65ad456"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1ce736500612915f7d22dd33a049d74d3ff47d19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"3f79a3b5_c3246b65","line":9,"in_reply_to":"3f79a3b5_302243b9","updated":"2018-11-30 02:29:35.000000000","message":"I am assuming there will be another patch to provide configuration guidelines in the OpenStack Networking Guide.","commit_id":"058c212a4362c7c388f81b675f982df5c65ad456"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3417edfa94b428f5bc9e69ed458534fb450631b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"3f79a3b5_837af324","line":9,"in_reply_to":"3f79a3b5_302243b9","updated":"2018-11-30 02:38:59.000000000","message":"One release note is good to me, will do it later.","commit_id":"058c212a4362c7c388f81b675f982df5c65ad456"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3417edfa94b428f5bc9e69ed458534fb450631b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"3f79a3b5_2392ff56","line":9,"in_reply_to":"3f79a3b5_c3246b65","updated":"2018-11-30 02:38:59.000000000","message":"Yes, [Doc] work is done locally, I\u0027ll submit it today.","commit_id":"058c212a4362c7c388f81b675f982df5c65ad456"}]}
