)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f9e7faf151150d9cbd78052ec132a90b71a2a0c5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Maxime Guyot \u003cmaxime.guyot@elits.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-26 09:39:28 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Apply QoS policy on network:router_gateway"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2428c2466f41a022196576f4b14526752543da7a"},{"line_number":10,"context_line":"Closes-Bug: #1659265"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a461143_a2c1bce6","line":7,"updated":"2017-01-26 10:32:47.000000000","message":"Could you explain this a little bit more in detail with an extra paragraph?","commit_id":"d99593fbe1ba8399ac995a3bf52060f6a4b99455"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f7d99ee21373adbaf2a029b2014fc4b59ea1363b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-01-26 09:39:28 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Apply QoS policy on network:router_gateway"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2428c2466f41a022196576f4b14526752543da7a"},{"line_number":10,"context_line":"Closes-Bug: #1659265"},{"line_number":11,"context_line":"Related-Bug: #1486039"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a461143_4259f859","line":8,"updated":"2017-01-26 10:33:26.000000000","message":"I\u0027d also add DocImpact flag here, so we have documentation sorted out to explain this.","commit_id":"d99593fbe1ba8399ac995a3bf52060f6a4b99455"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"01c9e39feafb9ef69b1fdd03534be10fe8ca92e1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Apply QoS policy on network:router_gateway"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"All router ports (internal and external) used to be excluded from QoS policies applied on network. This patch excludles only internal router ports from network QoS policies."},{"line_number":10,"context_line":"This allows cloud administrators to set an egress Qos policiy to a public/external network and have the QoS policy applied on all external router ports (DVR or not). To the tenant this is also egress traffic so no confusion compared to QoS policies applied to VM ports."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a461143_6eef8f87","line":9,"updated":"2017-01-27 08:48:22.000000000","message":"nit: The lines are overflowing the 79th column limit.","commit_id":"6640f3e043ea8d01733f4c91d1468a72458e564e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5b9d9fe56e118c2925b407850de8359692b6100b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"All router ports (internal and external) used to be excluded from QoS policies applied on network. This patch excludles only internal router ports from network QoS policies."},{"line_number":10,"context_line":"This allows cloud administrators to set an egress Qos policiy to a public/external network and have the QoS policy applied on all external router ports (DVR or not). To the tenant this is also egress traffic so no confusion compared to QoS policies applied to VM ports."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact"},{"line_number":13,"context_line":"Change-Id: I2428c2466f41a022196576f4b14526752543da7a"},{"line_number":14,"context_line":"Closes-Bug: #1659265"},{"line_number":15,"context_line":"Related-Bug: #1486039"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a461143_7a783ec5","line":12,"updated":"2017-01-26 19:53:42.000000000","message":"you must provide a draft text here explaining what to put/update in docs","commit_id":"6640f3e043ea8d01733f4c91d1468a72458e564e"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"01c9e39feafb9ef69b1fdd03534be10fe8ca92e1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"All router ports (internal and external) used to be excluded from QoS policies applied on network. This patch excludles only internal router ports from network QoS policies."},{"line_number":10,"context_line":"This allows cloud administrators to set an egress Qos policiy to a public/external network and have the QoS policy applied on all external router ports (DVR or not). To the tenant this is also egress traffic so no confusion compared to QoS policies applied to VM ports."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact"},{"line_number":13,"context_line":"Change-Id: I2428c2466f41a022196576f4b14526752543da7a"},{"line_number":14,"context_line":"Closes-Bug: #1659265"},{"line_number":15,"context_line":"Related-Bug: #1486039"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a461143_8e991b22","line":12,"in_reply_to":"3a461143_7a783ec5","updated":"2017-01-27 08:48:22.000000000","message":"Sorry, I didn\u0027t explain that, may be a release note could help with that?","commit_id":"6640f3e043ea8d01733f4c91d1468a72458e564e"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d31b5884bfd5131d36b30ca038b35931957b45ec","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Apply QoS policy on network:router_gateway"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"All router ports (internal and external) used to be excluded from QoS policies"},{"line_number":10,"context_line":"applied on network. This patch excludles only internal router ports from"},{"line_number":11,"context_line":"network QoS policies."},{"line_number":12,"context_line":"This allows cloud administrators to set an egress Qos policiy to a"},{"line_number":13,"context_line":"public/external network and have the QoS policy applied on all external router"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1a1ced50_feed3326","line":10,"range":{"start_line":10,"start_character":31,"end_line":10,"end_character":40},"updated":"2017-03-17 02:54:14.000000000","message":"excludles ??? \nexcludes :)","commit_id":"81ce49213bf336bab344f673c84917466c62dfad"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d31b5884bfd5131d36b30ca038b35931957b45ec","unresolved":false,"context_lines":[{"line_number":9,"context_line":"All router ports (internal and external) used to be excluded from QoS policies"},{"line_number":10,"context_line":"applied on network. This patch excludles only internal router ports from"},{"line_number":11,"context_line":"network QoS policies."},{"line_number":12,"context_line":"This allows cloud administrators to set an egress Qos policiy to a"},{"line_number":13,"context_line":"public/external network and have the QoS policy applied on all external router"},{"line_number":14,"context_line":"ports (DVR or not). To the tenant this is also egress traffic so no confusion"},{"line_number":15,"context_line":"compared to QoS policies applied to VM ports."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1a1ced50_1eca0fa2","line":12,"range":{"start_line":12,"start_character":50,"end_line":12,"end_character":53},"updated":"2017-03-17 02:54:14.000000000","message":"Qos -\u003e QoS","commit_id":"81ce49213bf336bab344f673c84917466c62dfad"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"231cf1454b842fc93a0d4e28d61af895ead1cbab","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Apply QoS policy on network:router_gateway"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"All router ports (internal and external) used to be excluded from QoS policies"},{"line_number":10,"context_line":"applied on network. This patch excludes only internal router ports from"},{"line_number":11,"context_line":"network QoS policies."},{"line_number":12,"context_line":"This allows cloud administrators to set an egress QoS policiy to a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"1a1ced50_c27239e5","line":9,"range":{"start_line":9,"start_character":70,"end_line":9,"end_character":78},"updated":"2017-03-17 23:48:12.000000000","message":"Per https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure, could you please wrap this line at 72 characters","commit_id":"fec7d4f9ac383b9868350101d9be9802841761f7"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"231cf1454b842fc93a0d4e28d61af895ead1cbab","unresolved":false,"context_lines":[{"line_number":10,"context_line":"applied on network. This patch excludes only internal router ports from"},{"line_number":11,"context_line":"network QoS policies."},{"line_number":12,"context_line":"This allows cloud administrators to set an egress QoS policiy to a"},{"line_number":13,"context_line":"public/external network and have the QoS policy applied on all external router"},{"line_number":14,"context_line":"ports (DVR or not). To the tenant this is also egress traffic so no confusion"},{"line_number":15,"context_line":"compared to QoS policies applied to VM ports."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"1a1ced50_22822d95","line":13,"range":{"start_line":13,"start_character":72,"end_line":13,"end_character":78},"updated":"2017-03-17 23:48:12.000000000","message":"Ditto","commit_id":"fec7d4f9ac383b9868350101d9be9802841761f7"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"231cf1454b842fc93a0d4e28d61af895ead1cbab","unresolved":false,"context_lines":[{"line_number":11,"context_line":"network QoS policies."},{"line_number":12,"context_line":"This allows cloud administrators to set an egress QoS policiy to a"},{"line_number":13,"context_line":"public/external network and have the QoS policy applied on all external router"},{"line_number":14,"context_line":"ports (DVR or not). To the tenant this is also egress traffic so no confusion"},{"line_number":15,"context_line":"compared to QoS policies applied to VM ports."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"1a1ced50_427f29aa","line":14,"range":{"start_line":14,"start_character":68,"end_line":14,"end_character":77},"updated":"2017-03-17 23:48:12.000000000","message":"Ditto","commit_id":"fec7d4f9ac383b9868350101d9be9802841761f7"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ffe91e72c76e5f21020d01cba7a2c6b6a8159f00","unresolved":false,"context_lines":[{"line_number":9,"context_line":"All router ports (internal and external) used to be excluded from QoS"},{"line_number":10,"context_line":"policies applied on network. This patch excludes only internal router"},{"line_number":11,"context_line":"ports from network QoS policies."},{"line_number":12,"context_line":"This allows cloud administrators to set an egress QoS policiy to a"},{"line_number":13,"context_line":"public/external network and have the QoS policy applied on all external"},{"line_number":14,"context_line":"router ports (DVR or not). To the tenant this is also egress traffic so"},{"line_number":15,"context_line":"no confusion compared to QoS policies applied to VM ports."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"1a1ced50_ee3b6e36","line":12,"range":{"start_line":12,"start_character":54,"end_line":12,"end_character":61},"updated":"2017-03-20 18:02:57.000000000","message":"nit: /s/policiy/policy","commit_id":"2086f37fc914a5268a175804a6dce7f30e1c3001"}],"neutron/objects/qos/rule.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a37389d367020fbc720a375c3929d6fd3b7f2b09","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                                     in constants.DEVICE_OWNER_PREFIXES)"},{"line_number":87,"context_line":"        is_router_ext \u003d any(port[\u0027device_owner\u0027].startswith(prefix)"},{"line_number":88,"context_line":"                                     for prefix"},{"line_number":89,"context_line":"                                     in [DEVICE_OWNER_AGENT_GW,"},{"line_number":90,"context_line":"                                     constants.DEVICE_OWNER_ROUTER_GW])"},{"line_number":91,"context_line":"        return not (is_network_rule and is_network_device_port) or is_router_ext"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_e6e782aa","line":89,"range":{"start_line":89,"start_character":41,"end_line":89,"end_character":62},"updated":"2017-01-25 15:09:08.000000000","message":"s / DEVICE_OWNER_AGENT_GW / constants.DEVICE_OWNER_AGENT_GW","commit_id":"7910e91bf4999db10a05a6d769e096da3767da17"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3c7d09b283828328c7f52843e8f2f87e07e4ea62","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        is_network_device_port \u003d any(port[\u0027device_owner\u0027].startswith(prefix)"},{"line_number":85,"context_line":"                                     for prefix"},{"line_number":86,"context_line":"                                     in constants.DEVICE_OWNER_PREFIXES)"},{"line_number":87,"context_line":"        is_router_ext \u003d any(port[\u0027device_owner\u0027].startswith(prefix)"},{"line_number":88,"context_line":"                                     for prefix"},{"line_number":89,"context_line":"                                     in [constants.DEVICE_OWNER_AGENT_GW,"},{"line_number":90,"context_line":"                                     constants.DEVICE_OWNER_ROUTER_GW])"},{"line_number":91,"context_line":"        return not (is_network_rule and is_network_device_port) or is_router_ext"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"@obj_base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_814b08b0","line":91,"range":{"start_line":87,"start_character":0,"end_line":91,"end_character":80},"updated":"2017-01-25 15:26:03.000000000","message":"I missed that. Please, fix indentation::\n\n        is_router_ext \u003d any(port[\u0027device_owner\u0027].startswith(prefix)\n                            for prefix in [constants.DEVICE_OWNER_AGENT_GW,\n                                           constants.DEVICE_OWNER_ROUTER_GW])\n        return (not (is_network_rule and is_network_device_port) or\n                is_router_ext)","commit_id":"baaa0b7014dc68f065f5083c4a9f9dc9827a14d4"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f9e7faf151150d9cbd78052ec132a90b71a2a0c5","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                                     in constants.DEVICE_OWNER_PREFIXES)"},{"line_number":87,"context_line":"        is_router_gw \u003d any(port[\u0027device_owner\u0027].startswith(prefix)"},{"line_number":88,"context_line":"                            for prefix"},{"line_number":89,"context_line":"                            in [constants.DEVICE_OWNER_AGENT_GW,"},{"line_number":90,"context_line":"                                constants.DEVICE_OWNER_ROUTER_GW])"},{"line_number":91,"context_line":"        return not (is_network_rule and is_network_device_port) or is_router_gw"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_62d99421","line":89,"range":{"start_line":89,"start_character":42,"end_line":89,"end_character":63},"updated":"2017-01-26 10:32:47.000000000","message":"So agent GW is for DVR, and the other is for normal legacy routers, right?\n\nCould we clarify this on a comment over L87 ?, It isn\u0027t really obvious and well documented.\n\nThank you :)","commit_id":"d99593fbe1ba8399ac995a3bf52060f6a4b99455"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b77f13787eb2711f5b8d1f42f7f6bffea14891de","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                                     for prefix"},{"line_number":87,"context_line":"                                     in constants.DEVICE_OWNER_PREFIXES)"},{"line_number":88,"context_line":"        # NOTE(miouge): Network QoS policies should apply to ext routers ports:"},{"line_number":89,"context_line":"        # - DEVICE_OWNER_AGENT_GW for DVR routers"},{"line_number":90,"context_line":"        # - DEVICE_OWNER_ROUTER_GW for normal neutron routers"},{"line_number":91,"context_line":"        is_router_gw \u003d any(port[\u0027device_owner\u0027].startswith(prefix)"},{"line_number":92,"context_line":"                           for prefix"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a30ddce_00834505","line":89,"updated":"2017-03-08 14:39:26.000000000","message":"for DVR it is not clear how the QoS will be enforced. For example BW limitation. Can you please explain","commit_id":"1558507f627553ee904c548e3d255c889c123b44"},{"author":{"_account_id":24132,"name":"Maxime Guyot","email":"maxime@root314.com","username":"miouge"},"change_message_id":"d0a5c58ab5e7eff332a52e934fb590c3e4cb4513","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                                     for prefix"},{"line_number":87,"context_line":"                                     in constants.DEVICE_OWNER_PREFIXES)"},{"line_number":88,"context_line":"        # NOTE(miouge): Network QoS policies should apply to ext routers ports:"},{"line_number":89,"context_line":"        # - DEVICE_OWNER_AGENT_GW for DVR routers"},{"line_number":90,"context_line":"        # - DEVICE_OWNER_ROUTER_GW for normal neutron routers"},{"line_number":91,"context_line":"        is_router_gw \u003d any(port[\u0027device_owner\u0027].startswith(prefix)"},{"line_number":92,"context_line":"                           for prefix"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a30ddce_be88d623","line":89,"in_reply_to":"9a30ddce_00834505","updated":"2017-03-08 15:29:45.000000000","message":"You right this comment is misleading or incorrect. This patch does not do any DVR specific change. The check on constants.DEVICE_OWNER_AGENT_GW should cover network:floatingip_agent_gateway and DEVICE_OWNER_ROUTER_GW covers network:router_gateway both of which are external facing router ports which today are excluded (see bug report).","commit_id":"1558507f627553ee904c548e3d255c889c123b44"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b77f13787eb2711f5b8d1f42f7f6bffea14891de","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        # - DEVICE_OWNER_ROUTER_GW for normal neutron routers"},{"line_number":91,"context_line":"        is_router_gw \u003d any(port[\u0027device_owner\u0027].startswith(prefix)"},{"line_number":92,"context_line":"                           for prefix"},{"line_number":93,"context_line":"                           in [constants.DEVICE_OWNER_AGENT_GW,"},{"line_number":94,"context_line":"                            constants.DEVICE_OWNER_ROUTER_GW])"},{"line_number":95,"context_line":"        # NOTE(ralonsoh): return True if:"},{"line_number":96,"context_line":"        #    - Is a port QoS policy (not a network QoS policy)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a30ddce_c0884d25","line":93,"updated":"2017-03-08 14:39:26.000000000","message":"please fix the indentation here","commit_id":"1558507f627553ee904c548e3d255c889c123b44"},{"author":{"_account_id":24132,"name":"Maxime Guyot","email":"maxime@root314.com","username":"miouge"},"change_message_id":"d0a5c58ab5e7eff332a52e934fb590c3e4cb4513","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        # - DEVICE_OWNER_ROUTER_GW for normal neutron routers"},{"line_number":91,"context_line":"        is_router_gw \u003d any(port[\u0027device_owner\u0027].startswith(prefix)"},{"line_number":92,"context_line":"                           for prefix"},{"line_number":93,"context_line":"                           in [constants.DEVICE_OWNER_AGENT_GW,"},{"line_number":94,"context_line":"                            constants.DEVICE_OWNER_ROUTER_GW])"},{"line_number":95,"context_line":"        # NOTE(ralonsoh): return True if:"},{"line_number":96,"context_line":"        #    - Is a port QoS policy (not a network QoS policy)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a30ddce_43038742","line":93,"in_reply_to":"9a30ddce_c0884d25","updated":"2017-03-08 15:29:45.000000000","message":"Can you highlight the indentation problem? I don\u0027t see what is wrong.","commit_id":"1558507f627553ee904c548e3d255c889c123b44"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7ce196c631c0453fd9894178f17325e74b996328","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        # - DEVICE_OWNER_AGENT_GW for DVR routers"},{"line_number":90,"context_line":"        # - DEVICE_OWNER_ROUTER_GW for normal neutron routers"},{"line_number":91,"context_line":"        is_router_gw \u003d any(port[\u0027device_owner\u0027].startswith(prefix)"},{"line_number":92,"context_line":"                           for prefix"},{"line_number":93,"context_line":"                           in [constants.DEVICE_OWNER_AGENT_GW,"},{"line_number":94,"context_line":"                            constants.DEVICE_OWNER_ROUTER_GW])"},{"line_number":95,"context_line":"        # NOTE(ralonsoh): return True if:"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a30ddce_24f7f959","line":92,"updated":"2017-03-13 00:18:49.000000000","message":"I think in previous patchset, garyk wanted to see something like this:\n\n        is_router_gw \u003d any(port[\u0027device_owner\u0027].startswith(prefix)\n                           for prefix in [constants.DEVICE_OWNER_AGENT_GW,\n                                          constants.DEVICE_OWNER_ROUTER_GW])","commit_id":"81ce49213bf336bab344f673c84917466c62dfad"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"945eff01c56f1fcdee9073c9bf23354b0914107b","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        # NOTE(ralonsoh): return True if:"},{"line_number":96,"context_line":"        #    - Is a port QoS policy (not a network QoS policy)"},{"line_number":97,"context_line":"        #    - Is not a network device (e.g. router) and is a network QoS"},{"line_number":98,"context_line":"        #      policy and there is no port QoS policy"},{"line_number":99,"context_line":"        return (is_port_policy or is_router_gw or"},{"line_number":100,"context_line":"                (not is_network_device_port and is_network_policy_only))"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3a1ff146_bc1d87bf","line":98,"updated":"2017-03-14 21:12:30.000000000","message":"nit: this comment above should be updated also","commit_id":"81ce49213bf336bab344f673c84917466c62dfad"}],"neutron/tests/unit/objects/qos/test_rule.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0ba7896d986097f35ec92e449ded1161fca4bf31","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            device_owner\u003dDEVICE_OWNER_COMPUTE,"},{"line_number":80,"context_line":"            expected_result\u003dTrue)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def test_should_apply_to_port_with_router_gw_port_and_net_policy(self):"},{"line_number":83,"context_line":"        self._test_should_apply_to_port("},{"line_number":84,"context_line":"            rule_policy_id\u003dPOLICY_ID_B,"},{"line_number":85,"context_line":"            port_policy_id\u003dPOLICY_ID_A,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a22e58a_8e489a5d","line":82,"updated":"2017-03-14 09:26:34.000000000","message":"You should also test for DEVICE_OWNER_AGENT_GW","commit_id":"81ce49213bf336bab344f673c84917466c62dfad"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0ba7896d986097f35ec92e449ded1161fca4bf31","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def test_should_apply_to_port_with_router_gw_port_and_net_policy(self):"},{"line_number":83,"context_line":"        self._test_should_apply_to_port("},{"line_number":84,"context_line":"            rule_policy_id\u003dPOLICY_ID_B,"},{"line_number":85,"context_line":"            port_policy_id\u003dPOLICY_ID_A,"},{"line_number":86,"context_line":"            device_owner\u003dconstants.DEVICE_OWNER_ROUTER_GW,"},{"line_number":87,"context_line":"            expected_result\u003dTrue)"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a22e58a_6e4b5e5a","line":85,"range":{"start_line":84,"start_character":12,"end_line":85,"end_character":39},"updated":"2017-03-14 09:26:34.000000000","message":"This test is agains bug #1659312 and bug #1665282:\n- #1659312: enforce qos policies on router interfaces\n- #1665282: port qos prevails over net qos\n\n--\u003e in this test case, port policy (A) is overwritten by net policy B.\n\nIn the logic, you should reduce the number of elements in \"is_network_device_port\": external router ports should be considered as network device ports. With this, the logic will pass.","commit_id":"81ce49213bf336bab344f673c84917466c62dfad"}],"releasenotes/notes/qos-for-router-gateway-02340f7aa8be3b0d.yaml":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d31b5884bfd5131d36b30ca038b35931957b45ec","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    Network QoS policies are now supported for network:router_gateway ports."},{"line_number":3,"context_line":"features:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    Neutron QoS policies set on a external network now apply to external"},{"line_number":6,"context_line":"    router ports (DVR or not)."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1a1ced50_de04f7c7","line":5,"range":{"start_line":5,"start_character":32,"end_line":5,"end_character":33},"updated":"2017-03-17 02:54:14.000000000","message":"a -\u003e an","commit_id":"81ce49213bf336bab344f673c84917466c62dfad"}]}
