)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8287f766bd1cb0188705f0a8e5322ffd52ef7825","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix WaitTimeout string representations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since eventlet.TimeoutError constructor is not called,"},{"line_number":10,"context_line":"TimeoutError __str__and __repr__ are not usable."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change ensures that the methods from the Exception"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_192665ce","line":9,"range":{"start_line":9,"start_character":40,"end_line":9,"end_character":53},"updated":"2017-01-26 21:17:33.000000000","message":"then maybe we should call it?","commit_id":"f66a216c97ed37a8100ffd7de5d9a4eb030e82bf"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"3b8346463e7ea4dc08f7f5e58d75f464fa31c9f7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix WaitTimeout string representations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since eventlet.TimeoutError constructor is not called,"},{"line_number":10,"context_line":"TimeoutError __str__and __repr__ are not usable."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change ensures that the methods from the Exception"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_bc853f5a","line":9,"range":{"start_line":9,"start_character":40,"end_line":9,"end_character":53},"in_reply_to":"3a461143_192665ce","updated":"2017-01-26 21:26:59.000000000","message":"This constructor seems to have significant side effects:\n\nhttps://github.com/eventlet/eventlet/blob/master/eventlet/timeout.py#L55\n\nI thought that it was probably on purpose that it wasn\u0027t called.","commit_id":"f66a216c97ed37a8100ffd7de5d9a4eb030e82bf"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"69703e0a74393d3dbd835d6afa96c08267c1d66b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix WaitTimeout string representations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since eventlet.TimeoutError constructor is not called,"},{"line_number":10,"context_line":"TimeoutError __str__and __repr__ are not usable."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change ensures that the methods from the Exception"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_6aeea9b5","line":9,"range":{"start_line":9,"start_character":40,"end_line":9,"end_character":53},"in_reply_to":"3a461143_2ae3c106","updated":"2017-01-26 22:10:30.000000000","message":"Introducing this WaitTimeout exception seems to have been done with particular care for backwards compat, so possibly some code tries to match the raised exception with an eventlet timeout and this needs to be preserved.","commit_id":"f66a216c97ed37a8100ffd7de5d9a4eb030e82bf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6e8d2d50d632b744aba60851471609171c86207b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix WaitTimeout string representations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since eventlet.TimeoutError constructor is not called,"},{"line_number":10,"context_line":"TimeoutError __str__and __repr__ are not usable."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change ensures that the methods from the Exception"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_1727e5b6","line":9,"range":{"start_line":9,"start_character":40,"end_line":9,"end_character":53},"in_reply_to":"3a461143_6aeea9b5","updated":"2017-01-27 18:07:57.000000000","message":"Yeah, I guess that\u0027s an explanation. At this point though, I wonder if we should really keep that inheritance. It complicates the logic somewhat, and leaves us open to other potential issues due to us not executing __init__ for a parent.","commit_id":"f66a216c97ed37a8100ffd7de5d9a4eb030e82bf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"dc9f35fd809dd77d047f3426382b1701215e6121","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix WaitTimeout string representations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since eventlet.TimeoutError constructor is not called,"},{"line_number":10,"context_line":"TimeoutError __str__and __repr__ are not usable."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change ensures that the methods from the Exception"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_2ae3c106","line":9,"range":{"start_line":9,"start_character":40,"end_line":9,"end_character":53},"in_reply_to":"3a461143_bc853f5a","updated":"2017-01-26 22:03:59.000000000","message":"So one thing that I don\u0027t completely follow is why we even want to inherit from TimeoutError.","commit_id":"f66a216c97ed37a8100ffd7de5d9a4eb030e82bf"}],"neutron/common/utils.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8287f766bd1cb0188705f0a8e5322ffd52ef7825","unresolved":false,"context_lines":[{"line_number":59,"context_line":"synchronized \u003d lockutils.synchronized_with_prefix(SYNCHRONIZED_PREFIX)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class WaitTimeout(Exception, eventlet.TimeoutError):"},{"line_number":63,"context_line":"    \"\"\"Default exception coming from wait_until_true() function."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    The reason is that eventlet.TimeoutError inherits from BaseException and"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_59070d1c","line":62,"range":{"start_line":62,"start_character":19,"end_line":62,"end_character":50},"updated":"2017-01-26 21:17:33.000000000","message":"is it something that happens because of MRO of the class? Would changing the order of parent classes help? Do we even need Exception one (we wouldn\u0027t need it if eventlet.TimeoutError is itself Exception).","commit_id":"f66a216c97ed37a8100ffd7de5d9a4eb030e82bf"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"3b8346463e7ea4dc08f7f5e58d75f464fa31c9f7","unresolved":false,"context_lines":[{"line_number":59,"context_line":"synchronized \u003d lockutils.synchronized_with_prefix(SYNCHRONIZED_PREFIX)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class WaitTimeout(Exception, eventlet.TimeoutError):"},{"line_number":63,"context_line":"    \"\"\"Default exception coming from wait_until_true() function."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    The reason is that eventlet.TimeoutError inherits from BaseException and"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_fcb7c7f2","line":62,"range":{"start_line":62,"start_character":19,"end_line":62,"end_character":50},"in_reply_to":"3a461143_59070d1c","updated":"2017-01-26 21:26:59.000000000","message":"The comment below (L63-68) seems to explain why the inheritance from Exception.\n\nOn the MRO:\n\n\u003e\u003e\u003e neutron.common.utils.WaitTimeout.__mro__\n(\u003cclass \u0027neutron.common.utils.WaitTimeout\u0027\u003e, \u003ctype \u0027exceptions.Exception\u0027\u003e, \u003cclass \u0027eventlet.timeout.Timeout\u0027\u003e, \u003ctype \u0027exceptions.BaseException\u0027\u003e, \u003ctype \u0027object\u0027\u003e)\n\nI guess Exception must inherit __str__ from BaseException or object, and the implementation from evenlet.timeout.TimeOut takes over ?  (I won\u0027t claim being an MRO specialist, and that\u0027s a euphemism)","commit_id":"f66a216c97ed37a8100ffd7de5d9a4eb030e82bf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"dc9f35fd809dd77d047f3426382b1701215e6121","unresolved":false,"context_lines":[{"line_number":59,"context_line":"synchronized \u003d lockutils.synchronized_with_prefix(SYNCHRONIZED_PREFIX)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class WaitTimeout(Exception, eventlet.TimeoutError):"},{"line_number":63,"context_line":"    \"\"\"Default exception coming from wait_until_true() function."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    The reason is that eventlet.TimeoutError inherits from BaseException and"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_ea29b938","line":62,"range":{"start_line":62,"start_character":19,"end_line":62,"end_character":50},"in_reply_to":"3a461143_fcb7c7f2","updated":"2017-01-26 22:03:59.000000000","message":"Yes, that\u0027s what happens.","commit_id":"f66a216c97ed37a8100ffd7de5d9a4eb030e82bf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6e8d2d50d632b744aba60851471609171c86207b","unresolved":false,"context_lines":[{"line_number":729,"context_line":"    Wait until callable predicate is evaluated as True"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"    :param predicate: Callable deciding whether waiting should continue."},{"line_number":732,"context_line":"        Best practice is to instantiate predicate with functools.partial()"},{"line_number":733,"context_line":"    :param timeout: Timeout in seconds how long should function wait."},{"line_number":734,"context_line":"    :param sleep: Polling interval for results in seconds."},{"line_number":735,"context_line":"    :param exception: Exception instance to raise on timeout. If None is passed"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_44353df5","line":732,"range":{"start_line":732,"start_character":4,"end_line":732,"end_character":8},"updated":"2017-01-27 18:07:57.000000000","message":"unrelated change?","commit_id":"f66a216c97ed37a8100ffd7de5d9a4eb030e82bf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1b46a10f7dd1a2e1efb928ec1d336a1961f01067","unresolved":false,"context_lines":[{"line_number":59,"context_line":"synchronized \u003d lockutils.synchronized_with_prefix(SYNCHRONIZED_PREFIX)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class WaitTimeout(Exception, eventlet.TimeoutError):"},{"line_number":63,"context_line":"    \"\"\"Default exception coming from wait_until_true() function."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    The reason is that eventlet.TimeoutError inherits from BaseException and"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_9a693cc1","line":62,"updated":"2017-01-27 18:34:36.000000000","message":"I understand we may want to avoid drastic changes that late in the cycle, so removing TimeoutError from the list of parents is probably not ideal now, but can we at least add a TODO here suggesting to clean that up in a next cycle?\n\nI think this multiple inheritance may bite us again in the future unless we kill it.","commit_id":"b6d9a3f0a3510530ea4de28937d6f8595068531a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2503f45d44054a4ab0609d7eb8b0037aff3af423","unresolved":false,"context_lines":[{"line_number":59,"context_line":"synchronized \u003d lockutils.synchronized_with_prefix(SYNCHRONIZED_PREFIX)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class WaitTimeout(Exception, eventlet.TimeoutError):"},{"line_number":63,"context_line":"    \"\"\"Default exception coming from wait_until_true() function."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    The reason is that eventlet.TimeoutError inherits from BaseException and"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_e6b54931","line":62,"in_reply_to":"3a461143_9a693cc1","updated":"2017-01-27 20:25:52.000000000","message":"Actually, we already warn in line 746 about the plan to kill multiple inheritance in Pike, so we are probably good to go.","commit_id":"b6d9a3f0a3510530ea4de28937d6f8595068531a"}]}
