)]}'
{"neutron/common/exceptions.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"422376c1489fb397bcd268581e8ceaad690b17d4","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"class QosRuleNotSupported(e.Conflict):"},{"line_number":115,"context_line":"    message \u003d _(\"Rule %(rule_type)s is not supported by port %(port_id)s\")"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"class UnsupportedPortDeviceOwner(e.Conflict):"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_0800de00","line":115,"updated":"2017-03-20 02:54:11.000000000","message":"IMHO , this error message doesnt look to descriptive.\nIf some information can be provided, then it would be better","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fc43ca47806d7f18cf0bb9f7aacc60ed0af7bd07","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"class QosRuleNotSupported(e.Conflict):"},{"line_number":115,"context_line":"    message \u003d _(\"Rule %(rule_type)s is not supported by port %(port_id)s\")"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"class UnsupportedPortDeviceOwner(e.Conflict):"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_87de583d","line":115,"in_reply_to":"1a1ced50_0800de00","updated":"2017-03-20 21:16:28.000000000","message":"What more informations You would expect here?\n\nIn place where this is raised I have access to Port dict and to rule object. So it can be something like:\n\n    \"Rule %(rule_type)s is not supported by port %(port_id)s with %(vif_type)s binding_type\"\n\nbut will it be better? What You think?","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5d76e56580165a29c7f960640b1d4c261b4bff94","unresolved":false,"context_lines":[{"line_number":815,"context_line":""},{"line_number":816,"context_line":"            kwargs \u003d {\u0027context\u0027: context, \u0027network\u0027: updated_network,"},{"line_number":817,"context_line":"                      \u0027original_network\u0027: original_network}"},{"line_number":818,"context_line":"            registry.notify("},{"line_number":819,"context_line":"                resources.NETWORK, events.BEFORE_UPDATE, self, **kwargs)"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"            # TODO(QoS): Move out to the extension framework somehow."},{"line_number":822,"context_line":"            need_network_update_notify \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_a83e8925","line":819,"range":{"start_line":818,"start_character":12,"end_line":819,"end_character":72},"updated":"2017-03-10 10:22:38.000000000","message":"Should the notification be sent before starting the transaction?\n\nIt\u0027s a BEFORE_UPDATE event.","commit_id":"5afb0e35c7b654b28270fa06a2f8f8e18449acf4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"23a5f4fd1ca4940b3e83084ca1ac117f21059ac6","unresolved":false,"context_lines":[{"line_number":815,"context_line":""},{"line_number":816,"context_line":"            kwargs \u003d {\u0027context\u0027: context, \u0027network\u0027: updated_network,"},{"line_number":817,"context_line":"                      \u0027original_network\u0027: original_network}"},{"line_number":818,"context_line":"            registry.notify("},{"line_number":819,"context_line":"                resources.NETWORK, events.BEFORE_UPDATE, self, **kwargs)"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"            # TODO(QoS): Move out to the extension framework somehow."},{"line_number":822,"context_line":"            need_network_update_notify \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_9c500c0d","line":819,"range":{"start_line":818,"start_character":12,"end_line":819,"end_character":72},"in_reply_to":"9a30ddce_1980c5bf","updated":"2017-03-10 23:10:09.000000000","message":"Done","commit_id":"5afb0e35c7b654b28270fa06a2f8f8e18449acf4"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e8e3b5d25dea435e9a577b7a62ffbe636918f8ca","unresolved":false,"context_lines":[{"line_number":815,"context_line":""},{"line_number":816,"context_line":"            kwargs \u003d {\u0027context\u0027: context, \u0027network\u0027: updated_network,"},{"line_number":817,"context_line":"                      \u0027original_network\u0027: original_network}"},{"line_number":818,"context_line":"            registry.notify("},{"line_number":819,"context_line":"                resources.NETWORK, events.BEFORE_UPDATE, self, **kwargs)"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"            # TODO(QoS): Move out to the extension framework somehow."},{"line_number":822,"context_line":"            need_network_update_notify \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_1980c5bf","line":819,"range":{"start_line":818,"start_character":12,"end_line":819,"end_character":72},"in_reply_to":"9a30ddce_a83e8925","updated":"2017-03-10 13:21:25.000000000","message":"right, this would be UPDATE_PRECOMMIT I believe :)","commit_id":"5afb0e35c7b654b28270fa06a2f8f8e18449acf4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5d76e56580165a29c7f960640b1d4c261b4bff94","unresolved":false,"context_lines":[{"line_number":1417,"context_line":"                \u0027port\u0027: updated_port,"},{"line_number":1418,"context_line":"                \u0027original_port\u0027: original_port,"},{"line_number":1419,"context_line":"            }"},{"line_number":1420,"context_line":"            registry.notify("},{"line_number":1421,"context_line":"                resources.PORT, events.BEFORE_UPDATE, self, **kwargs)"},{"line_number":1422,"context_line":""},{"line_number":1423,"context_line":"            # TODO(QoS): Move out to the extension framework somehow."},{"line_number":1424,"context_line":"            # Follow https://review.openstack.org/#/c/169223 for a solution."}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_8841c5ab","line":1421,"range":{"start_line":1420,"start_character":11,"end_line":1421,"end_character":69},"updated":"2017-03-10 10:22:38.000000000","message":"Should be the notification sent before starting the transaction?","commit_id":"5afb0e35c7b654b28270fa06a2f8f8e18449acf4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"23a5f4fd1ca4940b3e83084ca1ac117f21059ac6","unresolved":false,"context_lines":[{"line_number":1417,"context_line":"                \u0027port\u0027: updated_port,"},{"line_number":1418,"context_line":"                \u0027original_port\u0027: original_port,"},{"line_number":1419,"context_line":"            }"},{"line_number":1420,"context_line":"            registry.notify("},{"line_number":1421,"context_line":"                resources.PORT, events.BEFORE_UPDATE, self, **kwargs)"},{"line_number":1422,"context_line":""},{"line_number":1423,"context_line":"            # TODO(QoS): Move out to the extension framework somehow."},{"line_number":1424,"context_line":"            # Follow https://review.openstack.org/#/c/169223 for a solution."}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_1c45fc44","line":1421,"range":{"start_line":1420,"start_character":11,"end_line":1421,"end_character":69},"in_reply_to":"9a30ddce_8841c5ab","updated":"2017-03-10 23:10:09.000000000","message":"changed to PRECOMMIT_UPDATE","commit_id":"5afb0e35c7b654b28270fa06a2f8f8e18449acf4"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"728edbb4f55885520e563cf1f38ac4bd70ef697f","unresolved":false,"context_lines":[{"line_number":1210,"context_line":"                        original_port[psec.PORTSECURITY] !\u003d"},{"line_number":1211,"context_line":"                        updated_port[psec.PORTSECURITY]):"},{"line_number":1212,"context_line":"                need_port_update_notify \u003d True"},{"line_number":1213,"context_line":""},{"line_number":1214,"context_line":"            # TODO(QoS): Move out to the extension framework somehow."},{"line_number":1215,"context_line":"            # Follow https://review.openstack.org/#/c/169223 for a solution."},{"line_number":1216,"context_line":"            if (qos_consts.QOS_POLICY_ID in attrs and"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a1ff146_940c0544","line":1213,"updated":"2017-03-17 12:26:49.000000000","message":"nit unrelated change","commit_id":"f5a199f0dbe7fc4e351250a6faf3a2c4654e669e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a78ace041234d8a0d73d64fdea4bb2aed93b93d8","unresolved":false,"context_lines":[{"line_number":1210,"context_line":"                        original_port[psec.PORTSECURITY] !\u003d"},{"line_number":1211,"context_line":"                        updated_port[psec.PORTSECURITY]):"},{"line_number":1212,"context_line":"                need_port_update_notify \u003d True"},{"line_number":1213,"context_line":""},{"line_number":1214,"context_line":"            # TODO(QoS): Move out to the extension framework somehow."},{"line_number":1215,"context_line":"            # Follow https://review.openstack.org/#/c/169223 for a solution."},{"line_number":1216,"context_line":"            if (qos_consts.QOS_POLICY_ID in attrs and"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a1ced50_a9ce1058","line":1213,"in_reply_to":"3a1ff146_940c0544","updated":"2017-03-17 17:54:41.000000000","message":"Done","commit_id":"f5a199f0dbe7fc4e351250a6faf3a2c4654e669e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"57c7a65285075fa94d61ba7ed258ef7d5aa8feb1","unresolved":false,"context_lines":[{"line_number":813,"context_line":""},{"line_number":814,"context_line":"            updated_network \u003d self.get_network(context, id)"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"            kwargs \u003d {\u0027context\u0027: context, \u0027network\u0027: updated_network,"},{"line_number":817,"context_line":"                      \u0027original_network\u0027: original_network}"},{"line_number":818,"context_line":"            registry.notify("},{"line_number":819,"context_line":"                resources.NETWORK, events.PRECOMMIT_UPDATE, self, **kwargs)"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_7e21084d","line":816,"updated":"2017-03-20 05:42:02.000000000","message":"this code is unrelated to the patch - maybe consider splitting it out in the next patch set. that may make the review cycles a little quicker.","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"082faf207b6805ecae8885df83ae89f4c11b6b28","unresolved":false,"context_lines":[{"line_number":813,"context_line":""},{"line_number":814,"context_line":"            updated_network \u003d self.get_network(context, id)"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"            kwargs \u003d {\u0027context\u0027: context, \u0027network\u0027: updated_network,"},{"line_number":817,"context_line":"                      \u0027original_network\u0027: original_network}"},{"line_number":818,"context_line":"            registry.notify("},{"line_number":819,"context_line":"                resources.NETWORK, events.PRECOMMIT_UPDATE, self, **kwargs)"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_64edda24","line":816,"in_reply_to":"1a1ced50_7e21084d","updated":"2017-03-20 20:50:06.000000000","message":"You\u0027re right. I moved it to new patch: https://review.openstack.org/#/c/447682/","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"57c7a65285075fa94d61ba7ed258ef7d5aa8feb1","unresolved":false,"context_lines":[{"line_number":1073,"context_line":"                    attrs.get(addr_pair.ADDRESS_PAIRS)))"},{"line_number":1074,"context_line":"            self._process_port_create_extra_dhcp_opts(context, result,"},{"line_number":1075,"context_line":"                                                      dhcp_opts)"},{"line_number":1076,"context_line":"            kwargs \u003d {\u0027context\u0027: context, \u0027port\u0027: result}"},{"line_number":1077,"context_line":"            registry.notify("},{"line_number":1078,"context_line":"                resources.PORT, events.PRECOMMIT_CREATE, self, **kwargs)"},{"line_number":1079,"context_line":"            self.mechanism_manager.create_port_precommit(mech_context)"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_9e1c0415","line":1076,"updated":"2017-03-20 05:42:02.000000000","message":"ditto","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"082faf207b6805ecae8885df83ae89f4c11b6b28","unresolved":false,"context_lines":[{"line_number":1073,"context_line":"                    attrs.get(addr_pair.ADDRESS_PAIRS)))"},{"line_number":1074,"context_line":"            self._process_port_create_extra_dhcp_opts(context, result,"},{"line_number":1075,"context_line":"                                                      dhcp_opts)"},{"line_number":1076,"context_line":"            kwargs \u003d {\u0027context\u0027: context, \u0027port\u0027: result}"},{"line_number":1077,"context_line":"            registry.notify("},{"line_number":1078,"context_line":"                resources.PORT, events.PRECOMMIT_CREATE, self, **kwargs)"},{"line_number":1079,"context_line":"            self.mechanism_manager.create_port_precommit(mech_context)"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_64c07ae1","line":1076,"in_reply_to":"1a1ced50_9e1c0415","updated":"2017-03-20 20:50:06.000000000","message":"Done","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"57c7a65285075fa94d61ba7ed258ef7d5aa8feb1","unresolved":false,"context_lines":[{"line_number":1243,"context_line":"            need_port_update_notify |\u003d self._process_port_binding("},{"line_number":1244,"context_line":"                mech_context, attrs)"},{"line_number":1245,"context_line":""},{"line_number":1246,"context_line":"            # Send precommit_update notification for other plugins"},{"line_number":1247,"context_line":"            kwargs \u003d {"},{"line_number":1248,"context_line":"                \u0027context\u0027: context,"},{"line_number":1249,"context_line":"                \u0027port\u0027: updated_port,"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_de167cf0","line":1246,"updated":"2017-03-20 05:42:02.000000000","message":"ditto","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"082faf207b6805ecae8885df83ae89f4c11b6b28","unresolved":false,"context_lines":[{"line_number":1243,"context_line":"            need_port_update_notify |\u003d self._process_port_binding("},{"line_number":1244,"context_line":"                mech_context, attrs)"},{"line_number":1245,"context_line":""},{"line_number":1246,"context_line":"            # Send precommit_update notification for other plugins"},{"line_number":1247,"context_line":"            kwargs \u003d {"},{"line_number":1248,"context_line":"                \u0027context\u0027: context,"},{"line_number":1249,"context_line":"                \u0027port\u0027: updated_port,"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_84b73685","line":1246,"in_reply_to":"1a1ced50_de167cf0","updated":"2017-03-20 20:50:06.000000000","message":"Done","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"}],"neutron/services/qos/drivers/base.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"edd66d038541fab1a2e6b85cf50941b23aa82598","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    def is_rule_supported(self, rule):"},{"line_number":76,"context_line":"        supported_parameters \u003d self.supported_rules.get(rule.rule_type)"},{"line_number":77,"context_line":"        if not supported_parameters:"},{"line_number":78,"context_line":"            LOG.warning(_LW(\"Rule type %(rule_type)s is not supported by \""},{"line_number":79,"context_line":"                            \"%(driver_name)s\"),"},{"line_number":80,"context_line":"                        {\u0027rule_type\u0027: rule.rule_type,"},{"line_number":81,"context_line":"                         \u0027driver_name\u0027: self.name})"}],"source_content_type":"text/x-python","patch_set":4,"id":"da36d5c6_2d441e48","line":78,"updated":"2017-02-28 09:26:53.000000000","message":"I\u0027d use debug here, or we will get full of logs in mixed envs.","commit_id":"169e80d630ac55808144a36441016dd22a32a1ea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"291e0c143c54ab637a4cd8dc3e8ddaeea6311045","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    def is_rule_supported(self, rule):"},{"line_number":76,"context_line":"        supported_parameters \u003d self.supported_rules.get(rule.rule_type)"},{"line_number":77,"context_line":"        if not supported_parameters:"},{"line_number":78,"context_line":"            LOG.warning(_LW(\"Rule type %(rule_type)s is not supported by \""},{"line_number":79,"context_line":"                            \"%(driver_name)s\"),"},{"line_number":80,"context_line":"                        {\u0027rule_type\u0027: rule.rule_type,"},{"line_number":81,"context_line":"                         \u0027driver_name\u0027: self.name})"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_59ca1a1c","line":78,"in_reply_to":"da36d5c6_2d441e48","updated":"2017-03-04 21:41:34.000000000","message":"Done","commit_id":"169e80d630ac55808144a36441016dd22a32a1ea"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"edd66d038541fab1a2e6b85cf50941b23aa82598","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            return False"},{"line_number":83,"context_line":"        for parameter, supported_values in six.iteritems("},{"line_number":84,"context_line":"                supported_parameters):"},{"line_number":85,"context_line":"            if supported_values \u003d\u003d qos_consts.ANY_VALUE:"},{"line_number":86,"context_line":"                continue"},{"line_number":87,"context_line":"            value \u003d rule.get(parameter)"},{"line_number":88,"context_line":"            if value not in supported_values:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da36d5c6_2dea5edb","line":85,"updated":"2017-02-28 09:26:53.000000000","message":"Looks good, but it could be more flexible if we used api validators instead as @yamamoto suggested: \nhttps://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/validators.py","commit_id":"169e80d630ac55808144a36441016dd22a32a1ea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"225777b9d63d0a638dffccc3f59c84e52fccbae7","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            return False"},{"line_number":83,"context_line":"        for parameter, supported_values in six.iteritems("},{"line_number":84,"context_line":"                supported_parameters):"},{"line_number":85,"context_line":"            if supported_values \u003d\u003d qos_consts.ANY_VALUE:"},{"line_number":86,"context_line":"                continue"},{"line_number":87,"context_line":"            value \u003d rule.get(parameter)"},{"line_number":88,"context_line":"            if value not in supported_values:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_c03ff2b1","line":85,"in_reply_to":"ba2be162_32d65bf1","updated":"2017-03-11 10:14:41.000000000","message":"Done in PS11","commit_id":"169e80d630ac55808144a36441016dd22a32a1ea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"35125682fde8581df04f2289408097480bcda38d","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            return False"},{"line_number":83,"context_line":"        for parameter, supported_values in six.iteritems("},{"line_number":84,"context_line":"                supported_parameters):"},{"line_number":85,"context_line":"            if supported_values \u003d\u003d qos_consts.ANY_VALUE:"},{"line_number":86,"context_line":"                continue"},{"line_number":87,"context_line":"            value \u003d rule.get(parameter)"},{"line_number":88,"context_line":"            if value not in supported_values:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_32d65bf1","line":85,"in_reply_to":"da36d5c6_2dea5edb","updated":"2017-03-05 09:17:44.000000000","message":"I will try change it","commit_id":"169e80d630ac55808144a36441016dd22a32a1ea"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"edd66d038541fab1a2e6b85cf50941b23aa82598","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                continue"},{"line_number":87,"context_line":"            value \u003d rule.get(parameter)"},{"line_number":88,"context_line":"            if value not in supported_values:"},{"line_number":89,"context_line":"                LOG.warning(_LW(\"Parameter %(parameter)s\u003d%(value)s in \""},{"line_number":90,"context_line":"                                \"rule type %(rule_type)s is not \""},{"line_number":91,"context_line":"                                \"supported by %(driver_name)s\"),"},{"line_number":92,"context_line":"                            {\u0027parameter\u0027: parameter,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da36d5c6_ad9d6ebd","line":89,"updated":"2017-02-28 09:26:53.000000000","message":"ditto (about logging) :)","commit_id":"169e80d630ac55808144a36441016dd22a32a1ea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"291e0c143c54ab637a4cd8dc3e8ddaeea6311045","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                continue"},{"line_number":87,"context_line":"            value \u003d rule.get(parameter)"},{"line_number":88,"context_line":"            if value not in supported_values:"},{"line_number":89,"context_line":"                LOG.warning(_LW(\"Parameter %(parameter)s\u003d%(value)s in \""},{"line_number":90,"context_line":"                                \"rule type %(rule_type)s is not \""},{"line_number":91,"context_line":"                                \"supported by %(driver_name)s\"),"},{"line_number":92,"context_line":"                            {\u0027parameter\u0027: parameter,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_79cd1e30","line":89,"in_reply_to":"da36d5c6_ad9d6ebd","updated":"2017-03-04 21:41:34.000000000","message":"Done","commit_id":"169e80d630ac55808144a36441016dd22a32a1ea"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f98c34932b84f2cfc33c4f5d9697486049624003","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                      {\u0027rule_type\u0027: rule.rule_type,"},{"line_number":78,"context_line":"                       \u0027driver_name\u0027: self.name})"},{"line_number":79,"context_line":"            return False"},{"line_number":80,"context_line":"        for parameter, supported_values in six.iteritems("},{"line_number":81,"context_line":"                supported_parameters):"},{"line_number":82,"context_line":"            if supported_values \u003d\u003d qos_consts.ANY_VALUE:"},{"line_number":83,"context_line":"                continue"},{"line_number":84,"context_line":"            value \u003d rule.get(parameter)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_46ea2775","line":81,"range":{"start_line":80,"start_character":43,"end_line":81,"end_character":37},"updated":"2017-03-06 08:24:05.000000000","message":"this should be:\n   supported_parameters.items()","commit_id":"a026d29ae4e27907af0da170460544fbff250ae8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"da43998f52dacc63132fc8c93ef64fb22df220c0","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                      {\u0027rule_type\u0027: rule.rule_type,"},{"line_number":78,"context_line":"                       \u0027driver_name\u0027: self.name})"},{"line_number":79,"context_line":"            return False"},{"line_number":80,"context_line":"        for parameter, supported_values in six.iteritems("},{"line_number":81,"context_line":"                supported_parameters):"},{"line_number":82,"context_line":"            if supported_values \u003d\u003d qos_consts.ANY_VALUE:"},{"line_number":83,"context_line":"                continue"},{"line_number":84,"context_line":"            value \u003d rule.get(parameter)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a30ddce_13f3e20b","line":81,"range":{"start_line":80,"start_character":43,"end_line":81,"end_character":37},"in_reply_to":"9a30ddce_0ac49b90","updated":"2017-03-07 10:09:27.000000000","message":"Slawek, please take a look at this: http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html","commit_id":"a026d29ae4e27907af0da170460544fbff250ae8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"59056f32b6ae54bab12dd65597c54f561722c95c","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                      {\u0027rule_type\u0027: rule.rule_type,"},{"line_number":78,"context_line":"                       \u0027driver_name\u0027: self.name})"},{"line_number":79,"context_line":"            return False"},{"line_number":80,"context_line":"        for parameter, supported_values in six.iteritems("},{"line_number":81,"context_line":"                supported_parameters):"},{"line_number":82,"context_line":"            if supported_values \u003d\u003d qos_consts.ANY_VALUE:"},{"line_number":83,"context_line":"                continue"},{"line_number":84,"context_line":"            value \u003d rule.get(parameter)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a30ddce_75e1e199","line":81,"range":{"start_line":80,"start_character":43,"end_line":81,"end_character":37},"in_reply_to":"9a30ddce_13f3e20b","updated":"2017-03-09 21:55:40.000000000","message":"ok, thx. Changed","commit_id":"a026d29ae4e27907af0da170460544fbff250ae8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c3648aed9ea0a18ea801c048bdb56be8fb82c4c9","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                      {\u0027rule_type\u0027: rule.rule_type,"},{"line_number":78,"context_line":"                       \u0027driver_name\u0027: self.name})"},{"line_number":79,"context_line":"            return False"},{"line_number":80,"context_line":"        for parameter, supported_values in six.iteritems("},{"line_number":81,"context_line":"                supported_parameters):"},{"line_number":82,"context_line":"            if supported_values \u003d\u003d qos_consts.ANY_VALUE:"},{"line_number":83,"context_line":"                continue"},{"line_number":84,"context_line":"            value \u003d rule.get(parameter)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a30ddce_0ac49b90","line":81,"range":{"start_line":80,"start_character":43,"end_line":81,"end_character":37},"in_reply_to":"ba2be162_46ea2775","updated":"2017-03-06 22:12:45.000000000","message":"are You sure? I thought that six.iteritems() should be used to make it compatible with python2 and python3","commit_id":"a026d29ae4e27907af0da170460544fbff250ae8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"422376c1489fb397bcd268581e8ceaad690b17d4","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def is_rule_supported(self, rule):"},{"line_number":72,"context_line":"        supported_parameters \u003d self.supported_rules.get(rule.rule_type)"},{"line_number":73,"context_line":"        if not supported_parameters:"},{"line_number":74,"context_line":"            LOG.debug(\"Rule type %(rule_type)s is not supported by \""},{"line_number":75,"context_line":"                      \"%(driver_name)s\","},{"line_number":76,"context_line":"                      {\u0027rule_type\u0027: rule.rule_type,"},{"line_number":77,"context_line":"                       \u0027driver_name\u0027: self.name})"},{"line_number":78,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_a80fca2c","line":75,"range":{"start_line":74,"start_character":12,"end_line":75,"end_character":40},"updated":"2017-03-20 02:54:11.000000000","message":"This seems like a much better log for the exception, because debug logs may not be visible in the production env.","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fc43ca47806d7f18cf0bb9f7aacc60ed0af7bd07","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def is_rule_supported(self, rule):"},{"line_number":72,"context_line":"        supported_parameters \u003d self.supported_rules.get(rule.rule_type)"},{"line_number":73,"context_line":"        if not supported_parameters:"},{"line_number":74,"context_line":"            LOG.debug(\"Rule type %(rule_type)s is not supported by \""},{"line_number":75,"context_line":"                      \"%(driver_name)s\","},{"line_number":76,"context_line":"                      {\u0027rule_type\u0027: rule.rule_type,"},{"line_number":77,"context_line":"                       \u0027driver_name\u0027: self.name})"},{"line_number":78,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_c45f6e3f","line":75,"range":{"start_line":74,"start_character":12,"end_line":75,"end_character":40},"in_reply_to":"1a1ced50_a80fca2c","updated":"2017-03-20 21:16:28.000000000","message":"No, because in case when You will have more drivers (e.g. OVS and SR-IOV) then You will have such messages each time You will create port/create some QoS rule or make other action which will trigger this validation.","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e70685b5838309e0b821416ac5be4dc003a080d3","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                    validator_type)"},{"line_number":84,"context_line":"                validate_result \u003d validator_function(parameter_value,"},{"line_number":85,"context_line":"                                                     validator_data)"},{"line_number":86,"context_line":"                if validate_result:"},{"line_number":87,"context_line":"                    LOG.debug(\"Parameter %(parameter)s\u003d%(value)s in \""},{"line_number":88,"context_line":"                              \"rule type %(rule_type)s is not \""},{"line_number":89,"context_line":"                              \"supported by %(driver_name)s. \""}],"source_content_type":"text/x-python","patch_set":19,"id":"ffe62b97_7056355f","line":86,"range":{"start_line":86,"start_character":19,"end_line":86,"end_character":34},"updated":"2017-03-26 13:52:59.000000000","message":"i would expect this to return False if there was an issue. This is a little confusion here","commit_id":"bffbb0b6da1dea6ffe766c4fefc0c0e053c40535"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c870ed8a718a6e94c06cfcf95fcc06616d314510","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                    validator_type)"},{"line_number":84,"context_line":"                validate_result \u003d validator_function(parameter_value,"},{"line_number":85,"context_line":"                                                     validator_data)"},{"line_number":86,"context_line":"                if validate_result:"},{"line_number":87,"context_line":"                    LOG.debug(\"Parameter %(parameter)s\u003d%(value)s in \""},{"line_number":88,"context_line":"                              \"rule type %(rule_type)s is not \""},{"line_number":89,"context_line":"                              \"supported by %(driver_name)s. \""}],"source_content_type":"text/x-python","patch_set":19,"id":"ffe62b97_68bf69d0","line":86,"range":{"start_line":86,"start_character":19,"end_line":86,"end_character":34},"in_reply_to":"ffe62b97_7056355f","updated":"2017-03-26 21:06:26.000000000","message":"it is like that because that\u0027s how validator function works. It returns None if parameter is valid or reason why it\u0027s not valid.\n\nSo do You think that better would be different variable name (like not_validate_reason instead of validate_result) or maybe just comment why it\u0027s like that would be enough?","commit_id":"bffbb0b6da1dea6ffe766c4fefc0c0e053c40535"}],"neutron/services/qos/drivers/linuxbridge/driver.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f98c34932b84f2cfc33c4f5d9697486049624003","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    qos_consts.RULE_TYPE_DSCP_MARKING: {"},{"line_number":33,"context_line":"        \"dscp_mark\": constants.VALID_DSCP_MARKS"},{"line_number":34,"context_line":"    },"},{"line_number":35,"context_line":"    qos_consts.RULE_TYPE_MINIMUM_BANDWIDTH: {"},{"line_number":36,"context_line":"        \u0027min_kbps\u0027: qos_consts.ANY_VALUE,"},{"line_number":37,"context_line":"        \u0027direction\u0027: constants.VALID_DIRECTIONS"},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":"}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_667acbbe","line":38,"range":{"start_line":35,"start_character":4,"end_line":38,"end_character":5},"updated":"2017-03-06 08:24:05.000000000","message":"It\u0027s a pitty but is not supported yet...","commit_id":"a026d29ae4e27907af0da170460544fbff250ae8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c3648aed9ea0a18ea801c048bdb56be8fb82c4c9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    qos_consts.RULE_TYPE_DSCP_MARKING: {"},{"line_number":33,"context_line":"        \"dscp_mark\": constants.VALID_DSCP_MARKS"},{"line_number":34,"context_line":"    },"},{"line_number":35,"context_line":"    qos_consts.RULE_TYPE_MINIMUM_BANDWIDTH: {"},{"line_number":36,"context_line":"        \u0027min_kbps\u0027: qos_consts.ANY_VALUE,"},{"line_number":37,"context_line":"        \u0027direction\u0027: constants.VALID_DIRECTIONS"},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":"}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a30ddce_4a55b3c4","line":38,"range":{"start_line":35,"start_character":4,"end_line":38,"end_character":5},"in_reply_to":"ba2be162_667acbbe","updated":"2017-03-06 22:12:45.000000000","message":"changed","commit_id":"a026d29ae4e27907af0da170460544fbff250ae8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4248b4a48b3361f2e58a08ce4da56c5308433239","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"SUPPORTED_RULES \u003d {"},{"line_number":28,"context_line":"    qos_consts.RULE_TYPE_BANDWIDTH_LIMIT: {"},{"line_number":29,"context_line":"        \"max_kbps\": {\u0027type:values\u0027: None},"},{"line_number":30,"context_line":"        \"max_burst_kbps\": {\u0027type:values\u0027: None}"},{"line_number":31,"context_line":"    },"},{"line_number":32,"context_line":"    qos_consts.RULE_TYPE_DSCP_MARKING: {"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a22e58a_7ddb121c","line":29,"range":{"start_line":29,"start_character":20,"end_line":29,"end_character":41},"updated":"2017-03-14 11:58:26.000000000","message":"Sorry for this late comment. You should check this:\n  {\u0027type:range\u0027: [0, common_constants.DB_INTEGER_MAX_VALUE]}\n\nLike in neutron.extensions.qos.py","commit_id":"eb22c805abf4bc8d972f813fe8c44f215d408dd4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0140a2feecc451cc04cddb903cb4516f00a7ee23","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"SUPPORTED_RULES \u003d {"},{"line_number":28,"context_line":"    qos_consts.RULE_TYPE_BANDWIDTH_LIMIT: {"},{"line_number":29,"context_line":"        \"max_kbps\": {\u0027type:values\u0027: None},"},{"line_number":30,"context_line":"        \"max_burst_kbps\": {\u0027type:values\u0027: None}"},{"line_number":31,"context_line":"    },"},{"line_number":32,"context_line":"    qos_consts.RULE_TYPE_DSCP_MARKING: {"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a1ff146_196dcd04","line":29,"range":{"start_line":29,"start_character":20,"end_line":29,"end_character":41},"in_reply_to":"5a22e58a_7ddb121c","updated":"2017-03-14 21:01:54.000000000","message":"Done","commit_id":"eb22c805abf4bc8d972f813fe8c44f215d408dd4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4248b4a48b3361f2e58a08ce4da56c5308433239","unresolved":false,"context_lines":[{"line_number":27,"context_line":"SUPPORTED_RULES \u003d {"},{"line_number":28,"context_line":"    qos_consts.RULE_TYPE_BANDWIDTH_LIMIT: {"},{"line_number":29,"context_line":"        \"max_kbps\": {\u0027type:values\u0027: None},"},{"line_number":30,"context_line":"        \"max_burst_kbps\": {\u0027type:values\u0027: None}"},{"line_number":31,"context_line":"    },"},{"line_number":32,"context_line":"    qos_consts.RULE_TYPE_DSCP_MARKING: {"},{"line_number":33,"context_line":"        \"dscp_mark\": {\u0027type:values\u0027: constants.VALID_DSCP_MARKS}"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a22e58a_9dd8ce1f","line":30,"range":{"start_line":30,"start_character":26,"end_line":30,"end_character":47},"updated":"2017-03-14 11:58:26.000000000","message":"ditto","commit_id":"eb22c805abf4bc8d972f813fe8c44f215d408dd4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0140a2feecc451cc04cddb903cb4516f00a7ee23","unresolved":false,"context_lines":[{"line_number":27,"context_line":"SUPPORTED_RULES \u003d {"},{"line_number":28,"context_line":"    qos_consts.RULE_TYPE_BANDWIDTH_LIMIT: {"},{"line_number":29,"context_line":"        \"max_kbps\": {\u0027type:values\u0027: None},"},{"line_number":30,"context_line":"        \"max_burst_kbps\": {\u0027type:values\u0027: None}"},{"line_number":31,"context_line":"    },"},{"line_number":32,"context_line":"    qos_consts.RULE_TYPE_DSCP_MARKING: {"},{"line_number":33,"context_line":"        \"dscp_mark\": {\u0027type:values\u0027: constants.VALID_DSCP_MARKS}"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a1ff146_597745d4","line":30,"range":{"start_line":30,"start_character":26,"end_line":30,"end_character":47},"in_reply_to":"5a22e58a_9dd8ce1f","updated":"2017-03-14 21:01:54.000000000","message":"Done","commit_id":"eb22c805abf4bc8d972f813fe8c44f215d408dd4"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"422376c1489fb397bcd268581e8ceaad690b17d4","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        \"dscp_mark\": {\u0027type:values\u0027: constants.VALID_DSCP_MARKS}"},{"line_number":34,"context_line":"    }"},{"line_number":35,"context_line":"}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class LinuxBridgeDriver(base.DriverBase):"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_a836eae4","line":36,"updated":"2017-03-20 02:54:11.000000000","message":"Where did the Minimum Bandwidth Rule go?\nUpdate: I think that linuixbridge doesnt support Minimum Bandwidth Rule. Is that correct?","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fc43ca47806d7f18cf0bb9f7aacc60ed0af7bd07","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        \"dscp_mark\": {\u0027type:values\u0027: constants.VALID_DSCP_MARKS}"},{"line_number":34,"context_line":"    }"},{"line_number":35,"context_line":"}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class LinuxBridgeDriver(base.DriverBase):"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_c4268ecd","line":36,"in_reply_to":"1a1ced50_a836eae4","updated":"2017-03-20 21:16:28.000000000","message":"Yep, it\u0027s currently not supported by Linuxbridge driver.","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"1fce698c9245b7144ae60e90236f0dd0c9cec737","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"SUPPORTED_RULES \u003d [qos_consts.RULE_TYPE_BANDWIDTH_LIMIT,"},{"line_number":27,"context_line":"                   qos_consts.RULE_TYPE_DSCP_MARKING,"},{"line_number":28,"context_line":"                   qos_consts.RULE_TYPE_MINIMUM_BANDWIDTH]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class LinuxBridgeDriver(base.DriverBase):"}],"source_content_type":"text/x-python","patch_set":17,"id":"ffe62b97_9224480f","side":"PARENT","line":28,"updated":"2017-03-24 14:29:53.000000000","message":"I\u0027d say that if we want to remove it from here we need to do it on a separate patch :)\n\nAlternatively we can fix the support, but it wasn\u0027t simple.","commit_id":"f245ba027954f01b26760439e96957395829fbfc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8718496d67ae3441ef34b644ed584eb660eb8761","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"SUPPORTED_RULES \u003d [qos_consts.RULE_TYPE_BANDWIDTH_LIMIT,"},{"line_number":27,"context_line":"                   qos_consts.RULE_TYPE_DSCP_MARKING,"},{"line_number":28,"context_line":"                   qos_consts.RULE_TYPE_MINIMUM_BANDWIDTH]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class LinuxBridgeDriver(base.DriverBase):"}],"source_content_type":"text/x-python","patch_set":17,"id":"ffe62b97_b8ae0de5","side":"PARENT","line":28,"in_reply_to":"ffe62b97_9224480f","updated":"2017-03-24 14:42:09.000000000","message":"I will propose separate patch for it in few minutes :)","commit_id":"f245ba027954f01b26760439e96957395829fbfc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d9edb89803f2069b5a0b44ce05a304498607b0ff","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"SUPPORTED_RULES \u003d [qos_consts.RULE_TYPE_BANDWIDTH_LIMIT,"},{"line_number":27,"context_line":"                   qos_consts.RULE_TYPE_DSCP_MARKING,"},{"line_number":28,"context_line":"                   qos_consts.RULE_TYPE_MINIMUM_BANDWIDTH]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class LinuxBridgeDriver(base.DriverBase):"}],"source_content_type":"text/x-python","patch_set":17,"id":"ffe62b97_133cba91","side":"PARENT","line":28,"in_reply_to":"ffe62b97_b8ae0de5","updated":"2017-03-24 14:59:56.000000000","message":"So separate patch for this is done: https://review.openstack.org/#/c/449666/","commit_id":"f245ba027954f01b26760439e96957395829fbfc"}],"neutron/services/qos/drivers/manager.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5d76e56580165a29c7f960640b1d4c261b4bff94","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @staticmethod"},{"line_number":94,"context_line":"    def _get_port_vif_type(port):"},{"line_number":95,"context_line":"        try:"},{"line_number":96,"context_line":"            return port[portbindings.VIF_TYPE]"},{"line_number":97,"context_line":"        except KeyError:"},{"line_number":98,"context_line":"            return port[\u0027binding\u0027][\u0027vif_type\u0027]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @staticmethod"},{"line_number":101,"context_line":"    def _get_port_vnic_type(port):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_68e011fb","line":98,"range":{"start_line":95,"start_character":8,"end_line":98,"end_character":46},"updated":"2017-03-10 10:22:38.000000000","message":"1) This can be resumend in one line:\n     return port.get(portbindings.VIF_TYPE, port[\u0027binding\u0027][\u0027vif_type\u0027])\n\n2) I don\u0027t think you need to check port[\u0027binding\u0027][\u0027vif_type\u0027]. The port binding information in the port object, is in \"portbindings.VIF_TYPE\"","commit_id":"5afb0e35c7b654b28270fa06a2f8f8e18449acf4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"23a5f4fd1ca4940b3e83084ca1ac117f21059ac6","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @staticmethod"},{"line_number":94,"context_line":"    def _get_port_vif_type(port):"},{"line_number":95,"context_line":"        try:"},{"line_number":96,"context_line":"            return port[portbindings.VIF_TYPE]"},{"line_number":97,"context_line":"        except KeyError:"},{"line_number":98,"context_line":"            return port[\u0027binding\u0027][\u0027vif_type\u0027]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @staticmethod"},{"line_number":101,"context_line":"    def _get_port_vnic_type(port):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_9c3acc97","line":98,"range":{"start_line":95,"start_character":8,"end_line":98,"end_character":46},"in_reply_to":"9a30ddce_68e011fb","updated":"2017-03-10 23:10:09.000000000","message":"I removed it already","commit_id":"5afb0e35c7b654b28270fa06a2f8f8e18449acf4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5d76e56580165a29c7f960640b1d4c261b4bff94","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @staticmethod"},{"line_number":101,"context_line":"    def _get_port_vnic_type(port):"},{"line_number":102,"context_line":"        try:"},{"line_number":103,"context_line":"            return port[portbindings.VNIC_TYPE]"},{"line_number":104,"context_line":"        except KeyError:"},{"line_number":105,"context_line":"            return port[\u0027binding\u0027][\u0027vnic_type\u0027]"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def call(self, method_name, *args, **kwargs):"},{"line_number":108,"context_line":"        \"\"\"Helper method for calling a method across all extension drivers.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_e8724110","line":105,"range":{"start_line":102,"start_character":6,"end_line":105,"end_character":47},"updated":"2017-03-10 10:22:38.000000000","message":"ditto","commit_id":"5afb0e35c7b654b28270fa06a2f8f8e18449acf4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"23a5f4fd1ca4940b3e83084ca1ac117f21059ac6","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @staticmethod"},{"line_number":101,"context_line":"    def _get_port_vnic_type(port):"},{"line_number":102,"context_line":"        try:"},{"line_number":103,"context_line":"            return port[portbindings.VNIC_TYPE]"},{"line_number":104,"context_line":"        except KeyError:"},{"line_number":105,"context_line":"            return port[\u0027binding\u0027][\u0027vnic_type\u0027]"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def call(self, method_name, *args, **kwargs):"},{"line_number":108,"context_line":"        \"\"\"Helper method for calling a method across all extension drivers.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_bc3dd090","line":105,"range":{"start_line":102,"start_character":6,"end_line":105,"end_character":47},"in_reply_to":"9a30ddce_e8724110","updated":"2017-03-10 23:10:09.000000000","message":"I removed it already","commit_id":"5afb0e35c7b654b28270fa06a2f8f8e18449acf4"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"422376c1489fb397bcd268581e8ceaad690b17d4","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.callbacks import events"},{"line_number":23,"context_line":"from neutron.callbacks import registry"},{"line_number":24,"context_line":"from neutron.conf.services import qos_driver_manager as qos_mgr"},{"line_number":25,"context_line":"from neutron.extensions import portbindings"},{"line_number":26,"context_line":"from neutron.objects.qos import policy as policy_object"},{"line_number":27,"context_line":"from neutron.services.qos import qos_consts"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_084e1e6f","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":43},"updated":"2017-03-20 02:54:11.000000000","message":"I think this can be moved to neutron-lib , IIUC ?","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fc43ca47806d7f18cf0bb9f7aacc60ed0af7bd07","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.callbacks import events"},{"line_number":23,"context_line":"from neutron.callbacks import registry"},{"line_number":24,"context_line":"from neutron.conf.services import qos_driver_manager as qos_mgr"},{"line_number":25,"context_line":"from neutron.extensions import portbindings"},{"line_number":26,"context_line":"from neutron.objects.qos import policy as policy_object"},{"line_number":27,"context_line":"from neutron.services.qos import qos_consts"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_474e2070","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":43},"in_reply_to":"1a1ced50_084e1e6f","updated":"2017-03-20 21:16:28.000000000","message":"But is it somehow related to this patch?","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7ffa36c0e289d09f1a00dc1aee34295239e8ebaa","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.callbacks import events"},{"line_number":23,"context_line":"from neutron.callbacks import registry"},{"line_number":24,"context_line":"from neutron.conf.services import qos_driver_manager as qos_mgr"},{"line_number":25,"context_line":"from neutron.extensions import portbindings"},{"line_number":26,"context_line":"from neutron.objects.qos import policy as policy_object"},{"line_number":27,"context_line":"from neutron.services.qos import qos_consts"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_0be74fac","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":43},"in_reply_to":"1a1ced50_474e2070","updated":"2017-03-23 12:12:51.000000000","message":"Well if it moves there, then you may not need it in this patch :D","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"422376c1489fb397bcd268581e8ceaad690b17d4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"SKIPPED_VIF_TYPES \u003d ["},{"line_number":35,"context_line":"    portbindings.VIF_TYPE_UNBOUND,"},{"line_number":36,"context_line":"    portbindings.VIF_TYPE_BINDING_FAILED"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class QosServiceDriverManager(object):"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_48581633","line":37,"range":{"start_line":34,"start_character":1,"end_line":37,"end_character":1},"updated":"2017-03-20 02:54:11.000000000","message":"Not sure if this should be here or not ...\nBut is not a big deal","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7ffa36c0e289d09f1a00dc1aee34295239e8ebaa","unresolved":false,"context_lines":[{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"SKIPPED_VIF_TYPES \u003d ["},{"line_number":35,"context_line":"    portbindings.VIF_TYPE_UNBOUND,"},{"line_number":36,"context_line":"    portbindings.VIF_TYPE_BINDING_FAILED"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class QosServiceDriverManager(object):"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_4b8ce7d9","line":37,"range":{"start_line":34,"start_character":1,"end_line":37,"end_character":1},"in_reply_to":"1a1ced50_47754096","updated":"2017-03-23 12:12:51.000000000","message":"I was thinking more in terms of defining it in a constants file in neutron-lib","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fc43ca47806d7f18cf0bb9f7aacc60ed0af7bd07","unresolved":false,"context_lines":[{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"SKIPPED_VIF_TYPES \u003d ["},{"line_number":35,"context_line":"    portbindings.VIF_TYPE_UNBOUND,"},{"line_number":36,"context_line":"    portbindings.VIF_TYPE_BINDING_FAILED"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class QosServiceDriverManager(object):"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_47754096","line":37,"range":{"start_line":34,"start_character":1,"end_line":37,"end_character":1},"in_reply_to":"1a1ced50_48581633","updated":"2017-03-20 21:16:28.000000000","message":"I need it below in L128 and IMHO it\u0027s better to define here such list of bindings which will be not checked then add all of them in L128 in \"if\" condition","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"772af9cb300cd04cb04b329608034f2ad8745b07","unresolved":false,"context_lines":[{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"SKIPPED_VIF_TYPES \u003d ["},{"line_number":35,"context_line":"    portbindings.VIF_TYPE_UNBOUND,"},{"line_number":36,"context_line":"    portbindings.VIF_TYPE_BINDING_FAILED"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class QosServiceDriverManager(object):"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_da36de01","line":37,"range":{"start_line":34,"start_character":1,"end_line":37,"end_character":1},"in_reply_to":"1a1ced50_4b8ce7d9","updated":"2017-03-23 12:54:52.000000000","message":"I\u0027m not sure if it\u0027s necessary becauese it\u0027s only required here (it\u0027s specific only for validation rules uses case).","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"422376c1489fb397bcd268581e8ceaad690b17d4","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    def validate_rule_for_port(self, rule, port):"},{"line_number":126,"context_line":"        for driver in self._drivers:"},{"line_number":127,"context_line":"            vif_type \u003d port.binding.vif_type"},{"line_number":128,"context_line":"            if vif_type and vif_type not in SKIPPED_VIF_TYPES:"},{"line_number":129,"context_line":"                if not self._validate_vif_type(driver, vif_type, port[\u0027id\u0027]):"},{"line_number":130,"context_line":"                    continue"},{"line_number":131,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_486f36c5","line":128,"range":{"start_line":128,"start_character":15,"end_line":128,"end_character":27},"updated":"2017-03-20 02:54:11.000000000","message":"I think this may not be required . If vif_type is not defined, it would not be in SKIPPED_VIF_TYPES","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fc43ca47806d7f18cf0bb9f7aacc60ed0af7bd07","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    def validate_rule_for_port(self, rule, port):"},{"line_number":126,"context_line":"        for driver in self._drivers:"},{"line_number":127,"context_line":"            vif_type \u003d port.binding.vif_type"},{"line_number":128,"context_line":"            if vif_type and vif_type not in SKIPPED_VIF_TYPES:"},{"line_number":129,"context_line":"                if not self._validate_vif_type(driver, vif_type, port[\u0027id\u0027]):"},{"line_number":130,"context_line":"                    continue"},{"line_number":131,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_c76930c0","line":128,"range":{"start_line":128,"start_character":15,"end_line":128,"end_character":27},"in_reply_to":"1a1ced50_486f36c5","updated":"2017-03-20 21:16:28.000000000","message":"You\u0027re right. Changed","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"422376c1489fb397bcd268581e8ceaad690b17d4","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            if driver.is_rule_supported(rule):"},{"line_number":137,"context_line":"                return True"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            LOG.debug(\"Rule %(rule)s is not suppported by %(driver)s\","},{"line_number":140,"context_line":"                      {\u0027rule\u0027: rule.rule_type, \u0027driver\u0027: driver.name})"},{"line_number":141,"context_line":"        return False"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_687232af","line":139,"range":{"start_line":139,"start_character":44,"end_line":139,"end_character":70},"updated":"2017-03-20 02:54:11.000000000","message":"to many P\u0027s","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fc43ca47806d7f18cf0bb9f7aacc60ed0af7bd07","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            if driver.is_rule_supported(rule):"},{"line_number":137,"context_line":"                return True"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            LOG.debug(\"Rule %(rule)s is not suppported by %(driver)s\","},{"line_number":140,"context_line":"                      {\u0027rule\u0027: rule.rule_type, \u0027driver\u0027: driver.name})"},{"line_number":141,"context_line":"        return False"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_27b6843d","line":139,"range":{"start_line":139,"start_character":44,"end_line":139,"end_character":70},"in_reply_to":"1a1ced50_687232af","updated":"2017-03-20 21:16:28.000000000","message":"Done","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"422376c1489fb397bcd268581e8ceaad690b17d4","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            if driver.is_rule_supported(rule):"},{"line_number":137,"context_line":"                return True"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            LOG.debug(\"Rule %(rule)s is not suppported by %(driver)s\","},{"line_number":140,"context_line":"                      {\u0027rule\u0027: rule.rule_type, \u0027driver\u0027: driver.name})"},{"line_number":141,"context_line":"        return False"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_289f5ab5","line":140,"range":{"start_line":139,"start_character":1,"end_line":140,"end_character":70},"updated":"2017-03-20 02:54:11.000000000","message":"We can put this log in the is_rule_supported() and just do\n\n    return driver.is_rule_supported(rule) \n\nin Line#136","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fc43ca47806d7f18cf0bb9f7aacc60ed0af7bd07","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            if driver.is_rule_supported(rule):"},{"line_number":137,"context_line":"                return True"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            LOG.debug(\"Rule %(rule)s is not suppported by %(driver)s\","},{"line_number":140,"context_line":"                      {\u0027rule\u0027: rule.rule_type, \u0027driver\u0027: driver.name})"},{"line_number":141,"context_line":"        return False"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_c7de906c","line":140,"range":{"start_line":139,"start_character":1,"end_line":140,"end_character":70},"in_reply_to":"1a1ced50_289f5ab5","updated":"2017-03-20 21:16:28.000000000","message":"I can\u0027t just do\n\n   return driver.is_rule_supported(rule)\n\nbecause it would always check only one driver and I need to check all drivers unless one of them supports this rule (and vif_type is matched also)","commit_id":"4570e1a6d2a88ce5e3a6aa288d02f2bb4cbd4e98"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"28eed3bfd9175a9a6b10d7086c2e834d59ada150","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.callbacks import events"},{"line_number":23,"context_line":"from neutron.callbacks import registry"},{"line_number":24,"context_line":"from neutron.conf.services import qos_driver_manager as qos_mgr"},{"line_number":25,"context_line":"from neutron.extensions import portbindings"},{"line_number":26,"context_line":"from neutron.objects.qos import policy as policy_object"},{"line_number":27,"context_line":"from neutron.services.qos import qos_consts"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"ffe62b97_b3cbe41c","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":43},"updated":"2017-03-24 07:40:20.000000000","message":"There is already the definition of portbindings includes VIF_TYPE_UNBOUND and VIF_TYPE_BINDING_FAILED in neutron_lib. Could you consider to use it?\n\nhttps://github.com/openstack/neutron-lib/blob/1.3.0/neutron_lib/api/definitions/portbindings.py#L80-L81","commit_id":"4cf53c18ddabcdcfac050709866144eeef026342"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"961b683b49206c862d9a37fbbc9e2e3bbbaec6b3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.callbacks import events"},{"line_number":23,"context_line":"from neutron.callbacks import registry"},{"line_number":24,"context_line":"from neutron.conf.services import qos_driver_manager as qos_mgr"},{"line_number":25,"context_line":"from neutron.extensions import portbindings"},{"line_number":26,"context_line":"from neutron.objects.qos import policy as policy_object"},{"line_number":27,"context_line":"from neutron.services.qos import qos_consts"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"ffe62b97_39c21587","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":43},"in_reply_to":"ffe62b97_b3cbe41c","updated":"2017-03-24 08:19:03.000000000","message":"Done","commit_id":"4cf53c18ddabcdcfac050709866144eeef026342"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"28eed3bfd9175a9a6b10d7086c2e834d59ada150","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            if driver.is_rule_supported(rule):"},{"line_number":137,"context_line":"                return True"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            LOG.debug(\"Rule %(rule)s is not supported by %(driver)s\","},{"line_number":140,"context_line":"                      {\u0027rule\u0027: rule.rule_type, \u0027driver\u0027: driver.name})"},{"line_number":141,"context_line":"        return False"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":17,"id":"ffe62b97_930d8092","line":140,"range":{"start_line":139,"start_character":12,"end_line":140,"end_character":70},"updated":"2017-03-24 07:40:20.000000000","message":"I think that this debug log is duplicated because similar log is outputted on L74 and L87 in base.py.","commit_id":"4cf53c18ddabcdcfac050709866144eeef026342"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"961b683b49206c862d9a37fbbc9e2e3bbbaec6b3","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            if driver.is_rule_supported(rule):"},{"line_number":137,"context_line":"                return True"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            LOG.debug(\"Rule %(rule)s is not supported by %(driver)s\","},{"line_number":140,"context_line":"                      {\u0027rule\u0027: rule.rule_type, \u0027driver\u0027: driver.name})"},{"line_number":141,"context_line":"        return False"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":17,"id":"ffe62b97_9940010a","line":140,"range":{"start_line":139,"start_character":12,"end_line":140,"end_character":70},"in_reply_to":"ffe62b97_930d8092","updated":"2017-03-24 08:19:03.000000000","message":"You are right. Removed. Thx","commit_id":"4cf53c18ddabcdcfac050709866144eeef026342"}],"neutron/services/qos/drivers/openvswitch/driver.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"91726bd5292d4d1924a18cb76d40d65f1794939a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return OVSDriver("},{"line_number":43,"context_line":"            name\u003d\u0027openvswitch\u0027,"},{"line_number":44,"context_line":"            vif_types\u003d[portbindings.VIF_TYPE_OVS,"},{"line_number":45,"context_line":"                       portbindings.VIF_TYPE_VHOST_USER],"},{"line_number":46,"context_line":"            vnic_types\u003d[portbindings.VNIC_NORMAL],"},{"line_number":47,"context_line":"            supported_rules\u003dSUPPORTED_RULES,"},{"line_number":48,"context_line":"            requires_rpc_notifications\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da36d5c6_9f5c27ef","line":45,"updated":"2017-02-28 09:30:53.000000000","message":"we may need to add a conditional is_rule_supported based on the vif type. May be is_rule_supported needs to take VIF and VNIC type as optional arguments?","commit_id":"169e80d630ac55808144a36441016dd22a32a1ea"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"881476fab0645a7059311827545383068c5021e3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return OVSDriver("},{"line_number":43,"context_line":"            name\u003d\u0027openvswitch\u0027,"},{"line_number":44,"context_line":"            vif_types\u003d[portbindings.VIF_TYPE_OVS,"},{"line_number":45,"context_line":"                       portbindings.VIF_TYPE_VHOST_USER],"},{"line_number":46,"context_line":"            vnic_types\u003d[portbindings.VNIC_NORMAL],"},{"line_number":47,"context_line":"            supported_rules\u003dSUPPORTED_RULES,"},{"line_number":48,"context_line":"            requires_rpc_notifications\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_ae31cdee","line":45,"in_reply_to":"9a30ddce_f3f2ce6e","updated":"2017-03-07 10:25:31.000000000","message":"No no, sorry! I does, because the limit is on the interface (policing, not shaping).\n\nThank you David Shaughnessy for the warning.","commit_id":"169e80d630ac55808144a36441016dd22a32a1ea"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"2ad9f2910675cf665cd68e116688fe31c2c95144","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return OVSDriver("},{"line_number":43,"context_line":"            name\u003d\u0027openvswitch\u0027,"},{"line_number":44,"context_line":"            vif_types\u003d[portbindings.VIF_TYPE_OVS,"},{"line_number":45,"context_line":"                       portbindings.VIF_TYPE_VHOST_USER],"},{"line_number":46,"context_line":"            vnic_types\u003d[portbindings.VNIC_NORMAL],"},{"line_number":47,"context_line":"            supported_rules\u003dSUPPORTED_RULES,"},{"line_number":48,"context_line":"            requires_rpc_notifications\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_f3f2ce6e","line":45,"in_reply_to":"ba2be162_2659b38e","updated":"2017-03-07 10:20:42.000000000","message":"yikes, more hidden complexity :] :D","commit_id":"169e80d630ac55808144a36441016dd22a32a1ea"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ecd4cc9faeca1d19af1efe8014c9e071f0659249","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return OVSDriver("},{"line_number":43,"context_line":"            name\u003d\u0027openvswitch\u0027,"},{"line_number":44,"context_line":"            vif_types\u003d[portbindings.VIF_TYPE_OVS,"},{"line_number":45,"context_line":"                       portbindings.VIF_TYPE_VHOST_USER],"},{"line_number":46,"context_line":"            vnic_types\u003d[portbindings.VNIC_NORMAL],"},{"line_number":47,"context_line":"            supported_rules\u003dSUPPORTED_RULES,"},{"line_number":48,"context_line":"            requires_rpc_notifications\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_2659b38e","line":45,"in_reply_to":"ba2be162_c8b52f7f","updated":"2017-03-06 08:22:11.000000000","message":"VHOST currently supports QoS rules but doesn\u0027t do anything. That means the API call is accepted but there is no QoS.\n\nVHOST shouldn\u0027t be supported for BW_LIMIT; should be for DSCP.","commit_id":"169e80d630ac55808144a36441016dd22a32a1ea"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"cc6985122d11e94e1d660eac51aad9bc87ab87b9","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return OVSDriver("},{"line_number":43,"context_line":"            name\u003d\u0027openvswitch\u0027,"},{"line_number":44,"context_line":"            vif_types\u003d[portbindings.VIF_TYPE_OVS,"},{"line_number":45,"context_line":"                       portbindings.VIF_TYPE_VHOST_USER],"},{"line_number":46,"context_line":"            vnic_types\u003d[portbindings.VNIC_NORMAL],"},{"line_number":47,"context_line":"            supported_rules\u003dSUPPORTED_RULES,"},{"line_number":48,"context_line":"            requires_rpc_notifications\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_c8b52f7f","line":45,"in_reply_to":"da36d5c6_9f5c27ef","updated":"2017-02-28 13:25:02.000000000","message":"I say this, because I\u0027m not sure if VHOST does really support the policer, for example, or if it will support queues in the future.\nAlso subports have the same issue now.\n\nAsking @ralonso here.","commit_id":"169e80d630ac55808144a36441016dd22a32a1ea"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4248b4a48b3361f2e58a08ce4da56c5308433239","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"SUPPORTED_RULES \u003d {"},{"line_number":28,"context_line":"    qos_consts.RULE_TYPE_BANDWIDTH_LIMIT: {"},{"line_number":29,"context_line":"        \"max_kbps\": {\u0027type:values\u0027: None},"},{"line_number":30,"context_line":"        \"max_burst_kbps\": {\u0027type:values\u0027: None}"},{"line_number":31,"context_line":"    },"},{"line_number":32,"context_line":"    qos_consts.RULE_TYPE_DSCP_MARKING: {"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a22e58a_dd2fa6f4","line":29,"range":{"start_line":29,"start_character":20,"end_line":29,"end_character":42},"updated":"2017-03-14 11:58:26.000000000","message":"ditto","commit_id":"eb22c805abf4bc8d972f813fe8c44f215d408dd4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0140a2feecc451cc04cddb903cb4516f00a7ee23","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"SUPPORTED_RULES \u003d {"},{"line_number":28,"context_line":"    qos_consts.RULE_TYPE_BANDWIDTH_LIMIT: {"},{"line_number":29,"context_line":"        \"max_kbps\": {\u0027type:values\u0027: None},"},{"line_number":30,"context_line":"        \"max_burst_kbps\": {\u0027type:values\u0027: None}"},{"line_number":31,"context_line":"    },"},{"line_number":32,"context_line":"    qos_consts.RULE_TYPE_DSCP_MARKING: {"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a1ff146_d9497590","line":29,"range":{"start_line":29,"start_character":20,"end_line":29,"end_character":42},"in_reply_to":"5a22e58a_dd2fa6f4","updated":"2017-03-14 21:01:54.000000000","message":"Done","commit_id":"eb22c805abf4bc8d972f813fe8c44f215d408dd4"}],"neutron/services/qos/drivers/sriov/driver.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4248b4a48b3361f2e58a08ce4da56c5308433239","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"SUPPORTED_RULES \u003d {"},{"line_number":28,"context_line":"    qos_consts.RULE_TYPE_BANDWIDTH_LIMIT: {"},{"line_number":29,"context_line":"        \"max_kbps\": {\u0027type:values\u0027: None},"},{"line_number":30,"context_line":"        \"max_burst_kbps\": {\u0027type:values\u0027: None}"},{"line_number":31,"context_line":"    },"},{"line_number":32,"context_line":"    qos_consts.RULE_TYPE_MINIMUM_BANDWIDTH: {"},{"line_number":33,"context_line":"        \"min_kbps\": {\u0027type:values\u0027: None},"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a22e58a_3d3fda26","line":30,"range":{"start_line":29,"start_character":8,"end_line":30,"end_character":47},"updated":"2017-03-14 11:58:26.000000000","message":"ditto","commit_id":"eb22c805abf4bc8d972f813fe8c44f215d408dd4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0140a2feecc451cc04cddb903cb4516f00a7ee23","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"SUPPORTED_RULES \u003d {"},{"line_number":28,"context_line":"    qos_consts.RULE_TYPE_BANDWIDTH_LIMIT: {"},{"line_number":29,"context_line":"        \"max_kbps\": {\u0027type:values\u0027: None},"},{"line_number":30,"context_line":"        \"max_burst_kbps\": {\u0027type:values\u0027: None}"},{"line_number":31,"context_line":"    },"},{"line_number":32,"context_line":"    qos_consts.RULE_TYPE_MINIMUM_BANDWIDTH: {"},{"line_number":33,"context_line":"        \"min_kbps\": {\u0027type:values\u0027: None},"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a1ff146_d930950a","line":30,"range":{"start_line":29,"start_character":8,"end_line":30,"end_character":47},"in_reply_to":"5a22e58a_3d3fda26","updated":"2017-03-14 21:01:54.000000000","message":"Done","commit_id":"eb22c805abf4bc8d972f813fe8c44f215d408dd4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4248b4a48b3361f2e58a08ce4da56c5308433239","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \"max_burst_kbps\": {\u0027type:values\u0027: None}"},{"line_number":31,"context_line":"    },"},{"line_number":32,"context_line":"    qos_consts.RULE_TYPE_MINIMUM_BANDWIDTH: {"},{"line_number":33,"context_line":"        \"min_kbps\": {\u0027type:values\u0027: None},"},{"line_number":34,"context_line":"        \u0027direction\u0027: {\u0027type:values\u0027: constants.VALID_DIRECTIONS}"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a22e58a_9d460ebe","line":33,"range":{"start_line":33,"start_character":7,"end_line":33,"end_character":42},"updated":"2017-03-14 11:58:26.000000000","message":"ditto","commit_id":"eb22c805abf4bc8d972f813fe8c44f215d408dd4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0140a2feecc451cc04cddb903cb4516f00a7ee23","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \"max_burst_kbps\": {\u0027type:values\u0027: None}"},{"line_number":31,"context_line":"    },"},{"line_number":32,"context_line":"    qos_consts.RULE_TYPE_MINIMUM_BANDWIDTH: {"},{"line_number":33,"context_line":"        \"min_kbps\": {\u0027type:values\u0027: None},"},{"line_number":34,"context_line":"        \u0027direction\u0027: {\u0027type:values\u0027: constants.VALID_DIRECTIONS}"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a1ff146_f93551f7","line":33,"range":{"start_line":33,"start_character":7,"end_line":33,"end_character":42},"in_reply_to":"5a22e58a_9d460ebe","updated":"2017-03-14 21:01:54.000000000","message":"Done","commit_id":"eb22c805abf4bc8d972f813fe8c44f215d408dd4"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"28eed3bfd9175a9a6b10d7086c2e834d59ada150","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"SUPPORTED_RULES \u003d {"},{"line_number":28,"context_line":"    qos_consts.RULE_TYPE_BANDWIDTH_LIMIT: {"},{"line_number":29,"context_line":"        \"max_kbps\": {\u0027type:range\u0027: [0, constants.DB_INTEGER_MAX_VALUE]},"},{"line_number":30,"context_line":"        \"max_burst_kbps\": {\u0027type:range\u0027: [0, constants.DB_INTEGER_MAX_VALUE]}"},{"line_number":31,"context_line":"    },"},{"line_number":32,"context_line":"    qos_consts.RULE_TYPE_MINIMUM_BANDWIDTH: {"}],"source_content_type":"text/x-python","patch_set":17,"id":"ffe62b97_330a3426","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":18},"updated":"2017-03-24 07:40:20.000000000","message":"It seems that the string can be used in some drivers as well. I think that it\u0027s useful to put a constant for it in qos_constants. This is applied to others(i.e. max_burst_kbps, min_kbps, direction, and dscp_mark).","commit_id":"4cf53c18ddabcdcfac050709866144eeef026342"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"961b683b49206c862d9a37fbbc9e2e3bbbaec6b3","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"SUPPORTED_RULES \u003d {"},{"line_number":28,"context_line":"    qos_consts.RULE_TYPE_BANDWIDTH_LIMIT: {"},{"line_number":29,"context_line":"        \"max_kbps\": {\u0027type:range\u0027: [0, constants.DB_INTEGER_MAX_VALUE]},"},{"line_number":30,"context_line":"        \"max_burst_kbps\": {\u0027type:range\u0027: [0, constants.DB_INTEGER_MAX_VALUE]}"},{"line_number":31,"context_line":"    },"},{"line_number":32,"context_line":"    qos_consts.RULE_TYPE_MINIMUM_BANDWIDTH: {"}],"source_content_type":"text/x-python","patch_set":17,"id":"ffe62b97_79889d1e","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":18},"in_reply_to":"ffe62b97_330a3426","updated":"2017-03-24 08:19:03.000000000","message":"Done","commit_id":"4cf53c18ddabcdcfac050709866144eeef026342"}],"neutron/services/qos/qos_plugin.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"edd66d038541fab1a2e6b85cf50941b23aa82598","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        ports_ids \u003d policy.get_bound_ports()"},{"line_number":59,"context_line":"        ports \u003d core_plugin.get_ports(context, filters\u003d{\u0027id\u0027: ports_ids})"},{"line_number":60,"context_line":"        for port in ports:"},{"line_number":61,"context_line":"            if (port not in ports_with_policy and"},{"line_number":62,"context_line":"                port[qos_consts.QOS_POLICY_ID] \u003d\u003d policy[\u0027id\u0027]):"},{"line_number":63,"context_line":"                ports_with_policy.append(port)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da36d5c6_7f6db3cb","line":60,"updated":"2017-02-28 09:26:53.000000000","message":"see next comment, may be we should iterate over \"ports_with_policy\", may be \"ports_with_net_policy\" is a better name.","commit_id":"169e80d630ac55808144a36441016dd22a32a1ea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"291e0c143c54ab637a4cd8dc3e8ddaeea6311045","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        ports_ids \u003d policy.get_bound_ports()"},{"line_number":59,"context_line":"        ports \u003d core_plugin.get_ports(context, filters\u003d{\u0027id\u0027: ports_ids})"},{"line_number":60,"context_line":"        for port in ports:"},{"line_number":61,"context_line":"            if (port not in ports_with_policy and"},{"line_number":62,"context_line":"                port[qos_consts.QOS_POLICY_ID] \u003d\u003d policy[\u0027id\u0027]):"},{"line_number":63,"context_line":"                ports_with_policy.append(port)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_59f13a6a","line":60,"in_reply_to":"da36d5c6_7f6db3cb","updated":"2017-03-04 21:41:34.000000000","message":"changed","commit_id":"169e80d630ac55808144a36441016dd22a32a1ea"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"edd66d038541fab1a2e6b85cf50941b23aa82598","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        ports \u003d core_plugin.get_ports(context, filters\u003d{\u0027id\u0027: ports_ids})"},{"line_number":60,"context_line":"        for port in ports:"},{"line_number":61,"context_line":"            if (port not in ports_with_policy and"},{"line_number":62,"context_line":"                port[qos_consts.QOS_POLICY_ID] \u003d\u003d policy[\u0027id\u0027]):"},{"line_number":63,"context_line":"                ports_with_policy.append(port)"},{"line_number":64,"context_line":"        return ports_with_policy"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da36d5c6_df3dbfbc","line":62,"updated":"2017-02-28 09:26:53.000000000","message":"wouldn\u0027t all of them in this loop be bound to the policy?,\n\nWe\u0027d need to discard a few in the \"ports_with_policy\" one that came from network.","commit_id":"169e80d630ac55808144a36441016dd22a32a1ea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"291e0c143c54ab637a4cd8dc3e8ddaeea6311045","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        ports \u003d core_plugin.get_ports(context, filters\u003d{\u0027id\u0027: ports_ids})"},{"line_number":60,"context_line":"        for port in ports:"},{"line_number":61,"context_line":"            if (port not in ports_with_policy and"},{"line_number":62,"context_line":"                port[qos_consts.QOS_POLICY_ID] \u003d\u003d policy[\u0027id\u0027]):"},{"line_number":63,"context_line":"                ports_with_policy.append(port)"},{"line_number":64,"context_line":"        return ports_with_policy"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_39e00696","line":62,"in_reply_to":"da36d5c6_df3dbfbc","updated":"2017-03-04 21:41:34.000000000","message":"You are right. I changed it now","commit_id":"169e80d630ac55808144a36441016dd22a32a1ea"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"edd66d038541fab1a2e6b85cf50941b23aa82598","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    def validate_policy(self, context, policy):"},{"line_number":67,"context_line":"        ports \u003d self._get_ports_with_policy(context, policy)"},{"line_number":68,"context_line":"        for port in ports:"},{"line_number":69,"context_line":"            for rule in policy.rules:"},{"line_number":70,"context_line":"                if not self.driver_manager.validate_rule_for_port(rule, port):"},{"line_number":71,"context_line":"                    raise n_exc.QosRuleNotSupported(rule_type\u003drule.rule_type,"},{"line_number":72,"context_line":"                                                    port_id\u003dport[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"da36d5c6_d42126b6","line":69,"updated":"2017-02-28 09:26:53.000000000","message":"nit: this is probably a silly optimization at this point, but in the case of having many many ports, it could be faster to find the subset of drivers, and then validate just once with every involved drivers.","commit_id":"169e80d630ac55808144a36441016dd22a32a1ea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"720a1d00858010833d1f60a775b6937382057eca","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    def validate_policy(self, context, policy):"},{"line_number":67,"context_line":"        ports \u003d self._get_ports_with_policy(context, policy)"},{"line_number":68,"context_line":"        for port in ports:"},{"line_number":69,"context_line":"            for rule in policy.rules:"},{"line_number":70,"context_line":"                if not self.driver_manager.validate_rule_for_port(rule, port):"},{"line_number":71,"context_line":"                    raise n_exc.QosRuleNotSupported(rule_type\u003drule.rule_type,"},{"line_number":72,"context_line":"                                                    port_id\u003dport[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_c6c825ab","line":69,"in_reply_to":"da36d5c6_d42126b6","updated":"2017-03-10 07:14:18.000000000","message":"How You want to validate only once with each driver? You mean to get set of port\u0027s vif_types? If yes, what about vnic_types then?","commit_id":"169e80d630ac55808144a36441016dd22a32a1ea"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"edd66d038541fab1a2e6b85cf50941b23aa82598","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            for rule in policy.rules:"},{"line_number":70,"context_line":"                if not self.driver_manager.validate_rule_for_port(rule, port):"},{"line_number":71,"context_line":"                    raise n_exc.QosRuleNotSupported(rule_type\u003drule.rule_type,"},{"line_number":72,"context_line":"                                                    port_id\u003dport[\u0027id\u0027])"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @db_base_plugin_common.convert_result_to_dict"},{"line_number":75,"context_line":"    def create_policy(self, context, policy):"}],"source_content_type":"text/x-python","patch_set":4,"id":"da36d5c6_1f1af76e","line":72,"updated":"2017-02-28 09:26:53.000000000","message":"above comment would not help in the case of reporting the port id for the driver, may be we could keep at least one port id for each driver.\n\nIt\u0027d be also nice to explain which QoS driver can\u0027t handle it specifically.","commit_id":"169e80d630ac55808144a36441016dd22a32a1ea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"720a1d00858010833d1f60a775b6937382057eca","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            for rule in policy.rules:"},{"line_number":70,"context_line":"                if not self.driver_manager.validate_rule_for_port(rule, port):"},{"line_number":71,"context_line":"                    raise n_exc.QosRuleNotSupported(rule_type\u003drule.rule_type,"},{"line_number":72,"context_line":"                                                    port_id\u003dport[\u0027id\u0027])"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @db_base_plugin_common.convert_result_to_dict"},{"line_number":75,"context_line":"    def create_policy(self, context, policy):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_26c4a18f","line":72,"in_reply_to":"da36d5c6_1f1af76e","updated":"2017-03-10 07:14:18.000000000","message":"But here I don\u0027t know which driver failed. I can display in error message vif_type of port (and maybe vnic_type) but is it what You want?","commit_id":"169e80d630ac55808144a36441016dd22a32a1ea"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"cf053cad2f248524892b0674e437c28a0793a120","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def _get_ports_with_policy(self, context, policy):"},{"line_number":53,"context_line":"        core_plugin \u003d directory.get_plugin()"},{"line_number":54,"context_line":"        networks_ids \u003d policy.get_bound_networks()"},{"line_number":55,"context_line":"        ports_with_net_policy \u003d core_plugin.get_ports("},{"line_number":56,"context_line":"            context, filters\u003d{\u0027network_id\u0027: networks_ids})"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        # Filter only this ports which don\u0027t have overriten policy"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a30ddce_6ec19580","line":55,"updated":"2017-03-07 10:32:37.000000000","message":"another note, sorry,\n\nMay be we should be using NeutronDbObjects for ports/etc, we can filter them now, and grab bunches, etc:\n\nhttps://review.openstack.org/#/c/336518/21/doc/source/devref/objects_usage.rst@115\n\nThis way you don\u0027t need to use those objects as dictionaries, and we will be safe during online upgrades, etc.\n\nIt\u0027d even be cool if we had policy.get_bound_network_objects()\n\n\nand same for bound ports on L64-L66","commit_id":"a026d29ae4e27907af0da170460544fbff250ae8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"59056f32b6ae54bab12dd65597c54f561722c95c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def _get_ports_with_policy(self, context, policy):"},{"line_number":53,"context_line":"        core_plugin \u003d directory.get_plugin()"},{"line_number":54,"context_line":"        networks_ids \u003d policy.get_bound_networks()"},{"line_number":55,"context_line":"        ports_with_net_policy \u003d core_plugin.get_ports("},{"line_number":56,"context_line":"            context, filters\u003d{\u0027network_id\u0027: networks_ids})"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        # Filter only this ports which don\u0027t have overriten policy"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a30ddce_cb7aee76","line":55,"in_reply_to":"9a30ddce_6ec19580","updated":"2017-03-09 21:55:40.000000000","message":"changed","commit_id":"a026d29ae4e27907af0da170460544fbff250ae8"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e8e3b5d25dea435e9a577b7a62ffbe636918f8ca","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        callbacks_registry.subscribe("},{"line_number":59,"context_line":"            self._validate_update_port_callback,"},{"line_number":60,"context_line":"            callbacks_resources.PORT,"},{"line_number":61,"context_line":"            callbacks_events.BEFORE_UPDATE)"},{"line_number":62,"context_line":"        callbacks_registry.subscribe("},{"line_number":63,"context_line":"            self._validate_update_network_callback,"},{"line_number":64,"context_line":"            callbacks_resources.NETWORK,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_94947c43","line":61,"updated":"2017-03-10 13:21:25.000000000","message":"UPDATE_PRECOMMIT","commit_id":"5afb0e35c7b654b28270fa06a2f8f8e18449acf4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"23a5f4fd1ca4940b3e83084ca1ac117f21059ac6","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        callbacks_registry.subscribe("},{"line_number":59,"context_line":"            self._validate_update_port_callback,"},{"line_number":60,"context_line":"            callbacks_resources.PORT,"},{"line_number":61,"context_line":"            callbacks_events.BEFORE_UPDATE)"},{"line_number":62,"context_line":"        callbacks_registry.subscribe("},{"line_number":63,"context_line":"            self._validate_update_network_callback,"},{"line_number":64,"context_line":"            callbacks_resources.NETWORK,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_5c4bf458","line":61,"in_reply_to":"9a30ddce_94947c43","updated":"2017-03-10 23:10:09.000000000","message":"Done","commit_id":"5afb0e35c7b654b28270fa06a2f8f8e18449acf4"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e8e3b5d25dea435e9a577b7a62ffbe636918f8ca","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        callbacks_registry.subscribe("},{"line_number":63,"context_line":"            self._validate_update_network_callback,"},{"line_number":64,"context_line":"            callbacks_resources.NETWORK,"},{"line_number":65,"context_line":"            callbacks_events.BEFORE_UPDATE)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _get_ports_with_policy(self, context, policy):"},{"line_number":68,"context_line":"        networks_ids \u003d policy.get_bound_networks()"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_b49d0068","line":65,"updated":"2017-03-10 13:21:25.000000000","message":"ditto","commit_id":"5afb0e35c7b654b28270fa06a2f8f8e18449acf4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"23a5f4fd1ca4940b3e83084ca1ac117f21059ac6","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        callbacks_registry.subscribe("},{"line_number":63,"context_line":"            self._validate_update_network_callback,"},{"line_number":64,"context_line":"            callbacks_resources.NETWORK,"},{"line_number":65,"context_line":"            callbacks_events.BEFORE_UPDATE)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _get_ports_with_policy(self, context, policy):"},{"line_number":68,"context_line":"        networks_ids \u003d policy.get_bound_networks()"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_7c46f84f","line":65,"in_reply_to":"9a30ddce_b49d0068","updated":"2017-03-10 23:10:09.000000000","message":"Done","commit_id":"5afb0e35c7b654b28270fa06a2f8f8e18449acf4"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e8e3b5d25dea435e9a577b7a62ffbe636918f8ca","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        # Filter only this ports which don\u0027t have overriten policy"},{"line_number":73,"context_line":"        ports_with_net_policy \u003d ["},{"line_number":74,"context_line":"            port for port in ports_with_net_policy if"},{"line_number":75,"context_line":"            port[qos_consts.QOS_POLICY_ID] is None"},{"line_number":76,"context_line":"        ]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        ports_ids \u003d policy.get_bound_ports()"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_2e6c5ccf","line":75,"updated":"2017-03-10 13:21:25.000000000","message":"with the object you just can do port.qos_policy_id","commit_id":"5afb0e35c7b654b28270fa06a2f8f8e18449acf4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"23a5f4fd1ca4940b3e83084ca1ac117f21059ac6","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        # Filter only this ports which don\u0027t have overriten policy"},{"line_number":73,"context_line":"        ports_with_net_policy \u003d ["},{"line_number":74,"context_line":"            port for port in ports_with_net_policy if"},{"line_number":75,"context_line":"            port[qos_consts.QOS_POLICY_ID] is None"},{"line_number":76,"context_line":"        ]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        ports_ids \u003d policy.get_bound_ports()"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_3c956086","line":75,"in_reply_to":"9a30ddce_2e6c5ccf","updated":"2017-03-10 23:10:09.000000000","message":"Done","commit_id":"5afb0e35c7b654b28270fa06a2f8f8e18449acf4"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e8e3b5d25dea435e9a577b7a62ffbe636918f8ca","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        ports_with_policy \u003d ports_object.Port.get_objects("},{"line_number":80,"context_line":"            context, id\u003dports_ids)"},{"line_number":81,"context_line":"        ports \u003d list(set(ports_with_policy + ports_with_net_policy))"},{"line_number":82,"context_line":"        return [port.to_dict() for port in ports]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def _validate_create_port_callback(self, resource, event, trigger,"},{"line_number":85,"context_line":"                                       **kwargs):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_ee06c4cc","line":82,"range":{"start_line":82,"start_character":16,"end_line":82,"end_character":30},"updated":"2017-03-10 13:21:25.000000000","message":"we could just use the port objects down under.\n\nUsing \"dictionary\" objects is not a good practice when we can avoid it.","commit_id":"5afb0e35c7b654b28270fa06a2f8f8e18449acf4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"23a5f4fd1ca4940b3e83084ca1ac117f21059ac6","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        ports_with_policy \u003d ports_object.Port.get_objects("},{"line_number":80,"context_line":"            context, id\u003dports_ids)"},{"line_number":81,"context_line":"        ports \u003d list(set(ports_with_policy + ports_with_net_policy))"},{"line_number":82,"context_line":"        return [port.to_dict() for port in ports]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def _validate_create_port_callback(self, resource, event, trigger,"},{"line_number":85,"context_line":"                                       **kwargs):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_1c9a5cb9","line":82,"range":{"start_line":82,"start_character":16,"end_line":82,"end_character":30},"in_reply_to":"9a30ddce_ee06c4cc","updated":"2017-03-10 23:10:09.000000000","message":"changed","commit_id":"5afb0e35c7b654b28270fa06a2f8f8e18449acf4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4248b4a48b3361f2e58a08ce4da56c5308433239","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        ports_with_net_policy \u003d ports_object.Port.get_objects("},{"line_number":71,"context_line":"            context, network_id\u003dnetworks_ids)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Filter only this ports which don\u0027t have overriten policy"},{"line_number":74,"context_line":"        ports_with_net_policy \u003d ["},{"line_number":75,"context_line":"            port for port in ports_with_net_policy if"},{"line_number":76,"context_line":"            port.qos_policy_id is None"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a22e58a_9da7ee4e","line":73,"range":{"start_line":73,"start_character":50,"end_line":73,"end_character":59},"updated":"2017-03-14 11:58:26.000000000","message":"Overwritten? Overridden?","commit_id":"eb22c805abf4bc8d972f813fe8c44f215d408dd4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0140a2feecc451cc04cddb903cb4516f00a7ee23","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        ports_with_net_policy \u003d ports_object.Port.get_objects("},{"line_number":71,"context_line":"            context, network_id\u003dnetworks_ids)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Filter only this ports which don\u0027t have overriten policy"},{"line_number":74,"context_line":"        ports_with_net_policy \u003d ["},{"line_number":75,"context_line":"            port for port in ports_with_net_policy if"},{"line_number":76,"context_line":"            port.qos_policy_id is None"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a1ff146_3917e952","line":73,"range":{"start_line":73,"start_character":50,"end_line":73,"end_character":59},"in_reply_to":"5a22e58a_9da7ee4e","updated":"2017-03-14 21:01:54.000000000","message":"changed, thx","commit_id":"eb22c805abf4bc8d972f813fe8c44f215d408dd4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4248b4a48b3361f2e58a08ce4da56c5308433239","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def _get_ports_with_policy(self, context, policy):"},{"line_number":69,"context_line":"        networks_ids \u003d policy.get_bound_networks()"},{"line_number":70,"context_line":"        ports_with_net_policy \u003d ports_object.Port.get_objects("},{"line_number":71,"context_line":"            context, network_id\u003dnetworks_ids)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Filter only this ports which don\u0027t have overriten policy"},{"line_number":74,"context_line":"        ports_with_net_policy \u003d ["},{"line_number":75,"context_line":"            port for port in ports_with_net_policy if"},{"line_number":76,"context_line":"            port.qos_policy_id is None"},{"line_number":77,"context_line":"        ]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        ports_ids \u003d policy.get_bound_ports()"},{"line_number":80,"context_line":"        ports_with_policy \u003d ports_object.Port.get_objects("}],"source_content_type":"text/x-python","patch_set":13,"id":"5a22e58a_383a88ce","line":77,"range":{"start_line":70,"start_character":0,"end_line":77,"end_character":9},"updated":"2017-03-14 11:58:26.000000000","message":"It\u0027s possible to filter the \"get\" function to retrieve only ports with qos_policy_id\u003dNone and network_id\u003dnetworks_ids?","commit_id":"eb22c805abf4bc8d972f813fe8c44f215d408dd4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0140a2feecc451cc04cddb903cb4516f00a7ee23","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def _get_ports_with_policy(self, context, policy):"},{"line_number":69,"context_line":"        networks_ids \u003d policy.get_bound_networks()"},{"line_number":70,"context_line":"        ports_with_net_policy \u003d ports_object.Port.get_objects("},{"line_number":71,"context_line":"            context, network_id\u003dnetworks_ids)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Filter only this ports which don\u0027t have overriten policy"},{"line_number":74,"context_line":"        ports_with_net_policy \u003d ["},{"line_number":75,"context_line":"            port for port in ports_with_net_policy if"},{"line_number":76,"context_line":"            port.qos_policy_id is None"},{"line_number":77,"context_line":"        ]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        ports_ids \u003d policy.get_bound_ports()"},{"line_number":80,"context_line":"        ports_with_policy \u003d ports_object.Port.get_objects("}],"source_content_type":"text/x-python","patch_set":13,"id":"3a1ff146_9cb9ab31","line":77,"range":{"start_line":70,"start_character":0,"end_line":77,"end_character":9},"in_reply_to":"5a22e58a_383a88ce","updated":"2017-03-14 21:01:54.000000000","message":"unfortunatelly no:\n\n(Pdb++) pp ports_object.Port.get_objects(context, network_id\u003dnetworks_ids, qos_policy_id\u003dNone)\n*** InvalidInput: InvalidInput(u\"Invalid input for operation: \u0027qos_policy_id\u0027 is not supported for filtering.\",)","commit_id":"eb22c805abf4bc8d972f813fe8c44f215d408dd4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ec801451b2f69a0e6a3a2086fefd37187e2c76b9","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        policy \u003d policy_object.QosPolicy.get_object(context, id\u003dpolicy_id)"},{"line_number":128,"context_line":"        ports \u003d ports_object.Port.get_objects("},{"line_number":129,"context_line":"                context, network_id\u003dupdated_network[\u0027id\u0027])"},{"line_number":130,"context_line":"        # Filter only this ports which don\u0027t have overriten policy"},{"line_number":131,"context_line":"        ports \u003d ["},{"line_number":132,"context_line":"            port for port in ports if port.qos_policy_id is None"},{"line_number":133,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a1ff146_e5bf1f5e","line":130,"range":{"start_line":130,"start_character":50,"end_line":130,"end_character":59},"updated":"2017-03-16 09:45:45.000000000","message":"s/overriten/overwritten","commit_id":"eb22c805abf4bc8d972f813fe8c44f215d408dd4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"50cb00affe02f680259ee8d1437ddc0e2e55a0ee","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        policy \u003d policy_object.QosPolicy.get_object(context, id\u003dpolicy_id)"},{"line_number":128,"context_line":"        ports \u003d ports_object.Port.get_objects("},{"line_number":129,"context_line":"                context, network_id\u003dupdated_network[\u0027id\u0027])"},{"line_number":130,"context_line":"        # Filter only this ports which don\u0027t have overriten policy"},{"line_number":131,"context_line":"        ports \u003d ["},{"line_number":132,"context_line":"            port for port in ports if port.qos_policy_id is None"},{"line_number":133,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a1ced50_49fe7c6c","line":130,"range":{"start_line":130,"start_character":50,"end_line":130,"end_character":59},"in_reply_to":"3a1ff146_e5bf1f5e","updated":"2017-03-17 17:54:36.000000000","message":"Done","commit_id":"eb22c805abf4bc8d972f813fe8c44f215d408dd4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4248b4a48b3361f2e58a08ce4da56c5308433239","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            return"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        policy \u003d policy_object.QosPolicy.get_object(context, id\u003dpolicy_id)"},{"line_number":128,"context_line":"        ports \u003d ports_object.Port.get_objects("},{"line_number":129,"context_line":"                context, network_id\u003dupdated_network[\u0027id\u0027])"},{"line_number":130,"context_line":"        # Filter only this ports which don\u0027t have overriten policy"},{"line_number":131,"context_line":"        ports \u003d ["},{"line_number":132,"context_line":"            port for port in ports if port.qos_policy_id is None"},{"line_number":133,"context_line":"        ]"},{"line_number":134,"context_line":"        self.validate_policy_for_ports(policy, ports)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def validate_policy(self, context, policy):"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a22e58a_d3ba37c0","line":133,"range":{"start_line":128,"start_character":0,"end_line":133,"end_character":9},"updated":"2017-03-14 11:58:26.000000000","message":"ditto, get ports using the filters","commit_id":"eb22c805abf4bc8d972f813fe8c44f215d408dd4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0140a2feecc451cc04cddb903cb4516f00a7ee23","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            return"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        policy \u003d policy_object.QosPolicy.get_object(context, id\u003dpolicy_id)"},{"line_number":128,"context_line":"        ports \u003d ports_object.Port.get_objects("},{"line_number":129,"context_line":"                context, network_id\u003dupdated_network[\u0027id\u0027])"},{"line_number":130,"context_line":"        # Filter only this ports which don\u0027t have overriten policy"},{"line_number":131,"context_line":"        ports \u003d ["},{"line_number":132,"context_line":"            port for port in ports if port.qos_policy_id is None"},{"line_number":133,"context_line":"        ]"},{"line_number":134,"context_line":"        self.validate_policy_for_ports(policy, ports)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def validate_policy(self, context, policy):"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a1ff146_1c7cdb71","line":133,"range":{"start_line":128,"start_character":0,"end_line":133,"end_character":9},"in_reply_to":"5a22e58a_d3ba37c0","updated":"2017-03-14 21:01:54.000000000","message":"see my answer above","commit_id":"eb22c805abf4bc8d972f813fe8c44f215d408dd4"}],"neutron/tests/unit/services/qos/test_qos_plugin.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"28eed3bfd9175a9a6b10d7086c2e834d59ada150","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            policy_ports \u003d self.qos_plugin._get_ports_with_policy("},{"line_number":125,"context_line":"                self.ctxt, self.policy)"},{"line_number":126,"context_line":"            self.assertEqual("},{"line_number":127,"context_line":"                len(ports + expected_network_ports), len(policy_ports))"},{"line_number":128,"context_line":"            for port in expected_ports:"},{"line_number":129,"context_line":"                self.assertTrue(port in policy_ports)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"ffe62b97_b67d12e9","line":127,"range":{"start_line":127,"start_character":20,"end_line":127,"end_character":50},"updated":"2017-03-24 07:40:20.000000000","message":"Why not expected_ports?","commit_id":"4cf53c18ddabcdcfac050709866144eeef026342"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"961b683b49206c862d9a37fbbc9e2e3bbbaec6b3","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            policy_ports \u003d self.qos_plugin._get_ports_with_policy("},{"line_number":125,"context_line":"                self.ctxt, self.policy)"},{"line_number":126,"context_line":"            self.assertEqual("},{"line_number":127,"context_line":"                len(ports + expected_network_ports), len(policy_ports))"},{"line_number":128,"context_line":"            for port in expected_ports:"},{"line_number":129,"context_line":"                self.assertTrue(port in policy_ports)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"ffe62b97_799d3d58","line":127,"range":{"start_line":127,"start_character":20,"end_line":127,"end_character":50},"in_reply_to":"ffe62b97_b67d12e9","updated":"2017-03-24 08:19:03.000000000","message":"I don\u0027t know :)\nFixed. Thx","commit_id":"4cf53c18ddabcdcfac050709866144eeef026342"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"28eed3bfd9175a9a6b10d7086c2e834d59ada150","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            self.assertEqual("},{"line_number":127,"context_line":"                len(ports + expected_network_ports), len(policy_ports))"},{"line_number":128,"context_line":"            for port in expected_ports:"},{"line_number":129,"context_line":"                self.assertTrue(port in policy_ports)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def _test_validate_create_port_callback(self, policy_id\u003dNone,"},{"line_number":132,"context_line":"                                            network_policy_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":17,"id":"ffe62b97_f68eface","line":129,"range":{"start_line":129,"start_character":21,"end_line":129,"end_character":31},"updated":"2017-03-24 07:40:20.000000000","message":"It\u0027s better to use assertIn().","commit_id":"4cf53c18ddabcdcfac050709866144eeef026342"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"961b683b49206c862d9a37fbbc9e2e3bbbaec6b3","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            self.assertEqual("},{"line_number":127,"context_line":"                len(ports + expected_network_ports), len(policy_ports))"},{"line_number":128,"context_line":"            for port in expected_ports:"},{"line_number":129,"context_line":"                self.assertTrue(port in policy_ports)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def _test_validate_create_port_callback(self, policy_id\u003dNone,"},{"line_number":132,"context_line":"                                            network_policy_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":17,"id":"ffe62b97_f9ef0dae","line":129,"range":{"start_line":129,"start_character":21,"end_line":129,"end_character":31},"in_reply_to":"ffe62b97_f68eface","updated":"2017-03-24 08:19:03.000000000","message":"changed","commit_id":"4cf53c18ddabcdcfac050709866144eeef026342"}]}
