)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b0f2f40843f36074b25dea1fd07bcd85e96a10a2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"test run."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Instead of using devstack as a library, we just enable the service via"},{"line_number":15,"context_line":"ENABLED_SERVICES variable, and call ./stack.sh."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I73857f63f512e26d595c61a20ec5bf22d2fb0da7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"fa31d9ce_795253df","line":15,"updated":"2017-02-09 23:12:00.000000000","message":"not exactly... will fix on next respin","commit_id":"513e9e1cc70d99e8b572d7f4492187b4ac98e093"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"eb82342fe941b7a5089222cd15583d763d22b011","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Instead of using devstack as a library, we just enable the service in"},{"line_number":15,"context_line":"local.conf [[localrc]], and then call ./stack.sh."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Now that we install some pypi packages into the system, and since"},{"line_number":18,"context_line":"functional targets were using those system packages, post_gate_hook.sh"},{"line_number":19,"context_line":"broke failing to locate subunit-2to1 script in the tox env directory. To"},{"line_number":20,"context_line":"fix that, we disable sitepackages\u003d for all functional tox targets. This"},{"line_number":21,"context_line":"was enabled back in the times when we attempted to install neutron for"},{"line_number":22,"context_line":"the functional job using devstack, and we no longer do it, so it should"},{"line_number":23,"context_line":"be ok to stick to all packages from the tox venv."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I73857f63f512e26d595c61a20ec5bf22d2fb0da7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"fa31d9ce_74378eb0","line":23,"range":{"start_line":17,"start_character":0,"end_line":23,"end_character":48},"updated":"2017-02-10 18:02:43.000000000","message":"I am confused by this. Are you sure that\u0027s the root cause? Just wondering if this causes some other side effect.","commit_id":"4b4c88cc79cc72d32390c98cdec04d4568e03303"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fa71ef5a45026b0c72ede70539e95f081d66e9f3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Instead of using devstack as a library, we just enable the service in"},{"line_number":15,"context_line":"local.conf [[localrc]], and then call ./stack.sh."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Now that we install some pypi packages into the system, and since"},{"line_number":18,"context_line":"functional targets were using those system packages, post_gate_hook.sh"},{"line_number":19,"context_line":"broke failing to locate subunit-2to1 script in the tox env directory. To"},{"line_number":20,"context_line":"fix that, we disable sitepackages\u003d for all functional tox targets. This"},{"line_number":21,"context_line":"was enabled back in the times when we attempted to install neutron for"},{"line_number":22,"context_line":"the functional job using devstack, and we no longer do it, so it should"},{"line_number":23,"context_line":"be ok to stick to all packages from the tox venv."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I73857f63f512e26d595c61a20ec5bf22d2fb0da7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"fa31d9ce_9acc2b37","line":23,"range":{"start_line":17,"start_character":0,"end_line":23,"end_character":48},"in_reply_to":"fa31d9ce_349436e1","updated":"2017-02-10 19:14:37.000000000","message":"OK we discussed the matter in IRC, and I realized that Armando suggests that the reason why we couldn\u0027t find subunit-2to1 is not because it was not installed into the venv, but because I haven\u0027t \u0027cd -\u0027 back into neutron/ dir after ./stack.sh. Now that we do, there should be no need to disable sitepackages to make it work.","commit_id":"4b4c88cc79cc72d32390c98cdec04d4568e03303"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b6722dc0195c4cfbab18aa2e7633b00d2c8ceb8f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Instead of using devstack as a library, we just enable the service in"},{"line_number":15,"context_line":"local.conf [[localrc]], and then call ./stack.sh."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Now that we install some pypi packages into the system, and since"},{"line_number":18,"context_line":"functional targets were using those system packages, post_gate_hook.sh"},{"line_number":19,"context_line":"broke failing to locate subunit-2to1 script in the tox env directory. To"},{"line_number":20,"context_line":"fix that, we disable sitepackages\u003d for all functional tox targets. This"},{"line_number":21,"context_line":"was enabled back in the times when we attempted to install neutron for"},{"line_number":22,"context_line":"the functional job using devstack, and we no longer do it, so it should"},{"line_number":23,"context_line":"be ok to stick to all packages from the tox venv."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I73857f63f512e26d595c61a20ec5bf22d2fb0da7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"fa31d9ce_349436e1","line":23,"range":{"start_line":17,"start_character":0,"end_line":23,"end_character":48},"in_reply_to":"fa31d9ce_74378eb0","updated":"2017-02-10 18:19:32.000000000","message":"Yes, I installed subunit locally with pip install, then recreated venv, and got no such package installed (and hence no binary) in the venv.\n\nsitepackages\u003dTrue came from https://review.openstack.org/#/c/122233/ but I don\u0027t think it\u0027s valid anymore: we don\u0027t install neutron services with devstack in the job.","commit_id":"4b4c88cc79cc72d32390c98cdec04d4568e03303"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"04ae8ae5833d35392ea8eb84ae237c7698026634","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Instead of using devstack as a library, we just enable the service in"},{"line_number":15,"context_line":"local.conf [[localrc]], and then call ./stack.sh."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Now that we install some pypi packages into the system, and since"},{"line_number":18,"context_line":"functional targets were using those system packages, post_gate_hook.sh"},{"line_number":19,"context_line":"broke failing to locate subunit-2to1 script in the tox env directory. To"},{"line_number":20,"context_line":"fix that, we disable sitepackages\u003d for all functional tox targets. This"},{"line_number":21,"context_line":"was enabled back in the times when we attempted to install neutron for"},{"line_number":22,"context_line":"the functional job using devstack, and we no longer do it, so it should"},{"line_number":23,"context_line":"be ok to stick to all packages from the tox venv."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I73857f63f512e26d595c61a20ec5bf22d2fb0da7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"fa31d9ce_3da0999f","line":23,"range":{"start_line":17,"start_character":0,"end_line":23,"end_character":48},"in_reply_to":"fa31d9ce_9acc2b37","updated":"2017-02-10 19:36:02.000000000","message":"it looks like it\u0027s not it. I think you got it right in PS21","commit_id":"4b4c88cc79cc72d32390c98cdec04d4568e03303"}],"neutron/tests/contrib/gate_hook.sh":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"00dce80aec98fba8e3dd571f8551f08435c6d1f0","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    sudo chown -R $STACK_USER:$STACK_USER $BASE"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    # Start dstat to monitor machine performance during test run"},{"line_number":75,"context_line":"    source $DEVSTACK_PATH/lib/functions-common"},{"line_number":76,"context_line":"    source $DEVSTACK_PATH/lib/dstat"},{"line_number":77,"context_line":"    start_dstat"},{"line_number":78,"context_line":"    ;;"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a461143_75197a79","line":75,"range":{"start_line":75,"start_character":26,"end_line":75,"end_character":30},"updated":"2017-02-01 13:49:33.000000000","message":"Went ahead and looked at failure - functions-common is not in lib dir.","commit_id":"b71b462e355e4042f1d71361650b6f5549044197"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9d745e2b92df957c444d539b6660240ec08221d7","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Start dstat to monitor machine performance during test run"},{"line_number":75,"context_line":"    source $DEVSTACK_PATH/lib/functions-common"},{"line_number":76,"context_line":"    source $DEVSTACK_PATH/lib/dstat"},{"line_number":77,"context_line":"    start_dstat"},{"line_number":78,"context_line":"    ;;"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"\"api\"|\"api-pecan\"|\"full-ovsfw\"|\"full-pecan\"|\"dsvm-scenario\")"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a461143_84388fd4","line":77,"updated":"2017-02-01 00:45:04.000000000","message":"wouldn\u0027t something like this more appropriate being placed in https://github.com/openstack/neutron/blob/master/tools/configure_for_func_testing.sh?","commit_id":"b71b462e355e4042f1d71361650b6f5549044197"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4b8150ca3089eb4367e1a9b2a38b75910f0cf19e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Start dstat to monitor machine performance during test run"},{"line_number":75,"context_line":"    source $DEVSTACK_PATH/lib/functions-common"},{"line_number":76,"context_line":"    source $DEVSTACK_PATH/lib/dstat"},{"line_number":77,"context_line":"    start_dstat"},{"line_number":78,"context_line":"    ;;"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"\"api\"|\"api-pecan\"|\"full-ovsfw\"|\"full-pecan\"|\"dsvm-scenario\")"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a461143_423e7b2a","line":77,"in_reply_to":"3a461143_337b872b","updated":"2017-02-01 17:45:49.000000000","message":"Yeah, but then wouldn\u0027t it make sense to keep it isolated to the actual script executed in gate only? I guess it\u0027s a matter of taste.","commit_id":"b71b462e355e4042f1d71361650b6f5549044197"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"83d5a1fe35923713c6acee81c530cff739481c0a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Start dstat to monitor machine performance during test run"},{"line_number":75,"context_line":"    source $DEVSTACK_PATH/lib/functions-common"},{"line_number":76,"context_line":"    source $DEVSTACK_PATH/lib/dstat"},{"line_number":77,"context_line":"    start_dstat"},{"line_number":78,"context_line":"    ;;"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"\"api\"|\"api-pecan\"|\"full-ovsfw\"|\"full-pecan\"|\"dsvm-scenario\")"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a461143_a093a2ff","line":77,"in_reply_to":"3a461143_60753a31","updated":"2017-02-01 14:27:57.000000000","message":"I will move both start and stop into post hook.","commit_id":"b71b462e355e4042f1d71361650b6f5549044197"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"00dce80aec98fba8e3dd571f8551f08435c6d1f0","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Start dstat to monitor machine performance during test run"},{"line_number":75,"context_line":"    source $DEVSTACK_PATH/lib/functions-common"},{"line_number":76,"context_line":"    source $DEVSTACK_PATH/lib/dstat"},{"line_number":77,"context_line":"    start_dstat"},{"line_number":78,"context_line":"    ;;"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"\"api\"|\"api-pecan\"|\"full-ovsfw\"|\"full-pecan\"|\"dsvm-scenario\")"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a461143_b5020208","line":77,"in_reply_to":"3a461143_84388fd4","updated":"2017-02-01 13:49:33.000000000","message":"I would leave it here as it\u0027s gate related. When setting env locally it would keep it running till user stops it manually.\n\nShould we also put \u0027screen_stop dstat\u0027 to the post_test_hook?","commit_id":"b71b462e355e4042f1d71361650b6f5549044197"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"47c6ec662161b490a4ff278c34dc36364853c58f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Start dstat to monitor machine performance during test run"},{"line_number":75,"context_line":"    source $DEVSTACK_PATH/lib/functions-common"},{"line_number":76,"context_line":"    source $DEVSTACK_PATH/lib/dstat"},{"line_number":77,"context_line":"    start_dstat"},{"line_number":78,"context_line":"    ;;"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"\"api\"|\"api-pecan\"|\"full-ovsfw\"|\"full-pecan\"|\"dsvm-scenario\")"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a461143_337b872b","line":77,"in_reply_to":"3a461143_a093a2ff","updated":"2017-02-01 15:45:43.000000000","message":"there is a IS_GATE variable that controls what you do or do not do locally...","commit_id":"b71b462e355e4042f1d71361650b6f5549044197"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"92632cabbf4b70f5adbc36cfc11597e0c17603cb","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Start dstat to monitor machine performance during test run"},{"line_number":75,"context_line":"    source $DEVSTACK_PATH/lib/functions-common"},{"line_number":76,"context_line":"    source $DEVSTACK_PATH/lib/dstat"},{"line_number":77,"context_line":"    start_dstat"},{"line_number":78,"context_line":"    ;;"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"\"api\"|\"api-pecan\"|\"full-ovsfw\"|\"full-pecan\"|\"dsvm-scenario\")"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a461143_60753a31","line":77,"in_reply_to":"3a461143_b5020208","updated":"2017-02-01 14:21:57.000000000","message":"Right, we don\u0027t want it to be started during local functional test runs done on development machines.","commit_id":"b71b462e355e4042f1d71361650b6f5549044197"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a2e9328aab188654f03046c0645f44e448662c73","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    upgrade_ovs_if_necessary $compile_modules"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    # prepare base environment for ./stack.sh"},{"line_number":71,"context_line":"    load_conf_hook stack_base"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    # enable monitoring"},{"line_number":74,"context_line":"    load_conf_hook dstat"}],"source_content_type":"text/x-sh","patch_set":19,"id":"fa31d9ce_64f2a69c","line":71,"updated":"2017-02-10 00:09:44.000000000","message":"I am still unclear as of the need of having two hooks right now, the local.conf file looks ugly too. Also I\u0027d suggest you use USE_SCREEN \u003dFalse\n\nhttp://git.openstack.org/cgit/openstack-dev/devstack/tree/stackrc#n88","commit_id":"513e9e1cc70d99e8b572d7f4492187b4ac98e093"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a3c3a41a3e332dec98857fa534bd0bd844e0a98a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    upgrade_ovs_if_necessary $compile_modules"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    # prepare base environment for ./stack.sh"},{"line_number":71,"context_line":"    load_conf_hook stack_base"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    # enable monitoring"},{"line_number":74,"context_line":"    load_conf_hook dstat"}],"source_content_type":"text/x-sh","patch_set":19,"id":"fa31d9ce_71ad0788","line":71,"in_reply_to":"fa31d9ce_64f2a69c","updated":"2017-02-10 01:23:46.000000000","message":"The reason for the split is that if we tomorrow want to enable another service, we won\u0027t have its enablement dependent on the order of other hooks as long as stack_base is called first. Maybe I am complicating the matter too early?","commit_id":"513e9e1cc70d99e8b572d7f4492187b4ac98e093"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c9b3aac9c49003607225bbc7dab84bccbe8ef8b1","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    upgrade_ovs_if_necessary $compile_modules"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    # prepare base environment for ./stack.sh"},{"line_number":71,"context_line":"    load_conf_hook stack_base"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    # enable monitoring"},{"line_number":74,"context_line":"    load_conf_hook dstat"}],"source_content_type":"text/x-sh","patch_set":19,"id":"fa31d9ce_aa7384b3","line":71,"in_reply_to":"fa31d9ce_71ad0788","updated":"2017-02-10 02:53:36.000000000","message":"probably.","commit_id":"513e9e1cc70d99e8b572d7f4492187b4ac98e093"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a2e9328aab188654f03046c0645f44e448662c73","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    sudo chown -R $STACK_USER:$STACK_USER $BASE"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    # deploy devstack as per local.conf"},{"line_number":80,"context_line":"    cd $DEVSTACK_PATH \u0026\u0026 sudo -H -u $GATE_STACK_USER ./stack.sh"},{"line_number":81,"context_line":"    ;;"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"\"api\"|\"api-pecan\"|\"full-ovsfw\"|\"full-pecan\"|\"dsvm-scenario\")"}],"source_content_type":"text/x-sh","patch_set":19,"id":"fa31d9ce_24d18efc","line":80,"updated":"2017-02-10 00:09:44.000000000","message":"you gotta go back to where you were, either using pushd/popd or using cd -","commit_id":"513e9e1cc70d99e8b572d7f4492187b4ac98e093"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a3c3a41a3e332dec98857fa534bd0bd844e0a98a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    sudo chown -R $STACK_USER:$STACK_USER $BASE"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    # deploy devstack as per local.conf"},{"line_number":80,"context_line":"    cd $DEVSTACK_PATH \u0026\u0026 sudo -H -u $GATE_STACK_USER ./stack.sh"},{"line_number":81,"context_line":"    ;;"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"\"api\"|\"api-pecan\"|\"full-ovsfw\"|\"full-pecan\"|\"dsvm-scenario\")"}],"source_content_type":"text/x-sh","patch_set":19,"id":"fa31d9ce_91aa7b6f","line":80,"in_reply_to":"fa31d9ce_24d18efc","updated":"2017-02-10 01:23:46.000000000","message":"It doesn\u0027t seem to matter too much but ok.","commit_id":"513e9e1cc70d99e8b572d7f4492187b4ac98e093"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4dba3c7e451d719c77244918378b1e679ba88c60","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    sudo chown -R $STACK_USER:$STACK_USER $BASE"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    # deploy devstack as per local.conf"},{"line_number":80,"context_line":"    cd $DEVSTACK_PATH \u0026\u0026 sudo -H -u $GATE_STACK_USER ./stack.sh"},{"line_number":81,"context_line":"    ;;"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"\"api\"|\"api-pecan\"|\"full-ovsfw\"|\"full-pecan\"|\"dsvm-scenario\")"}],"source_content_type":"text/x-sh","patch_set":19,"id":"fa31d9ce_aa9aa4c3","line":80,"in_reply_to":"fa31d9ce_91aa7b6f","updated":"2017-02-10 02:54:29.000000000","message":"oh, it matters alright ;)","commit_id":"513e9e1cc70d99e8b572d7f4492187b4ac98e093"}],"neutron/tests/contrib/post_test_hook.sh":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"af53c3c6d774c97d33cd99563c16154435bb0705","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set -xe"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"NEUTRON_DIR\u003d\"$BASE/new/neutron\""},{"line_number":6,"context_line":"GATE_DEST\u003d$BASE/new"},{"line_number":7,"context_line":"DEVSTACK_PATH\u003d$GATE_DEST/devstack"},{"line_number":8,"context_line":"SCRIPTS_DIR\u003d\"/usr/os-testr-env/bin/\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"3a461143_1f7e73ae","line":5,"range":{"start_line":5,"start_character":13,"end_line":5,"end_character":22},"updated":"2017-02-02 10:30:35.000000000","message":"$GATE_DEST and put L6 to L5","commit_id":"e2b3f755e01b3b3e639959bef1a2dde158a0c4a4"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b2160463779cb4de6bf2b278426a10b013b19177","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set -xe"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"NEUTRON_DIR\u003d\"$BASE/new/neutron\""},{"line_number":6,"context_line":"GATE_DEST\u003d$BASE/new"},{"line_number":7,"context_line":"DEVSTACK_PATH\u003d$GATE_DEST/devstack"},{"line_number":8,"context_line":"SCRIPTS_DIR\u003d\"/usr/os-testr-env/bin/\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"1a430d35_07723c7b","line":5,"range":{"start_line":5,"start_character":13,"end_line":5,"end_character":22},"in_reply_to":"3a461143_1f7e73ae","updated":"2017-02-07 15:00:08.000000000","message":"Done","commit_id":"e2b3f755e01b3b3e639959bef1a2dde158a0c4a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"af53c3c6d774c97d33cd99563c16154435bb0705","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    # Start system monitoring"},{"line_number":35,"context_line":"    source $DEVSTACK_PATH/functions-common"},{"line_number":36,"context_line":"    source $DEVSTACK_PATH/lib/dstat"},{"line_number":37,"context_line":"    ENABLED_SERVICES+\u003d,dstat"},{"line_number":38,"context_line":"    start_dstat"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    # Run tests"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3a461143_0a3473dc","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":28},"updated":"2017-02-02 10:30:35.000000000","message":"Maybe \u0027enable_service dstat\u0027 is more defensive in case dstat is already present in ENABLED_SERVICES.\n\nLike here http://logs.openstack.org/58/427358/6/check/gate-neutron-dsvm-functional-ubuntu-xenial/b514fb6/console.html#_2017-02-01_21_04_56_915440","commit_id":"e2b3f755e01b3b3e639959bef1a2dde158a0c4a4"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b2160463779cb4de6bf2b278426a10b013b19177","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    # Start system monitoring"},{"line_number":35,"context_line":"    source $DEVSTACK_PATH/functions-common"},{"line_number":36,"context_line":"    source $DEVSTACK_PATH/lib/dstat"},{"line_number":37,"context_line":"    ENABLED_SERVICES+\u003d,dstat"},{"line_number":38,"context_line":"    start_dstat"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    # Run tests"}],"source_content_type":"text/x-sh","patch_set":6,"id":"1a430d35_670780ca","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":28},"in_reply_to":"3a461143_0a3473dc","updated":"2017-02-07 15:00:08.000000000","message":"Done","commit_id":"e2b3f755e01b3b3e639959bef1a2dde158a0c4a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"af53c3c6d774c97d33cd99563c16154435bb0705","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    source $DEVSTACK_PATH/functions-common"},{"line_number":36,"context_line":"    source $DEVSTACK_PATH/lib/dstat"},{"line_number":37,"context_line":"    ENABLED_SERVICES+\u003d,dstat"},{"line_number":38,"context_line":"    start_dstat"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    # Run tests"},{"line_number":41,"context_line":"    echo \"Running neutron $venv test suite\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"3a461143_a5b8f0e6","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":15},"updated":"2017-02-02 10:30:35.000000000","message":"I see that peakmem_tracker is part of this. Maybe would be also useful to enable the service?","commit_id":"e2b3f755e01b3b3e639959bef1a2dde158a0c4a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c99eeb625050c6f46996faefe25da650d20a5cbc","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    source $DEVSTACK_PATH/functions-common"},{"line_number":36,"context_line":"    source $DEVSTACK_PATH/lib/dstat"},{"line_number":37,"context_line":"    ENABLED_SERVICES+\u003d,dstat"},{"line_number":38,"context_line":"    start_dstat"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    # Run tests"},{"line_number":41,"context_line":"    echo \"Running neutron $venv test suite\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"1a430d35_8751cc38","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":15},"in_reply_to":"1a430d35_87338caa","updated":"2017-02-07 15:05:29.000000000","message":"Makes sense","commit_id":"e2b3f755e01b3b3e639959bef1a2dde158a0c4a4"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b2160463779cb4de6bf2b278426a10b013b19177","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    source $DEVSTACK_PATH/functions-common"},{"line_number":36,"context_line":"    source $DEVSTACK_PATH/lib/dstat"},{"line_number":37,"context_line":"    ENABLED_SERVICES+\u003d,dstat"},{"line_number":38,"context_line":"    start_dstat"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    # Run tests"},{"line_number":41,"context_line":"    echo \"Running neutron $venv test suite\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"1a430d35_87338caa","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":15},"in_reply_to":"3a461143_a5b8f0e6","updated":"2017-02-07 15:00:08.000000000","message":"Could be, though I don\u0027t see the service enabled anywhere. Maybe we can split concerns here, I don\u0027t want to debug potential failures of this other service in scope of this patch.","commit_id":"e2b3f755e01b3b3e639959bef1a2dde158a0c4a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"af53c3c6d774c97d33cd99563c16154435bb0705","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    stop_dstat"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    # Collect and parse results"},{"line_number":51,"context_line":"    generate_testr_results"},{"line_number":52,"context_line":"    exit $testr_exit_code"},{"line_number":53,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3a461143_65c0c8e1","line":51,"updated":"2017-02-02 10:30:35.000000000","message":"We probably need to collect the dstat log, something like https://github.com/openstack-infra/devstack-gate/blob/master/functions.sh#L838","commit_id":"e2b3f755e01b3b3e639959bef1a2dde158a0c4a4"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b2160463779cb4de6bf2b278426a10b013b19177","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    stop_dstat"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    # Collect and parse results"},{"line_number":51,"context_line":"    generate_testr_results"},{"line_number":52,"context_line":"    exit $testr_exit_code"},{"line_number":53,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"1a430d35_a7e5e8dc","line":51,"in_reply_to":"3a461143_65c0c8e1","updated":"2017-02-07 15:00:08.000000000","message":"Done","commit_id":"e2b3f755e01b3b3e639959bef1a2dde158a0c4a4"}]}
