)]}'
{"neutron/agent/linux/iptables_firewall.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"28a3f2ee425cee061108afb2ddec28ada82f8416","unresolved":false,"context_lines":[{"line_number":377,"context_line":"            if rule.get(\u0027ethertype\u0027) \u003d\u003d constants.IPv4:"},{"line_number":378,"context_line":"                ipv4_sg_rules.append(rule)"},{"line_number":379,"context_line":"            elif rule.get(\u0027ethertype\u0027) \u003d\u003d constants.IPv6:"},{"line_number":380,"context_line":"                if rule.get(\u0027protocol\u0027) \u003d\u003d \u0027icmp\u0027:"},{"line_number":381,"context_line":"                    rule[\u0027protocol\u0027] \u003d \u0027ipv6-icmp\u0027"},{"line_number":382,"context_line":"                ipv6_sg_rules.append(rule)"},{"line_number":383,"context_line":"        return ipv4_sg_rules, ipv6_sg_rules"}],"source_content_type":"text/x-python","patch_set":8,"id":"da36d5c6_f09936c5","side":"PARENT","line":380,"updated":"2017-02-24 10:24:41.000000000","message":"Interesting point in https://github.com/openstack/neutron-lib/blob/master/neutron_lib/constants.py#L197-L198","commit_id":"0d53546294980bd119b5f644fe46d1083820162c"}],"neutron/db/migration/alembic_migrations/versions/ocata/contract/2e086db97d13_foo.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0266e1e0fead318acfc813e706cfbd969c8610c3","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"TABLE \u003d \u0027securitygrouprules\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"TABLE_MODEL \u003d sa.Table(TABLE, "},{"line_number":34,"context_line":"                       sa.Column(\u0027protocol\u0027, sa.String(length\u003d40),"},{"line_number":35,"context_line":"                       nullable\u003dTrue),)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_d2a324ff","line":33,"updated":"2017-02-01 13:28:06.000000000","message":"whitespace","commit_id":"cbff0c727ddd8d62cc40783a5e85805b9125c5cd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3428c56ee6e9eb2ddef7833629cc5009ae8ae1ad","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    with session.begin(subtransactions\u003dTrue):"},{"line_number":44,"context_line":"        for row in session.query(TABLE_MODEL):"},{"line_number":45,"context_line":"            session.execute("},{"line_number":46,"context_line":"                TABLE_MODEL.update().values("},{"line_number":47,"context_line":"                    protocol\u003dconstants.PROTO_NAME_IPV6_ICMP).where("},{"line_number":48,"context_line":"                        protocol in ICMP_IPv6_PROTOCOL_LIST))"},{"line_number":49,"context_line":"    session.commit()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_3e7187e1","line":46,"updated":"2017-02-01 19:04:38.000000000","message":"it\u0027s definitely not in line with rolling upgrades approach. old servers may still create records with \u0027old\u0027 values.","commit_id":"cbff0c727ddd8d62cc40783a5e85805b9125c5cd"}],"neutron/db/migration/alembic_migrations/versions/pike/contract/5ebcd269f660_de_duplicate_ipv6_icmp_sg_rules.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"8d1e972392d21da5e644e4ac6d018b41c903313c","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def upgrade():"},{"line_number":36,"context_line":"    de_duplicate_ipv6_icmp_sg_rules()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def _rules_equal(rule1, rule2):"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_b828fc33","line":36,"updated":"2017-05-22 10:33:07.000000000","message":"I think this migration requires functional test. For reference -\n https://github.com/openstack/neutron/tree/master/neutron/tests/functional/db/migrations","commit_id":"151876e608c5c4f81866262cd79d95867abb17cc"}],"neutron/db/securitygroups_db.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0266e1e0fead318acfc813e706cfbd969c8610c3","unresolved":false,"context_lines":[{"line_number":446,"context_line":"                raise ext_sg.SecurityGroupRulesNotSingleTenant()"},{"line_number":447,"context_line":"        return sg_groups.pop()"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"    def _convert_IPv6_ICMP_rules(self, rule):"},{"line_number":450,"context_line":"        if rule[\u0027protocol\u0027] and rule[\u0027ethertype\u0027]:"},{"line_number":451,"context_line":"            if (rule[\u0027protocol\u0027] in n_const.IP_PROTOCOL_NAME_ALIASES or"},{"line_number":452,"context_line":"                rule[\u0027protocol\u0027] \u003d\u003d constants.PROTO_NAME_ICMP]) and ("}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_52b8142b","line":449,"updated":"2017-02-01 13:28:06.000000000","message":"please add a unit tests for this","commit_id":"cbff0c727ddd8d62cc40783a5e85805b9125c5cd"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"f1e950a78cc5ed53f07467062a122658e7341983","unresolved":false,"context_lines":[{"line_number":446,"context_line":"                raise ext_sg.SecurityGroupRulesNotSingleTenant()"},{"line_number":447,"context_line":"        return sg_groups.pop()"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"    def _convert_IPv6_ICMP_rules(self, rule):"},{"line_number":450,"context_line":"        if rule[\u0027protocol\u0027] and rule[\u0027ethertype\u0027]:"},{"line_number":451,"context_line":"            if (rule[\u0027protocol\u0027] in n_const.IP_PROTOCOL_NAME_ALIASES or"},{"line_number":452,"context_line":"                rule[\u0027protocol\u0027] \u003d\u003d constants.PROTO_NAME_ICMP]) and ("}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_e91e725e","line":449,"in_reply_to":"3a461143_52b8142b","updated":"2017-02-01 16:20:58.000000000","message":"Have the TC but I guess it was not added in the previous Git Commit ( my stupid pc )","commit_id":"cbff0c727ddd8d62cc40783a5e85805b9125c5cd"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"875806c7f67e93696fbf2c36abf4e282dfcd4c7b","unresolved":false,"context_lines":[{"line_number":449,"context_line":"    def _convert_IPv6_ICMP_rules(self, rule):"},{"line_number":450,"context_line":"        if rule[\u0027protocol\u0027] and rule[\u0027ethertype\u0027]:"},{"line_number":451,"context_line":"            if (rule[\u0027protocol\u0027] in n_const.IP_PROTOCOL_NAME_ALIASES or"},{"line_number":452,"context_line":"                rule[\u0027protocol\u0027] \u003d\u003d constants.PROTO_NAME_ICMP]) and ("},{"line_number":453,"context_line":"                rule[\u0027ethertype\u0027] \u003d constants.IPv6):"},{"line_number":454,"context_line":"                 rule[\u0027protocol\u0027] \u003d constants.PROTO_NAME_IPV6_ICMP "},{"line_number":455,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_47cdad85","line":452,"range":{"start_line":452,"start_character":61,"end_line":452,"end_character":62},"updated":"2017-02-01 17:23:27.000000000","message":"] ?","commit_id":"cbff0c727ddd8d62cc40783a5e85805b9125c5cd"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"875806c7f67e93696fbf2c36abf4e282dfcd4c7b","unresolved":false,"context_lines":[{"line_number":450,"context_line":"        if rule[\u0027protocol\u0027] and rule[\u0027ethertype\u0027]:"},{"line_number":451,"context_line":"            if (rule[\u0027protocol\u0027] in n_const.IP_PROTOCOL_NAME_ALIASES or"},{"line_number":452,"context_line":"                rule[\u0027protocol\u0027] \u003d\u003d constants.PROTO_NAME_ICMP]) and ("},{"line_number":453,"context_line":"                rule[\u0027ethertype\u0027] \u003d constants.IPv6):"},{"line_number":454,"context_line":"                 rule[\u0027protocol\u0027] \u003d constants.PROTO_NAME_IPV6_ICMP "},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    def _validate_security_group_rule(self, context, security_group_rule):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_87c79563","line":453,"range":{"start_line":453,"start_character":34,"end_line":453,"end_character":35},"updated":"2017-02-01 17:23:27.000000000","message":"s/\u003d\u003d","commit_id":"cbff0c727ddd8d62cc40783a5e85805b9125c5cd"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0266e1e0fead318acfc813e706cfbd969c8610c3","unresolved":false,"context_lines":[{"line_number":451,"context_line":"            if (rule[\u0027protocol\u0027] in n_const.IP_PROTOCOL_NAME_ALIASES or"},{"line_number":452,"context_line":"                rule[\u0027protocol\u0027] \u003d\u003d constants.PROTO_NAME_ICMP]) and ("},{"line_number":453,"context_line":"                rule[\u0027ethertype\u0027] \u003d constants.IPv6):"},{"line_number":454,"context_line":"                 rule[\u0027protocol\u0027] \u003d constants.PROTO_NAME_IPV6_ICMP "},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    def _validate_security_group_rule(self, context, security_group_rule):"},{"line_number":457,"context_line":"        rule \u003d security_group_rule[\u0027security_group_rule\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_12ae8ce7","line":454,"updated":"2017-02-01 13:28:06.000000000","message":"ditto","commit_id":"cbff0c727ddd8d62cc40783a5e85805b9125c5cd"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6ce6ccb612ab4a0d712ec1af82f2b6391a57aa6c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from neutron.extensions import securitygroup as ext_sg"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"ICMP_PROTO_LIST \u003d [constants.PROTO_NAME_ICMP,"},{"line_number":39,"context_line":"                   constants.PROTO_NAME_IPV6_ICMP,"},{"line_number":40,"context_line":"                   constants.PROTO_NAME_IPV6_ICMP_LEGACY]"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a1ced50_721694f2","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":15},"updated":"2017-03-20 11:06:36.000000000","message":"I think you should move this to neutron-lib (whenever is possible)","commit_id":"c0ccc77a5aaef5b11ac64e1aa967d5f38d0ddffc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"eebf9a512f2588789e93ec2ec4cf01bda22ffd70","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from neutron.extensions import securitygroup as ext_sg"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"ICMP_PROTO_LIST \u003d [constants.PROTO_NAME_ICMP,"},{"line_number":39,"context_line":"                   constants.PROTO_NAME_IPV6_ICMP,"},{"line_number":40,"context_line":"                   constants.PROTO_NAME_IPV6_ICMP_LEGACY]"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_bddd8e43","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":15},"in_reply_to":"1a1ced50_721694f2","updated":"2017-05-22 09:59:37.000000000","message":"Would do it once this is merged","commit_id":"c0ccc77a5aaef5b11ac64e1aa967d5f38d0ddffc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6ce6ccb612ab4a0d712ec1af82f2b6391a57aa6c","unresolved":false,"context_lines":[{"line_number":446,"context_line":"        return sg_groups.pop()"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def _convert_IPv6_ICMP_rules(self, rule):"},{"line_number":449,"context_line":"        if rule[\u0027protocol\u0027] and rule[\u0027ethertype\u0027]:"},{"line_number":450,"context_line":"            if rule[\u0027protocol\u0027] in ICMP_PROTO_LIST and ("},{"line_number":451,"context_line":"                rule[\u0027ethertype\u0027] \u003d\u003d constants.IPv6):"},{"line_number":452,"context_line":"                rule[\u0027protocol\u0027] \u003d constants.PROTO_NAME_IPV6_ICMP"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a1ced50_7772064b","line":449,"updated":"2017-03-20 11:06:36.000000000","message":"You could do this (is shorter):\n\nif (rule.get(\u0027protocol\u0027) in ICMP_PROTO_LIST and\n        rule.get(\u0027ethertype\u0027) \u003d\u003d constants.IPv6):","commit_id":"c0ccc77a5aaef5b11ac64e1aa967d5f38d0ddffc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"eebf9a512f2588789e93ec2ec4cf01bda22ffd70","unresolved":false,"context_lines":[{"line_number":446,"context_line":"        return sg_groups.pop()"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def _convert_IPv6_ICMP_rules(self, rule):"},{"line_number":449,"context_line":"        if rule[\u0027protocol\u0027] and rule[\u0027ethertype\u0027]:"},{"line_number":450,"context_line":"            if rule[\u0027protocol\u0027] in ICMP_PROTO_LIST and ("},{"line_number":451,"context_line":"                rule[\u0027ethertype\u0027] \u003d\u003d constants.IPv6):"},{"line_number":452,"context_line":"                rule[\u0027protocol\u0027] \u003d constants.PROTO_NAME_IPV6_ICMP"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_3df17ece","line":449,"in_reply_to":"1a1ced50_7772064b","updated":"2017-05-22 09:59:37.000000000","message":"Done","commit_id":"c0ccc77a5aaef5b11ac64e1aa967d5f38d0ddffc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6ce6ccb612ab4a0d712ec1af82f2b6391a57aa6c","unresolved":false,"context_lines":[{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def _convert_IPv6_ICMP_rules(self, rule):"},{"line_number":449,"context_line":"        if rule[\u0027protocol\u0027] and rule[\u0027ethertype\u0027]:"},{"line_number":450,"context_line":"            if rule[\u0027protocol\u0027] in ICMP_PROTO_LIST and ("},{"line_number":451,"context_line":"                rule[\u0027ethertype\u0027] \u003d\u003d constants.IPv6):"},{"line_number":452,"context_line":"                rule[\u0027protocol\u0027] \u003d constants.PROTO_NAME_IPV6_ICMP"},{"line_number":453,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a1ced50_4c82e195","line":450,"range":{"start_line":450,"start_character":55,"end_line":450,"end_character":56},"updated":"2017-03-20 11:06:36.000000000","message":"this parenthesis could group all \"if\" condition:\nif (rule[\u0027protocol\u0027] in..... ):","commit_id":"c0ccc77a5aaef5b11ac64e1aa967d5f38d0ddffc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"eebf9a512f2588789e93ec2ec4cf01bda22ffd70","unresolved":false,"context_lines":[{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def _convert_IPv6_ICMP_rules(self, rule):"},{"line_number":449,"context_line":"        if rule[\u0027protocol\u0027] and rule[\u0027ethertype\u0027]:"},{"line_number":450,"context_line":"            if rule[\u0027protocol\u0027] in ICMP_PROTO_LIST and ("},{"line_number":451,"context_line":"                rule[\u0027ethertype\u0027] \u003d\u003d constants.IPv6):"},{"line_number":452,"context_line":"                rule[\u0027protocol\u0027] \u003d constants.PROTO_NAME_IPV6_ICMP"},{"line_number":453,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_ddbf22ce","line":450,"range":{"start_line":450,"start_character":55,"end_line":450,"end_character":56},"in_reply_to":"1a1ced50_4c82e195","updated":"2017-05-22 09:59:37.000000000","message":"Done","commit_id":"c0ccc77a5aaef5b11ac64e1aa967d5f38d0ddffc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6ce6ccb612ab4a0d712ec1af82f2b6391a57aa6c","unresolved":false,"context_lines":[{"line_number":448,"context_line":"    def _convert_IPv6_ICMP_rules(self, rule):"},{"line_number":449,"context_line":"        if rule[\u0027protocol\u0027] and rule[\u0027ethertype\u0027]:"},{"line_number":450,"context_line":"            if rule[\u0027protocol\u0027] in ICMP_PROTO_LIST and ("},{"line_number":451,"context_line":"                rule[\u0027ethertype\u0027] \u003d\u003d constants.IPv6):"},{"line_number":452,"context_line":"                rule[\u0027protocol\u0027] \u003d constants.PROTO_NAME_IPV6_ICMP"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"    def _validate_security_group_rule(self, context, security_group_rule):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a1ced50_ac3435fb","line":451,"updated":"2017-03-20 11:06:36.000000000","message":"you should indent this line","commit_id":"c0ccc77a5aaef5b11ac64e1aa967d5f38d0ddffc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"eebf9a512f2588789e93ec2ec4cf01bda22ffd70","unresolved":false,"context_lines":[{"line_number":448,"context_line":"    def _convert_IPv6_ICMP_rules(self, rule):"},{"line_number":449,"context_line":"        if rule[\u0027protocol\u0027] and rule[\u0027ethertype\u0027]:"},{"line_number":450,"context_line":"            if rule[\u0027protocol\u0027] in ICMP_PROTO_LIST and ("},{"line_number":451,"context_line":"                rule[\u0027ethertype\u0027] \u003d\u003d constants.IPv6):"},{"line_number":452,"context_line":"                rule[\u0027protocol\u0027] \u003d constants.PROTO_NAME_IPV6_ICMP"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"    def _validate_security_group_rule(self, context, security_group_rule):"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_bdb6aef9","line":451,"in_reply_to":"1a1ced50_ac3435fb","updated":"2017-05-22 09:59:37.000000000","message":"Done","commit_id":"c0ccc77a5aaef5b11ac64e1aa967d5f38d0ddffc"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8d6b849d6421a47705072a52fc5e58be56a15823","unresolved":false,"context_lines":[{"line_number":583,"context_line":"            duplicate_ip_prefix \u003d self._validate_duplicate_ip_prefix("},{"line_number":584,"context_line":"                                    remote_ip_prefix, db_remote_ip_prefix)"},{"line_number":585,"context_line":"            if ((is_protocol_matching or is_protoethertype_matching) and"},{"line_number":586,"context_line":"                duplicate_ip_prefix and rule_dict \u003d\u003d db_rule):"},{"line_number":587,"context_line":"                raise ext_sg.SecurityGroupRuleExists(rule_id\u003drule_id)"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"    def _validate_duplicate_ip_prefix(self, ip_prefix, other_ip_prefix):"}],"source_content_type":"text/x-python","patch_set":9,"id":"dfeb2761_77cba671","line":586,"updated":"2017-04-04 05:35:00.000000000","message":"doesn\u0027t this break the case where only ethertype is different?","commit_id":"c0ccc77a5aaef5b11ac64e1aa967d5f38d0ddffc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"eebf9a512f2588789e93ec2ec4cf01bda22ffd70","unresolved":false,"context_lines":[{"line_number":583,"context_line":"            duplicate_ip_prefix \u003d self._validate_duplicate_ip_prefix("},{"line_number":584,"context_line":"                                    remote_ip_prefix, db_remote_ip_prefix)"},{"line_number":585,"context_line":"            if ((is_protocol_matching or is_protoethertype_matching) and"},{"line_number":586,"context_line":"                duplicate_ip_prefix and rule_dict \u003d\u003d db_rule):"},{"line_number":587,"context_line":"                raise ext_sg.SecurityGroupRuleExists(rule_id\u003drule_id)"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"    def _validate_duplicate_ip_prefix(self, ip_prefix, other_ip_prefix):"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_9db9aaea","line":586,"in_reply_to":"dfeb2761_77cba671","updated":"2017-05-22 09:59:37.000000000","message":"If ethertype is different, wont it make isprotoetherype_matching to false?","commit_id":"c0ccc77a5aaef5b11ac64e1aa967d5f38d0ddffc"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"c60b660a1fd7f3ed16b6fa9597e07e07bdf49940","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            if len(tenants) \u003e 1:"},{"line_number":440,"context_line":"                raise ext_sg.SecurityGroupRulesNotSingleTenant()"},{"line_number":441,"context_line":"        return sg_groups.pop()"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"    def _convert_icmpv6_protocol(self, rule):"},{"line_number":444,"context_line":"        if (rule.get(\u0027protocol\u0027) in n_const.ICMPV6_PROTO_LIST and"},{"line_number":445,"context_line":"                rule.get(\u0027ethertype\u0027) \u003d\u003d constants.IPv6):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7ffa3b31_d69d285a","line":442,"updated":"2017-04-16 04:42:18.000000000","message":"It seems like it would be a lot less invasive if we just convert in the API by altering the function convert_protocol to convert to a single ICMP rule.","commit_id":"315a7485cb834c69434ee459471cbd403c834bf8"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"94eaea71a67db264254f46e9a9b61552dd44bd97","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            if len(tenants) \u003e 1:"},{"line_number":440,"context_line":"                raise ext_sg.SecurityGroupRulesNotSingleTenant()"},{"line_number":441,"context_line":"        return sg_groups.pop()"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"    def _convert_icmpv6_protocol(self, rule):"},{"line_number":444,"context_line":"        if (rule.get(\u0027protocol\u0027) in n_const.ICMPV6_PROTO_LIST and"},{"line_number":445,"context_line":"                rule.get(\u0027ethertype\u0027) \u003d\u003d constants.IPv6):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7ffa3b31_9f667729","line":442,"updated":"2017-04-17 22:53:58.000000000","message":"Yeah, maybe we should just convert in the API, then have a contract script (contract to ensure old server isn\u0027t running) to standardize and eliminate dups.\n\nThen in queens we can get rid of all code on the iptables side that deals with the different types.","commit_id":"315a7485cb834c69434ee459471cbd403c834bf8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f7ca56164e8983ce46b529c8a5b9d8850805757f","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            if len(tenants) \u003e 1:"},{"line_number":440,"context_line":"                raise ext_sg.SecurityGroupRulesNotSingleTenant()"},{"line_number":441,"context_line":"        return sg_groups.pop()"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"    def _convert_icmpv6_protocol(self, rule):"},{"line_number":444,"context_line":"        if (rule.get(\u0027protocol\u0027) in n_const.ICMPV6_PROTO_LIST and"},{"line_number":445,"context_line":"                rule.get(\u0027ethertype\u0027) \u003d\u003d constants.IPv6):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7ffa3b31_da03f841","line":442,"in_reply_to":"7ffa3b31_d69d285a","updated":"2017-04-17 16:02:53.000000000","message":"Kevin, yes, I had done that in https://review.openstack.org/#/c/453346/ but abandoned in favor of this.  I can restore it if you like.\n\nThe biggest problem isn\u0027t changing all IPv6 ICMP values to a single name though, but dealing with things when the DB has one or more of these \"duplicates\".  I put that change in a separate patch, https://review.openstack.org/#/c/455444/ since it seemed a little hacky, but these all need to eventually converge into a single change.\n\nIs having a DB migration where the old value is converted, and removing duplicates in the process an option?","commit_id":"315a7485cb834c69434ee459471cbd403c834bf8"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"1796935c21f58686ec28d25a4e9d912490686bce","unresolved":false,"context_lines":[{"line_number":453,"context_line":"        return sg_groups.pop()"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    def _convert_icmpv6_protocol(self, rule):"},{"line_number":456,"context_line":"        if (rule.get(\u0027protocol\u0027) in n_const.ICMPV6_PROTO_LIST and"},{"line_number":457,"context_line":"                rule.get(\u0027ethertype\u0027) \u003d\u003d constants.IPv6):"},{"line_number":458,"context_line":"            rule[\u0027protocol\u0027] \u003d constants.PROTO_NAME_IPV6_ICMP"},{"line_number":459,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"df3967d1_545e3044","line":456,"updated":"2017-08-04 01:58:20.000000000","message":"Can \u002758\u0027 be converted to \u0027ipv6-icmp\u0027 too?","commit_id":"151876e608c5c4f81866262cd79d95867abb17cc"}]}
