)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9da415326e145060d6a362c601d7321d9ebb49a4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add \"default\" behaviour to QoS policies"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements the \"default\" behaviour for QoS policies."},{"line_number":10,"context_line":"If this falg is enabled for a QoS policy in a project, all"},{"line_number":11,"context_line":"new networks created will have this QoS policy assigned by default."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If a new QoS policy is created or updated with this flag and another"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a430d35_fb430040","line":10,"range":{"start_line":10,"start_character":8,"end_line":10,"end_character":12},"updated":"2017-02-07 17:07:11.000000000","message":"very nit: flag","commit_id":"d33dd83840965c2678e61e20b5418fea356723ba"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6873b05fce215c24376dd486079489caf0de0f0d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add \"default\" behaviour to QoS policies"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements the \"default\" behaviour for QoS policies."},{"line_number":10,"context_line":"If this falg is enabled for a QoS policy in a project, all"},{"line_number":11,"context_line":"new networks created will have this QoS policy assigned by default."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If a new QoS policy is created or updated with this flag and another"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a430d35_bbf17803","line":10,"range":{"start_line":10,"start_character":8,"end_line":10,"end_character":12},"in_reply_to":"1a430d35_fb430040","updated":"2017-02-07 17:09:48.000000000","message":"Don\u0027t worry, I need to sumbit another version. Also look at line 23...","commit_id":"d33dd83840965c2678e61e20b5418fea356723ba"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1a53cacbdfc89d69e845d2365dec50f3ce2cebbe","unresolved":false,"context_lines":[{"line_number":10,"context_line":"If this flag is enabled for a QoS policy in a project, all"},{"line_number":11,"context_line":"new networks created will have this QoS policy assigned by default."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If a new QoS policy is created or updated with this flag and another"},{"line_number":14,"context_line":"QoS policy in the same project is set as the default policy, the new"},{"line_number":15,"context_line":"one won\u0027t be created or updated (see subnet-pool behaviour)."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This new parameter will be located in \"qos_policies\" table, as a"},{"line_number":18,"context_line":"boolean field."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"3a1ff146_fa36cae5","line":15,"range":{"start_line":13,"start_character":1,"end_line":15,"end_character":59},"updated":"2017-03-16 15:49:16.000000000","message":"This is not clear.\nIf we have policy Q1 in the system with this flag, and we create a policy Q2 , and then update it with this flag, what would happen to QoS policy Q2 which is the new one?\n\nNot everyone would be using a subnet-pool. Therefore this reference may be inconvinient","commit_id":"7bdccde8d167bab0aa4341e9e5b69b73f2173116"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"63471bcbc8804fef04d10954bec26bed00adb490","unresolved":false,"context_lines":[{"line_number":10,"context_line":"If this flag is enabled for a QoS policy in a project, all"},{"line_number":11,"context_line":"new networks created will have this QoS policy assigned by default."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If a new QoS policy is created or updated with this flag and another"},{"line_number":14,"context_line":"QoS policy in the same project is set as the default policy, the new"},{"line_number":15,"context_line":"one won\u0027t be created or updated (see subnet-pool behaviour)."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This new parameter will be located in \"qos_policies\" table, as a"},{"line_number":18,"context_line":"boolean field."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"1a1ced50_c0b93acd","line":15,"range":{"start_line":13,"start_character":1,"end_line":15,"end_character":59},"in_reply_to":"3a1ff146_fa36cae5","updated":"2017-03-20 08:57:55.000000000","message":"The case you propose is a subset of the paragraph (two rules, one of them updated). This is explained: if there is one default QoS policy, no other one could be at the same time.","commit_id":"7bdccde8d167bab0aa4341e9e5b69b73f2173116"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1a53cacbdfc89d69e845d2365dec50f3ce2cebbe","unresolved":false,"context_lines":[{"line_number":17,"context_line":"This new parameter will be located in \"qos_policies\" table, as a"},{"line_number":18,"context_line":"boolean field."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"DocImpact"},{"line_number":21,"context_line":"APIImpact"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Closes-Bug: #1639220"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"3a1ff146_d75f273f","line":20,"updated":"2017-03-16 15:49:16.000000000","message":"Can you write the DocImpact information in the next line, I guess?","commit_id":"7bdccde8d167bab0aa4341e9e5b69b73f2173116"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"63471bcbc8804fef04d10954bec26bed00adb490","unresolved":false,"context_lines":[{"line_number":17,"context_line":"This new parameter will be located in \"qos_policies\" table, as a"},{"line_number":18,"context_line":"boolean field."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"DocImpact"},{"line_number":21,"context_line":"APIImpact"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Closes-Bug: #1639220"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"1a1ced50_e0b0f6df","line":20,"in_reply_to":"3a1ff146_d75f273f","updated":"2017-03-20 08:57:55.000000000","message":"Done","commit_id":"7bdccde8d167bab0aa4341e9e5b69b73f2173116"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"39e080b4b530e9f156b6acaba5e4a67070c8591e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"This new parameter will be located in \"qos_policies\" table, as a"},{"line_number":19,"context_line":"boolean field."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"DocImpact: use of default flag for QoS policies."},{"line_number":22,"context_line":"APIImpact"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-Bug: #1639220"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"1a1ced50_c37ce4ed","line":21,"range":{"start_line":21,"start_character":11,"end_line":21,"end_character":47},"updated":"2017-03-20 09:06:09.000000000","message":"This can be improved ...\n\nA default flag is introduced for QoS policies . If the Default Flag is enabled for a Project and set to a QoS policy, then all networks which are created in a project would be assigned the QoS policy","commit_id":"04b8fa133f86e0059cc717642de6c3e0d8bacc6d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"209ffcd499cf34061303113ff85a56f598c2e2eb","unresolved":false,"context_lines":[{"line_number":18,"context_line":"This new parameter will be located in \"qos_policies\" table, as a"},{"line_number":19,"context_line":"boolean field."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"DocImpact: use of default flag for QoS policies."},{"line_number":22,"context_line":"APIImpact"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-Bug: #1639220"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"1a1ced50_5278b8f2","line":21,"range":{"start_line":21,"start_character":11,"end_line":21,"end_character":47},"in_reply_to":"1a1ced50_c37ce4ed","updated":"2017-03-20 12:04:50.000000000","message":"Done","commit_id":"04b8fa133f86e0059cc717642de6c3e0d8bacc6d"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ac358093102326f49694415447c711da1833e2ce","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rodolfo Alonso Hernandez \u003crodolfo.alonso.hernandez@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-30 13:29:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \"default\" behaviour to QoS policies"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements the \"default\" behaviour for QoS policies."},{"line_number":10,"context_line":"If this flag is enabled for a QoS policy in a project, all"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":44,"id":"bff0334d_b45f580d","line":7,"updated":"2017-04-05 14:17:41.000000000","message":"Implement another extension file that will have it\u0027s own alias. For example, this extension was added so a description field could be added to the trunk resource: https://github.com/openstack/neutron/blob/master/neutron/extensions/trunk_details.py\n\nThen the modification you made to neutron/extensions/qos.py would be moved to this new extension file instead.","commit_id":"f3985b0d32dc15bba4044736f931dab32df57d13"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"cae43d92c545c2e73afbb8e397a807de762e88ff","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rodolfo Alonso Hernandez \u003crodolfo.alonso.hernandez@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-30 13:29:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \"default\" behaviour to QoS policies"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements the \"default\" behaviour for QoS policies."},{"line_number":10,"context_line":"If this flag is enabled for a QoS policy in a project, all"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":44,"id":"dfeb2761_d62eebf8","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":23},"updated":"2017-04-04 11:08:30.000000000","message":"how can an api user see if the functionality is supported by a deployment?","commit_id":"f3985b0d32dc15bba4044736f931dab32df57d13"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0d637baf0500c728d78e490a736582eb34cf1b47","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rodolfo Alonso Hernandez \u003crodolfo.alonso.hernandez@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-30 13:29:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \"default\" behaviour to QoS policies"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements the \"default\" behaviour for QoS policies."},{"line_number":10,"context_line":"If this flag is enabled for a QoS policy in a project, all"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":44,"id":"bff0334d_af46e54e","line":7,"in_reply_to":"bff0334d_b45f580d","updated":"2017-04-05 14:35:32.000000000","message":"Ahhhh OK, now I understand perfectly. The change is a bit more complex than I expected.","commit_id":"f3985b0d32dc15bba4044736f931dab32df57d13"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"697ef2da528ded0ae0b4728176c6511a7b73ba9c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rodolfo Alonso Hernandez \u003crodolfo.alonso.hernandez@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-30 13:29:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \"default\" behaviour to QoS policies"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements the \"default\" behaviour for QoS policies."},{"line_number":10,"context_line":"If this flag is enabled for a QoS policy in a project, all"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":44,"id":"dfeb2761_f3d8bcef","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":23},"in_reply_to":"dfeb2761_a852c8dc","updated":"2017-04-05 07:17:33.000000000","message":"@Kevin: can you explain this a bit more? I don\u0027t understand what do I need to do here.\n\nThis new parameter is an affix to QoS. Where do I need to expose it?\n\nThank you in advance.","commit_id":"f3985b0d32dc15bba4044736f931dab32df57d13"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8c1e1b7a9e6c0b1d3f4dbd8045147068c2268740","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rodolfo Alonso Hernandez \u003crodolfo.alonso.hernandez@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-30 13:29:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \"default\" behaviour to QoS policies"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements the \"default\" behaviour for QoS policies."},{"line_number":10,"context_line":"If this flag is enabled for a QoS policy in a project, all"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":44,"id":"dfeb2761_df1f0e59","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":23},"in_reply_to":"dfeb2761_d62eebf8","updated":"2017-04-04 17:34:46.000000000","message":"If the neutron service, api or DB is older than the current version, the user will see always this field set to \"False\", even if te user tries to set it to \"True\".\n\nIf the CLI is older, the user won\u0027t see or have the ability to change this parameter.","commit_id":"f3985b0d32dc15bba4044736f931dab32df57d13"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ccb9eafb1f6427b63f4ada41f13c3f30f2cf6f25","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rodolfo Alonso Hernandez \u003crodolfo.alonso.hernandez@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-30 13:29:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \"default\" behaviour to QoS policies"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements the \"default\" behaviour for QoS policies."},{"line_number":10,"context_line":"If this flag is enabled for a QoS policy in a project, all"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":44,"id":"dfeb2761_a852c8dc","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":23},"in_reply_to":"dfeb2761_df1f0e59","updated":"2017-04-04 22:49:52.000000000","message":"We need a new extension so this is discoverable via the API. Even a dummy extension is okay as long as the user can see something in the extension list that indicates this.","commit_id":"f3985b0d32dc15bba4044736f931dab32df57d13"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"935b4d62c31f9d5f04066427f3be54105a1db5bc","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"DocImpact: A \"default\" flag is introduced for QoS policies. If this flag"},{"line_number":22,"context_line":"           is enabled in a QoS policy (attached to a project), then all"},{"line_number":23,"context_line":"           networks and ports created in this project would have this"},{"line_number":24,"context_line":"           QoS policy assigned."},{"line_number":25,"context_line":"APIImpact"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":65,"id":"ff0f0b1f_d2b10149","line":23,"range":{"start_line":23,"start_character":20,"end_line":23,"end_character":29},"updated":"2017-05-24 07:26:46.000000000","message":"i don\u0027t see anything about port creation in this patch.\n\ndo you mean the existing mechanism to use network\u0027s qos policy for ports without qos policy?  if so, it\u0027s better not to mention it here.  it\u0027s confusing.","commit_id":"67dafcdf6a4caafa9923ce3256f988de29d4c22f"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"00300af81b07bd9faaccf370f515c1b9e6d2d38a","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"DocImpact: A \"default\" flag is introduced for QoS policies. If this flag"},{"line_number":22,"context_line":"           is enabled in a QoS policy (attached to a project), then all"},{"line_number":23,"context_line":"           networks and ports created in this project would have this"},{"line_number":24,"context_line":"           QoS policy assigned."},{"line_number":25,"context_line":"APIImpact"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":65,"id":"ff0f0b1f_f1d87153","line":23,"range":{"start_line":23,"start_character":20,"end_line":23,"end_character":29},"in_reply_to":"ff0f0b1f_682ec4fb","updated":"2017-05-24 17:56:22.000000000","message":"this explanation made me think a newly created port will have the default qos policy as a network does.\nit isn\u0027t the case.","commit_id":"67dafcdf6a4caafa9923ce3256f988de29d4c22f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4aafca408bac72d12e13116a33a4f55345756cf6","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"DocImpact: A \"default\" flag is introduced for QoS policies. If this flag"},{"line_number":22,"context_line":"           is enabled in a QoS policy (attached to a project), then all"},{"line_number":23,"context_line":"           networks and ports created in this project would have this"},{"line_number":24,"context_line":"           QoS policy assigned."},{"line_number":25,"context_line":"APIImpact"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":65,"id":"ff0f0b1f_682ec4fb","line":23,"range":{"start_line":23,"start_character":20,"end_line":23,"end_character":29},"in_reply_to":"ff0f0b1f_d2b10149","updated":"2017-05-24 08:45:25.000000000","message":"As you can see in [1], when a network is created, the default policy is assigned (if no specific QoS policy is defined). Because a port is a network resource (a port must be always assigned to a network), it makes sense to talk about networks and ports.\n\n[1] https://review.openstack.org/#/c/428304/65/neutron/core_extensions/qos.py","commit_id":"67dafcdf6a4caafa9923ce3256f988de29d4c22f"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"935b4d62c31f9d5f04066427f3be54105a1db5bc","unresolved":false,"context_lines":[{"line_number":21,"context_line":"DocImpact: A \"default\" flag is introduced for QoS policies. If this flag"},{"line_number":22,"context_line":"           is enabled in a QoS policy (attached to a project), then all"},{"line_number":23,"context_line":"           networks and ports created in this project would have this"},{"line_number":24,"context_line":"           QoS policy assigned."},{"line_number":25,"context_line":"APIImpact"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Closes-Bug: #1639220"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":65,"id":"ff0f0b1f_327cbd81","line":24,"range":{"start_line":24,"start_character":22,"end_line":24,"end_character":30},"updated":"2017-05-24 07:26:46.000000000","message":"unless a policy is explicitly specified?","commit_id":"67dafcdf6a4caafa9923ce3256f988de29d4c22f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4aafca408bac72d12e13116a33a4f55345756cf6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"DocImpact: A \"default\" flag is introduced for QoS policies. If this flag"},{"line_number":22,"context_line":"           is enabled in a QoS policy (attached to a project), then all"},{"line_number":23,"context_line":"           networks and ports created in this project would have this"},{"line_number":24,"context_line":"           QoS policy assigned."},{"line_number":25,"context_line":"APIImpact"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Closes-Bug: #1639220"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":65,"id":"ff0f0b1f_88ed98b8","line":24,"range":{"start_line":24,"start_character":22,"end_line":24,"end_character":30},"in_reply_to":"ff0f0b1f_327cbd81","updated":"2017-05-24 08:45:25.000000000","message":"You are right. But this is assumed. Because this is PS65 and this is only the reference to a DocImpact bug, I think there is no need to be so specific.","commit_id":"67dafcdf6a4caafa9923ce3256f988de29d4c22f"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"00300af81b07bd9faaccf370f515c1b9e6d2d38a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"DocImpact: A \"default\" flag is introduced for QoS policies. If this flag"},{"line_number":22,"context_line":"           is enabled in a QoS policy (attached to a project), then all"},{"line_number":23,"context_line":"           networks and ports created in this project would have this"},{"line_number":24,"context_line":"           QoS policy assigned."},{"line_number":25,"context_line":"APIImpact"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Closes-Bug: #1639220"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":65,"id":"ff0f0b1f_11bbe5c4","line":24,"range":{"start_line":24,"start_character":22,"end_line":24,"end_character":30},"in_reply_to":"ff0f0b1f_88ed98b8","updated":"2017-05-24 17:56:22.000000000","message":"ok","commit_id":"67dafcdf6a4caafa9923ce3256f988de29d4c22f"}],"neutron/agent/l2/extensions/qos.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1a53cacbdfc89d69e845d2365dec50f3ce2cebbe","unresolved":false,"context_lines":[{"line_number":292,"context_line":"                     port[\u0027port_id\u0027])"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def _create_policy_network_binding(self, context, network_list):"},{"line_number":295,"context_line":"        for network in [net for net in network_list"},{"line_number":296,"context_line":"                        if net.id not in self.networks]:"},{"line_number":297,"context_line":"            self.networks.add(network.id)"},{"line_number":298,"context_line":"            qos_policy_id \u003d qos_db_api.get_default_qos_policy_id(context)"}],"source_content_type":"text/x-python","patch_set":23,"id":"3a1ff146_1abba628","line":295,"range":{"start_line":295,"start_character":7,"end_line":295,"end_character":28},"updated":"2017-03-16 15:49:16.000000000","message":"Just use the for and the if loop normally as the list of nets are not used anywhere else","commit_id":"7bdccde8d167bab0aa4341e9e5b69b73f2173116"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"525dd70b856ba6345cc3e03eab580a7b6c5d8d3a","unresolved":false,"context_lines":[{"line_number":292,"context_line":"                     port[\u0027port_id\u0027])"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def _create_policy_network_binding(self, context, network_list):"},{"line_number":295,"context_line":"        for network in [net for net in network_list"},{"line_number":296,"context_line":"                        if net.id not in self.networks]:"},{"line_number":297,"context_line":"            self.networks.add(network.id)"},{"line_number":298,"context_line":"            qos_policy_id \u003d qos_db_api.get_default_qos_policy_id(context)"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a1ced50_c3ca241a","line":295,"range":{"start_line":295,"start_character":7,"end_line":295,"end_character":28},"in_reply_to":"1a1ced50_c063fa3f","updated":"2017-03-20 09:05:56.000000000","message":"for net in network_list:\n     if net.id not in self.networks:\n         .\n         .\n         .\n\nThis is not a major change, just that the list creation is not required in Line#295","commit_id":"7bdccde8d167bab0aa4341e9e5b69b73f2173116"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d3990a6c1447cc4cfd7783a7da18e62dd88a17ba","unresolved":false,"context_lines":[{"line_number":292,"context_line":"                     port[\u0027port_id\u0027])"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def _create_policy_network_binding(self, context, network_list):"},{"line_number":295,"context_line":"        for network in [net for net in network_list"},{"line_number":296,"context_line":"                        if net.id not in self.networks]:"},{"line_number":297,"context_line":"            self.networks.add(network.id)"},{"line_number":298,"context_line":"            qos_policy_id \u003d qos_db_api.get_default_qos_policy_id(context)"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a1ced50_09837605","line":295,"range":{"start_line":295,"start_character":7,"end_line":295,"end_character":28},"in_reply_to":"1a1ced50_c3ca241a","updated":"2017-03-20 12:04:44.000000000","message":"You are right: I don\u0027t need to create a list.\n\nBut I\u0027ll keep the generator instead of creating a nested conditional.\n\nJust for fun: the generator is faster than the nested conditional.\n\n\n\nimport cProfile\n\ndef do_cprofile(func):\n    def profiled_func(*args, **kwargs):\n        profile \u003d cProfile.Profile()\n        try:\n            profile.enable()\n            result \u003d func(*args, **kwargs)\n            profile.disable()\n            return result\n        finally:\n            profile.print_stats()\n    return profiled_func\n\na \u003d list(range(10000000))\n\n\n@do_cprofile\ndef nested():\n    for i in a:\n        if i % 100000 \u003d\u003d 0:\n            continue\n\n@do_cprofile\ndef generator():\n   for i in (i for i in a if i % 100000 \u003d\u003d 0):\n       continue\n\n\n\nnested()\ngenerator()\n\n\n         2 function calls in 0.528 seconds\n\n   Ordered by: standard name\n\n   ncalls  tottime  percall  cumtime  percall filename:lineno(function)\n        1    0.528    0.528    0.528    0.528 z.py:18(nested)\n        1    0.000    0.000    0.000    0.000 {method \u0027disable\u0027 of \u0027_lsprof.Profiler\u0027 objects}\n\n\n         103 function calls in 0.462 seconds\n\n   Ordered by: standard name\n\n   ncalls  tottime  percall  cumtime  percall filename:lineno(function)\n        1    0.000    0.000    0.462    0.462 z.py:24(generator)\n      101    0.462    0.005    0.462    0.005 z.py:26(\u003cgenexpr\u003e)\n        1    0.000    0.000    0.000    0.000 {method \u0027disable\u0027 of \u0027_lsprof.Profiler\u0027 objects}","commit_id":"7bdccde8d167bab0aa4341e9e5b69b73f2173116"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"63471bcbc8804fef04d10954bec26bed00adb490","unresolved":false,"context_lines":[{"line_number":292,"context_line":"                     port[\u0027port_id\u0027])"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def _create_policy_network_binding(self, context, network_list):"},{"line_number":295,"context_line":"        for network in [net for net in network_list"},{"line_number":296,"context_line":"                        if net.id not in self.networks]:"},{"line_number":297,"context_line":"            self.networks.add(network.id)"},{"line_number":298,"context_line":"            qos_policy_id \u003d qos_db_api.get_default_qos_policy_id(context)"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a1ced50_c063fa3f","line":295,"range":{"start_line":295,"start_character":7,"end_line":295,"end_character":28},"in_reply_to":"3a1ff146_1abba628","updated":"2017-03-20 08:57:55.000000000","message":"I don\u0027t understand this comment.\n\nHere I\u0027m using a conditional generator. \"network\" is an element in \"network_list\" and not in \"self.networks\"","commit_id":"7bdccde8d167bab0aa4341e9e5b69b73f2173116"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"104441792a5e8ece6fefe06d5511466ce2c758a1","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        # server does not allow to remove a policy that is attached to any"},{"line_number":219,"context_line":"        # port, so we ignore DELETED events. Also, if we receive a CREATED"},{"line_number":220,"context_line":"        # event for a policy, it means that there are no ports so far that are"},{"line_number":221,"context_line":"        # attached to it. That\u0027s why we are interested in UPDATED events only"},{"line_number":222,"context_line":"        if (resource_type \u003d\u003d resources.QOS_POLICY and"},{"line_number":223,"context_line":"                event_type \u003d\u003d events.UPDATED):"},{"line_number":224,"context_line":"            for qos_policy in resource_list:"}],"source_content_type":"text/x-python","patch_set":42,"id":"ffe62b97_2d91ebf1","line":221,"updated":"2017-03-29 12:41:39.000000000","message":"I\u0027d add to this comment describing the purpose of subscribing to resources.NETWORK","commit_id":"6008146ca3e1207fbcbd6191bf878000c92f0d2c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8f0c5db5220151dcf8f4c2a924ae00c2e6349f0c","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        # server does not allow to remove a policy that is attached to any"},{"line_number":219,"context_line":"        # port, so we ignore DELETED events. Also, if we receive a CREATED"},{"line_number":220,"context_line":"        # event for a policy, it means that there are no ports so far that are"},{"line_number":221,"context_line":"        # attached to it. That\u0027s why we are interested in UPDATED events only"},{"line_number":222,"context_line":"        if (resource_type \u003d\u003d resources.QOS_POLICY and"},{"line_number":223,"context_line":"                event_type \u003d\u003d events.UPDATED):"},{"line_number":224,"context_line":"            for qos_policy in resource_list:"}],"source_content_type":"text/x-python","patch_set":42,"id":"ffe62b97_c64ed695","line":221,"in_reply_to":"ffe62b97_2d91ebf1","updated":"2017-03-29 15:34:19.000000000","message":"Done","commit_id":"6008146ca3e1207fbcbd6191bf878000c92f0d2c"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"104441792a5e8ece6fefe06d5511466ce2c758a1","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            for qos_policy in resource_list:"},{"line_number":225,"context_line":"                self._process_update_policy(qos_policy)"},{"line_number":226,"context_line":"        elif resource_type \u003d\u003d resources.NETWORK:"},{"line_number":227,"context_line":"            if event_type \u003d\u003d events.UPDATED:"},{"line_number":228,"context_line":"                self._create_policy_network_binding(context, resource_list)"},{"line_number":229,"context_line":"            elif event_type \u003d\u003d events.DELETED:"},{"line_number":230,"context_line":"                self._delete_network(resource_list)"}],"source_content_type":"text/x-python","patch_set":42,"id":"ffe62b97_0d53c73a","line":227,"range":{"start_line":227,"start_character":15,"end_line":227,"end_character":43},"updated":"2017-03-29 12:41:39.000000000","message":"Should this also include events.CREATED?","commit_id":"6008146ca3e1207fbcbd6191bf878000c92f0d2c"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"5c7b17829541268d046d90fb082a2481f6bc384f","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            for qos_policy in resource_list:"},{"line_number":225,"context_line":"                self._process_update_policy(qos_policy)"},{"line_number":226,"context_line":"        elif resource_type \u003d\u003d resources.NETWORK:"},{"line_number":227,"context_line":"            if event_type \u003d\u003d events.UPDATED:"},{"line_number":228,"context_line":"                self._create_policy_network_binding(context, resource_list)"},{"line_number":229,"context_line":"            elif event_type \u003d\u003d events.DELETED:"},{"line_number":230,"context_line":"                self._delete_network(resource_list)"}],"source_content_type":"text/x-python","patch_set":42,"id":"ffe62b97_ecf65b5d","line":227,"range":{"start_line":227,"start_character":15,"end_line":227,"end_character":43},"in_reply_to":"ffe62b97_06583e53","updated":"2017-03-29 15:59:20.000000000","message":"ack","commit_id":"6008146ca3e1207fbcbd6191bf878000c92f0d2c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8f0c5db5220151dcf8f4c2a924ae00c2e6349f0c","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            for qos_policy in resource_list:"},{"line_number":225,"context_line":"                self._process_update_policy(qos_policy)"},{"line_number":226,"context_line":"        elif resource_type \u003d\u003d resources.NETWORK:"},{"line_number":227,"context_line":"            if event_type \u003d\u003d events.UPDATED:"},{"line_number":228,"context_line":"                self._create_policy_network_binding(context, resource_list)"},{"line_number":229,"context_line":"            elif event_type \u003d\u003d events.DELETED:"},{"line_number":230,"context_line":"                self._delete_network(resource_list)"}],"source_content_type":"text/x-python","patch_set":42,"id":"ffe62b97_06583e53","line":227,"range":{"start_line":227,"start_character":15,"end_line":227,"end_character":43},"in_reply_to":"ffe62b97_0d53c73a","updated":"2017-03-29 15:34:19.000000000","message":"sesource.NETWORK has only UPDATED and DELETED","commit_id":"6008146ca3e1207fbcbd6191bf878000c92f0d2c"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"a46c8cef8589017b3672961ddef65c68e32651fc","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    def _delete_network(self, network_list):"},{"line_number":301,"context_line":"        for network in network_list:"},{"line_number":302,"context_line":"            self.networks.discard(network.id)"},{"line_number":303,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"ffe62b97_35c37159","line":303,"updated":"2017-03-29 13:48:41.000000000","message":"Remove this blank line, it will fail pep8.","commit_id":"6008146ca3e1207fbcbd6191bf878000c92f0d2c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8f0c5db5220151dcf8f4c2a924ae00c2e6349f0c","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    def _delete_network(self, network_list):"},{"line_number":301,"context_line":"        for network in network_list:"},{"line_number":302,"context_line":"            self.networks.discard(network.id)"},{"line_number":303,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"ffe62b97_666eea00","line":303,"in_reply_to":"ffe62b97_35c37159","updated":"2017-03-29 15:34:19.000000000","message":"Thanks!","commit_id":"6008146ca3e1207fbcbd6191bf878000c92f0d2c"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"9f3e7bc2cf643c4dfdc326ccd2ad66e568976356","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        # in UPDATED events only."},{"line_number":223,"context_line":"        # Network events are captured too. If a network is created and there"},{"line_number":224,"context_line":"        # is a default QoS policy in this project, this network will be"},{"line_number":225,"context_line":"        # updated. When the network is deleted, is removed from the local"},{"line_number":226,"context_line":"        # network set."},{"line_number":227,"context_line":"        if (resource_type \u003d\u003d resources.QOS_POLICY and"},{"line_number":228,"context_line":"                event_type \u003d\u003d events.UPDATED):"}],"source_content_type":"text/x-python","patch_set":43,"id":"ffe62b97_5ac859a4","line":225,"range":{"start_line":225,"start_character":47,"end_line":225,"end_character":48},"updated":"2017-03-29 16:41:11.000000000","message":"nit: it","commit_id":"d30cdfaa6e092766962f07e5f33f36edf7ca2f16"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4ba78060327b08937f14c8f0ca0ad28eb351212d","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        # in UPDATED events only."},{"line_number":223,"context_line":"        # Network events are captured too. If a network is created and there"},{"line_number":224,"context_line":"        # is a default QoS policy in this project, this network will be"},{"line_number":225,"context_line":"        # updated. When the network is deleted, is removed from the local"},{"line_number":226,"context_line":"        # network set."},{"line_number":227,"context_line":"        if (resource_type \u003d\u003d resources.QOS_POLICY and"},{"line_number":228,"context_line":"                event_type \u003d\u003d events.UPDATED):"}],"source_content_type":"text/x-python","patch_set":43,"id":"ffe62b97_58171a53","line":225,"range":{"start_line":225,"start_character":47,"end_line":225,"end_character":48},"in_reply_to":"ffe62b97_5ac859a4","updated":"2017-03-30 13:28:36.000000000","message":"Done","commit_id":"d30cdfaa6e092766962f07e5f33f36edf7ca2f16"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"cae43d92c545c2e73afbb8e397a807de762e88ff","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from neutron.api.rpc.callbacks import events"},{"line_number":27,"context_line":"from neutron.api.rpc.callbacks import resources"},{"line_number":28,"context_line":"from neutron.api.rpc.handlers import resources_rpc"},{"line_number":29,"context_line":"from neutron.db.qos import api as qos_db_api"},{"line_number":30,"context_line":"from neutron import manager"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":44,"id":"dfeb2761_b6000769","line":29,"updated":"2017-04-04 11:08:30.000000000","message":"does this mean to access db from l2 agent directly?","commit_id":"f3985b0d32dc15bba4044736f931dab32df57d13"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8c1e1b7a9e6c0b1d3f4dbd8045147068c2268740","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from neutron.api.rpc.callbacks import events"},{"line_number":27,"context_line":"from neutron.api.rpc.callbacks import resources"},{"line_number":28,"context_line":"from neutron.api.rpc.handlers import resources_rpc"},{"line_number":29,"context_line":"from neutron.db.qos import api as qos_db_api"},{"line_number":30,"context_line":"from neutron import manager"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":44,"id":"dfeb2761_3f303ae8","line":29,"in_reply_to":"dfeb2761_b6000769","updated":"2017-04-04 17:34:46.000000000","message":"This is a terrible mistake...\n\nI need to refactor this. The network binding MUST be done only in the service plugin, never from the agent.\n\nAs always, very careful with your reviews!","commit_id":"f3985b0d32dc15bba4044736f931dab32df57d13"}],"neutron/common/eventlet_utils.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"3566c4081ae4cba5c2ee8fa9ee776581b6713128","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        #       eventletmonkey_patch-breaks"},{"line_number":31,"context_line":"        eventlet.monkey_patch(os\u003dFalse, thread\u003dFalse)"},{"line_number":32,"context_line":"    else:"},{"line_number":33,"context_line":"        ###eventlet.monkey_patch()"},{"line_number":34,"context_line":"        eventlet.monkey_patch(thread\u003dFalse)"},{"line_number":35,"context_line":"        p_c_e \u003d importutils.import_module(\u0027pyroute2.config.eventlet\u0027)"},{"line_number":36,"context_line":"        p_c_e.eventlet_config()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_5f015f37","line":33,"updated":"2017-02-07 17:59:11.000000000","message":"nit: commented lines need to be removed","commit_id":"00e0b30ff3240c5de67a04a1121ac9ba6c72b919"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ffa848e536264a91e17c784f5dea0145af626497","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        #       eventletmonkey_patch-breaks"},{"line_number":31,"context_line":"        eventlet.monkey_patch(os\u003dFalse, thread\u003dFalse)"},{"line_number":32,"context_line":"    else:"},{"line_number":33,"context_line":"        ###eventlet.monkey_patch()"},{"line_number":34,"context_line":"        eventlet.monkey_patch(thread\u003dFalse)"},{"line_number":35,"context_line":"        p_c_e \u003d importutils.import_module(\u0027pyroute2.config.eventlet\u0027)"},{"line_number":36,"context_line":"        p_c_e.eventlet_config()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_420ee83b","line":33,"in_reply_to":"1a430d35_5f015f37","updated":"2017-02-08 10:18:47.000000000","message":"Uffff sorry!! I set this because of the debugger","commit_id":"00e0b30ff3240c5de67a04a1121ac9ba6c72b919"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0a4ffd5118d86f86a8c1442393c6ee68e758b0d8","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        #       eventletmonkey_patch-breaks"},{"line_number":31,"context_line":"        eventlet.monkey_patch(os\u003dFalse, thread\u003dFalse)"},{"line_number":32,"context_line":"    else:"},{"line_number":33,"context_line":"        ###eventlet.monkey_patch()"},{"line_number":34,"context_line":"        eventlet.monkey_patch(thread\u003dFalse)"},{"line_number":35,"context_line":"        p_c_e \u003d importutils.import_module(\u0027pyroute2.config.eventlet\u0027)"},{"line_number":36,"context_line":"        p_c_e.eventlet_config()"}],"source_content_type":"text/x-python","patch_set":32,"id":"ffe62b97_9011b9af","line":33,"updated":"2017-03-26 13:50:43.000000000","message":"why are you commenting this out?","commit_id":"1bb59031de703a85e61e0fce64272515f905102c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"631880f81de17e7ede55c59ec0b456df01432a33","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        #       eventletmonkey_patch-breaks"},{"line_number":31,"context_line":"        eventlet.monkey_patch(os\u003dFalse, thread\u003dFalse)"},{"line_number":32,"context_line":"    else:"},{"line_number":33,"context_line":"        ###eventlet.monkey_patch()"},{"line_number":34,"context_line":"        eventlet.monkey_patch(thread\u003dFalse)"},{"line_number":35,"context_line":"        p_c_e \u003d importutils.import_module(\u0027pyroute2.config.eventlet\u0027)"},{"line_number":36,"context_line":"        p_c_e.eventlet_config()"}],"source_content_type":"text/x-python","patch_set":32,"id":"ffe62b97_b09f1d02","line":33,"in_reply_to":"ffe62b97_9011b9af","updated":"2017-03-26 14:10:32.000000000","message":"Because I usually use a debugger. And sometimes I forget to uncomment it... Thanks!","commit_id":"1bb59031de703a85e61e0fce64272515f905102c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bdad7891e6825555a28c82038fd710cd3f3525a6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        #       eventletmonkey_patch-breaks"},{"line_number":31,"context_line":"        eventlet.monkey_patch(os\u003dFalse, thread\u003dFalse)"},{"line_number":32,"context_line":"    else:"},{"line_number":33,"context_line":"        eventlet.monkey_patch(thread\u003dFalse)"},{"line_number":34,"context_line":"        p_c_e \u003d importutils.import_module(\u0027pyroute2.config.eventlet\u0027)"},{"line_number":35,"context_line":"        p_c_e.eventlet_config()"}],"source_content_type":"text/x-python","patch_set":50,"id":"7ffa3b31_1e73504f","line":33,"updated":"2017-04-19 13:14:32.000000000","message":"is it required to make default qos policy?","commit_id":"6f3470c055de8586adf69aae7dac6e9eedd3d639"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"82ed85fa4d1d54a529fca7673068be1ba27bbc12","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        #       eventletmonkey_patch-breaks"},{"line_number":31,"context_line":"        eventlet.monkey_patch(os\u003dFalse, thread\u003dFalse)"},{"line_number":32,"context_line":"    else:"},{"line_number":33,"context_line":"        eventlet.monkey_patch(thread\u003dFalse)"},{"line_number":34,"context_line":"        p_c_e \u003d importutils.import_module(\u0027pyroute2.config.eventlet\u0027)"},{"line_number":35,"context_line":"        p_c_e.eventlet_config()"}],"source_content_type":"text/x-python","patch_set":50,"id":"7ffa3b31_197c8ab3","line":33,"in_reply_to":"7ffa3b31_1e73504f","updated":"2017-04-19 13:32:33.000000000","message":"Again.... I always make the same mistake. This is only for testing.","commit_id":"6f3470c055de8586adf69aae7dac6e9eedd3d639"}],"neutron/common/exceptions.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1f8e355a442546e2aa0de0ebc77fbdcb63032c28","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                \"could not be found.\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class QosDefaultPolicyFound(e.Conflict):"},{"line_number":35,"context_line":"    message \u003d _(\"QoS policy %(policy_id)s is the default policy.\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_abf6a4f6","line":34,"updated":"2017-03-21 12:12:57.000000000","message":"nit: maybe better name would be \"QoSDefaultPolicyAlreadyExists\" or something like that. \"QoSDefaultPolicyFound not sounds like something wrong for me :)","commit_id":"40d88fe8c3eef05bed5cefba8c3322cbb42d7729"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6c2f3c8da4e5713c8b43d59e55638bb9e4688962","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                \"could not be found.\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class QosDefaultPolicyFound(e.Conflict):"},{"line_number":35,"context_line":"    message \u003d _(\"QoS policy %(policy_id)s is the default policy.\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_8ed7314a","line":34,"in_reply_to":"1a1ced50_abf6a4f6","updated":"2017-03-21 16:40:07.000000000","message":"You are right","commit_id":"40d88fe8c3eef05bed5cefba8c3322cbb42d7729"}],"neutron/db/migration/alembic_migrations/versions/ocata/expand/83eb0c3315b3_add_is_default_to_qos_policies.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1bbed4a68bd345385a3f655dd601a8b2a034a46d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"add is default to qos policies"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Revision ID: 83eb0c3315b3"},{"line_number":19,"context_line":"Revises: a9c43481023c"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_87be80fd","line":16,"updated":"2017-02-02 19:34:25.000000000","message":"It\u0027s likely this is not making ocata, please do not forget to move it to Pike when it opens up.","commit_id":"87a8c99b3f93233cb2567fc23a5050958d3f124c"}],"neutron/db/migration/alembic_migrations/versions/pike/expand/62c781cb6192_add_is_default_to_qos_policies.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"3566c4081ae4cba5c2ee8fa9ee776581b6713128","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_428b48c3","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":37},"updated":"2017-02-07 17:59:11.000000000","message":"/s/OpenStack Foundation/Intel Corporation","commit_id":"00e0b30ff3240c5de67a04a1121ac9ba6c72b919"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ffa848e536264a91e17c784f5dea0145af626497","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_82045018","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":37},"in_reply_to":"1a430d35_428b48c3","updated":"2017-02-08 10:18:47.000000000","message":"Done, thanks","commit_id":"00e0b30ff3240c5de67a04a1121ac9ba6c72b919"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1f8e355a442546e2aa0de0ebc77fbdcb63032c28","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                  sa.Column(\u0027is_default\u0027,"},{"line_number":36,"context_line":"                            sa.Boolean(),"},{"line_number":37,"context_line":"                            server_default\u003dsql.false(),"},{"line_number":38,"context_line":"                            nullable\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_cbc68099","line":38,"updated":"2017-03-21 12:12:57.000000000","message":"I\u0027m not database expert but maybe there is possibility to add some kind of contstraint that only one policy in tenant can be default directly on db level?","commit_id":"40d88fe8c3eef05bed5cefba8c3322cbb42d7729"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6c2f3c8da4e5713c8b43d59e55638bb9e4688962","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                  sa.Column(\u0027is_default\u0027,"},{"line_number":36,"context_line":"                            sa.Boolean(),"},{"line_number":37,"context_line":"                            server_default\u003dsql.false(),"},{"line_number":38,"context_line":"                            nullable\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_997a1976","line":38,"in_reply_to":"1a1ced50_cbc68099","updated":"2017-03-21 16:40:07.000000000","message":"This could be done with a conditional insert/update. But this logic is already implemented in the service plugin.\n\nI know: you can modify the DB manually (I\u0027ve done this), but always under your responsibility.","commit_id":"40d88fe8c3eef05bed5cefba8c3322cbb42d7729"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"24235414982aae03ce8d0ab537202ef8616f6780","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    op.add_column(\u0027qos_policies\u0027,"},{"line_number":35,"context_line":"                  sa.Column(\u0027is_default\u0027,"},{"line_number":36,"context_line":"                            sa.Boolean(),"},{"line_number":37,"context_line":"                            server_default\u003dsql.false(),"},{"line_number":38,"context_line":"                            nullable\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":40,"id":"ffe62b97_1ed57a1c","line":37,"range":{"start_line":37,"start_character":43,"end_line":37,"end_character":55},"updated":"2017-03-28 04:50:00.000000000","message":"This can simply be False","commit_id":"6224c845d77ea2e3c4aaa0c7d7ce4692d7e3d5aa"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"cb64da352b744af68662cef0f0ffa404b5860b78","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    op.add_column(\u0027qos_policies\u0027,"},{"line_number":35,"context_line":"                  sa.Column(\u0027is_default\u0027,"},{"line_number":36,"context_line":"                            sa.Boolean(),"},{"line_number":37,"context_line":"                            server_default\u003dsql.false(),"},{"line_number":38,"context_line":"                            nullable\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":40,"id":"ffe62b97_29324360","line":37,"range":{"start_line":37,"start_character":43,"end_line":37,"end_character":55},"in_reply_to":"ffe62b97_1ed57a1c","updated":"2017-03-28 07:37:07.000000000","message":"No, this should be sql.false()","commit_id":"6224c845d77ea2e3c4aaa0c7d7ce4692d7e3d5aa"}],"neutron/db/migration/alembic_migrations/versions/pike/expand/62c781cb6192_add_qos_policies_default_table.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d3937bcfadb1ace0a04689f81f08f6970c431975","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \u0027qos_policies_default\u0027,"},{"line_number":35,"context_line":"        sa.Column(\u0027qos_policy_id\u0027,"},{"line_number":36,"context_line":"                  sa.String(length\u003d36),"},{"line_number":37,"context_line":"                  sa.ForeignKey(\u0027qos_policies.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":38,"context_line":"                  nullable\u003dFalse),"},{"line_number":39,"context_line":"        sa.Column(\u0027project_id\u0027,"},{"line_number":40,"context_line":"                  sa.String(length\u003d255),"}],"source_content_type":"text/x-python","patch_set":62,"id":"5ff73747_75b27196","line":37,"range":{"start_line":37,"start_character":51,"end_line":37,"end_character":69},"updated":"2017-04-26 19:50:06.000000000","message":"i think this is incorrect.\n\nif i remeber my sql days correctly this forign key relationship would mean if i delete a row form the \nqos_policies_default table this will cascade and delete the referenced row in the qos_policies table removing the policy entrily.\n\ni belive you want to add this constriant to the the existing qos_policies table not the new one as a seperate alter table statement after you create the new table.","commit_id":"4625f53e00e203a948308c7d7313eb3bafda0c6d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"70ab71c4ca20009a718083c8cfb3c66f0a059065","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \u0027qos_policies_default\u0027,"},{"line_number":35,"context_line":"        sa.Column(\u0027qos_policy_id\u0027,"},{"line_number":36,"context_line":"                  sa.String(length\u003d36),"},{"line_number":37,"context_line":"                  sa.ForeignKey(\u0027qos_policies.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":38,"context_line":"                  nullable\u003dFalse),"},{"line_number":39,"context_line":"        sa.Column(\u0027project_id\u0027,"},{"line_number":40,"context_line":"                  sa.String(length\u003d255),"}],"source_content_type":"text/x-python","patch_set":62,"id":"5ff73747_8a6b8a1c","line":37,"range":{"start_line":37,"start_character":51,"end_line":37,"end_character":69},"in_reply_to":"5ff73747_75b27196","updated":"2017-04-27 08:01:08.000000000","message":"I thought the same the first time.\n\nThis stament creates a listener to the parent table (in this case \u0027qos_policies\u0027). If in the parent table (in this hierarchical DB), with the field \"id\" matching the one stored in \"qos_policies_default\" is deleted, the register in this table will be deleted.\n\nFrom [1]:\nCASCADE: Delete or update the row from the parent table, and automatically delete or update the matching rows in the child table. Both ON DELETE CASCADE and ON UPDATE CASCADE are supported. Between two tables, do not define several ON UPDATE CASCADE clauses that act on the same column in the parent table or in the child table.\n\n[1] https://dev.mysql.com/doc/refman/5.7/en/create-table-foreign-keys.html","commit_id":"4625f53e00e203a948308c7d7313eb3bafda0c6d"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"935b4d62c31f9d5f04066427f3be54105a1db5bc","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        sa.Column(\u0027project_id\u0027,"},{"line_number":40,"context_line":"                  sa.String(length\u003d255),"},{"line_number":41,"context_line":"                  nullable\u003dFalse,"},{"line_number":42,"context_line":"                  index\u003dTrue,"},{"line_number":43,"context_line":"                  primary_key\u003dTrue),"},{"line_number":44,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":65,"id":"ff0f0b1f_8f2da2a9","line":42,"range":{"start_line":42,"start_character":18,"end_line":42,"end_character":28},"updated":"2017-05-24 07:26:46.000000000","message":"is it necessary for a primary key?","commit_id":"67dafcdf6a4caafa9923ce3256f988de29d4c22f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e97de2052485d12541a778003165d8bffc83c333","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        sa.Column(\u0027project_id\u0027,"},{"line_number":40,"context_line":"                  sa.String(length\u003d255),"},{"line_number":41,"context_line":"                  nullable\u003dFalse,"},{"line_number":42,"context_line":"                  index\u003dTrue,"},{"line_number":43,"context_line":"                  primary_key\u003dTrue),"},{"line_number":44,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":65,"id":"ff0f0b1f_3df7e25b","line":42,"range":{"start_line":42,"start_character":18,"end_line":42,"end_character":28},"in_reply_to":"ff0f0b1f_2859ecfc","updated":"2017-05-24 15:51:54.000000000","message":"Ok, this not the correct answer for this question (the question is not if this should be a primary key).\n\nProbably all backends will index the primary key. But index is not implicit in primary key [1]\n\nAlso there are other DB definitions in this repo using primary key and index.\n\n[1] https://pythonhosted.org/bob.db.msu_mfsd_mod/_modules/sqlalchemy/sql/schema.html","commit_id":"67dafcdf6a4caafa9923ce3256f988de29d4c22f"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"00300af81b07bd9faaccf370f515c1b9e6d2d38a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        sa.Column(\u0027project_id\u0027,"},{"line_number":40,"context_line":"                  sa.String(length\u003d255),"},{"line_number":41,"context_line":"                  nullable\u003dFalse,"},{"line_number":42,"context_line":"                  index\u003dTrue,"},{"line_number":43,"context_line":"                  primary_key\u003dTrue),"},{"line_number":44,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":65,"id":"ff0f0b1f_b1855909","line":42,"range":{"start_line":42,"start_character":18,"end_line":42,"end_character":28},"in_reply_to":"ff0f0b1f_3df7e25b","updated":"2017-05-24 17:56:22.000000000","message":"it\u0027s fine as far as it doesn\u0027t create an extra index.\n(i don\u0027t know if it does or not)","commit_id":"67dafcdf6a4caafa9923ce3256f988de29d4c22f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4aafca408bac72d12e13116a33a4f55345756cf6","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        sa.Column(\u0027project_id\u0027,"},{"line_number":40,"context_line":"                  sa.String(length\u003d255),"},{"line_number":41,"context_line":"                  nullable\u003dFalse,"},{"line_number":42,"context_line":"                  index\u003dTrue,"},{"line_number":43,"context_line":"                  primary_key\u003dTrue),"},{"line_number":44,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":65,"id":"ff0f0b1f_2859ecfc","line":42,"range":{"start_line":42,"start_character":18,"end_line":42,"end_character":28},"in_reply_to":"ff0f0b1f_8f2da2a9","updated":"2017-05-24 08:45:25.000000000","message":"For two reasons:\n- This field must be unique, with a one-to-one relationship with the project table.\n- To provide explicit access to this constrain, because I retrieve these registers using this parameter as a key.","commit_id":"67dafcdf6a4caafa9923ce3256f988de29d4c22f"}],"neutron/db/qos/api.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1f8e355a442546e2aa0de0ebc77fbdcb63032c28","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    \"\"\"Retrieve the default QoS policy ID.\"\"\""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    query \u003d (db_utils.model_query(context, models.QosPolicy)"},{"line_number":87,"context_line":"             .filter_by(is_default\u003dTrue).all())"},{"line_number":88,"context_line":"    if query:"},{"line_number":89,"context_line":"        return query[0].id"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_ab122407","line":87,"updated":"2017-03-21 12:12:57.000000000","message":"sorry for maybe stupid question but will this query return default policy only for current tenant or all default policies from database?","commit_id":"40d88fe8c3eef05bed5cefba8c3322cbb42d7729"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6c2f3c8da4e5713c8b43d59e55638bb9e4688962","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    \"\"\"Retrieve the default QoS policy ID.\"\"\""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    query \u003d (db_utils.model_query(context, models.QosPolicy)"},{"line_number":87,"context_line":"             .filter_by(is_default\u003dTrue).all())"},{"line_number":88,"context_line":"    if query:"},{"line_number":89,"context_line":"        return query[0].id"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_dab1df48","line":87,"in_reply_to":"1a1ced50_ab122407","updated":"2017-03-21 16:40:07.000000000","message":"Hmmm, this command will return all of them if the user is not admin or has advanced service rights (https://github.com/openstack/neutron/blob/master/neutron/db/_utils.py#L88)\n\nYou are right: I need to add a filter (project_id) depending on the network. This parameter must be passed by the caller (neutron.agent.l2.extension.qos.py:_create_policy_network_binding)","commit_id":"40d88fe8c3eef05bed5cefba8c3322cbb42d7729"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"3cbbaf9887260b213b65732e59603973747610c9","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    query \u003d (db_utils.model_query(context, models.QosPolicy)"},{"line_number":87,"context_line":"             .filter_by(is_default\u003dTrue,"},{"line_number":88,"context_line":"                        project_id\u003dproject_id).all())"},{"line_number":89,"context_line":"    if query:"},{"line_number":90,"context_line":"        return query[0].id"}],"source_content_type":"text/x-python","patch_set":46,"id":"bff0334d_f4b99578","line":88,"range":{"start_line":88,"start_character":47,"end_line":88,"end_character":50},"updated":"2017-04-11 21:20:37.000000000","message":"first() ?","commit_id":"a89de20b06bd480d6a0b5cc3f5ce94459f891edf"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"111136b929fba42ab2d67b0d8868b3277c21ee81","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    query \u003d (db_utils.model_query(context, models.QosPolicy)"},{"line_number":87,"context_line":"             .filter_by(is_default\u003dTrue,"},{"line_number":88,"context_line":"                        project_id\u003dproject_id).all())"},{"line_number":89,"context_line":"    if query:"},{"line_number":90,"context_line":"        return query[0].id"}],"source_content_type":"text/x-python","patch_set":46,"id":"bff0334d_ea007f04","line":88,"range":{"start_line":88,"start_character":47,"end_line":88,"end_character":50},"in_reply_to":"bff0334d_f4b99578","updated":"2017-04-12 10:04:54.000000000","message":"You are right, this is a mistake","commit_id":"a89de20b06bd480d6a0b5cc3f5ce94459f891edf"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"3cbbaf9887260b213b65732e59603973747610c9","unresolved":false,"context_lines":[{"line_number":87,"context_line":"             .filter_by(is_default\u003dTrue,"},{"line_number":88,"context_line":"                        project_id\u003dproject_id).all())"},{"line_number":89,"context_line":"    if query:"},{"line_number":90,"context_line":"        return query[0].id"}],"source_content_type":"text/x-python","patch_set":46,"id":"bff0334d_b4af8d28","line":90,"range":{"start_line":90,"start_character":15,"end_line":90,"end_character":26},"updated":"2017-04-11 21:20:37.000000000","message":"then you can, query.id, instead of query[0].id","commit_id":"a89de20b06bd480d6a0b5cc3f5ce94459f891edf"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"111136b929fba42ab2d67b0d8868b3277c21ee81","unresolved":false,"context_lines":[{"line_number":87,"context_line":"             .filter_by(is_default\u003dTrue,"},{"line_number":88,"context_line":"                        project_id\u003dproject_id).all())"},{"line_number":89,"context_line":"    if query:"},{"line_number":90,"context_line":"        return query[0].id"}],"source_content_type":"text/x-python","patch_set":46,"id":"bff0334d_cd015507","line":90,"range":{"start_line":90,"start_character":15,"end_line":90,"end_character":26},"in_reply_to":"bff0334d_b4af8d28","updated":"2017-04-12 10:04:54.000000000","message":"Done","commit_id":"a89de20b06bd480d6a0b5cc3f5ce94459f891edf"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e8bbe11e4808e2757436aa81cc09edd5c482426e","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"@db_api.retry_if_session_inactive()"},{"line_number":98,"context_line":"def delete_default_qos_policy(context, policy_id, project_id):"},{"line_number":99,"context_line":"    \"\"\"Delete the default QoS policy in a project\"\"\""},{"line_number":100,"context_line":"    try:"},{"line_number":101,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":53,"id":"7ffa3b31_05440673","line":98,"range":{"start_line":98,"start_character":39,"end_line":98,"end_character":48},"updated":"2017-04-20 03:36:56.000000000","message":"why does this take policy_id?","commit_id":"f12ac33a0c5632ddc957f1c02b7d56ab4c6553db"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"db56fda3d5083b56d7811b83266783494be4b8a9","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"@db_api.retry_if_session_inactive()"},{"line_number":98,"context_line":"def delete_default_qos_policy(context, policy_id, project_id):"},{"line_number":99,"context_line":"    \"\"\"Delete the default QoS policy in a project\"\"\""},{"line_number":100,"context_line":"    try:"},{"line_number":101,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":53,"id":"7ffa3b31_91a17897","line":98,"range":{"start_line":98,"start_character":39,"end_line":98,"end_character":48},"in_reply_to":"7ffa3b31_05440673","updated":"2017-04-20 08:24:57.000000000","message":"Done","commit_id":"f12ac33a0c5632ddc957f1c02b7d56ab4c6553db"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ed76fb4b23f23a740d55d7864d7729364b9bc8a0","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"@db_api.retry_if_session_inactive()"},{"line_number":83,"context_line":"def create_default_qos_policy(context, policy_id, project_id):"},{"line_number":84,"context_line":"    \"\"\"Create the default QoS policy in a project\"\"\""},{"line_number":85,"context_line":"    try:"},{"line_number":86,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":55,"id":"7ffa3b31_ef58a9fa","line":83,"updated":"2017-04-21 09:42:45.000000000","message":"can we please use OVO to do this rather than querying DB directly?","commit_id":"89aca763bf3dcb57f09d2b1b1de4d3587df18f3c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8eca073b22bc0a56cfe34cf9c8d77ed875a416f8","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"@db_api.retry_if_session_inactive()"},{"line_number":83,"context_line":"def create_default_qos_policy(context, policy_id, project_id):"},{"line_number":84,"context_line":"    \"\"\"Create the default QoS policy in a project\"\"\""},{"line_number":85,"context_line":"    try:"},{"line_number":86,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":55,"id":"7ffa3b31_cd62920a","line":83,"in_reply_to":"7ffa3b31_ef58a9fa","updated":"2017-04-21 13:09:24.000000000","message":"Done","commit_id":"89aca763bf3dcb57f09d2b1b1de4d3587df18f3c"}],"neutron/db/qos/models.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"3566c4081ae4cba5c2ee8fa9ee776581b6713128","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                                       backref\u003d\u0027qos_policy\u0027, lazy\u003d\u0027subquery\u0027,"},{"line_number":33,"context_line":"                                       cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":34,"context_line":"    is_default \u003d sa.Column(sa.Boolean, nullable\u003dFalse,"},{"line_number":35,"context_line":"                           server_default\u003dsql.false())"},{"line_number":36,"context_line":"    api_collections \u003d [\u0027policies\u0027]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_22863cdb","line":35,"updated":"2017-02-07 17:59:11.000000000","message":"Don\u0027t we need a default value in addition to server_default?","commit_id":"00e0b30ff3240c5de67a04a1121ac9ba6c72b919"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ffa848e536264a91e17c784f5dea0145af626497","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                                       backref\u003d\u0027qos_policy\u0027, lazy\u003d\u0027subquery\u0027,"},{"line_number":33,"context_line":"                                       cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":34,"context_line":"    is_default \u003d sa.Column(sa.Boolean, nullable\u003dFalse,"},{"line_number":35,"context_line":"                           server_default\u003dsql.false())"},{"line_number":36,"context_line":"    api_collections \u003d [\u0027policies\u0027]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_8ec9c05b","line":35,"in_reply_to":"1a430d35_22863cdb","updated":"2017-02-08 10:18:47.000000000","message":"I found the answer to this in http://docs.sqlalchemy.org/en/latest/core/defaults.html.\n\nWith \"server_default\", the value is added in the backend table definition:\nCREATE TABLE `qos_policies` (\n\t`id` VARCHAR(36) NOT NULL,\n\t`name` VARCHAR(255) NULL DEFAULT NULL,\n\t`project_id` VARCHAR(255) NULL DEFAULT NULL,\n\t`standard_attr_id` BIGINT(20) NOT NULL,\n\t`is_default` TINYINT(1) NOT NULL DEFAULT \u00270\u0027,\n        .......\n\nIf the value for \"is_default\" is not set, the SQL engine will set it to \u00270\u0027.","commit_id":"00e0b30ff3240c5de67a04a1121ac9ba6c72b919"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4c26c878b63b5b7e8d521fe98c5bb0dcaa440dce","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                                       backref\u003d\u0027qos_policy\u0027, lazy\u003d\u0027subquery\u0027,"},{"line_number":33,"context_line":"                                       cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":34,"context_line":"    is_default \u003d sa.Column(sa.Boolean, nullable\u003dFalse,"},{"line_number":35,"context_line":"                           server_default\u003dsql.false())"},{"line_number":36,"context_line":"    api_collections \u003d [\u0027policies\u0027]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_3aac3d35","line":35,"updated":"2017-02-09 16:09:00.000000000","message":"Thank you for the explanation. As this field is non nullable in the corresponding the field need to have the default value as follows:\n\n\u0027is_default\u0027: obj_fields.BooleanField(default\u003dFalse)","commit_id":"3757c60090e2b18e6e8cf06be15a8765c93df9f9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1a53cacbdfc89d69e845d2365dec50f3ce2cebbe","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                                       backref\u003d\u0027qos_policy\u0027, lazy\u003d\u0027subquery\u0027,"},{"line_number":33,"context_line":"                                       cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":34,"context_line":"    is_default \u003d sa.Column(sa.Boolean, nullable\u003dFalse,"},{"line_number":35,"context_line":"                           server_default\u003dsql.false())"},{"line_number":36,"context_line":"    api_collections \u003d [\u0027policies\u0027]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"3a1ff146_3a69428c","line":35,"range":{"start_line":35,"start_character":27,"end_line":35,"end_character":41},"updated":"2017-03-16 15:49:16.000000000","message":"this option is for Migration, not Models, IIRC","commit_id":"7bdccde8d167bab0aa4341e9e5b69b73f2173116"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"63471bcbc8804fef04d10954bec26bed00adb490","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                                       backref\u003d\u0027qos_policy\u0027, lazy\u003d\u0027subquery\u0027,"},{"line_number":33,"context_line":"                                       cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":34,"context_line":"    is_default \u003d sa.Column(sa.Boolean, nullable\u003dFalse,"},{"line_number":35,"context_line":"                           server_default\u003dsql.false())"},{"line_number":36,"context_line":"    api_collections \u003d [\u0027policies\u0027]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1a1ced50_4050ea5e","line":35,"range":{"start_line":35,"start_character":27,"end_line":35,"end_character":41},"in_reply_to":"3a1ff146_3a69428c","updated":"2017-03-20 08:57:55.000000000","message":"Done","commit_id":"7bdccde8d167bab0aa4341e9e5b69b73f2173116"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c3a84c7c18c26334093407a3d6c7e3364e1e7441","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                                       backref\u003d\u0027qos_policy\u0027, lazy\u003d\u0027subquery\u0027,"},{"line_number":33,"context_line":"                                       cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":34,"context_line":"    is_default \u003d sa.Column(sa.Boolean, nullable\u003dFalse,"},{"line_number":35,"context_line":"                           default\u003dsql.false())"},{"line_number":36,"context_line":"    api_collections \u003d [\u0027policies\u0027]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"ffe62b97_2803a175","line":35,"updated":"2017-03-26 21:53:54.000000000","message":"if You want to configure it as it is in migration script You should set \"server_default\" parameter here (instead of default).\n\nNow it makes some functional tests failing because migration script and model is not the same.\n\nAFAIK \"server_default\" represents value which will be stored on DB\u0027s side as default value for column and \"default\" means default value \u0027on python\u0027s side\u0027 only.","commit_id":"2fb4968467e8a41f05474424f31400db93b0a799"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"df834b935f3b8f814cec01129e9a98ab17b47326","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                                       backref\u003d\u0027qos_policy\u0027, lazy\u003d\u0027subquery\u0027,"},{"line_number":33,"context_line":"                                       cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":34,"context_line":"    is_default \u003d sa.Column(sa.Boolean, nullable\u003dFalse,"},{"line_number":35,"context_line":"                           default\u003dsql.false())"},{"line_number":36,"context_line":"    api_collections \u003d [\u0027policies\u0027]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"ffe62b97_08db3ded","line":35,"in_reply_to":"ffe62b97_2803a175","updated":"2017-03-26 22:13:59.000000000","message":"Yes, I found the error just a couple of minutes ago hehehe\n\nThanks!","commit_id":"2fb4968467e8a41f05474424f31400db93b0a799"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"24235414982aae03ce8d0ab537202ef8616f6780","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                                       backref\u003d\u0027qos_policy\u0027, lazy\u003d\u0027subquery\u0027,"},{"line_number":33,"context_line":"                                       cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":34,"context_line":"    is_default \u003d sa.Column(sa.Boolean, nullable\u003dFalse,"},{"line_number":35,"context_line":"                           server_default\u003dsql.false())"},{"line_number":36,"context_line":"    api_collections \u003d [\u0027policies\u0027]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ffe62b97_deda7249","line":35,"range":{"start_line":35,"start_character":27,"end_line":35,"end_character":52},"updated":"2017-03-28 04:50:00.000000000","message":"default\u003dfalse wont have been a problem here :)","commit_id":"6224c845d77ea2e3c4aaa0c7d7ce4692d7e3d5aa"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"cb64da352b744af68662cef0f0ffa404b5860b78","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                                       backref\u003d\u0027qos_policy\u0027, lazy\u003d\u0027subquery\u0027,"},{"line_number":33,"context_line":"                                       cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":34,"context_line":"    is_default \u003d sa.Column(sa.Boolean, nullable\u003dFalse,"},{"line_number":35,"context_line":"                           server_default\u003dsql.false())"},{"line_number":36,"context_line":"    api_collections \u003d [\u0027policies\u0027]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ffe62b97_090c1f92","line":35,"range":{"start_line":35,"start_character":27,"end_line":35,"end_character":52},"in_reply_to":"ffe62b97_deda7249","updated":"2017-03-28 07:37:07.000000000","message":"server_default and default are different. https://docs.openstack.org/developer/neutron/devref/db_layer.html#difference-between-default-and-server-default-parameters-for-columns","commit_id":"6224c845d77ea2e3c4aaa0c7d7ce4692d7e3d5aa"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ed76fb4b23f23a740d55d7864d7729364b9bc8a0","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    qos_policy_id \u003d sa.Column(sa.String(36),"},{"line_number":80,"context_line":"                              sa.ForeignKey(\u0027qos_policies.id\u0027,"},{"line_number":81,"context_line":"                                            ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":82,"context_line":"                              nullable\u003dFalse)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"class QosBandwidthLimitRule(model_base.HasId, model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":55,"id":"7ffa3b31_0f6635c2","line":82,"updated":"2017-04-21 09:42:45.000000000","message":"I think you will want \u0027revises_on_change\u0027 here to bump the revision of the qos policy whenever it is made default or loses it\u0027s default status.","commit_id":"89aca763bf3dcb57f09d2b1b1de4d3587df18f3c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8eca073b22bc0a56cfe34cf9c8d77ed875a416f8","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    qos_policy_id \u003d sa.Column(sa.String(36),"},{"line_number":80,"context_line":"                              sa.ForeignKey(\u0027qos_policies.id\u0027,"},{"line_number":81,"context_line":"                                            ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":82,"context_line":"                              nullable\u003dFalse)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"class QosBandwidthLimitRule(model_base.HasId, model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":55,"id":"7ffa3b31_edb9ce78","line":82,"in_reply_to":"7ffa3b31_0f6635c2","updated":"2017-04-21 13:09:24.000000000","message":"You are right","commit_id":"89aca763bf3dcb57f09d2b1b1de4d3587df18f3c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d3937bcfadb1ace0a04689f81f08f6970c431975","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                       model_base.HasProjectPrimaryKeyIndex):"},{"line_number":78,"context_line":"    __tablename__ \u003d \u0027qos_policies_default\u0027"},{"line_number":79,"context_line":"    qos_policy_id \u003d sa.Column(sa.String(36),"},{"line_number":80,"context_line":"                              sa.ForeignKey(\u0027qos_policies.id\u0027,"},{"line_number":81,"context_line":"                                            ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":82,"context_line":"                              nullable\u003dFalse)"},{"line_number":83,"context_line":"    revises_on_change \u003d (\u0027qos_policy\u0027,)"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":62,"id":"5ff73747_757711d6","line":81,"range":{"start_line":80,"start_character":30,"end_line":81,"end_character":64},"updated":"2017-04-26 19:50:06.000000000","message":"as i said in the migration script this is inverted.","commit_id":"4625f53e00e203a948308c7d7313eb3bafda0c6d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"70ab71c4ca20009a718083c8cfb3c66f0a059065","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                       model_base.HasProjectPrimaryKeyIndex):"},{"line_number":78,"context_line":"    __tablename__ \u003d \u0027qos_policies_default\u0027"},{"line_number":79,"context_line":"    qos_policy_id \u003d sa.Column(sa.String(36),"},{"line_number":80,"context_line":"                              sa.ForeignKey(\u0027qos_policies.id\u0027,"},{"line_number":81,"context_line":"                                            ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":82,"context_line":"                              nullable\u003dFalse)"},{"line_number":83,"context_line":"    revises_on_change \u003d (\u0027qos_policy\u0027,)"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":62,"id":"5ff73747_2ac91625","line":81,"range":{"start_line":80,"start_character":30,"end_line":81,"end_character":64},"in_reply_to":"5ff73747_757711d6","updated":"2017-04-27 08:01:08.000000000","message":"ditto","commit_id":"4625f53e00e203a948308c7d7313eb3bafda0c6d"}],"neutron/extensions/qos_default.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e8bbe11e4808e2757436aa81cc09edd5c482426e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"ALIAS \u003d \u0027qos-default\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# The name of the extension."},{"line_number":26,"context_line":"NAME \u003d \u0027QoS default status\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# The description of the extension."},{"line_number":29,"context_line":"DESCRIPTION \u003d \u0027Expose QoS default status\u0027"}],"source_content_type":"text/x-python","patch_set":53,"id":"7ffa3b31_c5261ecf","line":26,"range":{"start_line":26,"start_character":20,"end_line":26,"end_character":26},"updated":"2017-04-20 03:36:56.000000000","message":"policy?","commit_id":"f12ac33a0c5632ddc957f1c02b7d56ab4c6553db"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"db56fda3d5083b56d7811b83266783494be4b8a9","unresolved":false,"context_lines":[{"line_number":23,"context_line":"ALIAS \u003d \u0027qos-default\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# The name of the extension."},{"line_number":26,"context_line":"NAME \u003d \u0027QoS default status\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# The description of the extension."},{"line_number":29,"context_line":"DESCRIPTION \u003d \u0027Expose QoS default status\u0027"}],"source_content_type":"text/x-python","patch_set":53,"id":"7ffa3b31_310744cd","line":26,"range":{"start_line":26,"start_character":20,"end_line":26,"end_character":26},"in_reply_to":"7ffa3b31_c5261ecf","updated":"2017-04-20 08:24:57.000000000","message":"Done","commit_id":"f12ac33a0c5632ddc957f1c02b7d56ab4c6553db"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e8bbe11e4808e2757436aa81cc09edd5c482426e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"NAME \u003d \u0027QoS default status\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# The description of the extension."},{"line_number":29,"context_line":"DESCRIPTION \u003d \u0027Expose QoS default status\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# A timestamp of when the extension was introduced."},{"line_number":32,"context_line":"TIMESTAMP \u003d \u00272017-041-06T10:00:00-00:00\u0027"}],"source_content_type":"text/x-python","patch_set":53,"id":"7ffa3b31_a52312bd","line":29,"range":{"start_line":29,"start_character":34,"end_line":29,"end_character":40},"updated":"2017-04-20 03:36:56.000000000","message":"ditto","commit_id":"f12ac33a0c5632ddc957f1c02b7d56ab4c6553db"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"db56fda3d5083b56d7811b83266783494be4b8a9","unresolved":false,"context_lines":[{"line_number":26,"context_line":"NAME \u003d \u0027QoS default status\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# The description of the extension."},{"line_number":29,"context_line":"DESCRIPTION \u003d \u0027Expose QoS default status\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# A timestamp of when the extension was introduced."},{"line_number":32,"context_line":"TIMESTAMP \u003d \u00272017-041-06T10:00:00-00:00\u0027"}],"source_content_type":"text/x-python","patch_set":53,"id":"7ffa3b31_f10c3ced","line":29,"range":{"start_line":29,"start_character":34,"end_line":29,"end_character":40},"in_reply_to":"7ffa3b31_a52312bd","updated":"2017-04-20 08:24:57.000000000","message":"Done","commit_id":"f12ac33a0c5632ddc957f1c02b7d56ab4c6553db"}],"neutron/objects/qos/policy.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4c26c878b63b5b7e8d521fe98c5bb0dcaa440dce","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \u0027name\u0027: obj_fields.StringField(),"},{"line_number":57,"context_line":"        \u0027shared\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":58,"context_line":"        \u0027rules\u0027: obj_fields.ListOfObjectsField(\u0027QosRule\u0027, subclasses\u003dTrue),"},{"line_number":59,"context_line":"        \u0027is_default\u0027: obj_fields.BooleanField(),"},{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    fields_no_update \u003d [\u0027id\u0027, \u0027project_id\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_fa471575","line":59,"updated":"2017-02-09 16:09:00.000000000","message":"\"default\u003dFalse\" as mentioned above","commit_id":"3757c60090e2b18e6e8cf06be15a8765c93df9f9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6e78f3d5efcb607209ef35b81985663e8e6bc25a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \u0027name\u0027: obj_fields.StringField(),"},{"line_number":57,"context_line":"        \u0027shared\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":58,"context_line":"        \u0027rules\u0027: obj_fields.ListOfObjectsField(\u0027QosRule\u0027, subclasses\u003dTrue),"},{"line_number":59,"context_line":"        \u0027is_default\u0027: obj_fields.BooleanField(),"},{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    fields_no_update \u003d [\u0027id\u0027, \u0027project_id\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_7eda3019","line":59,"in_reply_to":"1a430d35_fa471575","updated":"2017-02-09 19:15:08.000000000","message":"Yes! Thank you!","commit_id":"3757c60090e2b18e6e8cf06be15a8765c93df9f9"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bdad7891e6825555a28c82038fd710cd3f3525a6","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                                              port_id\u003dport_id)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def set_default(self):"},{"line_number":196,"context_line":"        if not self.get_default(self.obj_context, self.project_id):"},{"line_number":197,"context_line":"            qos_db_api.create_default_qos_policy(self.obj_context, self.id,"},{"line_number":198,"context_line":"                                                 self.project_id)"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":50,"id":"7ffa3b31_79414e39","line":196,"updated":"2017-04-19 13:14:32.000000000","message":"here You are checking if default policy is set but in https://review.openstack.org/#/c/428304/50/neutron/db/qos/api.py You are rising exception in case if default policy already exists. Maybe it would be enough to just catch this exception here - IMHO it should be one call to db less","commit_id":"6f3470c055de8586adf69aae7dac6e9eedd3d639"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"82ed85fa4d1d54a529fca7673068be1ba27bbc12","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                                              port_id\u003dport_id)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def set_default(self):"},{"line_number":196,"context_line":"        if not self.get_default(self.obj_context, self.project_id):"},{"line_number":197,"context_line":"            qos_db_api.create_default_qos_policy(self.obj_context, self.id,"},{"line_number":198,"context_line":"                                                 self.project_id)"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":50,"id":"7ffa3b31_d4794793","line":196,"in_reply_to":"7ffa3b31_79414e39","updated":"2017-04-19 13:32:33.000000000","message":"If I can avoid it, I always prefer to avoid programming cathing exceptions.\n\nI prefer to call \"qos_db_api.create_default_qos_policy\" only if needed. I don\u0027t want to catch the possible exception thrown, because that means there is a real problem.","commit_id":"6f3470c055de8586adf69aae7dac6e9eedd3d639"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bdad7891e6825555a28c82038fd710cd3f3525a6","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                                                 self.project_id)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def unset_default(self):"},{"line_number":201,"context_line":"        if self.get_default(self.obj_context, self.project_id) \u003d\u003d self.id:"},{"line_number":202,"context_line":"            qos_db_api.delete_default_qos_policy(self.obj_context, self.id,"},{"line_number":203,"context_line":"                                                 self.project_id)"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":50,"id":"7ffa3b31_394bc659","line":201,"updated":"2017-04-19 13:14:32.000000000","message":"see my comment above","commit_id":"6f3470c055de8586adf69aae7dac6e9eedd3d639"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"82ed85fa4d1d54a529fca7673068be1ba27bbc12","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                                                 self.project_id)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def unset_default(self):"},{"line_number":201,"context_line":"        if self.get_default(self.obj_context, self.project_id) \u003d\u003d self.id:"},{"line_number":202,"context_line":"            qos_db_api.delete_default_qos_policy(self.obj_context, self.id,"},{"line_number":203,"context_line":"                                                 self.project_id)"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":50,"id":"7ffa3b31_34b98b2d","line":201,"in_reply_to":"7ffa3b31_394bc659","updated":"2017-04-19 13:32:33.000000000","message":"The same. I understand your point of view, but I prefer to make this check rather than to catch and mask any exception.","commit_id":"6f3470c055de8586adf69aae7dac6e9eedd3d639"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"97bc9d6850cf519f07922d63dc1a1f71f62d83ff","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    def obj_load_attr(self, attrname):"},{"line_number":75,"context_line":"        if attrname \u003d\u003d \u0027project_id\u0027:"},{"line_number":76,"context_line":"            return super(QosPolicy, self).obj_load_attr(attrname)"},{"line_number":77,"context_line":"        elif attrname \u003d\u003d \u0027rules\u0027:"},{"line_number":78,"context_line":"            return self._reload_rules()"},{"line_number":79,"context_line":"        elif attrname \u003d\u003d \u0027is_default\u0027:"},{"line_number":80,"context_line":"            return self._reload_is_default()"}],"source_content_type":"text/x-python","patch_set":64,"id":"1f013ff3_67354b46","line":77,"updated":"2017-05-17 06:25:20.000000000","message":"This logic is changing from before. Now it\u0027s being run on every call where before it was only doing it if hasattr returned False. Why the change?","commit_id":"e71fec1f4ef76e133b31cd23d5e221bbcd3037c5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"086e7662344408d57f7a52acd13bc52b39fcbc28","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    def obj_load_attr(self, attrname):"},{"line_number":75,"context_line":"        if attrname \u003d\u003d \u0027project_id\u0027:"},{"line_number":76,"context_line":"            return super(QosPolicy, self).obj_load_attr(attrname)"},{"line_number":77,"context_line":"        elif attrname \u003d\u003d \u0027rules\u0027:"},{"line_number":78,"context_line":"            return self._reload_rules()"},{"line_number":79,"context_line":"        elif attrname \u003d\u003d \u0027is_default\u0027:"},{"line_number":80,"context_line":"            return self._reload_is_default()"}],"source_content_type":"text/x-python","patch_set":64,"id":"1f013ff3_7866062c","line":77,"in_reply_to":"1f013ff3_67354b46","updated":"2017-05-17 07:59:39.000000000","message":"I have change, inside this object, how \"obj_load_attr\" is used.\n\nNow we are using \"obj_load_attr\" with several \"attrname\" synthetic arguments (rules, is_default). That\u0027s why the previous logic doesn\u0027t work.\n\nI\u0027ll change it according to devref/objects_usage: if attrname is not (rules, is_default), I\u0027ll call the super method.","commit_id":"e71fec1f4ef76e133b31cd23d5e221bbcd3037c5"}],"neutron/services/qos/qos_plugin.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1f8e355a442546e2aa0de0ebc77fbdcb63032c28","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # We need to remove redundant keyword."},{"line_number":64,"context_line":"        # This cannot be done in other place of stacktrace, because neutron"},{"line_number":65,"context_line":"        # needs to be backward compatible."},{"line_number":66,"context_line":"        policies \u003d policy_object.QosPolicy.get_objects("},{"line_number":67,"context_line":"            context, is_default\u003dTrue,"},{"line_number":68,"context_line":"            project_id\u003dpolicy[\u0027policy\u0027][\u0027project_id\u0027])"},{"line_number":69,"context_line":"        if policies and policy[\u0027policy\u0027].get(\u0027is_default\u0027):"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_0bda5817","line":66,"updated":"2017-03-21 12:12:57.000000000","message":"nit: if only one policy can be default then this should return always maximum 1 policy so why naming it with plural name?","commit_id":"40d88fe8c3eef05bed5cefba8c3322cbb42d7729"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6c2f3c8da4e5713c8b43d59e55638bb9e4688962","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # We need to remove redundant keyword."},{"line_number":64,"context_line":"        # This cannot be done in other place of stacktrace, because neutron"},{"line_number":65,"context_line":"        # needs to be backward compatible."},{"line_number":66,"context_line":"        policies \u003d policy_object.QosPolicy.get_objects("},{"line_number":67,"context_line":"            context, is_default\u003dTrue,"},{"line_number":68,"context_line":"            project_id\u003dpolicy[\u0027policy\u0027][\u0027project_id\u0027])"},{"line_number":69,"context_line":"        if policies and policy[\u0027policy\u0027].get(\u0027is_default\u0027):"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_5a608fa5","line":66,"in_reply_to":"1a1ced50_0bda5817","updated":"2017-03-21 16:40:07.000000000","message":"You are right. I used the plurar because \"get_objects\" return a list, independently of the number of objects","commit_id":"40d88fe8c3eef05bed5cefba8c3322cbb42d7729"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1f8e355a442546e2aa0de0ebc77fbdcb63032c28","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            project_id\u003dpolicy[\u0027policy\u0027][\u0027project_id\u0027])"},{"line_number":69,"context_line":"        if policies and policy[\u0027policy\u0027].get(\u0027is_default\u0027):"},{"line_number":70,"context_line":"            raise n_exc.QosDefaultPolicyFound(policy_id\u003dpolicies[0].id)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        policy[\u0027policy\u0027].pop(\u0027tenant_id\u0027, None)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        policy_obj \u003d policy_object.QosPolicy(context, **policy[\u0027policy\u0027])"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_8bae487f","line":71,"updated":"2017-03-21 12:12:57.000000000","message":"nit: please move it below L72 or move pop of tenant_id (L72) above Your code because now comment is not proper :)","commit_id":"40d88fe8c3eef05bed5cefba8c3322cbb42d7729"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6c2f3c8da4e5713c8b43d59e55638bb9e4688962","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            project_id\u003dpolicy[\u0027policy\u0027][\u0027project_id\u0027])"},{"line_number":69,"context_line":"        if policies and policy[\u0027policy\u0027].get(\u0027is_default\u0027):"},{"line_number":70,"context_line":"            raise n_exc.QosDefaultPolicyFound(policy_id\u003dpolicies[0].id)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        policy[\u0027policy\u0027].pop(\u0027tenant_id\u0027, None)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        policy_obj \u003d policy_object.QosPolicy(context, **policy[\u0027policy\u0027])"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_c46bc5ef","line":71,"in_reply_to":"1a1ced50_8bae487f","updated":"2017-03-21 16:40:07.000000000","message":"Ups...","commit_id":"40d88fe8c3eef05bed5cefba8c3322cbb42d7729"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1f8e355a442546e2aa0de0ebc77fbdcb63032c28","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        \"\"\""},{"line_number":97,"context_line":"        policy_obj \u003d policy_object.QosPolicy.get_object(context, id\u003dpolicy_id)"},{"line_number":98,"context_line":"        policies \u003d policy_object.QosPolicy.get_objects("},{"line_number":99,"context_line":"            context, is_default\u003dTrue, project_id\u003dpolicy_obj.project_id)"},{"line_number":100,"context_line":"        if (policies and policy[\u0027policy\u0027].get(\u0027is_default\u0027) and"},{"line_number":101,"context_line":"                policy_obj.id !\u003d policies[0].id):"},{"line_number":102,"context_line":"            raise n_exc.QosDefaultPolicyFound(policy_id\u003dpolicies[0].id)"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_0bf17895","line":99,"updated":"2017-03-21 12:12:57.000000000","message":"same plural name here","commit_id":"40d88fe8c3eef05bed5cefba8c3322cbb42d7729"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6c2f3c8da4e5713c8b43d59e55638bb9e4688962","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        \"\"\""},{"line_number":97,"context_line":"        policy_obj \u003d policy_object.QosPolicy.get_object(context, id\u003dpolicy_id)"},{"line_number":98,"context_line":"        policies \u003d policy_object.QosPolicy.get_objects("},{"line_number":99,"context_line":"            context, is_default\u003dTrue, project_id\u003dpolicy_obj.project_id)"},{"line_number":100,"context_line":"        if (policies and policy[\u0027policy\u0027].get(\u0027is_default\u0027) and"},{"line_number":101,"context_line":"                policy_obj.id !\u003d policies[0].id):"},{"line_number":102,"context_line":"            raise n_exc.QosDefaultPolicyFound(policy_id\u003dpolicies[0].id)"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_9a5687cc","line":99,"in_reply_to":"1a1ced50_0bf17895","updated":"2017-03-21 16:40:07.000000000","message":"Done","commit_id":"40d88fe8c3eef05bed5cefba8c3322cbb42d7729"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"3cbbaf9887260b213b65732e59603973747610c9","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        # needs to be backward compatible."},{"line_number":66,"context_line":"        policy[\u0027policy\u0027].pop(\u0027tenant_id\u0027, None)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        default_policy \u003d policy_object.QosPolicy.get_objects("},{"line_number":69,"context_line":"            context, is_default\u003dTrue,"},{"line_number":70,"context_line":"            project_id\u003dpolicy[\u0027policy\u0027][\u0027project_id\u0027])"},{"line_number":71,"context_line":"        if default_policy and policy[\u0027policy\u0027].get(\u0027is_default\u0027):"}],"source_content_type":"text/x-python","patch_set":46,"id":"bff0334d_9a9a735f","line":68,"range":{"start_line":68,"start_character":49,"end_line":68,"end_character":60},"updated":"2017-04-11 21:20:37.000000000","message":"get_object","commit_id":"a89de20b06bd480d6a0b5cc3f5ce94459f891edf"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"859ae6b3e07076be108f9efd986947cf7ecd3939","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        # needs to be backward compatible."},{"line_number":66,"context_line":"        policy[\u0027policy\u0027].pop(\u0027tenant_id\u0027, None)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        default_policy \u003d policy_object.QosPolicy.get_objects("},{"line_number":69,"context_line":"            context, is_default\u003dTrue,"},{"line_number":70,"context_line":"            project_id\u003dpolicy[\u0027policy\u0027][\u0027project_id\u0027])"},{"line_number":71,"context_line":"        if default_policy and policy[\u0027policy\u0027].get(\u0027is_default\u0027):"}],"source_content_type":"text/x-python","patch_set":46,"id":"bff0334d_4bac0a9e","line":68,"range":{"start_line":68,"start_character":49,"end_line":68,"end_character":60},"in_reply_to":"bff0334d_4ddf8568","updated":"2017-04-12 11:33:18.000000000","message":"Actually with get_object I need the primary key (id) and I don\u0027t have it","commit_id":"a89de20b06bd480d6a0b5cc3f5ce94459f891edf"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"111136b929fba42ab2d67b0d8868b3277c21ee81","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        # needs to be backward compatible."},{"line_number":66,"context_line":"        policy[\u0027policy\u0027].pop(\u0027tenant_id\u0027, None)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        default_policy \u003d policy_object.QosPolicy.get_objects("},{"line_number":69,"context_line":"            context, is_default\u003dTrue,"},{"line_number":70,"context_line":"            project_id\u003dpolicy[\u0027policy\u0027][\u0027project_id\u0027])"},{"line_number":71,"context_line":"        if default_policy and policy[\u0027policy\u0027].get(\u0027is_default\u0027):"}],"source_content_type":"text/x-python","patch_set":46,"id":"bff0334d_4ddf8568","line":68,"range":{"start_line":68,"start_character":49,"end_line":68,"end_character":60},"in_reply_to":"bff0334d_9a9a735f","updated":"2017-04-12 10:04:54.000000000","message":"Done","commit_id":"a89de20b06bd480d6a0b5cc3f5ce94459f891edf"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"29e4369929041b62db8556757feff4e73dc444a4","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        \"\"\""},{"line_number":98,"context_line":"        policy_obj \u003d policy_object.QosPolicy.get_object(context, id\u003dpolicy_id)"},{"line_number":99,"context_line":"        default_policy \u003d policy_object.QosPolicy.get_objects("},{"line_number":100,"context_line":"            context, is_default\u003dTrue, project_id\u003dpolicy_obj.project_id)"},{"line_number":101,"context_line":"        if (default_policy and policy[\u0027policy\u0027].get(\u0027is_default\u0027) and"},{"line_number":102,"context_line":"                policy_obj.id !\u003d default_policy[0].id):"},{"line_number":103,"context_line":"            raise n_exc.QoSDefaultPolicyAlreadyExists("}],"source_content_type":"text/x-python","patch_set":47,"id":"7ffa3b31_d171b2e2","line":100,"updated":"2017-04-16 09:11:37.000000000","message":"This is racey. Two threads can run this same check and then both create defaults. This constraint should be modeled directly in the DB.\n\nInstead of a column on the policy table, add a new DefaultQoSPolicy table with two columns: project_id and policy_id. Make project_id primary key and then we are guaranteed to never have duplicates.","commit_id":"d454e13d6c0566d2a869682fcfa40904a31e2806"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b7ef86a3eb729988076dcf18eac8afe752b2c826","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        \"\"\""},{"line_number":98,"context_line":"        policy_obj \u003d policy_object.QosPolicy.get_object(context, id\u003dpolicy_id)"},{"line_number":99,"context_line":"        default_policy \u003d policy_object.QosPolicy.get_objects("},{"line_number":100,"context_line":"            context, is_default\u003dTrue, project_id\u003dpolicy_obj.project_id)"},{"line_number":101,"context_line":"        if (default_policy and policy[\u0027policy\u0027].get(\u0027is_default\u0027) and"},{"line_number":102,"context_line":"                policy_obj.id !\u003d default_policy[0].id):"},{"line_number":103,"context_line":"            raise n_exc.QoSDefaultPolicyAlreadyExists("}],"source_content_type":"text/x-python","patch_set":47,"id":"7ffa3b31_2c64d4e3","line":100,"in_reply_to":"7ffa3b31_d171b2e2","updated":"2017-04-18 08:07:00.000000000","message":"That\u0027s right, we must enforce this restriction in the backend.","commit_id":"d454e13d6c0566d2a869682fcfa40904a31e2806"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e8bbe11e4808e2757436aa81cc09edd5c482426e","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            context, project_id\u003dpolicy[\u0027policy\u0027][\u0027project_id\u0027])"},{"line_number":163,"context_line":"        if default_policy_id and policy[\u0027policy\u0027].get(\u0027is_default\u0027):"},{"line_number":164,"context_line":"            raise n_exc.QoSPolicyDefaultAlreadyExists("},{"line_number":165,"context_line":"                project_id\u003dpolicy[\u0027policy\u0027][\u0027project_id\u0027])"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        policy_obj \u003d policy_object.QosPolicy(context, **policy[\u0027policy\u0027])"},{"line_number":168,"context_line":"        policy_obj.create()"}],"source_content_type":"text/x-python","patch_set":53,"id":"7ffa3b31_d05c9eee","line":165,"updated":"2017-04-20 03:36:56.000000000","message":"why do you need to check this explicitly?\ndb primary key constraints isn\u0027t suffice?\n\nalso, i guess this can be hidden in object layer.","commit_id":"f12ac33a0c5632ddc957f1c02b7d56ab4c6553db"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"db56fda3d5083b56d7811b83266783494be4b8a9","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            context, project_id\u003dpolicy[\u0027policy\u0027][\u0027project_id\u0027])"},{"line_number":163,"context_line":"        if default_policy_id and policy[\u0027policy\u0027].get(\u0027is_default\u0027):"},{"line_number":164,"context_line":"            raise n_exc.QoSPolicyDefaultAlreadyExists("},{"line_number":165,"context_line":"                project_id\u003dpolicy[\u0027policy\u0027][\u0027project_id\u0027])"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        policy_obj \u003d policy_object.QosPolicy(context, **policy[\u0027policy\u0027])"},{"line_number":168,"context_line":"        policy_obj.create()"}],"source_content_type":"text/x-python","patch_set":53,"id":"7ffa3b31_51d530e4","line":165,"in_reply_to":"7ffa3b31_d05c9eee","updated":"2017-04-20 08:24:57.000000000","message":"Done","commit_id":"f12ac33a0c5632ddc957f1c02b7d56ab4c6553db"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e8bbe11e4808e2757436aa81cc09edd5c482426e","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        if (default_policy_id and policy[\u0027policy\u0027].get(\u0027is_default\u0027) and"},{"line_number":191,"context_line":"                policy_obj.id !\u003d default_policy_id):"},{"line_number":192,"context_line":"            raise n_exc.QoSPolicyDefaultAlreadyExists("},{"line_number":193,"context_line":"                project_id\u003dpolicy_obj.project_id)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        policy_data \u003d policy[\u0027policy\u0027]"},{"line_number":196,"context_line":"        policy_obj \u003d policy_object.QosPolicy(context, id\u003dpolicy_id)"}],"source_content_type":"text/x-python","patch_set":53,"id":"7ffa3b31_9072967a","line":193,"updated":"2017-04-20 03:36:56.000000000","message":"ditto","commit_id":"f12ac33a0c5632ddc957f1c02b7d56ab4c6553db"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"db56fda3d5083b56d7811b83266783494be4b8a9","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        if (default_policy_id and policy[\u0027policy\u0027].get(\u0027is_default\u0027) and"},{"line_number":191,"context_line":"                policy_obj.id !\u003d default_policy_id):"},{"line_number":192,"context_line":"            raise n_exc.QoSPolicyDefaultAlreadyExists("},{"line_number":193,"context_line":"                project_id\u003dpolicy_obj.project_id)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        policy_data \u003d policy[\u0027policy\u0027]"},{"line_number":196,"context_line":"        policy_obj \u003d policy_object.QosPolicy(context, id\u003dpolicy_id)"}],"source_content_type":"text/x-python","patch_set":53,"id":"7ffa3b31_31086490","line":193,"in_reply_to":"7ffa3b31_9072967a","updated":"2017-04-20 08:24:57.000000000","message":"Done","commit_id":"f12ac33a0c5632ddc957f1c02b7d56ab4c6553db"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e8bbe11e4808e2757436aa81cc09edd5c482426e","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        policy_obj.update_fields(policy_data, reset_changes\u003dTrue)"},{"line_number":198,"context_line":"        policy_obj.update()"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        if policy[\u0027policy\u0027].get(\u0027is_default\u0027):"},{"line_number":201,"context_line":"            policy_obj.set_default()"},{"line_number":202,"context_line":"        else:"},{"line_number":203,"context_line":"            policy_obj.unset_default()"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        self.driver_manager.call(\u0027update_policy\u0027, context, policy_obj)"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-python","patch_set":53,"id":"7ffa3b31_d0a7fe0a","line":203,"range":{"start_line":200,"start_character":0,"end_line":203,"end_character":38},"updated":"2017-04-20 03:36:56.000000000","message":"i guess these should be hidden in object layer,\nprobably by overriding update() method.","commit_id":"f12ac33a0c5632ddc957f1c02b7d56ab4c6553db"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"db56fda3d5083b56d7811b83266783494be4b8a9","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        policy_obj.update_fields(policy_data, reset_changes\u003dTrue)"},{"line_number":198,"context_line":"        policy_obj.update()"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        if policy[\u0027policy\u0027].get(\u0027is_default\u0027):"},{"line_number":201,"context_line":"            policy_obj.set_default()"},{"line_number":202,"context_line":"        else:"},{"line_number":203,"context_line":"            policy_obj.unset_default()"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        self.driver_manager.call(\u0027update_policy\u0027, context, policy_obj)"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-python","patch_set":53,"id":"7ffa3b31_e6fb5d76","line":203,"range":{"start_line":200,"start_character":0,"end_line":203,"end_character":38},"in_reply_to":"7ffa3b31_d0a7fe0a","updated":"2017-04-20 08:24:57.000000000","message":"Done","commit_id":"f12ac33a0c5632ddc957f1c02b7d56ab4c6553db"}],"neutron/tests/fullstack/resources/client.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1a53cacbdfc89d69e845d2365dec50f3ce2cebbe","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        return router_interface_info"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def create_qos_policy(self, tenant_id, name, description, shared,"},{"line_number":136,"context_line":"                          is_default):"},{"line_number":137,"context_line":"        policy \u003d self.client.create_qos_policy("},{"line_number":138,"context_line":"            body\u003d{\u0027policy\u0027: {\u0027name\u0027: name,"},{"line_number":139,"context_line":"                             \u0027description\u0027: description,"}],"source_content_type":"text/x-python","patch_set":23,"id":"3a1ff146_faf5eaca","line":136,"range":{"start_line":136,"start_character":26,"end_line":136,"end_character":36},"updated":"2017-03-16 15:49:16.000000000","message":"is_default\u003dFalse ??","commit_id":"7bdccde8d167bab0aa4341e9e5b69b73f2173116"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"63471bcbc8804fef04d10954bec26bed00adb490","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        return router_interface_info"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def create_qos_policy(self, tenant_id, name, description, shared,"},{"line_number":136,"context_line":"                          is_default):"},{"line_number":137,"context_line":"        policy \u003d self.client.create_qos_policy("},{"line_number":138,"context_line":"            body\u003d{\u0027policy\u0027: {\u0027name\u0027: name,"},{"line_number":139,"context_line":"                             \u0027description\u0027: description,"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a1ced50_23cf7880","line":136,"range":{"start_line":136,"start_character":26,"end_line":136,"end_character":36},"in_reply_to":"3a1ff146_faf5eaca","updated":"2017-03-20 08:57:55.000000000","message":"Actually this function is used only once, in tests.fullstack.test_qos. This function call is already modified.\n\nIs the same a \"shared\" parameter.","commit_id":"7bdccde8d167bab0aa4341e9e5b69b73f2173116"}],"neutron/tests/fullstack/test_qos.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"358de075b2d951f6721b950574defba0736d9986","unresolved":false,"context_lines":[{"line_number":337,"context_line":"        qos_policy_1 \u003d self._create_qos_policy(project_id, True)"},{"line_number":338,"context_line":"        self.assertTrue(qos_policy_1[\u0027is_default\u0027])"},{"line_number":339,"context_line":"        qos_policy_2 \u003d self._create_qos_policy(project_id, False)"},{"line_number":340,"context_line":"        self.assertTrue(qos_policy_2[\u0027is_default\u0027])"},{"line_number":341,"context_line":"        self.assertRaises(exceptions.Conflict,"},{"line_number":342,"context_line":"                          self._update_qos_policy, qos_policy_2[\u0027id\u0027], True)"}],"source_content_type":"text/x-python","patch_set":43,"id":"ffe62b97_4938723c","line":340,"updated":"2017-03-30 11:54:22.000000000","message":"This is failing in the fullstack test and from the context it looks like you want an assertFalse instead?","commit_id":"d30cdfaa6e092766962f07e5f33f36edf7ca2f16"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4ba78060327b08937f14c8f0ca0ad28eb351212d","unresolved":false,"context_lines":[{"line_number":337,"context_line":"        qos_policy_1 \u003d self._create_qos_policy(project_id, True)"},{"line_number":338,"context_line":"        self.assertTrue(qos_policy_1[\u0027is_default\u0027])"},{"line_number":339,"context_line":"        qos_policy_2 \u003d self._create_qos_policy(project_id, False)"},{"line_number":340,"context_line":"        self.assertTrue(qos_policy_2[\u0027is_default\u0027])"},{"line_number":341,"context_line":"        self.assertRaises(exceptions.Conflict,"},{"line_number":342,"context_line":"                          self._update_qos_policy, qos_policy_2[\u0027id\u0027], True)"}],"source_content_type":"text/x-python","patch_set":43,"id":"ffe62b97_d8544a24","line":340,"in_reply_to":"ffe62b97_4938723c","updated":"2017-03-30 13:28:36.000000000","message":"You are correct! Good catch.\n\nSorry, this is the problem when the gate is in \"no-voting\".","commit_id":"d30cdfaa6e092766962f07e5f33f36edf7ca2f16"}],"neutron/tests/tempest/api/base.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b895c9fc0fcdbcd9ac8a0478506c1a8d00e8f19","unresolved":false,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    @classmethod"},{"line_number":367,"context_line":"    def create_qos_policy(cls, name, description\u003dNone, shared\u003dFalse,"},{"line_number":368,"context_line":"                          project_id\u003dNone):"},{"line_number":369,"context_line":"        \"\"\"Wrapper utility that returns a test QoS policy.\"\"\""},{"line_number":370,"context_line":"        body \u003d cls.admin_client.create_qos_policy("},{"line_number":371,"context_line":"            name, description, shared, project_id)"}],"source_content_type":"text/x-python","patch_set":63,"id":"3f044301_9d090ddf","line":368,"updated":"2017-05-04 11:04:28.000000000","message":"nit: IMHO this is not related to this patch :)","commit_id":"42ae488360800ba856b4a84b5350b1481b05736b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0fa10f797ebeeac30b232bf1bbdfd36e8552b3dc","unresolved":false,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    @classmethod"},{"line_number":367,"context_line":"    def create_qos_policy(cls, name, description\u003dNone, shared\u003dFalse,"},{"line_number":368,"context_line":"                          project_id\u003dNone):"},{"line_number":369,"context_line":"        \"\"\"Wrapper utility that returns a test QoS policy.\"\"\""},{"line_number":370,"context_line":"        body \u003d cls.admin_client.create_qos_policy("},{"line_number":371,"context_line":"            name, description, shared, project_id)"}],"source_content_type":"text/x-python","patch_set":63,"id":"1f013ff3_75d66852","line":368,"updated":"2017-05-12 19:27:02.000000000","message":"please split the rename into a separate parent patch. It makes it easier to review and reduces merge conflict risk if we need to revert the actual change.","commit_id":"42ae488360800ba856b4a84b5350b1481b05736b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6e202ba570528264a611da36df013e303c24b7ec","unresolved":false,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    @classmethod"},{"line_number":367,"context_line":"    def create_qos_policy(cls, name, description\u003dNone, shared\u003dFalse,"},{"line_number":368,"context_line":"                          project_id\u003dNone):"},{"line_number":369,"context_line":"        \"\"\"Wrapper utility that returns a test QoS policy.\"\"\""},{"line_number":370,"context_line":"        body \u003d cls.admin_client.create_qos_policy("},{"line_number":371,"context_line":"            name, description, shared, project_id)"}],"source_content_type":"text/x-python","patch_set":63,"id":"1f013ff3_07924cf7","line":368,"in_reply_to":"1f013ff3_75d66852","updated":"2017-05-15 10:31:36.000000000","message":"Done","commit_id":"42ae488360800ba856b4a84b5350b1481b05736b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"644536b07f1c4c6a3e8148d0dd0fbacfc66e7538","unresolved":false,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    @classmethod"},{"line_number":367,"context_line":"    def create_qos_policy(cls, name, description\u003dNone, shared\u003dFalse,"},{"line_number":368,"context_line":"                          project_id\u003dNone):"},{"line_number":369,"context_line":"        \"\"\"Wrapper utility that returns a test QoS policy.\"\"\""},{"line_number":370,"context_line":"        body \u003d cls.admin_client.create_qos_policy("},{"line_number":371,"context_line":"            name, description, shared, project_id)"}],"source_content_type":"text/x-python","patch_set":63,"id":"3f044301_880d4d92","line":368,"in_reply_to":"3f044301_9d090ddf","updated":"2017-05-04 11:41:56.000000000","message":"I changed this input parameter because it was confusing. The current parameter is not tenant_id anymore and because it\u0027s important for this feature to know in which project are you creating the qos policy, I decided to change it.","commit_id":"42ae488360800ba856b4a84b5350b1481b05736b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b895c9fc0fcdbcd9ac8a0478506c1a8d00e8f19","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                          project_id\u003dNone):"},{"line_number":369,"context_line":"        \"\"\"Wrapper utility that returns a test QoS policy.\"\"\""},{"line_number":370,"context_line":"        body \u003d cls.admin_client.create_qos_policy("},{"line_number":371,"context_line":"            name, description, shared, project_id)"},{"line_number":372,"context_line":"        qos_policy \u003d body[\u0027policy\u0027]"},{"line_number":373,"context_line":"        cls.qos_policies.append(qos_policy)"},{"line_number":374,"context_line":"        return qos_policy"}],"source_content_type":"text/x-python","patch_set":63,"id":"3f044301_7d0e41e6","line":371,"updated":"2017-05-04 11:04:28.000000000","message":"same here","commit_id":"42ae488360800ba856b4a84b5350b1481b05736b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6e202ba570528264a611da36df013e303c24b7ec","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                          project_id\u003dNone):"},{"line_number":369,"context_line":"        \"\"\"Wrapper utility that returns a test QoS policy.\"\"\""},{"line_number":370,"context_line":"        body \u003d cls.admin_client.create_qos_policy("},{"line_number":371,"context_line":"            name, description, shared, project_id)"},{"line_number":372,"context_line":"        qos_policy \u003d body[\u0027policy\u0027]"},{"line_number":373,"context_line":"        cls.qos_policies.append(qos_policy)"},{"line_number":374,"context_line":"        return qos_policy"}],"source_content_type":"text/x-python","patch_set":63,"id":"1f013ff3_8f88ae1f","line":371,"in_reply_to":"3f044301_7d0e41e6","updated":"2017-05-15 10:31:36.000000000","message":"Done","commit_id":"42ae488360800ba856b4a84b5350b1481b05736b"}],"neutron/tests/tempest/api/test_qos.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b895c9fc0fcdbcd9ac8a0478506c1a8d00e8f19","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":100,"context_line":"                                        description\u003d\u0027\u0027,"},{"line_number":101,"context_line":"                                        shared\u003dFalse,"},{"line_number":102,"context_line":"                                        project_id\u003dself.client.tenant_id)"},{"line_number":103,"context_line":"        self.assertRaises("},{"line_number":104,"context_line":"            exceptions.Forbidden,"},{"line_number":105,"context_line":"            self.client.update_qos_policy,"}],"source_content_type":"text/x-python","patch_set":63,"id":"3f044301_1df5fdcb","line":102,"updated":"2017-05-04 11:04:28.000000000","message":"nit: not related to this change","commit_id":"42ae488360800ba856b4a84b5350b1481b05736b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6e202ba570528264a611da36df013e303c24b7ec","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":100,"context_line":"                                        description\u003d\u0027\u0027,"},{"line_number":101,"context_line":"                                        shared\u003dFalse,"},{"line_number":102,"context_line":"                                        project_id\u003dself.client.tenant_id)"},{"line_number":103,"context_line":"        self.assertRaises("},{"line_number":104,"context_line":"            exceptions.Forbidden,"},{"line_number":105,"context_line":"            self.client.update_qos_policy,"}],"source_content_type":"text/x-python","patch_set":63,"id":"1f013ff3_6f7d621b","line":102,"in_reply_to":"3f044301_1df5fdcb","updated":"2017-05-15 10:31:36.000000000","message":"Done","commit_id":"42ae488360800ba856b4a84b5350b1481b05736b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b895c9fc0fcdbcd9ac8a0478506c1a8d00e8f19","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":111,"context_line":"                                        description\u003d\u0027\u0027,"},{"line_number":112,"context_line":"                                        shared\u003dFalse,"},{"line_number":113,"context_line":"                                        project_id\u003dself.admin_client.tenant_id)"},{"line_number":114,"context_line":"        self.assertRaises("},{"line_number":115,"context_line":"            exceptions.NotFound,"},{"line_number":116,"context_line":"            self.client.update_qos_policy,"}],"source_content_type":"text/x-python","patch_set":63,"id":"3f044301_fd0131b1","line":113,"updated":"2017-05-04 11:04:28.000000000","message":"nit: not related to this change","commit_id":"42ae488360800ba856b4a84b5350b1481b05736b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6e202ba570528264a611da36df013e303c24b7ec","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":111,"context_line":"                                        description\u003d\u0027\u0027,"},{"line_number":112,"context_line":"                                        shared\u003dFalse,"},{"line_number":113,"context_line":"                                        project_id\u003dself.admin_client.tenant_id)"},{"line_number":114,"context_line":"        self.assertRaises("},{"line_number":115,"context_line":"            exceptions.NotFound,"},{"line_number":116,"context_line":"            self.client.update_qos_policy,"}],"source_content_type":"text/x-python","patch_set":63,"id":"1f013ff3_ef8e1226","line":113,"in_reply_to":"3f044301_fd0131b1","updated":"2017-05-15 10:31:36.000000000","message":"Done","commit_id":"42ae488360800ba856b4a84b5350b1481b05736b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b895c9fc0fcdbcd9ac8a0478506c1a8d00e8f19","unresolved":false,"context_lines":[{"line_number":353,"context_line":"            name\u003d\u0027test-policy-shared\u0027,"},{"line_number":354,"context_line":"            description\u003d\u0027shared policy\u0027,"},{"line_number":355,"context_line":"            shared\u003dTrue,"},{"line_number":356,"context_line":"            project_id\u003dself.admin_client.tenant_id)"},{"line_number":357,"context_line":"        obtained_policy \u003d self.client.show_qos_policy(policy[\u0027id\u0027])[\u0027policy\u0027]"},{"line_number":358,"context_line":"        self.assertEqual(obtained_policy, policy)"},{"line_number":359,"context_line":""}],"source_content_type":"text/x-python","patch_set":63,"id":"3f044301_bd2de947","line":356,"updated":"2017-05-04 11:04:28.000000000","message":"nit: not related to this change","commit_id":"42ae488360800ba856b4a84b5350b1481b05736b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6e202ba570528264a611da36df013e303c24b7ec","unresolved":false,"context_lines":[{"line_number":353,"context_line":"            name\u003d\u0027test-policy-shared\u0027,"},{"line_number":354,"context_line":"            description\u003d\u0027shared policy\u0027,"},{"line_number":355,"context_line":"            shared\u003dTrue,"},{"line_number":356,"context_line":"            project_id\u003dself.admin_client.tenant_id)"},{"line_number":357,"context_line":"        obtained_policy \u003d self.client.show_qos_policy(policy[\u0027id\u0027])[\u0027policy\u0027]"},{"line_number":358,"context_line":"        self.assertEqual(obtained_policy, policy)"},{"line_number":359,"context_line":""}],"source_content_type":"text/x-python","patch_set":63,"id":"1f013ff3_af980a6a","line":356,"in_reply_to":"3f044301_bd2de947","updated":"2017-05-15 10:31:36.000000000","message":"Done","commit_id":"42ae488360800ba856b4a84b5350b1481b05736b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b895c9fc0fcdbcd9ac8a0478506c1a8d00e8f19","unresolved":false,"context_lines":[{"line_number":498,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":499,"context_line":"                                        description\u003d\u0027test policy\u0027,"},{"line_number":500,"context_line":"                                        shared\u003dFalse,"},{"line_number":501,"context_line":"                                        project_id\u003dself.client.tenant_id)"},{"line_number":502,"context_line":"        rule \u003d self.create_qos_bandwidth_limit_rule(policy_id\u003dpolicy[\u0027id\u0027],"},{"line_number":503,"context_line":"                                                    max_kbps\u003d1,"},{"line_number":504,"context_line":"                                                    max_burst_kbps\u003d1,"}],"source_content_type":"text/x-python","patch_set":63,"id":"3f044301_5d2ca546","line":501,"updated":"2017-05-04 11:04:28.000000000","message":"nit: not related to this change","commit_id":"42ae488360800ba856b4a84b5350b1481b05736b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6e202ba570528264a611da36df013e303c24b7ec","unresolved":false,"context_lines":[{"line_number":498,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":499,"context_line":"                                        description\u003d\u0027test policy\u0027,"},{"line_number":500,"context_line":"                                        shared\u003dFalse,"},{"line_number":501,"context_line":"                                        project_id\u003dself.client.tenant_id)"},{"line_number":502,"context_line":"        rule \u003d self.create_qos_bandwidth_limit_rule(policy_id\u003dpolicy[\u0027id\u0027],"},{"line_number":503,"context_line":"                                                    max_kbps\u003d1,"},{"line_number":504,"context_line":"                                                    max_burst_kbps\u003d1,"}],"source_content_type":"text/x-python","patch_set":63,"id":"1f013ff3_6fa2029d","line":501,"in_reply_to":"3f044301_5d2ca546","updated":"2017-05-15 10:31:36.000000000","message":"Done","commit_id":"42ae488360800ba856b4a84b5350b1481b05736b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b895c9fc0fcdbcd9ac8a0478506c1a8d00e8f19","unresolved":false,"context_lines":[{"line_number":513,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":514,"context_line":"                                        description\u003d\u0027test policy\u0027,"},{"line_number":515,"context_line":"                                        shared\u003dFalse,"},{"line_number":516,"context_line":"                                        project_id\u003dself.admin_client.tenant_id)"},{"line_number":517,"context_line":"        rule \u003d self.create_qos_bandwidth_limit_rule(policy_id\u003dpolicy[\u0027id\u0027],"},{"line_number":518,"context_line":"                                                    max_kbps\u003d1,"},{"line_number":519,"context_line":"                                                    max_burst_kbps\u003d1,"}],"source_content_type":"text/x-python","patch_set":63,"id":"3f044301_3d21d94e","line":516,"updated":"2017-05-04 11:04:28.000000000","message":"nit: not related to this change","commit_id":"42ae488360800ba856b4a84b5350b1481b05736b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6e202ba570528264a611da36df013e303c24b7ec","unresolved":false,"context_lines":[{"line_number":513,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":514,"context_line":"                                        description\u003d\u0027test policy\u0027,"},{"line_number":515,"context_line":"                                        shared\u003dFalse,"},{"line_number":516,"context_line":"                                        project_id\u003dself.admin_client.tenant_id)"},{"line_number":517,"context_line":"        rule \u003d self.create_qos_bandwidth_limit_rule(policy_id\u003dpolicy[\u0027id\u0027],"},{"line_number":518,"context_line":"                                                    max_kbps\u003d1,"},{"line_number":519,"context_line":"                                                    max_burst_kbps\u003d1,"}],"source_content_type":"text/x-python","patch_set":63,"id":"1f013ff3_4f9f4650","line":516,"in_reply_to":"3f044301_3d21d94e","updated":"2017-05-15 10:31:36.000000000","message":"Done","commit_id":"42ae488360800ba856b4a84b5350b1481b05736b"}],"neutron/tests/unit/core_extensions/test_qos.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b895c9fc0fcdbcd9ac8a0478506c1a8d00e8f19","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def test_process_fields_create_network(self):"},{"line_number":256,"context_line":"        with self._mock_plugin_loaded(True):"},{"line_number":257,"context_line":"            qos_policy_id \u003d mock.Mock()"},{"line_number":258,"context_line":"            network_id \u003d mock.Mock()"},{"line_number":259,"context_line":"            actual_network \u003d {\u0027id\u0027: network_id,"},{"line_number":260,"context_line":"                              qos_consts.QOS_POLICY_ID: qos_policy_id}"}],"source_content_type":"text/x-python","patch_set":63,"id":"3f044301_1dccdd87","line":257,"updated":"2017-05-04 11:04:28.000000000","message":"do You really use mock object here? isn\u0027t some generated uuid enough?","commit_id":"42ae488360800ba856b4a84b5350b1481b05736b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"644536b07f1c4c6a3e8148d0dd0fbacfc66e7538","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def test_process_fields_create_network(self):"},{"line_number":256,"context_line":"        with self._mock_plugin_loaded(True):"},{"line_number":257,"context_line":"            qos_policy_id \u003d mock.Mock()"},{"line_number":258,"context_line":"            network_id \u003d mock.Mock()"},{"line_number":259,"context_line":"            actual_network \u003d {\u0027id\u0027: network_id,"},{"line_number":260,"context_line":"                              qos_consts.QOS_POLICY_ID: qos_policy_id}"}],"source_content_type":"text/x-python","patch_set":63,"id":"3f044301_6887a1d9","line":257,"in_reply_to":"3f044301_1dccdd87","updated":"2017-05-04 11:41:56.000000000","message":"Just for consistency, I\u0027m using the same code used in previous test cases. For these tests, it doesn\u0027t matter which value is assigned to qos_policy_id or network_id.\n\nThe same in the next comments.","commit_id":"42ae488360800ba856b4a84b5350b1481b05736b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b895c9fc0fcdbcd9ac8a0478506c1a8d00e8f19","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    def test_process_fields_create_network(self):"},{"line_number":256,"context_line":"        with self._mock_plugin_loaded(True):"},{"line_number":257,"context_line":"            qos_policy_id \u003d mock.Mock()"},{"line_number":258,"context_line":"            network_id \u003d mock.Mock()"},{"line_number":259,"context_line":"            actual_network \u003d {\u0027id\u0027: network_id,"},{"line_number":260,"context_line":"                              qos_consts.QOS_POLICY_ID: qos_policy_id}"},{"line_number":261,"context_line":"            self.policy_m.get_network_policy \u003d mock.Mock("}],"source_content_type":"text/x-python","patch_set":63,"id":"3f044301_fdc81175","line":258,"updated":"2017-05-04 11:04:28.000000000","message":"see comment above","commit_id":"42ae488360800ba856b4a84b5350b1481b05736b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b895c9fc0fcdbcd9ac8a0478506c1a8d00e8f19","unresolved":false,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def test_process_fields_create_network_no_policy(self):"},{"line_number":271,"context_line":"        with self._mock_plugin_loaded(True):"},{"line_number":272,"context_line":"            project_id \u003d mock.Mock()"},{"line_number":273,"context_line":"            network_id \u003d mock.Mock()"},{"line_number":274,"context_line":"            actual_network \u003d {\u0027project_id\u0027: project_id,"},{"line_number":275,"context_line":"                              \u0027id\u0027: network_id,"}],"source_content_type":"text/x-python","patch_set":63,"id":"3f044301_bda049a7","line":272,"updated":"2017-05-04 11:04:28.000000000","message":"same here","commit_id":"42ae488360800ba856b4a84b5350b1481b05736b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b895c9fc0fcdbcd9ac8a0478506c1a8d00e8f19","unresolved":false,"context_lines":[{"line_number":270,"context_line":"    def test_process_fields_create_network_no_policy(self):"},{"line_number":271,"context_line":"        with self._mock_plugin_loaded(True):"},{"line_number":272,"context_line":"            project_id \u003d mock.Mock()"},{"line_number":273,"context_line":"            network_id \u003d mock.Mock()"},{"line_number":274,"context_line":"            actual_network \u003d {\u0027project_id\u0027: project_id,"},{"line_number":275,"context_line":"                              \u0027id\u0027: network_id,"},{"line_number":276,"context_line":"                              qos_consts.QOS_POLICY_ID: None}"}],"source_content_type":"text/x-python","patch_set":63,"id":"3f044301_7daac185","line":273,"updated":"2017-05-04 11:04:28.000000000","message":"and here","commit_id":"42ae488360800ba856b4a84b5350b1481b05736b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b895c9fc0fcdbcd9ac8a0478506c1a8d00e8f19","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            actual_network \u003d {\u0027project_id\u0027: project_id,"},{"line_number":275,"context_line":"                              \u0027id\u0027: network_id,"},{"line_number":276,"context_line":"                              qos_consts.QOS_POLICY_ID: None}"},{"line_number":277,"context_line":"            qos_policy_id \u003d mock.Mock()"},{"line_number":278,"context_line":"            qos_policy \u003d mock.MagicMock()"},{"line_number":279,"context_line":"            with mock.patch.object(policy.QosPolicyDefault, \"get_object\","},{"line_number":280,"context_line":"                    return_value\u003dqos_policy_id) as mock_get_default_policy_id:"}],"source_content_type":"text/x-python","patch_set":63,"id":"3f044301_1d917d53","line":277,"updated":"2017-05-04 11:04:28.000000000","message":"and here :)","commit_id":"42ae488360800ba856b4a84b5350b1481b05736b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b895c9fc0fcdbcd9ac8a0478506c1a8d00e8f19","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def test_process_fields_create_network_no_default_policy(self):"},{"line_number":290,"context_line":"        with self._mock_plugin_loaded(True):"},{"line_number":291,"context_line":"            project_id \u003d mock.Mock()"},{"line_number":292,"context_line":"            network_id \u003d mock.Mock()"},{"line_number":293,"context_line":"            actual_network \u003d {\u0027project_id\u0027: project_id,"},{"line_number":294,"context_line":"                              \u0027id\u0027: network_id,"}],"source_content_type":"text/x-python","patch_set":63,"id":"3f044301_dd9af56c","line":291,"updated":"2017-05-04 11:04:28.000000000","message":"and here :)","commit_id":"42ae488360800ba856b4a84b5350b1481b05736b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b895c9fc0fcdbcd9ac8a0478506c1a8d00e8f19","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    def test_process_fields_create_network_no_default_policy(self):"},{"line_number":290,"context_line":"        with self._mock_plugin_loaded(True):"},{"line_number":291,"context_line":"            project_id \u003d mock.Mock()"},{"line_number":292,"context_line":"            network_id \u003d mock.Mock()"},{"line_number":293,"context_line":"            actual_network \u003d {\u0027project_id\u0027: project_id,"},{"line_number":294,"context_line":"                              \u0027id\u0027: network_id,"},{"line_number":295,"context_line":"                              qos_consts.QOS_POLICY_ID: None}"}],"source_content_type":"text/x-python","patch_set":63,"id":"3f044301_9d8ead2c","line":292,"updated":"2017-05-04 11:04:28.000000000","message":"and here","commit_id":"42ae488360800ba856b4a84b5350b1481b05736b"}],"neutron/tests/unit/db/qos/test_api.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"80d3114d4ebac136721d27972dece943e13ff888","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import mock"},{"line_number":16,"context_line":"from oslo_utils import uuidutils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron_lib import context"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.db.qos import api as qos_api"},{"line_number":21,"context_line":"from neutron.services.qos import qos_plugin"}],"source_content_type":"text/x-python","patch_set":40,"id":"ffe62b97_0012a909","line":18,"updated":"2017-03-28 10:04:20.000000000","message":"this should be in the same section above","commit_id":"6224c845d77ea2e3c4aaa0c7d7ce4692d7e3d5aa"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"474043965def9320b2bcb63eb85681495be72ac7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import mock"},{"line_number":16,"context_line":"from oslo_utils import uuidutils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron_lib import context"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.db.qos import api as qos_api"},{"line_number":21,"context_line":"from neutron.services.qos import qos_plugin"}],"source_content_type":"text/x-python","patch_set":40,"id":"ffe62b97_8029199c","line":18,"in_reply_to":"ffe62b97_0012a909","updated":"2017-03-28 10:17:40.000000000","message":"Done","commit_id":"6224c845d77ea2e3c4aaa0c7d7ce4692d7e3d5aa"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"3cbbaf9887260b213b65732e59603973747610c9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                       \u0027shared\u0027: True,"},{"line_number":48,"context_line":"                       \u0027is_default\u0027: False}}"},{"line_number":49,"context_line":"        for key in [key for key in kwargs"},{"line_number":50,"context_line":"                    if key in policy_data[\u0027policy\u0027].keys()]:"},{"line_number":51,"context_line":"            policy_data[\u0027policy\u0027][key] \u003d kwargs[key]"},{"line_number":52,"context_line":"        self._policies_id.add(policy_data[\u0027policy\u0027][\u0027id\u0027])"},{"line_number":53,"context_line":"        self._qos_plugin.create_policy(self._context, policy_data)"}],"source_content_type":"text/x-python","patch_set":46,"id":"bff0334d_3d76c13f","line":50,"range":{"start_line":50,"start_character":52,"end_line":50,"end_character":58},"updated":"2017-04-11 21:20:37.000000000","message":"keys() is called by default this can be removed.\n\nAlso if this is collection is costly enough, to justify creation of sets, you could consider using sets. \n\n\u003e for key in kwargs.interesection(policy_data[\u0027policy\u0027])","commit_id":"a89de20b06bd480d6a0b5cc3f5ce94459f891edf"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"111136b929fba42ab2d67b0d8868b3277c21ee81","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                       \u0027shared\u0027: True,"},{"line_number":48,"context_line":"                       \u0027is_default\u0027: False}}"},{"line_number":49,"context_line":"        for key in [key for key in kwargs"},{"line_number":50,"context_line":"                    if key in policy_data[\u0027policy\u0027].keys()]:"},{"line_number":51,"context_line":"            policy_data[\u0027policy\u0027][key] \u003d kwargs[key]"},{"line_number":52,"context_line":"        self._policies_id.add(policy_data[\u0027policy\u0027][\u0027id\u0027])"},{"line_number":53,"context_line":"        self._qos_plugin.create_policy(self._context, policy_data)"}],"source_content_type":"text/x-python","patch_set":46,"id":"bff0334d_33393ed6","line":50,"range":{"start_line":50,"start_character":52,"end_line":50,"end_character":58},"in_reply_to":"bff0334d_3d76c13f","updated":"2017-04-12 10:04:54.000000000","message":"1) I\u0027ll remove keys()\n2) IMO, the list generator is easier to read (but it\u0027s just my opinion)","commit_id":"a89de20b06bd480d6a0b5cc3f5ce94459f891edf"}],"neutron/tests/unit/services/qos/test_qos_plugin.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0a4ffd5118d86f86a8c1442393c6ee68e758b0d8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import copy"},{"line_number":14,"context_line":"import mock"},{"line_number":15,"context_line":"from neutron_lib import context"},{"line_number":16,"context_line":"from neutron_lib.plugins import directory"}],"source_content_type":"text/x-python","patch_set":32,"id":"ffe62b97_101da9bc","line":13,"updated":"2017-03-26 13:50:43.000000000","message":"missing new line here","commit_id":"1bb59031de703a85e61e0fce64272515f905102c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"631880f81de17e7ede55c59ec0b456df01432a33","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import copy"},{"line_number":14,"context_line":"import mock"},{"line_number":15,"context_line":"from neutron_lib import context"},{"line_number":16,"context_line":"from neutron_lib.plugins import directory"}],"source_content_type":"text/x-python","patch_set":32,"id":"ffe62b97_90a2d94a","line":13,"in_reply_to":"ffe62b97_101da9bc","updated":"2017-03-26 14:10:32.000000000","message":"Done","commit_id":"1bb59031de703a85e61e0fce64272515f905102c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"bdcc236911437a04661ffe855b145e55bb7e4418","unresolved":false,"context_lines":[{"line_number":528,"context_line":"    def test_update_policy_rule_check_rule_minbw_gr_than_bwlimit(self):"},{"line_number":529,"context_line":"        _policy \u003d self._get_policy()"},{"line_number":530,"context_line":"        setattr(_policy, \"rules\", [self.min_rule])"},{"line_number":531,"context_line":"        ###self.mock_qos_load_attr.stop()"},{"line_number":532,"context_line":"        with mock.patch(\u0027neutron.objects.qos.policy.QosPolicy.get_object\u0027,"},{"line_number":533,"context_line":"                        return_value\u003d_policy):"},{"line_number":534,"context_line":"            self.qos_plugin.update_policy_minimum_bandwidth_rule("}],"source_content_type":"text/x-python","patch_set":68,"id":"ff0f0b1f_a406e41f","line":531,"updated":"2017-05-26 22:31:31.000000000","message":"Are we going to leave this here?","commit_id":"ac480359d6be76c247dce4bba6a2a489831cad2c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f8bfcf2e223809239a7b4946576a65efd095fc5f","unresolved":false,"context_lines":[{"line_number":528,"context_line":"    def test_update_policy_rule_check_rule_minbw_gr_than_bwlimit(self):"},{"line_number":529,"context_line":"        _policy \u003d self._get_policy()"},{"line_number":530,"context_line":"        setattr(_policy, \"rules\", [self.min_rule])"},{"line_number":531,"context_line":"        ###self.mock_qos_load_attr.stop()"},{"line_number":532,"context_line":"        with mock.patch(\u0027neutron.objects.qos.policy.QosPolicy.get_object\u0027,"},{"line_number":533,"context_line":"                        return_value\u003d_policy):"},{"line_number":534,"context_line":"            self.qos_plugin.update_policy_minimum_bandwidth_rule("}],"source_content_type":"text/x-python","patch_set":68,"id":"ff0f0b1f_6a3655b7","line":531,"updated":"2017-05-26 23:30:44.000000000","message":"I\u0027ll just address these really quick","commit_id":"ac480359d6be76c247dce4bba6a2a489831cad2c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2c5b74f37d44469b9c3fe73d618c69bc3a024261","unresolved":false,"context_lines":[{"line_number":528,"context_line":"    def test_update_policy_rule_check_rule_minbw_gr_than_bwlimit(self):"},{"line_number":529,"context_line":"        _policy \u003d self._get_policy()"},{"line_number":530,"context_line":"        setattr(_policy, \"rules\", [self.min_rule])"},{"line_number":531,"context_line":"        ###self.mock_qos_load_attr.stop()"},{"line_number":532,"context_line":"        with mock.patch(\u0027neutron.objects.qos.policy.QosPolicy.get_object\u0027,"},{"line_number":533,"context_line":"                        return_value\u003d_policy):"},{"line_number":534,"context_line":"            self.qos_plugin.update_policy_minimum_bandwidth_rule("}],"source_content_type":"text/x-python","patch_set":68,"id":"df140735_47a96ddd","line":531,"in_reply_to":"ff0f0b1f_6a3655b7","updated":"2017-05-29 06:56:58.000000000","message":"Thanks. I missed that.","commit_id":"ac480359d6be76c247dce4bba6a2a489831cad2c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"bdcc236911437a04661ffe855b145e55bb7e4418","unresolved":false,"context_lines":[{"line_number":533,"context_line":"                        return_value\u003d_policy):"},{"line_number":534,"context_line":"            self.qos_plugin.update_policy_minimum_bandwidth_rule("},{"line_number":535,"context_line":"                self.ctxt, self.min_rule.id, self.policy.id, self.rule_data)"},{"line_number":536,"context_line":"            #self.assertTrue(getattr(rule_object, \"get_rules\").called)"},{"line_number":537,"context_line":"            self.mock_qos_load_attr.assert_called_once_with(\u0027rules\u0027)"},{"line_number":538,"context_line":"            self._validate_driver_params(\u0027update_policy\u0027)"},{"line_number":539,"context_line":"        self.rule_data[\u0027bandwidth_limit_rule\u0027][\u0027max_kbps\u0027] \u003d 1"}],"source_content_type":"text/x-python","patch_set":68,"id":"ff0f0b1f_67fe8e06","line":536,"updated":"2017-05-26 22:31:31.000000000","message":"Ditto","commit_id":"ac480359d6be76c247dce4bba6a2a489831cad2c"}],"neutron/tests/unit/testlib_api.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0a4ffd5118d86f86a8c1442393c6ee68e758b0d8","unresolved":false,"context_lines":[{"line_number":307,"context_line":"    \"\"\"Mixin that converts a BaseSqlTestCase to use the OpportunisticSqlFixture."},{"line_number":308,"context_line":"    \"\"\""},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    #RAH"},{"line_number":311,"context_line":"    #SKIP_ON_UNAVAILABLE_DB \u003d not base.bool_from_env(\u0027OS_FAIL_ON_MISSING_DEPS\u0027)"},{"line_number":312,"context_line":"    SKIP_ON_UNAVAILABLE_DB \u003d True"},{"line_number":313,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"ffe62b97_b0839dcc","line":310,"updated":"2017-03-26 13:50:43.000000000","message":"??","commit_id":"1bb59031de703a85e61e0fce64272515f905102c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"631880f81de17e7ede55c59ec0b456df01432a33","unresolved":false,"context_lines":[{"line_number":307,"context_line":"    \"\"\"Mixin that converts a BaseSqlTestCase to use the OpportunisticSqlFixture."},{"line_number":308,"context_line":"    \"\"\""},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    #RAH"},{"line_number":311,"context_line":"    #SKIP_ON_UNAVAILABLE_DB \u003d not base.bool_from_env(\u0027OS_FAIL_ON_MISSING_DEPS\u0027)"},{"line_number":312,"context_line":"    SKIP_ON_UNAVAILABLE_DB \u003d True"},{"line_number":313,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"ffe62b97_30930dfd","line":310,"in_reply_to":"ffe62b97_b0839dcc","updated":"2017-03-26 14:10:32.000000000","message":"The same answer: I forgot to uncomment some debug changes. Sorry for that!","commit_id":"1bb59031de703a85e61e0fce64272515f905102c"}]}
