)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"7a7610187b5c6df7a3afdc0f76627bc3eaf28bbd","unresolved":false,"context_lines":[{"line_number":30,"context_line":"related. Eliminating the frequent TRY_AGAIN responses, in my local"},{"line_number":31,"context_line":"testing, also eliminates the TimeoutExceptions. This doesn\u0027t mean"},{"line_number":32,"context_line":"that the underlying issue is resolved, but it may be avoided."},{"line_number":33,"context_line":"Related-Bug: #1627106"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Change-Id: I26c7731f5dbd3bd2955dbfa18a7c41517da63e6e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa31d9ce_602d8fa7","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":7},"updated":"2017-02-14 15:40:00.000000000","message":"If we avoid the issue, doesn\u0027t it mean we\u0027re good with the solution? :)","commit_id":"26766963c6e6b2105718e21cd14dfc6df201154c"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"97c704ecdf46187ddc7d34807e9641d3c4586801","unresolved":false,"context_lines":[{"line_number":30,"context_line":"related. Eliminating the frequent TRY_AGAIN responses, in my local"},{"line_number":31,"context_line":"testing, also eliminates the TimeoutExceptions. This doesn\u0027t mean"},{"line_number":32,"context_line":"that the underlying issue is resolved, but it may be avoided."},{"line_number":33,"context_line":"Related-Bug: #1627106"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Change-Id: I26c7731f5dbd3bd2955dbfa18a7c41517da63e6e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa31d9ce_07330215","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":7},"in_reply_to":"fa31d9ce_602d8fa7","updated":"2017-02-14 17:58:50.000000000","message":"Well, for now. db_add(), to mimic the behavior of ovs-vsctl, promises that if a map key is modified with db_add and is already set, nothing will be done. So that operation would still require a verify() call in case the key was set by another transaction. To my knowledge, we don\u0027t use DbAdd on maps, but that doesn\u0027t mean we won\u0027t in the future for some reason. And I don\u0027t like the issue just lurking.","commit_id":"26766963c6e6b2105718e21cd14dfc6df201154c"}],"neutron/agent/ovsdb/native/commands.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3326c12e1203f259d6126892c98d3509f844619a","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            port.delete()"},{"line_number":162,"context_line":"        try:"},{"line_number":163,"context_line":"            self.api._ovs.delvalue(\u0027bridges\u0027, br)"},{"line_number":164,"context_line":"        except AttributeError:"},{"line_number":165,"context_line":"            self.api._ovs.verify(\u0027bridges\u0027)"},{"line_number":166,"context_line":"            bridges \u003d self.api._ovs.bridges"},{"line_number":167,"context_line":"            bridges.remove(br)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_ddc4ea41","line":164,"updated":"2017-02-03 23:34:13.000000000","message":"can you comment here indicating that attribute error means old version?","commit_id":"df115e7e3afa3b5a5c275befb3d9ad629669c922"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"30ed283e3effd2270295e422efa8544f4bb64e37","unresolved":false,"context_lines":[{"line_number":267,"context_line":"            setattr(record, col, idlutils.db_replace_record(val))"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"class DbAddCommand(BaseCommand):"},{"line_number":271,"context_line":"    def __init__(self, api, table, record, column, *values):"},{"line_number":272,"context_line":"        super(DbAddCommand, self).__init__(api)"},{"line_number":273,"context_line":"        self.table \u003d table"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_9dcee281","line":270,"updated":"2017-02-03 23:29:28.000000000","message":"I need to look more carefully at this one to verify if addvalue() behaves like expected when there are existing keys, etc. We don\u0027t, yet, use db_add() in-tree so it can be added in a separate patch.","commit_id":"df115e7e3afa3b5a5c275befb3d9ad629669c922"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3326c12e1203f259d6126892c98d3509f844619a","unresolved":false,"context_lines":[{"line_number":440,"context_line":""},{"line_number":441,"context_line":"        try:"},{"line_number":442,"context_line":"            br.delvalue(\u0027ports\u0027, port)"},{"line_number":443,"context_line":"        except AttributeError:"},{"line_number":444,"context_line":"            br.verify(\u0027ports\u0027)"},{"line_number":445,"context_line":"            ports \u003d br.ports"},{"line_number":446,"context_line":"            ports.remove(port)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_fdc1a62f","line":443,"updated":"2017-02-03 23:34:13.000000000","message":"ditto","commit_id":"df115e7e3afa3b5a5c275befb3d9ad629669c922"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"7a7610187b5c6df7a3afdc0f76627bc3eaf28bbd","unresolved":false,"context_lines":[{"line_number":447,"context_line":""},{"line_number":448,"context_line":"        try:"},{"line_number":449,"context_line":"            br.delvalue(\u0027ports\u0027, port)"},{"line_number":450,"context_line":"        except AttributeError:  # OVS \u003c 2.6"},{"line_number":451,"context_line":"            br.verify(\u0027ports\u0027)"},{"line_number":452,"context_line":"            ports \u003d br.ports"},{"line_number":453,"context_line":"            ports.remove(port)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_939c9fc1","line":450,"range":{"start_line":450,"start_character":30,"end_line":450,"end_character":43},"updated":"2017-02-14 15:40:00.000000000","message":"Is it here because of plan to backport this patch? We require at least 2.6.1: https://github.com/openstack/requirements/blob/953a6f36370439c5a59ceb1cf1f1e99181b742bc/global-requirements.txt#L151","commit_id":"26766963c6e6b2105718e21cd14dfc6df201154c"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"415f007ff756f1b51561678ba8966de103bc6ee4","unresolved":false,"context_lines":[{"line_number":447,"context_line":""},{"line_number":448,"context_line":"        try:"},{"line_number":449,"context_line":"            br.delvalue(\u0027ports\u0027, port)"},{"line_number":450,"context_line":"        except AttributeError:  # OVS \u003c 2.6"},{"line_number":451,"context_line":"            br.verify(\u0027ports\u0027)"},{"line_number":452,"context_line":"            ports \u003d br.ports"},{"line_number":453,"context_line":"            ports.remove(port)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_a23867a1","line":450,"range":{"start_line":450,"start_character":30,"end_line":450,"end_character":43},"in_reply_to":"fa31d9ce_939c9fc1","updated":"2017-02-14 17:08:30.000000000","message":"We require python-openvswitch \u003e\u003d 2.6.1 because it is the only one that supports python 3 I believe. Distro packaging until lately has been behind, but things work anyway because people didn\u0027t use Python 3. I went ahead and added this just because it was cheap to do.","commit_id":"26766963c6e6b2105718e21cd14dfc6df201154c"}]}