)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"31d44415bf35195e1c78ee27df820d898704d6f2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     garyk \u003cgkotton@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-05 14:24:52 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure that subnet update does not creat RPC client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Commit fc7cae844cb783887b8a8eb4d9c3286116d740e6 would create"},{"line_number":10,"context_line":"the notification class each time that the subnet update is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a430d35_1213aa67","line":7,"updated":"2017-02-05 21:57:46.000000000","message":"nit: s/creat/create/","commit_id":"ac598f5b7a3a8f54ea52bc8042eae84061c5c031"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e0fc0de77f8277564dc5742741e665c236b98bb","unresolved":false,"context_lines":[{"line_number":867,"context_line":"                self.update_port(context, port[\u0027id\u0027], {\u0027port\u0027: port})"},{"line_number":868,"context_line":"            # Send router_update to l3_agent"},{"line_number":869,"context_line":"            if routers:"},{"line_number":870,"context_line":"                self.l3_rpc_notifier.routers_updated(context, routers)"},{"line_number":871,"context_line":""},{"line_number":872,"context_line":"        if orig[\u0027gateway_ip\u0027] !\u003d result[\u0027gateway_ip\u0027]:"},{"line_number":873,"context_line":"            kwargs \u003d {\u0027context\u0027: context, \u0027subnet_id\u0027: result[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_22471c78","line":870,"updated":"2017-02-07 17:59:55.000000000","message":"so @garyk, you suggest that saving a single API object __init__ per subnet update (not e.g. per port affected) somehow makes it faster/more stable. A local check suggests that 100k object creations take ~.5s. Do you suggest someone does tens of thousands of PD controlled subnet updates per second, to make any release critical difference?\n\nAll I am saying is that we are in RC mode, we don\u0027t allow random patches with no clear benefit to go in. We had stability issues during Newton RC, and I don\u0027t want to repeat the mistake.\n\nThe best you can do is proving it actually makes some difference in a real life scenario.","commit_id":"ac598f5b7a3a8f54ea52bc8042eae84061c5c031"}]}
