)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"47080aeb7da5e50f48227f931f1c305e6f645a1e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The initial implementation was measuring the bandwidth stability"},{"line_number":10,"context_line":"over segments of time. But recent failures on high gate pressure"},{"line_number":11,"context_line":"has show that such stability can\u0027t be expected on the edge."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The test now checks the mean bandwidth during the whole transmission."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a430d35_96bc9bdd","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":8},"updated":"2017-02-07 15:36:13.000000000","message":"shown","commit_id":"90f187a81687b9e286fe71fb7feb35ae8963402f"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"54fda0d2b7e1222d2727bd4392771253cf859339","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The initial implementation was measuring the bandwidth stability"},{"line_number":10,"context_line":"over segments of time. But recent failures on high gate pressure"},{"line_number":11,"context_line":"has show that such stability can\u0027t be expected on the edge."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The test now checks the mean bandwidth during the whole transmission."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a430d35_acd78849","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":8},"in_reply_to":"1a430d35_96bc9bdd","updated":"2017-02-07 15:54:52.000000000","message":"Done","commit_id":"90f187a81687b9e286fe71fb7feb35ae8963402f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"47080aeb7da5e50f48227f931f1c305e6f645a1e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"over segments of time. But recent failures on high gate pressure"},{"line_number":11,"context_line":"has show that such stability can\u0027t be expected on the edge."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The test now checks the mean bandwidth during the whole transmission."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ic6a00f20ce76aba319ecdada79f68599c891cf29"},{"line_number":16,"context_line":"Closes-Bug: #1662109"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a430d35_9633bb13","line":13,"range":{"start_line":13,"start_character":24,"end_line":13,"end_character":28},"updated":"2017-02-07 15:36:13.000000000","message":"Isn\u0027t it average? Mean means something different.","commit_id":"90f187a81687b9e286fe71fb7feb35ae8963402f"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"54fda0d2b7e1222d2727bd4392771253cf859339","unresolved":false,"context_lines":[{"line_number":10,"context_line":"over segments of time. But recent failures on high gate pressure"},{"line_number":11,"context_line":"has show that such stability can\u0027t be expected on the edge."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The test now checks the mean bandwidth during the whole transmission."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ic6a00f20ce76aba319ecdada79f68599c891cf29"},{"line_number":16,"context_line":"Closes-Bug: #1662109"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a430d35_ccc854ab","line":13,"range":{"start_line":13,"start_character":24,"end_line":13,"end_character":28},"in_reply_to":"1a430d35_9633bb13","updated":"2017-02-07 15:54:52.000000000","message":"woops :D","commit_id":"90f187a81687b9e286fe71fb7feb35ae8963402f"}],"neutron/tests/tempest/scenario/test_qos.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"47080aeb7da5e50f48227f931f1c305e6f645a1e","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            should_check \u003d (time_elapsed \u003e\u003d 5 or"},{"line_number":126,"context_line":"                            total_bytes_read \u003d\u003d QoSTest.FILE_SIZE)"},{"line_number":127,"context_line":"            if should_check:"},{"line_number":128,"context_line":"                LOG.debug(\"time_elapsed \u003d  %(time_elapsed)d,\""},{"line_number":129,"context_line":"                          \"total_bytes_read \u003d %(bytes_read)d,\""},{"line_number":130,"context_line":"                          \"cycle_data_read \u003d %(cycle_data)d\","},{"line_number":131,"context_line":"                          {\"time_elapsed\": time_elapsed,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_16426bae","side":"PARENT","line":128,"range":{"start_line":128,"start_character":16,"end_line":128,"end_character":25},"updated":"2017-02-07 15:36:13.000000000","message":"I found this quite useful. Especially in the bug this patch solves :) Maybe we should keep it for future us?","commit_id":"31e5176a3606fca4ee7587964fce82729db5ef15"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"54fda0d2b7e1222d2727bd4392771253cf859339","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            should_check \u003d (time_elapsed \u003e\u003d 5 or"},{"line_number":126,"context_line":"                            total_bytes_read \u003d\u003d QoSTest.FILE_SIZE)"},{"line_number":127,"context_line":"            if should_check:"},{"line_number":128,"context_line":"                LOG.debug(\"time_elapsed \u003d  %(time_elapsed)d,\""},{"line_number":129,"context_line":"                          \"total_bytes_read \u003d %(bytes_read)d,\""},{"line_number":130,"context_line":"                          \"cycle_data_read \u003d %(cycle_data)d\","},{"line_number":131,"context_line":"                          {\"time_elapsed\": time_elapsed,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_2cd1d8fa","side":"PARENT","line":128,"range":{"start_line":128,"start_character":16,"end_line":128,"end_character":25},"in_reply_to":"1a430d35_16426bae","updated":"2017-02-07 15:54:52.000000000","message":"ack.","commit_id":"31e5176a3606fca4ee7587964fce82729db5ef15"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"47080aeb7da5e50f48227f931f1c305e6f645a1e","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                \u0027port\u0027: port, \u0027file_path\u0027: QoSTest.FILE_PATH})"},{"line_number":106,"context_line":"        ssh_client.exec_command(cmd)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        start_time \u003d time.time()"},{"line_number":109,"context_line":"        client_socket \u003d _connect_socket(host, port)"},{"line_number":110,"context_line":"        total_bytes_read \u003d 0"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_168c2bd9","line":108,"range":{"start_line":108,"start_character":0,"end_line":108,"end_character":32},"updated":"2017-02-07 15:36:13.000000000","message":"Should we move it as close as possible to the while loop? To L111 - it would count _connect_socket which is relatively expensive","commit_id":"90f187a81687b9e286fe71fb7feb35ae8963402f"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"54fda0d2b7e1222d2727bd4392771253cf859339","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                \u0027port\u0027: port, \u0027file_path\u0027: QoSTest.FILE_PATH})"},{"line_number":106,"context_line":"        ssh_client.exec_command(cmd)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        start_time \u003d time.time()"},{"line_number":109,"context_line":"        client_socket \u003d _connect_socket(host, port)"},{"line_number":110,"context_line":"        total_bytes_read \u003d 0"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_8cdf2c0c","line":108,"range":{"start_line":108,"start_character":0,"end_line":108,"end_character":32},"in_reply_to":"1a430d35_168c2bd9","updated":"2017-02-07 15:54:52.000000000","message":"I prefer to be on the safe side, if the system blocks from socket open, to start_time measurement, we will get a big bump again.\n\nWe retry, but given the situation, can we stay on the safe side? :)","commit_id":"90f187a81687b9e286fe71fb7feb35ae8963402f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"51a229860420f84c4f7c8ef6778a2f1162c58023","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                \u0027port\u0027: port, \u0027file_path\u0027: QoSTest.FILE_PATH})"},{"line_number":106,"context_line":"        ssh_client.exec_command(cmd)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        start_time \u003d time.time()"},{"line_number":109,"context_line":"        client_socket \u003d _connect_socket(host, port)"},{"line_number":110,"context_line":"        total_bytes_read \u003d 0"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_2a95383e","line":108,"range":{"start_line":108,"start_character":0,"end_line":108,"end_character":32},"in_reply_to":"1a430d35_8cdf2c0c","updated":"2017-02-07 16:23:57.000000000","message":"Right, so that would falsify the result on L117, wouldn\u0027t it?","commit_id":"90f187a81687b9e286fe71fb7feb35ae8963402f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1767af7f63812c6808d26dd1633c8bae6db4b17d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            total_bytes_read +\u003d len(data)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        time_elapsed \u003d time.time() - start_time"},{"line_number":117,"context_line":"        bytes_per_second \u003d total_bytes_read / time_elapsed"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        LOG.debug(\"time_elapsed \u003d %(time_elapsed)d, \""},{"line_number":120,"context_line":"                  \"total_bytes_read \u003d %(total_bytes_read)d, \""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_8a062c84","line":117,"range":{"start_line":117,"start_character":27,"end_line":117,"end_character":58},"updated":"2017-02-07 16:27:19.000000000","message":"Nit: Should we make one of those arguments a float number, so we get more precise bytes_per_second value?","commit_id":"b7213030fd59c6169b9a2d4cb9680cf5adbfe6d8"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"26f21a8fb4c2ee19ea0a3a438506879493d399fc","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            total_bytes_read +\u003d len(data)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        time_elapsed \u003d time.time() - start_time"},{"line_number":117,"context_line":"        bytes_per_second \u003d total_bytes_read / time_elapsed"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        LOG.debug(\"time_elapsed \u003d %(time_elapsed)d, \""},{"line_number":120,"context_line":"                  \"total_bytes_read \u003d %(total_bytes_read)d, \""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_c832f70f","line":117,"range":{"start_line":117,"start_character":27,"end_line":117,"end_character":58},"in_reply_to":"1a430d35_8a062c84","updated":"2017-02-07 19:00:52.000000000","message":"Not necessary I think the extra granularity is not needed at all.\n\nThe value on the test is around 128*1024","commit_id":"b7213030fd59c6169b9a2d4cb9680cf5adbfe6d8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"932a0e9b9e31f3382f9761508c8b0b7f682995b3","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            total_bytes_read +\u003d len(data)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        time_elapsed \u003d time.time() - start_time"},{"line_number":117,"context_line":"        bytes_per_second \u003d total_bytes_read / time_elapsed"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        LOG.debug(\"time_elapsed \u003d %(time_elapsed)d, \""},{"line_number":120,"context_line":"                  \"total_bytes_read \u003d %(total_bytes_read)d, \""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_eb55e8c1","line":117,"range":{"start_line":117,"start_character":27,"end_line":117,"end_character":58},"in_reply_to":"1a430d35_c832f70f","updated":"2017-02-07 21:55:09.000000000","message":"per Python docs, time.time() returns \"the time in seconds since the epoch as a floating point number\". So time_elapsed and bytes_per_second are floating point numbers","commit_id":"b7213030fd59c6169b9a2d4cb9680cf5adbfe6d8"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"565256e186000a5e63a76b8d9e8328c15740e2eb","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            total_bytes_read +\u003d len(data)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        time_elapsed \u003d time.time() - start_time"},{"line_number":117,"context_line":"        bytes_per_second \u003d total_bytes_read / time_elapsed"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        LOG.debug(\"time_elapsed \u003d %(time_elapsed)d, \""},{"line_number":120,"context_line":"                  \"total_bytes_read \u003d %(total_bytes_read)d, \""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_a625ca09","line":117,"range":{"start_line":117,"start_character":27,"end_line":117,"end_character":58},"in_reply_to":"1a430d35_eb55e8c1","updated":"2017-02-08 08:30:55.000000000","message":"Ah, good to know, thanks :) I thought it\u0027s integer.","commit_id":"b7213030fd59c6169b9a2d4cb9680cf5adbfe6d8"}]}
