)]}'
{"neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"55fa2be93db6a5b60c6561f87d9181e9d1117b1f","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        # Update default gateway if necessary"},{"line_number":237,"context_line":"        gateway \u003d device.route.get_gateway(scope\u003d\u0027global\u0027,"},{"line_number":238,"context_line":"                                           ip_version\u003dconstants.IP_VERSION_4)"},{"line_number":239,"context_line":"        return ips, gateway"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def ensure_flat_bridge(self, network_id, phy_bridge_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_f372e2ac","line":238,"updated":"2017-02-09 21:59:07.000000000","message":"Thinking about this some more, since this is only getting a single gateway (the IPv4 one since that\u0027s what /sbin/ip will return without a family argument), any old gateway that did exist will be using the old interface, and will be broken, probably until another RA arrives.\n\nSo a better change would be for update_interface_ip_details() to do a loop with (4, 6) or somesuch.\n\nOf course that\u0027s assuming not disabling IPv6 in ensure_bridge() is what we want to do?","commit_id":"e9bc1e54f6207467ec2bbbabb9f1bb0ae6b150aa"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ea44b4054333f65a3f8854b6190be4f9693b2359","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            return False"},{"line_number":360,"context_line":"        return True"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    def ensure_bridge(self, bridge_name, interface\u003dNone, move_ips\u003dTrue):"},{"line_number":363,"context_line":"        \"\"\"Create a bridge unless it already exists.\"\"\""},{"line_number":364,"context_line":"        # _bridge_exists_and_ensure_up instead of device_exists is used here"},{"line_number":365,"context_line":"        # because there are cases where the bridge exists but it\u0027s not UP,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_9282a7c6","line":362,"range":{"start_line":362,"start_character":57,"end_line":362,"end_character":65},"updated":"2017-03-05 09:31:55.000000000","message":"can we consider maybe calling the parameter update_interface?","commit_id":"5464d2c89fc4148575db1f7f62b2a89f3ed62a77"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"da46d7fef1f8de0411ff9ffc6cb6f07aedf035d2","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            return False"},{"line_number":360,"context_line":"        return True"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    def ensure_bridge(self, bridge_name, interface\u003dNone, move_ips\u003dTrue):"},{"line_number":363,"context_line":"        \"\"\"Create a bridge unless it already exists.\"\"\""},{"line_number":364,"context_line":"        # _bridge_exists_and_ensure_up instead of device_exists is used here"},{"line_number":365,"context_line":"        # because there are cases where the bridge exists but it\u0027s not UP,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_0020f79a","line":362,"range":{"start_line":362,"start_character":57,"end_line":362,"end_character":65},"in_reply_to":"ba2be162_9282a7c6","updated":"2017-03-17 20:56:22.000000000","message":"Done","commit_id":"5464d2c89fc4148575db1f7f62b2a89f3ed62a77"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"09d02a6f858aa4dd036edf682153e990f8625340","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        for ip_version in (constants.IP_VERSION_4, constants.IP_VERSION_6):"},{"line_number":343,"context_line":"            ips, gateway \u003d self.get_interface_details(source, ip_version)"},{"line_number":344,"context_line":"            if ips or gateway:"},{"line_number":345,"context_line":"                self._update_interface_ip_details(destination, source, ips,"},{"line_number":346,"context_line":"                                                  gateway)"},{"line_number":347,"context_line":"                updated \u003d True"},{"line_number":348,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_3f5eb776","line":345,"updated":"2017-03-19 09:25:18.000000000","message":"could this method throw an exception. if so do we want to continue?","commit_id":"b6d4d382a9fc1088752ae9b010fb25d0fcdd5845"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"355b4b63fca0a95a3eb7336a19ae61fba7b569d7","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        for ip_version in (constants.IP_VERSION_4, constants.IP_VERSION_6):"},{"line_number":343,"context_line":"            ips, gateway \u003d self.get_interface_details(source, ip_version)"},{"line_number":344,"context_line":"            if ips or gateway:"},{"line_number":345,"context_line":"                self._update_interface_ip_details(destination, source, ips,"},{"line_number":346,"context_line":"                                                  gateway)"},{"line_number":347,"context_line":"                updated \u003d True"},{"line_number":348,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_e773917e","line":345,"in_reply_to":"1a1ced50_3f5eb776","updated":"2017-03-20 18:58:28.000000000","message":"Yes, this could always throw something, ensure_bridge() never caught it either.  I\u0027m not sure catching and continuing is any better as IPv4 would be the one broken, which is probably what is being used.","commit_id":"b6d4d382a9fc1088752ae9b010fb25d0fcdd5845"}]}
