)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ca35cc97997cedb6718cb043d7b762f490818b05","unresolved":false,"context_lines":[{"line_number":9,"context_line":"It turns out that Neutron uses python-requests on just one place"},{"line_number":10,"context_line":"and for no good reason. Given that loading Requests amount for 80MB"},{"line_number":11,"context_line":"of RAM in my system, maybe it\u0027s worth removing our dependency on"},{"line_number":12,"context_line":"requests."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I905252a55bd174ff1aa8bdec42fe32432746846f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa31d9ce_526d3d03","line":12,"updated":"2017-02-10 17:55:50.000000000","message":"http://logs.openstack.org/67/432367/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/1483598/logs/ps.txt.gz\n\nvs \n\nhttp://logs.openstack.org/83/431083/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/cd2e7c6/logs/ps.txt.gz\n\nThe removal of the package seems to make hardly a difference. Can you elaborate on where that 80MB is coming from?","commit_id":"c34e11a2f85293855c8645a786794ac9eea6f4bf"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"c8436df10158047cf5bf4adfe37d843507b96434","unresolved":false,"context_lines":[{"line_number":9,"context_line":"It turns out that Neutron uses python-requests on just one place"},{"line_number":10,"context_line":"and for no good reason. Given that loading Requests amount for 80MB"},{"line_number":11,"context_line":"of RAM in my system, maybe it\u0027s worth removing our dependency on"},{"line_number":12,"context_line":"requests."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I905252a55bd174ff1aa8bdec42fe32432746846f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa31d9ce_8e4e7f94","line":12,"in_reply_to":"fa31d9ce_12182584","updated":"2017-02-13 09:49:53.000000000","message":"I measured python-request memory consumption with this approach: http://stackoverflow.com/a/15448600 (outside of openstack/neutron, just with a fresh python interpreter)","commit_id":"c34e11a2f85293855c8645a786794ac9eea6f4bf"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9eda46be5837223333ba0d1c163b02dd0d23d4a3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"It turns out that Neutron uses python-requests on just one place"},{"line_number":10,"context_line":"and for no good reason. Given that loading Requests amount for 80MB"},{"line_number":11,"context_line":"of RAM in my system, maybe it\u0027s worth removing our dependency on"},{"line_number":12,"context_line":"requests."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I905252a55bd174ff1aa8bdec42fe32432746846f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa31d9ce_12182584","line":12,"in_reply_to":"fa31d9ce_526d3d03","updated":"2017-02-10 17:56:55.000000000","message":"Um, this might simply be because we exercise this HA code in the gate.","commit_id":"c34e11a2f85293855c8645a786794ac9eea6f4bf"}],"neutron/agent/l3/keepalived_state_change.py":[{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"75abbfda4577fae6bcb39f8f0896d67c11b4659b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                     \u0027X-Neutron-State\u0027: state},"},{"line_number":105,"context_line":"            connection_type\u003dKeepalivedUnixDomainConnection)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        if resp.status !\u003d 200:"},{"line_number":108,"context_line":"            raise Exception(_(\u0027Unexpected response: %s\u0027) % resp)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        LOG.debug(\u0027Notified agent router %s, state %s\u0027, self.router_id, state)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_74759c96","line":107,"updated":"2017-02-13 10:17:09.000000000","message":"Can we make a constant and use that constant here? It will help to increase readability.","commit_id":"c34e11a2f85293855c8645a786794ac9eea6f4bf"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"0fe2ccbf9fffa18ae11097843e2aa85984b8b9c4","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                     \u0027X-Neutron-State\u0027: state},"},{"line_number":105,"context_line":"            connection_type\u003dKeepalivedUnixDomainConnection)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        if resp.status !\u003d 200:"},{"line_number":108,"context_line":"            raise Exception(_(\u0027Unexpected response: %s\u0027) % resp)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        LOG.debug(\u0027Notified agent router %s, state %s\u0027, self.router_id, state)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_225be255","line":107,"in_reply_to":"fa31d9ce_74759c96","updated":"2017-02-13 11:13:02.000000000","message":"Constants are fine if we reuse it several times. Besides, we can safely assume that everybody knows what a HTTP 200 means so putting a label on this wouldn\"t help a lot.","commit_id":"c34e11a2f85293855c8645a786794ac9eea6f4bf"}]}
