)]}'
{"tox.ini":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"001b2b780ccc6fa547d5ab9acb8c2a4866ffa937","unresolved":false,"context_lines":[{"line_number":105,"context_line":"basepython \u003d python2.7"},{"line_number":106,"context_line":"commands \u003d"},{"line_number":107,"context_line":"  python setup.py testr --coverage --testr-args\u003d\u0027{posargs}\u0027"},{"line_number":108,"context_line":"  coverage report --fail-under\u003d82 --skip-covered"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"[testenv:venv]"},{"line_number":111,"context_line":"commands \u003d {posargs}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"fa31d9ce_4e9111f0","line":108,"range":{"start_line":108,"start_character":31,"end_line":108,"end_character":33},"updated":"2017-02-10 21:10:23.000000000","message":"what decides the threshold ?","commit_id":"1f3245ae1ba3b7df44121929b9f4d895824d028a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"ae2f8e26b49db3c0d3113d3c8d2bd28a1af1d6fa","unresolved":false,"context_lines":[{"line_number":105,"context_line":"basepython \u003d python2.7"},{"line_number":106,"context_line":"commands \u003d"},{"line_number":107,"context_line":"  python setup.py testr --coverage --testr-args\u003d\u0027{posargs}\u0027"},{"line_number":108,"context_line":"  coverage report --fail-under\u003d82 --skip-covered"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"[testenv:venv]"},{"line_number":111,"context_line":"commands \u003d {posargs}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"fa31d9ce_89e223d4","line":108,"range":{"start_line":108,"start_character":31,"end_line":108,"end_character":33},"in_reply_to":"fa31d9ce_4e9111f0","updated":"2017-02-10 21:35:06.000000000","message":"Well, I saw that our current average is 83% so I just considered as started point.","commit_id":"1f3245ae1ba3b7df44121929b9f4d895824d028a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"187505694f0df3e211965054c2f7a112aa208d4d","unresolved":false,"context_lines":[{"line_number":105,"context_line":"basepython \u003d python2.7"},{"line_number":106,"context_line":"commands \u003d"},{"line_number":107,"context_line":"  python setup.py testr --coverage --testr-args\u003d\u0027{posargs}\u0027"},{"line_number":108,"context_line":"  coverage report --fail-under\u003d82 --skip-covered"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"[testenv:venv]"},{"line_number":111,"context_line":"commands \u003d {posargs}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"fa31d9ce_8fa5c005","line":108,"range":{"start_line":108,"start_character":31,"end_line":108,"end_character":33},"in_reply_to":"fa31d9ce_89e223d4","updated":"2017-02-11 00:39:23.000000000","message":"might as well round this up to 80%. But I am more curious what is the 20% we don\u0027t cover and how we can close on it. These days I can\u0027t see allowing code without a test that I am not sure we\u0027re ever gonna fail this.","commit_id":"1f3245ae1ba3b7df44121929b9f4d895824d028a"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"d30b489ddfa84bb84ff82f4cb7dfb7224f3f8eb6","unresolved":false,"context_lines":[{"line_number":105,"context_line":"basepython \u003d python2.7"},{"line_number":106,"context_line":"commands \u003d"},{"line_number":107,"context_line":"  python setup.py testr --coverage --testr-args\u003d\u0027{posargs}\u0027"},{"line_number":108,"context_line":"  coverage report --fail-under\u003d82 --skip-covered"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"[testenv:venv]"},{"line_number":111,"context_line":"commands \u003d {posargs}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"fa31d9ce_b018a376","line":108,"range":{"start_line":108,"start_character":31,"end_line":108,"end_character":33},"in_reply_to":"fa31d9ce_8fa5c005","updated":"2017-02-15 00:22:39.000000000","message":"removing code and its test might decrease the ratio, right?\n82 is fine for me as we can always revisit though.","commit_id":"1f3245ae1ba3b7df44121929b9f4d895824d028a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e7a79de1d41c64202fc2aa1ca46ef35826da52c7","unresolved":false,"context_lines":[{"line_number":105,"context_line":"basepython \u003d python2.7"},{"line_number":106,"context_line":"commands \u003d"},{"line_number":107,"context_line":"  python setup.py testr --coverage --testr-args\u003d\u0027{posargs}\u0027"},{"line_number":108,"context_line":"  coverage report --fail-under\u003d82 --skip-covered"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"[testenv:venv]"},{"line_number":111,"context_line":"commands \u003d {posargs}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"da36d5c6_b6ea88aa","line":108,"range":{"start_line":108,"start_character":31,"end_line":108,"end_character":33},"in_reply_to":"fa31d9ce_b018a376","updated":"2017-02-23 05:17:05.000000000","message":"In case you are interested what\u0027s not covered, you can refer to the report that the coverage job generates: http://logs.openstack.org/32/432432/2/check/neutron-coverage-ubuntu-xenial/83444fd/cover/ Some of those pieces are covered by other means (f.e. sanity checks are triggered in functional job; service.py should be extensively utilized in dsvm jobs; etc.)","commit_id":"1f3245ae1ba3b7df44121929b9f4d895824d028a"}]}
