)]}'
{"neutron/common/rpc.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"9359027018a07bc91ed0ce854873106ddca8a9c1","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def __init__(self, original_context):"},{"line_number":129,"context_line":"        self._original_context \u003d original_context"},{"line_number":130,"context_line":"        self._max_timeout \u003d TRANSPORT.conf.rpc_response_timeout * 10"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def __getattr__(self, name):"},{"line_number":133,"context_line":"        return getattr(self._original_context, name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_8b39e2f4","line":130,"updated":"2017-02-14 04:10:12.000000000","message":"I\u0027m a little confused. Why are we setting this instance method on init? Doesn\u0027t that make the assignment on L126 pointless?","commit_id":"c497c0b8fa5334b7a722f6cfd06aecc1593b7513"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0bc425e6e4db10ff800470e7f4856f1ce30e1555","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def __init__(self, original_context):"},{"line_number":129,"context_line":"        self._original_context \u003d original_context"},{"line_number":130,"context_line":"        self._max_timeout \u003d TRANSPORT.conf.rpc_response_timeout * 10"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def __getattr__(self, name):"},{"line_number":133,"context_line":"        return getattr(self._original_context, name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_53cdbcb5","line":130,"in_reply_to":"fa31d9ce_8b39e2f4","updated":"2017-02-14 19:15:31.000000000","message":"You are right, the way it is right now, a new context created will end up rewriting the cap.","commit_id":"c497c0b8fa5334b7a722f6cfd06aecc1593b7513"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8ab7288c7ea21bb86d3d65619abac10b6d00c4ca","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            default \u003d lambda: max_timeout"},{"line_number":129,"context_line":"        else:"},{"line_number":130,"context_line":"            default \u003d _get_default_method_timeout"},{"line_number":131,"context_line":"        cls._METHOD_TIMEOUTS \u003d collections.defaultdict("},{"line_number":132,"context_line":"            default, **{"},{"line_number":133,"context_line":"                k: min(v, max_timeout)"},{"line_number":134,"context_line":"                for k, v in cls._METHOD_TIMEOUTS.items()"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_4beb4078","line":131,"updated":"2017-02-14 20:59:10.000000000","message":"we can prolly avoid resetting/recalculating the dict if max_timeout requested is not lower than default.","commit_id":"804541748a3e904aaef5398ff3397811eb74428b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"dd7ad052599d18bfce330223296fd75c87a77c87","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @classmethod"},{"line_number":112,"context_line":"    def reset_timeouts(cls):"},{"line_number":113,"context_line":"        cls._METHOD_TIMEOUTS \u003d _get_default_method_timeouts()"},{"line_number":114,"context_line":"        try:"},{"line_number":115,"context_line":"            delattr(cls, \u0027_max_timeout\u0027)"},{"line_number":116,"context_line":"        except AttributeError:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_6d227b03","line":113,"range":{"start_line":113,"start_character":28,"end_line":113,"end_character":61},"updated":"2017-02-16 16:48:30.000000000","message":"What was wrong with the previous approach with .clear() ?","commit_id":"f89f41fb33fac94f7845856e29be680e7c0634aa"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"940d66a160da225533dbe2c056e5142e7f62055d","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @classmethod"},{"line_number":112,"context_line":"    def reset_timeouts(cls):"},{"line_number":113,"context_line":"        cls._METHOD_TIMEOUTS \u003d _get_default_method_timeouts()"},{"line_number":114,"context_line":"        try:"},{"line_number":115,"context_line":"            delattr(cls, \u0027_max_timeout\u0027)"},{"line_number":116,"context_line":"        except AttributeError:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_8f7239ac","line":113,"range":{"start_line":113,"start_character":28,"end_line":113,"end_character":61},"in_reply_to":"fa31d9ce_6d227b03","updated":"2017-02-16 21:48:13.000000000","message":".clear() does not change the default factory back to normal.","commit_id":"f89f41fb33fac94f7845856e29be680e7c0634aa"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"dd7ad052599d18bfce330223296fd75c87a77c87","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    def reset_timeouts(cls):"},{"line_number":113,"context_line":"        cls._METHOD_TIMEOUTS \u003d _get_default_method_timeouts()"},{"line_number":114,"context_line":"        try:"},{"line_number":115,"context_line":"            delattr(cls, \u0027_max_timeout\u0027)"},{"line_number":116,"context_line":"        except AttributeError:"},{"line_number":117,"context_line":"            pass"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_4df7778c","line":115,"range":{"start_line":115,"start_character":25,"end_line":115,"end_character":39},"updated":"2017-02-16 16:48:30.000000000","message":"It\u0027s easier to make _max_timeout a class attribute defaulting to None.\n\n _max_timeout \u003d None\n\n def reset_timeouts(cls):\n    cls._max_timeout \u003d None\n\n def get_max_timeout(cls):\n    return cls._max_timeout or _get_default_method_timeout() * 10","commit_id":"f89f41fb33fac94f7845856e29be680e7c0634aa"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"940d66a160da225533dbe2c056e5142e7f62055d","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    def reset_timeouts(cls):"},{"line_number":113,"context_line":"        cls._METHOD_TIMEOUTS \u003d _get_default_method_timeouts()"},{"line_number":114,"context_line":"        try:"},{"line_number":115,"context_line":"            delattr(cls, \u0027_max_timeout\u0027)"},{"line_number":116,"context_line":"        except AttributeError:"},{"line_number":117,"context_line":"            pass"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_cfab51d5","line":115,"range":{"start_line":115,"start_character":25,"end_line":115,"end_character":39},"in_reply_to":"fa31d9ce_4df7778c","updated":"2017-02-16 21:48:13.000000000","message":"Done","commit_id":"f89f41fb33fac94f7845856e29be680e7c0634aa"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"dd7ad052599d18bfce330223296fd75c87a77c87","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    def get_max_timeout(cls):"},{"line_number":121,"context_line":"        if hasattr(cls, \u0027_max_timeout\u0027):"},{"line_number":122,"context_line":"            return cls._max_timeout"},{"line_number":123,"context_line":"        return _get_default_method_timeout() * 10"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @classmethod"},{"line_number":126,"context_line":"    def set_max_timeout(cls, max_timeout):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_ad9b9371","line":123,"range":{"start_line":123,"start_character":47,"end_line":123,"end_character":49},"updated":"2017-02-16 16:48:30.000000000","message":"What does this constant mean?","commit_id":"f89f41fb33fac94f7845856e29be680e7c0634aa"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"940d66a160da225533dbe2c056e5142e7f62055d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    def get_max_timeout(cls):"},{"line_number":121,"context_line":"        if hasattr(cls, \u0027_max_timeout\u0027):"},{"line_number":122,"context_line":"            return cls._max_timeout"},{"line_number":123,"context_line":"        return _get_default_method_timeout() * 10"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @classmethod"},{"line_number":126,"context_line":"    def set_max_timeout(cls, max_timeout):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_af953d89","line":123,"range":{"start_line":123,"start_character":47,"end_line":123,"end_character":49},"in_reply_to":"fa31d9ce_ad9b9371","updated":"2017-02-16 21:48:13.000000000","message":"No idea why exactly 10, but it was picked before, see line 137 in the old version of the file.","commit_id":"f89f41fb33fac94f7845856e29be680e7c0634aa"}],"neutron/tests/unit/common/test_rpc.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"dd7ad052599d18bfce330223296fd75c87a77c87","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        self.addCleanup(rpc.cleanup)"},{"line_number":323,"context_line":"        rpc.init(CONF)"},{"line_number":324,"context_line":"        rpc.TRANSPORT \u003d mock.MagicMock()"},{"line_number":325,"context_line":"        rpc.TRANSPORT._send.side_effect \u003d messaging.MessagingTimeout"},{"line_number":326,"context_line":"        target \u003d messaging.Target(version\u003d\u00271.0\u0027, topic\u003d\u0027testing\u0027)"},{"line_number":327,"context_line":"        self.client \u003d rpc.get_client(target)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_0db57f7d","line":324,"range":{"start_line":324,"start_character":8,"end_line":324,"end_character":40},"updated":"2017-02-16 16:48:30.000000000","message":"Not related to this patch: I wonder if this can influence other tests running after this one using the rpc module.","commit_id":"f89f41fb33fac94f7845856e29be680e7c0634aa"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"940d66a160da225533dbe2c056e5142e7f62055d","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        self.addCleanup(rpc.cleanup)"},{"line_number":323,"context_line":"        rpc.init(CONF)"},{"line_number":324,"context_line":"        rpc.TRANSPORT \u003d mock.MagicMock()"},{"line_number":325,"context_line":"        rpc.TRANSPORT._send.side_effect \u003d messaging.MessagingTimeout"},{"line_number":326,"context_line":"        target \u003d messaging.Target(version\u003d\u00271.0\u0027, topic\u003d\u0027testing\u0027)"},{"line_number":327,"context_line":"        self.client \u003d rpc.get_client(target)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_6ff26508","line":324,"range":{"start_line":324,"start_character":8,"end_line":324,"end_character":40},"in_reply_to":"fa31d9ce_0db57f7d","updated":"2017-02-16 21:48:13.000000000","message":"It\u0027s reset by rpc.cleanup that is scheduled in line 322.","commit_id":"f89f41fb33fac94f7845856e29be680e7c0634aa"}]}
