)]}'
{"neutron/api/rpc/handlers/securitygroups_rpc.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"0b58ebd69fd689daeb75fc2fb40f50721943276f","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def security_groups_provider_updated(self, context,"},{"line_number":157,"context_line":"                                         devices_to_update\u003dNone):"},{"line_number":158,"context_line":"        \"\"\"Notify provider updated security groups.\"\"\""},{"line_number":159,"context_line":"        # NOTE(ihrachys) the version here should really be 1.3, but since we"},{"line_number":160,"context_line":"        # don\u0027t support proper version pinning yet, we leave it intact to allow"},{"line_number":161,"context_line":"        # to work with older agents. The reason why we should not require the"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_e6d2de33","line":158,"updated":"2017-02-17 16:03:36.000000000","message":"we need to cleanup this method in future, right?","commit_id":"b75c34df6bcb6b7a0d97aedf4ca80ae7414dfa35"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"92afe0952d6d567b70bd85fb27a4a1bdab48879f","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def security_groups_provider_updated(self, context,"},{"line_number":157,"context_line":"                                         devices_to_update\u003dNone):"},{"line_number":158,"context_line":"        \"\"\"Notify provider updated security groups.\"\"\""},{"line_number":159,"context_line":"        # NOTE(ihrachys) the version here should really be 1.3, but since we"},{"line_number":160,"context_line":"        # don\u0027t support proper version pinning yet, we leave it intact to allow"},{"line_number":161,"context_line":"        # to work with older agents. The reason why we should not require the"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_efa915e1","line":158,"in_reply_to":"fa31d9ce_e6d2de33","updated":"2017-02-17 20:39:27.000000000","message":"Yeah. I\u0027ll add in a note to remove it. We need to leave it in for at least one cycle since the old agents will have the old-style provider rules and need to be notified to retrieve the new ones.","commit_id":"b75c34df6bcb6b7a0d97aedf4ca80ae7414dfa35"}],"neutron/db/securitygroups_rpc_base.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ac9ee6e16acf3b97f0d74e99713edff887a12bc8","unresolved":false,"context_lines":[{"line_number":354,"context_line":"                   \u0027ethertype\u0027: const.IPv6,"},{"line_number":355,"context_line":"                   \u0027protocol\u0027: const.PROTO_NAME_IPV6_ICMP,"},{"line_number":356,"context_line":"                   \u0027source_port_range_min\u0027: const.ICMPV6_TYPE_RA}"},{"line_number":357,"context_line":"        port[\u0027security_group_rules\u0027].append(ra_rule)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def _apply_provider_rule(self, context, ports):"},{"line_number":360,"context_line":"        for port in ports.values():"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_fdf70ff3","line":357,"updated":"2017-02-17 22:08:49.000000000","message":"So the change in behavior here is that we will now add an RA rule even if there is no IPv6 subnet.","commit_id":"b75c34df6bcb6b7a0d97aedf4ca80ae7414dfa35"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"da81525dad9f649862493ad0cdd9990171190276","unresolved":false,"context_lines":[{"line_number":354,"context_line":"                   \u0027ethertype\u0027: const.IPv6,"},{"line_number":355,"context_line":"                   \u0027protocol\u0027: const.PROTO_NAME_IPV6_ICMP,"},{"line_number":356,"context_line":"                   \u0027source_port_range_min\u0027: const.ICMPV6_TYPE_RA}"},{"line_number":357,"context_line":"        port[\u0027security_group_rules\u0027].append(ra_rule)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def _apply_provider_rule(self, context, ports):"},{"line_number":360,"context_line":"        for port in ports.values():"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_b8992522","line":357,"in_reply_to":"da36d5c6_fdf70ff3","updated":"2017-02-17 23:37:06.000000000","message":"I suppose I can check for an IPv6 addr on the port before adding it.","commit_id":"b75c34df6bcb6b7a0d97aedf4ca80ae7414dfa35"}]}