)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"c09a828cd049d6d6311c26e9c44b97872cb4a322","unresolved":false,"context_lines":[{"line_number":10,"context_line":"dumped to the logs repeatedly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is comparing string formats of dictionaries, which should"},{"line_number":13,"context_line":"be safe since the pprint module sorts dictionaries by key first:"},{"line_number":14,"context_line":"https://docs.python.org/2/library/pprint.html"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"TrivialFix"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa31d9ce_b1d3a937","line":13,"updated":"2017-02-13 08:55:44.000000000","message":"It\u0027s actually pprint in this case. Short for \"pretty print\" :)","commit_id":"fb80b6c58845e46d73142b3594d7d31d686a0055"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"8f67f05f0e2f76447343fb946143537231818d35","unresolved":false,"context_lines":[{"line_number":10,"context_line":"dumped to the logs repeatedly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is comparing string formats of dictionaries, which should"},{"line_number":13,"context_line":"be safe since the pprint module sorts dictionaries by key first:"},{"line_number":14,"context_line":"https://docs.python.org/2/library/pprint.html"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"TrivialFix"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa31d9ce_2745bf16","line":13,"range":{"start_line":13,"start_character":18,"end_line":13,"end_character":24},"updated":"2017-02-13 05:03:24.000000000","message":"nit: /s/pprint/print","commit_id":"fb80b6c58845e46d73142b3594d7d31d686a0055"}],"neutron/api/rpc/callbacks/version_manager.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"c09a828cd049d6d6311c26e9c44b97872cb4a322","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        if self._last_report \u003d\u003d debug_dict:"},{"line_number":170,"context_line":"            return"},{"line_number":171,"context_line":"        self._last_report \u003d debug_dict"},{"line_number":172,"context_line":"        LOG.debug(\u0027Tracked resource versions report:\\n\u0027"},{"line_number":173,"context_line":"                  \u0027pushed versions:\\n%(pushed_versions)s\\n\\n\u0027"},{"line_number":174,"context_line":"                  \u0027consumer versions:\\n%(consumer_versions)s\\n\u0027, debug_dict)"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_d1d65d26","line":172,"updated":"2017-02-13 08:55:44.000000000","message":"I did it this way just to make the diff smaller but I can adjust on respin if I need to.","commit_id":"fb80b6c58845e46d73142b3594d7d31d686a0055"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"d6ea5f40403b8e101e0acada256d9c0fd44a9d51","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        format \u003d lambda versions: pprint.pformat(dict(versions), indent\u003d4)"},{"line_number":167,"context_line":"        debug_dict \u003d {\u0027pushed_versions\u0027: format(self._versions),"},{"line_number":168,"context_line":"                      \u0027consumer_versions\u0027: format(self._versions_by_consumer)}"},{"line_number":169,"context_line":"        if self._last_report \u003d\u003d debug_dict:"},{"line_number":170,"context_line":"            return"},{"line_number":171,"context_line":"        self._last_report \u003d debug_dict"},{"line_number":172,"context_line":"        LOG.debug(\u0027Tracked resource versions report:\\n\u0027"},{"line_number":173,"context_line":"                  \u0027pushed versions:\\n%(pushed_versions)s\\n\\n\u0027"},{"line_number":174,"context_line":"                  \u0027consumer versions:\\n%(consumer_versions)s\\n\u0027, debug_dict)"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_bbc70a11","line":172,"range":{"start_line":169,"start_character":8,"end_line":172,"end_character":17},"updated":"2017-02-13 08:10:42.000000000","message":"nit: \u0027if self._last_report !\u003d debug_dict: ..\u0027 would be more readable than \u0027return\u0027 if the middle.","commit_id":"fb80b6c58845e46d73142b3594d7d31d686a0055"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ca33f734b42cabdd217903e72c1a3cd20974f857","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        if self._last_report \u003d\u003d debug_dict:"},{"line_number":170,"context_line":"            return"},{"line_number":171,"context_line":"        self._last_report \u003d debug_dict"},{"line_number":172,"context_line":"        LOG.debug(\u0027Tracked resource versions report:\\n\u0027"},{"line_number":173,"context_line":"                  \u0027pushed versions:\\n%(pushed_versions)s\\n\\n\u0027"},{"line_number":174,"context_line":"                  \u0027consumer versions:\\n%(consumer_versions)s\\n\u0027, debug_dict)"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_420536ba","line":172,"in_reply_to":"fa31d9ce_d1d65d26","updated":"2017-02-13 10:59:50.000000000","message":"I\u0027m ok with either way, the change looks good :) thanks for addressing this.","commit_id":"fb80b6c58845e46d73142b3594d7d31d686a0055"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"546a0e12ebedbb817be068e68af0a30534841e6d","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    known by one or more consumers."},{"line_number":60,"context_line":"    \"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    _last_report \u003d None"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def __init__(self):"},{"line_number":65,"context_line":"        # Initialize with the local (server) versions, as we always want"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_1d3723e4","line":62,"range":{"start_line":62,"start_character":4,"end_line":62,"end_character":23},"updated":"2017-02-13 11:15:55.000000000","message":"The class description above seems to imply instances of this class are passed into multiple resources and if this is a static variable it will only be printed on the first resource to call report.\nThough I may be misunderstanding it.","commit_id":"31ff5442dd155713c2879011fd7f973a2348706f"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d3587e6a26e8521da2b7c704a5acd61afe820b26","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    known by one or more consumers."},{"line_number":60,"context_line":"    \"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    _last_report \u003d None"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def __init__(self):"},{"line_number":65,"context_line":"        # Initialize with the local (server) versions, as we always want"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_320cdf40","line":62,"updated":"2017-02-14 10:14:20.000000000","message":"good point. this may not be safe for the future if we have multiple uses of this","commit_id":"31ff5442dd155713c2879011fd7f973a2348706f"}]}
