)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"93177d3fd0955f9af575bc3a88280d090ef3c275","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Reedip \u003creedip.banerjee@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-13 19:02:13 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow port creation/updation by shared nw owners"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently if a new port is created by a tenant with whom"},{"line_number":10,"context_line":"the network is shared ( tenant is not the owner but has"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa31d9ce_68e122fe","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":48},"updated":"2017-02-13 19:15:44.000000000","message":"Consider changing this to:\n\nAllow port create/update by shared network owner\n\nThis way, the title is clearer and it still fits within the maximum length for a title line","commit_id":"d050183fd85cfbe3dec4124a8f40eeb89d0e4d66"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"560ce58151d9a3070432750907e926cc662fc582","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Reedip \u003creedip.banerjee@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-13 19:02:13 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow port creation/updation by shared nw owners"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently if a new port is created by a tenant with whom"},{"line_number":10,"context_line":"the network is shared ( tenant is not the owner but has"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa31d9ce_dd8e4f78","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":48},"in_reply_to":"fa31d9ce_68e122fe","updated":"2017-09-21 05:31:06.000000000","message":"Will do !","commit_id":"d050183fd85cfbe3dec4124a8f40eeb89d0e4d66"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"1f56c7ccfa4446f194329a10f66083b80274a270","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow port create/update by shared nw owners"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently if a new port is created by a tenant with whom"},{"line_number":10,"context_line":"the network is shared ( tenant is not the owner but has"},{"line_number":11,"context_line":"network shared via RBAC ) , the port is allocated on the default"},{"line_number":12,"context_line":"subnet. This patch allows the tenant to create/update a port on"},{"line_number":13,"context_line":"a subnet which the tenant requires."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da36d5c6_80c69a47","line":10,"updated":"2017-02-27 21:04:30.000000000","message":"Remove the space between the ( and tenant","commit_id":"60874d1034beccfa3f8bb18c2bf1d2d6d6b8f2f1"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"1f56c7ccfa4446f194329a10f66083b80274a270","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently if a new port is created by a tenant with whom"},{"line_number":10,"context_line":"the network is shared ( tenant is not the owner but has"},{"line_number":11,"context_line":"network shared via RBAC ) , the port is allocated on the default"},{"line_number":12,"context_line":"subnet. This patch allows the tenant to create/update a port on"},{"line_number":13,"context_line":"a subnet which the tenant requires."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da36d5c6_c0c0922d","line":11,"updated":"2017-02-27 21:04:30.000000000","message":"Remove the space between RBAC and ) and ) and comma.","commit_id":"60874d1034beccfa3f8bb18c2bf1d2d6d6b8f2f1"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"1f56c7ccfa4446f194329a10f66083b80274a270","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the network is shared ( tenant is not the owner but has"},{"line_number":11,"context_line":"network shared via RBAC ) , the port is allocated on the default"},{"line_number":12,"context_line":"subnet. This patch allows the tenant to create/update a port on"},{"line_number":13,"context_line":"a subnet which the tenant requires."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1046f6b13e68b1e274cc8f62f5b30aa5f8d71cdc"},{"line_number":16,"context_line":"Closes-Bug: #1543756"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da36d5c6_40eca28f","line":13,"updated":"2017-02-27 21:04:30.000000000","message":"This patch allows a tenant to create/update a port on subnets of a shared network owned by another tenant.","commit_id":"60874d1034beccfa3f8bb18c2bf1d2d6d6b8f2f1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"50d426dfca7631e026fd764f5a55a5cd2f27d0e2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"network shared via RBAC) , the port is allocated on the default"},{"line_number":12,"context_line":"subnet. This patch allows the tenant to create/update a port on"},{"line_number":13,"context_line":"a subnet which is actually a part of a shared network, owned by"},{"line_number":14,"context_line":"another tenant."},{"line_number":15,"context_line":"Tempest test in [1]"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1]: https://review.openstack.org/521413"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"ff82abbf_84b674d9","line":14,"updated":"2017-11-20 18:19:38.000000000","message":"shoudn\u0027t You add release not for that? IMO it\u0027s worth to inform users that default policy.json will change","commit_id":"b474f67faa0836baf8be871aabb4aa2d91258c8e"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"f48725722e0a001cf88a8bfdc5e73116ccab03bc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"network shared via RBAC) , the port is allocated on the default"},{"line_number":12,"context_line":"subnet. This patch allows the tenant to create/update a port on"},{"line_number":13,"context_line":"a subnet which is actually a part of a shared network, owned by"},{"line_number":14,"context_line":"another tenant."},{"line_number":15,"context_line":"Tempest test in [1]"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1]: https://review.openstack.org/521413"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"ff82abbf_be085d28","line":14,"in_reply_to":"ff82abbf_84b674d9","updated":"2017-11-21 03:34:33.000000000","message":"Done","commit_id":"b474f67faa0836baf8be871aabb4aa2d91258c8e"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"af4b32c864f753b6c71b1fabcec73c9129455f52","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the network is shared (tenant is not the owner but has"},{"line_number":11,"context_line":"network shared via RBAC) , the port is allocated on the default"},{"line_number":12,"context_line":"subnet. This patch allows the tenant to create/update a port on"},{"line_number":13,"context_line":"a subnet which is actually a part of a shared network, owned by"},{"line_number":14,"context_line":"another tenant."},{"line_number":15,"context_line":"Tempest test in [1]"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"df87a7cf_aebe27d2","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":2},"updated":"2017-12-11 20:13:38.000000000","message":"any","commit_id":"a0d46c78404672bea64549b9ff59e4ecd9fe4c2a"}],"etc/policy.json":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"43d8517ff3ab88f38cee9c0ae61b4625b713d28c","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    \"create_port:device_owner\": \"not rule:network_device or rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":74,"context_line":"    \"create_port:mac_address\": \"rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":75,"context_line":"    \"create_port:fixed_ips:ip_address\": \"rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":76,"context_line":"    \"create_port:fixed_ips:subnet_id\": \"rule:context_is_advsvc or rule:admin_or_network_owner or rule:shared\","},{"line_number":77,"context_line":"    \"create_port:port_security_enabled\": \"rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":78,"context_line":"    \"create_port:binding:host_id\": \"rule:admin_only\","},{"line_number":79,"context_line":"    \"create_port:binding:profile\": \"rule:admin_only\","}],"source_content_type":"application/json","patch_set":2,"id":"fa31d9ce_1f31d005","line":76,"updated":"2017-02-13 14:18:50.000000000","message":"Similar to the comment below. I don\u0027t think you need to specify a policy for \u0027subnet_id\u0027 here and it will just use the same as \u0027create_port\u0027, which is that we want anyone to be able to specify the subnet_id of the create request.","commit_id":"4c60cba6dee8d310fd8cd41739a0b06ecb89b528"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"41ea38a2aef6440ba78fac22e4d63570ac168154","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    \"create_port:device_owner\": \"not rule:network_device or rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":74,"context_line":"    \"create_port:mac_address\": \"rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":75,"context_line":"    \"create_port:fixed_ips:ip_address\": \"rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":76,"context_line":"    \"create_port:fixed_ips:subnet_id\": \"rule:context_is_advsvc or rule:admin_or_network_owner or rule:shared\","},{"line_number":77,"context_line":"    \"create_port:port_security_enabled\": \"rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":78,"context_line":"    \"create_port:binding:host_id\": \"rule:admin_only\","},{"line_number":79,"context_line":"    \"create_port:binding:profile\": \"rule:admin_only\","}],"source_content_type":"application/json","patch_set":2,"id":"fa31d9ce_4d5b9087","line":76,"in_reply_to":"fa31d9ce_1f31d005","updated":"2017-02-13 19:01:19.000000000","message":"I was thinking that the port should only be created if the network is shared with the owner. This allows the tenant with whom the network is shared to create the port, but prevent others from creating a port.","commit_id":"4c60cba6dee8d310fd8cd41739a0b06ecb89b528"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"43d8517ff3ab88f38cee9c0ae61b4625b713d28c","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    \"update_port:device_owner\": \"not rule:network_device or rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":90,"context_line":"    \"update_port:mac_address\": \"rule:admin_only or rule:context_is_advsvc\","},{"line_number":91,"context_line":"    \"update_port:fixed_ips:ip_address\": \"rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":92,"context_line":"    \"update_port:fixed_ips:subnet_id\": \"rule:context_is_advsvc or rule:admin_or_network_owner or rule:shared\","},{"line_number":93,"context_line":"    \"update_port:port_security_enabled\": \"rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":94,"context_line":"    \"update_port:binding:host_id\": \"rule:admin_only\","},{"line_number":95,"context_line":"    \"update_port:binding:profile\": \"rule:admin_only\","}],"source_content_type":"application/json","patch_set":2,"id":"fa31d9ce_3ff9344e","line":92,"updated":"2017-02-13 14:18:50.000000000","message":"I think you might not even need to specify the policy for subnet_id here and it will inherit the default of \"update_port\" which is the one we want.","commit_id":"4c60cba6dee8d310fd8cd41739a0b06ecb89b528"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"41ea38a2aef6440ba78fac22e4d63570ac168154","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    \"update_port:device_owner\": \"not rule:network_device or rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":90,"context_line":"    \"update_port:mac_address\": \"rule:admin_only or rule:context_is_advsvc\","},{"line_number":91,"context_line":"    \"update_port:fixed_ips:ip_address\": \"rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":92,"context_line":"    \"update_port:fixed_ips:subnet_id\": \"rule:context_is_advsvc or rule:admin_or_network_owner or rule:shared\","},{"line_number":93,"context_line":"    \"update_port:port_security_enabled\": \"rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":94,"context_line":"    \"update_port:binding:host_id\": \"rule:admin_only\","},{"line_number":95,"context_line":"    \"update_port:binding:profile\": \"rule:admin_only\","}],"source_content_type":"application/json","patch_set":2,"id":"fa31d9ce_ad508c5f","line":92,"in_reply_to":"fa31d9ce_3ff9344e","updated":"2017-02-13 19:01:19.000000000","message":"Agreed, removing this.","commit_id":"4c60cba6dee8d310fd8cd41739a0b06ecb89b528"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a38d10bb95691634a1083233d835bae3d11396f4","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    \"update_port\": \"rule:admin_or_owner or rule:context_is_advsvc\","},{"line_number":90,"context_line":"    \"update_port:device_owner\": \"not rule:network_device or rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":91,"context_line":"    \"update_port:mac_address\": \"rule:admin_only or rule:context_is_advsvc\","},{"line_number":92,"context_line":"    \"update_port:fixed_ips:ip_address\": \"rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":93,"context_line":"    \"update_port:port_security_enabled\": \"rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":94,"context_line":"    \"update_port:binding:host_id\": \"rule:admin_only\","},{"line_number":95,"context_line":"    \"update_port:binding:profile\": \"rule:admin_only\","}],"source_content_type":"application/json","patch_set":19,"id":"df87a7cf_ecd7654a","line":92,"updated":"2017-12-11 13:15:06.000000000","message":"Do you need a rule for update_port:fixed_ips:subnet_id?\nRegular users can update fixed_ips.","commit_id":"8eabddd76f5e8d201618d0b1334607669f4029ed"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e7e1a5094c830d1a08263884a270dcac0f583271","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    \"update_port\": \"rule:admin_or_owner or rule:context_is_advsvc\","},{"line_number":90,"context_line":"    \"update_port:device_owner\": \"not rule:network_device or rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":91,"context_line":"    \"update_port:mac_address\": \"rule:admin_only or rule:context_is_advsvc\","},{"line_number":92,"context_line":"    \"update_port:fixed_ips:ip_address\": \"rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":93,"context_line":"    \"update_port:port_security_enabled\": \"rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":94,"context_line":"    \"update_port:binding:host_id\": \"rule:admin_only\","},{"line_number":95,"context_line":"    \"update_port:binding:profile\": \"rule:admin_only\","}],"source_content_type":"application/json","patch_set":19,"id":"df87a7cf_e5bd3202","line":92,"in_reply_to":"df87a7cf_193d288e","updated":"2017-12-11 18:00:03.000000000","message":"Confirmed it. You are right.","commit_id":"8eabddd76f5e8d201618d0b1334607669f4029ed"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b6e9fe7ef3fa868f3a082a4cac85cc8cb253e641","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    \"update_port\": \"rule:admin_or_owner or rule:context_is_advsvc\","},{"line_number":90,"context_line":"    \"update_port:device_owner\": \"not rule:network_device or rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":91,"context_line":"    \"update_port:mac_address\": \"rule:admin_only or rule:context_is_advsvc\","},{"line_number":92,"context_line":"    \"update_port:fixed_ips:ip_address\": \"rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":93,"context_line":"    \"update_port:port_security_enabled\": \"rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":94,"context_line":"    \"update_port:binding:host_id\": \"rule:admin_only\","},{"line_number":95,"context_line":"    \"update_port:binding:profile\": \"rule:admin_only\","}],"source_content_type":"application/json","patch_set":19,"id":"df87a7cf_193d288e","line":92,"in_reply_to":"df87a7cf_5916504b","updated":"2017-12-11 15:41:43.000000000","message":"I think I have addressed it in the next PS( PS#20)","commit_id":"8eabddd76f5e8d201618d0b1334607669f4029ed"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"88288a1b491080820f0ea17a0f52b0f7d3457dac","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    \"update_port\": \"rule:admin_or_owner or rule:context_is_advsvc\","},{"line_number":90,"context_line":"    \"update_port:device_owner\": \"not rule:network_device or rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":91,"context_line":"    \"update_port:mac_address\": \"rule:admin_only or rule:context_is_advsvc\","},{"line_number":92,"context_line":"    \"update_port:fixed_ips:ip_address\": \"rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":93,"context_line":"    \"update_port:port_security_enabled\": \"rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":94,"context_line":"    \"update_port:binding:host_id\": \"rule:admin_only\","},{"line_number":95,"context_line":"    \"update_port:binding:profile\": \"rule:admin_only\","}],"source_content_type":"application/json","patch_set":19,"id":"df87a7cf_5916504b","line":92,"in_reply_to":"df87a7cf_ecd7654a","updated":"2017-12-11 15:36:27.000000000","message":"this comment is not addressed yet.","commit_id":"8eabddd76f5e8d201618d0b1334607669f4029ed"}],"neutron/tests/etc/policy.json":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a38d10bb95691634a1083233d835bae3d11396f4","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    \"update_port\": \"rule:admin_or_owner or rule:context_is_advsvc\","},{"line_number":90,"context_line":"    \"update_port:device_owner\": \"not rule:network_device or rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":91,"context_line":"    \"update_port:mac_address\": \"rule:admin_only or rule:context_is_advsvc\","},{"line_number":92,"context_line":"    \"update_port:fixed_ips:ip_address\": \"rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":93,"context_line":"    \"update_port:port_security_enabled\": \"rule:context_is_advsvc or rule:admin_or_network_owner\","},{"line_number":94,"context_line":"    \"update_port:binding:host_id\": \"rule:admin_only\","},{"line_number":95,"context_line":"    \"update_port:binding:profile\": \"rule:admin_only\","}],"source_content_type":"application/json","patch_set":19,"id":"df87a7cf_accdddb7","line":92,"updated":"2017-12-11 13:15:06.000000000","message":"ditto","commit_id":"8eabddd76f5e8d201618d0b1334607669f4029ed"}],"neutron/tests/tempest/api/test_ports.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"00459cb552fbc014dd3f4182166eba41bd3fd6bf","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class PortsTestJSON(base.BaseNetworkTest):"},{"line_number":22,"context_line":"    "},{"line_number":23,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027alt\u0027]"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_99d035f8","line":22,"updated":"2017-02-14 20:33:30.000000000","message":"whitespaces here","commit_id":"1db8fe59cc595cee5262c86c168ba8c18314ae1b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"00459cb552fbc014dd3f4182166eba41bd3fd6bf","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            object_type\u003d\u0027network\u0027, object_id\u003dself.network[\u0027id\u0027],"},{"line_number":69,"context_line":"            action\u003d\u0027access_as_shared\u0027,"},{"line_number":70,"context_line":"            target_tenant\u003dself.alt_client.tenant_id)"},{"line_number":71,"context_line":"        fixed_ip \u003d [{\u0027subnet_id\u0027:subnet[\u0027id\u0027]}]"},{"line_number":72,"context_line":"        body \u003d self.create_port(self.network, fixed_ips\u003dfixed_ip)"},{"line_number":73,"context_line":"        subnet \u003d body[\u0027port\u0027][\u0027fixed_ips\u0027][\u0027subnet_id\u0027]"},{"line_number":74,"context_line":"        self.assertEqual(subnet[\u0027id\u0027], subnet)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_39b4a980","line":71,"range":{"start_line":71,"start_character":33,"end_line":71,"end_character":34},"updated":"2017-02-14 20:33:30.000000000","message":"missing space before this \u0027s\u0027","commit_id":"1db8fe59cc595cee5262c86c168ba8c18314ae1b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"00459cb552fbc014dd3f4182166eba41bd3fd6bf","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            target_tenant\u003dself.alt_client.tenant_id)"},{"line_number":71,"context_line":"        fixed_ip \u003d [{\u0027subnet_id\u0027:subnet[\u0027id\u0027]}]"},{"line_number":72,"context_line":"        body \u003d self.create_port(self.network, fixed_ips\u003dfixed_ip)"},{"line_number":73,"context_line":"        subnet \u003d body[\u0027port\u0027][\u0027fixed_ips\u0027][\u0027subnet_id\u0027]"},{"line_number":74,"context_line":"        self.assertEqual(subnet[\u0027id\u0027], subnet)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @test.idempotent_id(\u0027539fbefe-fb36-48aa-9a53-8c5fbd44e492\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_59707ddc","line":73,"range":{"start_line":73,"start_character":8,"end_line":73,"end_character":14},"updated":"2017-02-14 20:33:30.000000000","message":"I think subnet_id would be better","commit_id":"1db8fe59cc595cee5262c86c168ba8c18314ae1b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"00459cb552fbc014dd3f4182166eba41bd3fd6bf","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        fixed_ip \u003d [{\u0027subnet_id\u0027:subnet[\u0027id\u0027]}]"},{"line_number":72,"context_line":"        body \u003d self.create_port(self.network, fixed_ips\u003dfixed_ip)"},{"line_number":73,"context_line":"        subnet \u003d body[\u0027port\u0027][\u0027fixed_ips\u0027][\u0027subnet_id\u0027]"},{"line_number":74,"context_line":"        self.assertEqual(subnet[\u0027id\u0027], subnet)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @test.idempotent_id(\u0027539fbefe-fb36-48aa-9a53-8c5fbd44e492\u0027)"},{"line_number":77,"context_line":"    @test.requires_ext(extension\u003d\"dns-integration\","}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_997675d5","line":74,"range":{"start_line":74,"start_character":39,"end_line":74,"end_character":45},"updated":"2017-02-14 20:33:30.000000000","message":"ditto","commit_id":"1db8fe59cc595cee5262c86c168ba8c18314ae1b"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"1f56c7ccfa4446f194329a10f66083b80274a270","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class PortsTestJSON(base.BaseNetworkTest):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027alt\u0027]"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"da36d5c6_a0755e33","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":0},"updated":"2017-02-27 21:04:30.000000000","message":"Remove the blank line.","commit_id":"60874d1034beccfa3f8bb18c2bf1d2d6d6b8f2f1"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"dcd022f8bbaa6465e6d6a5aee7ab7c48e331b4bd","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class PortsTestJSON(base.BaseNetworkTest):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027alt\u0027]"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_8ec40d41","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":0},"in_reply_to":"da36d5c6_a0755e33","updated":"2017-02-28 21:09:29.000000000","message":"Frankly, I don\u0027t see anything wrong with the blank line. In fact, the admin api test base class has exactly this: https://github.com/openstack/neutron/blob/master/neutron/tests/tempest/api/base.py#L421","commit_id":"60874d1034beccfa3f8bb18c2bf1d2d6d6b8f2f1"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"dcd022f8bbaa6465e6d6a5aee7ab7c48e331b4bd","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            action\u003d\u0027access_as_shared\u0027,"},{"line_number":70,"context_line":"            target_tenant\u003dself.alt_client.tenant_id)"},{"line_number":71,"context_line":"        fixed_ip \u003d [{\u0027subnet_id\u0027: subnet[\u0027id\u0027]}]"},{"line_number":72,"context_line":"        body \u003d self.create_port(self.network, fixed_ips\u003dfixed_ip)"},{"line_number":73,"context_line":"        subnet_id \u003d body[\u0027port\u0027][\u0027fixed_ips\u0027][\u0027subnet_id\u0027]"},{"line_number":74,"context_line":"        self.assertEqual(subnet[\u0027id\u0027], subnet_id)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_4ece9584","line":72,"range":{"start_line":72,"start_character":20,"end_line":72,"end_character":31},"updated":"2017-02-28 21:09:29.000000000","message":"This method is returning body[\u0027port\u0027]: https://github.com/openstack/neutron/blob/master/neutron/tests/tempest/api/base.py#L308. That is why L73 fails with KeyError: \u0027port\u0027","commit_id":"60874d1034beccfa3f8bb18c2bf1d2d6d6b8f2f1"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"5d76cda7e9d783b2a53408e7f69773b74e93cb96","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @decorators.idempotent_id(\u0027faf3d558-d53f-4d61-b668-7ac4c9482da8\u0027)"},{"line_number":65,"context_line":"    @test.requires_ext(extension\u003d\"rbac-policies\", service\u003d\"network\")"},{"line_number":66,"context_line":"    def test_create_port_other_tenant(self):"},{"line_number":67,"context_line":"        subnet \u003d self.create_subnet(self.network, enable_dhcp\u003dFalse)"},{"line_number":68,"context_line":"        self.client.create_rbac_policy("},{"line_number":69,"context_line":"            object_type\u003d\u0027network\u0027, object_id\u003dself.network[\u0027id\u0027],"},{"line_number":70,"context_line":"            action\u003d\u0027access_as_shared\u0027,"},{"line_number":71,"context_line":"            target_tenant\u003dself.alt_client.tenant_id)"},{"line_number":72,"context_line":"        fixed_ip \u003d [{\u0027subnet_id\u0027: subnet[\u0027id\u0027]}]"},{"line_number":73,"context_line":"        body \u003d self.create_port(self.network, fixed_ips\u003dfixed_ip)"},{"line_number":74,"context_line":"        subnet_id \u003d body[\u0027fixed_ips\u0027][\u0027subnet_id\u0027]"},{"line_number":75,"context_line":"        self.assertEqual(subnet[\u0027id\u0027], subnet_id)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @decorators.idempotent_id(\u0027539fbefe-fb36-48aa-9a53-8c5fbd44e492\u0027)"},{"line_number":78,"context_line":"    @test.requires_ext(extension\u003d\"dns-integration\","}],"source_content_type":"text/x-python","patch_set":8,"id":"ba2be162_7f7b1abe","line":75,"range":{"start_line":66,"start_character":0,"end_line":75,"end_character":49},"updated":"2017-03-06 15:49:56.000000000","message":"Can we get some additional tests to verify the failure cases? Such as a test which attempts to use a specific IP address. And similar tests for updating the port.","commit_id":"48835689b71e90ab686572d1877c63af2127bd6e"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6b1b29183c2e7155c3dbfc820f3782ec870a4a73","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @decorators.idempotent_id(\u0027faf3d558-d53f-4d61-b668-7ac4c9482da8\u0027)"},{"line_number":65,"context_line":"    @test.requires_ext(extension\u003d\"rbac-policies\", service\u003d\"network\")"},{"line_number":66,"context_line":"    def test_create_port_other_tenant(self):"},{"line_number":67,"context_line":"        subnet \u003d self.create_subnet(self.network, enable_dhcp\u003dFalse)"},{"line_number":68,"context_line":"        self.client.create_rbac_policy("},{"line_number":69,"context_line":"            object_type\u003d\u0027network\u0027, object_id\u003dself.network[\u0027id\u0027],"},{"line_number":70,"context_line":"            action\u003d\u0027access_as_shared\u0027,"},{"line_number":71,"context_line":"            target_tenant\u003dself.alt_client.tenant_id)"},{"line_number":72,"context_line":"        fixed_ip \u003d [{\u0027subnet_id\u0027: subnet[\u0027id\u0027]}]"},{"line_number":73,"context_line":"        body \u003d self.create_port(self.network, fixed_ips\u003dfixed_ip)"},{"line_number":74,"context_line":"        subnet_id \u003d body[\u0027fixed_ips\u0027][\u0027subnet_id\u0027]"},{"line_number":75,"context_line":"        self.assertEqual(subnet[\u0027id\u0027], subnet_id)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @decorators.idempotent_id(\u0027539fbefe-fb36-48aa-9a53-8c5fbd44e492\u0027)"},{"line_number":78,"context_line":"    @test.requires_ext(extension\u003d\"dns-integration\","}],"source_content_type":"text/x-python","patch_set":8,"id":"ba2be162_e844b31c","line":75,"range":{"start_line":66,"start_character":0,"end_line":75,"end_character":49},"in_reply_to":"ba2be162_7f7b1abe","updated":"2017-03-06 16:12:42.000000000","message":"Sure John, I will put across 2 more test cases tomorrow morning.\nThanks for your feedback","commit_id":"48835689b71e90ab686572d1877c63af2127bd6e"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"af846934e285a03629f2cbbaf8f207770015d5f2","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            exceptions.BadRequest,"},{"line_number":76,"context_line":"            self.create_port,"},{"line_number":77,"context_line":"            self.network, fixed_ips\u003dfixed_ip,"},{"line_number":78,"context_line":"            tenant_id\u003dself.alt_client.tenant_id)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @decorators.idempotent_id(\u0027faf3d558-d53f-4d61-b668-7ac4c9482da8\u0027)"},{"line_number":81,"context_line":"    @test.requires_ext(extension\u003d\"rbac-policies\", service\u003d\"network\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"ffe62b97_e5ac1037","line":78,"updated":"2017-03-30 09:00:46.000000000","message":"This isn\u0027t doing quite what we want. Calling self.create_port will use the regular self.client client. We want to call create_port directly on self.alt_client so we are authenticated as the alt user, not merely setting the tenant_id.","commit_id":"04342b97d9f3e43cb5d02b8cb4f5075f7ff71d09"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"83b73867ba6fea58feea1b2af71ff1f21e471a49","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            target_tenant\u003dself.alt_client.tenant_id)"},{"line_number":73,"context_line":"        fixed_ip \u003d [{\u0027ip_address\u0027: \u002710.0.0.11\u0027}]"},{"line_number":74,"context_line":"        self.assertRaises("},{"line_number":75,"context_line":"            exceptions.BadRequest,"},{"line_number":76,"context_line":"            self.alt_client.create_port,"},{"line_number":77,"context_line":"            self.network, fixed_ips\u003dfixed_ip,"},{"line_number":78,"context_line":"            tenant_id\u003dself.alt_client.tenant_id)"}],"source_content_type":"text/x-python","patch_set":17,"id":"1f485f77_ffc26352","line":75,"updated":"2017-11-19 12:34:23.000000000","message":"are You sure that BadRequest will be raised for proper reason? It looks for me that self.network don\u0027t have any subnet so creation of port with given ip_address will return like \"Invalid input for operation: IP allocation requires subnets for network.\"","commit_id":"06643ea3c6598e0162a7ffc27a790b8ba0339cc5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7335fb9d80f0c895f50c504980a48ed6ccedda8d","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            target_tenant\u003dself.alt_client.tenant_id)"},{"line_number":73,"context_line":"        fixed_ip \u003d [{\u0027ip_address\u0027: \u002710.0.0.11\u0027}]"},{"line_number":74,"context_line":"        self.assertRaises("},{"line_number":75,"context_line":"            exceptions.BadRequest,"},{"line_number":76,"context_line":"            self.alt_client.create_port,"},{"line_number":77,"context_line":"            self.network, fixed_ips\u003dfixed_ip,"},{"line_number":78,"context_line":"            tenant_id\u003dself.alt_client.tenant_id)"}],"source_content_type":"text/x-python","patch_set":17,"id":"ff82abbf_a575c8fc","line":75,"in_reply_to":"1f485f77_ffc26352","updated":"2017-11-21 03:23:00.000000000","message":"Wouldnt the RBAC be hit first ?","commit_id":"06643ea3c6598e0162a7ffc27a790b8ba0339cc5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6838225e321a8df25ac833f6d35eac1707455c0b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            target_tenant\u003dself.alt_client.tenant_id)"},{"line_number":73,"context_line":"        fixed_ip \u003d [{\u0027ip_address\u0027: \u002710.0.0.11\u0027}]"},{"line_number":74,"context_line":"        self.assertRaises("},{"line_number":75,"context_line":"            exceptions.BadRequest,"},{"line_number":76,"context_line":"            self.alt_client.create_port,"},{"line_number":77,"context_line":"            self.network, fixed_ips\u003dfixed_ip,"},{"line_number":78,"context_line":"            tenant_id\u003dself.alt_client.tenant_id)"}],"source_content_type":"text/x-python","patch_set":17,"id":"ff82abbf_7251a4d8","line":75,"in_reply_to":"ff82abbf_a575c8fc","updated":"2017-11-21 08:05:54.000000000","message":"should we rely on such order only? IMHO it should be done in way that we can be sure reason of why it fails.","commit_id":"06643ea3c6598e0162a7ffc27a790b8ba0339cc5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"c690c3a50be6d5b581686e3971dfc8aa3ae5384a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    @decorators.idempotent_id(\u0027faf3d558-d53f-4d61-b668-7ac4c9482da8\u0027)"},{"line_number":81,"context_line":"    @test.requires_ext(extension\u003d\"rbac-policies\", service\u003d\"network\")"},{"line_number":82,"context_line":"    def test_create_port_with_subnet_other_tenant(self):"},{"line_number":83,"context_line":"        network \u003d cls.create_shared_network()"},{"line_number":84,"context_line":"        subnet \u003d self.create_subnet(network, enable_dhcp\u003dFalse)"},{"line_number":85,"context_line":"        fixed_ip \u003d [{\u0027subnet_id\u0027: subnet[\u0027id\u0027]}]"},{"line_number":86,"context_line":"        body \u003d self.create_port(self.network, fixed_ips\u003dfixed_ip,"}],"source_content_type":"text/x-python","patch_set":17,"id":"1f485f77_41c40c40","line":83,"range":{"start_line":83,"start_character":18,"end_line":83,"end_character":21},"updated":"2017-11-18 00:50:18.000000000","message":"This has to be self","commit_id":"06643ea3c6598e0162a7ffc27a790b8ba0339cc5"}],"releasenotes/notes/allow_port_create_update_shared_owners-2a57b1c72d91ace2.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d634667ffb1a1d510d42f8a42bb563cce4a5987f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Tenants who can access shared networks, can now create/update"},{"line_number":5,"context_line":"    ports on a specified subnet instead of the default subnet."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"df87a7cf_d6b78ff4","line":5,"updated":"2017-12-11 15:23:07.000000000","message":"Maybe it is worth to mentions that this is change of default behavior but it can be changed via policy.json?","commit_id":"2fc6e4696dfdf41ec3d5cbaa4dac8c61d0d37b19"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6db0490121ce5ff0a4316e0daa03c77c37aa8d73","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Tenants who can access shared networks, can now create/update"},{"line_number":5,"context_line":"    ports on a specified subnet instead of the default subnet."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"df87a7cf_0515b6e4","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"updated":"2017-12-11 18:04:31.000000000","message":"upgrade might be a better section because it affect the existing behavior.","commit_id":"a0d46c78404672bea64549b9ff59e4ecd9fe4c2a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c53b873b1e8cc7ad0274f77389c5b6719eb6b141","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Tenants who can access shared networks, can now create/update"},{"line_number":5,"context_line":"    ports on a specified subnet instead of the default subnet."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"df87a7cf_081b8bc9","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"in_reply_to":"df87a7cf_0515b6e4","updated":"2017-12-11 19:11:03.000000000","message":"I still think Feature would be useful.\nThis is not an upgrade related change, is it?\n\nAny reasons why you believe this would be suitable in upgrade?\nOne reason which I think may be because previously users cannot do this change, now they can.\nBut then again, any user updating from , say , Pike to Queens, wont have this feature enabled in their customized policy.json file, right?","commit_id":"a0d46c78404672bea64549b9ff59e4ecd9fe4c2a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6db0490121ce5ff0a4316e0daa03c77c37aa8d73","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Tenants who can access shared networks, can now create/update"},{"line_number":5,"context_line":"    ports on a specified subnet instead of the default subnet."},{"line_number":6,"context_line":"    This is a default behavior and can be changed by modifying policy.json"},{"line_number":7,"context_line":"    file."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"df87a7cf_6526026b","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":74},"updated":"2017-12-11 18:04:31.000000000","message":"How about  \"This is a change in the default policy and you can change it by modifying policy.json file\"?","commit_id":"a0d46c78404672bea64549b9ff59e4ecd9fe4c2a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c53b873b1e8cc7ad0274f77389c5b6719eb6b141","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Tenants who can access shared networks, can now create/update"},{"line_number":5,"context_line":"    ports on a specified subnet instead of the default subnet."},{"line_number":6,"context_line":"    This is a default behavior and can be changed by modifying policy.json"},{"line_number":7,"context_line":"    file."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"df87a7cf_6881f7c2","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":74},"in_reply_to":"df87a7cf_6526026b","updated":"2017-12-11 19:11:03.000000000","message":"I think the default behavior is ok.\nBut I can change the second part of the release note.","commit_id":"a0d46c78404672bea64549b9ff59e4ecd9fe4c2a"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"af4b32c864f753b6c71b1fabcec73c9129455f52","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Tenants who can access shared networks, can now create/update"},{"line_number":5,"context_line":"    ports on a specified subnet instead of the default subnet."},{"line_number":6,"context_line":"    This is a default behavior and can be changed by modifying policy.json"},{"line_number":7,"context_line":"    file."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"df87a7cf_8eac839f","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":74},"in_reply_to":"df87a7cf_6881f7c2","updated":"2017-12-11 20:13:38.000000000","message":"How about:\n\nThis is now the default behavior and....","commit_id":"a0d46c78404672bea64549b9ff59e4ecd9fe4c2a"}]}
