)]}'
{"neutron/tests/fullstack/test_securitygroup.py":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"00cf98cce3bcc1e7c78b5fe4298b97ff1b6a377a","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                body\u003d{\u0027port\u0027: {\u0027port_security_enabled\u0027: True,"},{"line_number":172,"context_line":"                               \u0027security_groups\u0027: [sgs[sg][\u0027id\u0027]]}})"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        # 1. check if connection from elsewhere is blocked"},{"line_number":175,"context_line":"        netcat \u003d net_helpers.NetcatTester("},{"line_number":176,"context_line":"            vms[2].namespace, vms[0].namespace, vms[0].ip, 3333,"},{"line_number":177,"context_line":"            net_helpers.NetcatTester.TCP)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_061dfdbc","line":174,"range":{"start_line":174,"start_character":8,"end_line":174,"end_character":12},"updated":"2017-02-13 17:16:38.000000000","message":"Since you changed order, may you switch comments on L106 and L107?","commit_id":"2ff2cf9ddb16e03af5d23e7e1a8bdf79530cb155"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a1f385d99699be0b46cc584ce31ebdf0e0b9df79","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                body\u003d{\u0027port\u0027: {\u0027port_security_enabled\u0027: True,"},{"line_number":172,"context_line":"                               \u0027security_groups\u0027: [sgs[sg][\u0027id\u0027]]}})"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        # 1. check if connection from elsewhere is blocked"},{"line_number":175,"context_line":"        netcat \u003d net_helpers.NetcatTester("},{"line_number":176,"context_line":"            vms[2].namespace, vms[0].namespace, vms[0].ip, 3333,"},{"line_number":177,"context_line":"            net_helpers.NetcatTester.TCP)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_461c5577","line":174,"range":{"start_line":174,"start_character":8,"end_line":174,"end_character":12},"in_reply_to":"fa31d9ce_061dfdbc","updated":"2017-02-13 17:19:16.000000000","message":"Oops, done","commit_id":"2ff2cf9ddb16e03af5d23e7e1a8bdf79530cb155"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"847b198edec472f5924be65b8ba878bb660e4bb7","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        common_utils.wait_until_true("},{"line_number":179,"context_line":"            netcat.test_no_connectivity,"},{"line_number":180,"context_line":"            exception\u003dAssertionError("},{"line_number":181,"context_line":"                \"Still can ping VM from different host.\")"},{"line_number":182,"context_line":"        )"},{"line_number":183,"context_line":"        netcat.stop_processes()"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_299729ed","line":181,"updated":"2017-02-13 22:27:18.000000000","message":"This doesn\u0027t look like a ping test :)","commit_id":"0fdcb9b967868834f6f2cd42865af0c2a2deae99"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1ffbe483999babcb43df660992612e5077391448","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        common_utils.wait_until_true("},{"line_number":179,"context_line":"            netcat.test_no_connectivity,"},{"line_number":180,"context_line":"            exception\u003dAssertionError("},{"line_number":181,"context_line":"                \"Still can ping VM from different host.\")"},{"line_number":182,"context_line":"        )"},{"line_number":183,"context_line":"        netcat.stop_processes()"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_bc5d0b7b","line":181,"in_reply_to":"fa31d9ce_299729ed","updated":"2017-02-14 08:05:28.000000000","message":"It\u0027s a ping with tcp :)","commit_id":"0fdcb9b967868834f6f2cd42865af0c2a2deae99"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"354db759a09c991b16bf1d506848b36a72f476a7","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    def test_securitygroup(self):"},{"line_number":104,"context_line":"        \"\"\"Tests if a security group rules are working, by confirming"},{"line_number":105,"context_line":"        that 0. traffic is allowed when port security is disabled,"},{"line_number":106,"context_line":"             1. connection from elsewhere is blocked,"},{"line_number":107,"context_line":"             2. connection from allowed security group is allowed,"},{"line_number":108,"context_line":"             3. traffic not explicitly allowed (eg. ICMP) is blocked,"},{"line_number":109,"context_line":"             4. a security group update takes effect,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_42c4245e","line":106,"range":{"start_line":106,"start_character":32,"end_line":106,"end_character":42},"updated":"2017-02-14 08:50:42.000000000","message":"elsewhere is undefined here. :)\nYou might want to say \"connection from outside of allowed security group is blocked\" instead.","commit_id":"4fc2fc63abed0691a403b4264e42e6c8cf46812b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8e9af65a67fff851926e643b094715bbf7adc18b","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    def test_securitygroup(self):"},{"line_number":104,"context_line":"        \"\"\"Tests if a security group rules are working, by confirming"},{"line_number":105,"context_line":"        that 0. traffic is allowed when port security is disabled,"},{"line_number":106,"context_line":"             1. connection from elsewhere is blocked,"},{"line_number":107,"context_line":"             2. connection from allowed security group is allowed,"},{"line_number":108,"context_line":"             3. traffic not explicitly allowed (eg. ICMP) is blocked,"},{"line_number":109,"context_line":"             4. a security group update takes effect,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_dd22b951","line":106,"range":{"start_line":106,"start_character":32,"end_line":106,"end_character":42},"in_reply_to":"fa31d9ce_42c4245e","updated":"2017-02-14 09:27:51.000000000","message":"Done","commit_id":"4fc2fc63abed0691a403b4264e42e6c8cf46812b"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"952369081fb5c42b041814a544d28b1f7156c7c6","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    def test_securitygroup(self):"},{"line_number":104,"context_line":"        \"\"\"Tests if a security group rules are working, by confirming"},{"line_number":105,"context_line":"        that 0. traffic is allowed when port security is disabled,"},{"line_number":106,"context_line":"             1. connection from elsewhere is blocked,"},{"line_number":107,"context_line":"             2. connection from allowed security group is allowed,"},{"line_number":108,"context_line":"             3. traffic not explicitly allowed (eg. ICMP) is blocked,"},{"line_number":109,"context_line":"             4. a security group update takes effect,"},{"line_number":110,"context_line":"             5. a remote security group member addition works, and"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_820c5cee","line":107,"range":{"start_line":106,"start_character":32,"end_line":107,"end_character":66},"updated":"2017-02-14 08:43:16.000000000","message":"nit nit:\n1. Connection from disallowed hosts is blocked\n2. Connection from allowed security group is permitted\nJust a suggestion in case you need a respin, otherwise LGTM","commit_id":"4fc2fc63abed0691a403b4264e42e6c8cf46812b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8e9af65a67fff851926e643b094715bbf7adc18b","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    def test_securitygroup(self):"},{"line_number":104,"context_line":"        \"\"\"Tests if a security group rules are working, by confirming"},{"line_number":105,"context_line":"        that 0. traffic is allowed when port security is disabled,"},{"line_number":106,"context_line":"             1. connection from elsewhere is blocked,"},{"line_number":107,"context_line":"             2. connection from allowed security group is allowed,"},{"line_number":108,"context_line":"             3. traffic not explicitly allowed (eg. ICMP) is blocked,"},{"line_number":109,"context_line":"             4. a security group update takes effect,"},{"line_number":110,"context_line":"             5. a remote security group member addition works, and"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_bdb9857b","line":107,"range":{"start_line":106,"start_character":32,"end_line":107,"end_character":66},"in_reply_to":"fa31d9ce_820c5cee","updated":"2017-02-14 09:27:51.000000000","message":"Done","commit_id":"4fc2fc63abed0691a403b4264e42e6c8cf46812b"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"354db759a09c991b16bf1d506848b36a72f476a7","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                body\u003d{\u0027port\u0027: {\u0027port_security_enabled\u0027: True,"},{"line_number":172,"context_line":"                               \u0027security_groups\u0027: [sgs[sg][\u0027id\u0027]]}})"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        # 1. check if connection from elsewhere is blocked"},{"line_number":175,"context_line":"        netcat \u003d net_helpers.NetcatTester("},{"line_number":176,"context_line":"            vms[2].namespace, vms[0].namespace, vms[0].ip, 3333,"},{"line_number":177,"context_line":"            net_helpers.NetcatTester.TCP)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_e2a518a2","line":174,"updated":"2017-02-14 08:50:42.000000000","message":"It\u0027s it the commit log but leaving a short note on why we need to wait here would help.","commit_id":"4fc2fc63abed0691a403b4264e42e6c8cf46812b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8e9af65a67fff851926e643b094715bbf7adc18b","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                body\u003d{\u0027port\u0027: {\u0027port_security_enabled\u0027: True,"},{"line_number":172,"context_line":"                               \u0027security_groups\u0027: [sgs[sg][\u0027id\u0027]]}})"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        # 1. check if connection from elsewhere is blocked"},{"line_number":175,"context_line":"        netcat \u003d net_helpers.NetcatTester("},{"line_number":176,"context_line":"            vms[2].namespace, vms[0].namespace, vms[0].ip, 3333,"},{"line_number":177,"context_line":"            net_helpers.NetcatTester.TCP)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_9d3921f5","line":174,"in_reply_to":"fa31d9ce_e2a518a2","updated":"2017-02-14 09:27:51.000000000","message":"Done","commit_id":"4fc2fc63abed0691a403b4264e42e6c8cf46812b"}]}