)]}'
{"neutron/db/flavors_db.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"00f3debf7de5b236b7725ce81173b30c90fa0c7b","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        return self._make_flavor_dict(obj)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def update_flavor(self, context, flavor_id, flavor):"},{"line_number":111,"context_line":"        with db_api.context_manager.writer.using(context):"},{"line_number":112,"context_line":"            self._ensure_flavor_not_in_use(context, flavor_id)"},{"line_number":113,"context_line":"            fl_obj \u003d self._get_flavor(context, flavor_id)"},{"line_number":114,"context_line":"            fl_obj.update_fields(flavor[\u0027flavor\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_e4b31a4b","line":111,"updated":"2017-02-15 16:30:19.000000000","message":"Could you add, just for sake, empty dict called fl_obj?\nIf anything happens inside context manager, we won\u0027t have fl_obj which will cause error in return line.","commit_id":"3c89520c34e0f9bbeb6e68b675dffee2557655de"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"fc5574eebcab290de98e094cdec2f909ac1a2f1f","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        return self._make_flavor_dict(obj)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def update_flavor(self, context, flavor_id, flavor):"},{"line_number":111,"context_line":"        with db_api.context_manager.writer.using(context):"},{"line_number":112,"context_line":"            self._ensure_flavor_not_in_use(context, flavor_id)"},{"line_number":113,"context_line":"            fl_obj \u003d self._get_flavor(context, flavor_id)"},{"line_number":114,"context_line":"            fl_obj.update_fields(flavor[\u0027flavor\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_a70a0424","line":111,"in_reply_to":"fa31d9ce_47e6a8e8","updated":"2017-02-15 17:06:09.000000000","message":"ack, thanks","commit_id":"3c89520c34e0f9bbeb6e68b675dffee2557655de"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a840b26cc056673153e72fe4e209ea6b2c290378","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        return self._make_flavor_dict(obj)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def update_flavor(self, context, flavor_id, flavor):"},{"line_number":111,"context_line":"        with db_api.context_manager.writer.using(context):"},{"line_number":112,"context_line":"            self._ensure_flavor_not_in_use(context, flavor_id)"},{"line_number":113,"context_line":"            fl_obj \u003d self._get_flavor(context, flavor_id)"},{"line_number":114,"context_line":"            fl_obj.update_fields(flavor[\u0027flavor\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_47e6a8e8","line":111,"in_reply_to":"fa31d9ce_e4b31a4b","updated":"2017-02-15 16:56:58.000000000","message":"These context managers don\u0027t stop exceptions. We don\u0027t have to worry about undefined vars defined in the body.","commit_id":"3c89520c34e0f9bbeb6e68b675dffee2557655de"}]}
