)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17821,"name":"Zhixin Li","email":"lizhixin@awcloud.com","username":"lizhixin"},"change_message_id":"28db00c89e055d1aa1b80f47ed7dce32cc48720e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"it is used for getting a random dhcp_lease value,"},{"line_number":11,"context_line":"and modify some old Errors of PEP8 in dhcp.py file."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Fixes Bug1652728"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I488b7c689f5b6d352a76ce4e73c549f0e3b7fcdd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa31d9ce_6292a1f7","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":16},"updated":"2017-02-16 06:54:38.000000000","message":"using \u0027Closes-bug: #1652728\u0027 is better.","commit_id":"06a5b46c63f8ad94c3574817a3dcb8f0f487d0f4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"bcfb4af61a35c7ec70dda7e9a781fca43ba3c25d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding a random lease_time value for dhcp-agent in large scale environment."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We add a vary called dhcp_lease_random in conf file common.py,"},{"line_number":10,"context_line":"it is used for getting a random dhcp_lease value,"},{"line_number":11,"context_line":"and modify some old Errors of PEP8 in dhcp.py file."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dfeb2761_e27ba4bb","line":9,"range":{"start_line":9,"start_character":9,"end_line":9,"end_character":13},"updated":"2017-04-02 12:48:07.000000000","message":"variable","commit_id":"e140688fd67b913239878f2ee6c6e65600907491"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":17821,"name":"Zhixin Li","email":"lizhixin@awcloud.com","username":"lizhixin"},"change_message_id":"28db00c89e055d1aa1b80f47ed7dce32cc48720e","unresolved":false,"context_lines":[{"line_number":369,"context_line":"                lease \u003d \u0027infinite\u0027"},{"line_number":370,"context_line":"            else:"},{"line_number":371,"context_line":"                # random is the modulus of network id\u0027s first segment"},{"line_number":372,"context_line":"                random \u003d int(self.network.id.split(\u0027-\u0027)[0], 16) % \\"},{"line_number":373,"context_line":"                    self.conf.dhcp_lease_random"},{"line_number":374,"context_line":"                lease \u003d \u0027%ss\u0027 % (self.conf.dhcp_lease_duration + random)"},{"line_number":375,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_423d9d29","line":372,"range":{"start_line":372,"start_character":65,"end_line":372,"end_character":67},"updated":"2017-02-16 06:54:38.000000000","message":"\u0027\\\u0027 is not recommended, use \u0027()\u0027 instead, like this:\nrandom \u003d (int(self.network.id.split(\u0027-\u0027)[0], 16) %\n          self.conf.dhcp_lease_random)\nAnd I don\u0027t think the ramdon generated from network_id is a good idea.","commit_id":"06a5b46c63f8ad94c3574817a3dcb8f0f487d0f4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6c71dc6028ece75a1928f366289e769a89914fb4","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                    os.makedirs(log_dir)"},{"line_number":421,"context_line":"            except OSError:"},{"line_number":422,"context_line":"                LOG.error(_LE(\u0027Error while create dnsmasq log dir: %s\u0027),"},{"line_number":423,"context_line":"                          log_dir)"},{"line_number":424,"context_line":"            else:"},{"line_number":425,"context_line":"                log_filename \u003d os.path.join(log_dir, \u0027dhcp_dns_log\u0027)"},{"line_number":426,"context_line":"                cmd.append(\u0027--log-queries\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_27a34251","line":423,"updated":"2017-02-16 16:00:27.000000000","message":"All pep8 issues should be fixed in a different patch and not mixed-in with a functional change.","commit_id":"e140688fd67b913239878f2ee6c6e65600907491"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"862c5dfd4e26c8cc49d0291ea471dfbf6f18a528","unresolved":false,"context_lines":[{"line_number":627,"context_line":"            # Dnsmasq timestamp format for an infinite lease is 0."},{"line_number":628,"context_line":"            timestamp \u003d 0"},{"line_number":629,"context_line":"        else:"},{"line_number":630,"context_line":"            timestamp \u003d int(time.time()) + self.conf.dhcp_lease_duration + \\"},{"line_number":631,"context_line":"                int(self.network.id.split(\u0027-\u0027)[0], 16) % \\"},{"line_number":632,"context_line":"                self.conf.dhcp_lease_random"},{"line_number":633,"context_line":"        dhcp_enabled_subnet_ids \u003d [s.id for s in self.network.subnets"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_0ea4bd05","line":630,"range":{"start_line":630,"start_character":75,"end_line":630,"end_character":76},"updated":"2017-02-27 01:23:58.000000000","message":"Per https://docs.openstack.org/developer/hacking/#general, please avoid using backslash to continue lines. What you did in L372 above is fine","commit_id":"e140688fd67b913239878f2ee6c6e65600907491"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"862c5dfd4e26c8cc49d0291ea471dfbf6f18a528","unresolved":false,"context_lines":[{"line_number":628,"context_line":"            timestamp \u003d 0"},{"line_number":629,"context_line":"        else:"},{"line_number":630,"context_line":"            timestamp \u003d int(time.time()) + self.conf.dhcp_lease_duration + \\"},{"line_number":631,"context_line":"                int(self.network.id.split(\u0027-\u0027)[0], 16) % \\"},{"line_number":632,"context_line":"                self.conf.dhcp_lease_random"},{"line_number":633,"context_line":"        dhcp_enabled_subnet_ids \u003d [s.id for s in self.network.subnets"},{"line_number":634,"context_line":"                                   if s.enable_dhcp]"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_2ea7c10b","line":631,"range":{"start_line":631,"start_character":57,"end_line":631,"end_character":58},"updated":"2017-02-27 01:23:58.000000000","message":"Ditto","commit_id":"e140688fd67b913239878f2ee6c6e65600907491"}],"neutron/conf/common.py":[{"author":{"_account_id":17821,"name":"Zhixin Li","email":"lizhixin@awcloud.com","username":"lizhixin"},"change_message_id":"28db00c89e055d1aa1b80f47ed7dce32cc48720e","unresolved":false,"context_lines":[{"line_number":84,"context_line":"               help\u003d_(\"DHCP lease duration (in seconds). Use -1 to tell \""},{"line_number":85,"context_line":"                      \"dnsmasq to use infinite lease times.\")),"},{"line_number":86,"context_line":"    # number with a range of dhcp_lease_random"},{"line_number":87,"context_line":"    cfg.IntOpt(\u0027dhcp_lease_random\u0027, default\u003d1200,"},{"line_number":88,"context_line":"               help\u003d_(\"DHCP lease random (in seconds).Every dhcp lease time \""},{"line_number":89,"context_line":"                      \"will add this random.\")),"},{"line_number":90,"context_line":"    cfg.StrOpt(\u0027dns_domain\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_c268adf7","line":87,"range":{"start_line":87,"start_character":16,"end_line":87,"end_character":33},"updated":"2017-02-16 06:54:38.000000000","message":"This is not a real random, it may make us confused.","commit_id":"06a5b46c63f8ad94c3574817a3dcb8f0f487d0f4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6c71dc6028ece75a1928f366289e769a89914fb4","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    # number with a range of dhcp_lease_random"},{"line_number":87,"context_line":"    cfg.IntOpt(\u0027dhcp_lease_random\u0027, default\u003d1200,"},{"line_number":88,"context_line":"               help\u003d_(\"DHCP lease random (in seconds).Every dhcp lease time \""},{"line_number":89,"context_line":"                      \"will add this random.\")),"},{"line_number":90,"context_line":"    cfg.StrOpt(\u0027dns_domain\u0027,"},{"line_number":91,"context_line":"               default\u003d\u0027openstacklocal\u0027,"},{"line_number":92,"context_line":"               help\u003d_(\u0027Domain to use for building the hostnames\u0027)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_a7a65251","line":89,"updated":"2017-02-16 16:00:27.000000000","message":"At a minimum, the default needs to be \"off\", which can\u0027t be done by setting this to zero the way the code is written:\n\n\u003e\u003e\u003e 600 % 0\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\nZeroDivisionError: integer division or modulo by zero","commit_id":"e140688fd67b913239878f2ee6c6e65600907491"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"bcfb4af61a35c7ec70dda7e9a781fca43ba3c25d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    # number with a range of dhcp_lease_random"},{"line_number":87,"context_line":"    cfg.IntOpt(\u0027dhcp_lease_random\u0027, default\u003d1200,"},{"line_number":88,"context_line":"               help\u003d_(\"DHCP lease random (in seconds).Every dhcp lease time \""},{"line_number":89,"context_line":"                      \"will add this random.\")),"},{"line_number":90,"context_line":"    cfg.StrOpt(\u0027dns_domain\u0027,"},{"line_number":91,"context_line":"               default\u003d\u0027openstacklocal\u0027,"},{"line_number":92,"context_line":"               help\u003d_(\u0027Domain to use for building the hostnames\u0027)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_a24fdc90","line":89,"in_reply_to":"fa31d9ce_a7a65251","updated":"2017-04-02 12:48:07.000000000","message":"agree - this should be off by default.","commit_id":"e140688fd67b913239878f2ee6c6e65600907491"}]}
