)]}'
{"neutron/api/rpc/agentnotifiers/dhcp_rpc_agent_api.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c2a231326d6bc778f7501b750feee4eceb204eae","unresolved":false,"context_lines":[{"line_number":248,"context_line":"                return"},{"line_number":249,"context_line":"        self.notify(context, data, method_name)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def _only_status_changed(self, orig, new):"},{"line_number":252,"context_line":"        # a status change will manifest as a bumped revision number, a new"},{"line_number":253,"context_line":"        # updated_at timestamp, and a new status. If that\u0027s all that changed,"},{"line_number":254,"context_line":"        # return True, else False"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_cd07fd16","line":251,"range":{"start_line":251,"start_character":8,"end_line":251,"end_character":28},"updated":"2017-02-16 08:39:45.000000000","message":"Does it make sense to only notify in case MAC/IP changes? Seems agent shouldn\u0027t care about owner, binding, etc. updates as well..","commit_id":"840e04b6f122f022f67b600ed2f96ae5e92eabe0"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"c5be63069ded6411ce52dec82ec2346ac3fdc03f","unresolved":false,"context_lines":[{"line_number":248,"context_line":"                return"},{"line_number":249,"context_line":"        self.notify(context, data, method_name)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def _only_status_changed(self, orig, new):"},{"line_number":252,"context_line":"        # a status change will manifest as a bumped revision number, a new"},{"line_number":253,"context_line":"        # updated_at timestamp, and a new status. If that\u0027s all that changed,"},{"line_number":254,"context_line":"        # return True, else False"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_b3e69142","line":251,"updated":"2017-02-16 18:25:39.000000000","message":"I don\u0027t want to try to decide what the agent is interested in here, particularily since I want to back-port this and that would make it riskier. As Daniel and Neil pointed out, there are actually several attributes it may be interested in and we might miss one going down that path.\n\n@Victor, those attributes are just the ones that change on a status update. I want it named _only_status_changed to communicate the intent that we are skipping status updates.","commit_id":"840e04b6f122f022f67b600ed2f96ae5e92eabe0"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"c6f83398b2e4114be2b8f1e686ab7676815d57cc","unresolved":false,"context_lines":[{"line_number":248,"context_line":"                return"},{"line_number":249,"context_line":"        self.notify(context, data, method_name)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def _only_status_changed(self, orig, new):"},{"line_number":252,"context_line":"        # a status change will manifest as a bumped revision number, a new"},{"line_number":253,"context_line":"        # updated_at timestamp, and a new status. If that\u0027s all that changed,"},{"line_number":254,"context_line":"        # return True, else False"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_c116d6f0","line":251,"range":{"start_line":251,"start_character":8,"end_line":251,"end_character":28},"in_reply_to":"fa31d9ce_3b160556","updated":"2017-02-16 15:08:59.000000000","message":"Also per-port DHCP options?","commit_id":"840e04b6f122f022f67b600ed2f96ae5e92eabe0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a78e8f710a59796e4f7d895c036bf69b092963fe","unresolved":false,"context_lines":[{"line_number":248,"context_line":"                return"},{"line_number":249,"context_line":"        self.notify(context, data, method_name)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def _only_status_changed(self, orig, new):"},{"line_number":252,"context_line":"        # a status change will manifest as a bumped revision number, a new"},{"line_number":253,"context_line":"        # updated_at timestamp, and a new status. If that\u0027s all that changed,"},{"line_number":254,"context_line":"        # return True, else False"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_a72bb293","line":251,"range":{"start_line":251,"start_character":8,"end_line":251,"end_character":28},"in_reply_to":"fa31d9ce_c116d6f0","updated":"2017-02-16 16:00:42.000000000","message":"IIRC we discussed about this in the past, i.e. making notifications conditional to what the DHCP cares about. We feared the potential higher impact of the increase in notifications for the native case, but left existing logic as is with the promise to revise this later on. I guess now it\u0027s the time.\n\nAt this point, it makes sense to evaluate what data the DHCP cares about when it sees a notification, and have it be notified if and only if these change, however this means \u0027coupling\u0027 this logic with the agent\u0027s.","commit_id":"840e04b6f122f022f67b600ed2f96ae5e92eabe0"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"dfa692632622b5aa574b64fc1d9c5357c8f64002","unresolved":false,"context_lines":[{"line_number":248,"context_line":"                return"},{"line_number":249,"context_line":"        self.notify(context, data, method_name)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def _only_status_changed(self, orig, new):"},{"line_number":252,"context_line":"        # a status change will manifest as a bumped revision number, a new"},{"line_number":253,"context_line":"        # updated_at timestamp, and a new status. If that\u0027s all that changed,"},{"line_number":254,"context_line":"        # return True, else False"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_a7549221","line":251,"range":{"start_line":251,"start_character":8,"end_line":251,"end_character":28},"in_reply_to":"fa31d9ce_c116d6f0","updated":"2017-02-16 16:00:37.000000000","message":"Regarding the name of the method and given that is checking the status and some standard attributes, this should be change to something more generic, maybe like requires_notify(...)","commit_id":"840e04b6f122f022f67b600ed2f96ae5e92eabe0"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"cef1a238cb11c972a1e4618c6769a5038e4a9fa9","unresolved":false,"context_lines":[{"line_number":248,"context_line":"                return"},{"line_number":249,"context_line":"        self.notify(context, data, method_name)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def _only_status_changed(self, orig, new):"},{"line_number":252,"context_line":"        # a status change will manifest as a bumped revision number, a new"},{"line_number":253,"context_line":"        # updated_at timestamp, and a new status. If that\u0027s all that changed,"},{"line_number":254,"context_line":"        # return True, else False"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_3b160556","line":251,"range":{"start_line":251,"start_character":8,"end_line":251,"end_character":28},"in_reply_to":"fa31d9ce_cd07fd16","updated":"2017-02-16 14:44:02.000000000","message":"Also on admin_state_up?","commit_id":"840e04b6f122f022f67b600ed2f96ae5e92eabe0"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"c5be63069ded6411ce52dec82ec2346ac3fdc03f","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        # updated_at timestamp, and a new status. If that\u0027s all that changed,"},{"line_number":254,"context_line":"        # return True, else False"},{"line_number":255,"context_line":"        if not orig or not new:"},{"line_number":256,"context_line":"            return False"},{"line_number":257,"context_line":"        if set(orig.keys()) !\u003d set(new.keys()):"},{"line_number":258,"context_line":"            return False"},{"line_number":259,"context_line":"        for k in orig.keys():"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_d3e30532","line":256,"updated":"2017-02-16 18:25:39.000000000","message":"This is an event handler for both port create and update. In the case of port create we definitely don\u0027t have the \u0027orig\u0027 arg. I left \u0027new\u0027 on there just defensively.","commit_id":"840e04b6f122f022f67b600ed2f96ae5e92eabe0"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"dfa692632622b5aa574b64fc1d9c5357c8f64002","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        # a status change will manifest as a bumped revision number, a new"},{"line_number":253,"context_line":"        # updated_at timestamp, and a new status. If that\u0027s all that changed,"},{"line_number":254,"context_line":"        # return True, else False"},{"line_number":255,"context_line":"        if not orig or not new:"},{"line_number":256,"context_line":"            return False"},{"line_number":257,"context_line":"        if set(orig.keys()) !\u003d set(new.keys()):"},{"line_number":258,"context_line":"            return False"},{"line_number":259,"context_line":"        for k in orig.keys():"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_07d0fec8","line":256,"range":{"start_line":255,"start_character":8,"end_line":256,"end_character":24},"updated":"2017-02-16 16:00:37.000000000","message":"does this validation is necessary? if one o the arguments is not provided it should raise an error.  Returning a false value in the case where some of the arguments is None looks like a false positive.","commit_id":"840e04b6f122f022f67b600ed2f96ae5e92eabe0"}]}
