)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e0e385297b51aae76e810eaf19807f2985fe03ce","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"We can run `oslopolicy-sample-generator --namespace neutron \\"},{"line_number":14,"context_line":"--output-file /etc/neutron/policy.json` in openstack environment"},{"line_number":15,"context_line":"or `tox -e genpolicy` in neutron top git diretory of devstack to"},{"line_number":16,"context_line":"generate policy.json file. Note that the generated policy.json"},{"line_number":17,"context_line":"has no \u0027{\u0027 in first line and \u0027}\u0027 in last line."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7f515b1d_1801ceaf","line":15,"range":{"start_line":15,"start_character":41,"end_line":15,"end_character":49},"updated":"2017-10-02 15:32:56.000000000","message":"directory*","commit_id":"d487a1d9210a394e197a7df4efe708a6fcdf55f5"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e0e385297b51aae76e810eaf19807f2985fe03ce","unresolved":false,"context_lines":[{"line_number":13,"context_line":"We can run `oslopolicy-sample-generator --namespace neutron \\"},{"line_number":14,"context_line":"--output-file /etc/neutron/policy.json` in openstack environment"},{"line_number":15,"context_line":"or `tox -e genpolicy` in neutron top git diretory of devstack to"},{"line_number":16,"context_line":"generate policy.json file. Note that the generated policy.json"},{"line_number":17,"context_line":"has no \u0027{\u0027 in first line and \u0027}\u0027 in last line."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ib8be61ffcbd10a893f47d35c09456700f803816e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7f515b1d_d8d5761d","line":16,"range":{"start_line":16,"start_character":51,"end_line":16,"end_character":62},"updated":"2017-10-02 15:32:56.000000000","message":"This actually is generated as YAML, and not JSON. JSON doesn\u0027t support comments but YAML does. If we use YAML, we can generate additional comments about the operations being done.","commit_id":"d487a1d9210a394e197a7df4efe708a6fcdf55f5"}],"etc/policy.json":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"4a81ca6e116d45d9db0d5df460037502f1dba378","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9ff52f3f_c8d92323","updated":"2017-04-13 00:24:20.000000000","message":"Shouldn\u0027t this file go away? If not, what keeps this in sync with the policy files?","commit_id":"d487a1d9210a394e197a7df4efe708a6fcdf55f5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1cbcc1935353928a2dcc1d0c9f7cf9a4e57d7dc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7f515b1d_9dc85b22","in_reply_to":"9ff52f3f_c8d92323","updated":"2017-09-27 22:17:22.000000000","message":"This file should go away. I checked the Nova repo, and it doesn\u0027t exist there. I\u0027ll remove it in the next revision. It is probably the result of a test","commit_id":"d487a1d9210a394e197a7df4efe708a6fcdf55f5"}],"neutron/conf/policies/address_scope.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"3586265394a9c62f622697298a9d647c8a173f21","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"rules \u003d ["},{"line_number":17,"context_line":"    policy.RuleDefault(\u0027shared_address_scopes\u0027,"},{"line_number":18,"context_line":"                       \u0027field:address_scopes:shared\u003dTrue\u0027,"},{"line_number":19,"context_line":"                       description\u003d\u0027Rule of shared address scope\u0027),"},{"line_number":20,"context_line":"    policy.RuleDefault(\u0027create_address_scope\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f515b1d_ddf1f602","line":17,"range":{"start_line":17,"start_character":11,"end_line":17,"end_character":22},"updated":"2017-10-01 00:13:01.000000000","message":"Using the DocumentedRuleDefault object from oslo policy helps because you can add in useful descriptions and URL/methods. This all gets rendered in the documentation for operators.\n\nhttps://docs.openstack.org/oslo.policy/latest/user/usage.html#how-to-register","commit_id":"d487a1d9210a394e197a7df4efe708a6fcdf55f5"}],"neutron/conf/policies/agent.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ea02891bb431b629fe42b0c50841b36fb47688e6","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"rules \u003d ["},{"line_number":17,"context_line":"    policy.RuleDefault(\u0027get_agent\u0027,"},{"line_number":18,"context_line":"                       \u0027rule:admin_only\u0027,"},{"line_number":19,"context_line":"                       description\u003d\u0027Acess rule for getting agent\u0027),"},{"line_number":20,"context_line":"    policy.RuleDefault(\u0027update_agent\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f515b1d_2ec0647c","line":17,"range":{"start_line":17,"start_character":11,"end_line":17,"end_character":22},"updated":"2017-10-05 15:41:08.000000000","message":"These should be DocumentedRuleDefault objects. The advantage is that it gives developers the opportunity to describe the actual policy and which API it maps to, making it easier for operators to understand which policies protect specific APIs (instead of making them go dig in the code for the answer).\n\nThis comment can be applied consistently throughout the patch.","commit_id":"d487a1d9210a394e197a7df4efe708a6fcdf55f5"}]}