)]}'
{"neutron/db/quota/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9d97aaf573aef24662094a76a9b340856a26d1a2","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                # Adjust for expired reservations. Apparently it is cheaper"},{"line_number":208,"context_line":"                # than querying every time for active reservations and counting"},{"line_number":209,"context_line":"                # overall quantity of resources reserved"},{"line_number":210,"context_line":"                expired_reservations \u003d quota_api.get_reservations_for_resource("},{"line_number":211,"context_line":"                    context, tenant_id, resource, expired\u003dTrue)"},{"line_number":212,"context_line":"                total_usage \u003d current_usages[resource] - expired_reservations"},{"line_number":213,"context_line":"                res_headroom \u003d current_limits[resource] - total_usage"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_177cb671","line":210,"updated":"2017-02-19 05:54:33.000000000","message":"we are going from reading the DB once to reading once per resource. I do not see the improvement here.","commit_id":"2b8c2fbfeec00eb1a625e4585e4d7d87116769fb"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b833fb3ca18d96ab1bd7fe199615301d29a3a3e4","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                # Adjust for expired reservations. Apparently it is cheaper"},{"line_number":208,"context_line":"                # than querying every time for active reservations and counting"},{"line_number":209,"context_line":"                # overall quantity of resources reserved"},{"line_number":210,"context_line":"                expired_reservations \u003d quota_api.get_reservations_for_resource("},{"line_number":211,"context_line":"                    context, tenant_id, resource, expired\u003dTrue)"},{"line_number":212,"context_line":"                total_usage \u003d current_usages[resource] - expired_reservations"},{"line_number":213,"context_line":"                res_headroom \u003d current_limits[resource] - total_usage"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_b169328e","line":210,"in_reply_to":"da36d5c6_177cb671","updated":"2017-02-20 02:15:34.000000000","message":"Except that we don\u0027t ever call the method with multiple resources. The improvement is simplifying the interface.","commit_id":"2b8c2fbfeec00eb1a625e4585e4d7d87116769fb"},{"author":{"_account_id":23821,"name":"Prince Nana Owusu Boateng","email":"prince.a.owusu.boateng@intel.com","username":"nanaboat"},"change_message_id":"0ab86c44d90212fee657a43948f79e75205c808d","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                # Adjust for expired reservations. Apparently it is cheaper"},{"line_number":208,"context_line":"                # than querying every time for active reservations and counting"},{"line_number":209,"context_line":"                # overall quantity of resources reserved"},{"line_number":210,"context_line":"                expired_reservations \u003d quota_api.get_reservations_for_resource("},{"line_number":211,"context_line":"                    context, tenant_id, resource, expired\u003dTrue)"},{"line_number":212,"context_line":"                total_usage \u003d current_usages[resource] - expired_reservations"},{"line_number":213,"context_line":"                res_headroom \u003d current_limits[resource] - total_usage"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_5376c3a4","line":210,"in_reply_to":"da36d5c6_b169328e","updated":"2017-03-02 20:10:47.000000000","message":"There are cases when this method is called with multiple resources. I believe we should look at the tradeoff between doing several DB readings when multiple resources are passed and simplifying the interface here.","commit_id":"2b8c2fbfeec00eb1a625e4585e4d7d87116769fb"}],"neutron/tests/unit/db/quota/test_api.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e03a67dbabededb1a72cdf6649f61ecff5d80046","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        self._create_reservation(resources_3, expiration\u003dexp_date_2)"},{"line_number":231,"context_line":"        with mock.patch(\u0027neutron.db.quota.api.utcnow\u0027,"},{"line_number":232,"context_line":"                        return_value\u003ddatetime.datetime(2015, 5, 20, 0, 0)):"},{"line_number":233,"context_line":"            if expired:"},{"line_number":234,"context_line":"                expected \u003d {"},{"line_number":235,"context_line":"                    \u0027goals\u0027: 0,"},{"line_number":236,"context_line":"                    \u0027assists\u0027: 2,"},{"line_number":237,"context_line":"                    \u0027bookings\u0027: 2,"},{"line_number":238,"context_line":"                }"},{"line_number":239,"context_line":"            else:"},{"line_number":240,"context_line":"                expected \u003d {"},{"line_number":241,"context_line":"                    \u0027goals\u0027: 5,"},{"line_number":242,"context_line":"                    \u0027assists\u0027: 1,"},{"line_number":243,"context_line":"                    \u0027bookings\u0027: 1,"},{"line_number":244,"context_line":"                }"},{"line_number":245,"context_line":"            for resource, amount in expected.items():"},{"line_number":246,"context_line":"                delta \u003d quota_api.get_reservations_for_resource("}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_7df95f4d","line":243,"range":{"start_line":233,"start_character":10,"end_line":243,"end_character":34},"updated":"2017-02-17 22:43:19.000000000","message":"Im little doubtful of these calculations, everything else looks fine,","commit_id":"2b8c2fbfeec00eb1a625e4585e4d7d87116769fb"}]}