)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"00b08d785e2b59768ffcab908c4b9c420ffc28a3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"This results in a small behavior change internally for bulk"},{"line_number":17,"context_line":"port creation operations where the notifier will be called"},{"line_number":18,"context_line":"once for each port rather than once for all ports. We can"},{"line_number":19,"context_line":"revisit this in the future if it turns out to be problematic"},{"line_number":20,"context_line":"but right now the bulk port creation API is rarely anyway"},{"line_number":21,"context_line":"since it\u0027s mostly a hidden feature (lack of client support)."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da36d5c6_396ec996","line":19,"range":{"start_line":19,"start_character":49,"end_line":19,"end_character":60},"updated":"2017-02-21 18:29:42.000000000","message":"Are you suggesting that this can have some side effects on the performance?","commit_id":"b903e59553c339930efc6649d8fa21b5581cdccf"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"2c77e10c6c578d0fa13b1f6e10d49f8756de82d6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"This results in a small behavior change internally for bulk"},{"line_number":17,"context_line":"port creation operations where the notifier will be called"},{"line_number":18,"context_line":"once for each port rather than once for all ports. We can"},{"line_number":19,"context_line":"revisit this in the future if it turns out to be problematic"},{"line_number":20,"context_line":"but right now the bulk port creation API is rarely anyway"},{"line_number":21,"context_line":"since it\u0027s mostly a hidden feature (lack of client support)."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da36d5c6_f871dda9","line":19,"range":{"start_line":19,"start_character":49,"end_line":19,"end_character":60},"in_reply_to":"da36d5c6_396ec996","updated":"2017-02-27 15:21:10.000000000","message":"Yes, but we don\u0027t currently use the bulk port API.","commit_id":"b903e59553c339930efc6649d8fa21b5581cdccf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3f51da17fb8a5210e82457fc6a1ae5dc2fef8f2b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"port creation operations where the notifier will be called"},{"line_number":18,"context_line":"once for each port rather than once for all ports. We can"},{"line_number":19,"context_line":"revisit this in the future if it turns out to be problematic"},{"line_number":20,"context_line":"but right now the bulk port creation API is rarely anyway"},{"line_number":21,"context_line":"since it\u0027s mostly a hidden feature (lack of client support)."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Partial-Bug: #1666424"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7ffa3b31_d6450c45","line":20,"range":{"start_line":20,"start_character":44,"end_line":20,"end_character":57},"updated":"2017-04-17 19:43:45.000000000","message":"rarely used","commit_id":"b9b598040da1b8d3e860b39d9027c10f8576ee33"}],"neutron/db/securitygroups_rpc_base.py":[{"author":{"_account_id":10518,"name":"Jesse","email":"jesse@easystack.cn","username":"jesse"},"change_message_id":"58887329498da597b3308087ab4137154a5704c2","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    \"\"\"Mixin class to add agent-based security group implementation.\"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @registry.receives(resources.PORT, [events.AFTER_CREATE,"},{"line_number":46,"context_line":"                                        events.AFTER_UPDATE,"},{"line_number":47,"context_line":"                                        events.AFTER_DELETE])"},{"line_number":48,"context_line":"    def notify_sg_on_port_change(self, resource, event, trigger, context,"},{"line_number":49,"context_line":"                                 port, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_81df2139","line":46,"updated":"2017-09-05 05:00:35.000000000","message":"I think we don\u0027t need to register update event because notify will send only on port\u0027s SG changes.","commit_id":"b9b598040da1b8d3e860b39d9027c10f8576ee33"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"00b08d785e2b59768ffcab908c4b9c420ffc28a3","unresolved":false,"context_lines":[{"line_number":1297,"context_line":"                              \"failed, deleting port \u0027%s\u0027\"), result[\u0027id\u0027])"},{"line_number":1298,"context_line":"                self.delete_port(context, result[\u0027id\u0027], l3_port_check\u003dFalse)"},{"line_number":1299,"context_line":""},{"line_number":1300,"context_line":"        # REVISIT(rkukura): Is there any point in calling this before"},{"line_number":1301,"context_line":"        # a binding has been successfully established?"},{"line_number":1302,"context_line":"        self.notify_security_groups_member_updated(context, result)"},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"        try:"},{"line_number":1305,"context_line":"            bound_context \u003d self._bind_port_if_needed(mech_context)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_ce5a4183","side":"PARENT","line":1302,"range":{"start_line":1300,"start_character":8,"end_line":1302,"end_character":67},"updated":"2017-02-21 18:29:42.000000000","message":"This doesn\u0027t requires to explicitly call this:\n\n    registry.notify(resources.PORT, events.AFTER_DELETE, self, **kwargs)\n\nBecause is internally called by _post_delete_port in delete_port, right?","commit_id":"e6fd02d9415655e3de0fbfb7ad8787ec82a8a0a1"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"2c77e10c6c578d0fa13b1f6e10d49f8756de82d6","unresolved":false,"context_lines":[{"line_number":1297,"context_line":"                              \"failed, deleting port \u0027%s\u0027\"), result[\u0027id\u0027])"},{"line_number":1298,"context_line":"                self.delete_port(context, result[\u0027id\u0027], l3_port_check\u003dFalse)"},{"line_number":1299,"context_line":""},{"line_number":1300,"context_line":"        # REVISIT(rkukura): Is there any point in calling this before"},{"line_number":1301,"context_line":"        # a binding has been successfully established?"},{"line_number":1302,"context_line":"        self.notify_security_groups_member_updated(context, result)"},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"        try:"},{"line_number":1305,"context_line":"            bound_context \u003d self._bind_port_if_needed(mech_context)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_d8a339ff","side":"PARENT","line":1302,"range":{"start_line":1300,"start_character":8,"end_line":1302,"end_character":67},"in_reply_to":"da36d5c6_ce5a4183","updated":"2017-02-27 15:21:10.000000000","message":"Yep.","commit_id":"e6fd02d9415655e3de0fbfb7ad8787ec82a8a0a1"},{"author":{"_account_id":10518,"name":"Jesse","email":"jesse@easystack.cn","username":"jesse"},"change_message_id":"58887329498da597b3308087ab4137154a5704c2","unresolved":false,"context_lines":[{"line_number":1285,"context_line":"            LOG.error(_LE(\"mechanism_manager.update_port_postcommit \""},{"line_number":1286,"context_line":"                          \"failed for port %s\"), id)"},{"line_number":1287,"context_line":""},{"line_number":1288,"context_line":"        self.check_and_notify_security_group_member_changed("},{"line_number":1289,"context_line":"            context, original_port, updated_port)"},{"line_number":1290,"context_line":"        need_port_update_notify |\u003d self.is_security_group_member_updated("},{"line_number":1291,"context_line":"            context, original_port, updated_port)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_4655cf4f","line":1288,"updated":"2017-09-05 05:00:35.000000000","message":"This will notify agents when needed in port_update.","commit_id":"b9b598040da1b8d3e860b39d9027c10f8576ee33"}]}
