)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"8929bf2ff34f61eb7d7591995789651c50b89f77","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces support for requests where the user does"},{"line_number":10,"context_line":"not know the segmentation details of a subport and by specifying"},{"line_number":11,"context_line":"segmentation_type\u003dinherit,segmentation_id\u003d\u003cport_uuid\u003e will let the"},{"line_number":12,"context_line":"trunk plugin infer these details from the network to which the"},{"line_number":13,"context_line":"subport is connected to."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da36d5c6_ff220c51","line":11,"range":{"start_line":11,"start_character":26,"end_line":11,"end_character":53},"updated":"2017-02-23 12:04:55.000000000","message":"can\u0027t pass uuid here as got\n\n\"Segmentation-id \u0027adde30f4-2dfd-4bcb-a219-0a96f6e3c744\u0027 is not an integer\"\n\nIf pass any integer value it works, but looks strange that user specify segmentation_id when it should be inherited.\n\nIf specify the only segmentation_type validator from neutron-lib raises error [1]. Why not to update neutron-lib validator with for example [0] and specify only segmentation_type\u003d\u0027inherit\u0027?\n\n[0] http://paste.openstack.org/show/600208/\n[1] https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/validators.py#L931","commit_id":"9c25f68869bfb7d5760a49cca18dd836525a4d47"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3e0b0d1931876d6f79b11f6769d9dc726e1a39d9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces support for requests where the user does"},{"line_number":10,"context_line":"not know the segmentation details of a subport and by specifying"},{"line_number":11,"context_line":"segmentation_type\u003dinherit,segmentation_id\u003d\u003cport_uuid\u003e will let the"},{"line_number":12,"context_line":"trunk plugin infer these details from the network to which the"},{"line_number":13,"context_line":"subport is connected to."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da36d5c6_3a54b2c8","line":11,"range":{"start_line":11,"start_character":26,"end_line":11,"end_character":53},"in_reply_to":"da36d5c6_ff220c51","updated":"2017-02-23 12:46:22.000000000","message":"Passing the UUID should work as the positive test demonstrates. Changing the API validator is something I considered, but this means making the API layer aware of a quirk about segmentation types that couples it to the plugin business rules, and I am not particularly fond of that, hence I went with this approach to start with. I am still on the fence though.","commit_id":"9c25f68869bfb7d5760a49cca18dd836525a4d47"}],"neutron/services/trunk/rules.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3fd92aaa96887072fa75496558024e631c14ccd9","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    def _prepare_subports(self, context):"},{"line_number":176,"context_line":"        \"\"\"Update subports segmentation details if INHERIT is requested.\"\"\""},{"line_number":177,"context_line":"        port_ids \u003d {"},{"line_number":178,"context_line":"            s[\u0027port_id\u0027]: i"},{"line_number":179,"context_line":"            for i, s in enumerate(self.subports)"},{"line_number":180,"context_line":"            if s.get(\u0027segmentation_type\u0027) \u003d\u003d constants.INHERIT"},{"line_number":181,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_3c05c9bb","line":178,"updated":"2017-02-22 04:49:57.000000000","message":"why are you enumerating and storing indexes here?\n\nport_ids \u003d {s[\u0027port_id\u0027] for s in self.subports\n            if s.get(\u0027segmentation_type\u0027) \u003d\u003d constants.INHERIT}","commit_id":"0bcd156dde5ce06c077d90c83d9faf5f43388289"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4e88de26da323a2f5f468f954d304d5cfeefbc04","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    def _prepare_subports(self, context):"},{"line_number":176,"context_line":"        \"\"\"Update subports segmentation details if INHERIT is requested.\"\"\""},{"line_number":177,"context_line":"        port_ids \u003d {"},{"line_number":178,"context_line":"            s[\u0027port_id\u0027]: i"},{"line_number":179,"context_line":"            for i, s in enumerate(self.subports)"},{"line_number":180,"context_line":"            if s.get(\u0027segmentation_type\u0027) \u003d\u003d constants.INHERIT"},{"line_number":181,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_dc2aed2b","line":178,"in_reply_to":"da36d5c6_3c05c9bb","updated":"2017-02-22 04:50:51.000000000","message":"because I am doing a replacement on like 196.","commit_id":"0bcd156dde5ce06c077d90c83d9faf5f43388289"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"78564dd516c35287bdda51228df30af6b3ca7b45","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    def _prepare_subports(self, context):"},{"line_number":176,"context_line":"        \"\"\"Update subports segmentation details if INHERIT is requested.\"\"\""},{"line_number":177,"context_line":"        port_ids \u003d {"},{"line_number":178,"context_line":"            s[\u0027port_id\u0027]: i"},{"line_number":179,"context_line":"            for i, s in enumerate(self.subports)"},{"line_number":180,"context_line":"            if s.get(\u0027segmentation_type\u0027) \u003d\u003d constants.INHERIT"},{"line_number":181,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_1ccba573","line":178,"in_reply_to":"da36d5c6_dc2aed2b","updated":"2017-02-22 04:55:10.000000000","message":"ah","commit_id":"0bcd156dde5ce06c077d90c83d9faf5f43388289"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"aa81f3e0c00f963657bdfc492fd6467240f5e5dc","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            s[\u0027port_id\u0027]: i"},{"line_number":179,"context_line":"            for i, s in enumerate(self.subports)"},{"line_number":180,"context_line":"            if s.get(\u0027segmentation_type\u0027) \u003d\u003d constants.INHERIT"},{"line_number":181,"context_line":"        }"},{"line_number":182,"context_line":"        core_plugin \u003d directory.get_plugin()"},{"line_number":183,"context_line":"        ports \u003d core_plugin.get_ports(context, filters\u003d{\u0027id\u0027: port_ids})"},{"line_number":184,"context_line":"        # this assumes a user does not try to trunk the same network"}],"source_content_type":"text/x-python","patch_set":4,"id":"da36d5c6_4e51bf35","line":181,"updated":"2017-02-22 20:43:23.000000000","message":"if port_ids are empty we may just return here to avoid doing unnecessary work.","commit_id":"d67fc35dd60cfa54d4c28026ca7dee2439492ce2"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f17189358e4e7cd7f783ed8a40781bd9f84c1119","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            s[\u0027port_id\u0027]: i"},{"line_number":179,"context_line":"            for i, s in enumerate(self.subports)"},{"line_number":180,"context_line":"            if s.get(\u0027segmentation_type\u0027) \u003d\u003d constants.INHERIT"},{"line_number":181,"context_line":"        }"},{"line_number":182,"context_line":"        core_plugin \u003d directory.get_plugin()"},{"line_number":183,"context_line":"        ports \u003d core_plugin.get_ports(context, filters\u003d{\u0027id\u0027: port_ids})"},{"line_number":184,"context_line":"        # this assumes a user does not try to trunk the same network"}],"source_content_type":"text/x-python","patch_set":4,"id":"da36d5c6_224adfac","line":181,"in_reply_to":"da36d5c6_4e51bf35","updated":"2017-02-22 20:57:09.000000000","message":"Yeah, I guess I can skip to save the extra lookup with empty result sets.","commit_id":"d67fc35dd60cfa54d4c28026ca7dee2439492ce2"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"6ddb05c4547222ecbf0ca259659c4f5a247a66bf","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            context.elevated(), filters\u003d{\u0027id\u0027: network_port_map})"},{"line_number":194,"context_line":"        for net in networks:"},{"line_number":195,"context_line":"            port \u003d network_port_map[net[\u0027id\u0027]]"},{"line_number":196,"context_line":"            port.update({\u0027segmentation_id\u0027: net[providernet.SEGMENTATION_ID],"},{"line_number":197,"context_line":"                         \u0027segmentation_type\u0027: net[providernet.NETWORK_TYPE]})"},{"line_number":198,"context_line":"            self.subports[port_ids[port[\u0027port_id\u0027]]] \u003d port"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_0a3f05b5","line":196,"updated":"2017-03-07 20:12:01.000000000","message":"we marked providernet as optional in the extension definition, so I think you need to add some safely validation above this that checks that these keys are actually present in the network (check for extension or check for keys directly)","commit_id":"87d15b3e50f21a64821c167c48a44d684850a9df"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7c26480aeb78ddfaa6ee229d0c1ea4d5fc2b49f9","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            context.elevated(), filters\u003d{\u0027id\u0027: network_port_map})"},{"line_number":194,"context_line":"        for net in networks:"},{"line_number":195,"context_line":"            port \u003d network_port_map[net[\u0027id\u0027]]"},{"line_number":196,"context_line":"            port.update({\u0027segmentation_id\u0027: net[providernet.SEGMENTATION_ID],"},{"line_number":197,"context_line":"                         \u0027segmentation_type\u0027: net[providernet.NETWORK_TYPE]})"},{"line_number":198,"context_line":"            self.subports[port_ids[port[\u0027port_id\u0027]]] \u003d port"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_8a6855f7","line":196,"in_reply_to":"9a30ddce_0a3f05b5","updated":"2017-03-07 20:30:07.000000000","message":"oh shoot, I forgot to update this piece.","commit_id":"87d15b3e50f21a64821c167c48a44d684850a9df"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"537d2e7b55969b8fae95e36e19126fb173e3a9ba","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            for x in ports"},{"line_number":196,"context_line":"        }"},{"line_number":197,"context_line":"        networks \u003d core_plugin.get_networks("},{"line_number":198,"context_line":"            context.elevated(), filters\u003d{\u0027id\u0027: network_port_map})"},{"line_number":199,"context_line":"        for net in networks:"},{"line_number":200,"context_line":"            port \u003d network_port_map[net[\u0027id\u0027]]"},{"line_number":201,"context_line":"            port.update({\u0027segmentation_id\u0027: net[providernet.SEGMENTATION_ID],"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_6ce021fb","line":198,"updated":"2017-03-22 03:44:35.000000000","message":"should we validate that the networks are indeed provider networks?","commit_id":"7942dc2650c11aa73d14b43b48c4194ddee88226"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"046b09d152d1bbcbdbda683922fa3190a2785f87","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            for x in ports"},{"line_number":196,"context_line":"        }"},{"line_number":197,"context_line":"        networks \u003d core_plugin.get_networks("},{"line_number":198,"context_line":"            context.elevated(), filters\u003d{\u0027id\u0027: network_port_map})"},{"line_number":199,"context_line":"        for net in networks:"},{"line_number":200,"context_line":"            port \u003d network_port_map[net[\u0027id\u0027]]"},{"line_number":201,"context_line":"            port.update({\u0027segmentation_id\u0027: net[providernet.SEGMENTATION_ID],"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_9f2d3000","line":198,"in_reply_to":"1a1ced50_14777ea0","updated":"2017-03-23 15:05:38.000000000","message":"For other networks, segmentation ID doesn\u0027t serve a good indicator of what to use. I usually prefer to harden database from potentially bad data than deal with it later when it\u0027s in.","commit_id":"7942dc2650c11aa73d14b43b48c4194ddee88226"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"57d0238a7ff87f11124c867a1476304ac35bc23f","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            for x in ports"},{"line_number":196,"context_line":"        }"},{"line_number":197,"context_line":"        networks \u003d core_plugin.get_networks("},{"line_number":198,"context_line":"            context.elevated(), filters\u003d{\u0027id\u0027: network_port_map})"},{"line_number":199,"context_line":"        for net in networks:"},{"line_number":200,"context_line":"            port \u003d network_port_map[net[\u0027id\u0027]]"},{"line_number":201,"context_line":"            port.update({\u0027segmentation_id\u0027: net[providernet.SEGMENTATION_ID],"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_14777ea0","line":198,"in_reply_to":"1a1ced50_6ce021fb","updated":"2017-03-23 05:19:15.000000000","message":"That would be easily done, by checking the provider:physical_network attribute in the network object, though I am not 100% sure this is the right limitation at this point.","commit_id":"7942dc2650c11aa73d14b43b48c4194ddee88226"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1a44786f6134a3e67ea3c06f0ec156dbf3cd9aa5","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        core_plugin \u003d directory.get_plugin()"},{"line_number":185,"context_line":"        if not port_ids:"},{"line_number":186,"context_line":"            return"},{"line_number":187,"context_line":"        elif not n_utils.is_extension_supported(core_plugin, provider.ALIAS):"},{"line_number":188,"context_line":"            msg \u003d _(\"Cannot accept segmentation type %s\") % constants.INHERIT"},{"line_number":189,"context_line":"            raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a1ced50_be71240e","line":187,"updated":"2017-03-23 07:37:11.000000000","message":"nit - consider doing this check at the begining of the method - then we can save a number of cycles of looping over the ports","commit_id":"3ba94c723f55224187eb01159b51ac38efe75e74"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"307ed9f11c590e436ff5889a507c8c84ddf022ec","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        core_plugin \u003d directory.get_plugin()"},{"line_number":185,"context_line":"        if not port_ids:"},{"line_number":186,"context_line":"            return"},{"line_number":187,"context_line":"        elif not n_utils.is_extension_supported(core_plugin, provider.ALIAS):"},{"line_number":188,"context_line":"            msg \u003d _(\"Cannot accept segmentation type %s\") % constants.INHERIT"},{"line_number":189,"context_line":"            raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a1ced50_df6c08d2","line":187,"in_reply_to":"1a1ced50_be71240e","updated":"2017-03-23 14:50:35.000000000","message":"+1 as the port_ids dict can be relocated ..","commit_id":"3ba94c723f55224187eb01159b51ac38efe75e74"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"cd68a4937660ba9f8797a52fc9826f03ccaaebe0","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        core_plugin \u003d directory.get_plugin()"},{"line_number":185,"context_line":"        if not port_ids:"},{"line_number":186,"context_line":"            return"},{"line_number":187,"context_line":"        elif not n_utils.is_extension_supported(core_plugin, provider.ALIAS):"},{"line_number":188,"context_line":"            msg \u003d _(\"Cannot accept segmentation type %s\") % constants.INHERIT"},{"line_number":189,"context_line":"            raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a1ced50_df240861","line":187,"in_reply_to":"1a1ced50_df6c08d2","updated":"2017-03-23 14:54:47.000000000","message":"This is here on purpose: because if there\u0027s no INHERIT request you don\u0027t need to fail.","commit_id":"3ba94c723f55224187eb01159b51ac38efe75e74"}],"neutron/tests/contrib/gate_hook.sh":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"537d2e7b55969b8fae95e36e19126fb173e3a9ba","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    load_rc_hook qos"},{"line_number":98,"context_line":"    load_rc_hook trunk"},{"line_number":99,"context_line":"    load_conf_hook mtu"},{"line_number":100,"context_line":"    load_conf_hook vlan_provider"},{"line_number":101,"context_line":"    load_conf_hook osprofiler"},{"line_number":102,"context_line":"    if [[ \"$VENV\" \u003d~ \"dsvm-scenario\" ]]; then"},{"line_number":103,"context_line":"        load_conf_hook iptables_verify"}],"source_content_type":"text/x-sh","patch_set":8,"id":"1a1ced50_0c608da4","line":100,"updated":"2017-03-22 03:44:35.000000000","message":"(No action required) could isolate that hook to api jobs only.","commit_id":"7942dc2650c11aa73d14b43b48c4194ddee88226"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"57d0238a7ff87f11124c867a1476304ac35bc23f","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    load_rc_hook qos"},{"line_number":98,"context_line":"    load_rc_hook trunk"},{"line_number":99,"context_line":"    load_conf_hook mtu"},{"line_number":100,"context_line":"    load_conf_hook vlan_provider"},{"line_number":101,"context_line":"    load_conf_hook osprofiler"},{"line_number":102,"context_line":"    if [[ \"$VENV\" \u003d~ \"dsvm-scenario\" ]]; then"},{"line_number":103,"context_line":"        load_conf_hook iptables_verify"}],"source_content_type":"text/x-sh","patch_set":8,"id":"1a1ced50_946b6eb6","line":100,"in_reply_to":"1a1ced50_0c608da4","updated":"2017-03-23 05:19:15.000000000","message":"Don\u0027t do that for others :(","commit_id":"7942dc2650c11aa73d14b43b48c4194ddee88226"}],"neutron/tests/tempest/api/test_trunk.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"537d2e7b55969b8fae95e36e19126fb173e3a9ba","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        return self.create_shared_network(**post_body)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @decorators.idempotent_id(\u00270f05d98e-41f5-4629-dada-9aee269c9602\u0027)"},{"line_number":242,"context_line":"    def test_add_subport(self):"},{"line_number":243,"context_line":"        trunk_network \u003d self.create_provider_network()"},{"line_number":244,"context_line":"        trunk_port \u003d self.create_port(trunk_network)"},{"line_number":245,"context_line":"        subport_networks \u003d ["}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_acf859c4","line":242,"updated":"2017-03-22 03:44:35.000000000","message":"this test will immediately fail when attempt to execute it outside the gate will occur, because the provider network does not exist. I think we should gracefully handle the case where there is no physical network satisfying the request, by skipping the test.","commit_id":"7942dc2650c11aa73d14b43b48c4194ddee88226"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"bc5947d0ed06fd8f99e110d8e99156ed96438ae5","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        return self.create_shared_network(**post_body)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @decorators.idempotent_id(\u00270f05d98e-41f5-4629-dada-9aee269c9602\u0027)"},{"line_number":242,"context_line":"    def test_add_subport(self):"},{"line_number":243,"context_line":"        trunk_network \u003d self.create_provider_network()"},{"line_number":244,"context_line":"        trunk_port \u003d self.create_port(trunk_network)"},{"line_number":245,"context_line":"        subport_networks \u003d ["}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_bd040118","line":242,"in_reply_to":"1a1ced50_acf859c4","updated":"2017-03-22 06:37:24.000000000","message":"Valid concern. I suppose I need to add something to skip_checks, though I can\u0027t come up with anything clean.","commit_id":"7942dc2650c11aa73d14b43b48c4194ddee88226"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"41dcb4e4ab4f9350c973333695e0a29325170f53","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        return self.create_shared_network(**post_body)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @decorators.idempotent_id(\u00270f05d98e-41f5-4629-dada-9aee269c9602\u0027)"},{"line_number":242,"context_line":"    def test_add_subport(self):"},{"line_number":243,"context_line":"        trunk_network \u003d self.create_provider_network()"},{"line_number":244,"context_line":"        trunk_port \u003d self.create_port(trunk_network)"},{"line_number":245,"context_line":"        subport_networks \u003d ["}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_c9d008cc","line":242,"in_reply_to":"1a1ced50_bd040118","updated":"2017-03-22 16:46:16.000000000","message":"We may want to introduce a new tempest config option that would specify the network to use; then if it\u0027s not set, we skip.","commit_id":"7942dc2650c11aa73d14b43b48c4194ddee88226"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"23fc3d0198dadd42694ff13ab17ea211410194cf","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        return self.create_shared_network(**post_body)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @decorators.idempotent_id(\u00270f05d98e-41f5-4629-dada-9aee269c9602\u0027)"},{"line_number":242,"context_line":"    def test_add_subport(self):"},{"line_number":243,"context_line":"        trunk_network \u003d self.create_provider_network()"},{"line_number":244,"context_line":"        trunk_port \u003d self.create_port(trunk_network)"},{"line_number":245,"context_line":"        subport_networks \u003d ["}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_472cfc98","line":242,"in_reply_to":"1a1ced50_c9d008cc","updated":"2017-03-22 18:57:47.000000000","message":"right, that\u0027s what I hate.","commit_id":"7942dc2650c11aa73d14b43b48c4194ddee88226"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ee9b44d4980385bad933f514b6c59a2f07f5449b","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                msg \u003d \"%s extension not enabled.\" % ext"},{"line_number":233,"context_line":"                raise cls.skipException(msg)"},{"line_number":234,"context_line":"        if not config.CONF.neutron_plugin_options.provider_vlans:"},{"line_number":235,"context_line":"            raise cls.skipException(\"No provider VLAN networks avaiable\")"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def create_provider_network(self):"},{"line_number":238,"context_line":"        foo_net \u003d config.CONF.neutron_plugin_options.provider_vlans[0]"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a1ced50_3f3d1c2b","line":235,"range":{"start_line":235,"start_character":63,"end_line":235,"end_character":71},"updated":"2017-03-23 15:05:21.000000000","message":"available","commit_id":"5fedaa33f749dd11e55b3dfae9d7aa0435197c34"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"87601242a0ea0cb5b71be623300585237ea44430","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                msg \u003d \"%s extension not enabled.\" % ext"},{"line_number":233,"context_line":"                raise cls.skipException(msg)"},{"line_number":234,"context_line":"        if not config.CONF.neutron_plugin_options.provider_vlans:"},{"line_number":235,"context_line":"            raise cls.skipException(\"No provider VLAN networks avaiable\")"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def create_provider_network(self):"},{"line_number":238,"context_line":"        foo_net \u003d config.CONF.neutron_plugin_options.provider_vlans[0]"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a1ced50_c6e524dd","line":235,"range":{"start_line":235,"start_character":63,"end_line":235,"end_character":71},"in_reply_to":"1a1ced50_3f3d1c2b","updated":"2017-03-23 15:44:50.000000000","message":"doh!","commit_id":"5fedaa33f749dd11e55b3dfae9d7aa0435197c34"}],"neutron/tests/tempest/config.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ee9b44d4980385bad933f514b6c59a2f07f5449b","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"NeutronPluginOptions \u003d ["},{"line_number":22,"context_line":"    cfg.ListOpt(\u0027provider_vlans\u0027,"},{"line_number":23,"context_line":"                default\u003d[],"},{"line_number":24,"context_line":"                help\u003d\u0027List of provider networks available in the deployment.\u0027),"},{"line_number":25,"context_line":"    cfg.BoolOpt(\u0027specify_floating_ip_address_available\u0027,"},{"line_number":26,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a1ced50_7f1a34c7","line":23,"updated":"2017-03-23 15:05:21.000000000","message":"to understand the intent here, it\u0027s a list because you plan for the times when a test may need to use two provider networks?","commit_id":"5fedaa33f749dd11e55b3dfae9d7aa0435197c34"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"87601242a0ea0cb5b71be623300585237ea44430","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"NeutronPluginOptions \u003d ["},{"line_number":22,"context_line":"    cfg.ListOpt(\u0027provider_vlans\u0027,"},{"line_number":23,"context_line":"                default\u003d[],"},{"line_number":24,"context_line":"                help\u003d\u0027List of provider networks available in the deployment.\u0027),"},{"line_number":25,"context_line":"    cfg.BoolOpt(\u0027specify_floating_ip_address_available\u0027,"},{"line_number":26,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a1ced50_66ee30b6","line":23,"in_reply_to":"1a1ced50_7f1a34c7","updated":"2017-03-23 15:44:50.000000000","message":"yeah, design for change.","commit_id":"5fedaa33f749dd11e55b3dfae9d7aa0435197c34"}],"neutron/tests/unit/services/trunk/test_rules.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"537d2e7b55969b8fae95e36e19126fb173e3a9ba","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        mock.patch.object(rules.SubPortsValidator, \u0027_get_port_mtu\u0027,"},{"line_number":137,"context_line":"                          return_value\u003dNone).start()"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test__prepare_subports(self):"},{"line_number":140,"context_line":"        validator \u003d rules.SubPortsValidator("},{"line_number":141,"context_line":"            self.segmentation_types,"},{"line_number":142,"context_line":"            [{\u0027port_id\u0027: uuidutils.generate_uuid(),"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_accdb986","line":139,"updated":"2017-03-22 03:44:35.000000000","message":"would be nice to have the test case have a name that would explain which case you validate here.","commit_id":"7942dc2650c11aa73d14b43b48c4194ddee88226"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"57d0238a7ff87f11124c867a1476304ac35bc23f","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        mock.patch.object(rules.SubPortsValidator, \u0027_get_port_mtu\u0027,"},{"line_number":137,"context_line":"                          return_value\u003dNone).start()"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test__prepare_subports(self):"},{"line_number":140,"context_line":"        validator \u003d rules.SubPortsValidator("},{"line_number":141,"context_line":"            self.segmentation_types,"},{"line_number":142,"context_line":"            [{\u0027port_id\u0027: uuidutils.generate_uuid(),"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_d4b8862c","line":139,"in_reply_to":"1a1ced50_accdb986","updated":"2017-03-23 05:19:15.000000000","message":"Done","commit_id":"7942dc2650c11aa73d14b43b48c4194ddee88226"}],"releasenotes/notes/trunk_inherit-455dc74b9fa22dad.yaml":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"537d2e7b55969b8fae95e36e19126fb173e3a9ba","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Subport segmentation details can now accept ``inherit`` as segmentation"},{"line_number":4,"context_line":"    type during a trunk creation/update request.  The trunk plugin will"},{"line_number":5,"context_line":"    determine the segmentation type and ID and replace them  with those of"},{"line_number":6,"context_line":"    the network to which the port is connected.  Only single-segment VLAN"},{"line_number":7,"context_line":"    networks are set to have expected and correct results at this point."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1a1ced50_ecc33155","line":5,"range":{"start_line":5,"start_character":59,"end_line":5,"end_character":60},"updated":"2017-03-22 03:44:35.000000000","message":"remove","commit_id":"7942dc2650c11aa73d14b43b48c4194ddee88226"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"33f9698ccb7b1588446679067bb38c4d5dccda50","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Subport segmentation details can now accept ``inherit`` as segmentation"},{"line_number":4,"context_line":"    type during a trunk creation/update request.  The trunk plugin will"},{"line_number":5,"context_line":"    determine the segmentation type and ID and replace them  with those of"},{"line_number":6,"context_line":"    the network to which the port is connected.  Only single-segment VLAN"},{"line_number":7,"context_line":"    networks are set to have expected and correct results at this point."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1a1ced50_1fcdc065","line":5,"range":{"start_line":5,"start_character":59,"end_line":5,"end_character":60},"in_reply_to":"1a1ced50_1485be58","updated":"2017-03-23 15:00:15.000000000","message":"Sorry I always forget about boilerplate politeness. But nevertheless know I love you!!! :)","commit_id":"7942dc2650c11aa73d14b43b48c4194ddee88226"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"10f1ea22338e7198b0f80cb2fb05df6e22b543bd","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Subport segmentation details can now accept ``inherit`` as segmentation"},{"line_number":4,"context_line":"    type during a trunk creation/update request.  The trunk plugin will"},{"line_number":5,"context_line":"    determine the segmentation type and ID and replace them  with those of"},{"line_number":6,"context_line":"    the network to which the port is connected.  Only single-segment VLAN"},{"line_number":7,"context_line":"    networks are set to have expected and correct results at this point."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1a1ced50_063e5c29","line":5,"range":{"start_line":5,"start_character":59,"end_line":5,"end_character":60},"in_reply_to":"1a1ced50_1fcdc065","updated":"2017-03-23 15:45:15.000000000","message":"I know you do!","commit_id":"7942dc2650c11aa73d14b43b48c4194ddee88226"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"57d0238a7ff87f11124c867a1476304ac35bc23f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Subport segmentation details can now accept ``inherit`` as segmentation"},{"line_number":4,"context_line":"    type during a trunk creation/update request.  The trunk plugin will"},{"line_number":5,"context_line":"    determine the segmentation type and ID and replace them  with those of"},{"line_number":6,"context_line":"    the network to which the port is connected.  Only single-segment VLAN"},{"line_number":7,"context_line":"    networks are set to have expected and correct results at this point."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1a1ced50_1485be58","line":5,"range":{"start_line":5,"start_character":59,"end_line":5,"end_character":60},"in_reply_to":"1a1ced50_ecc33155","updated":"2017-03-23 05:19:15.000000000","message":"You could ask nicely ;)","commit_id":"7942dc2650c11aa73d14b43b48c4194ddee88226"}]}
