)]}'
{"neutron/tests/common/helpers.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1abded519c5518afb03b43c8f3bfc3124b68411b","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    return random.choice(list(available_vlans))"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"def skip_if_ovs_older_than(ovs_version):"},{"line_number":229,"context_line":"    \"\"\"Decorator for test method to skip if OVS version doesn\u0027t meet"},{"line_number":230,"context_line":"       minimal requirement."},{"line_number":231,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_a18216c6","line":228,"updated":"2017-02-24 05:44:43.000000000","message":"We could also have some tests for the decorator itself, but ok.","commit_id":"a00c109898edc86756c2231a214c6c8fb0fca563"}],"neutron/tests/functional/agent/test_ovs_flows.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"0ce4bd917b44142805c827fcf393264b74bef4f6","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        self.assertIn((\"dl_src\u003d%(gateway_mac)s\" % kwargs),"},{"line_number":404,"context_line":"                      trace[\"Final flow\"])"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    @_skip_if_bad_ovs"},{"line_number":407,"context_line":"    def test_install_flood_to_tun(self):"},{"line_number":408,"context_line":"        attrs \u003d {"},{"line_number":409,"context_line":"            \u0027remote_ip\u0027: \u0027192.0.2.1\u0027,  # RFC 5737 TEST-NET-1"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_adb16549","line":406,"updated":"2017-02-22 19:40:32.000000000","message":"I can see this being useful for other purposes. What if you turn this decorator in one that accepts a min_version of ovs, and call it \u0027skip_if_ovs_older_than\u0027?","commit_id":"8434649ea6e4e858d9d749bb148f992aa4e29081"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"aec40ac615a631e9105b229281bba5c118465629","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        self.assertIn((\"dl_src\u003d%(gateway_mac)s\" % kwargs),"},{"line_number":404,"context_line":"                      trace[\"Final flow\"])"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    @_skip_if_bad_ovs"},{"line_number":407,"context_line":"    def test_install_flood_to_tun(self):"},{"line_number":408,"context_line":"        attrs \u003d {"},{"line_number":409,"context_line":"            \u0027remote_ip\u0027: \u0027192.0.2.1\u0027,  # RFC 5737 TEST-NET-1"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_a25def7a","line":406,"in_reply_to":"da36d5c6_adb16549","updated":"2017-02-22 20:56:47.000000000","message":"Done","commit_id":"8434649ea6e4e858d9d749bb148f992aa4e29081"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"388f5b674ac201bda7928e4472cc9df05dba0d56","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        self.assertIn((\"dl_src\u003d%(gateway_mac)s\" % kwargs),"},{"line_number":389,"context_line":"                      trace[\"Final flow\"])"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    @helpers.skip_if_ovs_older_than(\"2.5.1\")"},{"line_number":392,"context_line":"    def test_install_flood_to_tun(self):"},{"line_number":393,"context_line":"        attrs \u003d {"},{"line_number":394,"context_line":"            \u0027remote_ip\u0027: \u0027192.0.2.1\u0027,  # RFC 5737 TEST-NET-1"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_a1fc0073","line":391,"range":{"start_line":391,"start_character":13,"end_line":391,"end_character":21},"updated":"2017-02-23 06:17:27.000000000","message":"I wonder if we could instead use xfail here: http://doc.pytest.org/en/latest/skipping.html#mark-a-test-function-as-expected-to-fail\n\nOf course we would need to solve the lack of pytest in global-requirements.txt first. There is also a separate pypi xfail package, though I am not sure what\u0027s the license there, and if it\u0027s stable enough for our needs. pytest sounds like a more mature project.","commit_id":"a00c109898edc86756c2231a214c6c8fb0fca563"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"f6d475c0f1e4b0e1e66e78926d368066b7f47d4f","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        self.assertIn((\"dl_src\u003d%(gateway_mac)s\" % kwargs),"},{"line_number":389,"context_line":"                      trace[\"Final flow\"])"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    @helpers.skip_if_ovs_older_than(\"2.5.1\")"},{"line_number":392,"context_line":"    def test_install_flood_to_tun(self):"},{"line_number":393,"context_line":"        attrs \u003d {"},{"line_number":394,"context_line":"            \u0027remote_ip\u0027: \u0027192.0.2.1\u0027,  # RFC 5737 TEST-NET-1"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_bb299139","line":391,"updated":"2017-02-23 04:24:46.000000000","message":"In the gate, functional jobs are only run on xenial. So this change leaves this test unchecked in the gate.\n\nDo you think not compiling ovs is better than a skipping a test?","commit_id":"a00c109898edc86756c2231a214c6c8fb0fca563"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"503d87f651db421a2641afe2a31acc9aae7b6b39","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        self.assertIn((\"dl_src\u003d%(gateway_mac)s\" % kwargs),"},{"line_number":389,"context_line":"                      trace[\"Final flow\"])"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    @helpers.skip_if_ovs_older_than(\"2.5.1\")"},{"line_number":392,"context_line":"    def test_install_flood_to_tun(self):"},{"line_number":393,"context_line":"        attrs \u003d {"},{"line_number":394,"context_line":"            \u0027remote_ip\u0027: \u0027192.0.2.1\u0027,  # RFC 5737 TEST-NET-1"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_61f04868","line":391,"in_reply_to":"da36d5c6_21dad017","updated":"2017-02-23 06:45:01.000000000","message":"Ok. understood. Thanks for the explanation.","commit_id":"a00c109898edc86756c2231a214c6c8fb0fca563"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3e1bf2f17631d9ca15537e32c3c5739e8a08c6c7","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        self.assertIn((\"dl_src\u003d%(gateway_mac)s\" % kwargs),"},{"line_number":389,"context_line":"                      trace[\"Final flow\"])"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    @helpers.skip_if_ovs_older_than(\"2.5.1\")"},{"line_number":392,"context_line":"    def test_install_flood_to_tun(self):"},{"line_number":393,"context_line":"        attrs \u003d {"},{"line_number":394,"context_line":"            \u0027remote_ip\u0027: \u0027192.0.2.1\u0027,  # RFC 5737 TEST-NET-1"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_389839c0","line":391,"in_reply_to":"da36d5c6_61f04868","updated":"2017-02-23 14:15:09.000000000","message":"Also with compilation we differ in testing suite from what is shipped.","commit_id":"a00c109898edc86756c2231a214c6c8fb0fca563"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3e1bf2f17631d9ca15537e32c3c5739e8a08c6c7","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        self.assertIn((\"dl_src\u003d%(gateway_mac)s\" % kwargs),"},{"line_number":389,"context_line":"                      trace[\"Final flow\"])"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    @helpers.skip_if_ovs_older_than(\"2.5.1\")"},{"line_number":392,"context_line":"    def test_install_flood_to_tun(self):"},{"line_number":393,"context_line":"        attrs \u003d {"},{"line_number":394,"context_line":"            \u0027remote_ip\u0027: \u0027192.0.2.1\u0027,  # RFC 5737 TEST-NET-1"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_f86b01b7","line":391,"range":{"start_line":391,"start_character":13,"end_line":391,"end_character":21},"in_reply_to":"da36d5c6_a1fc0073","updated":"2017-02-23 14:15:09.000000000","message":"What would be the reason for executing a test we know is gonna fail with this ovs version? I don\u0027t see any benefit in it.","commit_id":"a00c109898edc86756c2231a214c6c8fb0fca563"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"388f5b674ac201bda7928e4472cc9df05dba0d56","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        self.assertIn((\"dl_src\u003d%(gateway_mac)s\" % kwargs),"},{"line_number":389,"context_line":"                      trace[\"Final flow\"])"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    @helpers.skip_if_ovs_older_than(\"2.5.1\")"},{"line_number":392,"context_line":"    def test_install_flood_to_tun(self):"},{"line_number":393,"context_line":"        attrs \u003d {"},{"line_number":394,"context_line":"            \u0027remote_ip\u0027: \u0027192.0.2.1\u0027,  # RFC 5737 TEST-NET-1"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_21dad017","line":391,"in_reply_to":"da36d5c6_bb299139","updated":"2017-02-23 06:17:27.000000000","message":"Yes, that was a decision made on PTG today. Leaving compilation in gate means that we are affected by network connectivity issues to the git repo with ovs code. (We hit that several days ago, where the whole gate turned red because of the git repo was not accessible from inside openstack infra; we don\u0027t want to leave the gate exposed to similar issues; if it\u0027s a matter of a single known test case, the price is reasonable).","commit_id":"a00c109898edc86756c2231a214c6c8fb0fca563"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1abded519c5518afb03b43c8f3bfc3124b68411b","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        self.assertIn((\"dl_src\u003d%(gateway_mac)s\" % kwargs),"},{"line_number":389,"context_line":"                      trace[\"Final flow\"])"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    @helpers.skip_if_ovs_older_than(\"2.5.1\")"},{"line_number":392,"context_line":"    def test_install_flood_to_tun(self):"},{"line_number":393,"context_line":"        attrs \u003d {"},{"line_number":394,"context_line":"            \u0027remote_ip\u0027: \u0027192.0.2.1\u0027,  # RFC 5737 TEST-NET-1"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_e1424ead","line":391,"range":{"start_line":391,"start_character":13,"end_line":391,"end_character":21},"in_reply_to":"da36d5c6_f86b01b7","updated":"2017-02-24 05:44:43.000000000","message":"Hm, I guess you are right. It may make sense to xfail if a test is unstable, but if we know it will fail for sure, it\u0027s less of value to collect the data point.","commit_id":"a00c109898edc86756c2231a214c6c8fb0fca563"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"503d87f651db421a2641afe2a31acc9aae7b6b39","unresolved":false,"context_lines":[{"line_number":411,"context_line":"        self.br_tun.delete_flood_to_tun(kwargs[\u0027vlan\u0027])"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        trace \u003d self._run_trace(self.tun_br.br_name, test_packet)"},{"line_number":414,"context_line":"        self.assertEqual(\" unchanged\", trace[\"Final flow\"])"},{"line_number":415,"context_line":"        self.assertIn(\"drop\", trace[\"Datapath actions\"])"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_e10ef839","line":414,"updated":"2017-02-23 06:45:01.000000000","message":"An alternative is to temporary use the following workaround.\n\nhttps://review.openstack.org/#/c/235155/10/neutron/tests/functional/agent/test_ovs_flows.py@399","commit_id":"a00c109898edc86756c2231a214c6c8fb0fca563"}]}
