)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"e2b1af8ab4a5a1dad5edb4d2738e6fb360760387","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-03-10 12:56:43 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"devstack: Adapt to lib/neutron"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: I9068fd608e82e70db8d725f92269a26920efebcb"},{"line_number":10,"context_line":"Change-Id: Idcb903002aec823aa1e546e8e90815ebac614e5b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a1ff146_fab38608","line":8,"updated":"2017-03-14 18:18:48.000000000","message":"nit: there are many changes that deserve to be mentioned here.","commit_id":"a9a2f0f5ad307a929689eb71ce7e916c73c991fd"}],"devstack/lib/l2_agent_sriovnicswitch":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"e2b1af8ab4a5a1dad5edb4d2738e6fb360760387","unresolved":false,"context_lines":[{"line_number":15,"context_line":"}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"function start_l2_agent_sriov {"},{"line_number":18,"context_line":"    if is_neutron_legacy_enabled; then"},{"line_number":19,"context_line":"        SERVICE_NAME\u003dq-sriov-agt"},{"line_number":20,"context_line":"    else"},{"line_number":21,"context_line":"        SERVICE_NAME\u003dneutron-sriov-agent"},{"line_number":22,"context_line":"    fi"},{"line_number":23,"context_line":"    run_process $SERVICE_NAME \"$SRIOV_AGENT_BINARY --config-file $NEUTRON_CONF --config-file /$SRIOV_AGENT_CONF\""},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a1ff146_44f683d8","line":22,"range":{"start_line":18,"start_character":4,"end_line":22,"end_character":6},"updated":"2017-03-14 18:18:48.000000000","message":"nit: IMHO, this doesn\u0027t change the current behavior but at least express the desired to have a default option.\n\n    SERVICE_NAME\u003dneutron-sriov-agent\n    if is_neutron_legacy_enabled; then\n        SERVICE_NAME\u003dq-sriov-agt\n    fi","commit_id":"a9a2f0f5ad307a929689eb71ce7e916c73c991fd"}],"devstack/plugin.sh":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"145765175d0a8a5a1df5c6f1954f62e8a9e60ca2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"LIBDIR\u003d$DEST/neutron/devstack/lib"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if is_neutron_legacy_enabled; then"},{"line_number":4,"context_line":"    NEUTRON_CORE_PLUGIN\u003d$Q_PLUGIN"},{"line_number":5,"context_line":"    NEUTRON_AGENT\u003d$Q_AGENT"},{"line_number":6,"context_line":"    NEUTRON_CORE_PLUGIN_CONF_PATH\u003d$Q_PLUGIN_CONF_PATH"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3a1ff146_babbce74","line":3,"updated":"2017-03-14 18:29:55.000000000","message":"These changes seem to be managed by another patch[1] shouldn\u0027t be better to rebase on the top of that one?\n\n[1] https://review.openstack.org/#/c/445294/1/devstack/plugin.sh@3","commit_id":"a9a2f0f5ad307a929689eb71ce7e916c73c991fd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9bf742a073ee9c1757478150ab845e1d233999c0","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            ;;"},{"line_number":38,"context_line":"        post-config)"},{"line_number":39,"context_line":"            if is_service_enabled q-flavors neutron-flavors; then"},{"line_number":40,"context_line":"                configure_flavors"},{"line_number":41,"context_line":"            fi"},{"line_number":42,"context_line":"            if is_service_enabled q-qos neutron-qos; then"},{"line_number":43,"context_line":"                configure_qos"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a30ddce_41a4da06","line":40,"updated":"2017-03-13 05:27:10.000000000","message":"flavors should stay where they are","commit_id":"a9a2f0f5ad307a929689eb71ce7e916c73c991fd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"853f622090997e1ea6b5f2130fe725f04ff336b9","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            if is_service_enabled q-flavors neutron-flavors; then"},{"line_number":40,"context_line":"                configure_flavors"},{"line_number":41,"context_line":"            fi"},{"line_number":42,"context_line":"            if is_service_enabled q-qos neutron-qos; then"},{"line_number":43,"context_line":"                configure_qos"},{"line_number":44,"context_line":"            fi"},{"line_number":45,"context_line":"            if is_service_enabled q-trunk neutron-trunk; then"},{"line_number":46,"context_line":"                configure_trunk_extension"},{"line_number":47,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a30ddce_c14a8a54","line":44,"range":{"start_line":42,"start_character":12,"end_line":44,"end_character":14},"updated":"2017-03-13 05:24:25.000000000","message":"I disagree with moving this here too. This call is meant to update devstack lib/neutron variables, that will later be used by lib/neutron to configure files. The way it is right now, first lib/neutron sets its own values, then you attempt to override. And it doesn\u0027t play nice with qos hook that we have and that should append to variables not touch config files.","commit_id":"a9a2f0f5ad307a929689eb71ce7e916c73c991fd"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6c7d0e914ceb200adbae9ed110a2cdfcc3b39f99","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            if is_service_enabled q-flavors neutron-flavors; then"},{"line_number":40,"context_line":"                configure_flavors"},{"line_number":41,"context_line":"            fi"},{"line_number":42,"context_line":"            if is_service_enabled q-qos neutron-qos; then"},{"line_number":43,"context_line":"                configure_qos"},{"line_number":44,"context_line":"            fi"},{"line_number":45,"context_line":"            if is_service_enabled q-trunk neutron-trunk; then"},{"line_number":46,"context_line":"                configure_trunk_extension"},{"line_number":47,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5ff73747_efec09bc","line":44,"range":{"start_line":42,"start_character":12,"end_line":44,"end_character":14},"in_reply_to":"9a30ddce_c14a8a54","updated":"2017-05-01 08:35:54.000000000","message":"for lib/neutron, configure_qos modifies neutron.conf, which is not available in \"install\" phase.","commit_id":"a9a2f0f5ad307a929689eb71ce7e916c73c991fd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9bf742a073ee9c1757478150ab845e1d233999c0","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            if is_service_enabled q-qos neutron-qos; then"},{"line_number":43,"context_line":"                configure_qos"},{"line_number":44,"context_line":"            fi"},{"line_number":45,"context_line":"            if is_service_enabled q-trunk neutron-trunk; then"},{"line_number":46,"context_line":"                configure_trunk_extension"},{"line_number":47,"context_line":"            fi"},{"line_number":48,"context_line":"            if is_service_enabled q-dns neutron-dns; then"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a30ddce_019e62b8","line":45,"updated":"2017-03-13 05:27:10.000000000","message":"trunk - same thing.","commit_id":"a9a2f0f5ad307a929689eb71ce7e916c73c991fd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"701509cf8c01f752225894905ff6507b4bfe7cca","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                configure_l2_agent"},{"line_number":62,"context_line":"                configure_l2_agent_sriovnicswitch"},{"line_number":63,"context_line":"            fi"},{"line_number":64,"context_line":"            configure_ml2_extension_drivers"},{"line_number":65,"context_line":"            ;;"},{"line_number":66,"context_line":"        extra)"},{"line_number":67,"context_line":"            if is_service_enabled q-sriov-agt neutron-sriov-agent; then"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a30ddce_7c67d8b6","line":64,"updated":"2017-03-10 20:41:05.000000000","message":"I think it\u0027s configure_l2_agent that should call to configure_$NEUTRON_CORE_PLUGIN that should then call to configure_ml2_extension_drivers in case of ml2. Then we don\u0027t expose plugin specific logic into the common code here.","commit_id":"a9a2f0f5ad307a929689eb71ce7e916c73c991fd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c3b92092044284c2742fc12476a6b033d23659fa","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                configure_l2_agent"},{"line_number":62,"context_line":"                configure_l2_agent_sriovnicswitch"},{"line_number":63,"context_line":"            fi"},{"line_number":64,"context_line":"            configure_ml2_extension_drivers"},{"line_number":65,"context_line":"            ;;"},{"line_number":66,"context_line":"        extra)"},{"line_number":67,"context_line":"            if is_service_enabled q-sriov-agt neutron-sriov-agent; then"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a30ddce_de2ee58a","line":64,"in_reply_to":"9a30ddce_7c67d8b6","updated":"2017-03-13 03:49:52.000000000","message":"Actually, I believe it\u0027s for lib/neutron[-legacy] to write it out in proper time, not the plugin. See: https://review.openstack.org/#/c/444602/","commit_id":"a9a2f0f5ad307a929689eb71ce7e916c73c991fd"}]}
