)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"8fcd70d5f8bacc773bf8fd517a597f4d1824ac69","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2013-10-10 16:28:42 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implements: juniper-plugin-with-extensions"},{"line_number":8,"context_line":"Code changes to take care of patch4 review comments and pep8 failures"},{"line_number":9,"context_line":"Juniper Contrail plugin implementation for core resources."},{"line_number":10,"context_line":"Adds Juniper Contrail plugin implementation with unit tests."},{"line_number":11,"context_line":"contrailplugin.py is the main interface for neutron common infrastructure."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAATH%2F%2FsRs%3D","line":8,"updated":"2013-10-11 05:19:50.000000000","message":"add a empty line between 7 and 8\nI would also change first line to something like:  Juniper plug-in implementation","commit_id":"443152457e0f99d76e5c3cce2b804fcd3b5871e5"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"d5f4fba8027248225afe32880e53c0088cde26e9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2013-10-10 16:28:42 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implements: juniper-plugin-with-extensions"},{"line_number":8,"context_line":"Code changes to take care of patch4 review comments and pep8 failures"},{"line_number":9,"context_line":"Juniper Contrail plugin implementation for core resources."},{"line_number":10,"context_line":"Adds Juniper Contrail plugin implementation with unit tests."},{"line_number":11,"context_line":"contrailplugin.py is the main interface for neutron common infrastructure."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAATH%2F%2FsQQ%3D","line":8,"in_reply_to":"AAAATH%2F%2FsRs%3D","updated":"2013-10-11 05:28:36.000000000","message":"Done","commit_id":"443152457e0f99d76e5c3cce2b804fcd3b5871e5"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"f473f316e156b5f9a91d48264fb357f1809b68e3","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I547426f1d4e0d1a305e179a785a5d517d058c381"},{"line_number":18,"context_line":"Implements: blueprint juniper-plugin-with-extensions"},{"line_number":19,"context_line":"Closes-Bug: #1247228"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"AAAATn%2F%2FhCY%3D","line":19,"updated":"2013-11-03 05:10:39.000000000","message":"Remove and mark as invalid this Bug-Id\nThis is driven by a Blueprint.","commit_id":"39751d2c3eef4855695832e80d4565a701548ae1"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"86412f1a469d7f4aa0b0ae7c0c57e1f8c238cabb","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I547426f1d4e0d1a305e179a785a5d517d058c381"},{"line_number":18,"context_line":"Implements: blueprint juniper-plugin-with-extensions"},{"line_number":19,"context_line":"Closes-Bug: #1247228"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"AAAATn%2F%2FfYo%3D","line":19,"in_reply_to":"AAAATn%2F%2FhCY%3D","updated":"2013-11-04 18:51:14.000000000","message":"Done","commit_id":"39751d2c3eef4855695832e80d4565a701548ae1"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"d4764e6da5d87962786841bfa96d482cf966ea36","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- The contrailplugin.py is the main interface for neutron common"},{"line_number":13,"context_line":"  infrastructure"},{"line_number":14,"context_line":"- The ctdb/config_db.py is the interface to reach Juniper/Contrail"},{"line_number":15,"context_line":"  Virtual Network Infrastructure using the vnc_api library"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I547426f1d4e0d1a305e179a785a5d517d058c381"},{"line_number":18,"context_line":"Implements: blueprint juniper-plugin-with-extensions"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"AAAAUH%2F9qeI%3D","line":15,"updated":"2014-02-05 08:38:58.000000000","message":"please, add in the commit message the link to the nova vif driver commit","commit_id":"d0a6fc6b3277166d726e8fe332e1b7dbc3586522"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"86156603e1097114af7a258f378c53770cbb0b2e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- The contrailplugin.py is the main interface for neutron common"},{"line_number":13,"context_line":"  infrastructure"},{"line_number":14,"context_line":"- The ctdb/config_db.py is the interface to reach Juniper/Contrail"},{"line_number":15,"context_line":"  Virtual Network Infrastructure using the vnc_api library"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I547426f1d4e0d1a305e179a785a5d517d058c381"},{"line_number":18,"context_line":"Implements: blueprint juniper-plugin-with-extensions"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"AAAAUH%2F9m98%3D","line":15,"in_reply_to":"AAAAUH%2F9qeI%3D","updated":"2014-02-05 18:49:20.000000000","message":"There is no nova vif driver commit now. The vif driver is part of nova config change.","commit_id":"d0a6fc6b3277166d726e8fe332e1b7dbc3586522"}],"etc/neutron/plugins/juniper/contrail/ContrailPlugin.ini":[{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"8fcd70d5f8bacc773bf8fd517a597f4d1824ac69","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Juniper plugin specific configuration"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# JunosVContrail specifc configuration for plugin"},{"line_number":4,"context_line":"[JunosVContrail]"}],"source_content_type":"text/x-properties","patch_set":5,"id":"AAAATH%2F%2FsRk%3D","line":4,"updated":"2013-10-11 05:19:50.000000000","message":"what is the point of having this file if no config parameters are included?","commit_id":"443152457e0f99d76e5c3cce2b804fcd3b5871e5"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"d5f4fba8027248225afe32880e53c0088cde26e9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Juniper plugin specific configuration"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# JunosVContrail specifc configuration for plugin"},{"line_number":4,"context_line":"[JunosVContrail]"}],"source_content_type":"text/x-properties","patch_set":5,"id":"AAAATH%2F%2FsQI%3D","line":4,"in_reply_to":"AAAATH%2F%2FsRk%3D","updated":"2013-10-11 05:28:36.000000000","message":"as we add more support on this plug-in, we will add config param","commit_id":"443152457e0f99d76e5c3cce2b804fcd3b5871e5"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"f473f316e156b5f9a91d48264fb357f1809b68e3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Juniper plugin specific configuration"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# JunosVContrail specifc configuration for plugin"},{"line_number":4,"context_line":"[JunosVContrail]"}],"source_content_type":"text/x-properties","patch_set":9,"id":"AAAATn%2F%2FhCU%3D","line":4,"updated":"2013-11-03 05:10:39.000000000","message":"what\u0027s the point of having this config file if nothing is here?","commit_id":"39751d2c3eef4855695832e80d4565a701548ae1"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"86412f1a469d7f4aa0b0ae7c0c57e1f8c238cabb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Juniper plugin specific configuration"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# JunosVContrail specifc configuration for plugin"},{"line_number":4,"context_line":"[JunosVContrail]"}],"source_content_type":"text/x-properties","patch_set":9,"id":"AAAATn%2F%2FfYQ%3D","line":4,"in_reply_to":"AAAATn%2F%2FhCU%3D","updated":"2013-11-04 18:51:14.000000000","message":"We populate this file during provisioning. Yes it does need some default values. I will change it to have the default values.","commit_id":"39751d2c3eef4855695832e80d4565a701548ae1"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"d4764e6da5d87962786841bfa96d482cf966ea36","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[APISERVER]"},{"line_number":4,"context_line":"# parameters to connect to VNC API server"},{"line_number":5,"context_line":"api_server_ip \u003d 127.0.0.1"},{"line_number":6,"context_line":"api_server_port \u003d 8082"},{"line_number":7,"context_line":"multi_tenancy \u003d False"}],"source_content_type":"text/x-properties","patch_set":22,"id":"AAAAUH%2F9qeU%3D","line":5,"updated":"2014-02-05 08:38:58.000000000","message":"I will comment out these values, common practice in neutron config files","commit_id":"d0a6fc6b3277166d726e8fe332e1b7dbc3586522"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"86156603e1097114af7a258f378c53770cbb0b2e","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[APISERVER]"},{"line_number":4,"context_line":"# parameters to connect to VNC API server"},{"line_number":5,"context_line":"api_server_ip \u003d 127.0.0.1"},{"line_number":6,"context_line":"api_server_port \u003d 8082"},{"line_number":7,"context_line":"multi_tenancy \u003d False"}],"source_content_type":"text/x-properties","patch_set":22,"id":"AAAAUH%2F9m7M%3D","line":5,"in_reply_to":"AAAAUH%2F9qeU%3D","updated":"2014-02-05 18:49:20.000000000","message":"Done","commit_id":"d0a6fc6b3277166d726e8fe332e1b7dbc3586522"}],"neutron/extensions/portbindings.py":[{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"f473f316e156b5f9a91d48264fb357f1809b68e3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"VIF_TYPE_HYPERV \u003d \u0027hyperv\u0027"},{"line_number":47,"context_line":"VIF_TYPE_MIDONET \u003d \u0027midonet\u0027"},{"line_number":48,"context_line":"VIF_TYPE_VROUTER \u003d \u0027vrouter\u0027"},{"line_number":49,"context_line":"VIF_TYPE_OTHER \u003d \u0027other\u0027"},{"line_number":50,"context_line":"VIF_TYPES \u003d [VIF_TYPE_UNBOUND, VIF_TYPE_BINDING_FAILED, VIF_TYPE_OVS,"},{"line_number":51,"context_line":"             VIF_TYPE_IVS, VIF_TYPE_BRIDGE, VIF_TYPE_802_QBG,"},{"line_number":52,"context_line":"             VIF_TYPE_802_QBH, VIF_TYPE_HYPERV, VIF_TYPE_MIDONET,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2FhCQ%3D","line":49,"updated":"2013-11-03 05:10:39.000000000","message":"I will recommend to include the BP and Commit ID for the respective changes in Nova. I am assuming that you are also posting a new VIF driver.","commit_id":"39751d2c3eef4855695832e80d4565a701548ae1"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"86412f1a469d7f4aa0b0ae7c0c57e1f8c238cabb","unresolved":false,"context_lines":[{"line_number":46,"context_line":"VIF_TYPE_HYPERV \u003d \u0027hyperv\u0027"},{"line_number":47,"context_line":"VIF_TYPE_MIDONET \u003d \u0027midonet\u0027"},{"line_number":48,"context_line":"VIF_TYPE_VROUTER \u003d \u0027vrouter\u0027"},{"line_number":49,"context_line":"VIF_TYPE_OTHER \u003d \u0027other\u0027"},{"line_number":50,"context_line":"VIF_TYPES \u003d [VIF_TYPE_UNBOUND, VIF_TYPE_BINDING_FAILED, VIF_TYPE_OVS,"},{"line_number":51,"context_line":"             VIF_TYPE_IVS, VIF_TYPE_BRIDGE, VIF_TYPE_802_QBG,"},{"line_number":52,"context_line":"             VIF_TYPE_802_QBH, VIF_TYPE_HYPERV, VIF_TYPE_MIDONET,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2FfW0%3D","line":49,"in_reply_to":"AAAATn%2F%2FhCQ%3D","updated":"2013-11-04 18:51:14.000000000","message":"Done","commit_id":"39751d2c3eef4855695832e80d4565a701548ae1"}],"neutron/plugins/juniper/__init__.py":[{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"d4764e6da5d87962786841bfa96d482cf966ea36","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 Juniper Networks.  All rights reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUH%2F9qeE%3D","line":2,"updated":"2014-02-05 08:38:58.000000000","message":"empty files should not have Copyright information at all","commit_id":"d0a6fc6b3277166d726e8fe332e1b7dbc3586522"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"86156603e1097114af7a258f378c53770cbb0b2e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 Juniper Networks.  All rights reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUH%2F9mpA%3D","line":2,"in_reply_to":"AAAAUH%2F9qeE%3D","updated":"2014-02-05 18:49:20.000000000","message":"Done","commit_id":"d0a6fc6b3277166d726e8fe332e1b7dbc3586522"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"643fff30b5e640c943a9279e1882e10608c59484","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# @author: Hampapur Ajay Juniper Networks."}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FYzM%3D","line":17,"updated":"2014-02-13 15:47:00.000000000","message":"__init__.py now should be empty.","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"574f6e2a84875198bb6eb32fd95bf5c626727b56","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# @author: Hampapur Ajay Juniper Networks."}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FWm4%3D","line":17,"in_reply_to":"AAAAUX%2F%2FYzM%3D","updated":"2014-02-14 00:42:48.000000000","message":"Done","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"}],"neutron/plugins/juniper/contrail/__init__.py":[{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"d4764e6da5d87962786841bfa96d482cf966ea36","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 Juniper Networks.  All rights reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":7,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUH%2F9qd8%3D","line":4,"updated":"2014-02-05 08:38:58.000000000","message":"ditto\nBTW. The year is wrong!","commit_id":"d0a6fc6b3277166d726e8fe332e1b7dbc3586522"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"86156603e1097114af7a258f378c53770cbb0b2e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 Juniper Networks.  All rights reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":7,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUH%2F9mo0%3D","line":4,"in_reply_to":"AAAAUH%2F9qd8%3D","updated":"2014-02-05 18:49:20.000000000","message":"Done","commit_id":"d0a6fc6b3277166d726e8fe332e1b7dbc3586522"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"643fff30b5e640c943a9279e1882e10608c59484","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# @author: Hampapur Ajay Juniper Networks."}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FYyk%3D","line":17,"updated":"2014-02-13 15:47:00.000000000","message":"__init__.py should be empty.","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"574f6e2a84875198bb6eb32fd95bf5c626727b56","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# @author: Hampapur Ajay Juniper Networks."}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FWmc%3D","line":17,"in_reply_to":"AAAAUX%2F%2FYyk%3D","updated":"2014-02-14 00:42:48.000000000","message":"Done","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"}],"neutron/plugins/juniper/contrail/contrailplugin.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# @author: Hampapur Ajay, Rudra Rugge, Atul Moghe Juniper Networks."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import ConfigParser"},{"line_number":21,"context_line":"import logging"},{"line_number":22,"context_line":"from pprint import pformat"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqRg%3D","line":20,"updated":"2013-09-01 02:50:32.000000000","message":"Do you have to use config parser?  Should be using oslo.config.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# @author: Hampapur Ajay, Rudra Rugge, Atul Moghe Juniper Networks."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import ConfigParser"},{"line_number":21,"context_line":"import logging"},{"line_number":22,"context_line":"from pprint import pformat"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYBs%3D","line":20,"in_reply_to":"AAAASn%2F%2FqRg%3D","updated":"2013-10-07 16:59:22.000000000","message":"yes, we can change..","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import ConfigParser"},{"line_number":21,"context_line":"import logging"},{"line_number":22,"context_line":"from pprint import pformat"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"#from neutron.manager import NeutronManager"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqRc%3D","line":21,"updated":"2013-09-01 02:50:32.000000000","message":"You should be using\n\nfrom neutron.openstack.common import logging","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import ConfigParser"},{"line_number":21,"context_line":"import logging"},{"line_number":22,"context_line":"from pprint import pformat"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"#from neutron.manager import NeutronManager"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYuY%3D","line":21,"in_reply_to":"AAAASn%2F%2FqRc%3D","updated":"2013-10-07 16:59:22.000000000","message":"will change as suggested","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import logging"},{"line_number":22,"context_line":"from pprint import pformat"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"#from neutron.manager import NeutronManager"},{"line_number":25,"context_line":"from neutron.common import exceptions as exc"},{"line_number":26,"context_line":"from neutron.db import db_base_plugin_v2"},{"line_number":27,"context_line":"from neutron.extensions import l3"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FLCw%3D","line":24,"updated":"2013-10-02 23:32:37.000000000","message":"remove unused code","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import logging"},{"line_number":22,"context_line":"from pprint import pformat"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"#from neutron.manager import NeutronManager"},{"line_number":25,"context_line":"from neutron.common import exceptions as exc"},{"line_number":26,"context_line":"from neutron.db import db_base_plugin_v2"},{"line_number":27,"context_line":"from neutron.extensions import l3"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FElc%3D","line":24,"in_reply_to":"AAAAS3%2F%2FLCw%3D","updated":"2013-10-07 16:59:22.000000000","message":"we will remove and send new patch for review","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from neutron.db import db_base_plugin_v2"},{"line_number":27,"context_line":"from neutron.extensions import l3"},{"line_number":28,"context_line":"from neutron.extensions import securitygroup"},{"line_number":29,"context_line":"#from neutron.extensions import vpcroutetable"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"import cgitb"},{"line_number":32,"context_line":"from httplib2 import Http"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FLCs%3D","line":29,"updated":"2013-10-02 23:32:37.000000000","message":"remove unused code","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from neutron.db import db_base_plugin_v2"},{"line_number":27,"context_line":"from neutron.extensions import l3"},{"line_number":28,"context_line":"from neutron.extensions import securitygroup"},{"line_number":29,"context_line":"#from neutron.extensions import vpcroutetable"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"import cgitb"},{"line_number":32,"context_line":"from httplib2 import Http"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F8f0%3D","line":29,"in_reply_to":"AAAAS3%2F%2FLCs%3D","updated":"2013-10-07 16:59:22.000000000","message":"Done","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.extensions import securitygroup"},{"line_number":29,"context_line":"#from neutron.extensions import vpcroutetable"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"import cgitb"},{"line_number":32,"context_line":"from httplib2 import Http"},{"line_number":33,"context_line":"from oslo.config import cfg"},{"line_number":34,"context_line":"import re"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqRY%3D","line":31,"updated":"2013-09-01 02:50:32.000000000","message":"please do not use this library\n\nLOG.exception() will properly output the tb to the proper log.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.extensions import securitygroup"},{"line_number":29,"context_line":"#from neutron.extensions import vpcroutetable"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"import cgitb"},{"line_number":32,"context_line":"from httplib2 import Http"},{"line_number":33,"context_line":"from oslo.config import cfg"},{"line_number":34,"context_line":"import re"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYBc%3D","line":31,"in_reply_to":"AAAASn%2F%2FqRY%3D","updated":"2013-10-07 16:59:22.000000000","message":"will follow this suggestion","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":34,"context_line":"import re"},{"line_number":35,"context_line":"import string"},{"line_number":36,"context_line":"import sys"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"import ctdb.config_db"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqRU%3D","line":37,"updated":"2013-09-01 02:50:32.000000000","message":"All of the imports need to be ordered properly per the HACKING guidelines.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":34,"context_line":"import re"},{"line_number":35,"context_line":"import string"},{"line_number":36,"context_line":"import sys"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"import ctdb.config_db"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYuE%3D","line":37,"in_reply_to":"AAAASn%2F%2FqRU%3D","updated":"2013-10-07 16:59:22.000000000","message":"will change as suggested, this was passed by pep8.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":45,"context_line":"]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def _read_cfg(cfg_parser, section, option, default):"},{"line_number":49,"context_line":"        try:"},{"line_number":50,"context_line":"            val \u003d cfg_parser.get(section, option)"},{"line_number":51,"context_line":"        except (AttributeError,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FLIo%3D","line":48,"updated":"2013-10-02 23:32:37.000000000","message":"we should use oslo.config","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def _read_cfg(cfg_parser, section, option, default):"},{"line_number":49,"context_line":"        try:"},{"line_number":50,"context_line":"            val \u003d cfg_parser.get(section, option)"},{"line_number":51,"context_line":"        except (AttributeError,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F8xY%3D","line":48,"in_reply_to":"AAAAS3%2F%2FLIo%3D","updated":"2013-10-07 16:59:22.000000000","message":"we will change as suggested","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        return val"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def _read_cfg_boolean(cfg_parser, section, option, default):"},{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            val \u003d cfg_parser.getboolean(section, option)"},{"line_number":62,"context_line":"        except (AttributeError, ValueError,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FLIg%3D","line":59,"updated":"2013-10-02 23:32:37.000000000","message":"we should use oslo.config","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        return val"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def _read_cfg_boolean(cfg_parser, section, option, default):"},{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            val \u003d cfg_parser.getboolean(section, option)"},{"line_number":62,"context_line":"        except (AttributeError, ValueError,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F8xU%3D","line":59,"in_reply_to":"AAAAS3%2F%2FLIg%3D","updated":"2013-10-07 16:59:22.000000000","message":"we will change as suggested","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":70,"context_line":"class ContrailPlugin(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":71,"context_line":"                     l3.RouterPluginBase,"},{"line_number":72,"context_line":"                     securitygroup.SecurityGroupPluginBase):"},{"line_number":73,"context_line":"#vpcroutetable.RouteTablePluginBase):"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    supported_extension_aliases \u003d [\"ipam\", \"policy\", \"security-group\","},{"line_number":76,"context_line":"                                   \"router\", \"route-table\", \"port-security\"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FLJo%3D","line":73,"updated":"2013-10-02 23:32:37.000000000","message":"remove unused comment","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":70,"context_line":"class ContrailPlugin(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":71,"context_line":"                     l3.RouterPluginBase,"},{"line_number":72,"context_line":"                     securitygroup.SecurityGroupPluginBase):"},{"line_number":73,"context_line":"#vpcroutetable.RouteTablePluginBase):"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    supported_extension_aliases \u003d [\"ipam\", \"policy\", \"security-group\","},{"line_number":76,"context_line":"                                   \"router\", \"route-table\", \"port-security\"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FEk0%3D","line":73,"in_reply_to":"AAAAS3%2F%2FLJo%3D","updated":"2013-10-07 16:59:22.000000000","message":"remove and will send new patch for review","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":73,"context_line":"#vpcroutetable.RouteTablePluginBase):"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    supported_extension_aliases \u003d [\"ipam\", \"policy\", \"security-group\","},{"line_number":76,"context_line":"                                   \"router\", \"route-table\", \"port-security\"]"},{"line_number":77,"context_line":"    __native_bulk_support \u003d False"},{"line_number":78,"context_line":"    _cfgdb \u003d None"},{"line_number":79,"context_line":"    _args \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FLIs%3D","line":76,"updated":"2013-10-02 23:32:37.000000000","message":"It looks this plugin supports router.\nhowever floating ip part is only supported. \nIt should be implemented or at least we need comment here.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":73,"context_line":"#vpcroutetable.RouteTablePluginBase):"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    supported_extension_aliases \u003d [\"ipam\", \"policy\", \"security-group\","},{"line_number":76,"context_line":"                                   \"router\", \"route-table\", \"port-security\"]"},{"line_number":77,"context_line":"    __native_bulk_support \u003d False"},{"line_number":78,"context_line":"    _cfgdb \u003d None"},{"line_number":79,"context_line":"    _args \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F%2Bms%3D","line":76,"in_reply_to":"AAAAS3%2F%2FLIs%3D","updated":"2013-10-07 16:59:22.000000000","message":"we will put appropriate comment here.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    _tenant_name_dict \u003d {}"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @classmethod"},{"line_number":84,"context_line":"    def _parse_class_args(cls, cfg_parser):"},{"line_number":85,"context_line":"        cfg_parser.read(\"/etc/neutron/plugins/juniper/\""},{"line_number":86,"context_line":"                        \"contrail/ContrailPlugin.ini\""},{"line_number":87,"context_line":"                        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FLIc%3D","line":84,"updated":"2013-10-02 23:32:37.000000000","message":"may be this function is not needed.\nWe can get config from oslo.config easy.\nI don\u0027t see the value of setting this as class args.\nAlso this style is not generic in python..","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    _tenant_name_dict \u003d {}"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @classmethod"},{"line_number":84,"context_line":"    def _parse_class_args(cls, cfg_parser):"},{"line_number":85,"context_line":"        cfg_parser.read(\"/etc/neutron/plugins/juniper/\""},{"line_number":86,"context_line":"                        \"contrail/ContrailPlugin.ini\""},{"line_number":87,"context_line":"                        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F%2Bmo%3D","line":84,"in_reply_to":"AAAAS3%2F%2FLIc%3D","updated":"2013-10-07 16:59:22.000000000","message":"we will use olso.config","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @classmethod"},{"line_number":84,"context_line":"    def _parse_class_args(cls, cfg_parser):"},{"line_number":85,"context_line":"        cfg_parser.read(\"/etc/neutron/plugins/juniper/\""},{"line_number":86,"context_line":"                        \"contrail/ContrailPlugin.ini\""},{"line_number":87,"context_line":"                        )"},{"line_number":88,"context_line":"        cls._multi_tenancy \u003d _read_cfg_boolean(cfg_parser, \u0027APISERVER\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqRI%3D","line":85,"updated":"2013-09-01 02:50:32.000000000","message":"Hard coding this value is a bad idea.  You should pass this via the --config-file flag on the server command line like the other plugins.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @classmethod"},{"line_number":84,"context_line":"    def _parse_class_args(cls, cfg_parser):"},{"line_number":85,"context_line":"        cfg_parser.read(\"/etc/neutron/plugins/juniper/\""},{"line_number":86,"context_line":"                        \"contrail/ContrailPlugin.ini\""},{"line_number":87,"context_line":"                        )"},{"line_number":88,"context_line":"        cls._multi_tenancy \u003d _read_cfg_boolean(cfg_parser, \u0027APISERVER\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYBU%3D","line":85,"in_reply_to":"AAAASn%2F%2FqRI%3D","updated":"2013-10-07 16:59:22.000000000","message":"will do it..","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                        )"},{"line_number":88,"context_line":"        cls._multi_tenancy \u003d _read_cfg_boolean(cfg_parser, \u0027APISERVER\u0027,"},{"line_number":89,"context_line":"                                               \u0027multi_tenancy\u0027, False)"},{"line_number":90,"context_line":"        cls._admin_token \u003d _read_cfg(cfg_parser, \u0027KEYSTONE\u0027, \u0027admin_token\u0027, \u0027\u0027)"},{"line_number":91,"context_line":"        cls._auth_url \u003d _read_cfg(cfg_parser, \u0027KEYSTONE\u0027, \u0027auth_url\u0027, \u0027\u0027)"},{"line_number":92,"context_line":"        cls._admin_user \u003d _read_cfg(cfg_parser, \u0027KEYSTONE\u0027, \u0027admin_user\u0027,"},{"line_number":93,"context_line":"                                    \u0027user1\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqRM%3D","line":90,"updated":"2013-09-01 02:50:32.000000000","message":"Keystone information should already be available to the process.  You should not have declare it a second time.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                        )"},{"line_number":88,"context_line":"        cls._multi_tenancy \u003d _read_cfg_boolean(cfg_parser, \u0027APISERVER\u0027,"},{"line_number":89,"context_line":"                                               \u0027multi_tenancy\u0027, False)"},{"line_number":90,"context_line":"        cls._admin_token \u003d _read_cfg(cfg_parser, \u0027KEYSTONE\u0027, \u0027admin_token\u0027, \u0027\u0027)"},{"line_number":91,"context_line":"        cls._auth_url \u003d _read_cfg(cfg_parser, \u0027KEYSTONE\u0027, \u0027auth_url\u0027, \u0027\u0027)"},{"line_number":92,"context_line":"        cls._admin_user \u003d _read_cfg(cfg_parser, \u0027KEYSTONE\u0027, \u0027admin_user\u0027,"},{"line_number":93,"context_line":"                                    \u0027user1\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYBQ%3D","line":90,"in_reply_to":"AAAASn%2F%2FqRM%3D","updated":"2013-10-07 16:59:22.000000000","message":"will make changes as suggested","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                                           \u0027admin_tenant_name\u0027,"},{"line_number":98,"context_line":"                                           \u0027default-domain\u0027)"},{"line_number":99,"context_line":"        cls._tenants_api \u003d \u0027%s/tenants\u0027 % (cls._auth_url)"},{"line_number":100,"context_line":"        pass"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @classmethod"},{"line_number":103,"context_line":"    def _connect_to_db(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqRQ%3D","line":100,"updated":"2013-09-01 02:50:32.000000000","message":"pass is not necessary here","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                                           \u0027admin_tenant_name\u0027,"},{"line_number":98,"context_line":"                                           \u0027default-domain\u0027)"},{"line_number":99,"context_line":"        cls._tenants_api \u003d \u0027%s/tenants\u0027 % (cls._auth_url)"},{"line_number":100,"context_line":"        pass"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @classmethod"},{"line_number":103,"context_line":"    def _connect_to_db(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYt8%3D","line":100,"in_reply_to":"AAAASn%2F%2FqRQ%3D","updated":"2013-10-07 16:59:22.000000000","message":"will remove","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @classmethod"},{"line_number":103,"context_line":"    def _connect_to_db(cls):"},{"line_number":104,"context_line":"        \"\"\""},{"line_number":105,"context_line":"        Many instantiations of plugin (base + extensions) but need to have"},{"line_number":106,"context_line":"    only one config db conn (else error from ifmap-server)"},{"line_number":107,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FLIU%3D","line":104,"updated":"2013-10-02 23:32:37.000000000","message":"see Hacking guidelines for comment\n\nhttps://github.com/openstack/neutron/blob/master/HACKING.rst#docstrings\n\nI won\u0027t comment the other doc strings, but same comment will be applied for it.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @classmethod"},{"line_number":103,"context_line":"    def _connect_to_db(cls):"},{"line_number":104,"context_line":"        \"\"\""},{"line_number":105,"context_line":"        Many instantiations of plugin (base + extensions) but need to have"},{"line_number":106,"context_line":"    only one config db conn (else error from ifmap-server)"},{"line_number":107,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F8kI%3D","line":104,"in_reply_to":"AAAAS3%2F%2FLIU%3D","updated":"2013-10-07 16:59:22.000000000","message":"Done","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        if cls._cfgdb is None:"},{"line_number":110,"context_line":"            sip \u003d cfg.CONF.APISERVER.api_server_ip"},{"line_number":111,"context_line":"            sport \u003d cfg.CONF.APISERVER.api_server_port"},{"line_number":112,"context_line":"            # Initialize connection to DB and add default entries"},{"line_number":113,"context_line":"            cls._cfgdb \u003d ctdb.config_db.DBInterface(cls._admin_user,"},{"line_number":114,"context_line":"                                                    cls._admin_password,"},{"line_number":115,"context_line":"                                                    cls._admin_tenant_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FLHY%3D","line":112,"updated":"2013-10-02 23:32:37.000000000","message":"I\u0027m not sure why this method is class method.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"1e7eadbb6c690bc7540596d7c92d37b356cd6eac","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        if cls._cfgdb is None:"},{"line_number":110,"context_line":"            sip \u003d cfg.CONF.APISERVER.api_server_ip"},{"line_number":111,"context_line":"            sport \u003d cfg.CONF.APISERVER.api_server_port"},{"line_number":112,"context_line":"            # Initialize connection to DB and add default entries"},{"line_number":113,"context_line":"            cls._cfgdb \u003d ctdb.config_db.DBInterface(cls._admin_user,"},{"line_number":114,"context_line":"                                                    cls._admin_password,"},{"line_number":115,"context_line":"                                                    cls._admin_tenant_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F4C0%3D","line":112,"in_reply_to":"AAAAS3%2F%2FLHY%3D","updated":"2013-10-08 21:34:24.000000000","message":"There could be multiple plugin to controller connection and with different credential, this info is kept in the clas","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        if cls._cfgdb is None:"},{"line_number":110,"context_line":"            sip \u003d cfg.CONF.APISERVER.api_server_ip"},{"line_number":111,"context_line":"            sport \u003d cfg.CONF.APISERVER.api_server_port"},{"line_number":112,"context_line":"            # Initialize connection to DB and add default entries"},{"line_number":113,"context_line":"            cls._cfgdb \u003d ctdb.config_db.DBInterface(cls._admin_user,"},{"line_number":114,"context_line":"                                                    cls._admin_password,"},{"line_number":115,"context_line":"                                                    cls._admin_tenant_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F8kA%3D","line":112,"in_reply_to":"AAAAS3%2F%2FLHY%3D","updated":"2013-10-07 16:59:22.000000000","message":"will take a look and change if required","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                                                    sip, sport)"},{"line_number":117,"context_line":"            cls._cfgdb.manager \u003d cls"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @classmethod"},{"line_number":120,"context_line":"    def _get_user_cfgdb(cls, context):"},{"line_number":121,"context_line":"        if not cls._multi_tenancy:"},{"line_number":122,"context_line":"            return cls._cfgdb"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FLHE%3D","line":119,"updated":"2013-10-02 23:32:37.000000000","message":"why this should be classmethod?","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                                                    sip, sport)"},{"line_number":117,"context_line":"            cls._cfgdb.manager \u003d cls"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @classmethod"},{"line_number":120,"context_line":"    def _get_user_cfgdb(cls, context):"},{"line_number":121,"context_line":"        if not cls._multi_tenancy:"},{"line_number":122,"context_line":"            return cls._cfgdb"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F8j8%3D","line":119,"in_reply_to":"AAAAS3%2F%2FLHE%3D","updated":"2013-10-07 16:59:22.000000000","message":"will change if needed","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"1e7eadbb6c690bc7540596d7c92d37b356cd6eac","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                                                    sip, sport)"},{"line_number":117,"context_line":"            cls._cfgdb.manager \u003d cls"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @classmethod"},{"line_number":120,"context_line":"    def _get_user_cfgdb(cls, context):"},{"line_number":121,"context_line":"        if not cls._multi_tenancy:"},{"line_number":122,"context_line":"            return cls._cfgdb"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F7PU%3D","line":119,"in_reply_to":"AAAATH%2F%2F8j8%3D","updated":"2013-10-08 21:34:24.000000000","message":"There could be multiple plugin to controller connection and with different credential, this info is kept in the class.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        return cls._cfgdb_map[user_id]"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    @classmethod"},{"line_number":136,"context_line":"    def _tenant_list_from_keystone(cls):"},{"line_number":137,"context_line":"        # get all tenants"},{"line_number":138,"context_line":"        hdrs \u003d {\u0027X-Auth-Token\u0027: cls._admin_token,"},{"line_number":139,"context_line":"                \u0027Content-Type\u0027: \u0027application/json\u0027}"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqRA%3D","line":136,"updated":"2013-09-01 02:50:32.000000000","message":"You should not make a direct call to keystone.  The keystone client is already a dependency of this project.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        return cls._cfgdb_map[user_id]"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    @classmethod"},{"line_number":136,"context_line":"    def _tenant_list_from_keystone(cls):"},{"line_number":137,"context_line":"        # get all tenants"},{"line_number":138,"context_line":"        hdrs \u003d {\u0027X-Auth-Token\u0027: cls._admin_token,"},{"line_number":139,"context_line":"                \u0027Content-Type\u0027: \u0027application/json\u0027}"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYBM%3D","line":136,"in_reply_to":"AAAASn%2F%2FqRA%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        # transform needed for python compatibility"},{"line_number":149,"context_line":"        content \u003d re.sub(\u0027true\u0027, \u0027True\u0027, content)"},{"line_number":150,"context_line":"        content \u003d re.sub(\u0027null\u0027, \u0027None\u0027, content)"},{"line_number":151,"context_line":"        content \u003d eval(content)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        # bail if response is unexpected"},{"line_number":154,"context_line":"        if \u0027tenants\u0027 not in content:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqRE%3D","line":151,"updated":"2013-09-01 02:50:32.000000000","message":"You should never call eval() in this context it is not safe.  You should use proper json handling utils.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        # transform needed for python compatibility"},{"line_number":149,"context_line":"        content \u003d re.sub(\u0027true\u0027, \u0027True\u0027, content)"},{"line_number":150,"context_line":"        content \u003d re.sub(\u0027null\u0027, \u0027None\u0027, content)"},{"line_number":151,"context_line":"        content \u003d eval(content)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        # bail if response is unexpected"},{"line_number":154,"context_line":"        if \u0027tenants\u0027 not in content:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYBE%3D","line":151,"in_reply_to":"AAAASn%2F%2FqRE%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            cls._tenant_id_dict[tenant[\u0027id\u0027]] \u003d tenant[\u0027name\u0027]"},{"line_number":162,"context_line":"            cls._tenant_name_dict[tenant[\u0027name\u0027]] \u003d tenant[\u0027id\u0027]"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def update_security_group(self, context, id, security_group):"},{"line_number":165,"context_line":"        pass"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FLG4%3D","line":164,"updated":"2013-10-02 23:32:37.000000000","message":"We need to implement this too.\nor at least we should return not implemented error.\nMethod should be ordered with similar functions","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            cls._tenant_id_dict[tenant[\u0027id\u0027]] \u003d tenant[\u0027name\u0027]"},{"line_number":162,"context_line":"            cls._tenant_name_dict[tenant[\u0027name\u0027]] \u003d tenant[\u0027id\u0027]"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def update_security_group(self, context, id, security_group):"},{"line_number":165,"context_line":"        pass"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F8js%3D","line":164,"in_reply_to":"AAAAS3%2F%2FLG4%3D","updated":"2013-10-07 16:59:22.000000000","message":"Done","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        ContrailPlugin._tenant_list_from_keystone()"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    @classmethod"},{"line_number":179,"context_line":"    def tenant_id_to_name(cls, id):"},{"line_number":180,"context_line":"        # bail if we never built the list successfully"},{"line_number":181,"context_line":"        if len(cls._tenant_id_dict) \u003d\u003d 0:"},{"line_number":182,"context_line":"            return id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FLCM%3D","line":179,"updated":"2013-10-02 23:32:37.000000000","message":"it looks like unused..\nWhy this one is needed?","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        ContrailPlugin._tenant_list_from_keystone()"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    @classmethod"},{"line_number":179,"context_line":"    def tenant_id_to_name(cls, id):"},{"line_number":180,"context_line":"        # bail if we never built the list successfully"},{"line_number":181,"context_line":"        if len(cls._tenant_id_dict) \u003d\u003d 0:"},{"line_number":182,"context_line":"            return id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F8jw%3D","line":179,"in_reply_to":"AAAAS3%2F%2FLCM%3D","updated":"2013-10-07 16:59:22.000000000","message":"Done","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    @classmethod"},{"line_number":179,"context_line":"    def tenant_id_to_name(cls, id):"},{"line_number":180,"context_line":"        # bail if we never built the list successfully"},{"line_number":181,"context_line":"        if len(cls._tenant_id_dict) \u003d\u003d 0:"},{"line_number":182,"context_line":"            return id"},{"line_number":183,"context_line":"        # check cache"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FLCg%3D","line":180,"updated":"2013-10-02 23:32:37.000000000","message":"Where is this used?","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"1e7eadbb6c690bc7540596d7c92d37b356cd6eac","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    @classmethod"},{"line_number":179,"context_line":"    def tenant_id_to_name(cls, id):"},{"line_number":180,"context_line":"        # bail if we never built the list successfully"},{"line_number":181,"context_line":"        if len(cls._tenant_id_dict) \u003d\u003d 0:"},{"line_number":182,"context_line":"            return id"},{"line_number":183,"context_line":"        # check cache"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F4BU%3D","line":180,"in_reply_to":"AAAAS3%2F%2FLCg%3D","updated":"2013-10-08 21:34:24.000000000","message":"we have removed this","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        # otherwise refresh"},{"line_number":187,"context_line":"        cls._tenant_list_from_keystone()"},{"line_number":188,"context_line":"        # second time\u0027s a charm?"},{"line_number":189,"context_line":"        return cls._tenant_id_dict[id] if id in cls._tenant_id_dict else id"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    @classmethod"},{"line_number":192,"context_line":"    def tenant_name_to_id(cls, name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqQ8%3D","line":189,"updated":"2013-09-01 02:50:32.000000000","message":"FYI... you\u0027ve reimplemented a built-in dict method\n\ncls._tenant_id_dict.get(id, id)","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        # otherwise refresh"},{"line_number":187,"context_line":"        cls._tenant_list_from_keystone()"},{"line_number":188,"context_line":"        # second time\u0027s a charm?"},{"line_number":189,"context_line":"        return cls._tenant_id_dict[id] if id in cls._tenant_id_dict else id"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    @classmethod"},{"line_number":192,"context_line":"    def tenant_name_to_id(cls, name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYBA%3D","line":189,"in_reply_to":"AAAASn%2F%2FqQ8%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        return cls._tenant_id_dict[id] if id in cls._tenant_id_dict else id"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    @classmethod"},{"line_number":192,"context_line":"    def tenant_name_to_id(cls, name):"},{"line_number":193,"context_line":"        # bail if we never built the list successfully"},{"line_number":194,"context_line":"        if len(cls._tenant_name_dict) \u003d\u003d 0:"},{"line_number":195,"context_line":"            return name"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FLCI%3D","line":192,"updated":"2013-10-02 23:32:37.000000000","message":"it looks like unused..\nWhy this one is needed?","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        return cls._tenant_id_dict[id] if id in cls._tenant_id_dict else id"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    @classmethod"},{"line_number":192,"context_line":"    def tenant_name_to_id(cls, name):"},{"line_number":193,"context_line":"        # bail if we never built the list successfully"},{"line_number":194,"context_line":"        if len(cls._tenant_name_dict) \u003d\u003d 0:"},{"line_number":195,"context_line":"            return name"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F8jo%3D","line":192,"in_reply_to":"AAAAS3%2F%2FLCI%3D","updated":"2013-10-07 16:59:22.000000000","message":"Done","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        a symbolic name."},{"line_number":212,"context_line":"        \"\"\""},{"line_number":213,"context_line":"        try:"},{"line_number":214,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":215,"context_line":"            net_info \u003d cfgdb.network_create(network[\u0027network\u0027])"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"            # verify transformation is conforming to api"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqQg%3D","line":214,"updated":"2013-09-01 02:50:32.000000000","message":"You can make calls against the instance which will invoke the class method.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        a symbolic name."},{"line_number":212,"context_line":"        \"\"\""},{"line_number":213,"context_line":"        try:"},{"line_number":214,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":215,"context_line":"            net_info \u003d cfgdb.network_create(network[\u0027network\u0027])"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"            # verify transformation is conforming to api"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYA8%3D","line":214,"in_reply_to":"AAAASn%2F%2FqQg%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"            net_dict.update(net_info[\u0027q_extra_data\u0027])"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"            LOG.debug(\"create_network(): \" + pformat(net_dict) + \"\\n\")"},{"line_number":224,"context_line":"            return net_dict"},{"line_number":225,"context_line":"        except Exception as e:"},{"line_number":226,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FLDk%3D","line":223,"updated":"2013-10-02 23:32:37.000000000","message":"you should be \ndebug(_(\"create_network(): %r\"), net_dict)\n\n_() should be needed for i18n\n%r will dump db object.\n# pformat get long in log. \n\nThis comment will be applied for all comments","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            LOG.debug(\"create_network(): \" + pformat(net_dict) + \"\\n\")"},{"line_number":224,"context_line":"            return net_dict"},{"line_number":225,"context_line":"        except Exception as e:"},{"line_number":226,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":227,"context_line":"            raise e"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def get_network(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqQ4%3D","line":226,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception(\u0027the message\u0027)","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            LOG.debug(\"create_network(): \" + pformat(net_dict) + \"\\n\")"},{"line_number":224,"context_line":"            return net_dict"},{"line_number":225,"context_line":"        except Exception as e:"},{"line_number":226,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":227,"context_line":"            raise e"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def get_network(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYA4%3D","line":226,"in_reply_to":"AAAASn%2F%2FqQ4%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def get_network(self, context, id, fields\u003dNone):"},{"line_number":230,"context_line":"        try:"},{"line_number":231,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":232,"context_line":"            net_info \u003d cfgdb.network_read(id, fields)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"            # verify transformation is conforming to api"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqQc%3D","line":231,"updated":"2013-09-01 02:50:32.000000000","message":"call against the instance","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def get_network(self, context, id, fields\u003dNone):"},{"line_number":230,"context_line":"        try:"},{"line_number":231,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":232,"context_line":"            net_info \u003d cfgdb.network_read(id, fields)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"            # verify transformation is conforming to api"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX70%3D","line":231,"in_reply_to":"AAAASn%2F%2FqQc%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            LOG.debug(\"get_network(): \" + pformat(net_dict))"},{"line_number":244,"context_line":"            return self._fields(net_dict, fields)"},{"line_number":245,"context_line":"        except Exception as e:"},{"line_number":246,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":247,"context_line":"            raise e"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def update_network(self, context, net_id, network):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqQ0%3D","line":246,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            LOG.debug(\"get_network(): \" + pformat(net_dict))"},{"line_number":244,"context_line":"            return self._fields(net_dict, fields)"},{"line_number":245,"context_line":"        except Exception as e:"},{"line_number":246,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":247,"context_line":"            raise e"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def update_network(self, context, net_id, network):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX7w%3D","line":246,"in_reply_to":"AAAASn%2F%2FqQ0%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        Updates the attributes of a particular Virtual Network."},{"line_number":252,"context_line":"        \"\"\""},{"line_number":253,"context_line":"        try:"},{"line_number":254,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":255,"context_line":"            net_info \u003d cfgdb.network_update(net_id, network[\u0027network\u0027])"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"            # verify transformation is conforming to api"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqQk%3D","line":254,"updated":"2013-09-01 02:50:32.000000000","message":"call method directly on the instance","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        Updates the attributes of a particular Virtual Network."},{"line_number":252,"context_line":"        \"\"\""},{"line_number":253,"context_line":"        try:"},{"line_number":254,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":255,"context_line":"            net_info \u003d cfgdb.network_update(net_id, network[\u0027network\u0027])"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"            # verify transformation is conforming to api"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX7s%3D","line":254,"in_reply_to":"AAAASn%2F%2FqQk%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":263,"context_line":"            LOG.debug(\"update_network(): \" + pformat(net_dict))"},{"line_number":264,"context_line":"            return net_dict"},{"line_number":265,"context_line":"        except Exception as e:"},{"line_number":266,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":267,"context_line":"            raise e"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def delete_network(self, context, net_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqQw%3D","line":266,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":263,"context_line":"            LOG.debug(\"update_network(): \" + pformat(net_dict))"},{"line_number":264,"context_line":"            return net_dict"},{"line_number":265,"context_line":"        except Exception as e:"},{"line_number":266,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":267,"context_line":"            raise e"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def delete_network(self, context, net_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX7o%3D","line":266,"in_reply_to":"AAAASn%2F%2FqQw%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        belonging to the specified tenant."},{"line_number":273,"context_line":"        \"\"\""},{"line_number":274,"context_line":"        try:"},{"line_number":275,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":276,"context_line":"            cfgdb.network_delete(net_id)"},{"line_number":277,"context_line":"            LOG.debug(\"delete_network(): \" + pformat(net_id))"},{"line_number":278,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqQo%3D","line":275,"updated":"2013-09-01 02:50:32.000000000","message":"Why make calls against the class? You have an instance.\n\ncfgdb._get_user_cfgdb(context)","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        belonging to the specified tenant."},{"line_number":273,"context_line":"        \"\"\""},{"line_number":274,"context_line":"        try:"},{"line_number":275,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":276,"context_line":"            cfgdb.network_delete(net_id)"},{"line_number":277,"context_line":"            LOG.debug(\"delete_network(): \" + pformat(net_id))"},{"line_number":278,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX7k%3D","line":275,"in_reply_to":"AAAASn%2F%2FqQo%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":276,"context_line":"            cfgdb.network_delete(net_id)"},{"line_number":277,"context_line":"            LOG.debug(\"delete_network(): \" + pformat(net_id))"},{"line_number":278,"context_line":"        except Exception as e:"},{"line_number":279,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":280,"context_line":"            raise e"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def get_networks(self, context, filters\u003dNone, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqQs%3D","line":279,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":276,"context_line":"            cfgdb.network_delete(net_id)"},{"line_number":277,"context_line":"            LOG.debug(\"delete_network(): \" + pformat(net_id))"},{"line_number":278,"context_line":"        except Exception as e:"},{"line_number":279,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":280,"context_line":"            raise e"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def get_networks(self, context, filters\u003dNone, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX7c%3D","line":279,"in_reply_to":"AAAASn%2F%2FqQs%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def get_networks(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":283,"context_line":"        try:"},{"line_number":284,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":285,"context_line":"            nets_info \u003d cfgdb.network_list(filters)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"            nets_dicts \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqQY%3D","line":284,"updated":"2013-09-01 02:50:32.000000000","message":"call method directly on self","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def get_networks(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":283,"context_line":"        try:"},{"line_number":284,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":285,"context_line":"            nets_info \u003d cfgdb.network_list(filters)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"            nets_dicts \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX7U%3D","line":284,"in_reply_to":"AAAASn%2F%2FqQY%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":285,"context_line":"            nets_info \u003d cfgdb.network_list(filters)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"            nets_dicts \u003d []"},{"line_number":288,"context_line":"            for n_info in nets_info:"},{"line_number":289,"context_line":"                # verify transformation is conforming to api"},{"line_number":290,"context_line":"                n_dict \u003d self._make_network_dict(n_info[\u0027q_api_data\u0027], fields,"},{"line_number":291,"context_line":"                                                 False)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FLDQ%3D","line":288,"updated":"2013-10-02 23:32:37.000000000","message":"nit: net_info.\nWe shouldn\u0027t use shorten words for readability.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":285,"context_line":"            nets_info \u003d cfgdb.network_list(filters)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"            nets_dicts \u003d []"},{"line_number":288,"context_line":"            for n_info in nets_info:"},{"line_number":289,"context_line":"                # verify transformation is conforming to api"},{"line_number":290,"context_line":"                n_dict \u003d self._make_network_dict(n_info[\u0027q_api_data\u0027], fields,"},{"line_number":291,"context_line":"                                                 False)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F8gY%3D","line":288,"in_reply_to":"AAAAS3%2F%2FLDQ%3D","updated":"2013-10-07 16:59:22.000000000","message":"net_info is for single network and nets_info for more than one. Since function name is get_networks().  it is clear that net_info is for network","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                + pformat(nets_dicts))"},{"line_number":299,"context_line":"            return nets_dicts"},{"line_number":300,"context_line":"        except Exception as e:"},{"line_number":301,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":302,"context_line":"            raise e"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def get_networks_count(self, context, filters\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqQU%3D","line":301,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                + pformat(nets_dicts))"},{"line_number":299,"context_line":"            return nets_dicts"},{"line_number":300,"context_line":"        except Exception as e:"},{"line_number":301,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":302,"context_line":"            raise e"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def get_networks_count(self, context, filters\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX7M%3D","line":301,"in_reply_to":"AAAASn%2F%2FqQU%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def get_networks_count(self, context, filters\u003dNone):"},{"line_number":305,"context_line":"        try:"},{"line_number":306,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":307,"context_line":"            nets_count \u003d cfgdb.network_count(filters)"},{"line_number":308,"context_line":"            LOG.debug(\"get_networks_count(): \" + str(nets_count))"},{"line_number":309,"context_line":"            return nets_count"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqQM%3D","line":306,"updated":"2013-09-01 02:50:32.000000000","message":"self._get_user_cfgdb(context)","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def get_networks_count(self, context, filters\u003dNone):"},{"line_number":305,"context_line":"        try:"},{"line_number":306,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":307,"context_line":"            nets_count \u003d cfgdb.network_count(filters)"},{"line_number":308,"context_line":"            LOG.debug(\"get_networks_count(): \" + str(nets_count))"},{"line_number":309,"context_line":"            return nets_count"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX7I%3D","line":306,"in_reply_to":"AAAASn%2F%2FqQM%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":308,"context_line":"            LOG.debug(\"get_networks_count(): \" + str(nets_count))"},{"line_number":309,"context_line":"            return nets_count"},{"line_number":310,"context_line":"        except Exception as e:"},{"line_number":311,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":312,"context_line":"            raise e"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    # Subnet API handlers"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqQQ%3D","line":311,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":308,"context_line":"            LOG.debug(\"get_networks_count(): \" + str(nets_count))"},{"line_number":309,"context_line":"            return nets_count"},{"line_number":310,"context_line":"        except Exception as e:"},{"line_number":311,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":312,"context_line":"            raise e"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    # Subnet API handlers"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX7E%3D","line":311,"in_reply_to":"AAAASn%2F%2FqQQ%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":314,"context_line":"    # Subnet API handlers"},{"line_number":315,"context_line":"    def create_subnet(self, context, subnet):"},{"line_number":316,"context_line":"        try:"},{"line_number":317,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":318,"context_line":"            subnet_info \u003d cfgdb.subnet_create(subnet[\u0027subnet\u0027])"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"            # verify transformation is conforming to api"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqQI%3D","line":317,"updated":"2013-09-01 02:50:32.000000000","message":"call on instance directly","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":314,"context_line":"    # Subnet API handlers"},{"line_number":315,"context_line":"    def create_subnet(self, context, subnet):"},{"line_number":316,"context_line":"        try:"},{"line_number":317,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":318,"context_line":"            subnet_info \u003d cfgdb.subnet_create(subnet[\u0027subnet\u0027])"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"            # verify transformation is conforming to api"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX7A%3D","line":317,"in_reply_to":"AAAASn%2F%2FqQI%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":325,"context_line":"            LOG.debug(\"create_subnet(): \" + pformat(subnet_dict))"},{"line_number":326,"context_line":"            return subnet_dict"},{"line_number":327,"context_line":"        except Exception as e:"},{"line_number":328,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":329,"context_line":"            raise e"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    def get_subnet(self, context, subnet_id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqQE%3D","line":328,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":325,"context_line":"            LOG.debug(\"create_subnet(): \" + pformat(subnet_dict))"},{"line_number":326,"context_line":"            return subnet_dict"},{"line_number":327,"context_line":"        except Exception as e:"},{"line_number":328,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":329,"context_line":"            raise e"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    def get_subnet(self, context, subnet_id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX6Y%3D","line":328,"in_reply_to":"AAAASn%2F%2FqQE%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    def get_subnet(self, context, subnet_id, fields\u003dNone):"},{"line_number":332,"context_line":"        try:"},{"line_number":333,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":334,"context_line":"            subnet_info \u003d cfgdb.subnet_read(subnet_id)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"            # verify transformation is conforming to api"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqQA%3D","line":333,"updated":"2013-09-01 02:50:32.000000000","message":"call on self directly","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    def get_subnet(self, context, subnet_id, fields\u003dNone):"},{"line_number":332,"context_line":"        try:"},{"line_number":333,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":334,"context_line":"            subnet_info \u003d cfgdb.subnet_read(subnet_id)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"            # verify transformation is conforming to api"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX6U%3D","line":333,"in_reply_to":"AAAASn%2F%2FqQA%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            LOG.debug(\"get_subnet(): \" + pformat(subnet_dict))"},{"line_number":343,"context_line":"            return self._fields(subnet_dict, fields)"},{"line_number":344,"context_line":"        except Exception as e:"},{"line_number":345,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":346,"context_line":"            raise e"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def update_subnet(self, context, subnet_id, subnet):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqP8%3D","line":345,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            LOG.debug(\"get_subnet(): \" + pformat(subnet_dict))"},{"line_number":343,"context_line":"            return self._fields(subnet_dict, fields)"},{"line_number":344,"context_line":"        except Exception as e:"},{"line_number":345,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":346,"context_line":"            raise e"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def update_subnet(self, context, subnet_id, subnet):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX6Q%3D","line":345,"in_reply_to":"AAAASn%2F%2FqP8%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def update_subnet(self, context, subnet_id, subnet):"},{"line_number":349,"context_line":"        try:"},{"line_number":350,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":351,"context_line":"            subnet_info \u003d cfgdb.subnet_update(subnet_id, subnet[\u0027subnet\u0027])"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"            # verify transformation is conforming to api"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqP4%3D","line":350,"updated":"2013-09-01 02:50:32.000000000","message":"call on instance directly","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def update_subnet(self, context, subnet_id, subnet):"},{"line_number":349,"context_line":"        try:"},{"line_number":350,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":351,"context_line":"            subnet_info \u003d cfgdb.subnet_update(subnet_id, subnet[\u0027subnet\u0027])"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"            # verify transformation is conforming to api"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX6M%3D","line":350,"in_reply_to":"AAAASn%2F%2FqP4%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":358,"context_line":"            LOG.debug(\"update_subnet(): \" + pformat(subnet_dict))"},{"line_number":359,"context_line":"            return subnet_dict"},{"line_number":360,"context_line":"        except Exception as e:"},{"line_number":361,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":362,"context_line":"            raise e"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def delete_subnet(self, context, subnet_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqP0%3D","line":361,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":358,"context_line":"            LOG.debug(\"update_subnet(): \" + pformat(subnet_dict))"},{"line_number":359,"context_line":"            return subnet_dict"},{"line_number":360,"context_line":"        except Exception as e:"},{"line_number":361,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":362,"context_line":"            raise e"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def delete_subnet(self, context, subnet_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX6E%3D","line":361,"in_reply_to":"AAAASn%2F%2FqP0%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def delete_subnet(self, context, subnet_id):"},{"line_number":365,"context_line":"        try:"},{"line_number":366,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":367,"context_line":"            cfgdb.subnet_delete(subnet_id)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"            LOG.debug(\"delete_subnet(): \" + pformat(subnet_id))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqPw%3D","line":366,"updated":"2013-09-01 02:50:32.000000000","message":"call on instance directly","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def delete_subnet(self, context, subnet_id):"},{"line_number":365,"context_line":"        try:"},{"line_number":366,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":367,"context_line":"            cfgdb.subnet_delete(subnet_id)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"            LOG.debug(\"delete_subnet(): \" + pformat(subnet_id))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX6A%3D","line":366,"in_reply_to":"AAAASn%2F%2FqPw%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":368,"context_line":""},{"line_number":369,"context_line":"            LOG.debug(\"delete_subnet(): \" + pformat(subnet_id))"},{"line_number":370,"context_line":"        except Exception as e:"},{"line_number":371,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":372,"context_line":"            raise e"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def get_subnets(self, context, filters\u003dNone, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqPs%3D","line":371,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":368,"context_line":""},{"line_number":369,"context_line":"            LOG.debug(\"delete_subnet(): \" + pformat(subnet_id))"},{"line_number":370,"context_line":"        except Exception as e:"},{"line_number":371,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":372,"context_line":"            raise e"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def get_subnets(self, context, filters\u003dNone, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX58%3D","line":371,"in_reply_to":"AAAASn%2F%2FqPs%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        Called from Neutron API -\u003e get_\u003cresource\u003e"},{"line_number":377,"context_line":"        \"\"\""},{"line_number":378,"context_line":"        try:"},{"line_number":379,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":380,"context_line":"            subnets_info \u003d cfgdb.subnets_list(filters)"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"            subnets_dicts \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqPo%3D","line":379,"updated":"2013-09-01 02:50:32.000000000","message":"call on instance directly","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        Called from Neutron API -\u003e get_\u003cresource\u003e"},{"line_number":377,"context_line":"        \"\"\""},{"line_number":378,"context_line":"        try:"},{"line_number":379,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":380,"context_line":"            subnets_info \u003d cfgdb.subnets_list(filters)"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"            subnets_dicts \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX50%3D","line":379,"in_reply_to":"AAAASn%2F%2FqPo%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":380,"context_line":"            subnets_info \u003d cfgdb.subnets_list(filters)"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"            subnets_dicts \u003d []"},{"line_number":383,"context_line":"            for sn_info in subnets_info:"},{"line_number":384,"context_line":"                # verify transformation is conforming to api"},{"line_number":385,"context_line":"                sn_dict \u003d self._make_subnet_dict(sn_info[\u0027q_api_data\u0027], fields)"},{"line_number":386,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FLEw%3D","line":383,"updated":"2013-10-02 23:32:37.000000000","message":"nit: I prefer subnet_info","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":380,"context_line":"            subnets_info \u003d cfgdb.subnets_list(filters)"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"            subnets_dicts \u003d []"},{"line_number":383,"context_line":"            for sn_info in subnets_info:"},{"line_number":384,"context_line":"                # verify transformation is conforming to api"},{"line_number":385,"context_line":"                sn_dict \u003d self._make_subnet_dict(sn_info[\u0027q_api_data\u0027], fields)"},{"line_number":386,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F8gI%3D","line":383,"in_reply_to":"AAAAS3%2F%2FLEw%3D","updated":"2013-10-07 16:59:22.000000000","message":"since function name is get_subnets(), it is clear to understand sn_info for subnet, will prefer to keep it","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":392,"context_line":"                + pformat(subnets_dicts))"},{"line_number":393,"context_line":"            return subnets_dicts"},{"line_number":394,"context_line":"        except Exception as e:"},{"line_number":395,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":396,"context_line":"            raise e"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    def get_subnets_count(self, context, filters\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqPk%3D","line":395,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":392,"context_line":"                + pformat(subnets_dicts))"},{"line_number":393,"context_line":"            return subnets_dicts"},{"line_number":394,"context_line":"        except Exception as e:"},{"line_number":395,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":396,"context_line":"            raise e"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    def get_subnets_count(self, context, filters\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX5w%3D","line":395,"in_reply_to":"AAAASn%2F%2FqPk%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    def get_subnets_count(self, context, filters\u003dNone):"},{"line_number":399,"context_line":"        try:"},{"line_number":400,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":401,"context_line":"            subnets_count \u003d cfgdb.subnets_count(filters)"},{"line_number":402,"context_line":"            LOG.debug(\"get_subnets_count(): \" + str(subnets_count))"},{"line_number":403,"context_line":"            return subnets_count"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqPc%3D","line":400,"updated":"2013-09-01 02:50:32.000000000","message":"call on instance directly","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    def get_subnets_count(self, context, filters\u003dNone):"},{"line_number":399,"context_line":"        try:"},{"line_number":400,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":401,"context_line":"            subnets_count \u003d cfgdb.subnets_count(filters)"},{"line_number":402,"context_line":"            LOG.debug(\"get_subnets_count(): \" + str(subnets_count))"},{"line_number":403,"context_line":"            return subnets_count"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX5o%3D","line":400,"in_reply_to":"AAAASn%2F%2FqPc%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":402,"context_line":"            LOG.debug(\"get_subnets_count(): \" + str(subnets_count))"},{"line_number":403,"context_line":"            return subnets_count"},{"line_number":404,"context_line":"        except Exception as e:"},{"line_number":405,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":406,"context_line":"            raise e"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"    # Ipam API handlers"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqPg%3D","line":405,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":402,"context_line":"            LOG.debug(\"get_subnets_count(): \" + str(subnets_count))"},{"line_number":403,"context_line":"            return subnets_count"},{"line_number":404,"context_line":"        except Exception as e:"},{"line_number":405,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":406,"context_line":"            raise e"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"    # Ipam API handlers"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX5k%3D","line":405,"in_reply_to":"AAAASn%2F%2FqPg%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        a symbolic name."},{"line_number":413,"context_line":"        \"\"\""},{"line_number":414,"context_line":"        try:"},{"line_number":415,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":416,"context_line":"            ipam_info \u003d cfgdb.ipam_create(ipam[\u0027ipam\u0027])"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"            ##verify transformation is conforming to api"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqPU%3D","line":415,"updated":"2013-09-01 02:50:32.000000000","message":"call on instance directly","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        a symbolic name."},{"line_number":413,"context_line":"        \"\"\""},{"line_number":414,"context_line":"        try:"},{"line_number":415,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":416,"context_line":"            ipam_info \u003d cfgdb.ipam_create(ipam[\u0027ipam\u0027])"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"            ##verify transformation is conforming to api"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX1E%3D","line":415,"in_reply_to":"AAAASn%2F%2FqPU%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":415,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":416,"context_line":"            ipam_info \u003d cfgdb.ipam_create(ipam[\u0027ipam\u0027])"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"            ##verify transformation is conforming to api"},{"line_number":419,"context_line":"            #ipam_dict \u003d self._make_ipam_dict(ipam_info)"},{"line_number":420,"context_line":"            ipam_dict \u003d ipam_info[\u0027q_api_data\u0027]"},{"line_number":421,"context_line":"            ipam_dict.update(ipam_info[\u0027q_extra_data\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FLEQ%3D","line":418,"updated":"2013-10-02 23:32:37.000000000","message":"nit:## should be #","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":415,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":416,"context_line":"            ipam_info \u003d cfgdb.ipam_create(ipam[\u0027ipam\u0027])"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"            ##verify transformation is conforming to api"},{"line_number":419,"context_line":"            #ipam_dict \u003d self._make_ipam_dict(ipam_info)"},{"line_number":420,"context_line":"            ipam_dict \u003d ipam_info[\u0027q_api_data\u0027]"},{"line_number":421,"context_line":"            ipam_dict.update(ipam_info[\u0027q_extra_data\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F8gE%3D","line":418,"in_reply_to":"AAAAS3%2F%2FLEQ%3D","updated":"2013-10-07 16:59:22.000000000","message":"Done","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":423,"context_line":"            LOG.debug(\"create_ipam(): \" + pformat(ipam_dict))"},{"line_number":424,"context_line":"            return ipam_dict"},{"line_number":425,"context_line":"        except Exception as e:"},{"line_number":426,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":427,"context_line":"            raise e"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    def get_ipam(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqPY%3D","line":426,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":423,"context_line":"            LOG.debug(\"create_ipam(): \" + pformat(ipam_dict))"},{"line_number":424,"context_line":"            return ipam_dict"},{"line_number":425,"context_line":"        except Exception as e:"},{"line_number":426,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":427,"context_line":"            raise e"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    def get_ipam(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX5c%3D","line":426,"in_reply_to":"AAAASn%2F%2FqPY%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":431,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":432,"context_line":"            ipam_info \u003d cfgdb.ipam_read(id)"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"            ## verify transformation is conforming to api"},{"line_number":435,"context_line":"            #ipam_dict \u003d self._make_ipam_dict(ipam_info)"},{"line_number":436,"context_line":"            ipam_dict \u003d ipam_info[\u0027q_api_data\u0027]"},{"line_number":437,"context_line":"            ipam_dict.update(ipam_info[\u0027q_extra_data\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FLEM%3D","line":434,"updated":"2013-10-02 23:32:37.000000000","message":"nit:## should be #","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":431,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":432,"context_line":"            ipam_info \u003d cfgdb.ipam_read(id)"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"            ## verify transformation is conforming to api"},{"line_number":435,"context_line":"            #ipam_dict \u003d self._make_ipam_dict(ipam_info)"},{"line_number":436,"context_line":"            ipam_dict \u003d ipam_info[\u0027q_api_data\u0027]"},{"line_number":437,"context_line":"            ipam_dict.update(ipam_info[\u0027q_extra_data\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F8f8%3D","line":434,"in_reply_to":"AAAAS3%2F%2FLEM%3D","updated":"2013-10-07 16:59:22.000000000","message":"Done","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            LOG.debug(\"get_ipam(): \" + pformat(ipam_dict))"},{"line_number":440,"context_line":"            return ipam_dict"},{"line_number":441,"context_line":"        except Exception as e:"},{"line_number":442,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":443,"context_line":"            raise e"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"    def update_ipam(self, context, id, ipam):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqPQ%3D","line":442,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            LOG.debug(\"get_ipam(): \" + pformat(ipam_dict))"},{"line_number":440,"context_line":"            return ipam_dict"},{"line_number":441,"context_line":"        except Exception as e:"},{"line_number":442,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":443,"context_line":"            raise e"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"    def update_ipam(self, context, id, ipam):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX5U%3D","line":442,"in_reply_to":"AAAASn%2F%2FqPQ%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":450,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":451,"context_line":"            ipam_info \u003d cfgdb.ipam_update(id, ipam)"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"            ## verify transformation is conforming to api"},{"line_number":454,"context_line":"            #ipam_dict \u003d self._make_ipam_dict(ipam_info)"},{"line_number":455,"context_line":"            ipam_dict \u003d ipam_info[\u0027q_api_data\u0027]"},{"line_number":456,"context_line":"            ipam_dict.update(ipam_info[\u0027q_extra_data\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FLD8%3D","line":453,"updated":"2013-10-02 23:32:37.000000000","message":"nit:## should be #","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":450,"context_line":"            cfgdb \u003d ContrailPlugin._get_user_cfgdb(context)"},{"line_number":451,"context_line":"            ipam_info \u003d cfgdb.ipam_update(id, ipam)"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"            ## verify transformation is conforming to api"},{"line_number":454,"context_line":"            #ipam_dict \u003d self._make_ipam_dict(ipam_info)"},{"line_number":455,"context_line":"            ipam_dict \u003d ipam_info[\u0027q_api_data\u0027]"},{"line_number":456,"context_line":"            ipam_dict.update(ipam_info[\u0027q_extra_data\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F8f4%3D","line":453,"in_reply_to":"AAAAS3%2F%2FLD8%3D","updated":"2013-10-07 16:59:22.000000000","message":"Done","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":458,"context_line":"            LOG.debug(\"update_ipam(): \" + pformat(ipam_dict))"},{"line_number":459,"context_line":"            return ipam_dict"},{"line_number":460,"context_line":"        except Exception as e:"},{"line_number":461,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":462,"context_line":"            raise e"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"    def delete_ipam(self, context, ipam_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqPM%3D","line":461,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":458,"context_line":"            LOG.debug(\"update_ipam(): \" + pformat(ipam_dict))"},{"line_number":459,"context_line":"            return ipam_dict"},{"line_number":460,"context_line":"        except Exception as e:"},{"line_number":461,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":462,"context_line":"            raise e"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"    def delete_ipam(self, context, ipam_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX5M%3D","line":461,"in_reply_to":"AAAASn%2F%2FqPM%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":471,"context_line":""},{"line_number":472,"context_line":"            LOG.debug(\"delete_ipam(): \" + pformat(ipam_id))"},{"line_number":473,"context_line":"        except Exception as e:"},{"line_number":474,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":475,"context_line":"            raise e"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"    def get_ipams(self, context, filters\u003dNone, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqPI%3D","line":474,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":471,"context_line":""},{"line_number":472,"context_line":"            LOG.debug(\"delete_ipam(): \" + pformat(ipam_id))"},{"line_number":473,"context_line":"        except Exception as e:"},{"line_number":474,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":475,"context_line":"            raise e"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"    def get_ipams(self, context, filters\u003dNone, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX4g%3D","line":474,"in_reply_to":"AAAASn%2F%2FqPI%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":490,"context_line":"            LOG.debug(\"get_ipams(): \" + pformat(ipams_dicts))"},{"line_number":491,"context_line":"            return ipams_dicts"},{"line_number":492,"context_line":"        except Exception as e:"},{"line_number":493,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":494,"context_line":"            raise e"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"    def get_ipams_count(self, context, filters\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqPE%3D","line":493,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":490,"context_line":"            LOG.debug(\"get_ipams(): \" + pformat(ipams_dicts))"},{"line_number":491,"context_line":"            return ipams_dicts"},{"line_number":492,"context_line":"        except Exception as e:"},{"line_number":493,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":494,"context_line":"            raise e"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"    def get_ipams_count(self, context, filters\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX4c%3D","line":493,"in_reply_to":"AAAASn%2F%2FqPE%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            LOG.debug(\"get_ipams_count(): \" + str(ipams_count))"},{"line_number":501,"context_line":"            return ipams_count"},{"line_number":502,"context_line":"        except Exception as e:"},{"line_number":503,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":504,"context_line":"            raise e"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    # Policy API handlers"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqM4%3D","line":503,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            LOG.debug(\"get_ipams_count(): \" + str(ipams_count))"},{"line_number":501,"context_line":"            return ipams_count"},{"line_number":502,"context_line":"        except Exception as e:"},{"line_number":503,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":504,"context_line":"            raise e"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    # Policy API handlers"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX4Y%3D","line":503,"in_reply_to":"AAAASn%2F%2FqM4%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":521,"context_line":"            LOG.debug(\"create_policy(): \" + pformat(policy_dict))"},{"line_number":522,"context_line":"            return policy_dict"},{"line_number":523,"context_line":"        except Exception as e:"},{"line_number":524,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":525,"context_line":"            raise e"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    def get_policy(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqM8%3D","line":524,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":521,"context_line":"            LOG.debug(\"create_policy(): \" + pformat(policy_dict))"},{"line_number":522,"context_line":"            return policy_dict"},{"line_number":523,"context_line":"        except Exception as e:"},{"line_number":524,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":525,"context_line":"            raise e"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    def get_policy(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX4U%3D","line":524,"in_reply_to":"AAAASn%2F%2FqM8%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":537,"context_line":"            LOG.debug(\"get_policy(): \" + pformat(policy_dict))"},{"line_number":538,"context_line":"            return policy_dict"},{"line_number":539,"context_line":"        except Exception as e:"},{"line_number":540,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":541,"context_line":"            raise e"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    def update_policy(self, context, id, policy):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqNA%3D","line":540,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":537,"context_line":"            LOG.debug(\"get_policy(): \" + pformat(policy_dict))"},{"line_number":538,"context_line":"            return policy_dict"},{"line_number":539,"context_line":"        except Exception as e:"},{"line_number":540,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":541,"context_line":"            raise e"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    def update_policy(self, context, id, policy):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX4Q%3D","line":540,"in_reply_to":"AAAASn%2F%2FqNA%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":556,"context_line":"            LOG.debug(\"update_policy(): \" + pformat(policy_dict))"},{"line_number":557,"context_line":"            return policy_dict"},{"line_number":558,"context_line":"        except Exception as e:"},{"line_number":559,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":560,"context_line":"            raise e"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"    def delete_policy(self, context, policy_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqNE%3D","line":559,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":556,"context_line":"            LOG.debug(\"update_policy(): \" + pformat(policy_dict))"},{"line_number":557,"context_line":"            return policy_dict"},{"line_number":558,"context_line":"        except Exception as e:"},{"line_number":559,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":560,"context_line":"            raise e"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"    def delete_policy(self, context, policy_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX4M%3D","line":559,"in_reply_to":"AAAASn%2F%2FqNE%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":569,"context_line":""},{"line_number":570,"context_line":"            LOG.debug(\"delete_policy(): \" + pformat(policy_id))"},{"line_number":571,"context_line":"        except Exception as e:"},{"line_number":572,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":573,"context_line":"            raise e"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    def get_policys(self, context, filters\u003dNone, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqNI%3D","line":572,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":569,"context_line":""},{"line_number":570,"context_line":"            LOG.debug(\"delete_policy(): \" + pformat(policy_id))"},{"line_number":571,"context_line":"        except Exception as e:"},{"line_number":572,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":573,"context_line":"            raise e"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    def get_policys(self, context, filters\u003dNone, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX4E%3D","line":572,"in_reply_to":"AAAASn%2F%2FqNI%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":588,"context_line":"            LOG.debug(\"get_policys(): \" + pformat(policys_dicts))"},{"line_number":589,"context_line":"            return policys_dicts"},{"line_number":590,"context_line":"        except Exception as e:"},{"line_number":591,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":592,"context_line":"            raise e"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"    def get_policy_count(self, context, filters\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqNM%3D","line":591,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":588,"context_line":"            LOG.debug(\"get_policys(): \" + pformat(policys_dicts))"},{"line_number":589,"context_line":"            return policys_dicts"},{"line_number":590,"context_line":"        except Exception as e:"},{"line_number":591,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":592,"context_line":"            raise e"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"    def get_policy_count(self, context, filters\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX4A%3D","line":591,"in_reply_to":"AAAASn%2F%2FqNM%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":598,"context_line":"            LOG.debug(\"get_policy_count(): \" + str(policy_count))"},{"line_number":599,"context_line":"            return policy_count"},{"line_number":600,"context_line":"        except Exception as e:"},{"line_number":601,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":602,"context_line":"            raise e"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    # Floating IP API handlers"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqNQ%3D","line":601,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":598,"context_line":"            LOG.debug(\"get_policy_count(): \" + str(policy_count))"},{"line_number":599,"context_line":"            return policy_count"},{"line_number":600,"context_line":"        except Exception as e:"},{"line_number":601,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":602,"context_line":"            raise e"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    # Floating IP API handlers"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX34%3D","line":601,"in_reply_to":"AAAASn%2F%2FqNQ%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":625,"context_line":"            LOG.debug(\"create_floatingip(): \" + pformat(fip_dict))"},{"line_number":626,"context_line":"            return fip_dict"},{"line_number":627,"context_line":"        except Exception as e:"},{"line_number":628,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":629,"context_line":"            raise e"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    def update_floatingip(self, context, fip_id, floatingip):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqNU%3D","line":628,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":625,"context_line":"            LOG.debug(\"create_floatingip(): \" + pformat(fip_dict))"},{"line_number":626,"context_line":"            return fip_dict"},{"line_number":627,"context_line":"        except Exception as e:"},{"line_number":628,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":629,"context_line":"            raise e"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    def update_floatingip(self, context, fip_id, floatingip):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX30%3D","line":628,"in_reply_to":"AAAASn%2F%2FqNU%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":642,"context_line":"            LOG.debug(\"update_floatingip(): \" + pformat(fip_dict))"},{"line_number":643,"context_line":"            return fip_dict"},{"line_number":644,"context_line":"        except Exception as e:"},{"line_number":645,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":646,"context_line":"            raise e"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"    def get_floatingip(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqNY%3D","line":645,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":642,"context_line":"            LOG.debug(\"update_floatingip(): \" + pformat(fip_dict))"},{"line_number":643,"context_line":"            return fip_dict"},{"line_number":644,"context_line":"        except Exception as e:"},{"line_number":645,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":646,"context_line":"            raise e"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"    def get_floatingip(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX3w%3D","line":645,"in_reply_to":"AAAASn%2F%2FqNY%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":658,"context_line":"            LOG.debug(\"get_floatingip(): \" + pformat(fip_dict))"},{"line_number":659,"context_line":"            return fip_dict"},{"line_number":660,"context_line":"        except Exception as e:"},{"line_number":661,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":662,"context_line":"            raise e"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"    def delete_floatingip(self, context, fip_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqNc%3D","line":661,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":658,"context_line":"            LOG.debug(\"get_floatingip(): \" + pformat(fip_dict))"},{"line_number":659,"context_line":"            return fip_dict"},{"line_number":660,"context_line":"        except Exception as e:"},{"line_number":661,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":662,"context_line":"            raise e"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"    def delete_floatingip(self, context, fip_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX3s%3D","line":661,"in_reply_to":"AAAASn%2F%2FqNc%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":667,"context_line":"            cfgdb.floatingip_delete(fip_id)"},{"line_number":668,"context_line":"            LOG.debug(\"delete_floating(): \" + pformat(fip_id))"},{"line_number":669,"context_line":"        except Exception as e:"},{"line_number":670,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":671,"context_line":"            raise e"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"    def get_floatingips(self, context, filters\u003dNone, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqNg%3D","line":670,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":667,"context_line":"            cfgdb.floatingip_delete(fip_id)"},{"line_number":668,"context_line":"            LOG.debug(\"delete_floating(): \" + pformat(fip_id))"},{"line_number":669,"context_line":"        except Exception as e:"},{"line_number":670,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":671,"context_line":"            raise e"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"    def get_floatingips(self, context, filters\u003dNone, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX3o%3D","line":670,"in_reply_to":"AAAASn%2F%2FqNg%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":686,"context_line":"            LOG.debug(\"get_floatingips(): \" + pformat(fips_dicts))"},{"line_number":687,"context_line":"            return fips_dicts"},{"line_number":688,"context_line":"        except Exception as e:"},{"line_number":689,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":690,"context_line":"            raise e"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"    def get_floatingips_count(self, context, filters\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqNk%3D","line":689,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":686,"context_line":"            LOG.debug(\"get_floatingips(): \" + pformat(fips_dicts))"},{"line_number":687,"context_line":"            return fips_dicts"},{"line_number":688,"context_line":"        except Exception as e:"},{"line_number":689,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":690,"context_line":"            raise e"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"    def get_floatingips_count(self, context, filters\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX3k%3D","line":689,"in_reply_to":"AAAASn%2F%2FqNk%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":696,"context_line":"            LOG.debug(\"get_floatingips_count(): \" + str(floatingips_count))"},{"line_number":697,"context_line":"            return floatingips_count"},{"line_number":698,"context_line":"        except Exception as e:"},{"line_number":699,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":700,"context_line":"            raise e"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"    # Port API handlers"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqNo%3D","line":699,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":696,"context_line":"            LOG.debug(\"get_floatingips_count(): \" + str(floatingips_count))"},{"line_number":697,"context_line":"            return floatingips_count"},{"line_number":698,"context_line":"        except Exception as e:"},{"line_number":699,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":700,"context_line":"            raise e"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"    # Port API handlers"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX3c%3D","line":699,"in_reply_to":"AAAASn%2F%2FqNo%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":716,"context_line":"            LOG.debug(\"create_port(): \" + pformat(port_dict))"},{"line_number":717,"context_line":"            return port_dict"},{"line_number":718,"context_line":"        except Exception as e:"},{"line_number":719,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":720,"context_line":"            raise e"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"    def get_port(self, context, port_id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqNs%3D","line":719,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":716,"context_line":"            LOG.debug(\"create_port(): \" + pformat(port_dict))"},{"line_number":717,"context_line":"            return port_dict"},{"line_number":718,"context_line":"        except Exception as e:"},{"line_number":719,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":720,"context_line":"            raise e"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"    def get_port(self, context, port_id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX3Y%3D","line":719,"in_reply_to":"AAAASn%2F%2FqNs%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":732,"context_line":"            LOG.debug(\"get_port(): \" + pformat(port_dict))"},{"line_number":733,"context_line":"            return self._fields(port_dict, fields)"},{"line_number":734,"context_line":"        except Exception as e:"},{"line_number":735,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":736,"context_line":"            raise e"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"    def update_port(self, context, port_id, port):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqNw%3D","line":735,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":732,"context_line":"            LOG.debug(\"get_port(): \" + pformat(port_dict))"},{"line_number":733,"context_line":"            return self._fields(port_dict, fields)"},{"line_number":734,"context_line":"        except Exception as e:"},{"line_number":735,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":736,"context_line":"            raise e"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"    def update_port(self, context, port_id, port):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX3U%3D","line":735,"in_reply_to":"AAAASn%2F%2FqNw%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":751,"context_line":"            LOG.debug(\"update_port(): \" + pformat(port_dict))"},{"line_number":752,"context_line":"            return port_dict"},{"line_number":753,"context_line":"        except Exception as e:"},{"line_number":754,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":755,"context_line":"            raise e"},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"    def delete_port(self, context, port_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqN0%3D","line":754,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":751,"context_line":"            LOG.debug(\"update_port(): \" + pformat(port_dict))"},{"line_number":752,"context_line":"            return port_dict"},{"line_number":753,"context_line":"        except Exception as e:"},{"line_number":754,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":755,"context_line":"            raise e"},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"    def delete_port(self, context, port_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX3Q%3D","line":754,"in_reply_to":"AAAASn%2F%2FqN0%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":766,"context_line":"            cfgdb.port_delete(port_id)"},{"line_number":767,"context_line":"            LOG.debug(\"delete_port(): \" + pformat(port_id))"},{"line_number":768,"context_line":"        except Exception as e:"},{"line_number":769,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":770,"context_line":"            raise e"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"    def get_ports(self, context, filters\u003dNone, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqN4%3D","line":769,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":766,"context_line":"            cfgdb.port_delete(port_id)"},{"line_number":767,"context_line":"            LOG.debug(\"delete_port(): \" + pformat(port_id))"},{"line_number":768,"context_line":"        except Exception as e:"},{"line_number":769,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":770,"context_line":"            raise e"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"    def get_ports(self, context, filters\u003dNone, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX3M%3D","line":769,"in_reply_to":"AAAASn%2F%2FqN4%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":791,"context_line":"                + pformat(ports_dicts))"},{"line_number":792,"context_line":"            return ports_dicts"},{"line_number":793,"context_line":"        except Exception as e:"},{"line_number":794,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":795,"context_line":"            raise e"},{"line_number":796,"context_line":""},{"line_number":797,"context_line":"    def get_ports_count(self, context, filters\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqN8%3D","line":794,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":791,"context_line":"                + pformat(ports_dicts))"},{"line_number":792,"context_line":"            return ports_dicts"},{"line_number":793,"context_line":"        except Exception as e:"},{"line_number":794,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":795,"context_line":"            raise e"},{"line_number":796,"context_line":""},{"line_number":797,"context_line":"    def get_ports_count(self, context, filters\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX3E%3D","line":794,"in_reply_to":"AAAASn%2F%2FqN8%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":801,"context_line":"            LOG.debug(\"get_ports_count(): \" + str(ports_count))"},{"line_number":802,"context_line":"            return ports_count"},{"line_number":803,"context_line":"        except Exception as e:"},{"line_number":804,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":805,"context_line":"            raise e"},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"    def plug_interface(self, tenant_id, net_id, port_id, remote_interface_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqOA%3D","line":804,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":801,"context_line":"            LOG.debug(\"get_ports_count(): \" + str(ports_count))"},{"line_number":802,"context_line":"            return ports_count"},{"line_number":803,"context_line":"        except Exception as e:"},{"line_number":804,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":805,"context_line":"            raise e"},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"    def plug_interface(self, tenant_id, net_id, port_id, remote_interface_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX3A%3D","line":804,"in_reply_to":"AAAASn%2F%2FqOA%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":853,"context_line":"            LOG.debug(\"create_route_table(): \" + pformat(rt_dict))"},{"line_number":854,"context_line":"            return rt_dict"},{"line_number":855,"context_line":"        except Exception as e:"},{"line_number":856,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":857,"context_line":"            raise e"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"    def update_route_table(self, context, id, route_table):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqOE%3D","line":856,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":853,"context_line":"            LOG.debug(\"create_route_table(): \" + pformat(rt_dict))"},{"line_number":854,"context_line":"            return rt_dict"},{"line_number":855,"context_line":"        except Exception as e:"},{"line_number":856,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":857,"context_line":"            raise e"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"    def update_route_table(self, context, id, route_table):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX28%3D","line":856,"in_reply_to":"AAAASn%2F%2FqOE%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":878,"context_line":"            cfgdb.route_table_delete(id)"},{"line_number":879,"context_line":"            LOG.debug(\"delete_route_table(): \" + pformat(id))"},{"line_number":880,"context_line":"        except Exception as e:"},{"line_number":881,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":882,"context_line":"            raise e"},{"line_number":883,"context_line":""},{"line_number":884,"context_line":"    def get_route_tables(self, context, filters\u003dNone, fields\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqOI%3D","line":881,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":878,"context_line":"            cfgdb.route_table_delete(id)"},{"line_number":879,"context_line":"            LOG.debug(\"delete_route_table(): \" + pformat(id))"},{"line_number":880,"context_line":"        except Exception as e:"},{"line_number":881,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":882,"context_line":"            raise e"},{"line_number":883,"context_line":""},{"line_number":884,"context_line":"    def get_route_tables(self, context, filters\u003dNone, fields\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX24%3D","line":881,"in_reply_to":"AAAASn%2F%2FqOI%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":902,"context_line":"                + \u0027data: \u0027 + pformat(route_tables_dicts))"},{"line_number":903,"context_line":"            return route_tables_dicts"},{"line_number":904,"context_line":"        except Exception as e:"},{"line_number":905,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":906,"context_line":"            raise e"},{"line_number":907,"context_line":""},{"line_number":908,"context_line":"    def get_route_table(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqOM%3D","line":905,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":902,"context_line":"                + \u0027data: \u0027 + pformat(route_tables_dicts))"},{"line_number":903,"context_line":"            return route_tables_dicts"},{"line_number":904,"context_line":"        except Exception as e:"},{"line_number":905,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":906,"context_line":"            raise e"},{"line_number":907,"context_line":""},{"line_number":908,"context_line":"    def get_route_table(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX20%3D","line":905,"in_reply_to":"AAAASn%2F%2FqOM%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":919,"context_line":"            LOG.debug(\"get_route_table(): \" + pformat(rt_dict))"},{"line_number":920,"context_line":"            return self._fields(rt_dict, fields)"},{"line_number":921,"context_line":"        except Exception as e:"},{"line_number":922,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":923,"context_line":"            raise e"},{"line_number":924,"context_line":""},{"line_number":925,"context_line":"    # VPC route table svc instance handlers"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqOQ%3D","line":922,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":919,"context_line":"            LOG.debug(\"get_route_table(): \" + pformat(rt_dict))"},{"line_number":920,"context_line":"            return self._fields(rt_dict, fields)"},{"line_number":921,"context_line":"        except Exception as e:"},{"line_number":922,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":923,"context_line":"            raise e"},{"line_number":924,"context_line":""},{"line_number":925,"context_line":"    # VPC route table svc instance handlers"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX2w%3D","line":922,"in_reply_to":"AAAASn%2F%2FqOQ%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":947,"context_line":"            LOG.debug(\"create_nat_instance(): \" + pformat(si_dict))"},{"line_number":948,"context_line":"            return si_dict"},{"line_number":949,"context_line":"        except Exception as e:"},{"line_number":950,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":951,"context_line":"            raise e"},{"line_number":952,"context_line":""},{"line_number":953,"context_line":"    def delete_nat_instance(self, context, id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqOU%3D","line":950,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":947,"context_line":"            LOG.debug(\"create_nat_instance(): \" + pformat(si_dict))"},{"line_number":948,"context_line":"            return si_dict"},{"line_number":949,"context_line":"        except Exception as e:"},{"line_number":950,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":951,"context_line":"            raise e"},{"line_number":952,"context_line":""},{"line_number":953,"context_line":"    def delete_nat_instance(self, context, id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX2k%3D","line":950,"in_reply_to":"AAAASn%2F%2FqOU%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":956,"context_line":"            cfgdb.svc_instance_delete(id)"},{"line_number":957,"context_line":"            LOG.debug(\"delete_nat_instance(): \" + pformat(id))"},{"line_number":958,"context_line":"        except Exception as e:"},{"line_number":959,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":960,"context_line":"            raise e"},{"line_number":961,"context_line":""},{"line_number":962,"context_line":"    def get_nat_instances(self, context, filters\u003dNone, fields\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqOY%3D","line":959,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":956,"context_line":"            cfgdb.svc_instance_delete(id)"},{"line_number":957,"context_line":"            LOG.debug(\"delete_nat_instance(): \" + pformat(id))"},{"line_number":958,"context_line":"        except Exception as e:"},{"line_number":959,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":960,"context_line":"            raise e"},{"line_number":961,"context_line":""},{"line_number":962,"context_line":"    def get_nat_instances(self, context, filters\u003dNone, fields\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX2g%3D","line":959,"in_reply_to":"AAAASn%2F%2FqOY%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":980,"context_line":"                + \u0027data: \u0027 + pformat(svc_instances_dicts))"},{"line_number":981,"context_line":"            return svc_instances_dicts"},{"line_number":982,"context_line":"        except Exception as e:"},{"line_number":983,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":984,"context_line":"            raise e"},{"line_number":985,"context_line":""},{"line_number":986,"context_line":"    def get_nat_instance(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqOc%3D","line":983,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":980,"context_line":"                + \u0027data: \u0027 + pformat(svc_instances_dicts))"},{"line_number":981,"context_line":"            return svc_instances_dicts"},{"line_number":982,"context_line":"        except Exception as e:"},{"line_number":983,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":984,"context_line":"            raise e"},{"line_number":985,"context_line":""},{"line_number":986,"context_line":"    def get_nat_instance(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX2c%3D","line":983,"in_reply_to":"AAAASn%2F%2FqOc%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":997,"context_line":"            LOG.debug(\"get_nat_instance(): \" + pformat(si_dict))"},{"line_number":998,"context_line":"            return self._fields(si_dict, fields)"},{"line_number":999,"context_line":"        except Exception as e:"},{"line_number":1000,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":1001,"context_line":"            raise e"},{"line_number":1002,"context_line":""},{"line_number":1003,"context_line":"    # Security Group handlers"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqOg%3D","line":1000,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":997,"context_line":"            LOG.debug(\"get_nat_instance(): \" + pformat(si_dict))"},{"line_number":998,"context_line":"            return self._fields(si_dict, fields)"},{"line_number":999,"context_line":"        except Exception as e:"},{"line_number":1000,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":1001,"context_line":"            raise e"},{"line_number":1002,"context_line":""},{"line_number":1003,"context_line":"    # Security Group handlers"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX2U%3D","line":1000,"in_reply_to":"AAAASn%2F%2FqOg%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":1038,"context_line":"            LOG.debug(\"create_security_group(): \" + pformat(sg_dict))"},{"line_number":1039,"context_line":"            return sg_dict"},{"line_number":1040,"context_line":"        except Exception as e:"},{"line_number":1041,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":1042,"context_line":"            raise e"},{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"    def delete_security_group(self, context, id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqOk%3D","line":1041,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":1038,"context_line":"            LOG.debug(\"create_security_group(): \" + pformat(sg_dict))"},{"line_number":1039,"context_line":"            return sg_dict"},{"line_number":1040,"context_line":"        except Exception as e:"},{"line_number":1041,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":1042,"context_line":"            raise e"},{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"    def delete_security_group(self, context, id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX2Q%3D","line":1041,"in_reply_to":"AAAASn%2F%2FqOk%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":1047,"context_line":"            cfgdb.security_group_delete(id)"},{"line_number":1048,"context_line":"            LOG.debug(\"delete_security_group(): \" + pformat(id))"},{"line_number":1049,"context_line":"        except Exception as e:"},{"line_number":1050,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":1051,"context_line":"            raise e"},{"line_number":1052,"context_line":""},{"line_number":1053,"context_line":"    def get_security_groups(self, context, filters\u003dNone, fields\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqOo%3D","line":1050,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":1047,"context_line":"            cfgdb.security_group_delete(id)"},{"line_number":1048,"context_line":"            LOG.debug(\"delete_security_group(): \" + pformat(id))"},{"line_number":1049,"context_line":"        except Exception as e:"},{"line_number":1050,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":1051,"context_line":"            raise e"},{"line_number":1052,"context_line":""},{"line_number":1053,"context_line":"    def get_security_groups(self, context, filters\u003dNone, fields\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX2M%3D","line":1050,"in_reply_to":"AAAASn%2F%2FqOo%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":1071,"context_line":"                + \u0027data: \u0027 + pformat(security_groups_dicts))"},{"line_number":1072,"context_line":"            return security_groups_dicts"},{"line_number":1073,"context_line":"        except Exception as e:"},{"line_number":1074,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":1075,"context_line":"            raise e"},{"line_number":1076,"context_line":""},{"line_number":1077,"context_line":"    def get_security_group(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqOs%3D","line":1074,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":1071,"context_line":"                + \u0027data: \u0027 + pformat(security_groups_dicts))"},{"line_number":1072,"context_line":"            return security_groups_dicts"},{"line_number":1073,"context_line":"        except Exception as e:"},{"line_number":1074,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":1075,"context_line":"            raise e"},{"line_number":1076,"context_line":""},{"line_number":1077,"context_line":"    def get_security_group(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX2I%3D","line":1074,"in_reply_to":"AAAASn%2F%2FqOs%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":1088,"context_line":"            LOG.debug(\"get_security_group(): \" + pformat(sg_dict))"},{"line_number":1089,"context_line":"            return self._fields(sg_dict, fields)"},{"line_number":1090,"context_line":"        except Exception as e:"},{"line_number":1091,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":1092,"context_line":"            raise e"},{"line_number":1093,"context_line":""},{"line_number":1094,"context_line":"    def create_security_group_rule(self, context, security_group_rule):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqOw%3D","line":1091,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":1088,"context_line":"            LOG.debug(\"get_security_group(): \" + pformat(sg_dict))"},{"line_number":1089,"context_line":"            return self._fields(sg_dict, fields)"},{"line_number":1090,"context_line":"        except Exception as e:"},{"line_number":1091,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":1092,"context_line":"            raise e"},{"line_number":1093,"context_line":""},{"line_number":1094,"context_line":"    def create_security_group_rule(self, context, security_group_rule):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX2A%3D","line":1091,"in_reply_to":"AAAASn%2F%2FqOw%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":1105,"context_line":"            LOG.debug(\"create_security_group_rule(): \" + pformat(sgr_dict))"},{"line_number":1106,"context_line":"            return sgr_dict"},{"line_number":1107,"context_line":"        except Exception as e:"},{"line_number":1108,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":1109,"context_line":"            raise e"},{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":"    def delete_security_group_rule(self, context, id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqO0%3D","line":1108,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":1105,"context_line":"            LOG.debug(\"create_security_group_rule(): \" + pformat(sgr_dict))"},{"line_number":1106,"context_line":"            return sgr_dict"},{"line_number":1107,"context_line":"        except Exception as e:"},{"line_number":1108,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":1109,"context_line":"            raise e"},{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":"    def delete_security_group_rule(self, context, id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX18%3D","line":1108,"in_reply_to":"AAAASn%2F%2FqO0%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"            cfgdb.security_group_rule_delete(id)"},{"line_number":1115,"context_line":"            LOG.debug(\"delete_security_group_rule(): \" + pformat(id))"},{"line_number":1116,"context_line":"        except Exception as e:"},{"line_number":1117,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":1118,"context_line":"            raise e"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"    def get_security_group_rules(self, context, filters\u003dNone, fields\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqO4%3D","line":1117,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"            cfgdb.security_group_rule_delete(id)"},{"line_number":1115,"context_line":"            LOG.debug(\"delete_security_group_rule(): \" + pformat(id))"},{"line_number":1116,"context_line":"        except Exception as e:"},{"line_number":1117,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":1118,"context_line":"            raise e"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"    def get_security_group_rules(self, context, filters\u003dNone, fields\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX14%3D","line":1117,"in_reply_to":"AAAASn%2F%2FqO4%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":1138,"context_line":"                \u0027data: \u0027 + pformat(security_group_rules_dicts))"},{"line_number":1139,"context_line":"            return security_group_rules_dicts"},{"line_number":1140,"context_line":"        except Exception as e:"},{"line_number":1141,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":1142,"context_line":"            raise e"},{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":"    def get_security_group_rule(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqO8%3D","line":1141,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":1138,"context_line":"                \u0027data: \u0027 + pformat(security_group_rules_dicts))"},{"line_number":1139,"context_line":"            return security_group_rules_dicts"},{"line_number":1140,"context_line":"        except Exception as e:"},{"line_number":1141,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":1142,"context_line":"            raise e"},{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":"    def get_security_group_rule(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX10%3D","line":1141,"in_reply_to":"AAAASn%2F%2FqO8%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":1156,"context_line":"            LOG.debug(\"get_security_group_rule(): \" + pformat(sgr_dict))"},{"line_number":1157,"context_line":"            return self._fields(sgr_dict, fields)"},{"line_number":1158,"context_line":"        except Exception as e:"},{"line_number":1159,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":1160,"context_line":"            raise e"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqPA%3D","line":1159,"updated":"2013-09-01 02:50:32.000000000","message":"LOG.exception()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":1156,"context_line":"            LOG.debug(\"get_security_group_rule(): \" + pformat(sgr_dict))"},{"line_number":1157,"context_line":"            return self._fields(sgr_dict, fields)"},{"line_number":1158,"context_line":"        except Exception as e:"},{"line_number":1159,"context_line":"            cgitb.Hook(format\u003d\"text\").handle(sys.exc_info())"},{"line_number":1160,"context_line":"            raise e"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX1o%3D","line":1159,"in_reply_to":"AAAASn%2F%2FqPA%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"8fcd70d5f8bacc773bf8fd517a597f4d1824ac69","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from httplib2 import Http"},{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":"from pprint import pformat"},{"line_number":22,"context_line":"import re"},{"line_number":23,"context_line":"import string"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FsRQ%3D","line":21,"updated":"2013-10-11 05:19:50.000000000","message":"imports are not in alphabetical order - running pep8 will give you more details","commit_id":"443152457e0f99d76e5c3cce2b804fcd3b5871e5"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"d5f4fba8027248225afe32880e53c0088cde26e9","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from httplib2 import Http"},{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":"from pprint import pformat"},{"line_number":22,"context_line":"import re"},{"line_number":23,"context_line":"import string"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FsQE%3D","line":21,"in_reply_to":"AAAATH%2F%2FsRQ%3D","updated":"2013-10-11 05:28:36.000000000","message":"this is alphabetical order, which one are you referring to specifically?","commit_id":"443152457e0f99d76e5c3cce2b804fcd3b5871e5"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"3987f40ace876847a20e33ca83f13c1d6ab32803","unresolved":false,"context_lines":[{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def _read_cfg(multi_parser, section, option, default):"},{"line_number":43,"context_line":"        name_tuple \u003d (section, option)"},{"line_number":44,"context_line":"        cfg_names \u003d []"},{"line_number":45,"context_line":"        cfg_names.append(name_tuple)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FoxE%3D","line":42,"updated":"2013-10-11 23:17:26.000000000","message":"In previous patch, you said you will use olso.config instead of this function..","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"7ae63bf3a195a99bb0b003a37c390f7d8b7331e3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def _read_cfg(multi_parser, section, option, default):"},{"line_number":43,"context_line":"        name_tuple \u003d (section, option)"},{"line_number":44,"context_line":"        cfg_names \u003d []"},{"line_number":45,"context_line":"        cfg_names.append(name_tuple)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2Fh0A%3D","line":42,"in_reply_to":"AAAATH%2F%2Fh44%3D","updated":"2013-10-14 23:12:21.000000000","message":"multiparser is from oslo.config only, we are using method \n\ndef get(self, names, multi\u003dFalse): \nfrom multiparser class in oslo.config. \n\nhttps://github.com/openstack/oslo.config/blob/master/oslo/config/cfg.py\n\n_read_cfg() function helps in consolidating multi_parser.get() call, instead of calling for 5/6 different section/options combination, we make one call to it within this function/method.\n\nwhat is a issue?","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"d541b27a8a67694350b454a2742a1935b3d376e8","unresolved":false,"context_lines":[{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def _read_cfg(multi_parser, section, option, default):"},{"line_number":43,"context_line":"        name_tuple \u003d (section, option)"},{"line_number":44,"context_line":"        cfg_names \u003d []"},{"line_number":45,"context_line":"        cfg_names.append(name_tuple)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2Fh44%3D","line":42,"in_reply_to":"AAAATH%2F%2Fh9w%3D","updated":"2013-10-14 22:43:18.000000000","message":"We should use oslo.config directly for coding style consistency.\nI don\u0027t think we need this function.","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"a4bd43763c61adba6a3aacb51fa6017a31f77751","unresolved":false,"context_lines":[{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def _read_cfg(multi_parser, section, option, default):"},{"line_number":43,"context_line":"        name_tuple \u003d (section, option)"},{"line_number":44,"context_line":"        cfg_names \u003d []"},{"line_number":45,"context_line":"        cfg_names.append(name_tuple)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2Fh9w%3D","line":42,"in_reply_to":"AAAATH%2F%2FiSo%3D","updated":"2013-10-14 22:18:08.000000000","message":"It is based on oslo.config. We have one common method _read_cfg(), which uses oslo.config to read different sections, options in config file and save it for later use.","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"9d12496a6b54b3de5349a3ea2938bbf792661c3a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def _read_cfg(multi_parser, section, option, default):"},{"line_number":43,"context_line":"        name_tuple \u003d (section, option)"},{"line_number":44,"context_line":"        cfg_names \u003d []"},{"line_number":45,"context_line":"        cfg_names.append(name_tuple)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FiSo%3D","line":42,"in_reply_to":"AAAATH%2F%2Fj%2BM%3D","updated":"2013-10-14 21:01:27.000000000","message":"IMO, how to deal the config should be consistent across the code.\nso we should use oslo.config way in openstack code.","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"0e9c47c0dffc00e9953c67b728cadb836db069d9","unresolved":false,"context_lines":[{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def _read_cfg(multi_parser, section, option, default):"},{"line_number":43,"context_line":"        name_tuple \u003d (section, option)"},{"line_number":44,"context_line":"        cfg_names \u003d []"},{"line_number":45,"context_line":"        cfg_names.append(name_tuple)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2Fj%2BM%3D","line":42,"in_reply_to":"AAAATH%2F%2FoxE%3D","updated":"2013-10-14 19:57:20.000000000","message":"I am using the same function but with multi_parser which is from olso.config. earlier one was with cfg_parser. I dont want to change code flow..","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"3987f40ace876847a20e33ca83f13c1d6ab32803","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    _tenant_id_dict \u003d {}"},{"line_number":65,"context_line":"    _tenant_name_dict \u003d {}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @classmethod"},{"line_number":68,"context_line":"    def _parse_class_args(cls, multi_parser):"},{"line_number":69,"context_line":"        read_ok \u003d multi_parser.read(cfg.CONF.config_file)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FoxM%3D","line":67,"updated":"2013-10-11 23:17:26.000000000","message":"In previous patch, you said you will use olso.config instead of this function..","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"0e9c47c0dffc00e9953c67b728cadb836db069d9","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    _tenant_id_dict \u003d {}"},{"line_number":65,"context_line":"    _tenant_name_dict \u003d {}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @classmethod"},{"line_number":68,"context_line":"    def _parse_class_args(cls, multi_parser):"},{"line_number":69,"context_line":"        read_ok \u003d multi_parser.read(cfg.CONF.config_file)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2Fj%2BI%3D","line":67,"in_reply_to":"AAAATH%2F%2FoxM%3D","updated":"2013-10-14 19:57:20.000000000","message":"same reply as above","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"3987f40ace876847a20e33ca83f13c1d6ab32803","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"            LOG.debug(_(\"create_network(): %r\"), net_dict)"},{"line_number":182,"context_line":"            return net_dict"},{"line_number":183,"context_line":"        except Exception as e:"},{"line_number":184,"context_line":"            LOG.exception(_(\"Unable to create network\"))"},{"line_number":185,"context_line":"            raise e"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FouE%3D","line":183,"updated":"2013-10-11 23:17:26.000000000","message":"This kind of exception handling is done.\nso we can remove all of it\nhttps://github.com/openstack/neutron/blob/master/neutron/api/v2/resource.py#L118","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"0e9c47c0dffc00e9953c67b728cadb836db069d9","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"            LOG.debug(_(\"create_network(): %r\"), net_dict)"},{"line_number":182,"context_line":"            return net_dict"},{"line_number":183,"context_line":"        except Exception as e:"},{"line_number":184,"context_line":"            LOG.exception(_(\"Unable to create network\"))"},{"line_number":185,"context_line":"            raise e"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FjIc%3D","line":183,"in_reply_to":"AAAATH%2F%2FouE%3D","updated":"2013-10-14 19:57:20.000000000","message":"Done","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"3987f40ace876847a20e33ca83f13c1d6ab32803","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            raise e"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def update_network(self, context, net_id, network):"},{"line_number":208,"context_line":"        \"\"\""},{"line_number":209,"context_line":"        Updates the attributes of a particular Virtual Network."},{"line_number":210,"context_line":"        \"\"\""},{"line_number":211,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2Fou8%3D","line":208,"updated":"2013-10-11 23:17:26.000000000","message":"Doc string is not fixed...\nhttps://github.com/openstack/neutron/blob/master/HACKING.rst\n\nSame for the other comments","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"0e9c47c0dffc00e9953c67b728cadb836db069d9","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            raise e"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def update_network(self, context, net_id, network):"},{"line_number":208,"context_line":"        \"\"\""},{"line_number":209,"context_line":"        Updates the attributes of a particular Virtual Network."},{"line_number":210,"context_line":"        \"\"\""},{"line_number":211,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FjIU%3D","line":208,"in_reply_to":"AAAATH%2F%2Fou8%3D","updated":"2013-10-14 19:57:20.000000000","message":"Done","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"3987f40ace876847a20e33ca83f13c1d6ab32803","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            cfgdb \u003d self._get_user_cfgdb(context)"},{"line_number":213,"context_line":"            net_info \u003d cfgdb.network_update(net_id, network[\u0027network\u0027])"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"            # verify transformation is conforming to api"},{"line_number":216,"context_line":"            net_dict \u003d self._make_network_dict(net_info[\u0027q_api_data\u0027],"},{"line_number":217,"context_line":"                                               None, False)"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FovQ%3D","line":215,"updated":"2013-10-11 23:17:26.000000000","message":"confirming?","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"0e9c47c0dffc00e9953c67b728cadb836db069d9","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            cfgdb \u003d self._get_user_cfgdb(context)"},{"line_number":213,"context_line":"            net_info \u003d cfgdb.network_update(net_id, network[\u0027network\u0027])"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"            # verify transformation is conforming to api"},{"line_number":216,"context_line":"            net_dict \u003d self._make_network_dict(net_info[\u0027q_api_data\u0027],"},{"line_number":217,"context_line":"                                               None, False)"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FjIY%3D","line":215,"in_reply_to":"AAAATH%2F%2FovQ%3D","updated":"2013-10-14 19:57:20.000000000","message":"Done","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# @author: Hampapur Ajay, Rudra Rugge, Atul Moghe Juniper Networks."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from httplib2 import Http"},{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":"from pprint import pformat"},{"line_number":22,"context_line":"import re"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeFI%3D","line":19,"updated":"2013-10-15 19:27:44.000000000","message":"We should do package level import\nso \nplease do just import httplib2 here","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# @author: Hampapur Ajay, Rudra Rugge, Atul Moghe Juniper Networks."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from httplib2 import Http"},{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":"from pprint import pformat"},{"line_number":22,"context_line":"import re"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh70%3D","line":19,"in_reply_to":"AAAATH%2F%2FeFI%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from pprint import pformat"},{"line_number":22,"context_line":"import re"},{"line_number":23,"context_line":"import string"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import ctdb.config_db"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from neutron.common import exceptions as exc"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeFE%3D","line":24,"updated":"2013-10-15 19:27:44.000000000","message":"blank line is not needed","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from pprint import pformat"},{"line_number":22,"context_line":"import re"},{"line_number":23,"context_line":"import string"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import ctdb.config_db"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from neutron.common import exceptions as exc"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh7w%3D","line":24,"in_reply_to":"AAAATH%2F%2FeFE%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    # Network API handlers"},{"line_number":172,"context_line":"    def create_network(self, context, network):"},{"line_number":173,"context_line":"        \"\"\""},{"line_number":174,"context_line":"        Creates a new Virtual Network, and assigns it"},{"line_number":175,"context_line":"        a symbolic name."},{"line_number":176,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeHQ%3D","line":173,"updated":"2013-10-15 19:27:44.000000000","message":"hacking.rst","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    # Network API handlers"},{"line_number":172,"context_line":"    def create_network(self, context, network):"},{"line_number":173,"context_line":"        \"\"\""},{"line_number":174,"context_line":"        Creates a new Virtual Network, and assigns it"},{"line_number":175,"context_line":"        a symbolic name."},{"line_number":176,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh7s%3D","line":173,"in_reply_to":"AAAATH%2F%2FeHQ%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        return net_dict"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def delete_network(self, context, net_id):"},{"line_number":220,"context_line":"        \"\"\"Network delete operation."},{"line_number":221,"context_line":"        Deletes the network with the specified network identifier"},{"line_number":222,"context_line":"        belonging to the specified tenant."},{"line_number":223,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeHM%3D","line":220,"updated":"2013-10-15 19:27:44.000000000","message":"line needed","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        return net_dict"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def delete_network(self, context, net_id):"},{"line_number":220,"context_line":"        \"\"\"Network delete operation."},{"line_number":221,"context_line":"        Deletes the network with the specified network identifier"},{"line_number":222,"context_line":"        belonging to the specified tenant."},{"line_number":223,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh7o%3D","line":220,"in_reply_to":"AAAATH%2F%2FeHM%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":239,"context_line":"            nets_dicts.append(n_dict)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        LOG.debug("},{"line_number":242,"context_line":"            \"get_networks(): filters: \" + pformat(filters) + \" data: \""},{"line_number":243,"context_line":"            + pformat(nets_dicts))"},{"line_number":244,"context_line":"        return nets_dicts"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeEs%3D","line":242,"updated":"2013-10-15 19:27:44.000000000","message":"Instead of format, please use  \"%r\" : obj","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":239,"context_line":"            nets_dicts.append(n_dict)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        LOG.debug("},{"line_number":242,"context_line":"            \"get_networks(): filters: \" + pformat(filters) + \" data: \""},{"line_number":243,"context_line":"            + pformat(nets_dicts))"},{"line_number":244,"context_line":"        return nets_dicts"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh7k%3D","line":242,"in_reply_to":"AAAATH%2F%2FeEs%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        LOG.debug(_(\"get_networks_count(): %r\"), str(nets_count))"},{"line_number":250,"context_line":"        return nets_count"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    # Subnet API handlers"},{"line_number":253,"context_line":"    def create_subnet(self, context, subnet):"},{"line_number":254,"context_line":"        cfgdb \u003d self._get_user_cfgdb(context)"},{"line_number":255,"context_line":"        subnet_info \u003d cfgdb.subnet_create(subnet[\u0027subnet\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeHE%3D","line":252,"updated":"2013-10-15 19:27:44.000000000","message":"This should be doc string","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        LOG.debug(_(\"get_networks_count(): %r\"), str(nets_count))"},{"line_number":250,"context_line":"        return nets_count"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    # Subnet API handlers"},{"line_number":253,"context_line":"    def create_subnet(self, context, subnet):"},{"line_number":254,"context_line":"        cfgdb \u003d self._get_user_cfgdb(context)"},{"line_number":255,"context_line":"        subnet_info \u003d cfgdb.subnet_create(subnet[\u0027subnet\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh7g%3D","line":252,"in_reply_to":"AAAATH%2F%2FeHE%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        LOG.debug(_(\"get_subnets_count(): %r\"), str(subnets_count))"},{"line_number":318,"context_line":"        return subnets_count"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    # Ipam API handlers"},{"line_number":321,"context_line":"    def create_ipam(self, context, ipam):"},{"line_number":322,"context_line":"        \"\"\"Create ipam operation."},{"line_number":323,"context_line":"        Creates a new IPAM, and assigns it a symbolic name."}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeG8%3D","line":320,"updated":"2013-10-15 19:27:44.000000000","message":"This should be in doc string","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        LOG.debug(_(\"get_subnets_count(): %r\"), str(subnets_count))"},{"line_number":318,"context_line":"        return subnets_count"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    # Ipam API handlers"},{"line_number":321,"context_line":"    def create_ipam(self, context, ipam):"},{"line_number":322,"context_line":"        \"\"\"Create ipam operation."},{"line_number":323,"context_line":"        Creates a new IPAM, and assigns it a symbolic name."}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh7c%3D","line":320,"in_reply_to":"AAAATH%2F%2FeG8%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    # Ipam API handlers"},{"line_number":321,"context_line":"    def create_ipam(self, context, ipam):"},{"line_number":322,"context_line":"        \"\"\"Create ipam operation."},{"line_number":323,"context_line":"        Creates a new IPAM, and assigns it a symbolic name."},{"line_number":324,"context_line":"        \"\"\""},{"line_number":325,"context_line":"        cfgdb \u003d self._get_user_cfgdb(context)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeHA%3D","line":322,"updated":"2013-10-15 19:27:44.000000000","message":"blank line need","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    # Ipam API handlers"},{"line_number":321,"context_line":"    def create_ipam(self, context, ipam):"},{"line_number":322,"context_line":"        \"\"\"Create ipam operation."},{"line_number":323,"context_line":"        Creates a new IPAM, and assigns it a symbolic name."},{"line_number":324,"context_line":"        \"\"\""},{"line_number":325,"context_line":"        cfgdb \u003d self._get_user_cfgdb(context)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh7Y%3D","line":322,"in_reply_to":"AAAATH%2F%2FeHA%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        LOG.debug(_(\"get_ipams_count(): %r\"), str(ipams_count))"},{"line_number":383,"context_line":"        return ipams_count"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    # Policy API handlers"},{"line_number":386,"context_line":"    def create_policy(self, context, policy):"},{"line_number":387,"context_line":"        \"\"\"Creates a new Policy, and assigns it a symbolic name.\"\"\""},{"line_number":388,"context_line":"        cfgdb \u003d self._get_user_cfgdb(context)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeG0%3D","line":385,"updated":"2013-10-15 19:27:44.000000000","message":"This line should be in doc string","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        LOG.debug(_(\"get_ipams_count(): %r\"), str(ipams_count))"},{"line_number":383,"context_line":"        return ipams_count"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    # Policy API handlers"},{"line_number":386,"context_line":"    def create_policy(self, context, policy):"},{"line_number":387,"context_line":"        \"\"\"Creates a new Policy, and assigns it a symbolic name.\"\"\""},{"line_number":388,"context_line":"        cfgdb \u003d self._get_user_cfgdb(context)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh7U%3D","line":385,"in_reply_to":"AAAATH%2F%2FeG0%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        cfgdb \u003d self._get_user_cfgdb(context)"},{"line_number":389,"context_line":"        policy_info \u003d cfgdb.policy_create(policy[\u0027policy\u0027])"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"        # verify transformation is conforming to api"},{"line_number":392,"context_line":"        policy_dict \u003d policy_info[\u0027q_api_data\u0027]"},{"line_number":393,"context_line":"        policy_dict.update(policy_info[\u0027q_extra_data\u0027])"},{"line_number":394,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeGw%3D","line":391,"updated":"2013-10-15 19:27:44.000000000","message":"This comment is really needed? #This review will be applied for the other part.","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        cfgdb \u003d self._get_user_cfgdb(context)"},{"line_number":389,"context_line":"        policy_info \u003d cfgdb.policy_create(policy[\u0027policy\u0027])"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"        # verify transformation is conforming to api"},{"line_number":392,"context_line":"        policy_dict \u003d policy_info[\u0027q_api_data\u0027]"},{"line_number":393,"context_line":"        policy_dict.update(policy_info[\u0027q_extra_data\u0027])"},{"line_number":394,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh7Q%3D","line":391,"in_reply_to":"AAAATH%2F%2FeGw%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    def get_policys(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":429,"context_line":"        cfgdb \u003d self._get_user_cfgdb(context)"},{"line_number":430,"context_line":"        policys_info \u003d cfgdb.policy_list(filters)"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        policys_dicts \u003d []"},{"line_number":433,"context_line":"        for policy_info in policys_info:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeGk%3D","line":430,"updated":"2013-10-15 19:27:44.000000000","message":"policies ?","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    def get_policys(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":429,"context_line":"        cfgdb \u003d self._get_user_cfgdb(context)"},{"line_number":430,"context_line":"        policys_info \u003d cfgdb.policy_list(filters)"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        policys_dicts \u003d []"},{"line_number":433,"context_line":"        for policy_info in policys_info:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh7M%3D","line":430,"in_reply_to":"AAAATH%2F%2FeGk%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":445,"context_line":"        LOG.debug(_(\"get_policy_count(): %r\"), str(policy_count))"},{"line_number":446,"context_line":"        return policy_count"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    # Floating IP API handlers"},{"line_number":449,"context_line":"    def _make_floatingip_dict(self, floatingip, fields\u003dNone):"},{"line_number":450,"context_line":"        res \u003d {\u0027id\u0027: floatingip[\u0027id\u0027],"},{"line_number":451,"context_line":"               \u0027tenant_id\u0027: floatingip[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeGc%3D","line":448,"updated":"2013-10-15 19:27:44.000000000","message":"In doc string","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":445,"context_line":"        LOG.debug(_(\"get_policy_count(): %r\"), str(policy_count))"},{"line_number":446,"context_line":"        return policy_count"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    # Floating IP API handlers"},{"line_number":449,"context_line":"    def _make_floatingip_dict(self, floatingip, fields\u003dNone):"},{"line_number":450,"context_line":"        res \u003d {\u0027id\u0027: floatingip[\u0027id\u0027],"},{"line_number":451,"context_line":"               \u0027tenant_id\u0027: floatingip[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh7I%3D","line":448,"in_reply_to":"AAAATH%2F%2FeGc%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        LOG.debug(_(\"get_floatingips_count(): %r\"), str(floatingips_count))"},{"line_number":520,"context_line":"        return floatingips_count"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    # Port API handlers"},{"line_number":523,"context_line":"    def create_port(self, context, port):"},{"line_number":524,"context_line":"        \"\"\"Creates a port on the specified Virtual Network.\"\"\""},{"line_number":525,"context_line":"        cfgdb \u003d self._get_user_cfgdb(context)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeGU%3D","line":522,"updated":"2013-10-15 19:27:44.000000000","message":"In doc string","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        LOG.debug(_(\"get_floatingips_count(): %r\"), str(floatingips_count))"},{"line_number":520,"context_line":"        return floatingips_count"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    # Port API handlers"},{"line_number":523,"context_line":"    def create_port(self, context, port):"},{"line_number":524,"context_line":"        \"\"\"Creates a port on the specified Virtual Network.\"\"\""},{"line_number":525,"context_line":"        cfgdb \u003d self._get_user_cfgdb(context)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh7E%3D","line":522,"in_reply_to":"AAAATH%2F%2FeGU%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":546,"context_line":"        return self._fields(port_dict, fields)"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    def update_port(self, context, port_id, port):"},{"line_number":549,"context_line":"        \"\"\"Port update on a virtual network."},{"line_number":550,"context_line":"        Updates the attributes of a port on the specified Virtual Network."},{"line_number":551,"context_line":"        \"\"\""},{"line_number":552,"context_line":"        cfgdb \u003d self._get_user_cfgdb(context)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeGQ%3D","line":549,"updated":"2013-10-15 19:27:44.000000000","message":"blank line","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":546,"context_line":"        return self._fields(port_dict, fields)"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    def update_port(self, context, port_id, port):"},{"line_number":549,"context_line":"        \"\"\"Port update on a virtual network."},{"line_number":550,"context_line":"        Updates the attributes of a port on the specified Virtual Network."},{"line_number":551,"context_line":"        \"\"\""},{"line_number":552,"context_line":"        cfgdb \u003d self._get_user_cfgdb(context)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh7A%3D","line":549,"in_reply_to":"AAAATH%2F%2FeGQ%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":561,"context_line":"        return port_dict"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    def delete_port(self, context, port_id):"},{"line_number":564,"context_line":"        \"\"\"port delete on a virtual network."},{"line_number":565,"context_line":"        Deletes a port on a specified Virtual Network,"},{"line_number":566,"context_line":"        if the port contains a remote interface attachment,"},{"line_number":567,"context_line":"        the remote interface is first un-plugged and then the port"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeGI%3D","line":564,"updated":"2013-10-15 19:27:44.000000000","message":"blank line","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":561,"context_line":"        return port_dict"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    def delete_port(self, context, port_id):"},{"line_number":564,"context_line":"        \"\"\"port delete on a virtual network."},{"line_number":565,"context_line":"        Deletes a port on a specified Virtual Network,"},{"line_number":566,"context_line":"        if the port contains a remote interface attachment,"},{"line_number":567,"context_line":"        the remote interface is first un-plugged and then the port"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh68%3D","line":564,"in_reply_to":"AAAATH%2F%2FeGI%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":572,"context_line":"        LOG.debug(_(\"delete_port(): %r\"), port_id)"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"    def get_ports(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":575,"context_line":"        \"\"\""},{"line_number":576,"context_line":"        Retrieves all port identifiers belonging to the"},{"line_number":577,"context_line":"        specified Virtual Network."},{"line_number":578,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeGA%3D","line":575,"updated":"2013-10-15 19:27:44.000000000","message":"hacking.rst","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":572,"context_line":"        LOG.debug(_(\"delete_port(): %r\"), port_id)"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"    def get_ports(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":575,"context_line":"        \"\"\""},{"line_number":576,"context_line":"        Retrieves all port identifiers belonging to the"},{"line_number":577,"context_line":"        specified Virtual Network."},{"line_number":578,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh64%3D","line":575,"in_reply_to":"AAAATH%2F%2FeGA%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":599,"context_line":"        return ports_count"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"    def plug_interface(self, tenant_id, net_id, port_id, remote_interface_id):"},{"line_number":602,"context_line":"        \"\"\""},{"line_number":603,"context_line":"        Attaches a remote interface to the specified port on the"},{"line_number":604,"context_line":"        specified Virtual Network."},{"line_number":605,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeF0%3D","line":602,"updated":"2013-10-15 19:27:44.000000000","message":"hacking.rst","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":599,"context_line":"        return ports_count"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"    def plug_interface(self, tenant_id, net_id, port_id, remote_interface_id):"},{"line_number":602,"context_line":"        \"\"\""},{"line_number":603,"context_line":"        Attaches a remote interface to the specified port on the"},{"line_number":604,"context_line":"        specified Virtual Network."},{"line_number":605,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh60%3D","line":602,"in_reply_to":"AAAATH%2F%2FeF0%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":613,"context_line":""},{"line_number":614,"context_line":"    def unplug_interface(self, tenant_id, net_id, port_id):"},{"line_number":615,"context_line":"        \"\"\""},{"line_number":616,"context_line":"        Detaches a remote interface from the specified port on the"},{"line_number":617,"context_line":"        specified Virtual Network."},{"line_number":618,"context_line":"        \"\"\""},{"line_number":619,"context_line":"        self._get_port(tenant_id, net_id, port_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeFs%3D","line":616,"updated":"2013-10-15 19:27:44.000000000","message":"hacking.rst","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":613,"context_line":""},{"line_number":614,"context_line":"    def unplug_interface(self, tenant_id, net_id, port_id):"},{"line_number":615,"context_line":"        \"\"\""},{"line_number":616,"context_line":"        Detaches a remote interface from the specified port on the"},{"line_number":617,"context_line":"        specified Virtual Network."},{"line_number":618,"context_line":"        \"\"\""},{"line_number":619,"context_line":"        self._get_port(tenant_id, net_id, port_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh6w%3D","line":616,"in_reply_to":"AAAATH%2F%2FeFs%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"f473f316e156b5f9a91d48264fb357f1809b68e3","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            cls._cfgdb.manager \u003d cls"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @classmethod"},{"line_number":111,"context_line":"    def _get_user_cfgdb(cls, context):"},{"line_number":112,"context_line":"        if not cls._multi_tenancy:"},{"line_number":113,"context_line":"            return cls._cfgdb"},{"line_number":114,"context_line":"        user_id \u003d context.user_id"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2FhBs%3D","line":111,"updated":"2013-11-03 05:10:39.000000000","message":"If I understand this function properly, it basically creates an object to the DB but I dont see roll back operation is something goes wrong.\nDid you try to follow the same approach than other plugins does in terms of DB operations?\nDo you have anything against that kind of implementation?\nFor instance:\nOVS, BrigSwitch, PLUMgrid plugins","commit_id":"39751d2c3eef4855695832e80d4565a701548ae1"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"86412f1a469d7f4aa0b0ae7c0c57e1f8c238cabb","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            cls._cfgdb.manager \u003d cls"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @classmethod"},{"line_number":111,"context_line":"    def _get_user_cfgdb(cls, context):"},{"line_number":112,"context_line":"        if not cls._multi_tenancy:"},{"line_number":113,"context_line":"            return cls._cfgdb"},{"line_number":114,"context_line":"        user_id \u003d context.user_id"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2FfWc%3D","line":111,"in_reply_to":"AAAATn%2F%2FhBs%3D","updated":"2013-11-04 18:51:14.000000000","message":"This function caches connection handles to the VNC API server keyed by user(across different projects). If there is an error in establishing connection to the API server, there is no state created and hence no rollback needed.","commit_id":"39751d2c3eef4855695832e80d4565a701548ae1"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"d4764e6da5d87962786841bfa96d482cf966ea36","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 Juniper Networks.  All rights reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUH%2F9qd4%3D","line":3,"updated":"2014-02-05 08:38:58.000000000","message":"wrong year!","commit_id":"d0a6fc6b3277166d726e8fe332e1b7dbc3586522"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"86156603e1097114af7a258f378c53770cbb0b2e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 Juniper Networks.  All rights reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUH%2F9mnY%3D","line":3,"in_reply_to":"AAAAUH%2F9qd4%3D","updated":"2014-02-05 18:49:20.000000000","message":"Done","commit_id":"d0a6fc6b3277166d726e8fe332e1b7dbc3586522"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"d4764e6da5d87962786841bfa96d482cf966ea36","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"vnc_opts \u003d ["},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027api_server_ip\u0027, default\u003d\u0027127.0.0.1\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027api_server_port\u0027, default\u003d\u00278082\u0027),"},{"line_number":38,"context_line":"]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUH%2F9qcc%3D","line":37,"updated":"2014-02-05 08:38:58.000000000","message":"Would suggest to incorporate the help parameter here:\ncfg.StrOpt(\u0027api_server_port\u0027, default\u003d\u00278082\u0027, help\u003d_(bla bla bla..))","commit_id":"d0a6fc6b3277166d726e8fe332e1b7dbc3586522"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"86156603e1097114af7a258f378c53770cbb0b2e","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"vnc_opts \u003d ["},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027api_server_ip\u0027, default\u003d\u0027127.0.0.1\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027api_server_port\u0027, default\u003d\u00278082\u0027),"},{"line_number":38,"context_line":"]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUH%2F9mm0%3D","line":37,"in_reply_to":"AAAAUH%2F9qcc%3D","updated":"2014-02-05 18:49:20.000000000","message":"Done","commit_id":"d0a6fc6b3277166d726e8fe332e1b7dbc3586522"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"d4764e6da5d87962786841bfa96d482cf966ea36","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                     l3.RouterPluginBase,"},{"line_number":60,"context_line":"                     securitygroup.SecurityGroupPluginBase):"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # only floatingip part of router extension is supported."},{"line_number":63,"context_line":"    supported_extension_aliases \u003d [\"security-group\", \"port-security\"]"},{"line_number":64,"context_line":"    __native_bulk_support \u003d False"},{"line_number":65,"context_line":"    _cfgdb \u003d None"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUH%2F9qdU%3D","line":62,"updated":"2014-02-05 08:38:58.000000000","message":"Is this correct?\nI will assume that at least you need to implement the port binding extension.","commit_id":"d0a6fc6b3277166d726e8fe332e1b7dbc3586522"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"86156603e1097114af7a258f378c53770cbb0b2e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                     l3.RouterPluginBase,"},{"line_number":60,"context_line":"                     securitygroup.SecurityGroupPluginBase):"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # only floatingip part of router extension is supported."},{"line_number":63,"context_line":"    supported_extension_aliases \u003d [\"security-group\", \"port-security\"]"},{"line_number":64,"context_line":"    __native_bulk_support \u003d False"},{"line_number":65,"context_line":"    _cfgdb \u003d None"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUH%2F9moU%3D","line":62,"in_reply_to":"AAAAUH%2F9qdU%3D","updated":"2014-02-05 18:49:20.000000000","message":"We don\u0027t need to implement the port-binding extension","commit_id":"d0a6fc6b3277166d726e8fe332e1b7dbc3586522"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"d4764e6da5d87962786841bfa96d482cf966ea36","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        ContrailPlugin._tenant_list_from_keystone()"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    # Network API handlers"},{"line_number":176,"context_line":"    def create_network(self, context, network):"},{"line_number":177,"context_line":"        \"\"\"Creates a new Virtual Network, and assigns it a symbolic name.\"\"\""},{"line_number":178,"context_line":"        cfgdb \u003d self._get_user_cfgdb(context)"},{"line_number":179,"context_line":"        net_info \u003d cfgdb.network_create(network[\u0027network\u0027])"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUH%2F9qcA%3D","line":176,"updated":"2014-02-05 08:38:58.000000000","message":"no back-end operation?","commit_id":"d0a6fc6b3277166d726e8fe332e1b7dbc3586522"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"86156603e1097114af7a258f378c53770cbb0b2e","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        ContrailPlugin._tenant_list_from_keystone()"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    # Network API handlers"},{"line_number":176,"context_line":"    def create_network(self, context, network):"},{"line_number":177,"context_line":"        \"\"\"Creates a new Virtual Network, and assigns it a symbolic name.\"\"\""},{"line_number":178,"context_line":"        cfgdb \u003d self._get_user_cfgdb(context)"},{"line_number":179,"context_line":"        net_info \u003d cfgdb.network_create(network[\u0027network\u0027])"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUH%2F9mn4%3D","line":176,"in_reply_to":"AAAAUH%2F9qcA%3D","updated":"2014-02-05 18:49:20.000000000","message":"There is a backend operation in ctdb/config_db.py","commit_id":"d0a6fc6b3277166d726e8fe332e1b7dbc3586522"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"d4764e6da5d87962786841bfa96d482cf966ea36","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    def create_network(self, context, network):"},{"line_number":177,"context_line":"        \"\"\"Creates a new Virtual Network, and assigns it a symbolic name.\"\"\""},{"line_number":178,"context_line":"        cfgdb \u003d self._get_user_cfgdb(context)"},{"line_number":179,"context_line":"        net_info \u003d cfgdb.network_create(network[\u0027network\u0027])"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        # verify transformation is conforming to api"},{"line_number":182,"context_line":"        net_dict \u003d self._make_network_dict(net_info[\u0027q_api_data\u0027],"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUH%2F9qcE%3D","line":179,"updated":"2014-02-05 08:38:58.000000000","message":"I do not see any back-end operation call here, is this correct? some details about how this plugin work will help developers to make a better review.. adding a wiki page will help.","commit_id":"d0a6fc6b3277166d726e8fe332e1b7dbc3586522"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"86156603e1097114af7a258f378c53770cbb0b2e","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    def create_network(self, context, network):"},{"line_number":177,"context_line":"        \"\"\"Creates a new Virtual Network, and assigns it a symbolic name.\"\"\""},{"line_number":178,"context_line":"        cfgdb \u003d self._get_user_cfgdb(context)"},{"line_number":179,"context_line":"        net_info \u003d cfgdb.network_create(network[\u0027network\u0027])"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        # verify transformation is conforming to api"},{"line_number":182,"context_line":"        net_dict \u003d self._make_network_dict(net_info[\u0027q_api_data\u0027],"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUH%2F9mno%3D","line":179,"in_reply_to":"AAAAUH%2F9qcE%3D","updated":"2014-02-05 18:49:20.000000000","message":"There is a backend operation in ctdb/config_db.py","commit_id":"d0a6fc6b3277166d726e8fe332e1b7dbc3586522"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"643fff30b5e640c943a9279e1882e10608c59484","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import httplib2"},{"line_number":21,"context_line":"from oslo.config import cfg"},{"line_number":22,"context_line":"import re"},{"line_number":23,"context_line":"import string"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from neutron.common import constants"},{"line_number":26,"context_line":"from neutron.common import exceptions as exc"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FYsk%3D","line":23,"updated":"2014-02-13 15:47:00.000000000","message":"Please split standard and third-party modules according to OpenStack HACKING.rst.","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"574f6e2a84875198bb6eb32fd95bf5c626727b56","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import httplib2"},{"line_number":21,"context_line":"from oslo.config import cfg"},{"line_number":22,"context_line":"import re"},{"line_number":23,"context_line":"import string"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from neutron.common import constants"},{"line_number":26,"context_line":"from neutron.common import exceptions as exc"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FWKs%3D","line":23,"in_reply_to":"AAAAUX%2F%2FYsk%3D","updated":"2014-02-14 00:42:48.000000000","message":"Done","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"643fff30b5e640c943a9279e1882e10608c59484","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                     l3.RouterPluginBase,"},{"line_number":62,"context_line":"                     securitygroup.SecurityGroupPluginBase):"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    # only floatingip part of router extension is supported."},{"line_number":65,"context_line":"    supported_extension_aliases \u003d [\"security-group\", \"port-security\"]"},{"line_number":66,"context_line":"    __native_bulk_support \u003d False"},{"line_number":67,"context_line":"    _cfgdb \u003d None"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FYnc%3D","line":64,"updated":"2014-02-13 15:47:00.000000000","message":"It seems ContrailPlugin supports router extension. RouterPluginBase is inherited above.\nDon\u0027t we need \u0027router\u0027 and \u0027external-net\u0027 in supported_extension_alias?","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"574f6e2a84875198bb6eb32fd95bf5c626727b56","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                     l3.RouterPluginBase,"},{"line_number":62,"context_line":"                     securitygroup.SecurityGroupPluginBase):"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    # only floatingip part of router extension is supported."},{"line_number":65,"context_line":"    supported_extension_aliases \u003d [\"security-group\", \"port-security\"]"},{"line_number":66,"context_line":"    __native_bulk_support \u003d False"},{"line_number":67,"context_line":"    _cfgdb \u003d None"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FWL8%3D","line":64,"in_reply_to":"AAAAUX%2F%2FYnc%3D","updated":"2014-02-14 00:42:48.000000000","message":"Done","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"643fff30b5e640c943a9279e1882e10608c59484","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @classmethod"},{"line_number":73,"context_line":"    def _parse_class_args(cls, multi_parser):"},{"line_number":74,"context_line":"        read_ok \u003d multi_parser.read(cfg.CONF.config_file)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        if len(read_ok) !\u003d len(cfg.CONF.config_file):"},{"line_number":77,"context_line":"            raise cfg.Error(\"Some config files were not parsed properly\")"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FYqw%3D","line":74,"updated":"2014-02-13 15:47:00.000000000","message":"Why do you need to use a different parser from oslo.config?","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"574f6e2a84875198bb6eb32fd95bf5c626727b56","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @classmethod"},{"line_number":73,"context_line":"    def _parse_class_args(cls, multi_parser):"},{"line_number":74,"context_line":"        read_ok \u003d multi_parser.read(cfg.CONF.config_file)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        if len(read_ok) !\u003d len(cfg.CONF.config_file):"},{"line_number":77,"context_line":"            raise cfg.Error(\"Some config files were not parsed properly\")"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FWL4%3D","line":74,"in_reply_to":"AAAAUX%2F%2FYqw%3D","updated":"2014-02-14 00:42:48.000000000","message":"Done","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"643fff30b5e640c943a9279e1882e10608c59484","unresolved":false,"context_lines":[{"line_number":636,"context_line":""},{"line_number":637,"context_line":"        # verify transformation is conforming to api"},{"line_number":638,"context_line":"        sgr_dict \u003d {}"},{"line_number":639,"context_line":"        if sgr_info !\u003d {}:"},{"line_number":640,"context_line":"            sgr_dict \u003d self._make_security_group_rule_dict("},{"line_number":641,"context_line":"                sgr_info[\u0027q_api_data\u0027], fields)"},{"line_number":642,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FYpA%3D","line":639,"updated":"2014-02-13 15:47:00.000000000","message":"Consider:\n\n  if sgr_info:","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"574f6e2a84875198bb6eb32fd95bf5c626727b56","unresolved":false,"context_lines":[{"line_number":636,"context_line":""},{"line_number":637,"context_line":"        # verify transformation is conforming to api"},{"line_number":638,"context_line":"        sgr_dict \u003d {}"},{"line_number":639,"context_line":"        if sgr_info !\u003d {}:"},{"line_number":640,"context_line":"            sgr_dict \u003d self._make_security_group_rule_dict("},{"line_number":641,"context_line":"                sgr_info[\u0027q_api_data\u0027], fields)"},{"line_number":642,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FWK0%3D","line":639,"in_reply_to":"AAAAUX%2F%2FYpA%3D","updated":"2014-02-14 00:42:48.000000000","message":"Done","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"55180b641b221b51f3a0a71baeecd755e8855c04","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                     securitygroup.SecurityGroupPluginBase):"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # only floatingip part of router extension is supported."},{"line_number":83,"context_line":"    supported_extension_aliases \u003d [\"security-group\", \"port-security\"]"},{"line_number":84,"context_line":"    __native_bulk_support \u003d False"},{"line_number":85,"context_line":"    _cfgdb \u003d None"},{"line_number":86,"context_line":"    _args \u003d None"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2BroE%3D","line":83,"updated":"2014-02-19 20:41:52.000000000","message":"We should add router here even if it isn\u0027t fully supported","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"346d601cf47e2cb655ee6f4d6da3f7ac6347804a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                     securitygroup.SecurityGroupPluginBase):"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # only floatingip part of router extension is supported."},{"line_number":83,"context_line":"    supported_extension_aliases \u003d [\"security-group\", \"port-security\"]"},{"line_number":84,"context_line":"    __native_bulk_support \u003d False"},{"line_number":85,"context_line":"    _cfgdb \u003d None"},{"line_number":86,"context_line":"    _args \u003d None"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2Bgn0%3D","line":83,"in_reply_to":"AAAAUX%2F%2BroE%3D","updated":"2014-02-20 19:58:53.000000000","message":"We will have a new independent review for router extension support. Not supported in this patch.","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"55180b641b221b51f3a0a71baeecd755e8855c04","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        \"\"\""},{"line_number":111,"context_line":"        cls._cfgdb_map \u003d {}"},{"line_number":112,"context_line":"        if cls._cfgdb is None:"},{"line_number":113,"context_line":"            sip \u003d cfg.CONF.APISERVER.api_server_ip"},{"line_number":114,"context_line":"            sport \u003d cfg.CONF.APISERVER.api_server_port"},{"line_number":115,"context_line":"            # Initialize connection to DB and add default entries"},{"line_number":116,"context_line":"            cls._cfgdb \u003d ctdb.config_db.DBInterface(cls._admin_user,"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2BrlY%3D","line":113,"updated":"2014-02-19 20:41:52.000000000","message":"nit: sip isn\u0027t needed","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"346d601cf47e2cb655ee6f4d6da3f7ac6347804a","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        \"\"\""},{"line_number":111,"context_line":"        cls._cfgdb_map \u003d {}"},{"line_number":112,"context_line":"        if cls._cfgdb is None:"},{"line_number":113,"context_line":"            sip \u003d cfg.CONF.APISERVER.api_server_ip"},{"line_number":114,"context_line":"            sport \u003d cfg.CONF.APISERVER.api_server_port"},{"line_number":115,"context_line":"            # Initialize connection to DB and add default entries"},{"line_number":116,"context_line":"            cls._cfgdb \u003d ctdb.config_db.DBInterface(cls._admin_user,"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2Bgew%3D","line":113,"in_reply_to":"AAAAUX%2F%2BrlY%3D","updated":"2014-02-20 19:58:53.000000000","message":"Done","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"55180b641b221b51f3a0a71baeecd755e8855c04","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        cls._cfgdb_map \u003d {}"},{"line_number":112,"context_line":"        if cls._cfgdb is None:"},{"line_number":113,"context_line":"            sip \u003d cfg.CONF.APISERVER.api_server_ip"},{"line_number":114,"context_line":"            sport \u003d cfg.CONF.APISERVER.api_server_port"},{"line_number":115,"context_line":"            # Initialize connection to DB and add default entries"},{"line_number":116,"context_line":"            cls._cfgdb \u003d ctdb.config_db.DBInterface(cls._admin_user,"},{"line_number":117,"context_line":"                                                    cls._admin_password,"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2BrlU%3D","line":114,"updated":"2014-02-19 20:41:52.000000000","message":"nit: sport isnt\u0027 needed","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"346d601cf47e2cb655ee6f4d6da3f7ac6347804a","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        cls._cfgdb_map \u003d {}"},{"line_number":112,"context_line":"        if cls._cfgdb is None:"},{"line_number":113,"context_line":"            sip \u003d cfg.CONF.APISERVER.api_server_ip"},{"line_number":114,"context_line":"            sport \u003d cfg.CONF.APISERVER.api_server_port"},{"line_number":115,"context_line":"            # Initialize connection to DB and add default entries"},{"line_number":116,"context_line":"            cls._cfgdb \u003d ctdb.config_db.DBInterface(cls._admin_user,"},{"line_number":117,"context_line":"                                                    cls._admin_password,"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2Bgeo%3D","line":114,"in_reply_to":"AAAAUX%2F%2BrlU%3D","updated":"2014-02-20 19:58:53.000000000","message":"Done","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"55180b641b221b51f3a0a71baeecd755e8855c04","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    @classmethod"},{"line_number":142,"context_line":"    def _tenant_list_from_keystone(cls):"},{"line_number":143,"context_line":"        # get all tenants"},{"line_number":144,"context_line":"        hdrs \u003d {\u0027X-Auth-Token\u0027: cls._admin_token,"},{"line_number":145,"context_line":"                \u0027Content-Type\u0027: \u0027application/json\u0027}"},{"line_number":146,"context_line":"        try:"},{"line_number":147,"context_line":"            rsp, content \u003d httplib2.Http().request(cls._tenants_api,"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2Brj4%3D","line":144,"updated":"2014-02-19 20:41:52.000000000","message":"nit: headers","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"346d601cf47e2cb655ee6f4d6da3f7ac6347804a","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    @classmethod"},{"line_number":142,"context_line":"    def _tenant_list_from_keystone(cls):"},{"line_number":143,"context_line":"        # get all tenants"},{"line_number":144,"context_line":"        hdrs \u003d {\u0027X-Auth-Token\u0027: cls._admin_token,"},{"line_number":145,"context_line":"                \u0027Content-Type\u0027: \u0027application/json\u0027}"},{"line_number":146,"context_line":"        try:"},{"line_number":147,"context_line":"            rsp, content \u003d httplib2.Http().request(cls._tenants_api,"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2Bgek%3D","line":144,"in_reply_to":"AAAAUX%2F%2Brj4%3D","updated":"2014-02-20 19:58:53.000000000","message":"Done","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"55180b641b221b51f3a0a71baeecd755e8855c04","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        hdrs \u003d {\u0027X-Auth-Token\u0027: cls._admin_token,"},{"line_number":145,"context_line":"                \u0027Content-Type\u0027: \u0027application/json\u0027}"},{"line_number":146,"context_line":"        try:"},{"line_number":147,"context_line":"            rsp, content \u003d httplib2.Http().request(cls._tenants_api,"},{"line_number":148,"context_line":"                                                   method\u003d\"GET\", headers\u003dhdrs)"},{"line_number":149,"context_line":"            if rsp.status !\u003d 200:"},{"line_number":150,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2BrkQ%3D","line":147,"updated":"2014-02-19 20:41:52.000000000","message":"nit: i prefer response.","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"346d601cf47e2cb655ee6f4d6da3f7ac6347804a","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        hdrs \u003d {\u0027X-Auth-Token\u0027: cls._admin_token,"},{"line_number":145,"context_line":"                \u0027Content-Type\u0027: \u0027application/json\u0027}"},{"line_number":146,"context_line":"        try:"},{"line_number":147,"context_line":"            rsp, content \u003d httplib2.Http().request(cls._tenants_api,"},{"line_number":148,"context_line":"                                                   method\u003d\"GET\", headers\u003dhdrs)"},{"line_number":149,"context_line":"            if rsp.status !\u003d 200:"},{"line_number":150,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2Bgeg%3D","line":147,"in_reply_to":"AAAAUX%2F%2BrkQ%3D","updated":"2014-02-20 19:58:53.000000000","message":"Done","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"55180b641b221b51f3a0a71baeecd755e8855c04","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        except Exception:"},{"line_number":152,"context_line":"            return"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        # transform needed for python compatibility"},{"line_number":155,"context_line":"        content \u003d re.sub(\u0027true\u0027, \u0027True\u0027, content)"},{"line_number":156,"context_line":"        content \u003d re.sub(\u0027null\u0027, \u0027None\u0027, content)"},{"line_number":157,"context_line":"        content \u003d eval(content)"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2Brjk%3D","line":154,"updated":"2014-02-19 20:41:52.000000000","message":"use jsontool","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"346d601cf47e2cb655ee6f4d6da3f7ac6347804a","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        except Exception:"},{"line_number":152,"context_line":"            return"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        # transform needed for python compatibility"},{"line_number":155,"context_line":"        content \u003d re.sub(\u0027true\u0027, \u0027True\u0027, content)"},{"line_number":156,"context_line":"        content \u003d re.sub(\u0027null\u0027, \u0027None\u0027, content)"},{"line_number":157,"context_line":"        content \u003d eval(content)"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2BgeU%3D","line":154,"in_reply_to":"AAAAUX%2F%2Brjk%3D","updated":"2014-02-20 19:58:53.000000000","message":"Done","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"55180b641b221b51f3a0a71baeecd755e8855c04","unresolved":false,"context_lines":[{"line_number":512,"context_line":"        if rule[\u0027tenant_id\u0027] not in tenant_ids:"},{"line_number":513,"context_line":"            tenant_ids.add(rule[\u0027tenant_id\u0027])"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        #remote_group_id \u003d rule.get(\u0027remote_group_id\u0027)"},{"line_number":516,"context_line":"        ## Check that remote_group_id exists for tenant"},{"line_number":517,"context_line":"        #if remote_group_id:"},{"line_number":518,"context_line":"        #    self.get_security_group(context, remote_group_id,"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2Brig%3D","line":515,"updated":"2014-02-19 20:41:52.000000000","message":"please remove dead code","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"346d601cf47e2cb655ee6f4d6da3f7ac6347804a","unresolved":false,"context_lines":[{"line_number":512,"context_line":"        if rule[\u0027tenant_id\u0027] not in tenant_ids:"},{"line_number":513,"context_line":"            tenant_ids.add(rule[\u0027tenant_id\u0027])"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        #remote_group_id \u003d rule.get(\u0027remote_group_id\u0027)"},{"line_number":516,"context_line":"        ## Check that remote_group_id exists for tenant"},{"line_number":517,"context_line":"        #if remote_group_id:"},{"line_number":518,"context_line":"        #    self.get_security_group(context, remote_group_id,"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2BgeI%3D","line":515,"in_reply_to":"AAAAUX%2F%2Brig%3D","updated":"2014-02-20 19:58:53.000000000","message":"Done","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9cd640f78303e838d93fe977b6d972e3bc032e25","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# @author: Hampapur Ajay, Rudra Rugge, Atul Moghe Juniper Networks."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import json"},{"line_number":20,"context_line":"import string"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import httplib2"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2F%2FEc%3D","line":19,"updated":"2014-02-23 02:44:39.000000000","message":"Please use the version from neutron.openstack.common.\n\nfrom neutron.openstack.common import jsonutils as json","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"83cb8c45241a0d0cdee92db7e9ebcdc4f6eafd2f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# @author: Hampapur Ajay, Rudra Rugge, Atul Moghe Juniper Networks."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import json"},{"line_number":20,"context_line":"import string"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import httplib2"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2FzYE%3D","line":19,"in_reply_to":"AAAAU3%2F%2F%2FEc%3D","updated":"2014-02-25 21:19:57.000000000","message":"Done","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9cd640f78303e838d93fe977b6d972e3bc032e25","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# @author: Hampapur Ajay, Rudra Rugge, Atul Moghe Juniper Networks."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import json"},{"line_number":20,"context_line":"import string"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import httplib2"},{"line_number":23,"context_line":"from oslo.config import cfg"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2F%2FEY%3D","line":20,"updated":"2014-02-23 02:44:39.000000000","message":"This is unnecessary see below.","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"83cb8c45241a0d0cdee92db7e9ebcdc4f6eafd2f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# @author: Hampapur Ajay, Rudra Rugge, Atul Moghe Juniper Networks."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import json"},{"line_number":20,"context_line":"import string"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import httplib2"},{"line_number":23,"context_line":"from oslo.config import cfg"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2FmO8%3D","line":20,"in_reply_to":"AAAAU3%2F%2F%2FEY%3D","updated":"2014-02-25 21:19:57.000000000","message":"Done","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9cd640f78303e838d93fe977b6d972e3bc032e25","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import httplib2"},{"line_number":23,"context_line":"from oslo.config import cfg"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import ctdb.config_db"},{"line_number":26,"context_line":"from neutron.common import constants"},{"line_number":27,"context_line":"from neutron.common import exceptions as exc"},{"line_number":28,"context_line":"from neutron.db import db_base_plugin_v2"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2F%2FEU%3D","line":25,"updated":"2014-02-23 02:44:39.000000000","message":"This should be in 2nd group of imports","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"83cb8c45241a0d0cdee92db7e9ebcdc4f6eafd2f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import httplib2"},{"line_number":23,"context_line":"from oslo.config import cfg"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import ctdb.config_db"},{"line_number":26,"context_line":"from neutron.common import constants"},{"line_number":27,"context_line":"from neutron.common import exceptions as exc"},{"line_number":28,"context_line":"from neutron.db import db_base_plugin_v2"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2FmNw%3D","line":25,"in_reply_to":"AAAAU3%2F%2F%2FEU%3D","updated":"2014-02-25 21:19:57.000000000","message":"Done","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9cd640f78303e838d93fe977b6d972e3bc032e25","unresolved":false,"context_lines":[{"line_number":45,"context_line":"               help\u003d\u0027Retry Interval to connect to VNC Server\u0027),"},{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"keystone_opts \u003d ["},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027admin_token\u0027, default\u003d\u0027\u0027,"},{"line_number":50,"context_line":"               help\u003d\u0027Admin token\u0027),"},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027auth_url\u0027, default\u003d\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2F%2FEQ%3D","line":48,"updated":"2014-02-23 02:44:39.000000000","message":"Are these different keystone credentials than the ones in use from the server?  If not, this section can be dropped.","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"83cb8c45241a0d0cdee92db7e9ebcdc4f6eafd2f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"               help\u003d\u0027Retry Interval to connect to VNC Server\u0027),"},{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"keystone_opts \u003d ["},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027admin_token\u0027, default\u003d\u0027\u0027,"},{"line_number":50,"context_line":"               help\u003d\u0027Admin token\u0027),"},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027auth_url\u0027, default\u003d\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2Floo%3D","line":48,"in_reply_to":"AAAAU3%2F%2F%2FEQ%3D","updated":"2014-02-25 21:19:57.000000000","message":"Done","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9cd640f78303e838d93fe977b6d972e3bc032e25","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"class ContrailPlugin(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":80,"context_line":"                     securitygroup.SecurityGroupPluginBase):"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # only floatingip part of router extension is supported."},{"line_number":83,"context_line":"    supported_extension_aliases \u003d [\"security-group\", \"port-security\"]"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2F%2FDE%3D","line":80,"updated":"2014-02-23 02:44:39.000000000","message":"Why are you importing the extension here?","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"83cb8c45241a0d0cdee92db7e9ebcdc4f6eafd2f","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"class ContrailPlugin(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":80,"context_line":"                     securitygroup.SecurityGroupPluginBase):"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # only floatingip part of router extension is supported."},{"line_number":83,"context_line":"    supported_extension_aliases \u003d [\"security-group\", \"port-security\"]"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2FmGI%3D","line":80,"in_reply_to":"AAAAU3%2F%2F%2FDE%3D","updated":"2014-02-25 21:19:57.000000000","message":"We are implementing the class methods in the plugin.","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9cd640f78303e838d93fe977b6d972e3bc032e25","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    _tenant_id_dict \u003d {}"},{"line_number":88,"context_line":"    _tenant_name_dict \u003d {}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @classmethod"},{"line_number":91,"context_line":"    def _parse_class_args(cls):"},{"line_number":92,"context_line":"        cls._multi_tenancy \u003d cfg.CONF.APISERVER.multi_tenancy"},{"line_number":93,"context_line":"        cls._max_retries \u003d cfg.CONF.APISERVER.max_retries"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2F%2FEA%3D","line":90,"updated":"2014-02-23 02:44:39.000000000","message":"Why is this a class method?  This should be an instance method.","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"83cb8c45241a0d0cdee92db7e9ebcdc4f6eafd2f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    _tenant_id_dict \u003d {}"},{"line_number":88,"context_line":"    _tenant_name_dict \u003d {}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @classmethod"},{"line_number":91,"context_line":"    def _parse_class_args(cls):"},{"line_number":92,"context_line":"        cls._multi_tenancy \u003d cfg.CONF.APISERVER.multi_tenancy"},{"line_number":93,"context_line":"        cls._max_retries \u003d cfg.CONF.APISERVER.max_retries"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2FmFM%3D","line":90,"in_reply_to":"AAAAU3%2F%2F%2FEA%3D","updated":"2014-02-25 21:19:57.000000000","message":"We need a single instance of config db connection.","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9cd640f78303e838d93fe977b6d972e3bc032e25","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        cls._tenants_api \u003d \u0027%s/tenants\u0027 % (cls._auth_url)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @classmethod"},{"line_number":105,"context_line":"    def _connect_to_db(cls):"},{"line_number":106,"context_line":"        \"\"\"Connection to config db."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        Many instantiations of plugin (base + extensions) but need to have"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2F%2FD4%3D","line":105,"updated":"2014-02-23 02:44:39.000000000","message":"This should be an instance method.","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"83cb8c45241a0d0cdee92db7e9ebcdc4f6eafd2f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        cls._tenants_api \u003d \u0027%s/tenants\u0027 % (cls._auth_url)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @classmethod"},{"line_number":105,"context_line":"    def _connect_to_db(cls):"},{"line_number":106,"context_line":"        \"\"\"Connection to config db."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        Many instantiations of plugin (base + extensions) but need to have"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2FmFU%3D","line":105,"in_reply_to":"AAAAU3%2F%2F%2FD4%3D","updated":"2014-02-25 21:19:57.000000000","message":"See the comment on this function. We need a single instance of config db connection.","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9cd640f78303e838d93fe977b6d972e3bc032e25","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            cls._cfgdb.manager \u003d cls"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @classmethod"},{"line_number":125,"context_line":"    def _get_user_cfgdb(cls, context):"},{"line_number":126,"context_line":"        if not cls._multi_tenancy:"},{"line_number":127,"context_line":"            return cls._cfgdb"},{"line_number":128,"context_line":"        user_id \u003d context.user_id"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2F%2FDw%3D","line":125,"updated":"2014-02-23 02:44:39.000000000","message":"This should be an instance method.","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"83cb8c45241a0d0cdee92db7e9ebcdc4f6eafd2f","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            cls._cfgdb.manager \u003d cls"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @classmethod"},{"line_number":125,"context_line":"    def _get_user_cfgdb(cls, context):"},{"line_number":126,"context_line":"        if not cls._multi_tenancy:"},{"line_number":127,"context_line":"            return cls._cfgdb"},{"line_number":128,"context_line":"        user_id \u003d context.user_id"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2FmE0%3D","line":125,"in_reply_to":"AAAAU3%2F%2F%2FDw%3D","updated":"2014-02-25 21:19:57.000000000","message":"We need a single instance of config db connection.","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9cd640f78303e838d93fe977b6d972e3bc032e25","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        return cls._cfgdb_map[user_id]"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    @classmethod"},{"line_number":142,"context_line":"    def _tenant_list_from_keystone(cls):"},{"line_number":143,"context_line":"        # get all tenants"},{"line_number":144,"context_line":"        headers \u003d {\u0027X-Auth-Token\u0027: cls._admin_token,"},{"line_number":145,"context_line":"                   \u0027Content-Type\u0027: \u0027application/json\u0027}"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2F%2FDo%3D","line":142,"updated":"2014-02-23 02:44:39.000000000","message":"This should be an instance method.","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"83cb8c45241a0d0cdee92db7e9ebcdc4f6eafd2f","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        return cls._cfgdb_map[user_id]"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    @classmethod"},{"line_number":142,"context_line":"    def _tenant_list_from_keystone(cls):"},{"line_number":143,"context_line":"        # get all tenants"},{"line_number":144,"context_line":"        headers \u003d {\u0027X-Auth-Token\u0027: cls._admin_token,"},{"line_number":145,"context_line":"                   \u0027Content-Type\u0027: \u0027application/json\u0027}"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2FmEo%3D","line":142,"in_reply_to":"AAAAU3%2F%2F%2FDo%3D","updated":"2014-02-25 21:19:57.000000000","message":"We need a single instance of config db connection.","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9cd640f78303e838d93fe977b6d972e3bc032e25","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        LOG.debug(_(\"get_subnets_count(): %r\"), str(subnets_count))"},{"line_number":310,"context_line":"        return subnets_count"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def _make_floatingip_dict(self, floatingip, fields\u003dNone):"},{"line_number":313,"context_line":"        res \u003d {\u0027id\u0027: floatingip[\u0027id\u0027],"},{"line_number":314,"context_line":"               \u0027tenant_id\u0027: floatingip[\u0027tenant_id\u0027],"},{"line_number":315,"context_line":"               \u0027floating_ip_address\u0027: floatingip[\u0027floating_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2F%2FDU%3D","line":312,"updated":"2014-02-23 02:44:39.000000000","message":"Why are you reimplementing this method?","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"83cb8c45241a0d0cdee92db7e9ebcdc4f6eafd2f","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        LOG.debug(_(\"get_subnets_count(): %r\"), str(subnets_count))"},{"line_number":310,"context_line":"        return subnets_count"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def _make_floatingip_dict(self, floatingip, fields\u003dNone):"},{"line_number":313,"context_line":"        res \u003d {\u0027id\u0027: floatingip[\u0027id\u0027],"},{"line_number":314,"context_line":"               \u0027tenant_id\u0027: floatingip[\u0027tenant_id\u0027],"},{"line_number":315,"context_line":"               \u0027floating_ip_address\u0027: floatingip[\u0027floating_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2FzJc%3D","line":312,"in_reply_to":"AAAAU3%2F%2F%2FDU%3D","updated":"2014-02-25 21:19:57.000000000","message":"Done","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9cd640f78303e838d93fe977b6d972e3bc032e25","unresolved":false,"context_lines":[{"line_number":517,"context_line":"            raise securitygroup.SecurityGroupRulesNotSingleTenant()"},{"line_number":518,"context_line":"        return"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    def _make_security_group_rule_dict(self, security_group_rule, fields\u003dNone):"},{"line_number":521,"context_line":"        res \u003d {\u0027id\u0027: security_group_rule[\u0027id\u0027],"},{"line_number":522,"context_line":"               \u0027tenant_id\u0027: security_group_rule[\u0027tenant_id\u0027],"},{"line_number":523,"context_line":"               \u0027security_group_id\u0027: security_group_rule[\u0027security_group_id\u0027],"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2F%2FDM%3D","line":520,"updated":"2014-02-23 02:44:39.000000000","message":"Why is this reimplemented?","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"83cb8c45241a0d0cdee92db7e9ebcdc4f6eafd2f","unresolved":false,"context_lines":[{"line_number":517,"context_line":"            raise securitygroup.SecurityGroupRulesNotSingleTenant()"},{"line_number":518,"context_line":"        return"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    def _make_security_group_rule_dict(self, security_group_rule, fields\u003dNone):"},{"line_number":521,"context_line":"        res \u003d {\u0027id\u0027: security_group_rule[\u0027id\u0027],"},{"line_number":522,"context_line":"               \u0027tenant_id\u0027: security_group_rule[\u0027tenant_id\u0027],"},{"line_number":523,"context_line":"               \u0027security_group_id\u0027: security_group_rule[\u0027security_group_id\u0027],"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2FzL4%3D","line":520,"in_reply_to":"AAAAU3%2F%2F%2FDM%3D","updated":"2014-02-25 21:19:57.000000000","message":"Done","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"}],"neutron/plugins/juniper/contrail/ctdb/__init__.py":[{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"d4764e6da5d87962786841bfa96d482cf966ea36","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Copyright 2013 Juniper Networks.  All rights reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":7,"context_line":"#    a copy of the License at"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"#         http://www.apache.org/licenses/LICENSE-2.0"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUH%2F9qbw%3D","line":6,"updated":"2014-02-05 08:38:58.000000000","message":"remove Copyright from empty files","commit_id":"d0a6fc6b3277166d726e8fe332e1b7dbc3586522"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"86156603e1097114af7a258f378c53770cbb0b2e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Copyright 2013 Juniper Networks.  All rights reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":7,"context_line":"#    a copy of the License at"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"#         http://www.apache.org/licenses/LICENSE-2.0"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUH%2F9mwc%3D","line":6,"in_reply_to":"AAAAUH%2F9qbw%3D","updated":"2014-02-05 18:49:20.000000000","message":"Done","commit_id":"d0a6fc6b3277166d726e8fe332e1b7dbc3586522"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"643fff30b5e640c943a9279e1882e10608c59484","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# @author: Hampapur Ajay Juniper Networks."}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FYyY%3D","line":17,"updated":"2014-02-13 15:47:00.000000000","message":"same comment as for other __init___","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"574f6e2a84875198bb6eb32fd95bf5c626727b56","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# @author: Hampapur Ajay Juniper Networks."}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FWKc%3D","line":17,"in_reply_to":"AAAAUX%2F%2FYyY%3D","updated":"2014-02-14 00:42:48.000000000","message":"Done","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"}],"neutron/plugins/juniper/contrail/ctdb/config_db.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import socket"},{"line_number":23,"context_line":"import time"},{"line_number":24,"context_line":"import uuid"},{"line_number":25,"context_line":"from netaddr import IPNetwork, IPSet, IPAddress"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from neutron.api.v2 import attributes as attr"},{"line_number":28,"context_line":"from neutron.common import constants"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqM0%3D","line":25,"updated":"2013-09-01 02:50:32.000000000","message":"netaddr is a 3rd party library.  There should be a newline before this import.  Additionally, you should import the module and no classes out of the module for style consistency with Neutron.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import socket"},{"line_number":23,"context_line":"import time"},{"line_number":24,"context_line":"import uuid"},{"line_number":25,"context_line":"from netaddr import IPNetwork, IPSet, IPAddress"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from neutron.api.v2 import attributes as attr"},{"line_number":28,"context_line":"from neutron.common import constants"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYz8%3D","line":25,"in_reply_to":"AAAASn%2F%2FqM0%3D","updated":"2013-10-07 16:59:22.000000000","message":"will modify as suggested","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from neutron.api.v2 import attributes as attr"},{"line_number":28,"context_line":"from neutron.common import constants"},{"line_number":29,"context_line":"from neutron.common import exceptions"},{"line_number":30,"context_line":"from vnc_api.common import exception as vnc_exc"},{"line_number":31,"context_line":"from vnc_api import vnc_api"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"_DEFAULT_HEADERS \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqMw%3D","line":30,"updated":"2013-09-01 02:50:32.000000000","message":"This should be in the 3rd party import section.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from neutron.api.v2 import attributes as attr"},{"line_number":28,"context_line":"from neutron.common import constants"},{"line_number":29,"context_line":"from neutron.common import exceptions"},{"line_number":30,"context_line":"from vnc_api.common import exception as vnc_exc"},{"line_number":31,"context_line":"from vnc_api import vnc_api"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"_DEFAULT_HEADERS \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYzw%3D","line":30,"in_reply_to":"AAAASn%2F%2FqMw%3D","updated":"2013-10-07 16:59:22.000000000","message":"will modify as suggested","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        self._api_srvr_port \u003d api_srvr_port"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        self._db_cache \u003d {}"},{"line_number":54,"context_line":"        self._db_cache[\u0027q_networks\u0027] \u003d {}"},{"line_number":55,"context_line":"        self._db_cache[\u0027q_subnets\u0027] \u003d {}"},{"line_number":56,"context_line":"        self._db_cache[\u0027q_subnet_maps\u0027] \u003d {}"},{"line_number":57,"context_line":"        self._db_cache[\u0027q_policies\u0027] \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FLCA%3D","line":54,"updated":"2013-10-02 23:32:37.000000000","message":"q \u003d\u003d quantum ?\nif so we should use n_","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        self._api_srvr_port \u003d api_srvr_port"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        self._db_cache \u003d {}"},{"line_number":54,"context_line":"        self._db_cache[\u0027q_networks\u0027] \u003d {}"},{"line_number":55,"context_line":"        self._db_cache[\u0027q_subnets\u0027] \u003d {}"},{"line_number":56,"context_line":"        self._db_cache[\u0027q_subnet_maps\u0027] \u003d {}"},{"line_number":57,"context_line":"        self._db_cache[\u0027q_policies\u0027] \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F8fI%3D","line":54,"in_reply_to":"AAAAS3%2F%2FLCA%3D","updated":"2013-10-07 16:59:22.000000000","message":"we will see if we can change if it is localized..","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        # Retry till a api-server is up"},{"line_number":72,"context_line":"        connected \u003d False"},{"line_number":73,"context_line":"        while not connected:"},{"line_number":74,"context_line":"            try:"},{"line_number":75,"context_line":"                self._vnc_lib \u003d vnc_api.VncApi("},{"line_number":76,"context_line":"                    admin_name, admin_password,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FLBw%3D","line":73,"updated":"2013-10-02 23:32:37.000000000","message":"We should not do this forever.\nWe need to have reconnection_max.\nAlso we need raise a proper exception","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"1e7eadbb6c690bc7540596d7c92d37b356cd6eac","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        # Retry till a api-server is up"},{"line_number":72,"context_line":"        connected \u003d False"},{"line_number":73,"context_line":"        while not connected:"},{"line_number":74,"context_line":"            try:"},{"line_number":75,"context_line":"                self._vnc_lib \u003d vnc_api.VncApi("},{"line_number":76,"context_line":"                    admin_name, admin_password,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F3w0%3D","line":73,"in_reply_to":"AAAAS3%2F%2FLBw%3D","updated":"2013-10-08 21:34:24.000000000","message":"This needs to like this to as different component in distributed system may come up any time. Without this connection, this plugin wont do much just keep trying to api-server, therefore exception is also a sleep to retry after some time","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        # Retry till a api-server is up"},{"line_number":72,"context_line":"        connected \u003d False"},{"line_number":73,"context_line":"        while not connected:"},{"line_number":74,"context_line":"            try:"},{"line_number":75,"context_line":"                self._vnc_lib \u003d vnc_api.VncApi("},{"line_number":76,"context_line":"                    admin_name, admin_password,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F8fA%3D","line":73,"in_reply_to":"AAAAS3%2F%2FLBw%3D","updated":"2013-10-07 16:59:22.000000000","message":"will take a look","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            except requests.exceptions.RequestException:"},{"line_number":81,"context_line":"                time.sleep(3)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # changes \u0027net_fq_name_str pfx/len\u0027 key to \u0027net_id pfx/len\u0027 key"},{"line_number":84,"context_line":"        subnet_map \u003d self._vnc_lib.kv_retrieve(key\u003dNone)"},{"line_number":85,"context_line":"        for kv_dict in subnet_map:"},{"line_number":86,"context_line":"            key \u003d kv_dict[\u0027key\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FK9I%3D","line":83,"updated":"2013-10-02 23:32:37.000000000","message":"please add some examples","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            except requests.exceptions.RequestException:"},{"line_number":81,"context_line":"                time.sleep(3)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # changes \u0027net_fq_name_str pfx/len\u0027 key to \u0027net_id pfx/len\u0027 key"},{"line_number":84,"context_line":"        subnet_map \u003d self._vnc_lib.kv_retrieve(key\u003dNone)"},{"line_number":85,"context_line":"        for kv_dict in subnet_map:"},{"line_number":86,"context_line":"            key \u003d kv_dict[\u0027key\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F8e8%3D","line":83,"in_reply_to":"AAAAS3%2F%2FK9I%3D","updated":"2013-10-07 16:59:22.000000000","message":"Done","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # changes \u0027net_fq_name_str pfx/len\u0027 key to \u0027net_id pfx/len\u0027 key"},{"line_number":84,"context_line":"        subnet_map \u003d self._vnc_lib.kv_retrieve(key\u003dNone)"},{"line_number":85,"context_line":"        for kv_dict in subnet_map:"},{"line_number":86,"context_line":"            key \u003d kv_dict[\u0027key\u0027]"},{"line_number":87,"context_line":"            if len(key.split()) \u003d\u003d 1:"},{"line_number":88,"context_line":"                subnet_id \u003d key"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FLBg%3D","line":85,"updated":"2013-10-02 23:32:37.000000000","message":"for net_fq_name_str, prefix in [(d[\u0027key\u0027],d[\u0027value\u0027]) for d in subnet_map]:","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # changes \u0027net_fq_name_str pfx/len\u0027 key to \u0027net_id pfx/len\u0027 key"},{"line_number":84,"context_line":"        subnet_map \u003d self._vnc_lib.kv_retrieve(key\u003dNone)"},{"line_number":85,"context_line":"        for kv_dict in subnet_map:"},{"line_number":86,"context_line":"            key \u003d kv_dict[\u0027key\u0027]"},{"line_number":87,"context_line":"            if len(key.split()) \u003d\u003d 1:"},{"line_number":88,"context_line":"                subnet_id \u003d key"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F8e4%3D","line":85,"in_reply_to":"AAAAS3%2F%2FLBg%3D","updated":"2013-10-07 16:59:22.000000000","message":"will take a look","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                net_fq_name \u003d kv_dict[\u0027value\u0027].split()[0].split(\u0027:\u0027)"},{"line_number":96,"context_line":"                try:"},{"line_number":97,"context_line":"                    net_obj \u003d self._virtual_network_read(fq_name\u003dnet_fq_name)"},{"line_number":98,"context_line":"                except vnc_exc.NoIdError:"},{"line_number":99,"context_line":"                    self._vnc_lib.kv_delete(subnet_id)"},{"line_number":100,"context_line":"                    continue"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FK9A%3D","line":98,"updated":"2013-10-02 23:32:37.000000000","message":"should log warning","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                net_fq_name \u003d kv_dict[\u0027value\u0027].split()[0].split(\u0027:\u0027)"},{"line_number":96,"context_line":"                try:"},{"line_number":97,"context_line":"                    net_obj \u003d self._virtual_network_read(fq_name\u003dnet_fq_name)"},{"line_number":98,"context_line":"                except vnc_exc.NoIdError:"},{"line_number":99,"context_line":"                    self._vnc_lib.kv_delete(subnet_id)"},{"line_number":100,"context_line":"                    continue"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F8e0%3D","line":98,"in_reply_to":"AAAAS3%2F%2FK9A%3D","updated":"2013-10-07 16:59:22.000000000","message":"Done","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                try:"},{"line_number":117,"context_line":"                    net_obj \u003d self._virtual_network_read(fq_name\u003dnet_fq_name)"},{"line_number":118,"context_line":"                except vnc_exc.NoIdError:"},{"line_number":119,"context_line":"                    continue"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"                new_subnet_key \u003d \u0027%s %s\u0027 % (net_obj.uuid, key.split()[1])"},{"line_number":122,"context_line":"                self._vnc_lib.kv_store(new_subnet_key, subnet_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FK88%3D","line":119,"updated":"2013-10-02 23:32:37.000000000","message":"should log error","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                try:"},{"line_number":117,"context_line":"                    net_obj \u003d self._virtual_network_read(fq_name\u003dnet_fq_name)"},{"line_number":118,"context_line":"                except vnc_exc.NoIdError:"},{"line_number":119,"context_line":"                    continue"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"                new_subnet_key \u003d \u0027%s %s\u0027 % (net_obj.uuid, key.split()[1])"},{"line_number":122,"context_line":"                self._vnc_lib.kv_store(new_subnet_key, subnet_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F8ew%3D","line":119,"in_reply_to":"AAAAS3%2F%2FK88%3D","updated":"2013-10-07 16:59:22.000000000","message":"Done","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                new_subnet_key \u003d \u0027%s %s\u0027 % (net_obj.uuid, key.split()[1])"},{"line_number":122,"context_line":"                self._vnc_lib.kv_store(new_subnet_key, subnet_id)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    # Helper routines"},{"line_number":125,"context_line":"    def _request_api_server(self, url, method, data\u003dNone, headers\u003dNone):"},{"line_number":126,"context_line":"        if method \u003d\u003d \u0027GET\u0027:"},{"line_number":127,"context_line":"            return requests.get(url)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FLBc%3D","line":124,"updated":"2013-10-02 23:32:37.000000000","message":"This comment is not helpful","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                new_subnet_key \u003d \u0027%s %s\u0027 % (net_obj.uuid, key.split()[1])"},{"line_number":122,"context_line":"                self._vnc_lib.kv_store(new_subnet_key, subnet_id)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    # Helper routines"},{"line_number":125,"context_line":"    def _request_api_server(self, url, method, data\u003dNone, headers\u003dNone):"},{"line_number":126,"context_line":"        if method \u003d\u003d \u0027GET\u0027:"},{"line_number":127,"context_line":"            return requests.get(url)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F8ek%3D","line":124,"in_reply_to":"AAAAS3%2F%2FLBc%3D","updated":"2013-10-07 16:59:22.000000000","message":"Done","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    # Helper routines"},{"line_number":125,"context_line":"    def _request_api_server(self, url, method, data\u003dNone, headers\u003dNone):"},{"line_number":126,"context_line":"        if method \u003d\u003d \u0027GET\u0027:"},{"line_number":127,"context_line":"            return requests.get(url)"},{"line_number":128,"context_line":"        if method \u003d\u003d \u0027POST\u0027:"},{"line_number":129,"context_line":"            return requests.post(url, data\u003ddata, headers\u003dheaders)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqMo%3D","line":126,"updated":"2013-09-01 02:50:32.000000000","message":"There is a much simpler way:\n\nreturn requests.request(method, url\u003durl, data\u003ddata, headers\u003dheaders)","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    # Helper routines"},{"line_number":125,"context_line":"    def _request_api_server(self, url, method, data\u003dNone, headers\u003dNone):"},{"line_number":126,"context_line":"        if method \u003d\u003d \u0027GET\u0027:"},{"line_number":127,"context_line":"            return requests.get(url)"},{"line_number":128,"context_line":"        if method \u003d\u003d \u0027POST\u0027:"},{"line_number":129,"context_line":"            return requests.post(url, data\u003ddata, headers\u003dheaders)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYbE%3D","line":126,"in_reply_to":"AAAASn%2F%2FqMo%3D","updated":"2013-10-07 16:59:22.000000000","message":"will change as suggested","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            request.body, {\u0027Content-type\u0027: request.environ[\u0027CONTENT_TYPE\u0027]})"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def _obj_to_json(self, obj):"},{"line_number":147,"context_line":"        return dict((k, v) for k, v in obj.__dict__.iteritems())"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def _ensure_instance_exists(self, instance_id):"},{"line_number":150,"context_line":"        instance_name \u003d instance_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqMk%3D","line":147,"updated":"2013-09-01 02:50:32.000000000","message":"return vars(obj)","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            request.body, {\u0027Content-type\u0027: request.environ[\u0027CONTENT_TYPE\u0027]})"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def _obj_to_json(self, obj):"},{"line_number":147,"context_line":"        return dict((k, v) for k, v in obj.__dict__.iteritems())"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def _ensure_instance_exists(self, instance_id):"},{"line_number":150,"context_line":"        instance_name \u003d instance_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX1A%3D","line":147,"in_reply_to":"AAAASn%2F%2FqMk%3D","updated":"2013-10-07 16:59:22.000000000","message":"will make changes as per suggestion","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        self._vnc_lib.security_group_create(sg_obj)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        #allow all egress traffic"},{"line_number":173,"context_line":"        def_rule \u003d {}"},{"line_number":174,"context_line":"        def_rule[\u0027port_range_min\u0027] \u003d 0"},{"line_number":175,"context_line":"        def_rule[\u0027port_range_max\u0027] \u003d 65535"},{"line_number":176,"context_line":"        def_rule[\u0027direction\u0027] \u003d \u0027egress\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqMg%3D","line":173,"updated":"2013-09-01 02:50:32.000000000","message":"You can declare a dict with keys in one step.  \n\ndef_rule \u003d {\n    \u0027port_range_min\u0027: 0,\n    \u0027port_range_max\u0027: 65535,\n    \u0027direction\u0027: \u0027egress\u0027,\n    ...\n}","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        self._vnc_lib.security_group_create(sg_obj)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        #allow all egress traffic"},{"line_number":173,"context_line":"        def_rule \u003d {}"},{"line_number":174,"context_line":"        def_rule[\u0027port_range_min\u0027] \u003d 0"},{"line_number":175,"context_line":"        def_rule[\u0027port_range_max\u0027] \u003d 65535"},{"line_number":176,"context_line":"        def_rule[\u0027direction\u0027] \u003d \u0027egress\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYyY%3D","line":173,"in_reply_to":"AAAASn%2F%2FqMg%3D","updated":"2013-10-07 16:59:22.000000000","message":"will take care of it.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        self._security_group_rule_create(sg_obj.uuid, rule)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        #allow ingress traffic from within default security group"},{"line_number":184,"context_line":"        def_rule \u003d {}"},{"line_number":185,"context_line":"        def_rule[\u0027port_range_min\u0027] \u003d 0"},{"line_number":186,"context_line":"        def_rule[\u0027port_range_max\u0027] \u003d 65535"},{"line_number":187,"context_line":"        def_rule[\u0027direction\u0027] \u003d \u0027ingress\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqMc%3D","line":184,"updated":"2013-09-01 02:50:32.000000000","message":"same as above","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        self._security_group_rule_create(sg_obj.uuid, rule)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        #allow ingress traffic from within default security group"},{"line_number":184,"context_line":"        def_rule \u003d {}"},{"line_number":185,"context_line":"        def_rule[\u0027port_range_min\u0027] \u003d 0"},{"line_number":186,"context_line":"        def_rule[\u0027port_range_max\u0027] \u003d 65535"},{"line_number":187,"context_line":"        def_rule[\u0027direction\u0027] \u003d \u0027ingress\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYyQ%3D","line":184,"in_reply_to":"AAAASn%2F%2FqMc%3D","updated":"2013-10-07 16:59:22.000000000","message":"will modify as suggested","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":648,"context_line":"        return net_obj"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    def _subnet_vnc_create_mapping(self, subnet_id, subnet_key):"},{"line_number":651,"context_line":"        #import pdb; pdb.set_trace()"},{"line_number":652,"context_line":"        self._vnc_lib.kv_store(subnet_id, subnet_key)"},{"line_number":653,"context_line":"        self._vnc_lib.kv_store(subnet_key, subnet_id)"},{"line_number":654,"context_line":"        self._db_cache[\u0027q_subnet_maps\u0027][subnet_id] \u003d subnet_key"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FK8Y%3D","line":651,"updated":"2013-10-02 23:32:37.000000000","message":"remove this","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":648,"context_line":"        return net_obj"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    def _subnet_vnc_create_mapping(self, subnet_id, subnet_key):"},{"line_number":651,"context_line":"        #import pdb; pdb.set_trace()"},{"line_number":652,"context_line":"        self._vnc_lib.kv_store(subnet_id, subnet_key)"},{"line_number":653,"context_line":"        self._vnc_lib.kv_store(subnet_key, subnet_id)"},{"line_number":654,"context_line":"        self._db_cache[\u0027q_subnet_maps\u0027][subnet_id] \u003d subnet_key"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FER0%3D","line":651,"in_reply_to":"AAAAS3%2F%2FK8Y%3D","updated":"2013-10-07 16:59:22.000000000","message":"Done","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":658,"context_line":"        if id:"},{"line_number":659,"context_line":"            try:"},{"line_number":660,"context_line":"                return self._db_cache[\u0027q_subnet_maps\u0027][id]"},{"line_number":661,"context_line":"                #raise KeyError"},{"line_number":662,"context_line":"            except KeyError:"},{"line_number":663,"context_line":"                subnet_key \u003d self._vnc_lib.kv_retrieve(id)"},{"line_number":664,"context_line":"                self._db_cache[\u0027q_subnet_maps\u0027][id] \u003d subnet_key"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FK8U%3D","line":661,"updated":"2013-10-02 23:32:37.000000000","message":"remove","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":658,"context_line":"        if id:"},{"line_number":659,"context_line":"            try:"},{"line_number":660,"context_line":"                return self._db_cache[\u0027q_subnet_maps\u0027][id]"},{"line_number":661,"context_line":"                #raise KeyError"},{"line_number":662,"context_line":"            except KeyError:"},{"line_number":663,"context_line":"                subnet_key \u003d self._vnc_lib.kv_retrieve(id)"},{"line_number":664,"context_line":"                self._db_cache[\u0027q_subnet_maps\u0027][id] \u003d subnet_key"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FERk%3D","line":661,"in_reply_to":"AAAAS3%2F%2FK8U%3D","updated":"2013-10-07 16:59:22.000000000","message":"Done","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":666,"context_line":"        if key:"},{"line_number":667,"context_line":"            try:"},{"line_number":668,"context_line":"                return self._db_cache[\u0027q_subnet_maps\u0027][key]"},{"line_number":669,"context_line":"                #raise KeyError"},{"line_number":670,"context_line":"            except KeyError:"},{"line_number":671,"context_line":"                subnet_id \u003d self._vnc_lib.kv_retrieve(key)"},{"line_number":672,"context_line":"                self._db_cache[\u0027q_subnet_maps\u0027][key] \u003d subnet_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FK8Q%3D","line":669,"updated":"2013-10-02 23:32:37.000000000","message":"remove","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":666,"context_line":"        if key:"},{"line_number":667,"context_line":"            try:"},{"line_number":668,"context_line":"                return self._db_cache[\u0027q_subnet_maps\u0027][key]"},{"line_number":669,"context_line":"                #raise KeyError"},{"line_number":670,"context_line":"            except KeyError:"},{"line_number":671,"context_line":"                subnet_id \u003d self._vnc_lib.kv_retrieve(key)"},{"line_number":672,"context_line":"                self._db_cache[\u0027q_subnet_maps\u0027][key] \u003d subnet_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FERg%3D","line":669,"in_reply_to":"AAAAS3%2F%2FK8Q%3D","updated":"2013-10-07 16:59:22.000000000","message":"Done","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":737,"context_line":""},{"line_number":738,"context_line":"        return None"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"    # Conversion routines between VNC and Quantum objects"},{"line_number":741,"context_line":"    def _svc_instance_neutron_to_vnc(self, si_q, oper):"},{"line_number":742,"context_line":"        if oper \u003d\u003d CREATE:"},{"line_number":743,"context_line":"            project_id \u003d str(uuid.UUID(si_q[\u0027tenant_id\u0027]))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FK8A%3D","line":740,"updated":"2013-10-02 23:32:37.000000000","message":"Neutron","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":737,"context_line":""},{"line_number":738,"context_line":"        return None"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"    # Conversion routines between VNC and Quantum objects"},{"line_number":741,"context_line":"    def _svc_instance_neutron_to_vnc(self, si_q, oper):"},{"line_number":742,"context_line":"        if oper \u003d\u003d CREATE:"},{"line_number":743,"context_line":"            project_id \u003d str(uuid.UUID(si_q[\u0027tenant_id\u0027]))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FERY%3D","line":740,"in_reply_to":"AAAAS3%2F%2FK8A%3D","updated":"2013-10-07 16:59:22.000000000","message":"Done","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":739,"context_line":""},{"line_number":740,"context_line":"    # Conversion routines between VNC and Quantum objects"},{"line_number":741,"context_line":"    def _svc_instance_neutron_to_vnc(self, si_q, oper):"},{"line_number":742,"context_line":"        if oper \u003d\u003d CREATE:"},{"line_number":743,"context_line":"            project_id \u003d str(uuid.UUID(si_q[\u0027tenant_id\u0027]))"},{"line_number":744,"context_line":"            project_obj \u003d self._project_read(proj_id\u003dproject_id)"},{"line_number":745,"context_line":"            net_id \u003d si_q[\u0027internal_net\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FK74%3D","line":742,"updated":"2013-10-02 23:32:37.000000000","message":"should be operator","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":739,"context_line":""},{"line_number":740,"context_line":"    # Conversion routines between VNC and Quantum objects"},{"line_number":741,"context_line":"    def _svc_instance_neutron_to_vnc(self, si_q, oper):"},{"line_number":742,"context_line":"        if oper \u003d\u003d CREATE:"},{"line_number":743,"context_line":"            project_id \u003d str(uuid.UUID(si_q[\u0027tenant_id\u0027]))"},{"line_number":744,"context_line":"            project_obj \u003d self._project_read(proj_id\u003dproject_id)"},{"line_number":745,"context_line":"            net_id \u003d si_q[\u0027internal_net\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FERQ%3D","line":742,"in_reply_to":"AAAAS3%2F%2FK74%3D","updated":"2013-10-07 16:59:22.000000000","message":"oper is a well known usage for operator. we will keep it as as","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":757,"context_line":"                parent_obj\u003dproject_obj,"},{"line_number":758,"context_line":"                service_instance_properties\u003dsi_prop)"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"        return si_vnc"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    def _svc_instance_vnc_to_neutron(self, si_obj):"},{"line_number":763,"context_line":"        si_q_dict \u003d json.loads(json.dumps(si_obj,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FK78%3D","line":760,"updated":"2013-10-02 23:32:37.000000000","message":"si_vnc is not defined if oper isn\u0027t CREATE","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":757,"context_line":"                parent_obj\u003dproject_obj,"},{"line_number":758,"context_line":"                service_instance_properties\u003dsi_prop)"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"        return si_vnc"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    def _svc_instance_vnc_to_neutron(self, si_obj):"},{"line_number":763,"context_line":"        si_q_dict \u003d json.loads(json.dumps(si_obj,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F8es%3D","line":760,"in_reply_to":"AAAAS3%2F%2FK78%3D","updated":"2013-10-07 16:59:22.000000000","message":"will take a look","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0fb2c5090db81a191dec3a6a72201e1b001170d9","unresolved":false,"context_lines":[{"line_number":1014,"context_line":"            #        port_dict \u003d port_info[\u0027q_api_data\u0027]"},{"line_number":1015,"context_line":"            #        port_dict.update(port_info[\u0027q_extra_data\u0027])"},{"line_number":1016,"context_line":"            #"},{"line_number":1017,"context_line":"            #        net_q_dict[\u0027ports\u0027].append(port_dict)"},{"line_number":1018,"context_line":""},{"line_number":1019,"context_line":"            extra_dict[\u0027contrail:instance_count\u0027] \u003d 0"},{"line_number":1020,"context_line":"            if port_back_refs:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FK7w%3D","line":1017,"updated":"2013-10-02 23:32:37.000000000","message":"Remove unused code","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":1014,"context_line":"            #        port_dict \u003d port_info[\u0027q_api_data\u0027]"},{"line_number":1015,"context_line":"            #        port_dict.update(port_info[\u0027q_extra_data\u0027])"},{"line_number":1016,"context_line":"            #"},{"line_number":1017,"context_line":"            #        net_q_dict[\u0027ports\u0027].append(port_dict)"},{"line_number":1018,"context_line":""},{"line_number":1019,"context_line":"            extra_dict[\u0027contrail:instance_count\u0027] \u003d 0"},{"line_number":1020,"context_line":"            if port_back_refs:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FERA%3D","line":1017,"in_reply_to":"AAAAS3%2F%2FK7w%3D","updated":"2013-10-07 16:59:22.000000000","message":"Done","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":1070,"context_line":"        return subnet_vnc"},{"line_number":1071,"context_line":""},{"line_number":1072,"context_line":"    def _subnet_vnc_to_neutron(self, subnet_vnc, net_obj, ipam_fq_name):"},{"line_number":1073,"context_line":"        sn_q_dict \u003d {}"},{"line_number":1074,"context_line":"        sn_q_dict[\u0027name\u0027] \u003d \u0027\u0027"},{"line_number":1075,"context_line":"        sn_q_dict[\u0027tenant_id\u0027] \u003d net_obj.parent_uuid.replace(\u0027-\u0027, \u0027\u0027)"},{"line_number":1076,"context_line":"        sn_q_dict[\u0027network_id\u0027] \u003d net_obj.uuid"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqMY%3D","line":1073,"updated":"2013-09-01 02:50:32.000000000","message":"This should be initialized in one step","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":1070,"context_line":"        return subnet_vnc"},{"line_number":1071,"context_line":""},{"line_number":1072,"context_line":"    def _subnet_vnc_to_neutron(self, subnet_vnc, net_obj, ipam_fq_name):"},{"line_number":1073,"context_line":"        sn_q_dict \u003d {}"},{"line_number":1074,"context_line":"        sn_q_dict[\u0027name\u0027] \u003d \u0027\u0027"},{"line_number":1075,"context_line":"        sn_q_dict[\u0027tenant_id\u0027] \u003d net_obj.parent_uuid.replace(\u0027-\u0027, \u0027\u0027)"},{"line_number":1076,"context_line":"        sn_q_dict[\u0027network_id\u0027] \u003d net_obj.uuid"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYyA%3D","line":1073,"in_reply_to":"AAAASn%2F%2FqMY%3D","updated":"2013-10-07 16:59:22.000000000","message":"will change as suggested","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":"        first_ip \u003d str(IPNetwork(cidr).network + 1)"},{"line_number":1091,"context_line":"        last_ip \u003d str(IPNetwork(cidr).broadcast - 2)"},{"line_number":1092,"context_line":"        sn_q_dict[\u0027allocation_pools\u0027] \u003d \\"},{"line_number":1093,"context_line":"            [{\u0027id\u0027: \u0027TODO-allocation_pools-id\u0027,"},{"line_number":1094,"context_line":"             \u0027subnet_id\u0027: sn_id,"},{"line_number":1095,"context_line":"             \u0027first_ip\u0027: first_ip,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqMU%3D","line":1092,"updated":"2013-09-01 02:50:32.000000000","message":"Line continuations are not allowed per Neutron\u0027s hacking guidelines.  You should do this:\n\nsn_q_dict[\u0027allocation_pools\u0027] \u003d [\n    {\n    }\n]","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":"        first_ip \u003d str(IPNetwork(cidr).network + 1)"},{"line_number":1091,"context_line":"        last_ip \u003d str(IPNetwork(cidr).broadcast - 2)"},{"line_number":1092,"context_line":"        sn_q_dict[\u0027allocation_pools\u0027] \u003d \\"},{"line_number":1093,"context_line":"            [{\u0027id\u0027: \u0027TODO-allocation_pools-id\u0027,"},{"line_number":1094,"context_line":"             \u0027subnet_id\u0027: sn_id,"},{"line_number":1095,"context_line":"             \u0027first_ip\u0027: first_ip,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYxo%3D","line":1092,"in_reply_to":"AAAASn%2F%2FqMU%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok, will change as suggested","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":1219,"context_line":"        if port_refs:"},{"line_number":1220,"context_line":"            port_id \u003d fip_obj.get_virtual_machine_interface_refs()[0][\u0027uuid\u0027]"},{"line_number":1221,"context_line":""},{"line_number":1222,"context_line":"        fip_q_dict[\u0027id\u0027] \u003d fip_obj.uuid"},{"line_number":1223,"context_line":"        fip_q_dict[\u0027tenant_id\u0027] \u003d tenant_id"},{"line_number":1224,"context_line":"        fip_q_dict[\u0027floating_ip_address\u0027] \u003d fip_obj.get_floating_ip_address()"},{"line_number":1225,"context_line":"        fip_q_dict[\u0027floating_network_id\u0027] \u003d net_obj.uuid"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqKk%3D","line":1222,"updated":"2013-09-01 02:50:32.000000000","message":"You should initialize the fip_q_dict here.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":1219,"context_line":"        if port_refs:"},{"line_number":1220,"context_line":"            port_id \u003d fip_obj.get_virtual_machine_interface_refs()[0][\u0027uuid\u0027]"},{"line_number":1221,"context_line":""},{"line_number":1222,"context_line":"        fip_q_dict[\u0027id\u0027] \u003d fip_obj.uuid"},{"line_number":1223,"context_line":"        fip_q_dict[\u0027tenant_id\u0027] \u003d tenant_id"},{"line_number":1224,"context_line":"        fip_q_dict[\u0027floating_ip_address\u0027] \u003d fip_obj.get_floating_ip_address()"},{"line_number":1225,"context_line":"        fip_q_dict[\u0027floating_network_id\u0027] \u003d net_obj.uuid"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYxk%3D","line":1222,"in_reply_to":"AAAASn%2F%2FqKk%3D","updated":"2013-10-07 16:59:22.000000000","message":"ok. will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":1579,"context_line":"            if ipam_refs:"},{"line_number":1580,"context_line":"                for ipam_ref in ipam_refs:"},{"line_number":1581,"context_line":"                    subnet_vncs \u003d ipam_ref[\u0027attr\u0027].get_ipam_subnets()"},{"line_number":1582,"context_line":"                    for subnet_vnc in subnet_vncs:"},{"line_number":1583,"context_line":"                        sn_info \u003d self._subnet_vnc_to_neutron(subnet_vnc,"},{"line_number":1584,"context_line":"                                                              net_obj,"},{"line_number":1585,"context_line":"                                                              ipam_ref[\u0027to\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqKo%3D","line":1582,"updated":"2013-09-01 02:50:32.000000000","message":"This is N^3 and should probably be optimized","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":1579,"context_line":"            if ipam_refs:"},{"line_number":1580,"context_line":"                for ipam_ref in ipam_refs:"},{"line_number":1581,"context_line":"                    subnet_vncs \u003d ipam_ref[\u0027attr\u0027].get_ipam_subnets()"},{"line_number":1582,"context_line":"                    for subnet_vnc in subnet_vncs:"},{"line_number":1583,"context_line":"                        sn_info \u003d self._subnet_vnc_to_neutron(subnet_vnc,"},{"line_number":1584,"context_line":"                                                              net_obj,"},{"line_number":1585,"context_line":"                                                              ipam_ref[\u0027to\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYxE%3D","line":1582,"in_reply_to":"AAAASn%2F%2FqKo%3D","updated":"2013-10-07 16:59:22.000000000","message":"We need this logic to iterate over all subnet_vncs in all ipam_refs in net_ids.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":1697,"context_line":"        all_policys \u003d []  # all policys in all projects"},{"line_number":1698,"context_line":"        if filters and \u0027tenant_id\u0027 in filters:"},{"line_number":1699,"context_line":"            project_ids \u003d filters[\u0027tenant_id\u0027]"},{"line_number":1700,"context_line":"            for p_id in project_ids:"},{"line_number":1701,"context_line":"                project_policys \u003d self._policy_list_project(p_id)"},{"line_number":1702,"context_line":"                all_policys.append(project_policys)"},{"line_number":1703,"context_line":"        else:  # no filters"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqKs%3D","line":1700,"updated":"2013-09-01 02:50:32.000000000","message":"this should be a list comprehension","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":1697,"context_line":"        all_policys \u003d []  # all policys in all projects"},{"line_number":1698,"context_line":"        if filters and \u0027tenant_id\u0027 in filters:"},{"line_number":1699,"context_line":"            project_ids \u003d filters[\u0027tenant_id\u0027]"},{"line_number":1700,"context_line":"            for p_id in project_ids:"},{"line_number":1701,"context_line":"                project_policys \u003d self._policy_list_project(p_id)"},{"line_number":1702,"context_line":"                all_policys.append(project_policys)"},{"line_number":1703,"context_line":"        else:  # no filters"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYas%3D","line":1700,"in_reply_to":"AAAASn%2F%2FqKs%3D","updated":"2013-10-07 16:59:22.000000000","message":"will change as suggested","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":1708,"context_line":"                all_policys.append(project_policys)"},{"line_number":1709,"context_line":""},{"line_number":1710,"context_line":"        # prune phase"},{"line_number":1711,"context_line":"        for project_policys in all_policys:"},{"line_number":1712,"context_line":"            for proj_policy in project_policys:"},{"line_number":1713,"context_line":"                proj_policy_id \u003d proj_policy[\u0027uuid\u0027]"},{"line_number":1714,"context_line":"                if not self._filters_is_present(filters, \u0027id\u0027, proj_policy_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqKw%3D","line":1711,"updated":"2013-09-01 02:50:32.000000000","message":"this should be converted to a generator expression passed to extends()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":1708,"context_line":"                all_policys.append(project_policys)"},{"line_number":1709,"context_line":""},{"line_number":1710,"context_line":"        # prune phase"},{"line_number":1711,"context_line":"        for project_policys in all_policys:"},{"line_number":1712,"context_line":"            for proj_policy in project_policys:"},{"line_number":1713,"context_line":"                proj_policy_id \u003d proj_policy[\u0027uuid\u0027]"},{"line_number":1714,"context_line":"                if not self._filters_is_present(filters, \u0027id\u0027, proj_policy_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYak%3D","line":1711,"in_reply_to":"AAAASn%2F%2FqKw%3D","updated":"2013-10-07 16:59:22.000000000","message":"will change as suggested","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":1762,"context_line":"                    fip_back_refs \u003d port_obj.get_floating_ip_back_refs()"},{"line_number":1763,"context_line":"                    if not fip_back_refs:"},{"line_number":1764,"context_line":"                        continue"},{"line_number":1765,"context_line":"                    for fip_back_ref in fip_back_refs:"},{"line_number":1766,"context_line":"                        fip_obj \u003d self._vnc_lib.floating_ip_read("},{"line_number":1767,"context_line":"                            id\u003dfip_back_ref[\u0027uuid\u0027])"},{"line_number":1768,"context_line":"                        ret_list.append(self._floatingip_vnc_to_neutron("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqK0%3D","line":1765,"updated":"2013-09-01 02:50:32.000000000","message":"This should be converted to a generator expression or list comprehension.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"1e7eadbb6c690bc7540596d7c92d37b356cd6eac","unresolved":false,"context_lines":[{"line_number":1762,"context_line":"                    fip_back_refs \u003d port_obj.get_floating_ip_back_refs()"},{"line_number":1763,"context_line":"                    if not fip_back_refs:"},{"line_number":1764,"context_line":"                        continue"},{"line_number":1765,"context_line":"                    for fip_back_ref in fip_back_refs:"},{"line_number":1766,"context_line":"                        fip_obj \u003d self._vnc_lib.floating_ip_read("},{"line_number":1767,"context_line":"                            id\u003dfip_back_ref[\u0027uuid\u0027])"},{"line_number":1768,"context_line":"                        ret_list.append(self._floatingip_vnc_to_neutron("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F7d8%3D","line":1765,"in_reply_to":"AAAASn%2F%2FqK0%3D","updated":"2013-10-08 21:34:24.000000000","message":"not changing this part as it will make it difficult to read the code","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":1762,"context_line":"                    fip_back_refs \u003d port_obj.get_floating_ip_back_refs()"},{"line_number":1763,"context_line":"                    if not fip_back_refs:"},{"line_number":1764,"context_line":"                        continue"},{"line_number":1765,"context_line":"                    for fip_back_ref in fip_back_refs:"},{"line_number":1766,"context_line":"                        fip_obj \u003d self._vnc_lib.floating_ip_read("},{"line_number":1767,"context_line":"                            id\u003dfip_back_ref[\u0027uuid\u0027])"},{"line_number":1768,"context_line":"                        ret_list.append(self._floatingip_vnc_to_neutron("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYag%3D","line":1765,"in_reply_to":"AAAASn%2F%2FqK0%3D","updated":"2013-10-07 16:59:22.000000000","message":"will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":1777,"context_line":"            fip_back_refs \u003d proj_obj.get_floating_ip_back_refs()"},{"line_number":1778,"context_line":"            if not fip_back_refs:"},{"line_number":1779,"context_line":"                continue"},{"line_number":1780,"context_line":"            for fip_back_ref in fip_back_refs:"},{"line_number":1781,"context_line":"                fip_obj \u003d self._vnc_lib.floating_ip_read("},{"line_number":1782,"context_line":"                    id\u003dfip_back_ref[\u0027uuid\u0027])"},{"line_number":1783,"context_line":"                ret_list.append(self._floatingip_vnc_to_neutron(fip_obj))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqLA%3D","line":1780,"updated":"2013-09-01 02:50:32.000000000","message":"This should be converted to a generator expression or list comprehension.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":1777,"context_line":"            fip_back_refs \u003d proj_obj.get_floating_ip_back_refs()"},{"line_number":1778,"context_line":"            if not fip_back_refs:"},{"line_number":1779,"context_line":"                continue"},{"line_number":1780,"context_line":"            for fip_back_ref in fip_back_refs:"},{"line_number":1781,"context_line":"                fip_obj \u003d self._vnc_lib.floating_ip_read("},{"line_number":1782,"context_line":"                    id\u003dfip_back_ref[\u0027uuid\u0027])"},{"line_number":1783,"context_line":"                ret_list.append(self._floatingip_vnc_to_neutron(fip_obj))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYaY%3D","line":1780,"in_reply_to":"AAAASn%2F%2FqLA%3D","updated":"2013-10-07 16:59:22.000000000","message":"will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":1855,"context_line":"    def port_read(self, port_id):"},{"line_number":1856,"context_line":"        try:"},{"line_number":1857,"context_line":"            # return self._db_cache[\u0027q_ports\u0027][port_id]"},{"line_number":1858,"context_line":"            raise KeyError"},{"line_number":1859,"context_line":"        except KeyError:"},{"line_number":1860,"context_line":"            pass"},{"line_number":1861,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqLE%3D","line":1858,"updated":"2013-09-01 02:50:32.000000000","message":"This does not make any sense.   1856-1860 is basically a big noop.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":1855,"context_line":"    def port_read(self, port_id):"},{"line_number":1856,"context_line":"        try:"},{"line_number":1857,"context_line":"            # return self._db_cache[\u0027q_ports\u0027][port_id]"},{"line_number":1858,"context_line":"            raise KeyError"},{"line_number":1859,"context_line":"        except KeyError:"},{"line_number":1860,"context_line":"            pass"},{"line_number":1861,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYwg%3D","line":1858,"in_reply_to":"AAAASn%2F%2FqLE%3D","updated":"2013-10-07 16:59:22.000000000","message":"will remove this block","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":1947,"context_line":"            elif \u0027tenant_id\u0027 in filters:"},{"line_number":1948,"context_line":"                all_project_ids \u003d filters.get(\u0027tenant_id\u0027)"},{"line_number":1949,"context_line":""},{"line_number":1950,"context_line":"            for proj_id in all_project_ids:"},{"line_number":1951,"context_line":"                proj_ports \u003d self._port_list_project(proj_id)"},{"line_number":1952,"context_line":"                for port in proj_ports:"},{"line_number":1953,"context_line":"                    try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqLQ%3D","line":1950,"updated":"2013-09-01 02:50:32.000000000","message":"This should be rewritten using generator expressions and list comprehension syntax","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":1947,"context_line":"            elif \u0027tenant_id\u0027 in filters:"},{"line_number":1948,"context_line":"                all_project_ids \u003d filters.get(\u0027tenant_id\u0027)"},{"line_number":1949,"context_line":""},{"line_number":1950,"context_line":"            for proj_id in all_project_ids:"},{"line_number":1951,"context_line":"                proj_ports \u003d self._port_list_project(proj_id)"},{"line_number":1952,"context_line":"                for port in proj_ports:"},{"line_number":1953,"context_line":"                    try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYaI%3D","line":1950,"in_reply_to":"AAAASn%2F%2FqLQ%3D","updated":"2013-10-07 16:59:22.000000000","message":"will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":1956,"context_line":"                        continue"},{"line_number":1957,"context_line":"                    ret_q_ports.append(port_info)"},{"line_number":1958,"context_line":""},{"line_number":1959,"context_line":"            for net_id in filters.get(\u0027network_id\u0027, []):"},{"line_number":1960,"context_line":"                net_ports \u003d self._port_list_network(net_id)"},{"line_number":1961,"context_line":"                for port in net_ports:"},{"line_number":1962,"context_line":"                    port_info \u003d self.port_read(port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqLM%3D","line":1959,"updated":"2013-09-01 02:50:32.000000000","message":"same comment as above","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":1956,"context_line":"                        continue"},{"line_number":1957,"context_line":"                    ret_q_ports.append(port_info)"},{"line_number":1958,"context_line":""},{"line_number":1959,"context_line":"            for net_id in filters.get(\u0027network_id\u0027, []):"},{"line_number":1960,"context_line":"                net_ports \u003d self._port_list_network(net_id)"},{"line_number":1961,"context_line":"                for port in net_ports:"},{"line_number":1962,"context_line":"                    port_info \u003d self.port_read(port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYaE%3D","line":1959,"in_reply_to":"AAAASn%2F%2FqLM%3D","updated":"2013-10-07 16:59:22.000000000","message":"will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":2005,"context_line":"        sg_uuid \u003d self._security_group_create(sg_obj)"},{"line_number":2006,"context_line":""},{"line_number":2007,"context_line":"        #allow all egress traffic"},{"line_number":2008,"context_line":"        def_rule \u003d {}"},{"line_number":2009,"context_line":"        def_rule[\u0027port_range_min\u0027] \u003d 0"},{"line_number":2010,"context_line":"        def_rule[\u0027port_range_max\u0027] \u003d 65535"},{"line_number":2011,"context_line":"        def_rule[\u0027direction\u0027] \u003d \u0027egress\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqLU%3D","line":2008,"updated":"2013-09-01 02:50:32.000000000","message":"You should init the dict with the default values in one step similar to earlier suggestion.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":2005,"context_line":"        sg_uuid \u003d self._security_group_create(sg_obj)"},{"line_number":2006,"context_line":""},{"line_number":2007,"context_line":"        #allow all egress traffic"},{"line_number":2008,"context_line":"        def_rule \u003d {}"},{"line_number":2009,"context_line":"        def_rule[\u0027port_range_min\u0027] \u003d 0"},{"line_number":2010,"context_line":"        def_rule[\u0027port_range_max\u0027] \u003d 65535"},{"line_number":2011,"context_line":"        def_rule[\u0027direction\u0027] \u003d \u0027egress\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYwc%3D","line":2008,"in_reply_to":"AAAASn%2F%2FqLU%3D","updated":"2013-10-07 16:59:22.000000000","message":"will change","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":2036,"context_line":"        all_sgs \u003d []  # all sgs in all projects"},{"line_number":2037,"context_line":"        if filters and \u0027tenant_id\u0027 in filters:"},{"line_number":2038,"context_line":"            project_ids \u003d filters[\u0027tenant_id\u0027]"},{"line_number":2039,"context_line":"            for p_id in project_ids:"},{"line_number":2040,"context_line":"                project_sgs \u003d self._security_group_list_project(p_id)"},{"line_number":2041,"context_line":"                all_sgs.append(project_sgs)"},{"line_number":2042,"context_line":"        elif filters and \u0027name\u0027 in filters:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqLY%3D","line":2039,"updated":"2013-09-01 02:50:32.000000000","message":"This should be converted into list comprehension.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":2036,"context_line":"        all_sgs \u003d []  # all sgs in all projects"},{"line_number":2037,"context_line":"        if filters and \u0027tenant_id\u0027 in filters:"},{"line_number":2038,"context_line":"            project_ids \u003d filters[\u0027tenant_id\u0027]"},{"line_number":2039,"context_line":"            for p_id in project_ids:"},{"line_number":2040,"context_line":"                project_sgs \u003d self._security_group_list_project(p_id)"},{"line_number":2041,"context_line":"                all_sgs.append(project_sgs)"},{"line_number":2042,"context_line":"        elif filters and \u0027name\u0027 in filters:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYZ0%3D","line":2039,"in_reply_to":"AAAASn%2F%2FqLY%3D","updated":"2013-10-07 16:59:22.000000000","message":"will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":2045,"context_line":"            all_sgs.append(project_sgs)"},{"line_number":2046,"context_line":"        else:  # no filters"},{"line_number":2047,"context_line":"            dom_projects \u003d self._project_list_domain(None)"},{"line_number":2048,"context_line":"            for project in dom_projects:"},{"line_number":2049,"context_line":"                proj_id \u003d project[\u0027uuid\u0027]"},{"line_number":2050,"context_line":"                project_sgs \u003d self._security_group_list_project(proj_id)"},{"line_number":2051,"context_line":"                all_sgs.append(project_sgs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqLc%3D","line":2048,"updated":"2013-09-01 02:50:32.000000000","message":"this should be converted into a list comprehension.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":2045,"context_line":"            all_sgs.append(project_sgs)"},{"line_number":2046,"context_line":"        else:  # no filters"},{"line_number":2047,"context_line":"            dom_projects \u003d self._project_list_domain(None)"},{"line_number":2048,"context_line":"            for project in dom_projects:"},{"line_number":2049,"context_line":"                proj_id \u003d project[\u0027uuid\u0027]"},{"line_number":2050,"context_line":"                project_sgs \u003d self._security_group_list_project(proj_id)"},{"line_number":2051,"context_line":"                all_sgs.append(project_sgs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYZw%3D","line":2048,"in_reply_to":"AAAASn%2F%2FqLc%3D","updated":"2013-10-07 16:59:22.000000000","message":"will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":2051,"context_line":"                all_sgs.append(project_sgs)"},{"line_number":2052,"context_line":""},{"line_number":2053,"context_line":"        # prune phase"},{"line_number":2054,"context_line":"        for project_sgs in all_sgs:"},{"line_number":2055,"context_line":"            for proj_sg in project_sgs:"},{"line_number":2056,"context_line":"                proj_sg_id \u003d proj_sg[\u0027uuid\u0027]"},{"line_number":2057,"context_line":"                if not self._filters_is_present(filters, \u0027id\u0027, proj_sg_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqLg%3D","line":2054,"updated":"2013-09-01 02:50:32.000000000","message":"This should be converted into a list comprehension.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"1e7eadbb6c690bc7540596d7c92d37b356cd6eac","unresolved":false,"context_lines":[{"line_number":2051,"context_line":"                all_sgs.append(project_sgs)"},{"line_number":2052,"context_line":""},{"line_number":2053,"context_line":"        # prune phase"},{"line_number":2054,"context_line":"        for project_sgs in all_sgs:"},{"line_number":2055,"context_line":"            for proj_sg in project_sgs:"},{"line_number":2056,"context_line":"                proj_sg_id \u003d proj_sg[\u0027uuid\u0027]"},{"line_number":2057,"context_line":"                if not self._filters_is_present(filters, \u0027id\u0027, proj_sg_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F7UM%3D","line":2054,"in_reply_to":"AAAAS3%2F%2FYZs%3D","updated":"2013-10-08 21:34:24.000000000","message":"this is a conditional list therefore would like to keep it as is, instead of using list comprehension","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":2051,"context_line":"                all_sgs.append(project_sgs)"},{"line_number":2052,"context_line":""},{"line_number":2053,"context_line":"        # prune phase"},{"line_number":2054,"context_line":"        for project_sgs in all_sgs:"},{"line_number":2055,"context_line":"            for proj_sg in project_sgs:"},{"line_number":2056,"context_line":"                proj_sg_id \u003d proj_sg[\u0027uuid\u0027]"},{"line_number":2057,"context_line":"                if not self._filters_is_present(filters, \u0027id\u0027, proj_sg_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYZs%3D","line":2054,"in_reply_to":"AAAASn%2F%2FqLg%3D","updated":"2013-10-07 16:59:22.000000000","message":"will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":2094,"context_line":"            if sgr_entries is None:"},{"line_number":2095,"context_line":"                return"},{"line_number":2096,"context_line":""},{"line_number":2097,"context_line":"            for sg_rule in sgr_entries.get_policy_rule():"},{"line_number":2098,"context_line":"                sg_info \u003d self._security_group_rule_vnc_to_neutron(sg_obj.uuid,"},{"line_number":2099,"context_line":"                                                                   sg_rule)"},{"line_number":2100,"context_line":"                sg_rules.append(sg_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqLk%3D","line":2097,"updated":"2013-09-01 02:50:32.000000000","message":"This should be a list comprehension.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":2094,"context_line":"            if sgr_entries is None:"},{"line_number":2095,"context_line":"                return"},{"line_number":2096,"context_line":""},{"line_number":2097,"context_line":"            for sg_rule in sgr_entries.get_policy_rule():"},{"line_number":2098,"context_line":"                sg_info \u003d self._security_group_rule_vnc_to_neutron(sg_obj.uuid,"},{"line_number":2099,"context_line":"                                                                   sg_rule)"},{"line_number":2100,"context_line":"                sg_rules.append(sg_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYZo%3D","line":2097,"in_reply_to":"AAAASn%2F%2FqLk%3D","updated":"2013-10-07 16:59:22.000000000","message":"will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":2110,"context_line":"        all_sgs \u003d []"},{"line_number":2111,"context_line":"        if filters and \u0027tenant_id\u0027 in filters:"},{"line_number":2112,"context_line":"            project_ids \u003d filters[\u0027tenant_id\u0027]"},{"line_number":2113,"context_line":"            for p_id in project_ids:"},{"line_number":2114,"context_line":"                project_sgs \u003d self._security_group_list_project(p_id)"},{"line_number":2115,"context_line":"                all_sgs.append(project_sgs)"},{"line_number":2116,"context_line":"        else:  # no filters"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqLs%3D","line":2113,"updated":"2013-09-01 02:50:32.000000000","message":"This should be a list comprehension.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":2110,"context_line":"        all_sgs \u003d []"},{"line_number":2111,"context_line":"        if filters and \u0027tenant_id\u0027 in filters:"},{"line_number":2112,"context_line":"            project_ids \u003d filters[\u0027tenant_id\u0027]"},{"line_number":2113,"context_line":"            for p_id in project_ids:"},{"line_number":2114,"context_line":"                project_sgs \u003d self._security_group_list_project(p_id)"},{"line_number":2115,"context_line":"                all_sgs.append(project_sgs)"},{"line_number":2116,"context_line":"        else:  # no filters"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYZk%3D","line":2113,"in_reply_to":"AAAASn%2F%2FqLs%3D","updated":"2013-10-07 16:59:22.000000000","message":"will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":2115,"context_line":"                all_sgs.append(project_sgs)"},{"line_number":2116,"context_line":"        else:  # no filters"},{"line_number":2117,"context_line":"            dom_projects \u003d self._project_list_domain(None)"},{"line_number":2118,"context_line":"            for project in dom_projects:"},{"line_number":2119,"context_line":"                proj_id \u003d project[\u0027uuid\u0027]"},{"line_number":2120,"context_line":"                project_sgs \u003d self._security_group_list_project(proj_id)"},{"line_number":2121,"context_line":"                all_sgs.append(project_sgs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqLo%3D","line":2118,"updated":"2013-09-01 02:50:32.000000000","message":"This should be a list comprehension.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":2115,"context_line":"                all_sgs.append(project_sgs)"},{"line_number":2116,"context_line":"        else:  # no filters"},{"line_number":2117,"context_line":"            dom_projects \u003d self._project_list_domain(None)"},{"line_number":2118,"context_line":"            for project in dom_projects:"},{"line_number":2119,"context_line":"                proj_id \u003d project[\u0027uuid\u0027]"},{"line_number":2120,"context_line":"                project_sgs \u003d self._security_group_list_project(proj_id)"},{"line_number":2121,"context_line":"                all_sgs.append(project_sgs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYZg%3D","line":2118,"in_reply_to":"AAAASn%2F%2FqLo%3D","updated":"2013-10-07 16:59:22.000000000","message":"will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":2121,"context_line":"                all_sgs.append(project_sgs)"},{"line_number":2122,"context_line":""},{"line_number":2123,"context_line":"        # prune phase"},{"line_number":2124,"context_line":"        for project_sgs in all_sgs:"},{"line_number":2125,"context_line":"            for proj_sg in project_sgs:"},{"line_number":2126,"context_line":"                proj_sg_id \u003d proj_sg[\u0027uuid\u0027]"},{"line_number":2127,"context_line":"                if not self._filters_is_present(filters, \u0027id\u0027, proj_sg_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqLw%3D","line":2124,"updated":"2013-09-01 02:50:32.000000000","message":"This should be a list comprehension:\n\nret_list.extend(\n   self.security_group_rules_read(proj_sg[\u0027uuid\u0027])\n   for proj_sg in project_sgs\n   if self._filters_is_present(filters, \u0027id\u0027, proj_sg[\u0027uuid\u0027])\n)","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":2121,"context_line":"                all_sgs.append(project_sgs)"},{"line_number":2122,"context_line":""},{"line_number":2123,"context_line":"        # prune phase"},{"line_number":2124,"context_line":"        for project_sgs in all_sgs:"},{"line_number":2125,"context_line":"            for proj_sg in project_sgs:"},{"line_number":2126,"context_line":"                proj_sg_id \u003d proj_sg[\u0027uuid\u0027]"},{"line_number":2127,"context_line":"                if not self._filters_is_present(filters, \u0027id\u0027, proj_sg_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYZc%3D","line":2124,"in_reply_to":"AAAASn%2F%2FqLw%3D","updated":"2013-10-07 16:59:22.000000000","message":"will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":2163,"context_line":"        all_rts \u003d []  # all rts in all projects"},{"line_number":2164,"context_line":"        if filters and \u0027tenant_id\u0027 in filters:"},{"line_number":2165,"context_line":"            project_ids \u003d filters[\u0027tenant_id\u0027]"},{"line_number":2166,"context_line":"            for p_id in project_ids:"},{"line_number":2167,"context_line":"                project_rts \u003d self._route_table_list_project(p_id)"},{"line_number":2168,"context_line":"                all_rts.append(project_rts)"},{"line_number":2169,"context_line":"        elif filters and \u0027name\u0027 in filters:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqL8%3D","line":2166,"updated":"2013-09-01 02:50:32.000000000","message":"You should use a list comprehension.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":2163,"context_line":"        all_rts \u003d []  # all rts in all projects"},{"line_number":2164,"context_line":"        if filters and \u0027tenant_id\u0027 in filters:"},{"line_number":2165,"context_line":"            project_ids \u003d filters[\u0027tenant_id\u0027]"},{"line_number":2166,"context_line":"            for p_id in project_ids:"},{"line_number":2167,"context_line":"                project_rts \u003d self._route_table_list_project(p_id)"},{"line_number":2168,"context_line":"                all_rts.append(project_rts)"},{"line_number":2169,"context_line":"        elif filters and \u0027name\u0027 in filters:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYZY%3D","line":2166,"in_reply_to":"AAAASn%2F%2FqL8%3D","updated":"2013-10-07 16:59:22.000000000","message":"will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":2169,"context_line":"        elif filters and \u0027name\u0027 in filters:"},{"line_number":2170,"context_line":"            p_id \u003d str(uuid.UUID(context.tenant))"},{"line_number":2171,"context_line":"            project_rts \u003d self._route_table_list_project(p_id)"},{"line_number":2172,"context_line":"            all_rts.append(project_rts)"},{"line_number":2173,"context_line":"        else:  # no filters"},{"line_number":2174,"context_line":"            dom_projects \u003d self._project_list_domain(None)"},{"line_number":2175,"context_line":"            for project in dom_projects:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqL4%3D","line":2172,"updated":"2013-09-01 02:50:32.000000000","message":"same as above","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":2169,"context_line":"        elif filters and \u0027name\u0027 in filters:"},{"line_number":2170,"context_line":"            p_id \u003d str(uuid.UUID(context.tenant))"},{"line_number":2171,"context_line":"            project_rts \u003d self._route_table_list_project(p_id)"},{"line_number":2172,"context_line":"            all_rts.append(project_rts)"},{"line_number":2173,"context_line":"        else:  # no filters"},{"line_number":2174,"context_line":"            dom_projects \u003d self._project_list_domain(None)"},{"line_number":2175,"context_line":"            for project in dom_projects:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYZU%3D","line":2172,"in_reply_to":"AAAASn%2F%2FqL4%3D","updated":"2013-10-07 16:59:22.000000000","message":"will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":2175,"context_line":"            for project in dom_projects:"},{"line_number":2176,"context_line":"                proj_id \u003d project[\u0027uuid\u0027]"},{"line_number":2177,"context_line":"                project_rts \u003d self._route_table_list_project(proj_id)"},{"line_number":2178,"context_line":"                all_rts.append(project_rts)"},{"line_number":2179,"context_line":""},{"line_number":2180,"context_line":"        # prune phase"},{"line_number":2181,"context_line":"        for project_rts in all_rts:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqL0%3D","line":2178,"updated":"2013-09-01 02:50:32.000000000","message":"same as above","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":2175,"context_line":"            for project in dom_projects:"},{"line_number":2176,"context_line":"                proj_id \u003d project[\u0027uuid\u0027]"},{"line_number":2177,"context_line":"                project_rts \u003d self._route_table_list_project(proj_id)"},{"line_number":2178,"context_line":"                all_rts.append(project_rts)"},{"line_number":2179,"context_line":""},{"line_number":2180,"context_line":"        # prune phase"},{"line_number":2181,"context_line":"        for project_rts in all_rts:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYZQ%3D","line":2178,"in_reply_to":"AAAASn%2F%2FqL0%3D","updated":"2013-10-07 16:59:22.000000000","message":"will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":2215,"context_line":"        # collect phase"},{"line_number":2216,"context_line":"        all_sis \u003d []  # all sis in all projects"},{"line_number":2217,"context_line":"        if filters and \u0027tenant_id\u0027 in filters:"},{"line_number":2218,"context_line":"            project_ids \u003d filters[\u0027tenant_id\u0027]"},{"line_number":2219,"context_line":"            for p_id in project_ids:"},{"line_number":2220,"context_line":"                project_sis \u003d self._svc_instance_list_project(p_id)"},{"line_number":2221,"context_line":"                all_sis.append(project_sis)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqMI%3D","line":2218,"updated":"2013-09-01 02:50:32.000000000","message":"You should use a list comprehension:\n\nall_sis \u003d [\n    self._svc_instance_list_project(p_id) for p_id in project_ids\n]","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":2215,"context_line":"        # collect phase"},{"line_number":2216,"context_line":"        all_sis \u003d []  # all sis in all projects"},{"line_number":2217,"context_line":"        if filters and \u0027tenant_id\u0027 in filters:"},{"line_number":2218,"context_line":"            project_ids \u003d filters[\u0027tenant_id\u0027]"},{"line_number":2219,"context_line":"            for p_id in project_ids:"},{"line_number":2220,"context_line":"                project_sis \u003d self._svc_instance_list_project(p_id)"},{"line_number":2221,"context_line":"                all_sis.append(project_sis)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYZM%3D","line":2218,"in_reply_to":"AAAASn%2F%2FqMI%3D","updated":"2013-10-07 16:59:22.000000000","message":"will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":2221,"context_line":"                all_sis.append(project_sis)"},{"line_number":2222,"context_line":"        elif filters and \u0027name\u0027 in filters:"},{"line_number":2223,"context_line":"            p_id \u003d str(uuid.UUID(context.tenant))"},{"line_number":2224,"context_line":"            project_sis \u003d self._svc_instance_list_project(p_id)"},{"line_number":2225,"context_line":"            all_sis.append(project_sis)"},{"line_number":2226,"context_line":"        else:  # no filters"},{"line_number":2227,"context_line":"            dom_projects \u003d self._project_list_domain(None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqME%3D","line":2224,"updated":"2013-09-01 02:50:32.000000000","message":"list comprehension should be used here","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":2221,"context_line":"                all_sis.append(project_sis)"},{"line_number":2222,"context_line":"        elif filters and \u0027name\u0027 in filters:"},{"line_number":2223,"context_line":"            p_id \u003d str(uuid.UUID(context.tenant))"},{"line_number":2224,"context_line":"            project_sis \u003d self._svc_instance_list_project(p_id)"},{"line_number":2225,"context_line":"            all_sis.append(project_sis)"},{"line_number":2226,"context_line":"        else:  # no filters"},{"line_number":2227,"context_line":"            dom_projects \u003d self._project_list_domain(None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYZI%3D","line":2224,"in_reply_to":"AAAASn%2F%2FqME%3D","updated":"2013-10-07 16:59:22.000000000","message":"will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":2228,"context_line":"            for project in dom_projects:"},{"line_number":2229,"context_line":"                proj_id \u003d project[\u0027uuid\u0027]"},{"line_number":2230,"context_line":"                project_sis \u003d self._svc_instance_list_project(proj_id)"},{"line_number":2231,"context_line":"                all_sis.append(project_sis)"},{"line_number":2232,"context_line":""},{"line_number":2233,"context_line":"        # prune phase"},{"line_number":2234,"context_line":"        for project_sis in all_sis:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqMA%3D","line":2231,"updated":"2013-09-01 02:50:32.000000000","message":"same as above","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":2228,"context_line":"            for project in dom_projects:"},{"line_number":2229,"context_line":"                proj_id \u003d project[\u0027uuid\u0027]"},{"line_number":2230,"context_line":"                project_sis \u003d self._svc_instance_list_project(proj_id)"},{"line_number":2231,"context_line":"                all_sis.append(project_sis)"},{"line_number":2232,"context_line":""},{"line_number":2233,"context_line":"        # prune phase"},{"line_number":2234,"context_line":"        for project_sis in all_sis:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYZE%3D","line":2231,"in_reply_to":"AAAASn%2F%2FqMA%3D","updated":"2013-10-07 16:59:22.000000000","message":"will do","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self._api_srvr_ip \u003d api_srvr_ip"},{"line_number":56,"context_line":"        self._api_srvr_port \u003d api_srvr_port"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        self._db_cache \u003d {}"},{"line_number":59,"context_line":"        self._db_cache[\u0027q_networks\u0027] \u003d {}"},{"line_number":60,"context_line":"        self._db_cache[\u0027q_subnets\u0027] \u003d {}"},{"line_number":61,"context_line":"        self._db_cache[\u0027q_subnet_maps\u0027] \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FtyE%3D","line":58,"updated":"2013-10-10 20:28:17.000000000","message":"could save a bunch of symbols by writing:\n self._db_cache \u003d {\n     \u0027q_networks\u0027: {},\n     \u0027q_subnets\u0027: {},\n ...\n }","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self._api_srvr_ip \u003d api_srvr_ip"},{"line_number":56,"context_line":"        self._api_srvr_port \u003d api_srvr_port"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        self._db_cache \u003d {}"},{"line_number":59,"context_line":"        self._db_cache[\u0027q_networks\u0027] \u003d {}"},{"line_number":60,"context_line":"        self._db_cache[\u0027q_subnets\u0027] \u003d {}"},{"line_number":61,"context_line":"        self._db_cache[\u0027q_subnet_maps\u0027] \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Fta4%3D","line":58,"in_reply_to":"AAAATH%2F%2FtyE%3D","updated":"2013-10-10 22:07:45.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                    admin_tenant_name, api_srvr_ip,"},{"line_number":83,"context_line":"                    api_srvr_port, \u0027/\u0027, user_info\u003duser_info)"},{"line_number":84,"context_line":"                connected \u003d True"},{"line_number":85,"context_line":"            except requests.exceptions.RequestException:"},{"line_number":86,"context_line":"                time.sleep(3)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # changes \u0027net_fq_name_str pfx/len\u0027 key to \u0027net_id pfx/len\u0027 key"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Ftx8%3D","line":85,"updated":"2013-10-10 20:28:17.000000000","message":"There should be a limited time to wait for api-server which is better to be configurable","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                    admin_tenant_name, api_srvr_ip,"},{"line_number":83,"context_line":"                    api_srvr_port, \u0027/\u0027, user_info\u003duser_info)"},{"line_number":84,"context_line":"                connected \u003d True"},{"line_number":85,"context_line":"            except requests.exceptions.RequestException:"},{"line_number":86,"context_line":"                time.sleep(3)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # changes \u0027net_fq_name_str pfx/len\u0027 key to \u0027net_id pfx/len\u0027 key"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FtSg%3D","line":85,"in_reply_to":"AAAATH%2F%2Ftx8%3D","updated":"2013-10-10 22:07:45.000000000","message":"We want to keep trying as in distributed system not sure at what time api-server would come. Is there a concern?","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                try:"},{"line_number":103,"context_line":"                    net_obj \u003d self._virtual_network_read(fq_name\u003dnet_fq_name)"},{"line_number":104,"context_line":"                except vnc_exc.NoIdError:"},{"line_number":105,"context_line":"                    LOG.warning(_(\"No network: %r\",  net_fq_name))"},{"line_number":106,"context_line":"                    self._vnc_lib.kv_delete(subnet_id)"},{"line_number":107,"context_line":"                    continue"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Ftxw%3D","line":105,"updated":"2013-10-10 20:28:17.000000000","message":"This form is not correct. The correct one is:\n LOG.warning(_(\"No network: %r\"),  net_fq_name)","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                try:"},{"line_number":103,"context_line":"                    net_obj \u003d self._virtual_network_read(fq_name\u003dnet_fq_name)"},{"line_number":104,"context_line":"                except vnc_exc.NoIdError:"},{"line_number":105,"context_line":"                    LOG.warning(_(\"No network: %r\",  net_fq_name))"},{"line_number":106,"context_line":"                    self._vnc_lib.kv_delete(subnet_id)"},{"line_number":107,"context_line":"                    continue"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FthI%3D","line":105,"in_reply_to":"AAAATH%2F%2Ftxw%3D","updated":"2013-10-10 22:07:45.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                try:"},{"line_number":124,"context_line":"                    net_obj \u003d self._virtual_network_read(fq_name\u003dnet_fq_name)"},{"line_number":125,"context_line":"                except vnc_exc.NoIdError:"},{"line_number":126,"context_line":"                    LOG.warning(_(\"No network: %r\",  net_fq_name))"},{"line_number":127,"context_line":"                    continue"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"                new_subnet_key \u003d \u0027%s %s\u0027 % (net_obj.uuid, key.split()[1])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FtwQ%3D","line":126,"updated":"2013-10-10 20:28:17.000000000","message":"same as above","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                try:"},{"line_number":124,"context_line":"                    net_obj \u003d self._virtual_network_read(fq_name\u003dnet_fq_name)"},{"line_number":125,"context_line":"                except vnc_exc.NoIdError:"},{"line_number":126,"context_line":"                    LOG.warning(_(\"No network: %r\",  net_fq_name))"},{"line_number":127,"context_line":"                    continue"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"                new_subnet_key \u003d \u0027%s %s\u0027 % (net_obj.uuid, key.split()[1])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Ftgk%3D","line":126,"in_reply_to":"AAAATH%2F%2FtwQ%3D","updated":"2013-10-10 22:07:45.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                self._set_obj_tenant_id(obj_uuid, tenant_id)"},{"line_number":216,"context_line":"                return tenant_id"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"            return None"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def _set_obj_tenant_id(self, obj_uuid, tenant_uuid):"},{"line_number":221,"context_line":"        self._db_cache[\u0027q_obj_to_tenant\u0027][obj_uuid] \u003d tenant_uuid"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Ftvw%3D","line":218,"updated":"2013-10-10 20:28:17.000000000","message":"could omit this line as method returns None, if not specified otherwise","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                self._set_obj_tenant_id(obj_uuid, tenant_id)"},{"line_number":216,"context_line":"                return tenant_id"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"            return None"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def _set_obj_tenant_id(self, obj_uuid, tenant_uuid):"},{"line_number":221,"context_line":"        self._db_cache[\u0027q_obj_to_tenant\u0027][obj_uuid] \u003d tenant_uuid"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FtgI%3D","line":218,"in_reply_to":"AAAATH%2F%2Ftvw%3D","updated":"2013-10-10 22:07:45.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        sg_vnc.set_security_group_entries(rules)"},{"line_number":265,"context_line":"        self._vnc_lib.security_group_update(sg_vnc)"},{"line_number":266,"context_line":"        return"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def _security_group_rule_find(self, sgr_id):"},{"line_number":269,"context_line":"        dom_projects \u003d self._project_list_domain(None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Ftu4%3D","line":266,"updated":"2013-10-10 20:28:17.000000000","message":"return statement unnecessary","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        sg_vnc.set_security_group_entries(rules)"},{"line_number":265,"context_line":"        self._vnc_lib.security_group_update(sg_vnc)"},{"line_number":266,"context_line":"        return"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def _security_group_rule_find(self, sgr_id):"},{"line_number":269,"context_line":"        dom_projects \u003d self._project_list_domain(None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Ftf8%3D","line":266,"in_reply_to":"AAAATH%2F%2Ftu4%3D","updated":"2013-10-10 22:07:45.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":288,"context_line":"        rules.get_policy_rule().remove(sg_rule)"},{"line_number":289,"context_line":"        sg_obj.set_security_group_entries(rules)"},{"line_number":290,"context_line":"        self._vnc_lib.security_group_update(sg_obj)"},{"line_number":291,"context_line":"        return"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    def _security_group_create(self, sg_obj):"},{"line_number":294,"context_line":"        sg_uuid \u003d self._vnc_lib.security_group_create(sg_obj)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Ftu0%3D","line":291,"updated":"2013-10-10 20:28:17.000000000","message":"return statement unnecessary","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":288,"context_line":"        rules.get_policy_rule().remove(sg_rule)"},{"line_number":289,"context_line":"        sg_obj.set_security_group_entries(rules)"},{"line_number":290,"context_line":"        self._vnc_lib.security_group_update(sg_obj)"},{"line_number":291,"context_line":"        return"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    def _security_group_create(self, sg_obj):"},{"line_number":294,"context_line":"        sg_uuid \u003d self._vnc_lib.security_group_create(sg_obj)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Ftf4%3D","line":291,"in_reply_to":"AAAATH%2F%2Ftu0%3D","updated":"2013-10-10 22:07:45.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":489,"context_line":"        try:"},{"line_number":490,"context_line":"            project_uuid \u003d str(uuid.UUID(project_id))"},{"line_number":491,"context_line":"        except Exception:"},{"line_number":492,"context_line":"            print \"Error in converting uuid %s\" % (project_id)"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"        resp_str \u003d self._vnc_lib.virtual_networks_list(parent_id\u003dproject_uuid)"},{"line_number":495,"context_line":"        resp_dict \u003d json.loads(resp_str)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FtuA%3D","line":492,"updated":"2013-10-10 20:28:17.000000000","message":"This should be a log statement, not print.","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":489,"context_line":"        try:"},{"line_number":490,"context_line":"            project_uuid \u003d str(uuid.UUID(project_id))"},{"line_number":491,"context_line":"        except Exception:"},{"line_number":492,"context_line":"            print \"Error in converting uuid %s\" % (project_id)"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"        resp_str \u003d self._vnc_lib.virtual_networks_list(parent_id\u003dproject_uuid)"},{"line_number":495,"context_line":"        resp_dict \u003d json.loads(resp_str)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FteM%3D","line":492,"in_reply_to":"AAAATH%2F%2FtuA%3D","updated":"2013-10-10 22:07:45.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        try:"},{"line_number":501,"context_line":"            project_uuid \u003d str(uuid.UUID(project_id))"},{"line_number":502,"context_line":"        except Exception:"},{"line_number":503,"context_line":"            print \"Error in converting uuid %s\" % (project_id)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        resp_str \u003d self._vnc_lib.network_ipams_list(parent_id\u003dproject_uuid)"},{"line_number":506,"context_line":"        resp_dict \u003d json.loads(resp_str)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Ftt0%3D","line":503,"updated":"2013-10-10 20:28:17.000000000","message":"same as above","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        try:"},{"line_number":501,"context_line":"            project_uuid \u003d str(uuid.UUID(project_id))"},{"line_number":502,"context_line":"        except Exception:"},{"line_number":503,"context_line":"            print \"Error in converting uuid %s\" % (project_id)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        resp_str \u003d self._vnc_lib.network_ipams_list(parent_id\u003dproject_uuid)"},{"line_number":506,"context_line":"        resp_dict \u003d json.loads(resp_str)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FteI%3D","line":503,"in_reply_to":"AAAATH%2F%2Ftt0%3D","updated":"2013-10-10 22:07:45.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":511,"context_line":"        try:"},{"line_number":512,"context_line":"            project_uuid \u003d str(uuid.UUID(project_id))"},{"line_number":513,"context_line":"        except Exception:"},{"line_number":514,"context_line":"            print \"Error in converting uuid %s\" % (project_id)"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        self._ensure_default_security_group_exists(project_uuid)"},{"line_number":517,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Fttw%3D","line":514,"updated":"2013-10-10 20:28:17.000000000","message":"same as above","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":511,"context_line":"        try:"},{"line_number":512,"context_line":"            project_uuid \u003d str(uuid.UUID(project_id))"},{"line_number":513,"context_line":"        except Exception:"},{"line_number":514,"context_line":"            print \"Error in converting uuid %s\" % (project_id)"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        self._ensure_default_security_group_exists(project_uuid)"},{"line_number":517,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FteA%3D","line":514,"in_reply_to":"AAAATH%2F%2Fttw%3D","updated":"2013-10-10 22:07:45.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":524,"context_line":"        try:"},{"line_number":525,"context_line":"            sg_uuid \u003d str(uuid.UUID(sg_id))"},{"line_number":526,"context_line":"        except Exception:"},{"line_number":527,"context_line":"            print \"Error in converting SG uuid %s\" % (sg_id)"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        resp_str \u003d self._vnc_lib.security_groups_list(parent_id\u003dsg_uuid)"},{"line_number":530,"context_line":"        resp_dict \u003d json.loads(resp_str)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Ftts%3D","line":527,"updated":"2013-10-10 20:28:17.000000000","message":"same above","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":524,"context_line":"        try:"},{"line_number":525,"context_line":"            sg_uuid \u003d str(uuid.UUID(sg_id))"},{"line_number":526,"context_line":"        except Exception:"},{"line_number":527,"context_line":"            print \"Error in converting SG uuid %s\" % (sg_id)"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        resp_str \u003d self._vnc_lib.security_groups_list(parent_id\u003dsg_uuid)"},{"line_number":530,"context_line":"        resp_dict \u003d json.loads(resp_str)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Ftd4%3D","line":527,"in_reply_to":"AAAATH%2F%2Ftts%3D","updated":"2013-10-10 22:07:45.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":535,"context_line":"        try:"},{"line_number":536,"context_line":"            project_uuid \u003d str(uuid.UUID(project_id))"},{"line_number":537,"context_line":"        except Exception:"},{"line_number":538,"context_line":"            print \"Error in converting uuid %s\" % (project_id)"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        resp_str \u003d self._vnc_lib.route_tables_list(parent_id\u003dproject_uuid)"},{"line_number":541,"context_line":"        resp_dict \u003d json.loads(resp_str)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Fttk%3D","line":538,"updated":"2013-10-10 20:28:17.000000000","message":"same above","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":535,"context_line":"        try:"},{"line_number":536,"context_line":"            project_uuid \u003d str(uuid.UUID(project_id))"},{"line_number":537,"context_line":"        except Exception:"},{"line_number":538,"context_line":"            print \"Error in converting uuid %s\" % (project_id)"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        resp_str \u003d self._vnc_lib.route_tables_list(parent_id\u003dproject_uuid)"},{"line_number":541,"context_line":"        resp_dict \u003d json.loads(resp_str)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Ftdo%3D","line":538,"in_reply_to":"AAAATH%2F%2Fttk%3D","updated":"2013-10-10 22:07:45.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":546,"context_line":"        try:"},{"line_number":547,"context_line":"            project_uuid \u003d str(uuid.UUID(project_id))"},{"line_number":548,"context_line":"        except Exception:"},{"line_number":549,"context_line":"            print \"Error in converting uuid %s\" % (project_id)"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"        resp_str \u003d self._vnc_lib.service_instances_list(parent_id\u003dproject_uuid)"},{"line_number":552,"context_line":"        resp_dict \u003d json.loads(resp_str)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Fttg%3D","line":549,"updated":"2013-10-10 20:28:17.000000000","message":"same above","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":546,"context_line":"        try:"},{"line_number":547,"context_line":"            project_uuid \u003d str(uuid.UUID(project_id))"},{"line_number":548,"context_line":"        except Exception:"},{"line_number":549,"context_line":"            print \"Error in converting uuid %s\" % (project_id)"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"        resp_str \u003d self._vnc_lib.service_instances_list(parent_id\u003dproject_uuid)"},{"line_number":552,"context_line":"        resp_dict \u003d json.loads(resp_str)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Ftdk%3D","line":549,"in_reply_to":"AAAATH%2F%2Fttg%3D","updated":"2013-10-10 22:07:45.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        try:"},{"line_number":558,"context_line":"            project_uuid \u003d str(uuid.UUID(project_id))"},{"line_number":559,"context_line":"        except Exception:"},{"line_number":560,"context_line":"            print \"Error in converting uuid %s\" % (project_id)"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"        resp_str \u003d self._vnc_lib.network_policys_list(parent_id\u003dproject_uuid)"},{"line_number":563,"context_line":"        resp_dict \u003d json.loads(resp_str)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Fttc%3D","line":560,"updated":"2013-10-10 20:28:17.000000000","message":"same above","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        try:"},{"line_number":558,"context_line":"            project_uuid \u003d str(uuid.UUID(project_id))"},{"line_number":559,"context_line":"        except Exception:"},{"line_number":560,"context_line":"            print \"Error in converting uuid %s\" % (project_id)"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"        resp_str \u003d self._vnc_lib.network_policys_list(parent_id\u003dproject_uuid)"},{"line_number":563,"context_line":"        resp_dict \u003d json.loads(resp_str)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FtdU%3D","line":560,"in_reply_to":"AAAATH%2F%2Fttc%3D","updated":"2013-10-10 22:07:45.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":607,"context_line":""},{"line_number":608,"context_line":"        port_back_refs \u003d net_obj.get_virtual_machine_interface_back_refs()"},{"line_number":609,"context_line":"        if port_back_refs:"},{"line_number":610,"context_line":"            for port_back_ref in port_back_refs:"},{"line_number":611,"context_line":"                ret_list.append({\u0027id\u0027: port_back_ref[\u0027uuid\u0027]})"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        return ret_list"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Ftso%3D","line":610,"updated":"2013-10-10 20:28:17.000000000","message":"nit: might use list comprehension here","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":607,"context_line":""},{"line_number":608,"context_line":"        port_back_refs \u003d net_obj.get_virtual_machine_interface_back_refs()"},{"line_number":609,"context_line":"        if port_back_refs:"},{"line_number":610,"context_line":"            for port_back_ref in port_back_refs:"},{"line_number":611,"context_line":"                ret_list.append({\u0027id\u0027: port_back_ref[\u0027uuid\u0027]})"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        return ret_list"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FtZM%3D","line":610,"in_reply_to":"AAAATH%2F%2Ftso%3D","updated":"2013-10-10 22:07:45.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        if filters:"},{"line_number":635,"context_line":"            if key_name in filters:"},{"line_number":636,"context_line":"                try:"},{"line_number":637,"context_line":"                    if (\u0027shared\u0027 in filters and"},{"line_number":638,"context_line":"                            filters[\u0027shared\u0027][0] is True):"},{"line_number":639,"context_line":"                        # yuck, q-api has shared as list always of 1 elem"},{"line_number":640,"context_line":"                        return False  # no shared-resource support"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FtsM%3D","line":637,"updated":"2013-10-10 20:28:17.000000000","message":"in L635 you\u0027ve checked for key_name, but not using it in L637-642. Is it intended?","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        if filters:"},{"line_number":635,"context_line":"            if key_name in filters:"},{"line_number":636,"context_line":"                try:"},{"line_number":637,"context_line":"                    if (\u0027shared\u0027 in filters and"},{"line_number":638,"context_line":"                            filters[\u0027shared\u0027][0] is True):"},{"line_number":639,"context_line":"                        # yuck, q-api has shared as list always of 1 elem"},{"line_number":640,"context_line":"                        return False  # no shared-resource support"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FtYA%3D","line":637,"in_reply_to":"AAAATH%2F%2FtsM%3D","updated":"2013-10-10 22:07:45.000000000","message":"yes","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":635,"context_line":"            if key_name in filters:"},{"line_number":636,"context_line":"                try:"},{"line_number":637,"context_line":"                    if (\u0027shared\u0027 in filters and"},{"line_number":638,"context_line":"                            filters[\u0027shared\u0027][0] is True):"},{"line_number":639,"context_line":"                        # yuck, q-api has shared as list always of 1 elem"},{"line_number":640,"context_line":"                        return False  # no shared-resource support"},{"line_number":641,"context_line":"                except ValueError:  # not in requested list"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Ftr8%3D","line":638,"updated":"2013-10-10 20:28:17.000000000","message":"it\u0027s more readable if written:\n if (\u0027shared\u0027 in filters and filters[\u0027shared\u0027][0]):\nis filters[\u0027shared\u0027][0] a boolean value?","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"21774f009bd328d157e12d39218def8e94e71395","unresolved":false,"context_lines":[{"line_number":635,"context_line":"            if key_name in filters:"},{"line_number":636,"context_line":"                try:"},{"line_number":637,"context_line":"                    if (\u0027shared\u0027 in filters and"},{"line_number":638,"context_line":"                            filters[\u0027shared\u0027][0] is True):"},{"line_number":639,"context_line":"                        # yuck, q-api has shared as list always of 1 elem"},{"line_number":640,"context_line":"                        return False  # no shared-resource support"},{"line_number":641,"context_line":"                except ValueError:  # not in requested list"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FtPA%3D","line":638,"in_reply_to":"AAAATH%2F%2Ftr8%3D","updated":"2013-10-10 22:26:51.000000000","message":"yes it is boolean","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":641,"context_line":"                except ValueError:  # not in requested list"},{"line_number":642,"context_line":"                    return False"},{"line_number":643,"context_line":"            elif len(filters.keys()) \u003d\u003d 1:"},{"line_number":644,"context_line":"                shared_val \u003d filters.get(\u0027shared\u0027, None)"},{"line_number":645,"context_line":"                if shared_val and shared_val[0] is True:"},{"line_number":646,"context_line":"                    return False"},{"line_number":647,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FtsE%3D","line":644,"updated":"2013-10-10 20:28:17.000000000","message":"None parameter is unnecessary because it is default.","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"21774f009bd328d157e12d39218def8e94e71395","unresolved":false,"context_lines":[{"line_number":641,"context_line":"                except ValueError:  # not in requested list"},{"line_number":642,"context_line":"                    return False"},{"line_number":643,"context_line":"            elif len(filters.keys()) \u003d\u003d 1:"},{"line_number":644,"context_line":"                shared_val \u003d filters.get(\u0027shared\u0027, None)"},{"line_number":645,"context_line":"                if shared_val and shared_val[0] is True:"},{"line_number":646,"context_line":"                    return False"},{"line_number":647,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FtO0%3D","line":644,"in_reply_to":"AAAATH%2F%2FtsE%3D","updated":"2013-10-10 22:26:51.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":642,"context_line":"                    return False"},{"line_number":643,"context_line":"            elif len(filters.keys()) \u003d\u003d 1:"},{"line_number":644,"context_line":"                shared_val \u003d filters.get(\u0027shared\u0027, None)"},{"line_number":645,"context_line":"                if shared_val and shared_val[0] is True:"},{"line_number":646,"context_line":"                    return False"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Ftrs%3D","line":645,"updated":"2013-10-10 20:28:17.000000000","message":"it\u0027s more readable if written:\n if shared_val and shared_val[0]:","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":642,"context_line":"                    return False"},{"line_number":643,"context_line":"            elif len(filters.keys()) \u003d\u003d 1:"},{"line_number":644,"context_line":"                shared_val \u003d filters.get(\u0027shared\u0027, None)"},{"line_number":645,"context_line":"                if shared_val and shared_val[0] is True:"},{"line_number":646,"context_line":"                    return False"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FtXY%3D","line":645,"in_reply_to":"AAAATH%2F%2Ftrs%3D","updated":"2013-10-10 22:07:45.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":692,"context_line":"        try:"},{"line_number":693,"context_line":"            del self._db_cache[\u0027q_subnet_maps\u0027][subnet_id]"},{"line_number":694,"context_line":"            del self._db_cache[\u0027q_subnet_maps\u0027][subnet_key]"},{"line_number":695,"context_line":"        except KeyError:"},{"line_number":696,"context_line":"            pass"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"    def _subnet_vnc_get_key(self, subnet_vnc, net_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Ftrk%3D","line":695,"updated":"2013-10-10 20:28:17.000000000","message":"shouldn\u0027t it be caught for each del operation separately?","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"21774f009bd328d157e12d39218def8e94e71395","unresolved":false,"context_lines":[{"line_number":692,"context_line":"        try:"},{"line_number":693,"context_line":"            del self._db_cache[\u0027q_subnet_maps\u0027][subnet_id]"},{"line_number":694,"context_line":"            del self._db_cache[\u0027q_subnet_maps\u0027][subnet_key]"},{"line_number":695,"context_line":"        except KeyError:"},{"line_number":696,"context_line":"            pass"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"    def _subnet_vnc_get_key(self, subnet_vnc, net_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FtOM%3D","line":695,"in_reply_to":"AAAATH%2F%2Ftrk%3D","updated":"2013-10-10 22:26:51.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":705,"context_line":"        try:"},{"line_number":706,"context_line":"            net_obj \u003d self._virtual_network_read(net_id\u003dnet_uuid)"},{"line_number":707,"context_line":"        except vnc_exc.NoIdError:"},{"line_number":708,"context_line":"            return None"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"        ipam_refs \u003d net_obj.get_network_ipam_refs()"},{"line_number":711,"context_line":"        if not ipam_refs:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Ftrg%3D","line":708,"updated":"2013-10-10 20:28:17.000000000","message":"return None is unnecessary. Could have just use \u0027return\u0027 statement in this method","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":705,"context_line":"        try:"},{"line_number":706,"context_line":"            net_obj \u003d self._virtual_network_read(net_id\u003dnet_uuid)"},{"line_number":707,"context_line":"        except vnc_exc.NoIdError:"},{"line_number":708,"context_line":"            return None"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"        ipam_refs \u003d net_obj.get_network_ipam_refs()"},{"line_number":711,"context_line":"        if not ipam_refs:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Ftco%3D","line":708,"in_reply_to":"AAAATH%2F%2Ftrg%3D","updated":"2013-10-10 22:07:45.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":736,"context_line":"                            key\u003dsubnet_key)"},{"line_number":737,"context_line":"                        return subnet_id"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"        return None"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"    # Conversion routines between VNC and Neutron objects"},{"line_number":742,"context_line":"    def _svc_instance_neutron_to_vnc(self, si_q, operator):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Ftrc%3D","line":739,"updated":"2013-10-10 20:28:17.000000000","message":"unnecessary statement","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":736,"context_line":"                            key\u003dsubnet_key)"},{"line_number":737,"context_line":"                        return subnet_id"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"        return None"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"    # Conversion routines between VNC and Neutron objects"},{"line_number":742,"context_line":"    def _svc_instance_neutron_to_vnc(self, si_q, operator):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FtcQ%3D","line":739,"in_reply_to":"AAAATH%2F%2Ftrc%3D","updated":"2013-10-10 22:07:45.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":827,"context_line":"        sg_q_dict[\u0027rules\u0027] \u003d []"},{"line_number":828,"context_line":"        rule_list \u003d self.security_group_rules_read(sg_obj.uuid)"},{"line_number":829,"context_line":"        if rule_list:"},{"line_number":830,"context_line":"            for rule in rule_list:"},{"line_number":831,"context_line":"                sg_q_dict[\u0027rules\u0027].append(rule[\u0027q_api_data\u0027])"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"        return {\u0027q_api_data\u0027: sg_q_dict,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FtrU%3D","line":830,"updated":"2013-10-10 20:28:17.000000000","message":"nit: might use list comprehension here","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":827,"context_line":"        sg_q_dict[\u0027rules\u0027] \u003d []"},{"line_number":828,"context_line":"        rule_list \u003d self.security_group_rules_read(sg_obj.uuid)"},{"line_number":829,"context_line":"        if rule_list:"},{"line_number":830,"context_line":"            for rule in rule_list:"},{"line_number":831,"context_line":"                sg_q_dict[\u0027rules\u0027].append(rule[\u0027q_api_data\u0027])"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"        return {\u0027q_api_data\u0027: sg_q_dict,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FtUQ%3D","line":830,"in_reply_to":"AAAATH%2F%2FtrU%3D","updated":"2013-10-10 22:07:45.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":1258,"context_line":""},{"line_number":1259,"context_line":"            #proj_id \u003d self._get_obj_tenant_id(\u0027port\u0027, port_obj.uuid)"},{"line_number":1260,"context_line":"            proj_id \u003d None"},{"line_number":1261,"context_line":"            if not proj_id:"},{"line_number":1262,"context_line":"                # not in cache, get by reading VN obj, and populate cache"},{"line_number":1263,"context_line":"                net_obj \u003d self._virtual_network_read(net_id\u003dnet_id)"},{"line_number":1264,"context_line":"                proj_id \u003d net_obj.parent_uuid.replace(\u0027-\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Ftp4%3D","line":1261,"updated":"2013-10-10 20:28:17.000000000","message":"does this make sense?","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":1258,"context_line":""},{"line_number":1259,"context_line":"            #proj_id \u003d self._get_obj_tenant_id(\u0027port\u0027, port_obj.uuid)"},{"line_number":1260,"context_line":"            proj_id \u003d None"},{"line_number":1261,"context_line":"            if not proj_id:"},{"line_number":1262,"context_line":"                # not in cache, get by reading VN obj, and populate cache"},{"line_number":1263,"context_line":"                net_obj \u003d self._virtual_network_read(net_id\u003dnet_id)"},{"line_number":1264,"context_line":"                proj_id \u003d net_obj.parent_uuid.replace(\u0027-\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FtTo%3D","line":1261,"in_reply_to":"AAAATH%2F%2Ftp4%3D","updated":"2013-10-10 22:07:45.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":1329,"context_line":"            tenant_id \u003d self._get_obj_tenant_id(\u0027network\u0027, net_uuid)"},{"line_number":1330,"context_line":"            return {\u0027q_api_data\u0027: {\u0027id\u0027: net_uuid, \u0027tenant_id\u0027: tenant_id}}"},{"line_number":1331,"context_line":""},{"line_number":1332,"context_line":"        try:"},{"line_number":1333,"context_line":"            # return self._db_cache[\u0027q_networks\u0027][\u0027net_uuid\u0027]"},{"line_number":1334,"context_line":"            raise KeyError"},{"line_number":1335,"context_line":"        except KeyError:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Ftpc%3D","line":1332,"updated":"2013-10-10 20:28:17.000000000","message":"I think L1382-1337 could just be removed","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":1329,"context_line":"            tenant_id \u003d self._get_obj_tenant_id(\u0027network\u0027, net_uuid)"},{"line_number":1330,"context_line":"            return {\u0027q_api_data\u0027: {\u0027id\u0027: net_uuid, \u0027tenant_id\u0027: tenant_id}}"},{"line_number":1331,"context_line":""},{"line_number":1332,"context_line":"        try:"},{"line_number":1333,"context_line":"            # return self._db_cache[\u0027q_networks\u0027][\u0027net_uuid\u0027]"},{"line_number":1334,"context_line":"            raise KeyError"},{"line_number":1335,"context_line":"        except KeyError:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FtTc%3D","line":1332,"in_reply_to":"AAAATH%2F%2Ftpc%3D","updated":"2013-10-10 22:07:45.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":1363,"context_line":"        ret_list \u003d []"},{"line_number":1364,"context_line":""},{"line_number":1365,"context_line":"        if filters and \u0027shared\u0027 in filters:"},{"line_number":1366,"context_line":"            if filters[\u0027shared\u0027][0] is True:"},{"line_number":1367,"context_line":"                # no support for shared networks"},{"line_number":1368,"context_line":"                return ret_list"},{"line_number":1369,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Fto8%3D","line":1366,"updated":"2013-10-10 20:28:17.000000000","message":"just \n if filters[\u0027shared\u0027][0]:\nIt\u0027s more readable","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":1363,"context_line":"        ret_list \u003d []"},{"line_number":1364,"context_line":""},{"line_number":1365,"context_line":"        if filters and \u0027shared\u0027 in filters:"},{"line_number":1366,"context_line":"            if filters[\u0027shared\u0027][0] is True:"},{"line_number":1367,"context_line":"                # no support for shared networks"},{"line_number":1368,"context_line":"                return ret_list"},{"line_number":1369,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FtTQ%3D","line":1366,"in_reply_to":"AAAATH%2F%2Fto8%3D","updated":"2013-10-10 22:07:45.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":1494,"context_line":"        return subnet_info"},{"line_number":1495,"context_line":""},{"line_number":1496,"context_line":"    def subnet_read(self, subnet_id):"},{"line_number":1497,"context_line":"        try:"},{"line_number":1498,"context_line":"            # return self._db_cache[\u0027q_subnets\u0027][subnet_id]"},{"line_number":1499,"context_line":"            raise KeyError"},{"line_number":1500,"context_line":"        except KeyError:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Ftok%3D","line":1497,"updated":"2013-10-10 20:28:17.000000000","message":"I think L1497-1502 could just be removed","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":1494,"context_line":"        return subnet_info"},{"line_number":1495,"context_line":""},{"line_number":1496,"context_line":"    def subnet_read(self, subnet_id):"},{"line_number":1497,"context_line":"        try:"},{"line_number":1498,"context_line":"            # return self._db_cache[\u0027q_subnets\u0027][subnet_id]"},{"line_number":1499,"context_line":"            raise KeyError"},{"line_number":1500,"context_line":"        except KeyError:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FtTM%3D","line":1497,"in_reply_to":"AAAATH%2F%2Ftok%3D","updated":"2013-10-10 22:07:45.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d933c53b783ffada6c1da6ba3e2b34c33ee4481c","unresolved":false,"context_lines":[{"line_number":1540,"context_line":"                    except KeyError:"},{"line_number":1541,"context_line":"                        pass"},{"line_number":1542,"context_line":""},{"line_number":1543,"context_line":"                    return"},{"line_number":1544,"context_line":""},{"line_number":1545,"context_line":"    def subnets_list(self, filters\u003dNone):"},{"line_number":1546,"context_line":"        ret_subnets \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Ftoc%3D","line":1543,"updated":"2013-10-10 20:28:17.000000000","message":"unnecessary","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"8609196c58c2272cf25326b3bcacf40d84dad30c","unresolved":false,"context_lines":[{"line_number":1540,"context_line":"                    except KeyError:"},{"line_number":1541,"context_line":"                        pass"},{"line_number":1542,"context_line":""},{"line_number":1543,"context_line":"                    return"},{"line_number":1544,"context_line":""},{"line_number":1545,"context_line":"    def subnets_list(self, filters\u003dNone):"},{"line_number":1546,"context_line":"        ret_subnets \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FtTI%3D","line":1543,"in_reply_to":"AAAATH%2F%2Ftoc%3D","updated":"2013-10-10 22:07:45.000000000","message":"Done","commit_id":"1eae0ca533eac0bc42d2f1098ef4fd4b1379e686"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"3987f40ace876847a20e33ca83f13c1d6ab32803","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    Q_URL_PREFIX \u003d \u0027/extensions/ct\u0027"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def __init__(self, admin_name, admin_password, admin_tenant_name,"},{"line_number":54,"context_line":"                 api_srvr_ip, api_srvr_port, user_info\u003dNone):"},{"line_number":55,"context_line":"        self._api_srvr_ip \u003d api_srvr_ip"},{"line_number":56,"context_line":"        self._api_srvr_port \u003d api_srvr_port"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2Foto%3D","line":54,"updated":"2013-10-11 23:17:26.000000000","message":"s/srvr/server/g\n\nWe shouldn\u0027t use shorten name","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"a4bd43763c61adba6a3aacb51fa6017a31f77751","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    Q_URL_PREFIX \u003d \u0027/extensions/ct\u0027"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def __init__(self, admin_name, admin_password, admin_tenant_name,"},{"line_number":54,"context_line":"                 api_srvr_ip, api_srvr_port, user_info\u003dNone):"},{"line_number":55,"context_line":"        self._api_srvr_ip \u003d api_srvr_ip"},{"line_number":56,"context_line":"        self._api_srvr_port \u003d api_srvr_port"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FiMw%3D","line":54,"in_reply_to":"AAAATH%2F%2FiR8%3D","updated":"2013-10-14 22:18:08.000000000","message":"Done","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"9d12496a6b54b3de5349a3ea2938bbf792661c3a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    Q_URL_PREFIX \u003d \u0027/extensions/ct\u0027"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def __init__(self, admin_name, admin_password, admin_tenant_name,"},{"line_number":54,"context_line":"                 api_srvr_ip, api_srvr_port, user_info\u003dNone):"},{"line_number":55,"context_line":"        self._api_srvr_ip \u003d api_srvr_ip"},{"line_number":56,"context_line":"        self._api_srvr_port \u003d api_srvr_port"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FiR8%3D","line":54,"in_reply_to":"AAAATH%2F%2FjD4%3D","updated":"2013-10-14 21:01:27.000000000","message":"Even if so, we should not use shorten name in python code for readability and consistency.","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"0e9c47c0dffc00e9953c67b728cadb836db069d9","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    Q_URL_PREFIX \u003d \u0027/extensions/ct\u0027"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def __init__(self, admin_name, admin_password, admin_tenant_name,"},{"line_number":54,"context_line":"                 api_srvr_ip, api_srvr_port, user_info\u003dNone):"},{"line_number":55,"context_line":"        self._api_srvr_ip \u003d api_srvr_ip"},{"line_number":56,"context_line":"        self._api_srvr_port \u003d api_srvr_port"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FjD4%3D","line":54,"in_reply_to":"AAAATH%2F%2Foto%3D","updated":"2013-10-14 19:57:20.000000000","message":"these are self explanatory shorten names","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"3987f40ace876847a20e33ca83f13c1d6ab32803","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        # Retry till a api-server is up"},{"line_number":78,"context_line":"        connected \u003d False"},{"line_number":79,"context_line":"        while not connected:"},{"line_number":80,"context_line":"            try:"},{"line_number":81,"context_line":"                self._vnc_lib \u003d vnc_api.VncApi("},{"line_number":82,"context_line":"                    admin_name, admin_password,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2Fots%3D","line":79,"updated":"2013-10-11 23:17:26.000000000","message":"Please do similar impl with this https://github.com/openstack/neutron/blob/master/neutron/openstack/common/db/sqlalchemy/session.py#L678\n\nif the user want\u0027s to specify retry infinity, he can set -1","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"0e9c47c0dffc00e9953c67b728cadb836db069d9","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        # Retry till a api-server is up"},{"line_number":78,"context_line":"        connected \u003d False"},{"line_number":79,"context_line":"        while not connected:"},{"line_number":80,"context_line":"            try:"},{"line_number":81,"context_line":"                self._vnc_lib \u003d vnc_api.VncApi("},{"line_number":82,"context_line":"                    admin_name, admin_password,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2Fisc%3D","line":79,"in_reply_to":"AAAATH%2F%2Fots%3D","updated":"2013-10-14 19:57:20.000000000","message":"Done","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"3987f40ace876847a20e33ca83f13c1d6ab32803","unresolved":false,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        return port_uuid"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    def _virtual_machine_interface_read(self, port_id\u003dNone, fq_name\u003dNone):"},{"line_number":376,"context_line":"        if port_id:"},{"line_number":377,"context_line":"            try:"},{"line_number":378,"context_line":"                # return self._db_cache[\u0027vnc_ports\u0027][port_id]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FotQ%3D","line":375,"updated":"2013-10-11 23:17:26.000000000","message":"This method should be split for port_id and fq_name","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"0e9c47c0dffc00e9953c67b728cadb836db069d9","unresolved":false,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        return port_uuid"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    def _virtual_machine_interface_read(self, port_id\u003dNone, fq_name\u003dNone):"},{"line_number":376,"context_line":"        if port_id:"},{"line_number":377,"context_line":"            try:"},{"line_number":378,"context_line":"                # return self._db_cache[\u0027vnc_ports\u0027][port_id]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2Fit0%3D","line":375,"in_reply_to":"AAAATH%2F%2FotQ%3D","updated":"2013-10-14 19:57:20.000000000","message":"we can get virtual_machine_interface either from port_id or fq_name, therefore same API is used. we dont intended to change this.","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"3987f40ace876847a20e33ca83f13c1d6ab32803","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        if port_id:"},{"line_number":377,"context_line":"            try:"},{"line_number":378,"context_line":"                # return self._db_cache[\u0027vnc_ports\u0027][port_id]"},{"line_number":379,"context_line":"                raise KeyError"},{"line_number":380,"context_line":"            except KeyError:"},{"line_number":381,"context_line":"                port_obj \u003d self._vnc_lib.virtual_machine_interface_read("},{"line_number":382,"context_line":"                    id\u003dport_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FotI%3D","line":379,"updated":"2013-10-11 23:17:26.000000000","message":"Not fixed..","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"0e9c47c0dffc00e9953c67b728cadb836db069d9","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        if port_id:"},{"line_number":377,"context_line":"            try:"},{"line_number":378,"context_line":"                # return self._db_cache[\u0027vnc_ports\u0027][port_id]"},{"line_number":379,"context_line":"                raise KeyError"},{"line_number":380,"context_line":"            except KeyError:"},{"line_number":381,"context_line":"                port_obj \u003d self._vnc_lib.virtual_machine_interface_read("},{"line_number":382,"context_line":"                    id\u003dport_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FjEg%3D","line":379,"in_reply_to":"AAAATH%2F%2FotI%3D","updated":"2013-10-14 19:57:20.000000000","message":"Done","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"3987f40ace876847a20e33ca83f13c1d6ab32803","unresolved":false,"context_lines":[{"line_number":389,"context_line":"            fq_name_str \u003d json.dumps(fq_name)"},{"line_number":390,"context_line":"            try:"},{"line_number":391,"context_line":"                # return self._db_cache[\u0027vnc_ports\u0027][fq_name_str]"},{"line_number":392,"context_line":"                raise KeyError"},{"line_number":393,"context_line":"            except KeyError:"},{"line_number":394,"context_line":"                port_obj \u003d self._vnc_lib.virtual_machine_interface_read("},{"line_number":395,"context_line":"                    fq_name\u003dfq_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FotE%3D","line":392,"updated":"2013-10-11 23:17:26.000000000","message":"Not fixed..","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"0e9c47c0dffc00e9953c67b728cadb836db069d9","unresolved":false,"context_lines":[{"line_number":389,"context_line":"            fq_name_str \u003d json.dumps(fq_name)"},{"line_number":390,"context_line":"            try:"},{"line_number":391,"context_line":"                # return self._db_cache[\u0027vnc_ports\u0027][fq_name_str]"},{"line_number":392,"context_line":"                raise KeyError"},{"line_number":393,"context_line":"            except KeyError:"},{"line_number":394,"context_line":"                port_obj \u003d self._vnc_lib.virtual_machine_interface_read("},{"line_number":395,"context_line":"                    fq_name\u003dfq_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FjEc%3D","line":392,"in_reply_to":"AAAATH%2F%2FotE%3D","updated":"2013-10-14 19:57:20.000000000","message":"Done","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"3987f40ace876847a20e33ca83f13c1d6ab32803","unresolved":false,"context_lines":[{"line_number":429,"context_line":"    def _instance_ip_read(self, instance_ip_id\u003dNone, fq_name\u003dNone):"},{"line_number":430,"context_line":"        if instance_ip_id:"},{"line_number":431,"context_line":"            try:"},{"line_number":432,"context_line":"                # return self._db_cache[\u0027vnc_instance_ips\u0027][instance_ip_id]"},{"line_number":433,"context_line":"                raise KeyError"},{"line_number":434,"context_line":"            except KeyError:"},{"line_number":435,"context_line":"                iip_obj \u003d self._vnc_lib.instance_ip_read(id\u003dinstance_ip_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FotA%3D","line":432,"updated":"2013-10-11 23:17:26.000000000","message":"Not fixed..","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"0e9c47c0dffc00e9953c67b728cadb836db069d9","unresolved":false,"context_lines":[{"line_number":429,"context_line":"    def _instance_ip_read(self, instance_ip_id\u003dNone, fq_name\u003dNone):"},{"line_number":430,"context_line":"        if instance_ip_id:"},{"line_number":431,"context_line":"            try:"},{"line_number":432,"context_line":"                # return self._db_cache[\u0027vnc_instance_ips\u0027][instance_ip_id]"},{"line_number":433,"context_line":"                raise KeyError"},{"line_number":434,"context_line":"            except KeyError:"},{"line_number":435,"context_line":"                iip_obj \u003d self._vnc_lib.instance_ip_read(id\u003dinstance_ip_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FjEY%3D","line":432,"in_reply_to":"AAAATH%2F%2FotA%3D","updated":"2013-10-14 19:57:20.000000000","message":"Done","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"3987f40ace876847a20e33ca83f13c1d6ab32803","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        if fq_name:"},{"line_number":442,"context_line":"            fq_name_str \u003d json.dumps(fq_name)"},{"line_number":443,"context_line":"            try:"},{"line_number":444,"context_line":"                # return self._db_cache[\u0027vnc_instance_ips\u0027][fq_name_str]"},{"line_number":445,"context_line":"                raise KeyError"},{"line_number":446,"context_line":"            except KeyError:"},{"line_number":447,"context_line":"                iip_obj \u003d self._vnc_lib.instance_ip_read(fq_name\u003dfq_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2Fos8%3D","line":444,"updated":"2013-10-11 23:17:26.000000000","message":"Not fixed..","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"0e9c47c0dffc00e9953c67b728cadb836db069d9","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        if fq_name:"},{"line_number":442,"context_line":"            fq_name_str \u003d json.dumps(fq_name)"},{"line_number":443,"context_line":"            try:"},{"line_number":444,"context_line":"                # return self._db_cache[\u0027vnc_instance_ips\u0027][fq_name_str]"},{"line_number":445,"context_line":"                raise KeyError"},{"line_number":446,"context_line":"            except KeyError:"},{"line_number":447,"context_line":"                iip_obj \u003d self._vnc_lib.instance_ip_read(fq_name\u003dfq_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FjEU%3D","line":444,"in_reply_to":"AAAATH%2F%2Fos8%3D","updated":"2013-10-14 19:57:20.000000000","message":"Done","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"3987f40ace876847a20e33ca83f13c1d6ab32803","unresolved":false,"context_lines":[{"line_number":618,"context_line":"            ret_list.extend(net_ports)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"        return ret_list"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    # Returns True if"},{"line_number":623,"context_line":"    #     * no filter is specified"},{"line_number":624,"context_line":"    #     OR"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2Fosk%3D","line":621,"updated":"2013-10-11 23:17:26.000000000","message":"This should be the doc string","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"0e9c47c0dffc00e9953c67b728cadb836db069d9","unresolved":false,"context_lines":[{"line_number":618,"context_line":"            ret_list.extend(net_ports)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"        return ret_list"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    # Returns True if"},{"line_number":623,"context_line":"    #     * no filter is specified"},{"line_number":624,"context_line":"    #     OR"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FjAQ%3D","line":621,"in_reply_to":"AAAATH%2F%2Fosk%3D","updated":"2013-10-14 19:57:20.000000000","message":"Done","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"3987f40ace876847a20e33ca83f13c1d6ab32803","unresolved":false,"context_lines":[{"line_number":739,"context_line":"    # Conversion routines between VNC and Neutron objects"},{"line_number":740,"context_line":"    def _svc_instance_neutron_to_vnc(self, si_q, operator):"},{"line_number":741,"context_line":"        si_vnc \u003d None"},{"line_number":742,"context_line":"        if operator \u003d\u003d CREATE:"},{"line_number":743,"context_line":"            project_id \u003d str(uuid.UUID(si_q[\u0027tenant_id\u0027]))"},{"line_number":744,"context_line":"            project_obj \u003d self._project_read(proj_id\u003dproject_id)"},{"line_number":745,"context_line":"            net_id \u003d si_q[\u0027internal_net\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2Fos0%3D","line":742,"updated":"2013-10-11 23:17:26.000000000","message":"I\u0027m not sure why this method takes operator..","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"50bbdaf2ca52d752c7b330f2e893491d1d5c0c2f","unresolved":false,"context_lines":[{"line_number":739,"context_line":"    # Conversion routines between VNC and Neutron objects"},{"line_number":740,"context_line":"    def _svc_instance_neutron_to_vnc(self, si_q, operator):"},{"line_number":741,"context_line":"        si_vnc \u003d None"},{"line_number":742,"context_line":"        if operator \u003d\u003d CREATE:"},{"line_number":743,"context_line":"            project_id \u003d str(uuid.UUID(si_q[\u0027tenant_id\u0027]))"},{"line_number":744,"context_line":"            project_obj \u003d self._project_read(proj_id\u003dproject_id)"},{"line_number":745,"context_line":"            net_id \u003d si_q[\u0027internal_net\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2Fh6M%3D","line":742,"in_reply_to":"AAAATH%2F%2FiRk%3D","updated":"2013-10-14 22:38:01.000000000","message":"Done","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"9d12496a6b54b3de5349a3ea2938bbf792661c3a","unresolved":false,"context_lines":[{"line_number":739,"context_line":"    # Conversion routines between VNC and Neutron objects"},{"line_number":740,"context_line":"    def _svc_instance_neutron_to_vnc(self, si_q, operator):"},{"line_number":741,"context_line":"        si_vnc \u003d None"},{"line_number":742,"context_line":"        if operator \u003d\u003d CREATE:"},{"line_number":743,"context_line":"            project_id \u003d str(uuid.UUID(si_q[\u0027tenant_id\u0027]))"},{"line_number":744,"context_line":"            project_obj \u003d self._project_read(proj_id\u003dproject_id)"},{"line_number":745,"context_line":"            net_id \u003d si_q[\u0027internal_net\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FiRk%3D","line":742,"in_reply_to":"AAAATH%2F%2FjC8%3D","updated":"2013-10-14 21:01:27.000000000","message":"we should add it when we add more operations.\nGenerally, using if for switching functionality is a bad habit.\nWe should have separate function for each operation, and use dict for mapping","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"0e9c47c0dffc00e9953c67b728cadb836db069d9","unresolved":false,"context_lines":[{"line_number":739,"context_line":"    # Conversion routines between VNC and Neutron objects"},{"line_number":740,"context_line":"    def _svc_instance_neutron_to_vnc(self, si_q, operator):"},{"line_number":741,"context_line":"        si_vnc \u003d None"},{"line_number":742,"context_line":"        if operator \u003d\u003d CREATE:"},{"line_number":743,"context_line":"            project_id \u003d str(uuid.UUID(si_q[\u0027tenant_id\u0027]))"},{"line_number":744,"context_line":"            project_obj \u003d self._project_read(proj_id\u003dproject_id)"},{"line_number":745,"context_line":"            net_id \u003d si_q[\u0027internal_net\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FjC8%3D","line":742,"in_reply_to":"AAAATH%2F%2Fos0%3D","updated":"2013-10-14 19:57:20.000000000","message":"to update it later for other operations.. currently CREATE is supported.","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"3987f40ace876847a20e33ca83f13c1d6ab32803","unresolved":false,"context_lines":[{"line_number":1358,"context_line":"                return ret_list"},{"line_number":1359,"context_line":""},{"line_number":1360,"context_line":"        # collect phase"},{"line_number":1361,"context_line":"        all_nets \u003d []  # all n/ws in all projects"},{"line_number":1362,"context_line":"        if filters and \u0027tenant_id\u0027 in filters:"},{"line_number":1363,"context_line":"            # project-id is present"},{"line_number":1364,"context_line":"            if \u0027id\u0027 in filters:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2Foss%3D","line":1361,"updated":"2013-10-11 23:17:26.000000000","message":"all network?","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"0e9c47c0dffc00e9953c67b728cadb836db069d9","unresolved":false,"context_lines":[{"line_number":1358,"context_line":"                return ret_list"},{"line_number":1359,"context_line":""},{"line_number":1360,"context_line":"        # collect phase"},{"line_number":1361,"context_line":"        all_nets \u003d []  # all n/ws in all projects"},{"line_number":1362,"context_line":"        if filters and \u0027tenant_id\u0027 in filters:"},{"line_number":1363,"context_line":"            # project-id is present"},{"line_number":1364,"context_line":"            if \u0027id\u0027 in filters:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FjEM%3D","line":1361,"in_reply_to":"AAAATH%2F%2Foss%3D","updated":"2013-10-14 19:57:20.000000000","message":"yes, I will change the comment string to reflect it.","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import time"},{"line_number":24,"context_line":"import uuid"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from netaddr import IPNetwork, IPSet, IPAddress"},{"line_number":27,"context_line":"from vnc_api.common import exception as vnc_exc"},{"line_number":28,"context_line":"from vnc_api import vnc_api"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeDo%3D","line":26,"updated":"2013-10-15 19:27:44.000000000","message":"please don\u0027t import class directly, but use module level import","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import time"},{"line_number":24,"context_line":"import uuid"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from netaddr import IPNetwork, IPSet, IPAddress"},{"line_number":27,"context_line":"from vnc_api.common import exception as vnc_exc"},{"line_number":28,"context_line":"from vnc_api import vnc_api"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh8U%3D","line":26,"in_reply_to":"AAAATH%2F%2FeDo%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class DBInterface(object):"},{"line_number":48,"context_line":"    \"\"\""},{"line_number":49,"context_line":"    An instance of this class forwards requests to vnc cfg api (web)server"},{"line_number":50,"context_line":"    \"\"\""},{"line_number":51,"context_line":"    Q_URL_PREFIX \u003d \u0027/extensions/ct\u0027"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeCk%3D","line":49,"updated":"2013-10-15 19:27:44.000000000","message":"hacking rst","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class DBInterface(object):"},{"line_number":48,"context_line":"    \"\"\""},{"line_number":49,"context_line":"    An instance of this class forwards requests to vnc cfg api (web)server"},{"line_number":50,"context_line":"    \"\"\""},{"line_number":51,"context_line":"    Q_URL_PREFIX \u003d \u0027/extensions/ct\u0027"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh8Q%3D","line":49,"in_reply_to":"AAAATH%2F%2FeCk%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        return requests.request(method, url\u003durl, data\u003ddata, headers\u003dheaders)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def _relay_request(self, request):"},{"line_number":151,"context_line":"        \"\"\""},{"line_number":152,"context_line":"        Send received request to api server"},{"line_number":153,"context_line":"        \"\"\""},{"line_number":154,"context_line":"        # chop neutron parts of url and add api server address"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeCs%3D","line":151,"updated":"2013-10-15 19:27:44.000000000","message":"hacking.rst","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        return requests.request(method, url\u003durl, data\u003ddata, headers\u003dheaders)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def _relay_request(self, request):"},{"line_number":151,"context_line":"        \"\"\""},{"line_number":152,"context_line":"        Send received request to api server"},{"line_number":153,"context_line":"        \"\"\""},{"line_number":154,"context_line":"        # chop neutron parts of url and add api server address"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh8M%3D","line":151,"in_reply_to":"AAAATH%2F%2FeCs%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":556,"context_line":"        return ret_list"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"    def _filters_is_present(self, filters, key_name, match_value):"},{"line_number":559,"context_line":"        \"\"\"Check if filters present or not."},{"line_number":560,"context_line":"        Returns True if no filter is specified"},{"line_number":561,"context_line":"        OR search-param is not present in filters"},{"line_number":562,"context_line":"        OR (search-param is present in filters AND"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeCA%3D","line":559,"updated":"2013-10-15 19:27:44.000000000","message":"blank line needed","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":556,"context_line":"        return ret_list"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"    def _filters_is_present(self, filters, key_name, match_value):"},{"line_number":559,"context_line":"        \"\"\"Check if filters present or not."},{"line_number":560,"context_line":"        Returns True if no filter is specified"},{"line_number":561,"context_line":"        OR search-param is not present in filters"},{"line_number":562,"context_line":"        OR (search-param is present in filters AND"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh8I%3D","line":559,"in_reply_to":"AAAATH%2F%2FeCA%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":1166,"context_line":"        return {\u0027q_api_data\u0027: port_q_dict,"},{"line_number":1167,"context_line":"                \u0027q_extra_data\u0027: sg_dict}"},{"line_number":1168,"context_line":""},{"line_number":1169,"context_line":"    # public methods"},{"line_number":1170,"context_line":"    # network api handlers"},{"line_number":1171,"context_line":"    def network_create(self, network_q):"},{"line_number":1172,"context_line":"        #self._ensure_project_exists(network_q[\u0027tenant_id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeBg%3D","line":1169,"updated":"2013-10-15 19:27:44.000000000","message":"please move in to the doc string","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":1166,"context_line":"        return {\u0027q_api_data\u0027: port_q_dict,"},{"line_number":1167,"context_line":"                \u0027q_extra_data\u0027: sg_dict}"},{"line_number":1168,"context_line":""},{"line_number":1169,"context_line":"    # public methods"},{"line_number":1170,"context_line":"    # network api handlers"},{"line_number":1171,"context_line":"    def network_create(self, network_q):"},{"line_number":1172,"context_line":"        #self._ensure_project_exists(network_q[\u0027tenant_id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh8E%3D","line":1169,"in_reply_to":"AAAATH%2F%2FeBg%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":1169,"context_line":"    # public methods"},{"line_number":1170,"context_line":"    # network api handlers"},{"line_number":1171,"context_line":"    def network_create(self, network_q):"},{"line_number":1172,"context_line":"        #self._ensure_project_exists(network_q[\u0027tenant_id\u0027])"},{"line_number":1173,"context_line":""},{"line_number":1174,"context_line":"        net_obj \u003d self._network_neutron_to_vnc(network_q, CREATE)"},{"line_number":1175,"context_line":"        net_uuid \u003d self._virtual_network_create(net_obj)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeBw%3D","line":1172,"updated":"2013-10-15 19:27:44.000000000","message":"please remove dead code","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":1169,"context_line":"    # public methods"},{"line_number":1170,"context_line":"    # network api handlers"},{"line_number":1171,"context_line":"    def network_create(self, network_q):"},{"line_number":1172,"context_line":"        #self._ensure_project_exists(network_q[\u0027tenant_id\u0027])"},{"line_number":1173,"context_line":""},{"line_number":1174,"context_line":"        net_obj \u003d self._network_neutron_to_vnc(network_q, CREATE)"},{"line_number":1175,"context_line":"        net_uuid \u003d self._virtual_network_create(net_obj)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh8A%3D","line":1172,"in_reply_to":"AAAATH%2F%2FeBw%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"46d4312f75ee97b49dfe41fb6bccd6b1cd96568a","unresolved":false,"context_lines":[{"line_number":1284,"context_line":"        nets_info \u003d self.network_list(filters)"},{"line_number":1285,"context_line":"        return len(nets_info)"},{"line_number":1286,"context_line":""},{"line_number":1287,"context_line":"    # subnet api handlers"},{"line_number":1288,"context_line":"    def subnet_create(self, subnet_q):"},{"line_number":1289,"context_line":"        net_id \u003d subnet_q[\u0027network_id\u0027]"},{"line_number":1290,"context_line":"        net_obj \u003d self._virtual_network_read(net_id\u003dnet_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FeBU%3D","line":1287,"updated":"2013-10-15 19:27:44.000000000","message":"please move this for docstring","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8d4ab203f412fe3710b30eb357d33728e5fe7024","unresolved":false,"context_lines":[{"line_number":1284,"context_line":"        nets_info \u003d self.network_list(filters)"},{"line_number":1285,"context_line":"        return len(nets_info)"},{"line_number":1286,"context_line":""},{"line_number":1287,"context_line":"    # subnet api handlers"},{"line_number":1288,"context_line":"    def subnet_create(self, subnet_q):"},{"line_number":1289,"context_line":"        net_id \u003d subnet_q[\u0027network_id\u0027]"},{"line_number":1290,"context_line":"        net_obj \u003d self._virtual_network_read(net_id\u003dnet_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fh78%3D","line":1287,"in_reply_to":"AAAATH%2F%2FeBU%3D","updated":"2013-11-01 23:46:18.000000000","message":"Done","commit_id":"7103e3af1fd1fff0cf27b2edb283b374a09f3a87"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"811562a2e7c28cc68995598acdeb0a00bc62cd4d","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            remaining \u003d \u0027infinite\u0027"},{"line_number":83,"context_line":"        msg \u003d _(\u0027api-server connection failed. %s attempts left.\u0027)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        while not connected:"},{"line_number":86,"context_line":"            try:"},{"line_number":87,"context_line":"                self._vnc_lib \u003d vnc_api.VncApi("},{"line_number":88,"context_line":"                    admin_name, admin_password,"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F9bvY%3D","line":85,"updated":"2013-12-11 15:30:23.000000000","message":"It\u0027s better to extract L85-97 into separate method returning connected _vnc_lib or raising an exception. That will increase readability a lot.","commit_id":"ad6685f41e98a9ac8f329b3549f5e980149da1c1"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"34f2bb0c267717f4a64de42cfb23d03cc3a15897","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            remaining \u003d \u0027infinite\u0027"},{"line_number":83,"context_line":"        msg \u003d _(\u0027api-server connection failed. %s attempts left.\u0027)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        while not connected:"},{"line_number":86,"context_line":"            try:"},{"line_number":87,"context_line":"                self._vnc_lib \u003d vnc_api.VncApi("},{"line_number":88,"context_line":"                    admin_name, admin_password,"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F9GgA%3D","line":85,"in_reply_to":"AAAATn%2F9bvY%3D","updated":"2013-12-16 19:47:21.000000000","message":"Done","commit_id":"ad6685f41e98a9ac8f329b3549f5e980149da1c1"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"811562a2e7c28cc68995598acdeb0a00bc62cd4d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                    api_server_port, \u0027/\u0027, user_info\u003duser_info)"},{"line_number":91,"context_line":"                connected \u003d True"},{"line_number":92,"context_line":"            except requests.exceptions.RequestException:"},{"line_number":93,"context_line":"                LOG.warn(msg % remaining)"},{"line_number":94,"context_line":"                if (remaining !\u003d \u0027infinite\u0027 and remaining \u003d\u003d 0):"},{"line_number":95,"context_line":"                    raise"},{"line_number":96,"context_line":"                if (remaining !\u003d \u0027infinite\u0027):"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F9bv0%3D","line":93,"updated":"2013-12-11 15:30:23.000000000","message":"nit: LOG.warn(msg, remaining)","commit_id":"ad6685f41e98a9ac8f329b3549f5e980149da1c1"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"34f2bb0c267717f4a64de42cfb23d03cc3a15897","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                    api_server_port, \u0027/\u0027, user_info\u003duser_info)"},{"line_number":91,"context_line":"                connected \u003d True"},{"line_number":92,"context_line":"            except requests.exceptions.RequestException:"},{"line_number":93,"context_line":"                LOG.warn(msg % remaining)"},{"line_number":94,"context_line":"                if (remaining !\u003d \u0027infinite\u0027 and remaining \u003d\u003d 0):"},{"line_number":95,"context_line":"                    raise"},{"line_number":96,"context_line":"                if (remaining !\u003d \u0027infinite\u0027):"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F9Gf8%3D","line":93,"in_reply_to":"AAAATn%2F9bv0%3D","updated":"2013-12-16 19:47:21.000000000","message":"Done","commit_id":"ad6685f41e98a9ac8f329b3549f5e980149da1c1"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"811562a2e7c28cc68995598acdeb0a00bc62cd4d","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                connected \u003d True"},{"line_number":92,"context_line":"            except requests.exceptions.RequestException:"},{"line_number":93,"context_line":"                LOG.warn(msg % remaining)"},{"line_number":94,"context_line":"                if (remaining !\u003d \u0027infinite\u0027 and remaining \u003d\u003d 0):"},{"line_number":95,"context_line":"                    raise"},{"line_number":96,"context_line":"                if (remaining !\u003d \u0027infinite\u0027):"},{"line_number":97,"context_line":"                    remaining -\u003d 1"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F9bvw%3D","line":94,"updated":"2013-12-11 15:30:23.000000000","message":"parens are unnecessary","commit_id":"ad6685f41e98a9ac8f329b3549f5e980149da1c1"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"34f2bb0c267717f4a64de42cfb23d03cc3a15897","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                connected \u003d True"},{"line_number":92,"context_line":"            except requests.exceptions.RequestException:"},{"line_number":93,"context_line":"                LOG.warn(msg % remaining)"},{"line_number":94,"context_line":"                if (remaining !\u003d \u0027infinite\u0027 and remaining \u003d\u003d 0):"},{"line_number":95,"context_line":"                    raise"},{"line_number":96,"context_line":"                if (remaining !\u003d \u0027infinite\u0027):"},{"line_number":97,"context_line":"                    remaining -\u003d 1"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F9Gf4%3D","line":94,"in_reply_to":"AAAATn%2F9bvw%3D","updated":"2013-12-16 19:47:21.000000000","message":"Done","commit_id":"ad6685f41e98a9ac8f329b3549f5e980149da1c1"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"811562a2e7c28cc68995598acdeb0a00bc62cd4d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                LOG.warn(msg % remaining)"},{"line_number":94,"context_line":"                if (remaining !\u003d \u0027infinite\u0027 and remaining \u003d\u003d 0):"},{"line_number":95,"context_line":"                    raise"},{"line_number":96,"context_line":"                if (remaining !\u003d \u0027infinite\u0027):"},{"line_number":97,"context_line":"                    remaining -\u003d 1"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"                time.sleep(self._retry_interval)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F9bvo%3D","line":96,"updated":"2013-12-11 15:30:23.000000000","message":"same as above","commit_id":"ad6685f41e98a9ac8f329b3549f5e980149da1c1"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"34f2bb0c267717f4a64de42cfb23d03cc3a15897","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                LOG.warn(msg % remaining)"},{"line_number":94,"context_line":"                if (remaining !\u003d \u0027infinite\u0027 and remaining \u003d\u003d 0):"},{"line_number":95,"context_line":"                    raise"},{"line_number":96,"context_line":"                if (remaining !\u003d \u0027infinite\u0027):"},{"line_number":97,"context_line":"                    remaining -\u003d 1"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"                time.sleep(self._retry_interval)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F9Gf0%3D","line":96,"in_reply_to":"AAAATn%2F9bvo%3D","updated":"2013-12-16 19:47:21.000000000","message":"Done","commit_id":"ad6685f41e98a9ac8f329b3549f5e980149da1c1"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"811562a2e7c28cc68995598acdeb0a00bc62cd4d","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        # changes \u0027net_fq_name_str pfx/len\u0027 key to \u0027net_id pfx/len\u0027 key"},{"line_number":102,"context_line":"        # eg. domain1:project1:net1 1.1.1.0/24 becomes \u003cuuid\u003e 1.1.1.0/24"},{"line_number":103,"context_line":"        subnet_map \u003d self._vnc_lib.kv_retrieve(key\u003dNone)"},{"line_number":104,"context_line":"        for kv_dict in subnet_map:"},{"line_number":105,"context_line":"            key \u003d kv_dict[\u0027key\u0027]"},{"line_number":106,"context_line":"            if len(key.split()) \u003d\u003d 1:"},{"line_number":107,"context_line":"                subnet_id \u003d key"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F9bvI%3D","line":104,"updated":"2013-12-11 15:30:23.000000000","message":"Suggest move L104-143 in a separate method","commit_id":"ad6685f41e98a9ac8f329b3549f5e980149da1c1"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"34f2bb0c267717f4a64de42cfb23d03cc3a15897","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        # changes \u0027net_fq_name_str pfx/len\u0027 key to \u0027net_id pfx/len\u0027 key"},{"line_number":102,"context_line":"        # eg. domain1:project1:net1 1.1.1.0/24 becomes \u003cuuid\u003e 1.1.1.0/24"},{"line_number":103,"context_line":"        subnet_map \u003d self._vnc_lib.kv_retrieve(key\u003dNone)"},{"line_number":104,"context_line":"        for kv_dict in subnet_map:"},{"line_number":105,"context_line":"            key \u003d kv_dict[\u0027key\u0027]"},{"line_number":106,"context_line":"            if len(key.split()) \u003d\u003d 1:"},{"line_number":107,"context_line":"                subnet_id \u003d key"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F9Gfc%3D","line":104,"in_reply_to":"AAAATn%2F9bvI%3D","updated":"2013-12-16 19:47:21.000000000","message":"This code was related to format change, removed the code. Its not needed anymore.","commit_id":"ad6685f41e98a9ac8f329b3549f5e980149da1c1"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"811562a2e7c28cc68995598acdeb0a00bc62cd4d","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        subnet_map \u003d self._vnc_lib.kv_retrieve(key\u003dNone)"},{"line_number":104,"context_line":"        for kv_dict in subnet_map:"},{"line_number":105,"context_line":"            key \u003d kv_dict[\u0027key\u0027]"},{"line_number":106,"context_line":"            if len(key.split()) \u003d\u003d 1:"},{"line_number":107,"context_line":"                subnet_id \u003d key"},{"line_number":108,"context_line":"                # uuid key, fixup value portion to \u0027net_id pfx/len\u0027 format"},{"line_number":109,"context_line":"                # if not already so"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F9bvA%3D","line":106,"updated":"2013-12-11 15:30:23.000000000","message":"there\u0027s lots of similar lines playing with \u0027key\u0027 which do same things. Could you extract it into a method and use across the code?","commit_id":"ad6685f41e98a9ac8f329b3549f5e980149da1c1"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"34f2bb0c267717f4a64de42cfb23d03cc3a15897","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        subnet_map \u003d self._vnc_lib.kv_retrieve(key\u003dNone)"},{"line_number":104,"context_line":"        for kv_dict in subnet_map:"},{"line_number":105,"context_line":"            key \u003d kv_dict[\u0027key\u0027]"},{"line_number":106,"context_line":"            if len(key.split()) \u003d\u003d 1:"},{"line_number":107,"context_line":"                subnet_id \u003d key"},{"line_number":108,"context_line":"                # uuid key, fixup value portion to \u0027net_id pfx/len\u0027 format"},{"line_number":109,"context_line":"                # if not already so"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F9GfU%3D","line":106,"in_reply_to":"AAAATn%2F9bvA%3D","updated":"2013-12-16 19:47:21.000000000","message":"This code was related to format change, removed the code. Its not needed anymore.","commit_id":"ad6685f41e98a9ac8f329b3549f5e980149da1c1"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"811562a2e7c28cc68995598acdeb0a00bc62cd4d","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    #end _obj_to_dict"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def _ensure_instance_exists(self, instance_id):"},{"line_number":164,"context_line":"        if instance_id \u003d\u003d \u0027\u0027:"},{"line_number":165,"context_line":"            # in VNC representation port always under an instance, create dummy"},{"line_number":166,"context_line":"            instance_name \u003d \u0027default-virtual-machine\u0027"},{"line_number":167,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F9buI%3D","line":164,"updated":"2013-12-11 15:30:23.000000000","message":"nit: if not instance_id","commit_id":"ad6685f41e98a9ac8f329b3549f5e980149da1c1"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"34f2bb0c267717f4a64de42cfb23d03cc3a15897","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    #end _obj_to_dict"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def _ensure_instance_exists(self, instance_id):"},{"line_number":164,"context_line":"        if instance_id \u003d\u003d \u0027\u0027:"},{"line_number":165,"context_line":"            # in VNC representation port always under an instance, create dummy"},{"line_number":166,"context_line":"            instance_name \u003d \u0027default-virtual-machine\u0027"},{"line_number":167,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F9GfM%3D","line":164,"in_reply_to":"AAAATn%2F9buI%3D","updated":"2013-12-16 19:47:21.000000000","message":"Done","commit_id":"ad6685f41e98a9ac8f329b3549f5e980149da1c1"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"811562a2e7c28cc68995598acdeb0a00bc62cd4d","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                net_obj \u003d self._virtual_network_read(net_id\u003dobj_uuid)"},{"line_number":230,"context_line":"                tenant_id \u003d net_obj.parent_uuid.replace(\u0027-\u0027, \u0027\u0027)"},{"line_number":231,"context_line":"                self._set_obj_tenant_id(obj_uuid, tenant_id)"},{"line_number":232,"context_line":"                return tenant_id"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    def _set_obj_tenant_id(self, obj_uuid, tenant_uuid):"},{"line_number":235,"context_line":"        self._db_cache[\u0027q_obj_to_tenant\u0027][obj_uuid] \u003d tenant_uuid"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F9bsc%3D","line":232,"updated":"2013-12-11 15:30:23.000000000","message":"else?","commit_id":"ad6685f41e98a9ac8f329b3549f5e980149da1c1"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"34f2bb0c267717f4a64de42cfb23d03cc3a15897","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                net_obj \u003d self._virtual_network_read(net_id\u003dobj_uuid)"},{"line_number":230,"context_line":"                tenant_id \u003d net_obj.parent_uuid.replace(\u0027-\u0027, \u0027\u0027)"},{"line_number":231,"context_line":"                self._set_obj_tenant_id(obj_uuid, tenant_id)"},{"line_number":232,"context_line":"                return tenant_id"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    def _set_obj_tenant_id(self, obj_uuid, tenant_uuid):"},{"line_number":235,"context_line":"        self._db_cache[\u0027q_obj_to_tenant\u0027][obj_uuid] \u003d tenant_uuid"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F9Gas%3D","line":232,"in_reply_to":"AAAATn%2F9bsc%3D","updated":"2013-12-16 19:47:21.000000000","message":"Done","commit_id":"ad6685f41e98a9ac8f329b3549f5e980149da1c1"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"811562a2e7c28cc68995598acdeb0a00bc62cd4d","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    def _del_obj_tenant_id(self, obj_uuid):"},{"line_number":238,"context_line":"        try:"},{"line_number":239,"context_line":"            del self._db_cache[\u0027q_obj_to_tenant\u0027][obj_uuid]"},{"line_number":240,"context_line":"        except Exception:"},{"line_number":241,"context_line":"            pass"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def _project_read(self, proj_id\u003dNone, fq_name\u003dNone):"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F9bsU%3D","line":240,"updated":"2013-12-11 15:30:23.000000000","message":"except KeyError","commit_id":"ad6685f41e98a9ac8f329b3549f5e980149da1c1"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"34f2bb0c267717f4a64de42cfb23d03cc3a15897","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    def _del_obj_tenant_id(self, obj_uuid):"},{"line_number":238,"context_line":"        try:"},{"line_number":239,"context_line":"            del self._db_cache[\u0027q_obj_to_tenant\u0027][obj_uuid]"},{"line_number":240,"context_line":"        except Exception:"},{"line_number":241,"context_line":"            pass"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def _project_read(self, proj_id\u003dNone, fq_name\u003dNone):"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F9GfI%3D","line":240,"in_reply_to":"AAAATn%2F9bsU%3D","updated":"2013-12-16 19:47:21.000000000","message":"Done","commit_id":"ad6685f41e98a9ac8f329b3549f5e980149da1c1"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"811562a2e7c28cc68995598acdeb0a00bc62cd4d","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    def _security_group_rule_create(self, sg_id, sg_rule):"},{"line_number":259,"context_line":"        sg_vnc \u003d self._vnc_lib.security_group_read(id\u003dsg_id)"},{"line_number":260,"context_line":"        rules \u003d sg_vnc.get_security_group_entries()"},{"line_number":261,"context_line":"        if rules is None:"},{"line_number":262,"context_line":"            rules \u003d vnc_api.PolicyEntriesType([sg_rule])"},{"line_number":263,"context_line":"        else:"},{"line_number":264,"context_line":"            rules.add_policy_rule(sg_rule)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F9bsE%3D","line":261,"updated":"2013-12-11 15:30:23.000000000","message":"nit: if not rules:","commit_id":"ad6685f41e98a9ac8f329b3549f5e980149da1c1"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"34f2bb0c267717f4a64de42cfb23d03cc3a15897","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    def _security_group_rule_create(self, sg_id, sg_rule):"},{"line_number":259,"context_line":"        sg_vnc \u003d self._vnc_lib.security_group_read(id\u003dsg_id)"},{"line_number":260,"context_line":"        rules \u003d sg_vnc.get_security_group_entries()"},{"line_number":261,"context_line":"        if rules is None:"},{"line_number":262,"context_line":"            rules \u003d vnc_api.PolicyEntriesType([sg_rule])"},{"line_number":263,"context_line":"        else:"},{"line_number":264,"context_line":"            rules.add_policy_rule(sg_rule)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F9GfE%3D","line":261,"in_reply_to":"AAAATn%2F9bsE%3D","updated":"2013-12-16 19:47:21.000000000","message":"Done","commit_id":"ad6685f41e98a9ac8f329b3549f5e980149da1c1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"643fff30b5e640c943a9279e1882e10608c59484","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import json"},{"line_number":20,"context_line":"import netaddr"},{"line_number":21,"context_line":"import re"},{"line_number":22,"context_line":"import requests"},{"line_number":23,"context_line":"import socket"},{"line_number":24,"context_line":"import time"},{"line_number":25,"context_line":"import uuid"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FYx8%3D","line":22,"updated":"2014-02-13 15:47:00.000000000","message":"netaddr and requests are thirdparty module.","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"574f6e2a84875198bb6eb32fd95bf5c626727b56","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import json"},{"line_number":20,"context_line":"import netaddr"},{"line_number":21,"context_line":"import re"},{"line_number":22,"context_line":"import requests"},{"line_number":23,"context_line":"import socket"},{"line_number":24,"context_line":"import time"},{"line_number":25,"context_line":"import uuid"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FWIw%3D","line":22,"in_reply_to":"AAAAUX%2F%2FYx8%3D","updated":"2014-02-14 00:42:48.000000000","message":"Done","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"643fff30b5e640c943a9279e1882e10608c59484","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        # Get the mapping from cache, else seed cache and return"},{"line_number":180,"context_line":"        try:"},{"line_number":181,"context_line":"            return self._db_cache[\u0027q_obj_to_tenant\u0027][obj_uuid]"},{"line_number":182,"context_line":"        except KeyError as e:"},{"line_number":183,"context_line":"            # Seed the cache and return"},{"line_number":184,"context_line":"            if q_type \u003d\u003d \u0027port\u0027:"},{"line_number":185,"context_line":"                port_obj \u003d self._virtual_machine_interface_read(obj_uuid)"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FYuU%3D","line":182,"updated":"2014-02-13 15:47:00.000000000","message":"IMO it is better to use if-else logic rather than try-except because both L.181 and L.184-L.195 looks normal logic.","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"574f6e2a84875198bb6eb32fd95bf5c626727b56","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        # Get the mapping from cache, else seed cache and return"},{"line_number":180,"context_line":"        try:"},{"line_number":181,"context_line":"            return self._db_cache[\u0027q_obj_to_tenant\u0027][obj_uuid]"},{"line_number":182,"context_line":"        except KeyError as e:"},{"line_number":183,"context_line":"            # Seed the cache and return"},{"line_number":184,"context_line":"            if q_type \u003d\u003d \u0027port\u0027:"},{"line_number":185,"context_line":"                port_obj \u003d self._virtual_machine_interface_read(obj_uuid)"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FWII%3D","line":182,"in_reply_to":"AAAAUX%2F%2FYuU%3D","updated":"2014-02-14 00:42:48.000000000","message":"I think if else will read it twice. Its better to use try except and in normal case it has better performance.","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"643fff30b5e640c943a9279e1882e10608c59484","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                self._set_obj_tenant_id(obj_uuid, tenant_id)"},{"line_number":195,"context_line":"                return tenant_id"},{"line_number":196,"context_line":"            else:"},{"line_number":197,"context_line":"                raise e"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _set_obj_tenant_id(self, obj_uuid, tenant_uuid):"},{"line_number":200,"context_line":"        self._db_cache[\u0027q_obj_to_tenant\u0027][obj_uuid] \u003d tenant_uuid"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FYww%3D","line":197,"updated":"2014-02-13 15:47:00.000000000","message":"I think raising KeyError is not helpful. It is better to use a new exception with more meaningful message.\n\nIf you need to reraise the exception, please use excutils.save_and_reraise_exception.\n\n  except KeyError:\n    with excutils.save_and_reraise_exception() as ctxt:\n      if q_type \u003d\u003d \u0027port\u0027:\n        ctxt.reraise \u003d False\n        ...\n      elif q_type \u003d\u003d \u0027network\u0027:\n        ctxt.reraise \u003d False\n        ..","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"574f6e2a84875198bb6eb32fd95bf5c626727b56","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                self._set_obj_tenant_id(obj_uuid, tenant_id)"},{"line_number":195,"context_line":"                return tenant_id"},{"line_number":196,"context_line":"            else:"},{"line_number":197,"context_line":"                raise e"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _set_obj_tenant_id(self, obj_uuid, tenant_uuid):"},{"line_number":200,"context_line":"        self._db_cache[\u0027q_obj_to_tenant\u0027][obj_uuid] \u003d tenant_uuid"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FWGM%3D","line":197,"in_reply_to":"AAAAUX%2F%2FYww%3D","updated":"2014-02-14 00:42:48.000000000","message":"I will be more specfic when raising error","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"643fff30b5e640c943a9279e1882e10608c59484","unresolved":false,"context_lines":[{"line_number":407,"context_line":"    # find network ids on a given project"},{"line_number":408,"context_line":"    def _network_list_project(self, project_id):"},{"line_number":409,"context_line":"        try:"},{"line_number":410,"context_line":"            project_uuid \u003d str(uuid.UUID(project_id))"},{"line_number":411,"context_line":"        except Exception:"},{"line_number":412,"context_line":"            LOG.warning(_(\"Error in converting uuid: %r\"), project_id)"},{"line_number":413,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FYv0%3D","line":410,"updated":"2014-02-13 15:47:00.000000000","message":"It is better to be more specific. It applies to other similar codes.","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"574f6e2a84875198bb6eb32fd95bf5c626727b56","unresolved":false,"context_lines":[{"line_number":407,"context_line":"    # find network ids on a given project"},{"line_number":408,"context_line":"    def _network_list_project(self, project_id):"},{"line_number":409,"context_line":"        try:"},{"line_number":410,"context_line":"            project_uuid \u003d str(uuid.UUID(project_id))"},{"line_number":411,"context_line":"        except Exception:"},{"line_number":412,"context_line":"            LOG.warning(_(\"Error in converting uuid: %r\"), project_id)"},{"line_number":413,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FWFY%3D","line":410,"in_reply_to":"AAAAUX%2F%2FYv0%3D","updated":"2014-02-14 00:42:48.000000000","message":"i dont understand this comment, please give some details or examples.","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"55180b641b221b51f3a0a71baeecd755e8855c04","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def _obj_to_dict(self, obj):"},{"line_number":124,"context_line":"        return self._vnc_lib.obj_to_dict(obj)"},{"line_number":125,"context_line":"    #end _obj_to_dict"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _ensure_instance_exists(self, instance_id):"},{"line_number":128,"context_line":"        if not instance_id:"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2BrgA%3D","line":125,"updated":"2014-02-19 20:41:52.000000000","message":"not needed comment","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"346d601cf47e2cb655ee6f4d6da3f7ac6347804a","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def _obj_to_dict(self, obj):"},{"line_number":124,"context_line":"        return self._vnc_lib.obj_to_dict(obj)"},{"line_number":125,"context_line":"    #end _obj_to_dict"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _ensure_instance_exists(self, instance_id):"},{"line_number":128,"context_line":"        if not instance_id:"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2BgeA%3D","line":125,"in_reply_to":"AAAAUX%2F%2BrgA%3D","updated":"2014-02-20 19:58:53.000000000","message":"Done","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"55180b641b221b51f3a0a71baeecd755e8855c04","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    def _ensure_instance_exists(self, instance_id):"},{"line_number":128,"context_line":"        if not instance_id:"},{"line_number":129,"context_line":"            # in VNC representation port always under an instance, create dummy"},{"line_number":130,"context_line":"            instance_name \u003d \u0027default-virtual-machine\u0027"},{"line_number":131,"context_line":"        else:"},{"line_number":132,"context_line":"            instance_name \u003d instance_id"},{"line_number":133,"context_line":"        instance_obj \u003d vnc_api.VirtualMachine(instance_name)"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2Breg%3D","line":130,"updated":"2014-02-19 20:41:52.000000000","message":"Is it safe if port stays in same default instance?\nWhy port always stays under an instance?","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":55,"name":"Édouard Thuleau","email":"ethuleau@juniper.net","username":"ethuleau"},"change_message_id":"c676a49ae46572c4b213d03911caff195dc9aa00","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    def _ensure_instance_exists(self, instance_id):"},{"line_number":128,"context_line":"        if not instance_id:"},{"line_number":129,"context_line":"            # in VNC representation port always under an instance, create dummy"},{"line_number":130,"context_line":"            instance_name \u003d \u0027default-virtual-machine\u0027"},{"line_number":131,"context_line":"        else:"},{"line_number":132,"context_line":"            instance_name \u003d instance_id"},{"line_number":133,"context_line":"        instance_obj \u003d vnc_api.VirtualMachine(instance_name)"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2BYZM%3D","line":130,"in_reply_to":"AAAAUX%2F%2BgdM%3D","updated":"2014-02-21 15:25:14.000000000","message":"But Nova boot command permits to boot a VM with a specific port.\n\nIf the port is associated to fake device (virtual machine for Contrail), the boot command fails with error \u0027Port \u003cUUID\u003e is still in use. (HTTP 409)\u0027 as explained in contrail bug https://bugs.launchpad.net/opencontrail/+bug/1272418","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"346d601cf47e2cb655ee6f4d6da3f7ac6347804a","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    def _ensure_instance_exists(self, instance_id):"},{"line_number":128,"context_line":"        if not instance_id:"},{"line_number":129,"context_line":"            # in VNC representation port always under an instance, create dummy"},{"line_number":130,"context_line":"            instance_name \u003d \u0027default-virtual-machine\u0027"},{"line_number":131,"context_line":"        else:"},{"line_number":132,"context_line":"            instance_name \u003d instance_id"},{"line_number":133,"context_line":"        instance_obj \u003d vnc_api.VirtualMachine(instance_name)"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2BgdM%3D","line":130,"in_reply_to":"AAAAUX%2F%2Breg%3D","updated":"2014-02-20 19:58:53.000000000","message":"Yes it is safe, this is by design, our schema has port under an instance.","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"55180b641b221b51f3a0a71baeecd755e8855c04","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            instance_obj \u003d self._vnc_lib.virtual_machine_read(id\u003did)"},{"line_number":137,"context_line":"        except vnc_exc.NoIdError:  # instance doesn\u0027t exist, create it"},{"line_number":138,"context_line":"            instance_obj.uuid \u003d instance_id"},{"line_number":139,"context_line":"            self._vnc_lib.virtual_machine_create(instance_obj)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        return instance_obj"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2BreI%3D","line":139,"updated":"2014-02-19 20:41:52.000000000","message":"What\u0027s if two request come to same time?\nwe will have two instance?","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"346d601cf47e2cb655ee6f4d6da3f7ac6347804a","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            instance_obj \u003d self._vnc_lib.virtual_machine_read(id\u003did)"},{"line_number":137,"context_line":"        except vnc_exc.NoIdError:  # instance doesn\u0027t exist, create it"},{"line_number":138,"context_line":"            instance_obj.uuid \u003d instance_id"},{"line_number":139,"context_line":"            self._vnc_lib.virtual_machine_create(instance_obj)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        return instance_obj"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2Bgdo%3D","line":139,"in_reply_to":"AAAAUX%2F%2BreI%3D","updated":"2014-02-20 19:58:53.000000000","message":"We will not have two instances, only one instance","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"55180b641b221b51f3a0a71baeecd755e8855c04","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            \u0027remote_group_id\u0027: None,"},{"line_number":173,"context_line":"            \u0027protocol\u0027: \u0027any\u0027,"},{"line_number":174,"context_line":"        }"},{"line_number":175,"context_line":"        rule \u003d self._security_group_rule_neutron_to_vnc(def_rule, CREATE)"},{"line_number":176,"context_line":"        self._security_group_rule_create(sg_obj.uuid, rule)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def _get_obj_tenant_id(self, q_type, obj_uuid):"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2Brcs%3D","line":175,"updated":"2014-02-19 20:41:52.000000000","message":"Question: it looks like same with allow all connection rule..\nHow we apply this for only same default groups?","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"346d601cf47e2cb655ee6f4d6da3f7ac6347804a","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            \u0027remote_group_id\u0027: None,"},{"line_number":173,"context_line":"            \u0027protocol\u0027: \u0027any\u0027,"},{"line_number":174,"context_line":"        }"},{"line_number":175,"context_line":"        rule \u003d self._security_group_rule_neutron_to_vnc(def_rule, CREATE)"},{"line_number":176,"context_line":"        self._security_group_rule_create(sg_obj.uuid, rule)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def _get_obj_tenant_id(self, q_type, obj_uuid):"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2Bgcs%3D","line":175,"in_reply_to":"AAAAUX%2F%2Brcs%3D","updated":"2014-02-20 19:58:53.000000000","message":"security group rule is under a specific security group.","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9cd640f78303e838d93fe977b6d972e3bc032e25","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# @author: Hampapur Ajay, Rudra Rugge, Atul Moghe Juniper Networks."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import json"},{"line_number":20,"context_line":"import re"},{"line_number":21,"context_line":"import socket"},{"line_number":22,"context_line":"import time"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2F%2FC8%3D","line":19,"updated":"2014-02-23 02:44:39.000000000","message":"from neutron.openstack.common import json","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"83cb8c45241a0d0cdee92db7e9ebcdc4f6eafd2f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# @author: Hampapur Ajay, Rudra Rugge, Atul Moghe Juniper Networks."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import json"},{"line_number":20,"context_line":"import re"},{"line_number":21,"context_line":"import socket"},{"line_number":22,"context_line":"import time"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2Fy8o%3D","line":19,"in_reply_to":"AAAAU3%2F%2F%2FC8%3D","updated":"2014-02-25 21:19:57.000000000","message":"Done","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9cd640f78303e838d93fe977b6d972e3bc032e25","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import netaddr"},{"line_number":26,"context_line":"import requests"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from cfgm_common import exceptions as vnc_exc"},{"line_number":29,"context_line":"from neutron.api.v2 import attributes as attr"},{"line_number":30,"context_line":"from neutron.common import constants"},{"line_number":31,"context_line":"from neutron.common import exceptions"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2F%2FC4%3D","line":28,"updated":"2014-02-23 02:44:39.000000000","message":"This should be in the 2nd group of imports.","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"83cb8c45241a0d0cdee92db7e9ebcdc4f6eafd2f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import netaddr"},{"line_number":26,"context_line":"import requests"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from cfgm_common import exceptions as vnc_exc"},{"line_number":29,"context_line":"from neutron.api.v2 import attributes as attr"},{"line_number":30,"context_line":"from neutron.common import constants"},{"line_number":31,"context_line":"from neutron.common import exceptions"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2Fy8M%3D","line":28,"in_reply_to":"AAAAU3%2F%2F%2FC4%3D","updated":"2014-02-25 21:19:57.000000000","message":"Done","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9cd640f78303e838d93fe977b6d972e3bc032e25","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from neutron.common import constants"},{"line_number":31,"context_line":"from neutron.common import exceptions"},{"line_number":32,"context_line":"from neutron.openstack.common import log as logging"},{"line_number":33,"context_line":"from vnc_api import vnc_api"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2F%2FC0%3D","line":33,"updated":"2014-02-23 02:44:39.000000000","message":"This should be in the 2nd group of imports.","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"83cb8c45241a0d0cdee92db7e9ebcdc4f6eafd2f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from neutron.common import constants"},{"line_number":31,"context_line":"from neutron.common import exceptions"},{"line_number":32,"context_line":"from neutron.openstack.common import log as logging"},{"line_number":33,"context_line":"from vnc_api import vnc_api"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2Fy8I%3D","line":33,"in_reply_to":"AAAAU3%2F%2F%2FC0%3D","updated":"2014-02-25 21:19:57.000000000","message":"Done","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"1c506fe0e0af6f182030df5907ea9da1b1df4e65","unresolved":false,"context_lines":[{"line_number":1676,"context_line":"                    continue"},{"line_number":1677,"context_line":"                ret_list.append(sg_info)"},{"line_number":1678,"context_line":""},{"line_number":1679,"context_line":"        #import pdb; pdb.set_trace()"},{"line_number":1680,"context_line":"        return ret_list"},{"line_number":1681,"context_line":""},{"line_number":1682,"context_line":"    def security_group_rule_create(self, sgr_q):"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAU3%2F%2FaV0%3D","line":1679,"updated":"2014-02-26 19:39:40.000000000","message":"remove this","commit_id":"4eaa484f5803b4eb14eb2a2e461462ddb3ccac5e"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"2e192fa2a24bb8420dbb02a46a760b5cb93ee7e3","unresolved":false,"context_lines":[{"line_number":1676,"context_line":"                    continue"},{"line_number":1677,"context_line":"                ret_list.append(sg_info)"},{"line_number":1678,"context_line":""},{"line_number":1679,"context_line":"        #import pdb; pdb.set_trace()"},{"line_number":1680,"context_line":"        return ret_list"},{"line_number":1681,"context_line":""},{"line_number":1682,"context_line":"    def security_group_rule_create(self, sgr_q):"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAVX%2F%2F9u8%3D","line":1679,"in_reply_to":"AAAAU3%2F%2FZIE%3D","updated":"2014-02-27 05:01:20.000000000","message":"Done","commit_id":"4eaa484f5803b4eb14eb2a2e461462ddb3ccac5e"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"4679105b24b9645e9385787c8c68bd6b07ea90a5","unresolved":false,"context_lines":[{"line_number":1676,"context_line":"                    continue"},{"line_number":1677,"context_line":"                ret_list.append(sg_info)"},{"line_number":1678,"context_line":""},{"line_number":1679,"context_line":"        #import pdb; pdb.set_trace()"},{"line_number":1680,"context_line":"        return ret_list"},{"line_number":1681,"context_line":""},{"line_number":1682,"context_line":"    def security_group_rule_create(self, sgr_q):"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAU3%2F%2FZIE%3D","line":1679,"in_reply_to":"AAAAU3%2F%2FaV0%3D","updated":"2014-02-26 21:38:57.000000000","message":"Done","commit_id":"4eaa484f5803b4eb14eb2a2e461462ddb3ccac5e"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"2e192fa2a24bb8420dbb02a46a760b5cb93ee7e3","unresolved":false,"context_lines":[{"line_number":1676,"context_line":"                    continue"},{"line_number":1677,"context_line":"                ret_list.append(sg_info)"},{"line_number":1678,"context_line":""},{"line_number":1679,"context_line":"        #import pdb; pdb.set_trace()"},{"line_number":1680,"context_line":"        return ret_list"},{"line_number":1681,"context_line":""},{"line_number":1682,"context_line":"    def security_group_rule_create(self, sgr_q):"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAVX%2F%2F9vI%3D","line":1679,"in_reply_to":"AAAAU3%2F%2FaV0%3D","updated":"2014-02-27 05:01:20.000000000","message":"Done","commit_id":"4eaa484f5803b4eb14eb2a2e461462ddb3ccac5e"}],"neutron/tests/unit/juniper/__init__.py":[{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"d4764e6da5d87962786841bfa96d482cf966ea36","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"# You may obtain a copy of the License at"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"# Unless required by applicable law or agreed to in writing, software"},{"line_number":10,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS,"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUH%2F9qa8%3D","line":7,"updated":"2014-02-05 08:38:58.000000000","message":"ditto\nBTW. Year is totally outdated!!  :-)","commit_id":"d0a6fc6b3277166d726e8fe332e1b7dbc3586522"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"86156603e1097114af7a258f378c53770cbb0b2e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"# You may obtain a copy of the License at"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"# Unless required by applicable law or agreed to in writing, software"},{"line_number":10,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS,"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUH%2F9mwQ%3D","line":7,"in_reply_to":"AAAAUH%2F9qa8%3D","updated":"2014-02-05 18:49:20.000000000","message":"Done","commit_id":"d0a6fc6b3277166d726e8fe332e1b7dbc3586522"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"643fff30b5e640c943a9279e1882e10608c59484","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or"},{"line_number":12,"context_line":"# implied."},{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FYyw%3D","line":14,"updated":"2014-02-13 15:47:00.000000000","message":"__init__.py now should be empty.","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"574f6e2a84875198bb6eb32fd95bf5c626727b56","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or"},{"line_number":12,"context_line":"# implied."},{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FWDs%3D","line":14,"in_reply_to":"AAAAUX%2F%2FYyw%3D","updated":"2014-02-14 00:42:48.000000000","message":"Done","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"}],"neutron/tests/unit/juniper/test_contrail_plugin.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import datetime"},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"import neutron.db.api"},{"line_number":19,"context_line":"from neutron.manager import NeutronManager"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqKg%3D","line":16,"updated":"2013-09-01 02:50:32.000000000","message":"PEP8 import ordering errors.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import datetime"},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"import neutron.db.api"},{"line_number":19,"context_line":"from neutron.manager import NeutronManager"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYbc%3D","line":16,"in_reply_to":"AAAASn%2F%2FqKg%3D","updated":"2013-10-07 16:59:22.000000000","message":"will change as suggested","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    return GlobalProjects[0]"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"# Mock definations for different pkgs, modules and VncApi"},{"line_number":252,"context_line":"mock_vnc_api_cls \u003d mock.MagicMock(name\u003d\u0027MockVncApi\u0027, side_effect\u003dMockVncApi)"},{"line_number":253,"context_line":"mock_vnc_api_mod \u003d mock.MagicMock(name\u003d\u0027vnc_api_mock_mod\u0027)"},{"line_number":254,"context_line":"mock_vnc_api_mod.VncApi \u003d mock_vnc_api_cls"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqKY%3D","line":251,"updated":"2013-09-01 02:50:32.000000000","message":"You should be using mock.patch in the appropriate place instead of manually patching the library.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    return GlobalProjects[0]"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"# Mock definations for different pkgs, modules and VncApi"},{"line_number":252,"context_line":"mock_vnc_api_cls \u003d mock.MagicMock(name\u003d\u0027MockVncApi\u0027, side_effect\u003dMockVncApi)"},{"line_number":253,"context_line":"mock_vnc_api_mod \u003d mock.MagicMock(name\u003d\u0027vnc_api_mock_mod\u0027)"},{"line_number":254,"context_line":"mock_vnc_api_mod.VncApi \u003d mock_vnc_api_cls"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FX00%3D","line":251,"in_reply_to":"AAAASn%2F%2FqKY%3D","updated":"2013-10-07 16:59:22.000000000","message":"We were looking for tighter control on mock methods, therefore created a patch using magicMock(), will explore to see if we can use mock.patch","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":323,"context_line":"        networks_req \u003d {}"},{"line_number":324,"context_line":"        network \u003d {}"},{"line_number":325,"context_line":"        router_inst \u003d RouterInstance()"},{"line_number":326,"context_line":"        network[\u0027router:external\u0027] \u003d router_inst"},{"line_number":327,"context_line":"        network[u\u0027name\u0027] \u003d u\u0027network1\u0027"},{"line_number":328,"context_line":"        network[\u0027admin_state_up\u0027] \u003d \u0027True\u0027"},{"line_number":329,"context_line":"        network[\u0027tenant_id\u0027] \u003d uuid.uuid4().hex.decode()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqKQ%3D","line":326,"updated":"2013-09-01 02:50:32.000000000","message":"The dict should be defined in one step.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":323,"context_line":"        networks_req \u003d {}"},{"line_number":324,"context_line":"        network \u003d {}"},{"line_number":325,"context_line":"        router_inst \u003d RouterInstance()"},{"line_number":326,"context_line":"        network[\u0027router:external\u0027] \u003d router_inst"},{"line_number":327,"context_line":"        network[u\u0027name\u0027] \u003d u\u0027network1\u0027"},{"line_number":328,"context_line":"        network[\u0027admin_state_up\u0027] \u003d \u0027True\u0027"},{"line_number":329,"context_line":"        network[\u0027tenant_id\u0027] \u003d uuid.uuid4().hex.decode()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FY0w%3D","line":326,"in_reply_to":"AAAASn%2F%2FqKQ%3D","updated":"2013-10-07 16:59:22.000000000","message":"will take care of it.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        networks_req \u003d {}"},{"line_number":353,"context_line":"        network \u003d {}"},{"line_number":354,"context_line":"        router_inst \u003d RouterInstance()"},{"line_number":355,"context_line":"        network[\u0027router:external\u0027] \u003d router_inst"},{"line_number":356,"context_line":"        network[u\u0027name\u0027] \u003d u\u0027network1\u0027"},{"line_number":357,"context_line":"        network[\u0027admin_state_up\u0027] \u003d \u0027True\u0027"},{"line_number":358,"context_line":"        network[\u0027tenant_id\u0027] \u003d uuid.uuid4().hex.decode()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqKM%3D","line":355,"updated":"2013-09-01 02:50:32.000000000","message":"This dict should be defined in one step.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        networks_req \u003d {}"},{"line_number":353,"context_line":"        network \u003d {}"},{"line_number":354,"context_line":"        router_inst \u003d RouterInstance()"},{"line_number":355,"context_line":"        network[\u0027router:external\u0027] \u003d router_inst"},{"line_number":356,"context_line":"        network[u\u0027name\u0027] \u003d u\u0027network1\u0027"},{"line_number":357,"context_line":"        network[\u0027admin_state_up\u0027] \u003d \u0027True\u0027"},{"line_number":358,"context_line":"        network[\u0027tenant_id\u0027] \u003d uuid.uuid4().hex.decode()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FY0o%3D","line":355,"in_reply_to":"AAAASn%2F%2FqKM%3D","updated":"2013-10-07 16:59:22.000000000","message":"will take care of it","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":379,"context_line":"        networks_req \u003d {}"},{"line_number":380,"context_line":"        network \u003d {}"},{"line_number":381,"context_line":"        router_inst \u003d RouterInstance()"},{"line_number":382,"context_line":"        network[\u0027router:external\u0027] \u003d router_inst"},{"line_number":383,"context_line":"        network[u\u0027name\u0027] \u003d u\u0027network1\u0027"},{"line_number":384,"context_line":"        network[\u0027admin_state_up\u0027] \u003d \u0027True\u0027"},{"line_number":385,"context_line":"        network[\u0027tenant_id\u0027] \u003d uuid.uuid4().hex.decode()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqKI%3D","line":382,"updated":"2013-09-01 02:50:32.000000000","message":"This dict should created in one instruction.","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":379,"context_line":"        networks_req \u003d {}"},{"line_number":380,"context_line":"        network \u003d {}"},{"line_number":381,"context_line":"        router_inst \u003d RouterInstance()"},{"line_number":382,"context_line":"        network[\u0027router:external\u0027] \u003d router_inst"},{"line_number":383,"context_line":"        network[u\u0027name\u0027] \u003d u\u0027network1\u0027"},{"line_number":384,"context_line":"        network[\u0027admin_state_up\u0027] \u003d \u0027True\u0027"},{"line_number":385,"context_line":"        network[\u0027tenant_id\u0027] \u003d uuid.uuid4().hex.decode()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FY0g%3D","line":382,"in_reply_to":"AAAASn%2F%2FqKI%3D","updated":"2013-10-07 16:59:22.000000000","message":"will take care of it","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":401,"context_line":"        network[\u0027admin_state_up\u0027] \u003d \u0027False\u0027"},{"line_number":402,"context_line":"        new_dict \u003d plugin_obj.update_network(context_obj, net_id,"},{"line_number":403,"context_line":"                                             networks_req)"},{"line_number":404,"context_line":"        if (net_dict.get(\u0027admin_state_up\u0027) \u003d\u003d new_dict.get(\u0027admin_state_up\u0027)):"},{"line_number":405,"context_line":"            assert False"},{"line_number":406,"context_line":"        else:"},{"line_number":407,"context_line":"            assert True"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqJ8%3D","line":404,"updated":"2013-09-01 02:50:32.000000000","message":"you should be using the correct assert method instead of building your own.\n\nself.assertNotEqual(net_dict.get(\u0027admin_state_up\u0027), new_dict.get(\u0027admin_state_up\u0027))","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":401,"context_line":"        network[\u0027admin_state_up\u0027] \u003d \u0027False\u0027"},{"line_number":402,"context_line":"        new_dict \u003d plugin_obj.update_network(context_obj, net_id,"},{"line_number":403,"context_line":"                                             networks_req)"},{"line_number":404,"context_line":"        if (net_dict.get(\u0027admin_state_up\u0027) \u003d\u003d new_dict.get(\u0027admin_state_up\u0027)):"},{"line_number":405,"context_line":"            assert False"},{"line_number":406,"context_line":"        else:"},{"line_number":407,"context_line":"            assert True"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FY0U%3D","line":404,"in_reply_to":"AAAASn%2F%2FqJ8%3D","updated":"2013-10-07 16:59:22.000000000","message":"will take of it as suggested","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"00dc4314f6e839710fa2e32070e2ba6658dba591","unresolved":false,"context_lines":[{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        subnet_obj[u\u0027subnet\u0027][\u0027network_id\u0027] \u003d net[\u0027id\u0027]"},{"line_number":509,"context_line":"        subnet_dict \u003d plugin_obj.create_subnet(context_obj, subnet_obj)"},{"line_number":510,"context_line":"        if subnet_dict[\u0027cidr\u0027] !\u003d subnet_obj[\u0027subnet\u0027][\u0027cidr\u0027]:"},{"line_number":511,"context_line":"            assert False"},{"line_number":512,"context_line":"        else:"},{"line_number":513,"context_line":"            assert True"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FqJ4%3D","line":510,"updated":"2013-09-01 02:50:32.000000000","message":"self.assertEqual()","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"9840f3253838642c950855c9882d6535fcf79cf8","unresolved":false,"context_lines":[{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        subnet_obj[u\u0027subnet\u0027][\u0027network_id\u0027] \u003d net[\u0027id\u0027]"},{"line_number":509,"context_line":"        subnet_dict \u003d plugin_obj.create_subnet(context_obj, subnet_obj)"},{"line_number":510,"context_line":"        if subnet_dict[\u0027cidr\u0027] !\u003d subnet_obj[\u0027subnet\u0027][\u0027cidr\u0027]:"},{"line_number":511,"context_line":"            assert False"},{"line_number":512,"context_line":"        else:"},{"line_number":513,"context_line":"            assert True"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FY0Q%3D","line":510,"in_reply_to":"AAAASn%2F%2FqJ4%3D","updated":"2013-10-07 16:59:22.000000000","message":"will change as suggested","commit_id":"19fd77fed54e3506221662418090a1b8e7f454aa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"9dd4f0676dcdceaca22e33787db19aebd5e520e6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2012 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2Fosc%3D","line":1,"updated":"2013-10-11 23:20:15.000000000","message":"In this test module, many unit test is a just blank.\nCould you add body for them?","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"a4bd43763c61adba6a3aacb51fa6017a31f77751","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2012 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2Fh9o%3D","line":1,"in_reply_to":"AAAATH%2F%2FiQ4%3D","updated":"2013-10-14 22:18:08.000000000","message":"Done","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"9d12496a6b54b3de5349a3ea2938bbf792661c3a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2012 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FiQ4%3D","line":1,"in_reply_to":"AAAATH%2F%2Figc%3D","updated":"2013-10-14 21:01:27.000000000","message":"if so, you should use @skip","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":8583,"name":"Atul Moghe","email":"amoghe@juniper.net","username":"amoghe"},"change_message_id":"0e9c47c0dffc00e9953c67b728cadb836db069d9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2012 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2Figc%3D","line":1,"in_reply_to":"AAAATH%2F%2Fosc%3D","updated":"2013-10-14 19:57:20.000000000","message":"this is to make sure that test cases added in parents are handled properly. some of the test cases are not relevant to this plugin but defined in parent class, otherwise Jenkins unit test will fail","commit_id":"bff7ea328e6a284dbe3dbc31c04ae5e9e129d69d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"643fff30b5e640c943a9279e1882e10608c59484","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import datetime"},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"import sys"},{"line_number":19,"context_line":"import uuid"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import neutron.db.api"},{"line_number":22,"context_line":"from neutron.manager import NeutronManager"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FYm8%3D","line":19,"updated":"2014-02-13 15:47:00.000000000","message":"Please split standard and thirdparty modules into separate sections?","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"574f6e2a84875198bb6eb32fd95bf5c626727b56","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import datetime"},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"import sys"},{"line_number":19,"context_line":"import uuid"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import neutron.db.api"},{"line_number":22,"context_line":"from neutron.manager import NeutronManager"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FWDQ%3D","line":19,"in_reply_to":"AAAAUX%2F%2FYm8%3D","updated":"2014-02-14 00:42:48.000000000","message":"Done","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"643fff30b5e640c943a9279e1882e10608c59484","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"class MockVncObject(mock.MagicMock):"},{"line_number":82,"context_line":"    def __init__(self, name\u003dNone, parent_obj\u003dNone, *args, **kwargs):"},{"line_number":83,"context_line":"        super(mock.MagicMock, self).__init__()"},{"line_number":84,"context_line":"        if not parent_obj:"},{"line_number":85,"context_line":"            self._fq_name \u003d [name]"},{"line_number":86,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FYls%3D","line":83,"updated":"2014-02-13 15:47:00.000000000","message":"Should it be \"super(MockVncObject, self).__init__()\"? Why not?","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"574f6e2a84875198bb6eb32fd95bf5c626727b56","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"class MockVncObject(mock.MagicMock):"},{"line_number":82,"context_line":"    def __init__(self, name\u003dNone, parent_obj\u003dNone, *args, **kwargs):"},{"line_number":83,"context_line":"        super(mock.MagicMock, self).__init__()"},{"line_number":84,"context_line":"        if not parent_obj:"},{"line_number":85,"context_line":"            self._fq_name \u003d [name]"},{"line_number":86,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FVMs%3D","line":83,"in_reply_to":"AAAAUX%2F%2FYls%3D","updated":"2014-02-14 00:42:48.000000000","message":"Done","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"643fff30b5e640c943a9279e1882e10608c59484","unresolved":false,"context_lines":[{"line_number":132,"context_line":"class MockSubnetType(mock.MagicMock):"},{"line_number":133,"context_line":"    def __init__(self, name\u003dNone, ip_prefix\u003dNone, ip_prefix_len\u003dNone,"},{"line_number":134,"context_line":"                 *args, **kwargs):"},{"line_number":135,"context_line":"        super(mock.MagicMock, self).__init__()"},{"line_number":136,"context_line":"        self.ip_prefix \u003d ip_prefix"},{"line_number":137,"context_line":"        self.ip_prefix_len \u003d ip_prefix_len"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FYlQ%3D","line":135,"updated":"2014-02-13 15:47:00.000000000","message":"Same as the above.","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"574f6e2a84875198bb6eb32fd95bf5c626727b56","unresolved":false,"context_lines":[{"line_number":132,"context_line":"class MockSubnetType(mock.MagicMock):"},{"line_number":133,"context_line":"    def __init__(self, name\u003dNone, ip_prefix\u003dNone, ip_prefix_len\u003dNone,"},{"line_number":134,"context_line":"                 *args, **kwargs):"},{"line_number":135,"context_line":"        super(mock.MagicMock, self).__init__()"},{"line_number":136,"context_line":"        self.ip_prefix \u003d ip_prefix"},{"line_number":137,"context_line":"        self.ip_prefix_len \u003d ip_prefix_len"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FVMk%3D","line":135,"in_reply_to":"AAAAUX%2F%2FYlQ%3D","updated":"2014-02-14 00:42:48.000000000","message":"Done","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"643fff30b5e640c943a9279e1882e10608c59484","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        self.assertNotEqual(net_dict.get(\u0027admin_state_up\u0027),"},{"line_number":409,"context_line":"                            new_dict.get(\u0027admin_state_up\u0027))"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    # Not supported test cases in the this TestClass"},{"line_number":412,"context_line":"    def test_create_networks_bulk_emulated(self):"},{"line_number":413,"context_line":"        pass"},{"line_number":414,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FYio%3D","line":411,"updated":"2014-02-13 15:47:00.000000000","message":"This kinds of test skipping is really fragile.\nIf someone adds a new test to base test classes, he/she is forced to update this test. It is not desirable and should be avoided.","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"574f6e2a84875198bb6eb32fd95bf5c626727b56","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        self.assertNotEqual(net_dict.get(\u0027admin_state_up\u0027),"},{"line_number":409,"context_line":"                            new_dict.get(\u0027admin_state_up\u0027))"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    # Not supported test cases in the this TestClass"},{"line_number":412,"context_line":"    def test_create_networks_bulk_emulated(self):"},{"line_number":413,"context_line":"        pass"},{"line_number":414,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FVMM%3D","line":411,"in_reply_to":"AAAAUX%2F%2FYio%3D","updated":"2014-02-14 00:42:48.000000000","message":"We want to know if someone adds a new test case to base class, and then we will decide if we need to implement or skip.","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"55180b641b221b51f3a0a71baeecd755e8855c04","unresolved":false,"context_lines":[{"line_number":548,"context_line":"        subnet_id \u003d subnet_dict[\u0027id\u0027]"},{"line_number":549,"context_line":"        plugin_obj.delete_subnet(context_obj, subnet_id)"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    def test_update_subnet_gateway_in_allocation_pool_returns_409(self):"},{"line_number":552,"context_line":"        pass"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"    def test_delete_network(self):"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2Brhk%3D","line":551,"updated":"2014-02-19 20:41:52.000000000","message":"IMO, we should pass these tests","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"346d601cf47e2cb655ee6f4d6da3f7ac6347804a","unresolved":false,"context_lines":[{"line_number":548,"context_line":"        subnet_id \u003d subnet_dict[\u0027id\u0027]"},{"line_number":549,"context_line":"        plugin_obj.delete_subnet(context_obj, subnet_id)"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    def test_update_subnet_gateway_in_allocation_pool_returns_409(self):"},{"line_number":552,"context_line":"        pass"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"    def test_delete_network(self):"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2Bgb8%3D","line":551,"in_reply_to":"AAAAUX%2F%2Brhk%3D","updated":"2014-02-20 19:58:53.000000000","message":"I will see each of these test cases to see if we can avoid skipping them","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"55180b641b221b51f3a0a71baeecd755e8855c04","unresolved":false,"context_lines":[{"line_number":823,"context_line":"        pass"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"class TestContrailPortsV2(test_plugin.TestPortsV2,"},{"line_number":827,"context_line":"                          JVContrailPluginTestCase):"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"    def test_create_port(self):"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2BrhY%3D","line":826,"updated":"2014-02-19 20:41:52.000000000","message":"IMO, we should pass these tests","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"346d601cf47e2cb655ee6f4d6da3f7ac6347804a","unresolved":false,"context_lines":[{"line_number":823,"context_line":"        pass"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"class TestContrailPortsV2(test_plugin.TestPortsV2,"},{"line_number":827,"context_line":"                          JVContrailPluginTestCase):"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"    def test_create_port(self):"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUX%2F%2Bgbs%3D","line":826,"in_reply_to":"AAAAUX%2F%2BrhY%3D","updated":"2014-02-20 19:58:53.000000000","message":"I will see each of these test cases to see if we can avoid skipping them","commit_id":"377ad2183856861b057ca1f9d3464b3fe4c4fc88"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9cd640f78303e838d93fe977b6d972e3bc032e25","unresolved":false,"context_lines":[{"line_number":35,"context_line":"               \u0027gateway_ip\u0027: \u0027\u0027, u\u0027cidr\u0027: u\u002720.20.1.0/29\u0027}}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"vn_list \u003d []"},{"line_number":38,"context_line":"GlobalProjects \u003d []"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class MockVncApi(mock.MagicMock):"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2F%2FCQ%3D","line":38,"updated":"2014-02-23 02:44:39.000000000","message":"PEP8 naming violation.","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"83cb8c45241a0d0cdee92db7e9ebcdc4f6eafd2f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"               \u0027gateway_ip\u0027: \u0027\u0027, u\u0027cidr\u0027: u\u002720.20.1.0/29\u0027}}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"vn_list \u003d []"},{"line_number":38,"context_line":"GlobalProjects \u003d []"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class MockVncApi(mock.MagicMock):"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2Fy20%3D","line":38,"in_reply_to":"AAAAU3%2F%2F%2FCQ%3D","updated":"2014-02-25 21:19:57.000000000","message":"Done","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9cd640f78303e838d93fe977b6d972e3bc032e25","unresolved":false,"context_lines":[{"line_number":548,"context_line":"        subnet_id \u003d subnet_dict[\u0027id\u0027]"},{"line_number":549,"context_line":"        plugin_obj.delete_subnet(context_obj, subnet_id)"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    def test_update_subnet_gateway_in_allocation_pool_returns_409(self):"},{"line_number":552,"context_line":"        pass"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"    def test_delete_network(self):"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2F%2FCM%3D","line":551,"updated":"2014-02-23 02:44:39.000000000","message":"You\u0027re skipping lots of tests.","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"83cb8c45241a0d0cdee92db7e9ebcdc4f6eafd2f","unresolved":false,"context_lines":[{"line_number":548,"context_line":"        subnet_id \u003d subnet_dict[\u0027id\u0027]"},{"line_number":549,"context_line":"        plugin_obj.delete_subnet(context_obj, subnet_id)"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    def test_update_subnet_gateway_in_allocation_pool_returns_409(self):"},{"line_number":552,"context_line":"        pass"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"    def test_delete_network(self):"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAU3%2F%2Flnc%3D","line":551,"in_reply_to":"AAAAU3%2F%2F%2FCM%3D","updated":"2014-02-25 21:19:57.000000000","message":"Some test cases are skipped as we don not support some extensions. \nWe will keep adding more test cases.","commit_id":"093080585e1f2651c887a12aa6e2af558be6272b"}],"setup.cfg":[{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"d4764e6da5d87962786841bfa96d482cf966ea36","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    etc/neutron/plugins/plumgrid \u003d etc/neutron/plugins/plumgrid/plumgrid.ini"},{"line_number":66,"context_line":"    etc/neutron/plugins/ryu \u003d etc/neutron/plugins/ryu/ryu.ini"},{"line_number":67,"context_line":"    etc/neutron/plugins/vmware \u003d etc/neutron/plugins/vmware/nsx.ini"},{"line_number":68,"context_line":"    etc/neutron/plugins/juniper/contrail/ContrailPlugin \u003d etc/neutron/plugins/juniper/contrail/ContrailPlugin.ini"},{"line_number":69,"context_line":"scripts \u003d"},{"line_number":70,"context_line":"    bin/quantum-rootwrap"},{"line_number":71,"context_line":"    bin/neutron-rootwrap"}],"source_content_type":"text/x-ttcn-cfg","patch_set":22,"id":"AAAAUH%2F9qag%3D","line":68,"updated":"2014-02-05 08:38:58.000000000","message":"will recommend to keep everything with lower case","commit_id":"d0a6fc6b3277166d726e8fe332e1b7dbc3586522"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"86156603e1097114af7a258f378c53770cbb0b2e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    etc/neutron/plugins/plumgrid \u003d etc/neutron/plugins/plumgrid/plumgrid.ini"},{"line_number":66,"context_line":"    etc/neutron/plugins/ryu \u003d etc/neutron/plugins/ryu/ryu.ini"},{"line_number":67,"context_line":"    etc/neutron/plugins/vmware \u003d etc/neutron/plugins/vmware/nsx.ini"},{"line_number":68,"context_line":"    etc/neutron/plugins/juniper/contrail/ContrailPlugin \u003d etc/neutron/plugins/juniper/contrail/ContrailPlugin.ini"},{"line_number":69,"context_line":"scripts \u003d"},{"line_number":70,"context_line":"    bin/quantum-rootwrap"},{"line_number":71,"context_line":"    bin/neutron-rootwrap"}],"source_content_type":"text/x-ttcn-cfg","patch_set":22,"id":"AAAAUH%2F9mvs%3D","line":68,"in_reply_to":"AAAAUH%2F9qag%3D","updated":"2014-02-05 18:49:20.000000000","message":"Done","commit_id":"d0a6fc6b3277166d726e8fe332e1b7dbc3586522"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"643fff30b5e640c943a9279e1882e10608c59484","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    etc/neutron/plugins/plumgrid \u003d etc/neutron/plugins/plumgrid/plumgrid.ini"},{"line_number":66,"context_line":"    etc/neutron/plugins/ryu \u003d etc/neutron/plugins/ryu/ryu.ini"},{"line_number":67,"context_line":"    etc/neutron/plugins/vmware \u003d etc/neutron/plugins/vmware/nsx.ini"},{"line_number":68,"context_line":"    etc/neutron/plugins/juniper/contrail/contrailplugin \u003d etc/neutron/plugins/juniper/contrail/contrailplugin.ini"},{"line_number":69,"context_line":"scripts \u003d"},{"line_number":70,"context_line":"    bin/quantum-rootwrap"},{"line_number":71,"context_line":"    bin/neutron-rootwrap"}],"source_content_type":"text/x-ttcn-cfg","patch_set":25,"id":"AAAAUX%2F%2FY1o%3D","line":68,"updated":"2014-02-13 15:47:00.000000000","message":"The plugin conf will be copied to etc/neturon/plugins/juniper/contrail/contrailplugin/contrailplugin.ini. Is it an intended behavior? IMO etc/neutron/plugins/juniper/contrailplugin.ini or juniper/contrail/contrailplugin.ini is sufficient\n\nThe entries are sorted in alphabetical order. Please move the right place.","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"574f6e2a84875198bb6eb32fd95bf5c626727b56","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    etc/neutron/plugins/plumgrid \u003d etc/neutron/plugins/plumgrid/plumgrid.ini"},{"line_number":66,"context_line":"    etc/neutron/plugins/ryu \u003d etc/neutron/plugins/ryu/ryu.ini"},{"line_number":67,"context_line":"    etc/neutron/plugins/vmware \u003d etc/neutron/plugins/vmware/nsx.ini"},{"line_number":68,"context_line":"    etc/neutron/plugins/juniper/contrail/contrailplugin \u003d etc/neutron/plugins/juniper/contrail/contrailplugin.ini"},{"line_number":69,"context_line":"scripts \u003d"},{"line_number":70,"context_line":"    bin/quantum-rootwrap"},{"line_number":71,"context_line":"    bin/neutron-rootwrap"}],"source_content_type":"text/x-ttcn-cfg","patch_set":25,"id":"AAAAUX%2F%2FWzo%3D","line":68,"in_reply_to":"AAAAUX%2F%2FY1o%3D","updated":"2014-02-14 00:42:48.000000000","message":"it gets copied to \"/etc/neutron/plugins/juniper/contrail/contrailplugin.ini\"","commit_id":"627c7c806f90d9ed29f37cb26fbbae93fe75a0be"}]}
