)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ac2ad30a17ed936176f990cedefc3c0137d5e747","unresolved":false,"context_lines":[{"line_number":7,"context_line":"DVR: Configure unbound floatingip ports to snat_namespace."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is the agent side patch that takes care of configuring"},{"line_number":10,"context_line":"the floatingip for the unbound ports in the snat_namespace."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I595ce4d6520adfd57bacbdf20ed03ffefd0b190a"},{"line_number":13,"context_line":"Closes-Bug: #1583694"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dfeb2761_243ce1c6","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":36},"updated":"2017-04-03 14:17:06.000000000","message":"Can we call them \"centralized floating IPs\"? Here and in code as well. There is an [rfe] about adding ability to schedule floating IPs to network/dvr_snat nodes so I believe this patch can be a bit more generic, in terms of naming an least..","commit_id":"8083b7642beaf4c899b124f7fb40cef2afa37413"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"822e89d7706c12794f97efe2d7603e03aed60c22","unresolved":false,"context_lines":[{"line_number":7,"context_line":"DVR: Configure unbound floatingip ports to snat_namespace."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is the agent side patch that takes care of configuring"},{"line_number":10,"context_line":"the floatingip for the unbound ports in the snat_namespace."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I595ce4d6520adfd57bacbdf20ed03ffefd0b190a"},{"line_number":13,"context_line":"Closes-Bug: #1583694"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dfeb2761_afb9e12e","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":36},"in_reply_to":"dfeb2761_243ce1c6","updated":"2017-04-03 18:12:01.000000000","message":"Ok, will rename it.","commit_id":"8083b7642beaf4c899b124f7fb40cef2afa37413"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"000c3d6be27d0bae62a28d370bd6400a2f3441cf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Swaminathan Vasudevan \u003cSVasudevan@suse.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-04-05 11:07:44 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DVR: Configure unbound floatingip ports to snat_namespace."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is the agent side patch that takes care of configuring"},{"line_number":10,"context_line":"the centralized floatingips for the unbound ports in the snat_namespace."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bff0334d_713774b2","line":7,"range":{"start_line":7,"start_character":15,"end_line":7,"end_character":42},"updated":"2017-04-06 12:52:08.000000000","message":"centralized floating ips in","commit_id":"1b04727ef4aa1be99d6c02d7e31d3abb5bbdd57d"}],"neutron/agent/l3/dvr_edge_router.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"000c3d6be27d0bae62a28d370bd6400a2f3441cf","unresolved":false,"context_lines":[{"line_number":266,"context_line":"    def get_snat_external_device_interface_name(self, ex_gw_port):"},{"line_number":267,"context_line":"        return self._get_snat_external_device_name(ex_gw_port[\u0027id\u0027])"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def _get_unbound_fip_cidr_list(self, interface_name):"},{"line_number":270,"context_line":"        \"\"\"Returns the fip_cidr list for unbound floatingip ports.\"\"\""},{"line_number":271,"context_line":"        device \u003d ip_lib.IPDevice("},{"line_number":272,"context_line":"            interface_name, namespace\u003dself.snat_namespace.name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_1114a8f4","line":269,"range":{"start_line":269,"start_character":13,"end_line":269,"end_character":20},"updated":"2017-04-06 12:52:08.000000000","message":"consider replacing \u0027unbound\u0027 with \u0027centralized\u0027 here and in below code/comments","commit_id":"1b04727ef4aa1be99d6c02d7e31d3abb5bbdd57d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"000c3d6be27d0bae62a28d370bd6400a2f3441cf","unresolved":false,"context_lines":[{"line_number":275,"context_line":"    def get_router_cidrs(self, device):"},{"line_number":276,"context_line":"        \"\"\"Over-ride the get_router_cidrs function to return the list."},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        This function is over-rided to provide the complete list of"},{"line_number":279,"context_line":"        floating_ip cidrs that the router hosts."},{"line_number":280,"context_line":"        This includes the unbound ports floatingip cidr list and the"},{"line_number":281,"context_line":"        bound ports floatingip cidr list."}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_547e9ee4","line":278,"range":{"start_line":278,"start_character":25,"end_line":278,"end_character":35},"updated":"2017-04-06 12:52:08.000000000","message":"nit: overridden","commit_id":"1b04727ef4aa1be99d6c02d7e31d3abb5bbdd57d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"7408d6df4c8186295c737c69cb3b7016d8c6a37c","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        fip_cidrs \u003d super(DvrEdgeRouter, self).get_router_cidrs(device)"},{"line_number":284,"context_line":"        centralized_cidrs \u003d set()"},{"line_number":285,"context_line":"        if self.get_ex_gw_port():"},{"line_number":286,"context_line":"            interface_name \u003d self.get_snat_external_device_interface_name("},{"line_number":287,"context_line":"                self.get_ex_gw_port())"},{"line_number":288,"context_line":"            centralized_cidrs \u003d self._get_centralized_fip_cidr_list("},{"line_number":289,"context_line":"                interface_name)"},{"line_number":290,"context_line":"        existing_cidrs \u003d fip_cidrs | centralized_cidrs"}],"source_content_type":"text/x-python","patch_set":5,"id":"bff0334d_f470e4de","line":287,"range":{"start_line":286,"start_character":12,"end_line":287,"end_character":38},"updated":"2017-04-07 12:05:03.000000000","message":"consider moving into _get_centralized_fip_cidr_list","commit_id":"69a44da7d660a8ff109381e872a86164806a7e1a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"19fc3aab3800d5df655fc61b309e20daf8d3601b","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        fip_cidrs \u003d super(DvrEdgeRouter, self).get_router_cidrs(device)"},{"line_number":284,"context_line":"        centralized_cidrs \u003d set()"},{"line_number":285,"context_line":"        if self.get_ex_gw_port():"},{"line_number":286,"context_line":"            interface_name \u003d self.get_snat_external_device_interface_name("},{"line_number":287,"context_line":"                self.get_ex_gw_port())"},{"line_number":288,"context_line":"            centralized_cidrs \u003d self._get_centralized_fip_cidr_list("},{"line_number":289,"context_line":"                interface_name)"},{"line_number":290,"context_line":"        existing_cidrs \u003d fip_cidrs | centralized_cidrs"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_2b740999","line":287,"range":{"start_line":286,"start_character":12,"end_line":287,"end_character":38},"in_reply_to":"bff0334d_f470e4de","updated":"2017-06-09 21:15:29.000000000","message":"Done","commit_id":"69a44da7d660a8ff109381e872a86164806a7e1a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f8ced285a897619bd9ce4efc4b58d137d769e64e","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                self.get_ex_gw_port())"},{"line_number":288,"context_line":"            centralized_cidrs \u003d self._get_centralized_fip_cidr_list("},{"line_number":289,"context_line":"                interface_name)"},{"line_number":290,"context_line":"        existing_cidrs \u003d fip_cidrs | centralized_cidrs"},{"line_number":291,"context_line":"        return existing_cidrs"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    def remove_centralized_floatingip(self, fip_cidr):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f044301_9c9a456c","line":290,"updated":"2017-05-03 19:10:31.000000000","message":"no need to use existing_cidrs, just return fip|cent","commit_id":"69a44da7d660a8ff109381e872a86164806a7e1a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"19fc3aab3800d5df655fc61b309e20daf8d3601b","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                self.get_ex_gw_port())"},{"line_number":288,"context_line":"            centralized_cidrs \u003d self._get_centralized_fip_cidr_list("},{"line_number":289,"context_line":"                interface_name)"},{"line_number":290,"context_line":"        existing_cidrs \u003d fip_cidrs | centralized_cidrs"},{"line_number":291,"context_line":"        return existing_cidrs"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    def remove_centralized_floatingip(self, fip_cidr):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_0b694dbd","line":290,"in_reply_to":"3f044301_9c9a456c","updated":"2017-06-09 21:15:29.000000000","message":"Done","commit_id":"69a44da7d660a8ff109381e872a86164806a7e1a"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"7408d6df4c8186295c737c69cb3b7016d8c6a37c","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        device \u003d ip_lib.IPDevice("},{"line_number":316,"context_line":"            interface_name, namespace\u003dself.snat_namespace.name)"},{"line_number":317,"context_line":"        try:"},{"line_number":318,"context_line":"            ip_cidr \u003d common_utils.ip_to_cidr(fip[\u0027floating_ip_address\u0027])"},{"line_number":319,"context_line":"            device.addr.add(ip_cidr)"},{"line_number":320,"context_line":"        except RuntimeError:"},{"line_number":321,"context_line":"            LOG.warning(_LW(\"Unable to configure IP address for centralized \""}],"source_content_type":"text/x-python","patch_set":5,"id":"bff0334d_1acdb1b7","line":318,"range":{"start_line":318,"start_character":12,"end_line":318,"end_character":73},"updated":"2017-04-07 12:05:03.000000000","message":"can use fip_cidr","commit_id":"69a44da7d660a8ff109381e872a86164806a7e1a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"19fc3aab3800d5df655fc61b309e20daf8d3601b","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        device \u003d ip_lib.IPDevice("},{"line_number":316,"context_line":"            interface_name, namespace\u003dself.snat_namespace.name)"},{"line_number":317,"context_line":"        try:"},{"line_number":318,"context_line":"            ip_cidr \u003d common_utils.ip_to_cidr(fip[\u0027floating_ip_address\u0027])"},{"line_number":319,"context_line":"            device.addr.add(ip_cidr)"},{"line_number":320,"context_line":"        except RuntimeError:"},{"line_number":321,"context_line":"            LOG.warning(_LW(\"Unable to configure IP address for centralized \""}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_6b9fa1b4","line":318,"range":{"start_line":318,"start_character":12,"end_line":318,"end_character":73},"in_reply_to":"bff0334d_1acdb1b7","updated":"2017-06-09 21:15:29.000000000","message":"Done","commit_id":"69a44da7d660a8ff109381e872a86164806a7e1a"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"7408d6df4c8186295c737c69cb3b7016d8c6a37c","unresolved":false,"context_lines":[{"line_number":330,"context_line":"                                      self.agent_conf)"},{"line_number":331,"context_line":"        return lib_constants.FLOATINGIP_STATUS_ACTIVE"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    def _centralized_floating_forward_rules(self, floating_ip, fixed_ip):"},{"line_number":334,"context_line":"        return [(\u0027PREROUTING\u0027, \u0027-d %s/32 -j DNAT --to-destination %s\u0027 %"},{"line_number":335,"context_line":"                 (floating_ip, fixed_ip)),"},{"line_number":336,"context_line":"                (\u0027OUTPUT\u0027, \u0027-d %s/32 -j DNAT --to-destination %s\u0027 %"},{"line_number":337,"context_line":"                 (floating_ip, fixed_ip)),"},{"line_number":338,"context_line":"                (\u0027float-snat\u0027, \u0027-s %s/32 -j SNAT --to-source %s\u0027 %"},{"line_number":339,"context_line":"                 (fixed_ip, floating_ip))]"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    def _set_floating_ip_nat_rules_for_centralized_floatingip(self, fip):"},{"line_number":342,"context_line":"        if fip and fip.get(n_const.DVR_SNAT_BOUND):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bff0334d_fa2b2d2d","line":339,"range":{"start_line":333,"start_character":4,"end_line":339,"end_character":42},"updated":"2017-04-07 12:05:03.000000000","message":"does it differ from RouterInfo.floating_forward_rules()?","commit_id":"69a44da7d660a8ff109381e872a86164806a7e1a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"19fc3aab3800d5df655fc61b309e20daf8d3601b","unresolved":false,"context_lines":[{"line_number":330,"context_line":"                                      self.agent_conf)"},{"line_number":331,"context_line":"        return lib_constants.FLOATINGIP_STATUS_ACTIVE"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    def _centralized_floating_forward_rules(self, floating_ip, fixed_ip):"},{"line_number":334,"context_line":"        return [(\u0027PREROUTING\u0027, \u0027-d %s/32 -j DNAT --to-destination %s\u0027 %"},{"line_number":335,"context_line":"                 (floating_ip, fixed_ip)),"},{"line_number":336,"context_line":"                (\u0027OUTPUT\u0027, \u0027-d %s/32 -j DNAT --to-destination %s\u0027 %"},{"line_number":337,"context_line":"                 (floating_ip, fixed_ip)),"},{"line_number":338,"context_line":"                (\u0027float-snat\u0027, \u0027-s %s/32 -j SNAT --to-source %s\u0027 %"},{"line_number":339,"context_line":"                 (fixed_ip, floating_ip))]"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    def _set_floating_ip_nat_rules_for_centralized_floatingip(self, fip):"},{"line_number":342,"context_line":"        if fip and fip.get(n_const.DVR_SNAT_BOUND):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_ab5019d6","line":339,"range":{"start_line":333,"start_character":4,"end_line":339,"end_character":42},"in_reply_to":"bff0334d_fa2b2d2d","updated":"2017-06-09 21:15:29.000000000","message":"Looks the same to me, done.","commit_id":"69a44da7d660a8ff109381e872a86164806a7e1a"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"7408d6df4c8186295c737c69cb3b7016d8c6a37c","unresolved":false,"context_lines":[{"line_number":355,"context_line":"            self._set_floating_ip_nat_rules_for_centralized_floatingip(fip)"},{"line_number":356,"context_line":"        self.snat_iptables_manager.apply()"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"    def _get_snat_external_device_name(self, port_id):"},{"line_number":359,"context_line":"        long_name \u003d router.EXTERNAL_DEV_PREFIX + port_id"},{"line_number":360,"context_line":"        return long_name[:self.driver.DEV_NAME_LEN]"}],"source_content_type":"text/x-python","patch_set":5,"id":"bff0334d_da950942","line":360,"range":{"start_line":358,"start_character":4,"end_line":360,"end_character":51},"updated":"2017-04-07 12:05:03.000000000","message":"only used in get_snat_external_device_interface_name, why need 2 methods?","commit_id":"69a44da7d660a8ff109381e872a86164806a7e1a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"19fc3aab3800d5df655fc61b309e20daf8d3601b","unresolved":false,"context_lines":[{"line_number":355,"context_line":"            self._set_floating_ip_nat_rules_for_centralized_floatingip(fip)"},{"line_number":356,"context_line":"        self.snat_iptables_manager.apply()"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"    def _get_snat_external_device_name(self, port_id):"},{"line_number":359,"context_line":"        long_name \u003d router.EXTERNAL_DEV_PREFIX + port_id"},{"line_number":360,"context_line":"        return long_name[:self.driver.DEV_NAME_LEN]"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_0b970d93","line":360,"range":{"start_line":358,"start_character":4,"end_line":360,"end_character":51},"in_reply_to":"bff0334d_da950942","updated":"2017-06-09 21:15:29.000000000","message":"Done","commit_id":"69a44da7d660a8ff109381e872a86164806a7e1a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"17ff8e86d9c917aa9297bbcab491e4b54428aac1","unresolved":false,"context_lines":[{"line_number":327,"context_line":"                                      self.agent_conf)"},{"line_number":328,"context_line":"        return lib_constants.FLOATINGIP_STATUS_ACTIVE"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def _centralized_floating_forward_rules(self, floating_ip, fixed_ip):"},{"line_number":331,"context_line":"        return [(\u0027PREROUTING\u0027, \u0027-d %s/32 -j DNAT --to-destination %s\u0027 %"},{"line_number":332,"context_line":"                 (floating_ip, fixed_ip)),"},{"line_number":333,"context_line":"                (\u0027OUTPUT\u0027, \u0027-d %s/32 -j DNAT --to-destination %s\u0027 %"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_d743a9ae","line":330,"updated":"2017-06-22 21:29:08.000000000","message":"how different are these functions from the legacy router floating IP setup code? Is there any re-use we can benefit from here?","commit_id":"672c3d21033299dfdada2d05a41f33612f0d060f"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"16a49278a70eb09eb742121060935b39b1b3a487","unresolved":false,"context_lines":[{"line_number":327,"context_line":"                                      self.agent_conf)"},{"line_number":328,"context_line":"        return lib_constants.FLOATINGIP_STATUS_ACTIVE"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def _centralized_floating_forward_rules(self, floating_ip, fixed_ip):"},{"line_number":331,"context_line":"        return [(\u0027PREROUTING\u0027, \u0027-d %s/32 -j DNAT --to-destination %s\u0027 %"},{"line_number":332,"context_line":"                 (floating_ip, fixed_ip)),"},{"line_number":333,"context_line":"                (\u0027OUTPUT\u0027, \u0027-d %s/32 -j DNAT --to-destination %s\u0027 %"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_7cc9b623","line":330,"in_reply_to":"5f201791_d743a9ae","updated":"2017-06-28 19:39:22.000000000","message":"floating_forward_rules have been overridden in dvr_local_router, so I don\u0027t want to call floating_forward_rules in here, since it would call the floating_forward_rules in dvr_local_router and not in router_info.\nSo I have to probably add a function to duplicate this.","commit_id":"672c3d21033299dfdada2d05a41f33612f0d060f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d185fdef18aa280d78f46e0bcdfdd7274e07f433","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        if not self._is_this_snat_host():"},{"line_number":308,"context_line":"            return"},{"line_number":309,"context_line":"        if not self.get_ex_gw_port():"},{"line_number":310,"context_line":"            return"},{"line_number":311,"context_line":"        interface_name \u003d self.get_snat_external_device_interface_name("},{"line_number":312,"context_line":"            self.get_ex_gw_port())"},{"line_number":313,"context_line":"        device \u003d ip_lib.IPDevice("}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_a7e7ede4","line":310,"updated":"2017-07-13 22:19:47.000000000","message":"nit: check in different order than L293-295","commit_id":"c0875691abdd24442c68ed8c76a4ea78569273d8"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"76e31ba9db8fd749c6648edaf5fbf9726ba23ab6","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        if not self._is_this_snat_host():"},{"line_number":308,"context_line":"            return"},{"line_number":309,"context_line":"        if not self.get_ex_gw_port():"},{"line_number":310,"context_line":"            return"},{"line_number":311,"context_line":"        interface_name \u003d self.get_snat_external_device_interface_name("},{"line_number":312,"context_line":"            self.get_ex_gw_port())"},{"line_number":313,"context_line":"        device \u003d ip_lib.IPDevice("}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_b195c242","line":310,"in_reply_to":"1f1a1f67_a7e7ede4","updated":"2017-07-14 22:44:58.000000000","message":"will fix it.","commit_id":"c0875691abdd24442c68ed8c76a4ea78569273d8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d185fdef18aa280d78f46e0bcdfdd7274e07f433","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                 (fixed_ip, floating_ip))]"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    def _set_floating_ip_nat_rules_for_centralized_floatingip(self, fip):"},{"line_number":339,"context_line":"        if fip and fip.get(n_const.DVR_SNAT_BOUND):"},{"line_number":340,"context_line":"            fixed \u003d fip[\u0027fixed_ip_address\u0027]"},{"line_number":341,"context_line":"            fip_ip \u003d fip[\u0027floating_ip_address\u0027]"},{"line_number":342,"context_line":"            for chain, rule in self._centralized_floating_forward_rules("}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_1aadd487","line":339,"updated":"2017-07-13 22:19:47.000000000","message":"Isn\u0027t \u0027fip\u0027 always valid here?","commit_id":"c0875691abdd24442c68ed8c76a4ea78569273d8"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"76e31ba9db8fd749c6648edaf5fbf9726ba23ab6","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                 (fixed_ip, floating_ip))]"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    def _set_floating_ip_nat_rules_for_centralized_floatingip(self, fip):"},{"line_number":339,"context_line":"        if fip and fip.get(n_const.DVR_SNAT_BOUND):"},{"line_number":340,"context_line":"            fixed \u003d fip[\u0027fixed_ip_address\u0027]"},{"line_number":341,"context_line":"            fip_ip \u003d fip[\u0027floating_ip_address\u0027]"},{"line_number":342,"context_line":"            for chain, rule in self._centralized_floating_forward_rules("}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_31a2d2af","line":339,"in_reply_to":"1f1a1f67_1aadd487","updated":"2017-07-14 22:44:58.000000000","message":"I think so. But just to be safe checking for fip.\nOr else I can do fip.get(n_const.DVR_SNAT_BOUND, None)","commit_id":"c0875691abdd24442c68ed8c76a4ea78569273d8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d185fdef18aa280d78f46e0bcdfdd7274e07f433","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                self.snat_iptables_manager.ipv4[\u0027nat\u0027].add_rule("},{"line_number":345,"context_line":"                    chain, rule, tag\u003d\u0027floating_ip\u0027)"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    def process_floating_ip_nat_rules_for_centralized_floatingip(self):"},{"line_number":348,"context_line":"        self.snat_iptables_manager.ipv4[\u0027nat\u0027].clear_rules_by_tag("},{"line_number":349,"context_line":"            \u0027floating_ip\u0027)"},{"line_number":350,"context_line":"        floating_ips \u003d self.get_floating_ips()"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_3a3770e6","line":347,"updated":"2017-07-13 22:19:47.000000000","message":"Don\u0027t know if below should be under\n\nwith self.snat_iptables_manager.defer_apply():\n\nbut I guess this is consistent with the router_info code","commit_id":"c0875691abdd24442c68ed8c76a4ea78569273d8"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"76e31ba9db8fd749c6648edaf5fbf9726ba23ab6","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                self.snat_iptables_manager.ipv4[\u0027nat\u0027].add_rule("},{"line_number":345,"context_line":"                    chain, rule, tag\u003d\u0027floating_ip\u0027)"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    def process_floating_ip_nat_rules_for_centralized_floatingip(self):"},{"line_number":348,"context_line":"        self.snat_iptables_manager.ipv4[\u0027nat\u0027].clear_rules_by_tag("},{"line_number":349,"context_line":"            \u0027floating_ip\u0027)"},{"line_number":350,"context_line":"        floating_ips \u003d self.get_floating_ips()"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_519aee6d","line":347,"in_reply_to":"1f1a1f67_3a3770e6","updated":"2017-07-14 22:44:58.000000000","message":"Yes this is consistent and since we are applying it on snat_namespace it makes sense.","commit_id":"c0875691abdd24442c68ed8c76a4ea78569273d8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"6ea73529cc06e70c218813175d8cd663133990fa","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from neutron_lib import constants as lib_constants"},{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron._i18n import _LE, _LW"},{"line_number":19,"context_line":"from neutron.agent.l3 import dvr_local_router"},{"line_number":20,"context_line":"from neutron.agent.l3 import dvr_snat_ns"},{"line_number":21,"context_line":"from neutron.agent.l3 import router_info as router"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_812764b7","line":18,"range":{"start_line":18,"start_character":31,"end_line":18,"end_character":34},"updated":"2017-07-21 22:57:08.000000000","message":"Not needed","commit_id":"8b9f4f9230a74f09fc6477e7c8633db750791a91"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"e111a6bc8015696889b7530f370e80cab0a97171","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from neutron_lib import constants as lib_constants"},{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron._i18n import _LE, _LW"},{"line_number":19,"context_line":"from neutron.agent.l3 import dvr_local_router"},{"line_number":20,"context_line":"from neutron.agent.l3 import dvr_snat_ns"},{"line_number":21,"context_line":"from neutron.agent.l3 import router_info as router"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_59bca204","line":18,"range":{"start_line":18,"start_character":31,"end_line":18,"end_character":34},"in_reply_to":"ff346bd7_812764b7","updated":"2017-07-24 20:52:33.000000000","message":"Sure will fix it.","commit_id":"8b9f4f9230a74f09fc6477e7c8633db750791a91"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"6ea73529cc06e70c218813175d8cd663133990fa","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def add_centralized_floatingip(self, fip, fip_cidr):"},{"line_number":305,"context_line":"        \"\"\"Function to handle the centralized Floatingip addition.\"\"\""},{"line_number":306,"context_line":"        super(DvrEdgeRouter, self).add_centralized_floatingip(fip, fip_cidr)"},{"line_number":307,"context_line":"        if not self.get_ex_gw_port():"},{"line_number":308,"context_line":"            return"},{"line_number":309,"context_line":"        if not self._is_this_snat_host():"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_27456818","line":306,"updated":"2017-07-21 22:57:08.000000000","message":"Do we need this line? Or, if we have it here, why don\u0027t we do the same in remove_centralized_floatingip","commit_id":"8b9f4f9230a74f09fc6477e7c8633db750791a91"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"e111a6bc8015696889b7530f370e80cab0a97171","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def add_centralized_floatingip(self, fip, fip_cidr):"},{"line_number":305,"context_line":"        \"\"\"Function to handle the centralized Floatingip addition.\"\"\""},{"line_number":306,"context_line":"        super(DvrEdgeRouter, self).add_centralized_floatingip(fip, fip_cidr)"},{"line_number":307,"context_line":"        if not self.get_ex_gw_port():"},{"line_number":308,"context_line":"            return"},{"line_number":309,"context_line":"        if not self._is_this_snat_host():"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_99944a8d","line":306,"in_reply_to":"ff346bd7_27456818","updated":"2017-07-24 20:52:33.000000000","message":"Yes it might not be required here. since the super class implementation is a dummy one.","commit_id":"8b9f4f9230a74f09fc6477e7c8633db750791a91"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"6ea73529cc06e70c218813175d8cd663133990fa","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        try:"},{"line_number":316,"context_line":"            device.addr.add(fip_cidr)"},{"line_number":317,"context_line":"        except RuntimeError:"},{"line_number":318,"context_line":"            LOG.warning(_LW(\"Unable to configure IP address for centralized \""},{"line_number":319,"context_line":"                            \"floating IP: %s\"), fip[\u0027id\u0027])"},{"line_number":320,"context_line":"            return lib_constants.FLOATINGIP_STATUS_ERROR"},{"line_number":321,"context_line":"        self.process_floating_ip_nat_rules_for_centralized_floatingip()"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_e13750e3","line":318,"range":{"start_line":318,"start_character":24,"end_line":318,"end_character":27},"updated":"2017-07-21 22:57:08.000000000","message":"We are not doing these translations anymore","commit_id":"8b9f4f9230a74f09fc6477e7c8633db750791a91"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"e111a6bc8015696889b7530f370e80cab0a97171","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        try:"},{"line_number":316,"context_line":"            device.addr.add(fip_cidr)"},{"line_number":317,"context_line":"        except RuntimeError:"},{"line_number":318,"context_line":"            LOG.warning(_LW(\"Unable to configure IP address for centralized \""},{"line_number":319,"context_line":"                            \"floating IP: %s\"), fip[\u0027id\u0027])"},{"line_number":320,"context_line":"            return lib_constants.FLOATINGIP_STATUS_ERROR"},{"line_number":321,"context_line":"        self.process_floating_ip_nat_rules_for_centralized_floatingip()"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_d9f772f5","line":318,"range":{"start_line":318,"start_character":24,"end_line":318,"end_character":27},"in_reply_to":"ff346bd7_e13750e3","updated":"2017-07-24 20:52:33.000000000","message":"Will fix it.","commit_id":"8b9f4f9230a74f09fc6477e7c8633db750791a91"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"6ea73529cc06e70c218813175d8cd663133990fa","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        return lib_constants.FLOATINGIP_STATUS_ACTIVE"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def _centralized_floating_forward_rules(self, floating_ip, fixed_ip):"},{"line_number":331,"context_line":"        return [(\u0027PREROUTING\u0027, \u0027-d %s/32 -j DNAT --to-destination %s\u0027 %"},{"line_number":332,"context_line":"                 (floating_ip, fixed_ip)),"},{"line_number":333,"context_line":"                (\u0027OUTPUT\u0027, \u0027-d %s/32 -j DNAT --to-destination %s\u0027 %"},{"line_number":334,"context_line":"                 (floating_ip, fixed_ip)),"},{"line_number":335,"context_line":"                (\u0027float-snat\u0027, \u0027-s %s/32 -j SNAT --to-source %s\u0027 %"},{"line_number":336,"context_line":"                 (fixed_ip, floating_ip))]"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    def _set_floating_ip_nat_rules_for_centralized_floatingip(self, fip):"},{"line_number":339,"context_line":"        if fip.get(n_const.DVR_SNAT_BOUND, None):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_e7e2c001","line":336,"range":{"start_line":331,"start_character":0,"end_line":336,"end_character":42},"updated":"2017-07-21 22:57:08.000000000","message":"Would it make sense to create a floating_forward_rules function with this code in neutron/agent/common/utils.py and call it from here and from https://github.com/openstack/neutron/blob/master/neutron/agent/l3/router_info.py#L165?","commit_id":"8b9f4f9230a74f09fc6477e7c8633db750791a91"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"e111a6bc8015696889b7530f370e80cab0a97171","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        return lib_constants.FLOATINGIP_STATUS_ACTIVE"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def _centralized_floating_forward_rules(self, floating_ip, fixed_ip):"},{"line_number":331,"context_line":"        return [(\u0027PREROUTING\u0027, \u0027-d %s/32 -j DNAT --to-destination %s\u0027 %"},{"line_number":332,"context_line":"                 (floating_ip, fixed_ip)),"},{"line_number":333,"context_line":"                (\u0027OUTPUT\u0027, \u0027-d %s/32 -j DNAT --to-destination %s\u0027 %"},{"line_number":334,"context_line":"                 (floating_ip, fixed_ip)),"},{"line_number":335,"context_line":"                (\u0027float-snat\u0027, \u0027-s %s/32 -j SNAT --to-source %s\u0027 %"},{"line_number":336,"context_line":"                 (fixed_ip, floating_ip))]"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    def _set_floating_ip_nat_rules_for_centralized_floatingip(self, fip):"},{"line_number":339,"context_line":"        if fip.get(n_const.DVR_SNAT_BOUND, None):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_99c20a85","line":336,"range":{"start_line":331,"start_character":0,"end_line":336,"end_character":42},"in_reply_to":"ff346bd7_e7e2c001","updated":"2017-07-24 20:52:33.000000000","message":"Yes I just followed the pattern in router_info.py file to have in place.\nYes it makes sense to move it to the utils. But I think I will do it after this patch merges.","commit_id":"8b9f4f9230a74f09fc6477e7c8633db750791a91"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"62e27d0341804bc1b9b13756919f4e3cce19a260","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        long_name \u003d router.EXTERNAL_DEV_PREFIX + ex_gw_port[\u0027id\u0027]"},{"line_number":267,"context_line":"        return long_name[:self.driver.DEV_NAME_LEN]"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def _get_centralized_fip_cidr_list(self):"},{"line_number":270,"context_line":"        \"\"\"Returns the fip_cidr list for centralized floatingips.\"\"\""},{"line_number":271,"context_line":"        interface_name \u003d self.get_snat_external_device_interface_name("},{"line_number":272,"context_line":"                self.get_ex_gw_port())"}],"source_content_type":"text/x-python","patch_set":16,"id":"df3967d1_fa5906fe","line":269,"updated":"2017-07-31 22:05:52.000000000","message":"nit: this should probably be _get_centralized_fip_cidr_set","commit_id":"7b92c4e09551bca56c0927aec41f5a2a78fe5708"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"455503eeb49e91fdb552adc86174dbc8bedc67d6","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        long_name \u003d router.EXTERNAL_DEV_PREFIX + ex_gw_port[\u0027id\u0027]"},{"line_number":267,"context_line":"        return long_name[:self.driver.DEV_NAME_LEN]"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def _get_centralized_fip_cidr_list(self):"},{"line_number":270,"context_line":"        \"\"\"Returns the fip_cidr list for centralized floatingips.\"\"\""},{"line_number":271,"context_line":"        interface_name \u003d self.get_snat_external_device_interface_name("},{"line_number":272,"context_line":"                self.get_ex_gw_port())"}],"source_content_type":"text/x-python","patch_set":16,"id":"df3967d1_33ffb902","line":269,"in_reply_to":"df3967d1_fa5906fe","updated":"2017-08-01 00:35:44.000000000","message":"sure will fix","commit_id":"7b92c4e09551bca56c0927aec41f5a2a78fe5708"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d005c27ac529217ba1e6a3be621de66f5a706611","unresolved":false,"context_lines":[{"line_number":335,"context_line":"                 (fixed_ip, floating_ip))]"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def _set_floating_ip_nat_rules_for_centralized_floatingip(self, fip):"},{"line_number":338,"context_line":"        if fip.get(n_const.DVR_SNAT_BOUND, None):"},{"line_number":339,"context_line":"            fixed \u003d fip[\u0027fixed_ip_address\u0027]"},{"line_number":340,"context_line":"            fip_ip \u003d fip[\u0027floating_ip_address\u0027]"},{"line_number":341,"context_line":"            for chain, rule in self._centralized_floating_forward_rules("}],"source_content_type":"text/x-python","patch_set":17,"id":"df3967d1_eeb5c4ef","line":338,"range":{"start_line":338,"start_character":43,"end_line":338,"end_character":47},"updated":"2017-08-01 02:44:59.000000000","message":"nit: don\u0027t need the None, it\u0027s the default if the key isn\u0027t present","commit_id":"529f2cbdfd20079aa015a1963192dfb6db5237d0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"afbede64d464aacfd6c82367c7a87c15037cc2af","unresolved":false,"context_lines":[{"line_number":324,"context_line":"                                      interface_name,"},{"line_number":325,"context_line":"                                      fip[\u0027floating_ip_address\u0027],"},{"line_number":326,"context_line":"                                      self.agent_conf)"},{"line_number":327,"context_line":"        return lib_constants.FLOATINGIP_STATUS_ACTIVE"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    def _centralized_floating_forward_rules(self, floating_ip, fixed_ip):"},{"line_number":330,"context_line":"        return [(\u0027PREROUTING\u0027, \u0027-d %s/32 -j DNAT --to-destination %s\u0027 %"}],"source_content_type":"text/x-python","patch_set":23,"id":"bf3e73b7_9ec5573f","line":327,"updated":"2017-08-07 21:35:07.000000000","message":"I don\u0027t see this return code being used by the caller, so how does the status get back to the server?  Was looking at update_fip_statuses() and wondering...","commit_id":"c4e8156359dde090be37fca4cd7fb92d436969f5"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"c4267b2dc0ec8f63a8e98b34bde1638bf5740c65","unresolved":false,"context_lines":[{"line_number":324,"context_line":"                                      interface_name,"},{"line_number":325,"context_line":"                                      fip[\u0027floating_ip_address\u0027],"},{"line_number":326,"context_line":"                                      self.agent_conf)"},{"line_number":327,"context_line":"        return lib_constants.FLOATINGIP_STATUS_ACTIVE"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    def _centralized_floating_forward_rules(self, floating_ip, fixed_ip):"},{"line_number":330,"context_line":"        return [(\u0027PREROUTING\u0027, \u0027-d %s/32 -j DNAT --to-destination %s\u0027 %"}],"source_content_type":"text/x-python","patch_set":23,"id":"bf3e73b7_a14a3e52","line":327,"in_reply_to":"bf3e73b7_9ec5573f","updated":"2017-08-07 21:54:35.000000000","message":"add_floating_ip calls floating_ip_add_dist and it inturn calls add_centralized_floatingip and hence returns the status here.\nAm I missing something.","commit_id":"c4e8156359dde090be37fca4cd7fb92d436969f5"}],"neutron/agent/l3/dvr_local_router.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ac2ad30a17ed936176f990cedefc3c0137d5e747","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        \"\"\"Add floating IP to FIP namespace.\"\"\""},{"line_number":88,"context_line":"        floating_ip \u003d fip[\u0027floating_ip_address\u0027]"},{"line_number":89,"context_line":"        fixed_ip \u003d fip[\u0027fixed_ip_address\u0027]"},{"line_number":90,"context_line":"        self._add_floating_ip_rule(floating_ip, fixed_ip)"},{"line_number":91,"context_line":"        fip_2_rtr_name \u003d self.fip_ns.get_int_device_name(self.router_id)"},{"line_number":92,"context_line":"        #Add routing rule in fip namespace"},{"line_number":93,"context_line":"        fip_ns_name \u003d self.fip_ns.get_name()"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_c45e5511","side":"PARENT","line":90,"range":{"start_line":90,"start_character":8,"end_line":90,"end_character":34},"updated":"2017-04-03 14:17:06.000000000","message":"why just copying the code from this method and stop using it?","commit_id":"d0cc451bc25c945857273b7f89722afbb0b5afa6"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"822e89d7706c12794f97efe2d7603e03aed60c22","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        \"\"\"Add floating IP to FIP namespace.\"\"\""},{"line_number":88,"context_line":"        floating_ip \u003d fip[\u0027floating_ip_address\u0027]"},{"line_number":89,"context_line":"        fixed_ip \u003d fip[\u0027fixed_ip_address\u0027]"},{"line_number":90,"context_line":"        self._add_floating_ip_rule(floating_ip, fixed_ip)"},{"line_number":91,"context_line":"        fip_2_rtr_name \u003d self.fip_ns.get_int_device_name(self.router_id)"},{"line_number":92,"context_line":"        #Add routing rule in fip namespace"},{"line_number":93,"context_line":"        fip_ns_name \u003d self.fip_ns.get_name()"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_cf1d4510","side":"PARENT","line":90,"range":{"start_line":90,"start_character":8,"end_line":90,"end_character":34},"in_reply_to":"dfeb2761_c45e5511","updated":"2017-04-03 18:12:01.000000000","message":"Yes I should have used the _add_floating_ip_rule in #L 100 on the new file.\nWill do it.","commit_id":"d0cc451bc25c945857273b7f89722afbb0b5afa6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ac2ad30a17ed936176f990cedefc3c0137d5e747","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        rtr_2_fip, fip_2_rtr \u003d self.rtr_fip_subnet.get_pair()"},{"line_number":138,"context_line":"        fip_ns_name \u003d self.fip_ns.get_name()"},{"line_number":139,"context_line":"        self._remove_floating_ip_rule(floating_ip)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        device \u003d ip_lib.IPDevice(fip_2_rtr_name, namespace\u003dfip_ns_name)"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_849e0db6","side":"PARENT","line":139,"range":{"start_line":139,"start_character":13,"end_line":139,"end_character":37},"updated":"2017-04-03 14:17:06.000000000","message":"ditto","commit_id":"d0cc451bc25c945857273b7f89722afbb0b5afa6"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"822e89d7706c12794f97efe2d7603e03aed60c22","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        rtr_2_fip, fip_2_rtr \u003d self.rtr_fip_subnet.get_pair()"},{"line_number":138,"context_line":"        fip_ns_name \u003d self.fip_ns.get_name()"},{"line_number":139,"context_line":"        self._remove_floating_ip_rule(floating_ip)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        device \u003d ip_lib.IPDevice(fip_2_rtr_name, namespace\u003dfip_ns_name)"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_6fd4f920","side":"PARENT","line":139,"range":{"start_line":139,"start_character":13,"end_line":139,"end_character":37},"in_reply_to":"dfeb2761_849e0db6","updated":"2017-04-03 18:12:01.000000000","message":"Yes will do it.","commit_id":"d0cc451bc25c945857273b7f89722afbb0b5afa6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a5cbab46a75d0cefc5aedfc26b36d200866d7763","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1a1ced50_21a65553","updated":"2017-03-21 12:47:02.000000000","message":"Ideally this file shouldn\u0027t change at all - a local router should only bother about local floating ips","commit_id":"8083b7642beaf4c899b124f7fb40cef2afa37413"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"822e89d7706c12794f97efe2d7603e03aed60c22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dfeb2761_cf466522","in_reply_to":"1a1ced50_21a65553","updated":"2017-04-03 18:12:01.000000000","message":"Yes the reason for the change to handle the difference between the floatingip handled in fip namespace and floatingip handled in snat_namespace.\n\nI don\u0027t see any other way to do it cleanly.","commit_id":"8083b7642beaf4c899b124f7fb40cef2afa37413"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"1c41828f26d3e487b550fc99de7cfac8d77cc2ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bff0334d_d4be5cfe","in_reply_to":"1a1ced50_21a65553","updated":"2017-04-05 14:19:40.000000000","message":"Yes this file deals with all floatingips configured for DVR and on the fipnamespace.\nSo we handle the general floatingip case in here and move the floatingip processing for the snat_namespace to the dvr_edge_router.py","commit_id":"8083b7642beaf4c899b124f7fb40cef2afa37413"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"000c3d6be27d0bae62a28d370bd6400a2f3441cf","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    def floating_ip_added_dist(self, fip, fip_cidr):"},{"line_number":89,"context_line":"        \"\"\"Add floating IP to FIP namespace.\"\"\""},{"line_number":90,"context_line":"        if (fip.get(n_const.DVR_SNAT_BOUND) and"},{"line_number":91,"context_line":"            not fip[\u0027host\u0027]):"},{"line_number":92,"context_line":"            self.floatingips_unbound_set.add(fip_cidr)"},{"line_number":93,"context_line":"            self.add_floatingip_dist_unbound(fip, fip_cidr)"},{"line_number":94,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_94fae63f","line":91,"range":{"start_line":91,"start_character":12,"end_line":91,"end_character":27},"updated":"2017-04-06 12:52:08.000000000","message":"isn\u0027t DVR_SNAT_BOUND enough?","commit_id":"1b04727ef4aa1be99d6c02d7e31d3abb5bbdd57d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"000c3d6be27d0bae62a28d370bd6400a2f3441cf","unresolved":false,"context_lines":[{"line_number":547,"context_line":"            ext_scope_mark)"},{"line_number":548,"context_line":"        return ports_scopemark"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"    def check_if_fip_agent_required(self, floating_ips):"},{"line_number":551,"context_line":"        \"\"\"Filter Floating IPs to be hosted on this agent.\"\"\""},{"line_number":552,"context_line":"        return [i for i in floating_ips if ("},{"line_number":553,"context_line":"                   (i[\u0027host\u0027] \u003d\u003d self.host) or"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_f42492c8","line":550,"range":{"start_line":550,"start_character":8,"end_line":550,"end_character":35},"updated":"2017-04-06 12:52:08.000000000","message":"quite a confusing name for the method filtering by \u0027host\u0027","commit_id":"1b04727ef4aa1be99d6c02d7e31d3abb5bbdd57d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"875516c0b9d04f4a81422f60b2186cfcf43c565f","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        \"\"\"Add floating IP to FIP namespace.\"\"\""},{"line_number":90,"context_line":"        if fip.get(n_const.DVR_SNAT_BOUND):"},{"line_number":91,"context_line":"            self.centralized_floatingips_set.add(fip_cidr)"},{"line_number":92,"context_line":"            self.add_centralized_floatingip(fip, fip_cidr)"},{"line_number":93,"context_line":"        else:"},{"line_number":94,"context_line":"            floating_ip \u003d fip[\u0027floating_ip_address\u0027]"},{"line_number":95,"context_line":"            fixed_ip \u003d fip[\u0027fixed_ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_497a8788","line":92,"updated":"2017-05-03 18:59:07.000000000","message":"To not have to change the indent below can just put a return here","commit_id":"69a44da7d660a8ff109381e872a86164806a7e1a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"19fc3aab3800d5df655fc61b309e20daf8d3601b","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        \"\"\"Add floating IP to FIP namespace.\"\"\""},{"line_number":90,"context_line":"        if fip.get(n_const.DVR_SNAT_BOUND):"},{"line_number":91,"context_line":"            self.centralized_floatingips_set.add(fip_cidr)"},{"line_number":92,"context_line":"            self.add_centralized_floatingip(fip, fip_cidr)"},{"line_number":93,"context_line":"        else:"},{"line_number":94,"context_line":"            floating_ip \u003d fip[\u0027floating_ip_address\u0027]"},{"line_number":95,"context_line":"            fixed_ip \u003d fip[\u0027fixed_ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_cb0115b2","line":92,"in_reply_to":"5ff73747_497a8788","updated":"2017-06-09 21:15:29.000000000","message":"Done","commit_id":"69a44da7d660a8ff109381e872a86164806a7e1a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"875516c0b9d04f4a81422f60b2186cfcf43c565f","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        \"\"\"Remove floating IP from FIP namespace.\"\"\""},{"line_number":136,"context_line":"        if fip_cidr in self.centralized_floatingips_set:"},{"line_number":137,"context_line":"            self.remove_centralized_floatingip(fip_cidr)"},{"line_number":138,"context_line":"            self.centralized_floatingips_set.remove(fip_cidr)"},{"line_number":139,"context_line":"        else:"},{"line_number":140,"context_line":"            floating_ip \u003d fip_cidr.split(\u0027/\u0027)[0]"},{"line_number":141,"context_line":"            rtr_2_fip_name \u003d self.fip_ns.get_rtr_ext_device_name("}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_493ba79b","line":138,"updated":"2017-05-03 18:59:07.000000000","message":"Here too","commit_id":"69a44da7d660a8ff109381e872a86164806a7e1a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"875516c0b9d04f4a81422f60b2186cfcf43c565f","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        floating_ips \u003d self.get_floating_ips()"},{"line_number":456,"context_line":"        if not self._is_fip_bound_to_host(floating_ips):"},{"line_number":457,"context_line":"            return self.get_snat_external_device_interface_name(ex_gw_port)"},{"line_number":458,"context_line":"        else:"},{"line_number":459,"context_line":"            fip_int \u003d self.fip_ns.get_int_device_name(self.router_id)"},{"line_number":460,"context_line":"            if ip_lib.device_exists(fip_int, namespace\u003dself.fip_ns.get_name()):"},{"line_number":461,"context_line":"                return self.fip_ns.get_rtr_ext_device_name(self.router_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_695f83e5","line":458,"updated":"2017-05-03 18:59:07.000000000","message":"Don\u0027t need the else here as L458 returns","commit_id":"69a44da7d660a8ff109381e872a86164806a7e1a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"19fc3aab3800d5df655fc61b309e20daf8d3601b","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        floating_ips \u003d self.get_floating_ips()"},{"line_number":456,"context_line":"        if not self._is_fip_bound_to_host(floating_ips):"},{"line_number":457,"context_line":"            return self.get_snat_external_device_interface_name(ex_gw_port)"},{"line_number":458,"context_line":"        else:"},{"line_number":459,"context_line":"            fip_int \u003d self.fip_ns.get_int_device_name(self.router_id)"},{"line_number":460,"context_line":"            if ip_lib.device_exists(fip_int, namespace\u003dself.fip_ns.get_name()):"},{"line_number":461,"context_line":"                return self.fip_ns.get_rtr_ext_device_name(self.router_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_2be1a9ff","line":458,"in_reply_to":"5ff73747_695f83e5","updated":"2017-06-09 21:15:29.000000000","message":"Done","commit_id":"69a44da7d660a8ff109381e872a86164806a7e1a"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"7408d6df4c8186295c737c69cb3b7016d8c6a37c","unresolved":false,"context_lines":[{"line_number":546,"context_line":"            ext_scope_mark)"},{"line_number":547,"context_line":"        return ports_scopemark"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"    def _is_fip_bound_to_host(self, floating_ips):"},{"line_number":550,"context_line":"        \"\"\"Filter Floating IPs to be hosted on this agent.\"\"\""},{"line_number":551,"context_line":"        return [i for i in floating_ips if ("},{"line_number":552,"context_line":"                   (i[\u0027host\u0027] \u003d\u003d self.host) or"}],"source_content_type":"text/x-python","patch_set":5,"id":"bff0334d_1ae811b2","line":549,"range":{"start_line":549,"start_character":8,"end_line":549,"end_character":29},"updated":"2017-04-07 12:05:03.000000000","message":"\u0027is\u0027 implies bool return value, consider _get_floatingips_bound_to_host, or _any_floatingip_bound_to_host and return bool","commit_id":"69a44da7d660a8ff109381e872a86164806a7e1a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"19fc3aab3800d5df655fc61b309e20daf8d3601b","unresolved":false,"context_lines":[{"line_number":546,"context_line":"            ext_scope_mark)"},{"line_number":547,"context_line":"        return ports_scopemark"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"    def _is_fip_bound_to_host(self, floating_ips):"},{"line_number":550,"context_line":"        \"\"\"Filter Floating IPs to be hosted on this agent.\"\"\""},{"line_number":551,"context_line":"        return [i for i in floating_ips if ("},{"line_number":552,"context_line":"                   (i[\u0027host\u0027] \u003d\u003d self.host) or"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_4b986569","line":549,"range":{"start_line":549,"start_character":8,"end_line":549,"end_character":29},"in_reply_to":"bff0334d_1ae811b2","updated":"2017-06-09 21:15:29.000000000","message":"Done","commit_id":"69a44da7d660a8ff109381e872a86164806a7e1a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"875516c0b9d04f4a81422f60b2186cfcf43c565f","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        \"\"\"Filter Floating IPs to be hosted on this agent.\"\"\""},{"line_number":551,"context_line":"        return [i for i in floating_ips if ("},{"line_number":552,"context_line":"                   (i[\u0027host\u0027] \u003d\u003d self.host) or"},{"line_number":553,"context_line":"                   (i.get(\u0027dest_host\u0027) \u003d\u003d self.host))]"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"    def process_external(self):"},{"line_number":556,"context_line":"        ex_gw_port \u003d self.get_ex_gw_port()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_49a5e7b4","line":553,"updated":"2017-05-03 18:59:07.000000000","message":"Are any callers using the list returned?  If not then we don\u0027t need to iterate through all floating_ips, can just return True on first match.","commit_id":"69a44da7d660a8ff109381e872a86164806a7e1a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"19fc3aab3800d5df655fc61b309e20daf8d3601b","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        \"\"\"Filter Floating IPs to be hosted on this agent.\"\"\""},{"line_number":551,"context_line":"        return [i for i in floating_ips if ("},{"line_number":552,"context_line":"                   (i[\u0027host\u0027] \u003d\u003d self.host) or"},{"line_number":553,"context_line":"                   (i.get(\u0027dest_host\u0027) \u003d\u003d self.host))]"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"    def process_external(self):"},{"line_number":556,"context_line":"        ex_gw_port \u003d self.get_ex_gw_port()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_2b9d2959","line":553,"in_reply_to":"5ff73747_49a5e7b4","updated":"2017-06-09 21:15:29.000000000","message":"Done","commit_id":"69a44da7d660a8ff109381e872a86164806a7e1a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d185fdef18aa280d78f46e0bcdfdd7274e07f433","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def floating_forward_rules(self, floating_ip, fixed_ip, fip):"},{"line_number":54,"context_line":"        \"\"\"Override this function defined in router_info for dvr routers.\"\"\""},{"line_number":55,"context_line":"        if fip and fip.get(n_const.DVR_SNAT_BOUND):"},{"line_number":56,"context_line":"            return []"},{"line_number":57,"context_line":"        if not self.fip_ns:"},{"line_number":58,"context_line":"            return []"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_1a0394ba","line":55,"updated":"2017-07-13 22:19:47.000000000","message":"Is \u0027fip\u0027 ever not valid?  I only found 1 caller and it\u0027s always passing it.  Might just require test updates.","commit_id":"c0875691abdd24442c68ed8c76a4ea78569273d8"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"76e31ba9db8fd749c6648edaf5fbf9726ba23ab6","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def floating_forward_rules(self, floating_ip, fixed_ip, fip):"},{"line_number":54,"context_line":"        \"\"\"Override this function defined in router_info for dvr routers.\"\"\""},{"line_number":55,"context_line":"        if fip and fip.get(n_const.DVR_SNAT_BOUND):"},{"line_number":56,"context_line":"            return []"},{"line_number":57,"context_line":"        if not self.fip_ns:"},{"line_number":58,"context_line":"            return []"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_b17ee216","line":55,"in_reply_to":"1f1a1f67_1a0394ba","updated":"2017-07-14 22:44:58.000000000","message":"You may be right, probably I should just check for fip.get(n_const.DVR_SNAT_BOUND, None)","commit_id":"c0875691abdd24442c68ed8c76a4ea78569273d8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"6ea73529cc06e70c218813175d8cd663133990fa","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def floating_ip_added_dist(self, fip, fip_cidr):"},{"line_number":92,"context_line":"        \"\"\"Add floating IP to FIP namespace.\"\"\""},{"line_number":93,"context_line":"        if fip.get(n_const.DVR_SNAT_BOUND):"},{"line_number":94,"context_line":"            self.centralized_floatingips_set.add(fip_cidr)"},{"line_number":95,"context_line":"            self.add_centralized_floatingip(fip, fip_cidr)"},{"line_number":96,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_e73ac032","line":93,"updated":"2017-07-21 22:57:08.000000000","message":"We do this in this class because we need to handle the situation where dvr_snat agent is running on a compute node. Is my understanding correct?","commit_id":"8b9f4f9230a74f09fc6477e7c8633db750791a91"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"e111a6bc8015696889b7530f370e80cab0a97171","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def floating_ip_added_dist(self, fip, fip_cidr):"},{"line_number":92,"context_line":"        \"\"\"Add floating IP to FIP namespace.\"\"\""},{"line_number":93,"context_line":"        if fip.get(n_const.DVR_SNAT_BOUND):"},{"line_number":94,"context_line":"            self.centralized_floatingips_set.add(fip_cidr)"},{"line_number":95,"context_line":"            self.add_centralized_floatingip(fip, fip_cidr)"},{"line_number":96,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_9947aa1e","line":93,"in_reply_to":"ff346bd7_e73ac032","updated":"2017-07-24 20:52:33.000000000","message":"We do this in this class because it is here the \u0027dvr\u0027 router floatingips are handled, irrespective of the node where they reside. (either the snat network node or the dvr compute node)","commit_id":"8b9f4f9230a74f09fc6477e7c8633db750791a91"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a5fca7f2f38006d087438d6f9c4e3b338399f4dd","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    def floating_ip_removed_dist(self, fip_cidr):"},{"line_number":135,"context_line":"        \"\"\"Remove floating IP from FIP namespace.\"\"\""},{"line_number":136,"context_line":"        if fip_cidr in self.centralized_floatingips_set:"},{"line_number":137,"context_line":"            self.remove_centralized_floatingip(fip_cidr)"},{"line_number":138,"context_line":"            self.centralized_floatingips_set.remove(fip_cidr)"},{"line_number":139,"context_line":"            return"},{"line_number":140,"context_line":"        floating_ip \u003d fip_cidr.split(\u0027/\u0027)[0]"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_bf61d507","line":137,"updated":"2017-07-26 23:58:40.000000000","message":"Ah yes, I didn\u0027t realize the other one inherited form this one. That makes sense.","commit_id":"c5a9d5efa35f94e90888c4c1e6fbf832b4a13771"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"391bd4bd451ace2d1ac20913d8bd0cd29873f882","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    def floating_ip_removed_dist(self, fip_cidr):"},{"line_number":135,"context_line":"        \"\"\"Remove floating IP from FIP namespace.\"\"\""},{"line_number":136,"context_line":"        if fip_cidr in self.centralized_floatingips_set:"},{"line_number":137,"context_line":"            self.remove_centralized_floatingip(fip_cidr)"},{"line_number":138,"context_line":"            self.centralized_floatingips_set.remove(fip_cidr)"},{"line_number":139,"context_line":"            return"},{"line_number":140,"context_line":"        floating_ip \u003d fip_cidr.split(\u0027/\u0027)[0]"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_bcdd8a71","line":137,"updated":"2017-07-26 01:33:20.000000000","message":"aren\u0027t remove_centralized_floatingip and add_centralized_floating IP pass functions? Why even bother having them an calling them?","commit_id":"c5a9d5efa35f94e90888c4c1e6fbf832b4a13771"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"6846bf712bcfcb733aa7619257d943ff73325cb4","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    def floating_ip_removed_dist(self, fip_cidr):"},{"line_number":135,"context_line":"        \"\"\"Remove floating IP from FIP namespace.\"\"\""},{"line_number":136,"context_line":"        if fip_cidr in self.centralized_floatingips_set:"},{"line_number":137,"context_line":"            self.remove_centralized_floatingip(fip_cidr)"},{"line_number":138,"context_line":"            self.centralized_floatingips_set.remove(fip_cidr)"},{"line_number":139,"context_line":"            return"},{"line_number":140,"context_line":"        floating_ip \u003d fip_cidr.split(\u0027/\u0027)[0]"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_e959f68d","line":137,"in_reply_to":"ff346bd7_bcdd8a71","updated":"2017-07-26 16:51:16.000000000","message":"This is a pass function in dvr_local_router.py but has been over-ridden in dvr_edge_router.py.\nSo the implementation in dvr_edge_router.py gets called when the fip is configured as centralized or when unbound.\nHope this helps.","commit_id":"c5a9d5efa35f94e90888c4c1e6fbf832b4a13771"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"943367733dd474b9e6c9370e216d6f29cf3b48f6","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            \u0027FORWARD\u0027, \u0027-s %s/32 -j $float-snat\u0027 % fixed_ip)"},{"line_number":83,"context_line":"        return [mark_traffic_to_floating_ip, mark_traffic_from_fixed_ip]"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def add_centralized_floatingip(self, fip, fip_cidr):"},{"line_number":86,"context_line":"        pass"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def remove_centralized_floatingip(self, fip_cidr):"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff346bd7_bf2675cd","line":85,"updated":"2017-07-26 23:59:18.000000000","message":"following up on the last patch, can you add a docstring here explaining when this is called and why dvr_local_router doesn\u0027t have to do anything?","commit_id":"c9fa54b61c9ecb28d526701d1a5e1098929174b0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d005c27ac529217ba1e6a3be621de66f5a706611","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        if not self.fip_ns:"},{"line_number":56,"context_line":"            return []"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        if fip.get(n_const.DVR_SNAT_BOUND, None):"},{"line_number":59,"context_line":"            return []"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        fixed_ip \u003d fip[\u0027fixed_ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":17,"id":"df3967d1_ceba00dd","line":58,"range":{"start_line":58,"start_character":43,"end_line":58,"end_character":47},"updated":"2017-08-01 02:44:59.000000000","message":"here too","commit_id":"529f2cbdfd20079aa015a1963192dfb6db5237d0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0d40f217a7a893c05fd02e4c85a0b0c387cc4cda","unresolved":false,"context_lines":[{"line_number":546,"context_line":""},{"line_number":547,"context_line":"    def _get_floatingips_bound_to_host(self, floating_ips):"},{"line_number":548,"context_line":"        \"\"\"Filter Floating IPs to be hosted on this agent.\"\"\""},{"line_number":549,"context_line":"        return [i for i in floating_ips if ("},{"line_number":550,"context_line":"                   (i[\u0027host\u0027] \u003d\u003d self.host) or"},{"line_number":551,"context_line":"                   (i.get(\u0027dest_host\u0027) \u003d\u003d self.host))]"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    def process_external(self):"},{"line_number":554,"context_line":"        ex_gw_port \u003d self.get_ex_gw_port()"}],"source_content_type":"text/x-python","patch_set":19,"id":"df3967d1_b4067c1b","line":551,"range":{"start_line":549,"start_character":39,"end_line":551,"end_character":53},"updated":"2017-08-04 01:01:10.000000000","message":"A bit tricky line wrapping. Consider:\n\n [i for i in floating_ips\n  if (i[\u0027jhost\u0027] \u003d\u003d self.host or\n      i.get(\u0027dest_host\u0027) \u003d\u003d self.host)]","commit_id":"ccb7df3c870a83b590d574f8c1d24f276d4a1234"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"616284c8624acb32b684b0a885f16e9d624c53ae","unresolved":false,"context_lines":[{"line_number":546,"context_line":""},{"line_number":547,"context_line":"    def _get_floatingips_bound_to_host(self, floating_ips):"},{"line_number":548,"context_line":"        \"\"\"Filter Floating IPs to be hosted on this agent.\"\"\""},{"line_number":549,"context_line":"        return [i for i in floating_ips if ("},{"line_number":550,"context_line":"                   (i[\u0027host\u0027] \u003d\u003d self.host) or"},{"line_number":551,"context_line":"                   (i.get(\u0027dest_host\u0027) \u003d\u003d self.host))]"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    def process_external(self):"},{"line_number":554,"context_line":"        ex_gw_port \u003d self.get_ex_gw_port()"}],"source_content_type":"text/x-python","patch_set":19,"id":"df3967d1_1bd0bec8","line":551,"range":{"start_line":549,"start_character":39,"end_line":551,"end_character":53},"in_reply_to":"df3967d1_b4067c1b","updated":"2017-08-04 17:11:13.000000000","message":"Done","commit_id":"ccb7df3c870a83b590d574f8c1d24f276d4a1234"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"afbede64d464aacfd6c82367c7a87c15037cc2af","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        \"\"\"Add floating IP to FIP namespace.\"\"\""},{"line_number":99,"context_line":"        if fip.get(n_const.DVR_SNAT_BOUND):"},{"line_number":100,"context_line":"            self.centralized_floatingips_set.add(fip_cidr)"},{"line_number":101,"context_line":"            self.add_centralized_floatingip(fip, fip_cidr)"},{"line_number":102,"context_line":"            return"},{"line_number":103,"context_line":"        floating_ip \u003d fip[\u0027floating_ip_address\u0027]"},{"line_number":104,"context_line":"        fixed_ip \u003d fip[\u0027fixed_ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":23,"id":"bf3e73b7_7ec6336a","line":101,"updated":"2017-08-07 21:35:07.000000000","message":"I think this ordering should be reversed since add_centralized_floatingip() can return an error, and we shouldn\u0027t add it to the set in that case.","commit_id":"c4e8156359dde090be37fca4cd7fb92d436969f5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4bb2ea9411fd0fc7e66376ae5534deb3b9ba0994","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        \"\"\"Add floating IP to FIP namespace.\"\"\""},{"line_number":99,"context_line":"        if fip.get(n_const.DVR_SNAT_BOUND):"},{"line_number":100,"context_line":"            self.centralized_floatingips_set.add(fip_cidr)"},{"line_number":101,"context_line":"            self.add_centralized_floatingip(fip, fip_cidr)"},{"line_number":102,"context_line":"            return"},{"line_number":103,"context_line":"        floating_ip \u003d fip[\u0027floating_ip_address\u0027]"},{"line_number":104,"context_line":"        fixed_ip \u003d fip[\u0027fixed_ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":23,"id":"bf3e73b7_a16d9e99","line":101,"in_reply_to":"bf3e73b7_5e4c8f9d","updated":"2017-08-07 22:02:46.000000000","message":"This is where the return status is ignored, plus the caller will ignore anything we return anyways - add_floating_ip()","commit_id":"c4e8156359dde090be37fca4cd7fb92d436969f5"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"c4267b2dc0ec8f63a8e98b34bde1638bf5740c65","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        \"\"\"Add floating IP to FIP namespace.\"\"\""},{"line_number":99,"context_line":"        if fip.get(n_const.DVR_SNAT_BOUND):"},{"line_number":100,"context_line":"            self.centralized_floatingips_set.add(fip_cidr)"},{"line_number":101,"context_line":"            self.add_centralized_floatingip(fip, fip_cidr)"},{"line_number":102,"context_line":"            return"},{"line_number":103,"context_line":"        floating_ip \u003d fip[\u0027floating_ip_address\u0027]"},{"line_number":104,"context_line":"        fixed_ip \u003d fip[\u0027fixed_ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":23,"id":"bf3e73b7_5e4c8f9d","line":101,"in_reply_to":"bf3e73b7_7ec6336a","updated":"2017-08-07 21:54:35.000000000","message":"We can fix the order.","commit_id":"c4e8156359dde090be37fca4cd7fb92d436969f5"}],"neutron/agent/l3/router_info.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d185fdef18aa280d78f46e0bcdfdd7274e07f433","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        \"\"\"Filter Floating IPs to be hosted on this agent.\"\"\""},{"line_number":161,"context_line":"        return self.router.get(lib_constants.FLOATINGIP_KEY, [])"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def floating_forward_rules(self, floating_ip, fixed_ip, fip):"},{"line_number":164,"context_line":"        return [(\u0027PREROUTING\u0027, \u0027-d %s/32 -j DNAT --to-destination %s\u0027 %"},{"line_number":165,"context_line":"                 (floating_ip, fixed_ip)),"},{"line_number":166,"context_line":"                (\u0027OUTPUT\u0027, \u0027-d %s/32 -j DNAT --to-destination %s\u0027 %"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_fa68d887","line":163,"updated":"2017-07-13 22:19:47.000000000","message":"So I guess this can just take one argument now?  fip?","commit_id":"c0875691abdd24442c68ed8c76a4ea78569273d8"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"76e31ba9db8fd749c6648edaf5fbf9726ba23ab6","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        \"\"\"Filter Floating IPs to be hosted on this agent.\"\"\""},{"line_number":161,"context_line":"        return self.router.get(lib_constants.FLOATINGIP_KEY, [])"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def floating_forward_rules(self, floating_ip, fixed_ip, fip):"},{"line_number":164,"context_line":"        return [(\u0027PREROUTING\u0027, \u0027-d %s/32 -j DNAT --to-destination %s\u0027 %"},{"line_number":165,"context_line":"                 (floating_ip, fixed_ip)),"},{"line_number":166,"context_line":"                (\u0027OUTPUT\u0027, \u0027-d %s/32 -j DNAT --to-destination %s\u0027 %"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_919e4652","line":163,"in_reply_to":"1f1a1f67_fa68d887","updated":"2017-07-14 22:44:58.000000000","message":"Yes you are right.","commit_id":"c0875691abdd24442c68ed8c76a4ea78569273d8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"6ea73529cc06e70c218813175d8cd663133990fa","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        return self.router.get(lib_constants.FLOATINGIP_KEY, [])"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def floating_forward_rules(self, fip):"},{"line_number":165,"context_line":"        fixed_ip \u003d fip[\u0027fixed_ip_address\u0027]"},{"line_number":166,"context_line":"        floating_ip \u003d fip[\u0027floating_ip_address\u0027]"},{"line_number":167,"context_line":"        return [(\u0027PREROUTING\u0027, \u0027-d %s/32 -j DNAT --to-destination %s\u0027 %"},{"line_number":168,"context_line":"                 (floating_ip, fixed_ip)),"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_0755c450","line":165,"updated":"2017-07-21 22:57:08.000000000","message":"This change seems unrelated to this patchset. Am I missing something?","commit_id":"8b9f4f9230a74f09fc6477e7c8633db750791a91"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"e111a6bc8015696889b7530f370e80cab0a97171","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        return self.router.get(lib_constants.FLOATINGIP_KEY, [])"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def floating_forward_rules(self, fip):"},{"line_number":165,"context_line":"        fixed_ip \u003d fip[\u0027fixed_ip_address\u0027]"},{"line_number":166,"context_line":"        floating_ip \u003d fip[\u0027floating_ip_address\u0027]"},{"line_number":167,"context_line":"        return [(\u0027PREROUTING\u0027, \u0027-d %s/32 -j DNAT --to-destination %s\u0027 %"},{"line_number":168,"context_line":"                 (floating_ip, fixed_ip)),"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_f927d663","line":165,"in_reply_to":"ff346bd7_0755c450","updated":"2017-07-24 20:52:33.000000000","message":"This was related because of my change to \u0027floating_forward_rules\u0027 over-ridden in \u0027dvr_local_routers.py\u0027 file.\nBased on the previous feedback, I had to just pass the fip instead of fixed_ip, floating_ip and fip.","commit_id":"8b9f4f9230a74f09fc6477e7c8633db750791a91"}],"neutron/tests/functional/agent/l3/test_dvr_router.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"6ea73529cc06e70c218813175d8cd663133990fa","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                floating_ip[\u0027host\u0027] \u003d agent.conf.host"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        if enable_unbound_fip:"},{"line_number":471,"context_line":"            floating_ip[\u0027dvr_snat_bound\u0027] \u003d True"},{"line_number":472,"context_line":"        if enable_gw:"},{"line_number":473,"context_line":"            external_gw_port \u003d router[\u0027gw_port\u0027]"},{"line_number":474,"context_line":"            router[\u0027gw_port\u0027][portbindings.HOST_ID] \u003d agent.conf.host"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_67c250ec","line":471,"range":{"start_line":471,"start_character":24,"end_line":471,"end_character":40},"updated":"2017-07-21 22:57:08.000000000","message":"This could be n_const.DVR_SNAT_BOUND","commit_id":"8b9f4f9230a74f09fc6477e7c8633db750791a91"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"e111a6bc8015696889b7530f370e80cab0a97171","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                floating_ip[\u0027host\u0027] \u003d agent.conf.host"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        if enable_unbound_fip:"},{"line_number":471,"context_line":"            floating_ip[\u0027dvr_snat_bound\u0027] \u003d True"},{"line_number":472,"context_line":"        if enable_gw:"},{"line_number":473,"context_line":"            external_gw_port \u003d router[\u0027gw_port\u0027]"},{"line_number":474,"context_line":"            router[\u0027gw_port\u0027][portbindings.HOST_ID] \u003d agent.conf.host"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_79c9a676","line":471,"range":{"start_line":471,"start_character":24,"end_line":471,"end_character":40},"in_reply_to":"ff346bd7_67c250ec","updated":"2017-07-24 20:52:33.000000000","message":"Will fix it.","commit_id":"8b9f4f9230a74f09fc6477e7c8633db750791a91"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"6ea73529cc06e70c218813175d8cd663133990fa","unresolved":false,"context_lines":[{"line_number":990,"context_line":""},{"line_number":991,"context_line":"    def test_unbound_floating_ip_deployed_on_snat_namespace(self):"},{"line_number":992,"context_line":"        \"\"\"Test to validate the unbound floatingip lifecycle.\"\"\""},{"line_number":993,"context_line":"        self.agent.conf.agent_mode \u003d \u0027dvr_snat\u0027"},{"line_number":994,"context_line":"        router_info \u003d self.generate_dvr_router_info(enable_unbound_fip\u003dTrue)"},{"line_number":995,"context_line":"        router1 \u003d self.manage_router(self.agent, router_info)"},{"line_number":996,"context_line":"        unbound_floatingips \u003d router_info[lib_constants.FLOATINGIP_KEY]"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_671ed071","line":993,"range":{"start_line":993,"start_character":37,"end_line":993,"end_character":47},"updated":"2017-07-21 22:57:08.000000000","message":"This could be lib_constants.L3_AGENT_MODE_DVR_SNAT","commit_id":"8b9f4f9230a74f09fc6477e7c8633db750791a91"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"e111a6bc8015696889b7530f370e80cab0a97171","unresolved":false,"context_lines":[{"line_number":990,"context_line":""},{"line_number":991,"context_line":"    def test_unbound_floating_ip_deployed_on_snat_namespace(self):"},{"line_number":992,"context_line":"        \"\"\"Test to validate the unbound floatingip lifecycle.\"\"\""},{"line_number":993,"context_line":"        self.agent.conf.agent_mode \u003d \u0027dvr_snat\u0027"},{"line_number":994,"context_line":"        router_info \u003d self.generate_dvr_router_info(enable_unbound_fip\u003dTrue)"},{"line_number":995,"context_line":"        router1 \u003d self.manage_router(self.agent, router_info)"},{"line_number":996,"context_line":"        unbound_floatingips \u003d router_info[lib_constants.FLOATINGIP_KEY]"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_59c6e269","line":993,"range":{"start_line":993,"start_character":37,"end_line":993,"end_character":47},"in_reply_to":"ff346bd7_671ed071","updated":"2017-07-24 20:52:33.000000000","message":"Will fix it.","commit_id":"8b9f4f9230a74f09fc6477e7c8633db750791a91"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ab17e00f9423f20e6f38f2125897eb937c906e4d","unresolved":false,"context_lines":[{"line_number":445,"context_line":"                                 enable_ha\u003dFalse,"},{"line_number":446,"context_line":"                                 enable_snat\u003dFalse,"},{"line_number":447,"context_line":"                                 enable_gw\u003dTrue,"},{"line_number":448,"context_line":"                                 enable_unbound_fip\u003dFalse,"},{"line_number":449,"context_line":"                                 agent\u003dNone,"},{"line_number":450,"context_line":"                                 extra_routes\u003dFalse,"},{"line_number":451,"context_line":"                                 enable_floating_ip\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":15,"id":"ff346bd7_cf62750a","line":448,"updated":"2017-07-28 03:42:19.000000000","message":"Is it unbound?  Maybe enable_snat_bound_fip ?","commit_id":"c2c355d45306b193cdeb2a2e6843babafe474d9b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ab17e00f9423f20e6f38f2125897eb937c906e4d","unresolved":false,"context_lines":[{"line_number":989,"context_line":"        return qg_device_created_successfully, sg_device_created_successfully"},{"line_number":990,"context_line":""},{"line_number":991,"context_line":"    def test_unbound_floating_ip_deployed_on_snat_namespace(self):"},{"line_number":992,"context_line":"        \"\"\"Test to validate the unbound floatingip lifecycle.\"\"\""},{"line_number":993,"context_line":"        self.agent.conf.agent_mode \u003d lib_constants.L3_AGENT_MODE_DVR_SNAT"},{"line_number":994,"context_line":"        router_info \u003d self.generate_dvr_router_info(enable_unbound_fip\u003dTrue)"},{"line_number":995,"context_line":"        router1 \u003d self.manage_router(self.agent, router_info)"}],"source_content_type":"text/x-python","patch_set":15,"id":"ff346bd7_6f282996","line":992,"updated":"2017-07-28 03:42:19.000000000","message":"here as well","commit_id":"c2c355d45306b193cdeb2a2e6843babafe474d9b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"62e27d0341804bc1b9b13756919f4e3cce19a260","unresolved":false,"context_lines":[{"line_number":445,"context_line":"                                 enable_ha\u003dFalse,"},{"line_number":446,"context_line":"                                 enable_snat\u003dFalse,"},{"line_number":447,"context_line":"                                 enable_gw\u003dTrue,"},{"line_number":448,"context_line":"                                 enable_unbound_fip\u003dFalse,"},{"line_number":449,"context_line":"                                 agent\u003dNone,"},{"line_number":450,"context_line":"                                 extra_routes\u003dFalse,"},{"line_number":451,"context_line":"                                 enable_floating_ip\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":16,"id":"df3967d1_da5e42e5","line":448,"updated":"2017-07-31 22:05:52.000000000","message":"agree with Brian\u0027s comment on last PS. This should probably be snat_bound_fip or something similar","commit_id":"7b92c4e09551bca56c0927aec41f5a2a78fe5708"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"455503eeb49e91fdb552adc86174dbc8bedc67d6","unresolved":false,"context_lines":[{"line_number":445,"context_line":"                                 enable_ha\u003dFalse,"},{"line_number":446,"context_line":"                                 enable_snat\u003dFalse,"},{"line_number":447,"context_line":"                                 enable_gw\u003dTrue,"},{"line_number":448,"context_line":"                                 enable_unbound_fip\u003dFalse,"},{"line_number":449,"context_line":"                                 agent\u003dNone,"},{"line_number":450,"context_line":"                                 extra_routes\u003dFalse,"},{"line_number":451,"context_line":"                                 enable_floating_ip\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":16,"id":"df3967d1_b80dc63f","line":448,"in_reply_to":"df3967d1_da5e42e5","updated":"2017-08-01 00:35:44.000000000","message":"sure will fix","commit_id":"7b92c4e09551bca56c0927aec41f5a2a78fe5708"}],"neutron/tests/unit/agent/l3/test_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d4fb4ed2c96eea9e9c17ef2106ec50d487b24af4","unresolved":false,"context_lines":[{"line_number":1241,"context_line":"        ri.fip_ns.create_rtr_2_fip_link \u003d mock.Mock()"},{"line_number":1242,"context_line":"        with mock.patch.object(ri, \u0027get_floating_ips\u0027) as fips, \\"},{"line_number":1243,"context_line":"                mock.patch.object(ri,"},{"line_number":1244,"context_line":"                                  \u0027add_centralized_floatingip\u0027) as central_fip, \\"},{"line_number":1245,"context_line":"                mock.patch.object(ri, \u0027get_floating_agent_gw_interface\u0027"},{"line_number":1246,"context_line":"                                  ) as fip_gw_port, \\"},{"line_number":1247,"context_line":"                mock.patch.object(ri.fip_ns,"}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_58a5f1b4","line":1244,"updated":"2017-08-08 03:50:42.000000000","message":"This is triggering a pep8 failure","commit_id":"912be81132eb12dda24ce9f48e863618cbb401ab"}],"neutron/tests/unit/agent/l3/test_dvr_local_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d185fdef18aa280d78f46e0bcdfdd7274e07f433","unresolved":false,"context_lines":[{"line_number":744,"context_line":"        ri.external_gateway_removed("},{"line_number":745,"context_line":"            ri.ex_gw_port,"},{"line_number":746,"context_line":"            ri.get_external_device_name(ri.ex_gw_port[\u0027id\u0027]))"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"        ri.remove_floating_ip.assert_called_once_with(self.mock_ip_dev,"},{"line_number":749,"context_line":"                                                      \u002719.4.4.2/32\u0027)"},{"line_number":750,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_1adb941b","line":747,"updated":"2017-07-13 22:19:47.000000000","message":"random blank line","commit_id":"c0875691abdd24442c68ed8c76a4ea78569273d8"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"76e31ba9db8fd749c6648edaf5fbf9726ba23ab6","unresolved":false,"context_lines":[{"line_number":744,"context_line":"        ri.external_gateway_removed("},{"line_number":745,"context_line":"            ri.ex_gw_port,"},{"line_number":746,"context_line":"            ri.get_external_device_name(ri.ex_gw_port[\u0027id\u0027]))"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"        ri.remove_floating_ip.assert_called_once_with(self.mock_ip_dev,"},{"line_number":749,"context_line":"                                                      \u002719.4.4.2/32\u0027)"},{"line_number":750,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_71adea86","line":747,"in_reply_to":"1f1a1f67_1adb941b","updated":"2017-07-14 22:44:58.000000000","message":"will fix it.","commit_id":"c0875691abdd24442c68ed8c76a4ea78569273d8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"6ea73529cc06e70c218813175d8cd663133990fa","unresolved":false,"context_lines":[{"line_number":699,"context_line":""},{"line_number":700,"context_line":"    def test_external_gateway_removed_ext_gw_port_and_fip(self):"},{"line_number":701,"context_line":"        agent \u003d l3_agent.L3NATAgent(HOSTNAME, self.conf)"},{"line_number":702,"context_line":"        agent.conf.agent_mode \u003d \u0027dvr_snat\u0027"},{"line_number":703,"context_line":"        router \u003d l3_test_common.prepare_router_data(num_internal_ports\u003d2)"},{"line_number":704,"context_line":"        router[\u0027gw_port_host\u0027] \u003d HOSTNAME"},{"line_number":705,"context_line":"        self.mock_driver.unplug.reset_mock()"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_070dc43d","line":702,"range":{"start_line":702,"start_character":32,"end_line":702,"end_character":42},"updated":"2017-07-21 22:57:08.000000000","message":"This could be lib_constants.L3_AGENT_MODE_DVR_SNAT","commit_id":"8b9f4f9230a74f09fc6477e7c8633db750791a91"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"e111a6bc8015696889b7530f370e80cab0a97171","unresolved":false,"context_lines":[{"line_number":699,"context_line":""},{"line_number":700,"context_line":"    def test_external_gateway_removed_ext_gw_port_and_fip(self):"},{"line_number":701,"context_line":"        agent \u003d l3_agent.L3NATAgent(HOSTNAME, self.conf)"},{"line_number":702,"context_line":"        agent.conf.agent_mode \u003d \u0027dvr_snat\u0027"},{"line_number":703,"context_line":"        router \u003d l3_test_common.prepare_router_data(num_internal_ports\u003d2)"},{"line_number":704,"context_line":"        router[\u0027gw_port_host\u0027] \u003d HOSTNAME"},{"line_number":705,"context_line":"        self.mock_driver.unplug.reset_mock()"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_d9af7292","line":702,"range":{"start_line":702,"start_character":32,"end_line":702,"end_character":42},"in_reply_to":"ff346bd7_070dc43d","updated":"2017-07-24 20:52:33.000000000","message":"Will fix it.","commit_id":"8b9f4f9230a74f09fc6477e7c8633db750791a91"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0d40f217a7a893c05fd02e4c85a0b0c387cc4cda","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        fips \u003d ri.get_floating_ips()"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        self.assertEqual([{\u0027host\u0027: HOSTNAME},"},{"line_number":237,"context_line":"                          {\u0027host\u0027: mock.sentinel.otherhost}], fips)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def test_floating_forward_rules_no_fip_ns(self):"},{"line_number":240,"context_line":"        router \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":19,"id":"df3967d1_7126e6d0","line":237,"updated":"2017-08-04 01:01:10.000000000","message":"super nit: Hopefully wrap lines before \u0027fips\u0027. At now, the expected value (list) is wrapped, but the expected and actual value live in the same line. Just for readability.","commit_id":"ccb7df3c870a83b590d574f8c1d24f276d4a1234"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"616284c8624acb32b684b0a885f16e9d624c53ae","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        fips \u003d ri.get_floating_ips()"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        self.assertEqual([{\u0027host\u0027: HOSTNAME},"},{"line_number":237,"context_line":"                          {\u0027host\u0027: mock.sentinel.otherhost}], fips)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def test_floating_forward_rules_no_fip_ns(self):"},{"line_number":240,"context_line":"        router \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":19,"id":"df3967d1_fba05a44","line":237,"in_reply_to":"df3967d1_7126e6d0","updated":"2017-08-04 17:11:13.000000000","message":"Done","commit_id":"ccb7df3c870a83b590d574f8c1d24f276d4a1234"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d4fb4ed2c96eea9e9c17ef2106ec50d487b24af4","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        fip \u003d {\u0027floating_ip_address\u0027: ip}"},{"line_number":439,"context_line":"        result \u003d self._test_add_floating_ip(ri, fip, True)"},{"line_number":440,"context_line":"        ri.floating_ip_added_dist.assert_called_once_with(fip, ip + \u0027/32\u0027)"},{"line_number":441,"context_line":"        self.assertNotEqual(lib_constants.FLOATINGIP_STATUS_ACTIVE, result)"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"    @mock.patch.object(router_info.RouterInfo, \u0027remove_floating_ip\u0027)"},{"line_number":444,"context_line":"    def test_remove_floating_ip(self, super_remove_floating_ip):"}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_182649b9","line":441,"updated":"2017-08-08 03:50:42.000000000","message":"assertEqual ERROR","commit_id":"912be81132eb12dda24ce9f48e863618cbb401ab"}],"releasenotes/notes/dvr_handle_unbound_floatingip_port-f12ae806b8be2065.yaml":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4727755f4fe4f02f849d02b6268f733d6ba94744","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Floating IPs associated with an unbound port with DVR routers will be"},{"line_number":4,"context_line":"    handled by the network node or ``dvr_snat`` node."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Floating IPs associated with an unbound port with DVR routers will"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"df3967d1_31404307","line":4,"range":{"start_line":2,"start_character":0,"end_line":4,"end_character":53},"updated":"2017-08-04 18:28:47.000000000","message":"prelude is for general comments about a release, so I believe this is unnecessary.","commit_id":"85318f40748c8f61f0ec2e300544d4e3e8abcd6e"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"934dff68ad3b0829ca87c2e6cbdf09e5c87a00a9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Floating IPs associated with an unbound port with DVR routers will be"},{"line_number":4,"context_line":"    handled by the network node or ``dvr_snat`` node."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Floating IPs associated with an unbound port with DVR routers will"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"df3967d1_a7587155","line":4,"range":{"start_line":2,"start_character":0,"end_line":4,"end_character":53},"in_reply_to":"df3967d1_31404307","updated":"2017-08-04 19:42:24.000000000","message":"Done","commit_id":"85318f40748c8f61f0ec2e300544d4e3e8abcd6e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4727755f4fe4f02f849d02b6268f733d6ba94744","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Floating IPs associated with an unbound port with DVR routers will be"},{"line_number":4,"context_line":"    handled by the network node or ``dvr_snat`` node."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Floating IPs associated with an unbound port with DVR routers will"},{"line_number":8,"context_line":"    not be distributed, but will be centralized and implemented in the"},{"line_number":9,"context_line":"    SNAT namespace of the Network node or ``dvr_snat`` node."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"df3967d1_91f7ef59","line":6,"updated":"2017-08-04 18:28:47.000000000","message":"From operator\u0027s perspective, it is nice to write what we can now. In my understanding, DVR now supports to specify floating IPs to allowed_address_pairs in case of floating IPs are assigned to multiple VMs.\n\nIf it is not easy enough to write such thing, adding a link to the bug looks okay to me. operators can understand more by reading it.","commit_id":"85318f40748c8f61f0ec2e300544d4e3e8abcd6e"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"934dff68ad3b0829ca87c2e6cbdf09e5c87a00a9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Floating IPs associated with an unbound port with DVR routers will be"},{"line_number":4,"context_line":"    handled by the network node or ``dvr_snat`` node."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Floating IPs associated with an unbound port with DVR routers will"},{"line_number":8,"context_line":"    not be distributed, but will be centralized and implemented in the"},{"line_number":9,"context_line":"    SNAT namespace of the Network node or ``dvr_snat`` node."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"df3967d1_87532d39","line":6,"in_reply_to":"df3967d1_91f7ef59","updated":"2017-08-04 19:42:24.000000000","message":"Done","commit_id":"85318f40748c8f61f0ec2e300544d4e3e8abcd6e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4727755f4fe4f02f849d02b6268f733d6ba94744","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Floating IPs associated with an unbound port with DVR routers will"},{"line_number":8,"context_line":"    not be distributed, but will be centralized and implemented in the"},{"line_number":9,"context_line":"    SNAT namespace of the Network node or ``dvr_snat`` node."},{"line_number":10,"context_line":"issues:"},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    While the bound port Floating IPs are distributed, the unbound port"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"df3967d1_11ad3f9a","line":9,"updated":"2017-08-04 18:28:47.000000000","message":"Bug link would be nice:\n\n  (`bug 1583694 \u003chttps://bugs.launchpad.net/neutron/+bug/1583694\u003e`__)","commit_id":"85318f40748c8f61f0ec2e300544d4e3e8abcd6e"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"934dff68ad3b0829ca87c2e6cbdf09e5c87a00a9","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Floating IPs associated with an unbound port with DVR routers will"},{"line_number":8,"context_line":"    not be distributed, but will be centralized and implemented in the"},{"line_number":9,"context_line":"    SNAT namespace of the Network node or ``dvr_snat`` node."},{"line_number":10,"context_line":"issues:"},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    While the bound port Floating IPs are distributed, the unbound port"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"df3967d1_273a41e6","line":9,"in_reply_to":"df3967d1_11ad3f9a","updated":"2017-08-04 19:42:24.000000000","message":"Done","commit_id":"85318f40748c8f61f0ec2e300544d4e3e8abcd6e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4727755f4fe4f02f849d02b6268f733d6ba94744","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    Floating IPs are centralized."},{"line_number":14,"context_line":"fixes:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    This fix will allow the unbound port Floating IPs to be configured"},{"line_number":17,"context_line":"    properly with DVR routers irrespective of its device_owner."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"df3967d1_f1fbdbbd","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":13},"updated":"2017-08-04 18:28:47.000000000","message":"After rendered as a release note HTML page, readers cannot identify \u0027This fix\u0027.","commit_id":"85318f40748c8f61f0ec2e300544d4e3e8abcd6e"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"934dff68ad3b0829ca87c2e6cbdf09e5c87a00a9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    Floating IPs are centralized."},{"line_number":14,"context_line":"fixes:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    This fix will allow the unbound port Floating IPs to be configured"},{"line_number":17,"context_line":"    properly with DVR routers irrespective of its device_owner."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"df3967d1_e72799c9","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":13},"in_reply_to":"df3967d1_f1fbdbbd","updated":"2017-08-04 19:42:24.000000000","message":"Done","commit_id":"85318f40748c8f61f0ec2e300544d4e3e8abcd6e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"31e051347349cac3f4973117ba2d4c3ab2eb8f98","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    in the SNAT namespace in the Network node or ``dvr_snat`` node. This"},{"line_number":10,"context_line":"    will address VRRP use cases."},{"line_number":11,"context_line":"    More information about this is captured in"},{"line_number":12,"context_line":"    `bug 1583694 \u003chttps://bugs.launchpad.net/neutron/+bug/1583694\u003e`"},{"line_number":13,"context_line":"issues:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    While the bound port Floating IPs are distributed, the unbound port"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"bf3e73b7_f7aa6fd0","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":67},"updated":"2017-08-05 08:10:24.000000000","message":"__ is needed at the end of line.\nhttp://docs-draft.openstack.org/86/437986/22/check/gate-neutron-releasenotes/e1750c9//releasenotes/build/html/unreleased.html#new-features","commit_id":"c41718fb7b93e39a79abb3fc0264086be3610ed5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4408011d14a76c7663b213a4f2e18e0b76d22852","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    in the SNAT namespace in the Network node or ``dvr_snat`` node. This"},{"line_number":10,"context_line":"    will address VRRP use cases."},{"line_number":11,"context_line":"    More information about this is captured in"},{"line_number":12,"context_line":"    `bug 1583694 \u003chttps://bugs.launchpad.net/neutron/+bug/1583694\u003e`"},{"line_number":13,"context_line":"issues:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    While the bound port Floating IPs are distributed, the unbound port"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"bf3e73b7_973683b4","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":67},"in_reply_to":"bf3e73b7_f7aa6fd0","updated":"2017-08-05 08:23:14.000000000","message":"Done","commit_id":"c41718fb7b93e39a79abb3fc0264086be3610ed5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fcd05f1d6d923290d25cf287f6e35288cf43b8b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"9f436f4f_b5a056a7","updated":"2017-08-08 15:20:14.000000000","message":"Hmm.... it seems the old version was restored and all of my comments in patch set 21 need to be addressed again :(\n\nPerhaps you can just use the release notes of patch set 23.\n\nFor more detail, see \nhttps://review.openstack.org/#/c/437986/21/releasenotes/notes/dvr_handle_unbound_floatingip_port-f12ae806b8be2065.yaml\n\nand https://review.openstack.org/#/c/437986/22/releasenotes/notes/dvr_handle_unbound_floatingip_port-f12ae806b8be2065.yaml","commit_id":"4132c02bec0b214a9fed4e074d605b592dfdb34b"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"3e08d09da2981817a6d92486a9dcdf7bc7d0f036","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"9f436f4f_d6a7604f","in_reply_to":"9f436f4f_b5a056a7","updated":"2017-08-08 17:55:36.000000000","message":"Sure will update it.","commit_id":"4132c02bec0b214a9fed4e074d605b592dfdb34b"}]}
