)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"fc4e4cd49443bea366375b226f26e8bb3218dacc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hirofumi Ichihara \u003cichihara.hirofumi@lab.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-25 12:30:08 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Quota API raises 404 when wrong project_id is passed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Quota API just returns default value even if wrong project_id is"},{"line_number":10,"context_line":"passed. It should raise 404."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da36d5c6_b8e045ce","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":52},"updated":"2017-02-27 15:36:36.000000000","message":"nit: The title exceed the max of number of characters","commit_id":"0eb09b98e9f6c1699964f500e20b4038e1e025a0"}],"neutron/db/quota/driver.py":[{"author":{"_account_id":23821,"name":"Prince Nana Owusu Boateng","email":"prince.a.owusu.boateng@intel.com","username":"nanaboat"},"change_message_id":"cca27ad35a8a7d28c388fc5c4dbed8592e9c235b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                            for key, resource in resources.items())"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        # update with tenant specific limits"},{"line_number":69,"context_line":"        q_qry \u003d db_utils.model_query(context, quota_models.Quota).filter_by("},{"line_number":70,"context_line":"            tenant_id\u003dtenant_id)"},{"line_number":71,"context_line":"        for item in q_qry:"},{"line_number":72,"context_line":"            tenant_quota[item[\u0027resource\u0027]] \u003d item[\u0027limit\u0027]"},{"line_number":73,"context_line":"        else:"},{"line_number":74,"context_line":"            raise n_exc.ProjectNotFound(project_id\u003dtenant_id)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        return tenant_quota"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_57c38e8a","line":74,"range":{"start_line":69,"start_character":8,"end_line":74,"end_character":61},"updated":"2017-02-27 19:12:18.000000000","message":"For every valid tenant, default limit values for a resource set in neutron.conf is returned. Unless an admin user updates/changes  resource default limits then the Quota table returns the new limit for a resource. Therefore validating a tenant_id is out of scope for this method and I believe it should be verified against the Keystone before calling this method.","commit_id":"0eb09b98e9f6c1699964f500e20b4038e1e025a0"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"fc4e4cd49443bea366375b226f26e8bb3218dacc","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            tenant_id\u003dtenant_id)"},{"line_number":71,"context_line":"        for item in q_qry:"},{"line_number":72,"context_line":"            tenant_quota[item[\u0027resource\u0027]] \u003d item[\u0027limit\u0027]"},{"line_number":73,"context_line":"        else:"},{"line_number":74,"context_line":"            raise n_exc.ProjectNotFound(project_id\u003dtenant_id)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        return tenant_quota"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_d8e6d9af","line":74,"range":{"start_line":73,"start_character":8,"end_line":74,"end_character":61},"updated":"2017-02-27 15:36:36.000000000","message":"IMHO the process to verify if the project exist should be against the Keystone API and no in Quotas table.","commit_id":"0eb09b98e9f6c1699964f500e20b4038e1e025a0"}]}
