)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8328f1f00187e73bd2a76289d687b1b8ec141b43","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Check if ha port exists in delete ha router"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Under heavy load deletion of HA router can stuck in loop, when"},{"line_number":10,"context_line":"HA port has been deleted before."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Current change adds check that HA port is not None, before perform"},{"line_number":13,"context_line":"destroying state change monitor, disabling  keepalived and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba2be162_cd927d57","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":31},"updated":"2017-03-01 06:30:08.000000000","message":"is it an error? if yes, we\u0027d better investigate and fix the root cause..","commit_id":"068da465d74a742648fbc21dc8d7041a60731974"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"01cdd57fb09a50897bbcf7f4104c700a64bcc7d9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Check if ha port exists in delete ha router"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Under heavy load deletion of HA router can stuck in loop, when"},{"line_number":10,"context_line":"HA port has been deleted before."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Current change adds check that HA port is not None, before perform"},{"line_number":13,"context_line":"destroying state change monitor, disabling  keepalived and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba2be162_cdc0962d","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":31},"in_reply_to":"ba2be162_cd927d57","updated":"2017-03-01 21:08:35.000000000","message":"In the logs http://paste.openstack.org/show/601001/ for router 2fcdef4e-83fe-48b5-be0f-f45a631c1482 we get notification for router deletion, cleanup network, removing port and then started loop where router is trying to be deleted, but failed as HA port is already None.\n\nI will attach this for bug report.","commit_id":"068da465d74a742648fbc21dc8d7041a60731974"}],"neutron/agent/l3/ha_router.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8328f1f00187e73bd2a76289d687b1b8ec141b43","unresolved":false,"context_lines":[{"line_number":404,"context_line":"                               prefix\u003drouter.EXTERNAL_DEV_PREFIX)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    def delete(self):"},{"line_number":407,"context_line":"        if self.ha_port is None:"},{"line_number":408,"context_line":"            LOG.error(_LE(\"HA port is not initialized or has been already \""},{"line_number":409,"context_line":"                          \"deleted.\"))"},{"line_number":410,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_6d99916e","line":407,"range":{"start_line":407,"start_character":8,"end_line":407,"end_character":31},"updated":"2017-03-01 06:30:08.000000000","message":"was the port properly cleaned up before or just accidentally deleted/not assigned somewhere?","commit_id":"068da465d74a742648fbc21dc8d7041a60731974"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8328f1f00187e73bd2a76289d687b1b8ec141b43","unresolved":false,"context_lines":[{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    def delete(self):"},{"line_number":407,"context_line":"        if self.ha_port is None:"},{"line_number":408,"context_line":"            LOG.error(_LE(\"HA port is not initialized or has been already \""},{"line_number":409,"context_line":"                          \"deleted.\"))"},{"line_number":410,"context_line":"        else:"},{"line_number":411,"context_line":"            self.destroy_state_change_monitor(self.process_monitor)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_2d887922","line":408,"range":{"start_line":408,"start_character":12,"end_line":408,"end_character":21},"updated":"2017-03-01 06:30:08.000000000","message":"please see comment in the commit message.","commit_id":"068da465d74a742648fbc21dc8d7041a60731974"}]}
