)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"14aa9d381057935d36aed9bda87656687da5233f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"not support netmasks or subnet prefixes."},{"line_number":12,"context_line":"This patch addresses the issue by switching to IPNetwork in"},{"line_number":13,"context_line":"_get_allowed_pairs()."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6e27020e5b384b171bdcaac4ece3e547046ee9e4"},{"line_number":16,"context_line":"Closes-Bug: #1669021"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ff52f3f_2b0f572f","line":14,"updated":"2017-04-13 13:21:26.000000000","message":"Please include a DocImpact tag with a sentence or two explaining that allowed address pairs now support ranges as well as single addresses.","commit_id":"c599ef49a9e695888824223c13f95696f008c9e3"}],"neutron/tests/unit/agent/linux/openvswitch_firewall/test_firewall.py":[{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"14aa9d381057935d36aed9bda87656687da5233f","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def test__get_allowed_pairs_cidr(self):"},{"line_number":113,"context_line":"        port \u003d {\u0027allowed_address_pairs\u0027: [{\u0027mac_address\u0027: \u0027foo\u0027,"},{"line_number":114,"context_line":"                                           \u0027ip_address\u0027: \u0027192.168.0.0/30\u0027}]}"},{"line_number":115,"context_line":"        allowed_pairs \u003d ovsfw.OFPort._get_allowed_pairs(port, version\u003d4)"},{"line_number":116,"context_line":"        expected_aap \u003d {(\u0027foo\u0027, \u0027192.168.0.0/30\u0027)}"},{"line_number":117,"context_line":"        self.assertEqual(expected_aap, allowed_pairs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ff52f3f_cb834b56","line":114,"range":{"start_line":114,"start_character":69,"end_line":114,"end_character":72},"updated":"2017-04-13 13:21:26.000000000","message":"Hard to tell from the bug description and commit message, but is the intention here to allow a range as the value stored in ip_address? Or just a single address in cidr notation? If it\u0027s the former, please see my comment on the commit message. If it\u0027s the latter this should be /32, and some validation to prevent anything else would be a good idea.","commit_id":"c599ef49a9e695888824223c13f95696f008c9e3"},{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"2d30287dbf42777b78717e6f94d70c14fb40331c","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def test__get_allowed_pairs_cidr(self):"},{"line_number":113,"context_line":"        port \u003d {\u0027allowed_address_pairs\u0027: [{\u0027mac_address\u0027: \u0027foo\u0027,"},{"line_number":114,"context_line":"                                           \u0027ip_address\u0027: \u0027192.168.0.0/30\u0027}]}"},{"line_number":115,"context_line":"        allowed_pairs \u003d ovsfw.OFPort._get_allowed_pairs(port, version\u003d4)"},{"line_number":116,"context_line":"        expected_aap \u003d {(\u0027foo\u0027, \u0027192.168.0.0/30\u0027)}"},{"line_number":117,"context_line":"        self.assertEqual(expected_aap, allowed_pairs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_98facaba","line":114,"range":{"start_line":114,"start_character":69,"end_line":114,"end_character":72},"in_reply_to":"9ff52f3f_cb834b56","updated":"2017-04-19 18:32:15.000000000","message":"It\u0027s kind of undocumented, but by design iptables firewall allows prefixes in ip_address part of allowed_address_pairs (https://github.com/openstack/neutron/blob/master/neutron/common/utils.py#L233 and https://github.com/openstack/neutron/blob/master/neutron/agent/linux/iptables_firewall.py#L398). \nSo there was no intention to specifically introduce a range stored in ip_address, but to add consistency between 2 firewall drivers.","commit_id":"c599ef49a9e695888824223c13f95696f008c9e3"}]}
