)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"b2118a93957f2dd00874cf77d6e976c3064ffc8e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     rtmdk \u003crtmdk@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-06 20:31:55 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"self.available_local_vlans add 4094"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"problem"},{"line_number":10,"context_line":"    self.available_local_vlans omit 4094."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9a30ddce_130cc293","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":35},"updated":"2017-03-07 10:17:38.000000000","message":"Please consider a better title here.","commit_id":"ff2a91a6f3855c351ba43cbb0956496576cfcedf"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"b2118a93957f2dd00874cf77d6e976c3064ffc8e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"self.available_local_vlans add 4094"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"problem"},{"line_number":10,"context_line":"    self.available_local_vlans omit 4094."},{"line_number":11,"context_line":"solution"},{"line_number":12,"context_line":"    add 4094 for local vlan."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1668908"},{"line_number":15,"context_line":"Change-Id: Ic25929cad89ab2e31fdf5b70875b84491dfc52ed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9a30ddce_1383e2cd","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":28},"updated":"2017-03-07 10:17:38.000000000","message":"Describe the current problem and how to fix it.","commit_id":"ff2a91a6f3855c351ba43cbb0956496576cfcedf"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_neutron_agent.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"1509feb530ef9d66f39e222f5970fad1266b74c2","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        self.assertEqual(expected,"},{"line_number":210,"context_line":"                         self.agent.agent_state[\u0027agent_type\u0027])"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def test_agent_available_local_vlans(self):"},{"line_number":213,"context_line":"        expected \u003d [p_const.MIN_VLAN_TAG,"},{"line_number":214,"context_line":"                    p_const.MIN_VLAN_TAG + 1,"},{"line_number":215,"context_line":"                    p_const.MAX_VLAN_TAG - 1,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba2be162_bdd67325","line":212,"updated":"2017-03-06 18:21:41.000000000","message":"Can we also add a negative test case like if the vlan_tag is greater than 4094 then it is is not in the self.agent.available_local_vlans?","commit_id":"38f120fcbf27387ccae4380aa2cb2053d2efc646"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"b2118a93957f2dd00874cf77d6e976c3064ffc8e","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        exception \u003d [p_const.MIN_VLAN_TAG - 1,"},{"line_number":218,"context_line":"                     p_const.MAX_VLAN_TAG + 1,"},{"line_number":219,"context_line":"                     p_const.MAX_VLAN_TAG + 2]"},{"line_number":220,"context_line":"        for tag in expected:"},{"line_number":221,"context_line":"            self.assertTrue(tag in self.agent.available_local_vlans)"},{"line_number":222,"context_line":"        for tag in exception:"},{"line_number":223,"context_line":"            self.assertFalse(tag in self.agent.available_local_vlans)"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a30ddce_b373f64c","line":221,"range":{"start_line":220,"start_character":8,"end_line":221,"end_character":68},"updated":"2017-03-07 10:17:38.000000000","message":"Please consider to use assertIn to avoid iteration.","commit_id":"ff2a91a6f3855c351ba43cbb0956496576cfcedf"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"b2118a93957f2dd00874cf77d6e976c3064ffc8e","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        for tag in expected:"},{"line_number":221,"context_line":"            self.assertTrue(tag in self.agent.available_local_vlans)"},{"line_number":222,"context_line":"        for tag in exception:"},{"line_number":223,"context_line":"            self.assertFalse(tag in self.agent.available_local_vlans)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def test_agent_type_alt(self):"},{"line_number":226,"context_line":"        with mock.patch.object(self.mod_agent.OVSNeutronAgent,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a30ddce_73c7be45","line":223,"range":{"start_line":223,"start_character":17,"end_line":223,"end_character":28},"updated":"2017-03-07 10:17:38.000000000","message":"assertNotIn","commit_id":"ff2a91a6f3855c351ba43cbb0956496576cfcedf"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"4b1aec6d020ed22bab38242b95b770b2c1a64d1c","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                         self.agent.agent_state[\u0027agent_type\u0027])"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def test_agent_available_local_vlans(self):"},{"line_number":215,"context_line":"        expected \u003d [p_const.MIN_VLAN_TAG,"},{"line_number":216,"context_line":"                    p_const.MIN_VLAN_TAG + 1,"},{"line_number":217,"context_line":"                    p_const.MAX_VLAN_TAG - 1,"},{"line_number":218,"context_line":"                    p_const.MAX_VLAN_TAG]"},{"line_number":219,"context_line":"        exception \u003d [p_const.MIN_VLAN_TAG - 1,"},{"line_number":220,"context_line":"                     p_const.MAX_VLAN_TAG + 1,"},{"line_number":221,"context_line":"                     p_const.MAX_VLAN_TAG + 2]"},{"line_number":222,"context_line":"        available_vlan \u003d self.agent.available_local_vlans"},{"line_number":223,"context_line":"        for tag in expected:"},{"line_number":224,"context_line":"            self.assertIn(tag, available_vlan)"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a22e58a_62928f59","line":221,"range":{"start_line":215,"start_character":7,"end_line":221,"end_character":46},"updated":"2017-03-14 10:54:41.000000000","message":"In case you will need to push another patch set: I would make two separate tests for this.","commit_id":"ae8e6095f9c15f9d1012427c0b098c98fdc154fa"}]}