)]}'
{"neutron/tests/tempest/scenario/test_sctp.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"92b458bd8c72ecde0a4f8b3de86bfd1be6f85c5f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                                      )[\u0027ports\u0027][0]"},{"line_number":49,"context_line":"        self.fip2 \u003d self.create_and_associate_floatingip(port[\u0027id\u0027])"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        cmd1 \u003d \"ncat --sctp %s 132 \u003e /tmp/1\" % self.floating_ips[1]["},{"line_number":52,"context_line":"            \u0027fixed_ip_address\u0027]"},{"line_number":53,"context_line":"        cmd2 \u003d \"echo sctp_check | ncat --sctp -l -p 132  \u003e /dev/null \u0026\""},{"line_number":54,"context_line":"        server_ssh_client \u003d remote_client.RemoteClient("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_6ae11afe","line":51,"updated":"2017-03-02 16:11:09.000000000","message":"Not sure writing to a specific file on /tmp is good, I know in the base neutron tests there\u0027s a path that can be used that causes uniqueness.  But I don\u0027t now everything about the tempest tests.","commit_id":"f3d7a5cd5797cdf5200a2cd28afebb73f209868c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ff38eaaa7e8fda5b501d46e4a943097f86587ad4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                                      )[\u0027ports\u0027][0]"},{"line_number":49,"context_line":"        self.fip2 \u003d self.create_and_associate_floatingip(port[\u0027id\u0027])"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        cmd1 \u003d \"ncat --sctp %s 132 \u003e /tmp/1\" % self.floating_ips[1]["},{"line_number":52,"context_line":"            \u0027fixed_ip_address\u0027]"},{"line_number":53,"context_line":"        cmd2 \u003d \"echo sctp_check | ncat --sctp -l -p 132  \u003e /dev/null \u0026\""},{"line_number":54,"context_line":"        server_ssh_client \u003d remote_client.RemoteClient("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_791c1c6a","line":51,"range":{"start_line":51,"start_character":16,"end_line":51,"end_character":34},"updated":"2017-03-13 15:41:51.000000000","message":"There is a class in tests.common.net_helpers called NetcatTester. The description is: \"Tool for testing connectivity on transport layer using netcat executable\". Maybe you should use it, instead of creating your own commands.","commit_id":"f3d7a5cd5797cdf5200a2cd28afebb73f209868c"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"d4650dc3253f5847374d6deee0b7129a229074a2","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                                      )[\u0027ports\u0027][0]"},{"line_number":49,"context_line":"        self.fip2 \u003d self.create_and_associate_floatingip(port[\u0027id\u0027])"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        cmd1 \u003d \"ncat --sctp %s 132 \u003e /tmp/1\" % self.floating_ips[1]["},{"line_number":52,"context_line":"            \u0027fixed_ip_address\u0027]"},{"line_number":53,"context_line":"        cmd2 \u003d \"echo sctp_check | ncat --sctp -l -p 132  \u003e /dev/null \u0026\""},{"line_number":54,"context_line":"        server_ssh_client \u003d remote_client.RemoteClient("}],"source_content_type":"text/x-python","patch_set":1,"id":"5a22e58a_94bb5275","line":51,"range":{"start_line":51,"start_character":16,"end_line":51,"end_character":34},"in_reply_to":"9a30ddce_791c1c6a","updated":"2017-03-14 11:26:04.000000000","message":"Thanks for the tip, but at the moment there is a bug that causes loop when imported in the scenario","commit_id":"f3d7a5cd5797cdf5200a2cd28afebb73f209868c"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"d4650dc3253f5847374d6deee0b7129a229074a2","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                                      )[\u0027ports\u0027][0]"},{"line_number":49,"context_line":"        self.fip2 \u003d self.create_and_associate_floatingip(port[\u0027id\u0027])"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        cmd1 \u003d \"ncat --sctp %s 132 \u003e /tmp/1\" % self.floating_ips[1]["},{"line_number":52,"context_line":"            \u0027fixed_ip_address\u0027]"},{"line_number":53,"context_line":"        cmd2 \u003d \"echo sctp_check | ncat --sctp -l -p 132  \u003e /dev/null \u0026\""},{"line_number":54,"context_line":"        server_ssh_client \u003d remote_client.RemoteClient("}],"source_content_type":"text/x-python","patch_set":1,"id":"5a22e58a_dd996621","line":51,"in_reply_to":"9a30ddce_961a7fc4","updated":"2017-03-14 11:26:04.000000000","message":"Thank you for pointing me out for that, found the solution to do it without the files in this patch","commit_id":"f3d7a5cd5797cdf5200a2cd28afebb73f209868c"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"b5f38066f5d9e7b376675453656bb5efbc8696de","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                                      )[\u0027ports\u0027][0]"},{"line_number":49,"context_line":"        self.fip2 \u003d self.create_and_associate_floatingip(port[\u0027id\u0027])"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        cmd1 \u003d \"ncat --sctp %s 132 \u003e /tmp/1\" % self.floating_ips[1]["},{"line_number":52,"context_line":"            \u0027fixed_ip_address\u0027]"},{"line_number":53,"context_line":"        cmd2 \u003d \"echo sctp_check | ncat --sctp -l -p 132  \u003e /dev/null \u0026\""},{"line_number":54,"context_line":"        server_ssh_client \u003d remote_client.RemoteClient("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_8d7b6c7a","line":51,"in_reply_to":"ba2be162_6ae11afe","updated":"2017-03-05 10:55:44.000000000","message":"Can you point me exactly where is this path?","commit_id":"f3d7a5cd5797cdf5200a2cd28afebb73f209868c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b9ee61d6ef97979537c37d08344b77f549a7c464","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                                      )[\u0027ports\u0027][0]"},{"line_number":49,"context_line":"        self.fip2 \u003d self.create_and_associate_floatingip(port[\u0027id\u0027])"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        cmd1 \u003d \"ncat --sctp %s 132 \u003e /tmp/1\" % self.floating_ips[1]["},{"line_number":52,"context_line":"            \u0027fixed_ip_address\u0027]"},{"line_number":53,"context_line":"        cmd2 \u003d \"echo sctp_check | ncat --sctp -l -p 132  \u003e /dev/null \u0026\""},{"line_number":54,"context_line":"        server_ssh_client \u003d remote_client.RemoteClient("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_961a7fc4","line":51,"in_reply_to":"ba2be162_8d7b6c7a","updated":"2017-03-13 15:41:16.000000000","message":"Maybe the best idea is to create a tmp dir:\n  self.tmpdir \u003d self.useFixture(fixtures.TempDir())\n\nThen you can use it like here:\n  self.vf_address \u003d os.path.join(self.tmpdir.path, \"address\")\n  with open(self.vf_address, \"w\") as f:\n       f.write(\"ca:fe:ca:fe:ca:fe\\n\")","commit_id":"f3d7a5cd5797cdf5200a2cd28afebb73f209868c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"92b458bd8c72ecde0a4f8b3de86bfd1be6f85c5f","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        cmd1 \u003d \"ncat --sctp %s 132 \u003e /tmp/1\" % self.floating_ips[1]["},{"line_number":52,"context_line":"            \u0027fixed_ip_address\u0027]"},{"line_number":53,"context_line":"        cmd2 \u003d \"echo sctp_check | ncat --sctp -l -p 132  \u003e /dev/null \u0026\""},{"line_number":54,"context_line":"        server_ssh_client \u003d remote_client.RemoteClient("},{"line_number":55,"context_line":"            self.floating_ips[0][\u0027floating_ip_address\u0027],"},{"line_number":56,"context_line":"            CONF.validation.image_ssh_user,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_0a897e26","line":53,"updated":"2017-03-02 16:11:09.000000000","message":"Why \u0027-p 132\u0027 ?  Don\u0027t think that will work if you\u0027re not root since it\u0027s a port number, not protocol number.","commit_id":"f3d7a5cd5797cdf5200a2cd28afebb73f209868c"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"b5f38066f5d9e7b376675453656bb5efbc8696de","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        cmd1 \u003d \"ncat --sctp %s 132 \u003e /tmp/1\" % self.floating_ips[1]["},{"line_number":52,"context_line":"            \u0027fixed_ip_address\u0027]"},{"line_number":53,"context_line":"        cmd2 \u003d \"echo sctp_check | ncat --sctp -l -p 132  \u003e /dev/null \u0026\""},{"line_number":54,"context_line":"        server_ssh_client \u003d remote_client.RemoteClient("},{"line_number":55,"context_line":"            self.floating_ips[0][\u0027floating_ip_address\u0027],"},{"line_number":56,"context_line":"            CONF.validation.image_ssh_user,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_cd99e4c5","line":53,"in_reply_to":"ba2be162_0a897e26","updated":"2017-03-05 10:55:44.000000000","message":"Actually it worked, but indeed it makes sense to try another (bigger) value for the port, so I change it to 60000","commit_id":"f3d7a5cd5797cdf5200a2cd28afebb73f209868c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"92b458bd8c72ecde0a4f8b3de86bfd1be6f85c5f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.assertRaises("},{"line_number":63,"context_line":"            exceptions.SSHExecCommandFailed, self._check_sctp_connectivity,"},{"line_number":64,"context_line":"            server_ssh_client, server_ssh_client2, cmd1, cmd2)"},{"line_number":65,"context_line":"        rulesets \u003d [{\u0027protocol\u0027: 132,"},{"line_number":66,"context_line":"                     \u0027direction\u0027: \u0027ingress\u0027,"},{"line_number":67,"context_line":"                     \u0027remote_ip_prefix\u0027: \u00270.0.0.0/0\u0027}]"},{"line_number":68,"context_line":"        self.create_secgroup_rules(rulesets,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_4f3c68e2","line":65,"updated":"2017-03-02 16:11:09.000000000","message":"You should be able to use \u0027sctp\u0027, right?  IP_PROTOCOL_MAP has the mapping for it.","commit_id":"f3d7a5cd5797cdf5200a2cd28afebb73f209868c"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"b5f38066f5d9e7b376675453656bb5efbc8696de","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.assertRaises("},{"line_number":63,"context_line":"            exceptions.SSHExecCommandFailed, self._check_sctp_connectivity,"},{"line_number":64,"context_line":"            server_ssh_client, server_ssh_client2, cmd1, cmd2)"},{"line_number":65,"context_line":"        rulesets \u003d [{\u0027protocol\u0027: 132,"},{"line_number":66,"context_line":"                     \u0027direction\u0027: \u0027ingress\u0027,"},{"line_number":67,"context_line":"                     \u0027remote_ip_prefix\u0027: \u00270.0.0.0/0\u0027}]"},{"line_number":68,"context_line":"        self.create_secgroup_rules(rulesets,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_0d621cd8","line":65,"in_reply_to":"ba2be162_4f3c68e2","updated":"2017-03-05 10:55:44.000000000","message":"Done","commit_id":"f3d7a5cd5797cdf5200a2cd28afebb73f209868c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"698a1ae985a5b82243d2a4b1bb608d0e70506e6f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def test_basic_sctp(self):"},{"line_number":34,"context_line":"        port_num \u003d 6000"},{"line_number":35,"context_line":"        self.setup_network_and_server()"},{"line_number":36,"context_line":"        self.check_connectivity(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":37,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":38,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":39,"context_line":"        self.server2 \u003d self.create_server("}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_cf31baa3","line":36,"updated":"2017-03-13 16:32:17.000000000","message":"I don\u0027t think you need this connectivity test. setup_network_and_server is supposed to give you a server you can connect to","commit_id":"529df03ee18b20bdaf9c3ab5168bed41c1110ba0"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"41b136cc3df334794bb159bb0246c630fb81e8c0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def test_basic_sctp(self):"},{"line_number":34,"context_line":"        port_num \u003d 6000"},{"line_number":35,"context_line":"        self.setup_network_and_server()"},{"line_number":36,"context_line":"        self.check_connectivity(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":37,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":38,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":39,"context_line":"        self.server2 \u003d self.create_server("}],"source_content_type":"text/x-python","patch_set":2,"id":"5a22e58a_798def7a","line":36,"in_reply_to":"9a30ddce_cf31baa3","updated":"2017-03-14 08:16:22.000000000","message":"Done","commit_id":"529df03ee18b20bdaf9c3ab5168bed41c1110ba0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"698a1ae985a5b82243d2a4b1bb608d0e70506e6f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.check_connectivity(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":37,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":38,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":39,"context_line":"        self.server2 \u003d self.create_server("},{"line_number":40,"context_line":"            flavor_ref\u003dCONF.compute.flavor_ref,"},{"line_number":41,"context_line":"            image_ref\u003dCONF.compute.image_ref,"},{"line_number":42,"context_line":"            key_name\u003dself.keypair[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_2c3d04c4","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":20},"updated":"2017-03-13 16:32:17.000000000","message":"why not just server2? you are only referencing it in this method","commit_id":"529df03ee18b20bdaf9c3ab5168bed41c1110ba0"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"41b136cc3df334794bb159bb0246c630fb81e8c0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.check_connectivity(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":37,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":38,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":39,"context_line":"        self.server2 \u003d self.create_server("},{"line_number":40,"context_line":"            flavor_ref\u003dCONF.compute.flavor_ref,"},{"line_number":41,"context_line":"            image_ref\u003dCONF.compute.image_ref,"},{"line_number":42,"context_line":"            key_name\u003dself.keypair[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a22e58a_79488f5c","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":20},"in_reply_to":"9a30ddce_2c3d04c4","updated":"2017-03-14 08:16:22.000000000","message":"Done","commit_id":"529df03ee18b20bdaf9c3ab5168bed41c1110ba0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"698a1ae985a5b82243d2a4b1bb608d0e70506e6f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        port \u003d self.client.list_ports(network_id\u003dself.network[\u0027id\u0027],"},{"line_number":49,"context_line":"                                      device_id\u003dself.server2[\u0027server\u0027][\u0027id\u0027]"},{"line_number":50,"context_line":"                                      )[\u0027ports\u0027][0]"},{"line_number":51,"context_line":"        self.fip2 \u003d self.create_and_associate_floatingip(port[\u0027id\u0027])"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        cmd1 \u003d \"ncat --sctp %s %s \u003e /tmp/1\" % (self.floating_ips[1]["},{"line_number":54,"context_line":"            \u0027fixed_ip_address\u0027], port_num)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_2c442448","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":17},"updated":"2017-03-13 16:32:17.000000000","message":"why not just fip2? you are only referencing this in this method","commit_id":"529df03ee18b20bdaf9c3ab5168bed41c1110ba0"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"41b136cc3df334794bb159bb0246c630fb81e8c0","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        port \u003d self.client.list_ports(network_id\u003dself.network[\u0027id\u0027],"},{"line_number":49,"context_line":"                                      device_id\u003dself.server2[\u0027server\u0027][\u0027id\u0027]"},{"line_number":50,"context_line":"                                      )[\u0027ports\u0027][0]"},{"line_number":51,"context_line":"        self.fip2 \u003d self.create_and_associate_floatingip(port[\u0027id\u0027])"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        cmd1 \u003d \"ncat --sctp %s %s \u003e /tmp/1\" % (self.floating_ips[1]["},{"line_number":54,"context_line":"            \u0027fixed_ip_address\u0027], port_num)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a22e58a_d96d03ce","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":17},"in_reply_to":"9a30ddce_2c442448","updated":"2017-03-14 08:16:22.000000000","message":"Done","commit_id":"529df03ee18b20bdaf9c3ab5168bed41c1110ba0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"698a1ae985a5b82243d2a4b1bb608d0e70506e6f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                                      )[\u0027ports\u0027][0]"},{"line_number":51,"context_line":"        self.fip2 \u003d self.create_and_associate_floatingip(port[\u0027id\u0027])"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        cmd1 \u003d \"ncat --sctp %s %s \u003e /tmp/1\" % (self.floating_ips[1]["},{"line_number":54,"context_line":"            \u0027fixed_ip_address\u0027], port_num)"},{"line_number":55,"context_line":"        cmd2 \u003d (\"echo sctp_check | ncat --sctp -l -p %d  \u003e /dev/null \u0026\""},{"line_number":56,"context_line":"                % port_num)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_4cadd8e7","line":53,"range":{"start_line":53,"start_character":47,"end_line":53,"end_character":67},"updated":"2017-03-13 16:32:17.000000000","message":"why not just fip2? (see comment to line 51)","commit_id":"529df03ee18b20bdaf9c3ab5168bed41c1110ba0"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"41b136cc3df334794bb159bb0246c630fb81e8c0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                                      )[\u0027ports\u0027][0]"},{"line_number":51,"context_line":"        self.fip2 \u003d self.create_and_associate_floatingip(port[\u0027id\u0027])"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        cmd1 \u003d \"ncat --sctp %s %s \u003e /tmp/1\" % (self.floating_ips[1]["},{"line_number":54,"context_line":"            \u0027fixed_ip_address\u0027], port_num)"},{"line_number":55,"context_line":"        cmd2 \u003d (\"echo sctp_check | ncat --sctp -l -p %d  \u003e /dev/null \u0026\""},{"line_number":56,"context_line":"                % port_num)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a22e58a_f910ffaa","line":53,"range":{"start_line":53,"start_character":47,"end_line":53,"end_character":67},"in_reply_to":"9a30ddce_4cadd8e7","updated":"2017-03-14 08:16:22.000000000","message":"Done","commit_id":"529df03ee18b20bdaf9c3ab5168bed41c1110ba0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"698a1ae985a5b82243d2a4b1bb608d0e70506e6f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        cmd2 \u003d (\"echo sctp_check | ncat --sctp -l -p %d  \u003e /dev/null \u0026\""},{"line_number":56,"context_line":"                % port_num)"},{"line_number":57,"context_line":"        server_ssh_client \u003d remote_client.RemoteClient("},{"line_number":58,"context_line":"            self.floating_ips[0][\u0027floating_ip_address\u0027],"},{"line_number":59,"context_line":"            CONF.validation.image_ssh_user,"},{"line_number":60,"context_line":"            pkey\u003dself.keypair[\u0027private_key\u0027], server\u003dself.server[\u0027server\u0027])"},{"line_number":61,"context_line":"        server_ssh_client2 \u003d remote_client.RemoteClient("}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_acd5741c","line":58,"range":{"start_line":58,"start_character":17,"end_line":58,"end_character":32},"updated":"2017-03-13 16:32:17.000000000","message":"why not reference it directly? Just self.fip","commit_id":"529df03ee18b20bdaf9c3ab5168bed41c1110ba0"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"41b136cc3df334794bb159bb0246c630fb81e8c0","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        cmd2 \u003d (\"echo sctp_check | ncat --sctp -l -p %d  \u003e /dev/null \u0026\""},{"line_number":56,"context_line":"                % port_num)"},{"line_number":57,"context_line":"        server_ssh_client \u003d remote_client.RemoteClient("},{"line_number":58,"context_line":"            self.floating_ips[0][\u0027floating_ip_address\u0027],"},{"line_number":59,"context_line":"            CONF.validation.image_ssh_user,"},{"line_number":60,"context_line":"            pkey\u003dself.keypair[\u0027private_key\u0027], server\u003dself.server[\u0027server\u0027])"},{"line_number":61,"context_line":"        server_ssh_client2 \u003d remote_client.RemoteClient("}],"source_content_type":"text/x-python","patch_set":2,"id":"5a22e58a_1926bb16","line":58,"range":{"start_line":58,"start_character":17,"end_line":58,"end_character":32},"in_reply_to":"9a30ddce_acd5741c","updated":"2017-03-14 08:16:22.000000000","message":"Done","commit_id":"529df03ee18b20bdaf9c3ab5168bed41c1110ba0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"698a1ae985a5b82243d2a4b1bb608d0e70506e6f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            CONF.validation.image_ssh_user,"},{"line_number":60,"context_line":"            pkey\u003dself.keypair[\u0027private_key\u0027], server\u003dself.server[\u0027server\u0027])"},{"line_number":61,"context_line":"        server_ssh_client2 \u003d remote_client.RemoteClient("},{"line_number":62,"context_line":"            self.floating_ips[1][\u0027floating_ip_address\u0027],"},{"line_number":63,"context_line":"            CONF.validation.image_ssh_user,"},{"line_number":64,"context_line":"            pkey\u003dself.keypair[\u0027private_key\u0027], server\u003dself.server2[\u0027server\u0027])"},{"line_number":65,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_8fb8a212","line":62,"range":{"start_line":62,"start_character":12,"end_line":62,"end_character":32},"updated":"2017-03-13 16:32:17.000000000","message":"Why not reference it directly? Just fip2","commit_id":"529df03ee18b20bdaf9c3ab5168bed41c1110ba0"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"41b136cc3df334794bb159bb0246c630fb81e8c0","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            CONF.validation.image_ssh_user,"},{"line_number":60,"context_line":"            pkey\u003dself.keypair[\u0027private_key\u0027], server\u003dself.server[\u0027server\u0027])"},{"line_number":61,"context_line":"        server_ssh_client2 \u003d remote_client.RemoteClient("},{"line_number":62,"context_line":"            self.floating_ips[1][\u0027floating_ip_address\u0027],"},{"line_number":63,"context_line":"            CONF.validation.image_ssh_user,"},{"line_number":64,"context_line":"            pkey\u003dself.keypair[\u0027private_key\u0027], server\u003dself.server2[\u0027server\u0027])"},{"line_number":65,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":2,"id":"5a22e58a_791defbc","line":62,"range":{"start_line":62,"start_character":12,"end_line":62,"end_character":32},"in_reply_to":"9a30ddce_8fb8a212","updated":"2017-03-14 08:16:22.000000000","message":"Done","commit_id":"529df03ee18b20bdaf9c3ab5168bed41c1110ba0"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"df5d2e533b43995d69be0d57ad0a3a17c4600c43","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                                      cmd1\u003dcmd1,"},{"line_number":72,"context_line":"                                      cmd2\u003dcmd2)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _check_sctp_connectivity(self, ssh_client1, ssh_client2, cmd1, cmd2,"},{"line_number":75,"context_line":"                                 should_succeed\u003dTrue):"},{"line_number":76,"context_line":"        ssh_client2.exec_command(cmd2)"},{"line_number":77,"context_line":"        output \u003d ssh_client1.exec_command(cmd1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_ec5f3ee3","line":74,"updated":"2017-04-14 22:53:39.000000000","message":"I would make the formation of the individual sctp commands the responsibility of this function. Just have this function accept the higher level data like what IP address and port to use.","commit_id":"0218b1b82802839c41f7ce8fb52fd804fffefcf9"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"d8c7037bde9ca0badf914531680dcc37d5e4ae98","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                                      cmd1\u003dcmd1,"},{"line_number":72,"context_line":"                                      cmd2\u003dcmd2)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _check_sctp_connectivity(self, ssh_client1, ssh_client2, cmd1, cmd2,"},{"line_number":75,"context_line":"                                 should_succeed\u003dTrue):"},{"line_number":76,"context_line":"        ssh_client2.exec_command(cmd2)"},{"line_number":77,"context_line":"        output \u003d ssh_client1.exec_command(cmd1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_6f0e2433","line":74,"in_reply_to":"7ffa3b31_ec5f3ee3","updated":"2017-04-19 10:15:12.000000000","message":"Done","commit_id":"0218b1b82802839c41f7ce8fb52fd804fffefcf9"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"df5d2e533b43995d69be0d57ad0a3a17c4600c43","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        if should_succeed:"},{"line_number":79,"context_line":"            self.assertIn(\u0027sctp_check\u0027, output)"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            self.assertNotIn(\u0027sctp_check\u0027, output)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_cc6482bc","line":81,"updated":"2017-04-14 22:53:39.000000000","message":"It seems like we will never reach this branch since an SCTP failure results in an exception from the ssh command above. I would just remove the \u0027should_succeed\u0027 completely.","commit_id":"0218b1b82802839c41f7ce8fb52fd804fffefcf9"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"d8c7037bde9ca0badf914531680dcc37d5e4ae98","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        if should_succeed:"},{"line_number":79,"context_line":"            self.assertIn(\u0027sctp_check\u0027, output)"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            self.assertNotIn(\u0027sctp_check\u0027, output)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_2f313ced","line":81,"in_reply_to":"7ffa3b31_cc6482bc","updated":"2017-04-19 10:15:12.000000000","message":"@kevin Maybe it makes more sense to leave the negative case in this function by removing 61-63 and putting exception handling in this function?","commit_id":"0218b1b82802839c41f7ce8fb52fd804fffefcf9"}],"neutron/tests/tempest/scenario/test_trunk.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"698a1ae985a5b82243d2a4b1bb608d0e70506e6f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":51,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network)"},{"line_number":52,"context_line":"        router \u003d cls.create_router_by_client()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        cls.create_router_interface(router[\u0027id\u0027], cls.subnet[\u0027id\u0027])"},{"line_number":55,"context_line":"        cls.keypair \u003d cls.create_keypair()"},{"line_number":56,"context_line":"        cls.secgroup \u003d cls.manager.network_client.create_security_group("}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_d61797a0","line":53,"updated":"2017-03-13 16:32:17.000000000","message":"This is a gratuitous change that has nothing to do with this patchset. Please re-store to previous state","commit_id":"529df03ee18b20bdaf9c3ab5168bed41c1110ba0"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"41b136cc3df334794bb159bb0246c630fb81e8c0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":51,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network)"},{"line_number":52,"context_line":"        router \u003d cls.create_router_by_client()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        cls.create_router_interface(router[\u0027id\u0027], cls.subnet[\u0027id\u0027])"},{"line_number":55,"context_line":"        cls.keypair \u003d cls.create_keypair()"},{"line_number":56,"context_line":"        cls.secgroup \u003d cls.manager.network_client.create_security_group("}],"source_content_type":"text/x-python","patch_set":2,"id":"5a22e58a_f90d5f38","line":53,"in_reply_to":"9a30ddce_d61797a0","updated":"2017-03-14 08:16:22.000000000","message":"Indeed, I probably did it by mistake, will return to previous state","commit_id":"529df03ee18b20bdaf9c3ab5168bed41c1110ba0"}]}