)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9fc4e2008d5f902c2e840587298662f858f26968","unresolved":false,"context_lines":[{"line_number":10,"context_line":"transaction execution time exceeds the probe interval, OVS will"},{"line_number":11,"context_line":"disconnect and the transaction will return TRY_AGAIN and most"},{"line_number":12,"context_line":"likely repeat failing until the vsctl_timeout is reached. This"},{"line_number":13,"context_line":"change adds ensures that the failsafe creation of the manager sets"},{"line_number":14,"context_line":"the inactivity probe to the vsctl_timeout value."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Currently the patch doesn\u0027t override the probe_interval on an"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a30ddce_3e916f9a","line":13,"range":{"start_line":13,"start_character":12,"end_line":13,"end_character":20},"updated":"2017-03-07 18:59:16.000000000","message":"not sure it\u0027s a word","commit_id":"e8044373421bdbb9511fef7423e5be003e5905fc"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"dea0e4ee268806c28c3976e399a57e3f91d3bf70","unresolved":false,"context_lines":[{"line_number":10,"context_line":"transaction execution time exceeds the probe interval, OVS will"},{"line_number":11,"context_line":"disconnect and the transaction will return TRY_AGAIN and most"},{"line_number":12,"context_line":"likely repeat failing until the vsctl_timeout is reached. This"},{"line_number":13,"context_line":"change adds ensures that the failsafe creation of the manager sets"},{"line_number":14,"context_line":"the inactivity probe to the vsctl_timeout value."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Currently the patch doesn\u0027t override the probe_interval on an"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a30ddce_24bfa2fc","line":13,"range":{"start_line":13,"start_character":12,"end_line":13,"end_character":20},"in_reply_to":"9a30ddce_3e916f9a","updated":"2017-03-07 19:47:26.000000000","message":"https://www.google.com/search?q\u003ddefine%3Aensure\n\nThe problem is I forgot to delete the word \u0027adds\u0027.","commit_id":"e8044373421bdbb9511fef7423e5be003e5905fc"}],"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9fc4e2008d5f902c2e840587298662f858f26968","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.vsctl_timeout \u003d cfg.CONF.ovs_vsctl_timeout"},{"line_number":108,"context_line":"        self.ovsdb \u003d ovsdb.API.get(self)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def add_manager(self, connection_uri, timeout\u003d()):"},{"line_number":111,"context_line":"        # if no timeout passed, use cfg, if False, don\u0027t set a timeout"},{"line_number":112,"context_line":"        timeout \u003d timeout if timeout !\u003d () else cfg.CONF.ovs_vsctl_timeout"},{"line_number":113,"context_line":"        with self.ovsdb.transaction() as txn:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_be58fffb","line":110,"range":{"start_line":110,"start_character":50,"end_line":110,"end_character":52},"updated":"2017-03-07 18:59:16.000000000","message":"it\u0027s more customary to have it as \u003dNone","commit_id":"e8044373421bdbb9511fef7423e5be003e5905fc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c391725ab976aab9be7f44b4576e1eab6cceff80","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.vsctl_timeout \u003d cfg.CONF.ovs_vsctl_timeout"},{"line_number":108,"context_line":"        self.ovsdb \u003d ovsdb.API.get(self)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def add_manager(self, connection_uri, timeout\u003d()):"},{"line_number":111,"context_line":"        # if no timeout passed, use cfg, if False, don\u0027t set a timeout"},{"line_number":112,"context_line":"        timeout \u003d timeout if timeout !\u003d () else cfg.CONF.ovs_vsctl_timeout"},{"line_number":113,"context_line":"        with self.ovsdb.transaction() as txn:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_8f94e737","line":110,"range":{"start_line":110,"start_character":50,"end_line":110,"end_character":52},"in_reply_to":"9a30ddce_4491f6ef","updated":"2017-03-07 20:01:28.000000000","message":"You should at least document what you have in a docstring. The current behaviour is not obvious even when reading the code.","commit_id":"e8044373421bdbb9511fef7423e5be003e5905fc"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"8ef39370de8a2d82ddd070f5677b88cf58bd7578","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.vsctl_timeout \u003d cfg.CONF.ovs_vsctl_timeout"},{"line_number":108,"context_line":"        self.ovsdb \u003d ovsdb.API.get(self)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def add_manager(self, connection_uri, timeout\u003d()):"},{"line_number":111,"context_line":"        # if no timeout passed, use cfg, if False, don\u0027t set a timeout"},{"line_number":112,"context_line":"        timeout \u003d timeout if timeout !\u003d () else cfg.CONF.ovs_vsctl_timeout"},{"line_number":113,"context_line":"        with self.ovsdb.transaction() as txn:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_925a4782","line":110,"range":{"start_line":110,"start_character":50,"end_line":110,"end_character":52},"in_reply_to":"9a30ddce_8f94e737","updated":"2017-03-07 22:34:07.000000000","message":"This is actually much clearer when not trying to do a one-liner. :p\n\n if timeout \u003d\u003d _SENTINEL:\n     timeout \u003d cfg.CONF.ovs_vsctl_timeout\n\n ...\n\nself-documenting and everything. No more code golf for me today.","commit_id":"e8044373421bdbb9511fef7423e5be003e5905fc"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"dea0e4ee268806c28c3976e399a57e3f91d3bf70","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.vsctl_timeout \u003d cfg.CONF.ovs_vsctl_timeout"},{"line_number":108,"context_line":"        self.ovsdb \u003d ovsdb.API.get(self)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def add_manager(self, connection_uri, timeout\u003d()):"},{"line_number":111,"context_line":"        # if no timeout passed, use cfg, if False, don\u0027t set a timeout"},{"line_number":112,"context_line":"        timeout \u003d timeout if timeout !\u003d () else cfg.CONF.ovs_vsctl_timeout"},{"line_number":113,"context_line":"        with self.ovsdb.transaction() as txn:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_4491f6ef","line":110,"range":{"start_line":110,"start_character":50,"end_line":110,"end_character":52},"in_reply_to":"9a30ddce_be58fffb","updated":"2017-03-07 19:47:26.000000000","message":"This is just the standard \"use a sentinel value if you want None to be a valid argument\" solution.\n\nI\u0027ll try to make this more acceptable. I didn\u0027t use None just because I wanted it to be available for specifying \"no timeout\" while still defaulting to the ovs_vsctl_timeout value. I could use None and use 0, but I don\u0027t like how that semantically could mean \"don\u0027t wait\" or \"wait forever\". Having set_timeout\u003dTrue doesn\u0027t allow one to set the timeout to an arbitrary value which seemed useful as well. I\u0027ll think about it (though I thought about it quite a bit already). I wish I could just pass the cfg value as the default, but unfortunately that will make it a constant default argument even if the config value is changed.","commit_id":"e8044373421bdbb9511fef7423e5be003e5905fc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9fc4e2008d5f902c2e840587298662f858f26968","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        self.ovsdb \u003d ovsdb.API.get(self)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def add_manager(self, connection_uri, timeout\u003d()):"},{"line_number":111,"context_line":"        # if no timeout passed, use cfg, if False, don\u0027t set a timeout"},{"line_number":112,"context_line":"        timeout \u003d timeout if timeout !\u003d () else cfg.CONF.ovs_vsctl_timeout"},{"line_number":113,"context_line":"        with self.ovsdb.transaction() as txn:"},{"line_number":114,"context_line":"            txn.add(self.ovsdb.add_manager(connection_uri))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_9ebb3bc4","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":70},"updated":"2017-03-07 18:59:16.000000000","message":"that\u0027s rather twisted. I would feel better if we would have a separate argument (set_timeout\u003dTrue). that would be more explicit.","commit_id":"e8044373421bdbb9511fef7423e5be003e5905fc"}],"neutron/agent/ovsdb/native/helpers.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9fc4e2008d5f902c2e840587298662f858f26968","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    api \u003d ovsdb.API.get(OvsdbVsctlContext, \u0027vsctl\u0027)"},{"line_number":37,"context_line":"    with api.transaction() as txn:"},{"line_number":38,"context_line":"        txn.add(api.add_manager(manager_uri))"},{"line_number":39,"context_line":"        if set_timeout:"},{"line_number":40,"context_line":"            timeout \u003d cfg.CONF.ovs_vsctl_timeout * 1000"},{"line_number":41,"context_line":"            txn.add(api.db_set(\u0027Manager\u0027, manager_uri,"},{"line_number":42,"context_line":"                               (\u0027inactivity_probe\u0027, timeout)))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_7e604736","line":42,"range":{"start_line":39,"start_character":8,"end_line":42,"end_character":62},"updated":"2017-03-07 18:59:16.000000000","message":"that seems identical to what we have in add_manager in ovs_lib. Can\u0027t we just pass timeout there in line 38?","commit_id":"e8044373421bdbb9511fef7423e5be003e5905fc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c391725ab976aab9be7f44b4576e1eab6cceff80","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    api \u003d ovsdb.API.get(OvsdbVsctlContext, \u0027vsctl\u0027)"},{"line_number":37,"context_line":"    with api.transaction() as txn:"},{"line_number":38,"context_line":"        txn.add(api.add_manager(manager_uri))"},{"line_number":39,"context_line":"        if set_timeout:"},{"line_number":40,"context_line":"            timeout \u003d cfg.CONF.ovs_vsctl_timeout * 1000"},{"line_number":41,"context_line":"            txn.add(api.db_set(\u0027Manager\u0027, manager_uri,"},{"line_number":42,"context_line":"                               (\u0027inactivity_probe\u0027, timeout)))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_ef3f2323","line":42,"range":{"start_line":39,"start_character":8,"end_line":42,"end_character":62},"in_reply_to":"9a30ddce_2456c2d2","updated":"2017-03-07 20:01:28.000000000","message":"Is it because you will split native impl?","commit_id":"e8044373421bdbb9511fef7423e5be003e5905fc"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"dea0e4ee268806c28c3976e399a57e3f91d3bf70","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    api \u003d ovsdb.API.get(OvsdbVsctlContext, \u0027vsctl\u0027)"},{"line_number":37,"context_line":"    with api.transaction() as txn:"},{"line_number":38,"context_line":"        txn.add(api.add_manager(manager_uri))"},{"line_number":39,"context_line":"        if set_timeout:"},{"line_number":40,"context_line":"            timeout \u003d cfg.CONF.ovs_vsctl_timeout * 1000"},{"line_number":41,"context_line":"            txn.add(api.db_set(\u0027Manager\u0027, manager_uri,"},{"line_number":42,"context_line":"                               (\u0027inactivity_probe\u0027, timeout)))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_2456c2d2","line":42,"range":{"start_line":39,"start_character":8,"end_line":42,"end_character":62},"in_reply_to":"9a30ddce_7e604736","updated":"2017-03-07 19:47:26.000000000","message":"The reason I duplicated is that enable_connection_uri would be used by outside projects, but ovs_lib would not be.","commit_id":"e8044373421bdbb9511fef7423e5be003e5905fc"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"d06a601718a5dbdd85ac3375d619571144e350c7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    api \u003d ovsdb.API.get(OvsdbVsctlContext, \u0027vsctl\u0027)"},{"line_number":37,"context_line":"    with api.transaction() as txn:"},{"line_number":38,"context_line":"        txn.add(api.add_manager(manager_uri))"},{"line_number":39,"context_line":"        if set_timeout:"},{"line_number":40,"context_line":"            timeout \u003d cfg.CONF.ovs_vsctl_timeout * 1000"},{"line_number":41,"context_line":"            txn.add(api.db_set(\u0027Manager\u0027, manager_uri,"},{"line_number":42,"context_line":"                               (\u0027inactivity_probe\u0027, timeout)))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_52ba8fe2","line":42,"range":{"start_line":39,"start_character":8,"end_line":42,"end_character":62},"in_reply_to":"9a30ddce_ef3f2323","updated":"2017-03-07 22:19:28.000000000","message":"It\u0027s just because other projects import from neutron.agent.ovsdb and not neutron.agent.common.ovs_lib. But the division will also be there with the split-out project.","commit_id":"e8044373421bdbb9511fef7423e5be003e5905fc"}]}