)]}'
{"neutron/db/agentschedulers_db.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"6f48d4659de35d60f3ae68eb82b4deccbbe7c4fc","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        else:"},{"line_number":187,"context_line":"            return {\u0027routers\u0027: []}"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def list_sync_routers_on_active_l3_agent("},{"line_number":190,"context_line":"            self, context, host, router_ids, active\u003dNone):"},{"line_number":191,"context_line":"        agent \u003d self._get_agent_by_type_and_host("},{"line_number":192,"context_line":"            context, constants.AGENT_TYPE_L3, host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2F1I8%3D","line":189,"updated":"2013-08-29 02:49:23.000000000","message":"I understand you want to rename this method, but in that case could the correct renaming be list_active_routers_on_l3_agent_for_sync?","commit_id":"3cfa470569d8092f818b8859828c94c5facb1cef"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"96be273020c0c4690ff4c32b1662499192b05efa","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        else:"},{"line_number":187,"context_line":"            return {\u0027routers\u0027: []}"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def list_sync_routers_on_active_l3_agent("},{"line_number":190,"context_line":"            self, context, host, router_ids, active\u003dNone):"},{"line_number":191,"context_line":"        agent \u003d self._get_agent_by_type_and_host("},{"line_number":192,"context_line":"            context, constants.AGENT_TYPE_L3, host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FZIc%3D","line":189,"in_reply_to":"AAAAS3%2F%2Fb9c%3D","updated":"2013-09-27 16:15:01.000000000","message":"I think that active is admin_state_up \u003d\u003d True. I don\u0027t understand active or inactive synching router. The previous name means that routers is set admin_state_up \u003d\u003d True.","commit_id":"3cfa470569d8092f818b8859828c94c5facb1cef"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"3ef85b70b96d96e15149ecd5d4373206ced7d281","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        else:"},{"line_number":187,"context_line":"            return {\u0027routers\u0027: []}"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def list_sync_routers_on_active_l3_agent("},{"line_number":190,"context_line":"            self, context, host, router_ids, active\u003dNone):"},{"line_number":191,"context_line":"        agent \u003d self._get_agent_by_type_and_host("},{"line_number":192,"context_line":"            context, constants.AGENT_TYPE_L3, host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2Fu%2Bk%3D","line":189,"in_reply_to":"AAAASn%2F%2F1I8%3D","updated":"2013-08-30 08:51:06.000000000","message":"I don\u0027t intend to rename so. This method name means that you can get list of all routers on active l3agent.","commit_id":"3cfa470569d8092f818b8859828c94c5facb1cef"},{"author":{"_account_id":5127,"name":"Justin Hammond","email":"runningempty@gmail.com","username":"justin-hammond"},"change_message_id":"aac36d2b423c9ab89107db61876d07ab83f90f0a","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        else:"},{"line_number":187,"context_line":"            return {\u0027routers\u0027: []}"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def list_sync_routers_on_active_l3_agent("},{"line_number":190,"context_line":"            self, context, host, router_ids, active\u003dNone):"},{"line_number":191,"context_line":"        agent \u003d self._get_agent_by_type_and_host("},{"line_number":192,"context_line":"            context, constants.AGENT_TYPE_L3, host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2Fb9c%3D","line":189,"in_reply_to":"AAAASn%2F%2FUFg%3D","updated":"2013-09-26 17:11:30.000000000","message":"What is a sync router? The previous name of active sync routers brings to mind the image of routers that are actively syncing. Is it a active or inactive synching router?","commit_id":"3cfa470569d8092f818b8859828c94c5facb1cef"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"4acb0290c643ba64a790795c44d23f0fcc21f5a6","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        else:"},{"line_number":187,"context_line":"            return {\u0027routers\u0027: []}"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def list_sync_routers_on_active_l3_agent("},{"line_number":190,"context_line":"            self, context, host, router_ids, active\u003dNone):"},{"line_number":191,"context_line":"        agent \u003d self._get_agent_by_type_and_host("},{"line_number":192,"context_line":"            context, constants.AGENT_TYPE_L3, host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2FUFg%3D","line":189,"in_reply_to":"AAAASn%2F%2Fu%2Bk%3D","updated":"2013-09-06 14:31:44.000000000","message":"ok perhaps I have a bad understanding of english","commit_id":"3cfa470569d8092f818b8859828c94c5facb1cef"}],"neutron/db/l3_agentschedulers_db.py":[{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"6071dbd08defdfeafe59ba6c21f4936878314a6a","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            return {\u0027routers\u0027: []}"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def list_active_sync_routers_on_active_l3_agent("},{"line_number":130,"context_line":"            self, context, host, router_ids, active\u003dNone):"},{"line_number":131,"context_line":"        agent \u003d self._get_agent_by_type_and_host("},{"line_number":132,"context_line":"            context, constants.AGENT_TYPE_L3, host)"},{"line_number":133,"context_line":"        if not agent.admin_state_up:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FylU%3D","line":130,"updated":"2014-01-08 12:47:06.000000000","message":"Why adding a new parameter which doesn\u0027t seem to be used ?","commit_id":"f4084c9b89e6b21d4d57e2ea075282b62c5a81b3"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"d4c6aca42c972ce4a1e6fa54e76d568e189d4f92","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            return {\u0027routers\u0027: []}"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def list_active_sync_routers_on_active_l3_agent("},{"line_number":130,"context_line":"            self, context, host, router_ids, active\u003dNone):"},{"line_number":131,"context_line":"        agent \u003d self._get_agent_by_type_and_host("},{"line_number":132,"context_line":"            context, constants.AGENT_TYPE_L3, host)"},{"line_number":133,"context_line":"        if not agent.admin_state_up:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Ft0Q%3D","line":130,"in_reply_to":"AAAAUH%2F%2FylU%3D","updated":"2014-01-09 09:31:24.000000000","message":"This function originally return router list which set admin_state_up True. So adding new parameter(active) that can do so.","commit_id":"f4084c9b89e6b21d4d57e2ea075282b62c5a81b3"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"ae29f06a6b4c71ae0f99e6333e83697d0f159de7","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            return {\u0027routers\u0027: []}"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def list_active_sync_routers_on_active_l3_agent("},{"line_number":130,"context_line":"            self, context, host, router_ids, active\u003dNone):"},{"line_number":131,"context_line":"        agent \u003d self._get_agent_by_type_and_host("},{"line_number":132,"context_line":"            context, constants.AGENT_TYPE_L3, host)"},{"line_number":133,"context_line":"        if not agent.admin_state_up:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FqPQ%3D","line":130,"updated":"2014-01-10 00:10:57.000000000","message":"if we specify active\u003dFalse, this method returns inactive routers.\nso list_active_sync_routers_on_active_l3_agent should be list_sync_routers_on_active_l3_agent","commit_id":"03203100d4f7efd6467a9aeadfa236e8fab03a08"}],"neutron/tests/unit/openvswitch/test_agent_scheduler.py":[{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"ae29f06a6b4c71ae0f99e6333e83697d0f159de7","unresolved":false,"context_lines":[{"line_number":755,"context_line":"            #GET all routers"},{"line_number":756,"context_line":"            ret_a \u003d l3_rpc.sync_routers(self.adminContext, host\u003dL3_HOSTA)"},{"line_number":757,"context_line":"            self.assertEqual(set(router_ids), set([r[\u0027id\u0027] for r in ret_a]))"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"    def test_router_auto_schedule_for_specified_routers(self):"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"        def _sync_router_with_ids(router_ids, exp_synced, exp_hosted, host_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FqPM%3D","line":758,"updated":"2014-01-10 00:10:57.000000000","message":"you should add test cases for active\u003dFalse case and active\u003dTrue case","commit_id":"03203100d4f7efd6467a9aeadfa236e8fab03a08"}],"neutron/tests/unit/test_l3_plugin.py":[{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"6071dbd08defdfeafe59ba6c21f4936878314a6a","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        data \u003d {\u0027router\u0027: {\u0027tenant_id\u0027: tenant_id}}"},{"line_number":336,"context_line":"        if name:"},{"line_number":337,"context_line":"            data[\u0027router\u0027][\u0027name\u0027] \u003d name"},{"line_number":338,"context_line":"        if admin_state_up !\u003d None:"},{"line_number":339,"context_line":"            data[\u0027router\u0027][\u0027admin_state_up\u0027] \u003d admin_state_up"},{"line_number":340,"context_line":"        for arg in ((\u0027admin_state_up\u0027, \u0027tenant_id\u0027) + (arg_list or ())):"},{"line_number":341,"context_line":"            # Arg must be present and not empty"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FylE%3D","line":338,"updated":"2014-01-08 12:47:06.000000000","message":"nit: if admin_state_up is not None:","commit_id":"f4084c9b89e6b21d4d57e2ea075282b62c5a81b3"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"d4c6aca42c972ce4a1e6fa54e76d568e189d4f92","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        data \u003d {\u0027router\u0027: {\u0027tenant_id\u0027: tenant_id}}"},{"line_number":336,"context_line":"        if name:"},{"line_number":337,"context_line":"            data[\u0027router\u0027][\u0027name\u0027] \u003d name"},{"line_number":338,"context_line":"        if admin_state_up !\u003d None:"},{"line_number":339,"context_line":"            data[\u0027router\u0027][\u0027admin_state_up\u0027] \u003d admin_state_up"},{"line_number":340,"context_line":"        for arg in ((\u0027admin_state_up\u0027, \u0027tenant_id\u0027) + (arg_list or ())):"},{"line_number":341,"context_line":"            # Arg must be present and not empty"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Ftxw%3D","line":338,"in_reply_to":"AAAAUH%2F%2FylE%3D","updated":"2014-01-09 09:31:24.000000000","message":"OK. I will modify.","commit_id":"f4084c9b89e6b21d4d57e2ea075282b62c5a81b3"}]}
