)]}'
{"neutron/plugins/ml2/drivers/openvswitch/agent/extension_drivers/qos_driver.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d1c9a5450a66e0ca9dd88fdc1133fe9bfcbae893","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                                                    RULE_TYPE_DSCP_MARKING, 0)"},{"line_number":124,"context_line":"        if dscp_port:"},{"line_number":125,"context_line":"            port_num \u003d dscp_port[\u0027vif_port\u0027].ofport"},{"line_number":126,"context_line":"            self.br_int.uninstall_flows(in_port\u003dport_num, table_id\u003d0, reg2\u003d0)"},{"line_number":127,"context_line":"        else:"},{"line_number":128,"context_line":"            LOG.debug(\"delete_dscp_marking was received for port %s but \""},{"line_number":129,"context_line":"                      \"no port information was stored to be deleted\","}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_213a59ce","line":126,"range":{"start_line":126,"start_character":24,"end_line":126,"end_character":39},"updated":"2017-03-14 17:07:57.000000000","message":"There is a problem with this, depending on the driver used:\n- Native: \"uninstall_flows\" is implemented in https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/ofswitch.py#L102, and uses \"table_id\"\n- OF: \"uninstall_flows\" will call ovs_lib.delete_flows -\u003e do_actions_flows. All parameters will be directly translated to OF CLI rules. In OF, the way to identify a table is \"table\"\n\nIMO, the easiest way to make this change is to modify the native implementation to accept \"table\" instead of \"table_id\"","commit_id":"98371a6c83d1d866b98ac4a8c9c7b8b4686c42c9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e9158b291dd906f311e64da7571cc19ee4b86e70","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                                                    RULE_TYPE_DSCP_MARKING, 0)"},{"line_number":124,"context_line":"        if dscp_port:"},{"line_number":125,"context_line":"            port_num \u003d dscp_port[\u0027vif_port\u0027].ofport"},{"line_number":126,"context_line":"            self.br_int.uninstall_flows(in_port\u003dport_num, table_id\u003d0, reg2\u003d0)"},{"line_number":127,"context_line":"        else:"},{"line_number":128,"context_line":"            LOG.debug(\"delete_dscp_marking was received for port %s but \""},{"line_number":129,"context_line":"                      \"no port information was stored to be deleted\","}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_41daf579","line":126,"updated":"2017-03-14 17:11:53.000000000","message":"indeed CLI driver expects table_id: https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/openflow/ovs_ofctl/ofswitch.py#L31","commit_id":"98371a6c83d1d866b98ac4a8c9c7b8b4686c42c9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"21c0af4ccf14982dc226380d3dbf6a5962e6b2af","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                                                    RULE_TYPE_DSCP_MARKING, 0)"},{"line_number":124,"context_line":"        if dscp_port:"},{"line_number":125,"context_line":"            port_num \u003d dscp_port[\u0027vif_port\u0027].ofport"},{"line_number":126,"context_line":"            self.br_int.uninstall_flows(in_port\u003dport_num, table_id\u003d0, reg2\u003d0)"},{"line_number":127,"context_line":"        else:"},{"line_number":128,"context_line":"            LOG.debug(\"delete_dscp_marking was received for port %s but \""},{"line_number":129,"context_line":"                      \"no port information was stored to be deleted\","}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_01f8fde4","line":126,"range":{"start_line":126,"start_character":24,"end_line":126,"end_character":39},"in_reply_to":"3a1ff146_213a59ce","updated":"2017-03-14 17:11:25.000000000","message":"I didn\u0027t say anything...\n\n_conv_args(kwargs) will convert it.","commit_id":"98371a6c83d1d866b98ac4a8c9c7b8b4686c42c9"}]}