)]}'
{"neutron/agent/linux/iptables_firewall.py":[{"author":{"_account_id":25618,"name":"Paweł Suder","email":"pawel@suder.info","username":"SuderPawel"},"change_message_id":"5cb6c472e56e94d19166cba666091dea5f3c77e6","unresolved":false,"context_lines":[{"line_number":640,"context_line":"        iptables_rules +\u003d [comment_rule(\u0027-m state --state \u0027"},{"line_number":641,"context_line":"                                        \u0027INVALID -j $sg-fallback\u0027,"},{"line_number":642,"context_line":"                                        comment\u003dic.INVALID_DROP)]"},{"line_number":643,"context_line":"        # Always drop invalid packets"},{"line_number":644,"context_line":"        return iptables_rules"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"    def _allow_established(self, iptables_rules):"}],"source_content_type":"text/x-python","patch_set":18,"id":"1f9dbf25_6bcf687f","line":643,"range":{"start_line":643,"start_character":8,"end_line":643,"end_character":37},"updated":"2018-03-01 10:33:53.000000000","message":"I would say that this comment is not relevant.","commit_id":"fe203872828e430a6be058f353ecbc0fd9d937cf"},{"author":{"_account_id":25618,"name":"Paweł Suder","email":"pawel@suder.info","username":"SuderPawel"},"change_message_id":"5cb6c472e56e94d19166cba666091dea5f3c77e6","unresolved":false,"context_lines":[{"line_number":719,"context_line":"        self._add_rules_to_chain_v4v6(SG_CHAIN, jump_rule, jump_rule)"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"        # allow first accept packet"},{"line_number":722,"context_line":"        self.iptables.ipv4[\u0027filter\u0027].add_rule(chain_name, \u0027-j ACCEPT\u0027)"},{"line_number":723,"context_line":"        self.iptables.ipv6[\u0027filter\u0027].add_rule(chain_name, \u0027-j ACCEPT\u0027)"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"1f9dbf25_2b4880ca","line":722,"range":{"start_line":722,"start_character":37,"end_line":722,"end_character":45},"updated":"2018-03-01 10:33:53.000000000","message":"Would you like to add rule at first place? I would say that this `add_rule` does not add rule in first place of chain.\n\nCheck this https://github.com/openstack/neutron/blob/cbee0f9f88ff34f70ff19590471b5405e06ff2a9/neutron/agent/linux/iptables_manager.py#L205-L226","commit_id":"fe203872828e430a6be058f353ecbc0fd9d937cf"},{"author":{"_account_id":25618,"name":"Paweł Suder","email":"pawel@suder.info","username":"SuderPawel"},"change_message_id":"5cb6c472e56e94d19166cba666091dea5f3c77e6","unresolved":false,"context_lines":[{"line_number":720,"context_line":""},{"line_number":721,"context_line":"        # allow first accept packet"},{"line_number":722,"context_line":"        self.iptables.ipv4[\u0027filter\u0027].add_rule(chain_name, \u0027-j ACCEPT\u0027)"},{"line_number":723,"context_line":"        self.iptables.ipv6[\u0027filter\u0027].add_rule(chain_name, \u0027-j ACCEPT\u0027)"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"    def filter_defer_apply_on(self):"}],"source_content_type":"text/x-python","patch_set":18,"id":"1f9dbf25_0b1904d6","line":723,"range":{"start_line":723,"start_character":37,"end_line":723,"end_character":45},"updated":"2018-03-01 10:33:53.000000000","message":"Same here.","commit_id":"fe203872828e430a6be058f353ecbc0fd9d937cf"}],"neutron/services/logapi/drivers/linuxbridge/iptables_log.py":[{"author":{"_account_id":24441,"name":"Cuong Nguyen","email":"cuongnv@vn.fujitsu.com","username":"cuongnv"},"change_message_id":"b0300247877849747ecea26d74a06a6ee163a44d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    IPTABLES_DIRECTION \u003d {firewall.INGRESS_DIRECTION: \u0027physdev-out\u0027,"},{"line_number":115,"context_line":"                          firewall.EGRESS_DIRECTION: \u0027physdev-in\u0027}"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def __int__(self, agent_api):"},{"line_number":118,"context_line":"        self.iptables \u003d agent_api.get_iptables_manager()"},{"line_number":119,"context_line":"        self._deferred \u003d False"},{"line_number":120,"context_line":"        self.log_ports \u003d collections.defaultdict(dict)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3fa0c359_da5b1f1f","line":117,"range":{"start_line":117,"start_character":8,"end_line":117,"end_character":15},"updated":"2018-02-26 09:59:09.000000000","message":"__init__?","commit_id":"57cf8ce14372f45b2aabfb20b9bd15e571fba332"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"fb3939e3b85c7ff72c68adf6ee43d25d09aa37d6","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    IPTABLES_DIRECTION \u003d {firewall.INGRESS_DIRECTION: \u0027physdev-out\u0027,"},{"line_number":115,"context_line":"                          firewall.EGRESS_DIRECTION: \u0027physdev-in\u0027}"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def __int__(self, agent_api):"},{"line_number":118,"context_line":"        self.iptables \u003d agent_api.get_iptables_manager()"},{"line_number":119,"context_line":"        self._deferred \u003d False"},{"line_number":120,"context_line":"        self.log_ports \u003d collections.defaultdict(dict)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3fa0c359_10571bcc","line":117,"range":{"start_line":117,"start_character":8,"end_line":117,"end_character":15},"in_reply_to":"3fa0c359_da5b1f1f","updated":"2018-02-27 00:59:01.000000000","message":"Thanks! Done.","commit_id":"57cf8ce14372f45b2aabfb20b9bd15e571fba332"},{"author":{"_account_id":28174,"name":"Kim Bao Long","email":"longkb@vn.fujitsu.com","username":"longkb.fvl"},"change_message_id":"0d783de33fd1721c799da49a5cb07d2329cf106b","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        log_resources \u003d kwargs.get(\u0027log_resources\u0027)"},{"line_number":237,"context_line":"        if port_id:"},{"line_number":238,"context_line":"            logs_info \u003d self.resource_rpc.get_sg_log_info_for_port("},{"line_number":239,"context_line":"                context, port_id\u003dport_id)"},{"line_number":240,"context_line":"        elif log_resources:"},{"line_number":241,"context_line":"            logs_info \u003d self.resource_rpc.get_sg_log_info_for_log_resources("},{"line_number":242,"context_line":"                context, log_resources\u003dlog_resources)"}],"source_content_type":"text/x-python","patch_set":28,"id":"5f7c97a3_9057dc5a","line":239,"range":{"start_line":239,"start_character":16,"end_line":239,"end_character":41},"updated":"2018-06-26 04:43:55.000000000","message":"In order to match with a generic RPC patch(https://review.openstack.org/#/c/534227/9/neutron/services/logapi/rpc/agent.py@39), we should add resouce_type into rpc calls like:\n\nlogs_info \u003d self.resource_rpc.get_sg_log_info_for_port(\n                context, log_const.SECURITY_GROUP, port_id\u003dport_id)","commit_id":"e224dc8d9cf4ef22aa3d2e637a56fe547a2e233f"},{"author":{"_account_id":28174,"name":"Kim Bao Long","email":"longkb@vn.fujitsu.com","username":"longkb.fvl"},"change_message_id":"0d783de33fd1721c799da49a5cb07d2329cf106b","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                context, port_id\u003dport_id)"},{"line_number":240,"context_line":"        elif log_resources:"},{"line_number":241,"context_line":"            logs_info \u003d self.resource_rpc.get_sg_log_info_for_log_resources("},{"line_number":242,"context_line":"                context, log_resources\u003dlog_resources)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        for log_info in logs_info:"},{"line_number":245,"context_line":"            log_id \u003d log_info[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":28,"id":"5f7c97a3_7050005f","line":242,"range":{"start_line":242,"start_character":16,"end_line":242,"end_character":52},"updated":"2018-06-26 04:43:55.000000000","message":"nit","commit_id":"e224dc8d9cf4ef22aa3d2e637a56fe547a2e233f"}],"neutron/tests/unit/services/logapi/drivers/linuxbridge/test_iptables_log.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"bc48a98b4bf05a233071579648f86b82dcb30b6b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012, Nachi Ueno, NTT MCL, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":28,"id":"5f7c97a3_d6237e05","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":43},"updated":"2018-07-16 04:48:04.000000000","message":"This is right?","commit_id":"e224dc8d9cf4ef22aa3d2e637a56fe547a2e233f"}],"setup.cfg":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"bc48a98b4bf05a233071579648f86b82dcb30b6b","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    fip_qos \u003d neutron.agent.l3.extensions.fip_qos:FipQosAgentExtension"},{"line_number":110,"context_line":"neutron.services.logapi.drivers \u003d"},{"line_number":111,"context_line":"    ovs \u003d neutron.services.logapi.drivers.openvswitch.ovs_firewall_log:OVSFirewallLoggingDriver"},{"line_number":112,"context_line":"    linuxbridge \u003d neutron.services.logapi.drivers.linuxbridge.iptables_log:IptablesLoggingDriver"},{"line_number":113,"context_line":"neutron.qos.agent_drivers \u003d"},{"line_number":114,"context_line":"    ovs \u003d neutron.plugins.ml2.drivers.openvswitch.agent.extension_drivers.qos_driver:QosOVSAgentDriver"},{"line_number":115,"context_line":"    sriov \u003d neutron.plugins.ml2.drivers.mech_sriov.agent.extension_drivers.qos_driver:QosSRIOVAgentDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":28,"id":"5f7c97a3_b63fe220","line":112,"range":{"start_line":112,"start_character":4,"end_line":112,"end_character":15},"updated":"2018-07-16 04:48:04.000000000","message":"Should be `iptables`, because this is based on the iptables functionalities. `linuxbridge` is a little confused to cloud user.","commit_id":"e224dc8d9cf4ef22aa3d2e637a56fe547a2e233f"}]}
