)]}'
{"neutron/conf/agent/l3/config.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5d6ae4cfc1bf6055c8cbf357af3ac5130bca27e7","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                              \"router. If a next-hop using a global unique \""},{"line_number":81,"context_line":"                              \"address (GUA) is desired, it needs to be done \""},{"line_number":82,"context_line":"                              \"via a subnet allocated to the network and not \""},{"line_number":83,"context_line":"                              \"through this parameter. \")),"},{"line_number":84,"context_line":"    cfg.StrOpt(\u0027prefix_delegation_driver\u0027,"},{"line_number":85,"context_line":"               default\u003d\u0027dibbler\u0027,"},{"line_number":86,"context_line":"               help\u003d_(\u0027Driver used for ipv6 prefix delegation. This needs to \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_59c1b32d","line":83,"updated":"2017-03-16 13:51:25.000000000","message":"nit: since you\u0027re changing the line anyways, might as well remove the extra trailing space","commit_id":"002de8a1ae3588d577449ae09a63d2d374e46670"},{"author":{"_account_id":24564,"name":"qtlu","email":"qtlu@fiberhome.com","username":"qtlu"},"change_message_id":"dd89c56ba1d7e723d2e515700705854b39ec741c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                              \"router. If a next-hop using a global unique \""},{"line_number":81,"context_line":"                              \"address (GUA) is desired, it needs to be done \""},{"line_number":82,"context_line":"                              \"via a subnet allocated to the network and not \""},{"line_number":83,"context_line":"                              \"through this parameter. \")),"},{"line_number":84,"context_line":"    cfg.StrOpt(\u0027prefix_delegation_driver\u0027,"},{"line_number":85,"context_line":"               default\u003d\u0027dibbler\u0027,"},{"line_number":86,"context_line":"               help\u003d_(\u0027Driver used for ipv6 prefix delegation. This needs to \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_3e250bab","line":83,"in_reply_to":"3a1ff146_59c1b32d","updated":"2017-03-17 03:07:16.000000000","message":"Done","commit_id":"002de8a1ae3588d577449ae09a63d2d374e46670"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0957ad3d86235f808712ae72c3b89355b1a5c461","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                      \"networks, both the external_network_bridge and \""},{"line_number":63,"context_line":"                      \"gateway_external_network_id must be left empty.\"),"},{"line_number":64,"context_line":"               deprecated_for_removal\u003dTrue),"},{"line_number":65,"context_line":"    cfg.HostAddressOpt(\u0027ipv6_gateway\u0027,"},{"line_number":66,"context_line":"                       help\u003d_(\"With IPv6, the network used for the external \""},{"line_number":67,"context_line":"                              \"gateway does not need to have an associated \""},{"line_number":68,"context_line":"                              \"subnet, since the automatically assigned \""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_21fa3e43","line":65,"updated":"2017-03-17 14:38:58.000000000","message":"Since this must be an IPv6 address, you should specify a version:\n\nversion\u003dconstants.IP_VERSION_6","commit_id":"1316aa4fecd2a9191095603ada945540b440ea49"},{"author":{"_account_id":24564,"name":"qtlu","email":"qtlu@fiberhome.com","username":"qtlu"},"change_message_id":"012dab9529a769a13cb988b06ce632e23105e4f3","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                      \"networks, both the external_network_bridge and \""},{"line_number":63,"context_line":"                      \"gateway_external_network_id must be left empty.\"),"},{"line_number":64,"context_line":"               deprecated_for_removal\u003dTrue),"},{"line_number":65,"context_line":"    cfg.HostAddressOpt(\u0027ipv6_gateway\u0027,"},{"line_number":66,"context_line":"                       help\u003d_(\"With IPv6, the network used for the external \""},{"line_number":67,"context_line":"                              \"gateway does not need to have an associated \""},{"line_number":68,"context_line":"                              \"subnet, since the automatically assigned \""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_5688c722","line":65,"in_reply_to":"1a1ced50_21fa3e43","updated":"2017-03-18 06:38:32.000000000","message":"Done","commit_id":"1316aa4fecd2a9191095603ada945540b440ea49"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"24a184b12389d8eb271f56a2f7e21dba5cd71bd8","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                      \"networks, both the external_network_bridge and \""},{"line_number":63,"context_line":"                      \"gateway_external_network_id must be left empty.\"),"},{"line_number":64,"context_line":"               deprecated_for_removal\u003dTrue),"},{"line_number":65,"context_line":"    cfg.StrOpt(\u0027ipv6_gateway\u0027, default\u003d\u0027\u0027,"},{"line_number":66,"context_line":"               help\u003d_(\"With IPv6, the network used for the external gateway \""},{"line_number":67,"context_line":"                      \"does not need to have an associated subnet, since the \""},{"line_number":68,"context_line":"                      \"automatically assigned link-local address (LLA) can \""}],"source_content_type":"text/x-python","patch_set":5,"id":"ffe62b97_9edd3c16","side":"PARENT","line":65,"range":{"start_line":65,"start_character":30,"end_line":65,"end_character":41},"updated":"2017-03-27 08:48:40.000000000","message":"The original config option had a \"deafult\" value. Shouldn\u0027t you set the same default value in the refactored paramater?","commit_id":"cd947ac4d05a5301fb3bf704b0dd1ca39fd7e541"},{"author":{"_account_id":19999,"name":"Trinath Somanchi","email":"trinaths.dev@gmail.com","username":"trinath-somanchi"},"change_message_id":"65ea6d014d03f4861076aaa6dd05e0c5a247a18d","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                      \"networks, both the external_network_bridge and \""},{"line_number":63,"context_line":"                      \"gateway_external_network_id must be left empty.\"),"},{"line_number":64,"context_line":"               deprecated_for_removal\u003dTrue),"},{"line_number":65,"context_line":"    cfg.StrOpt(\u0027ipv6_gateway\u0027, default\u003d\u0027\u0027,"},{"line_number":66,"context_line":"               help\u003d_(\"With IPv6, the network used for the external gateway \""},{"line_number":67,"context_line":"                      \"does not need to have an associated subnet, since the \""},{"line_number":68,"context_line":"                      \"automatically assigned link-local address (LLA) can \""}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_aa21fcb6","side":"PARENT","line":65,"range":{"start_line":65,"start_character":30,"end_line":65,"end_character":41},"in_reply_to":"ffe62b97_9edd3c16","updated":"2017-04-01 11:33:46.000000000","message":"Agreed! But the change itself looks good.","commit_id":"cd947ac4d05a5301fb3bf704b0dd1ca39fd7e541"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"51e8743dc38689fc5f12b01d34fcb23b460f8a52","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                      \"networks, both the external_network_bridge and \""},{"line_number":63,"context_line":"                      \"gateway_external_network_id must be left empty.\"),"},{"line_number":64,"context_line":"               deprecated_for_removal\u003dTrue),"},{"line_number":65,"context_line":"    cfg.HostAddressOpt(\u0027ipv6_gateway\u0027,"},{"line_number":66,"context_line":"                       version\u003dconstants.IP_VERSION_6,"},{"line_number":67,"context_line":"                       help\u003d_(\"With IPv6, the network used for the external \""},{"line_number":68,"context_line":"                              \"gateway does not need to have an associated \""}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_59edab89","line":65,"updated":"2017-04-02 02:03:50.000000000","message":"What is the new default? None?","commit_id":"6f34bc5023cd0370b62928ce18a217b816a6a6b7"},{"author":{"_account_id":24564,"name":"qtlu","email":"qtlu@fiberhome.com","username":"qtlu"},"change_message_id":"0944e52efe934fbbd2b60e2c481b537208d4b1e5","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                      \"networks, both the external_network_bridge and \""},{"line_number":63,"context_line":"                      \"gateway_external_network_id must be left empty.\"),"},{"line_number":64,"context_line":"               deprecated_for_removal\u003dTrue),"},{"line_number":65,"context_line":"    cfg.HostAddressOpt(\u0027ipv6_gateway\u0027,"},{"line_number":66,"context_line":"                       version\u003dconstants.IP_VERSION_6,"},{"line_number":67,"context_line":"                       help\u003d_(\"With IPv6, the network used for the external \""},{"line_number":68,"context_line":"                              \"gateway does not need to have an associated \""}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_9cfbc645","line":65,"in_reply_to":"dfeb2761_59edab89","updated":"2017-04-05 02:29:52.000000000","message":"There is no default value, because None or \u0027\u0027 are both invalid ip address or hostname. So what value should we set for it, a link local address or other?","commit_id":"6f34bc5023cd0370b62928ce18a217b816a6a6b7"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"94db47f9f191b157fb64e38e2f5411c86ac2ec27","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                              \"subnet, since the automatically assigned \""},{"line_number":70,"context_line":"                              \"link-local address (LLA) can be used. However, \""},{"line_number":71,"context_line":"                              \"an IPv6 gateway address is needed for use as \""},{"line_number":72,"context_line":"                              \"the next-hop for the default route. If no IPv6 \""},{"line_number":73,"context_line":"                              \"gateway address is configured here, (and only \""},{"line_number":74,"context_line":"                              \"then) the neutron router will be configured to \""},{"line_number":75,"context_line":"                              \"get its default route from router \""}],"source_content_type":"text/x-python","patch_set":6,"id":"7ffa3b31_ab735580","line":72,"updated":"2017-04-16 01:15:02.000000000","message":"Following up comment on previous PS, you mentioned that there is now no default. If so, then this is a backward incompatible change and this help text is wrong because it says \"If no IPv6 gateway is configured\", which is not possible if this doesn\u0027t default to something.","commit_id":"e2692c94b3350a92fa9d0fbe352ad89642b7c04f"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"cbe27620c372c806dee07527083a8bd29ee15f5f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                              \"subnet, since the automatically assigned \""},{"line_number":65,"context_line":"                              \"link-local address (LLA) can be used. However, \""},{"line_number":66,"context_line":"                              \"an IPv6 gateway address is needed for use as \""},{"line_number":67,"context_line":"                              \"the next-hop for the default route. If no IPv6 \""},{"line_number":68,"context_line":"                              \"gateway address is configured here, (and only \""},{"line_number":69,"context_line":"                              \"then) the neutron router will be configured to \""},{"line_number":70,"context_line":"                              \"get its default route from router \""},{"line_number":71,"context_line":"                              \"advertisements (RAs) from the upstream router; \""},{"line_number":72,"context_line":"                              \"in which case the upstream router must also be \""},{"line_number":73,"context_line":"                              \"configured to send these RAs. \""}],"source_content_type":"text/x-python","patch_set":7,"id":"7ffa3b31_82b01a45","line":70,"range":{"start_line":67,"start_character":67,"end_line":70,"end_character":66},"updated":"2017-04-19 15:54:10.000000000","message":"comment in previous PS still unaddressed.","commit_id":"50c46527d951121576e337041ecccd16cf95e9d0"},{"author":{"_account_id":24564,"name":"qtlu","email":"qtlu@fiberhome.com","username":"qtlu"},"change_message_id":"157834606b91ce8e6da2a905078b392f4af9f5c6","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                              \"subnet, since the automatically assigned \""},{"line_number":65,"context_line":"                              \"link-local address (LLA) can be used. However, \""},{"line_number":66,"context_line":"                              \"an IPv6 gateway address is needed for use as \""},{"line_number":67,"context_line":"                              \"the next-hop for the default route. If no IPv6 \""},{"line_number":68,"context_line":"                              \"gateway address is configured here, (and only \""},{"line_number":69,"context_line":"                              \"then) the neutron router will be configured to \""},{"line_number":70,"context_line":"                              \"get its default route from router \""},{"line_number":71,"context_line":"                              \"advertisements (RAs) from the upstream router; \""},{"line_number":72,"context_line":"                              \"in which case the upstream router must also be \""},{"line_number":73,"context_line":"                              \"configured to send these RAs. \""}],"source_content_type":"text/x-python","patch_set":7,"id":"7ffa3b31_02207c9a","line":70,"range":{"start_line":67,"start_character":67,"end_line":70,"end_character":66},"in_reply_to":"7ffa3b31_82b01a45","updated":"2017-04-20 01:34:13.000000000","message":"Hi, Manjeet\nThanks for your review, in order to avoid backward incompatible problem, i have no changed with the `ipv6_gateway` config option","commit_id":"50c46527d951121576e337041ecccd16cf95e9d0"}],"neutron/conf/agent/metadata/config.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3e098ed7467d7371dbf92ac0af2628cc7e7d7eb5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    cfg.StrOpt(\u0027auth_ca_cert\u0027,"},{"line_number":45,"context_line":"               help\u003d_(\"Certificate Authority public key (CA cert) \""},{"line_number":46,"context_line":"                      \"file for ssl\")),"},{"line_number":47,"context_line":"    cfg.HostAddressOpt(\u0027nova_metadata_host\u0027,"},{"line_number":48,"context_line":"                       default\u003d\u0027127.0.0.1\u0027,"},{"line_number":49,"context_line":"                       deprecated_name\u003d\u0027nova_metadata_ip\u0027,"},{"line_number":50,"context_line":"                       help\u003d_(\"IP address or DNS name of Nova metadata \""}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_b6e0e227","line":47,"updated":"2017-04-05 07:33:58.000000000","message":"i am not sure about this - i think that this should still be an IP address. Do we have a use case where this is ever a hostname?","commit_id":"6f34bc5023cd0370b62928ce18a217b816a6a6b7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"33c7791657b390c73f75e8616410d59dd0d542b2","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    cfg.StrOpt(\u0027auth_ca_cert\u0027,"},{"line_number":45,"context_line":"               help\u003d_(\"Certificate Authority public key (CA cert) \""},{"line_number":46,"context_line":"                      \"file for ssl\")),"},{"line_number":47,"context_line":"    cfg.HostAddressOpt(\u0027nova_metadata_host\u0027,"},{"line_number":48,"context_line":"                       default\u003d\u0027127.0.0.1\u0027,"},{"line_number":49,"context_line":"                       deprecated_name\u003d\u0027nova_metadata_ip\u0027,"},{"line_number":50,"context_line":"                       help\u003d_(\"IP address or DNS name of Nova metadata \""}],"source_content_type":"text/x-python","patch_set":5,"id":"bff0334d_66d6ca52","line":47,"in_reply_to":"dfeb2761_b6e0e227","updated":"2017-04-05 13:42:02.000000000","message":"This can be either an IP address or hostname, the name was changed from nova_metadata_ip in Ocata to reflect that, commit 366dd7cc37c053e0fff897b16414c960243abcfc","commit_id":"6f34bc5023cd0370b62928ce18a217b816a6a6b7"}],"neutron/conf/common.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5d6ae4cfc1bf6055c8cbf357af3ac5130bca27e7","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"core_opts \u003d ["},{"line_number":25,"context_line":"    cfg.HostAddressOpt(\u0027bind_host\u0027, default\u003d\u00270.0.0.0\u0027,"},{"line_number":26,"context_line":"                       help\u003d_(\"The host IP to bind to\")),"},{"line_number":27,"context_line":"    cfg.PortOpt(\u0027bind_port\u0027, default\u003d9696,"},{"line_number":28,"context_line":"                help\u003d_(\"The port to bind to\")),"},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027api_extensions_path\u0027, default\u003d\"\","}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_59d8d31d","line":26,"updated":"2017-03-16 13:51:25.000000000","message":"nit: can you add a trailing period since you\u0027re changing the line?","commit_id":"002de8a1ae3588d577449ae09a63d2d374e46670"},{"author":{"_account_id":24564,"name":"qtlu","email":"qtlu@fiberhome.com","username":"qtlu"},"change_message_id":"dd89c56ba1d7e723d2e515700705854b39ec741c","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"core_opts \u003d ["},{"line_number":25,"context_line":"    cfg.HostAddressOpt(\u0027bind_host\u0027, default\u003d\u00270.0.0.0\u0027,"},{"line_number":26,"context_line":"                       help\u003d_(\"The host IP to bind to\")),"},{"line_number":27,"context_line":"    cfg.PortOpt(\u0027bind_port\u0027, default\u003d9696,"},{"line_number":28,"context_line":"                help\u003d_(\"The port to bind to\")),"},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027api_extensions_path\u0027, default\u003d\"\","}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_9e343fdf","line":26,"in_reply_to":"3a1ff146_59d8d31d","updated":"2017-03-17 03:07:16.000000000","message":"Done","commit_id":"002de8a1ae3588d577449ae09a63d2d374e46670"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0957ad3d86235f808712ae72c3b89355b1a5c461","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    cfg.IntOpt(\u0027send_events_interval\u0027, default\u003d2,"},{"line_number":111,"context_line":"               help\u003d_(\u0027Number of seconds between sending events to nova if \u0027"},{"line_number":112,"context_line":"                      \u0027there are any events to send.\u0027)),"},{"line_number":113,"context_line":"    cfg.HostAddressOpt(\u0027ipam_driver\u0027, default\u003d\u0027internal\u0027,"},{"line_number":114,"context_line":"                       help\u003d_(\"Neutron IPAM (IP address management) driver \""},{"line_number":115,"context_line":"                              \"to use. By default, the reference \""},{"line_number":116,"context_line":"                              \"implementation of the Neutron IPAM driver is \""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_014aa2c5","line":113,"updated":"2017-03-17 14:38:58.000000000","message":"This value is a string, and not an IP address.","commit_id":"1316aa4fecd2a9191095603ada945540b440ea49"},{"author":{"_account_id":24564,"name":"qtlu","email":"qtlu@fiberhome.com","username":"qtlu"},"change_message_id":"012dab9529a769a13cb988b06ce632e23105e4f3","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    cfg.IntOpt(\u0027send_events_interval\u0027, default\u003d2,"},{"line_number":111,"context_line":"               help\u003d_(\u0027Number of seconds between sending events to nova if \u0027"},{"line_number":112,"context_line":"                      \u0027there are any events to send.\u0027)),"},{"line_number":113,"context_line":"    cfg.HostAddressOpt(\u0027ipam_driver\u0027, default\u003d\u0027internal\u0027,"},{"line_number":114,"context_line":"                       help\u003d_(\"Neutron IPAM (IP address management) driver \""},{"line_number":115,"context_line":"                              \"to use. By default, the reference \""},{"line_number":116,"context_line":"                              \"implementation of the Neutron IPAM driver is \""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_768dc330","line":113,"in_reply_to":"1a1ced50_014aa2c5","updated":"2017-03-18 06:38:32.000000000","message":"Done","commit_id":"1316aa4fecd2a9191095603ada945540b440ea49"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3e098ed7467d7371dbf92ac0af2628cc7e7d7eb5","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"core_opts \u003d ["},{"line_number":25,"context_line":"    cfg.HostAddressOpt(\u0027bind_host\u0027, default\u003d\u00270.0.0.0\u0027,"},{"line_number":26,"context_line":"                       help\u003d_(\"The host IP to bind to.\")),"},{"line_number":27,"context_line":"    cfg.PortOpt(\u0027bind_port\u0027, default\u003d9696,"},{"line_number":28,"context_line":"                help\u003d_(\"The port to bind to\")),"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_96d39e60","line":25,"updated":"2017-04-05 07:33:58.000000000","message":"same comment here","commit_id":"6f34bc5023cd0370b62928ce18a217b816a6a6b7"}],"neutron/conf/plugins/ml2/drivers/linuxbridge.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f283bd2e239b133855e92bd6f8b3e284fba53788","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                      \"To reserve a unique group for each possible \""},{"line_number":41,"context_line":"                      \"(24-bit) VNI, use a /8 such as 239.0.0.0/8. This \""},{"line_number":42,"context_line":"                      \"setting must be the same on all the agents.\")),"},{"line_number":43,"context_line":"    cfg.HostAddressOpt(\u0027local_ip\u0027,"},{"line_number":44,"context_line":"                       help\u003d_(\"IP address of local overlay (tunnel) network \""},{"line_number":45,"context_line":"                              \"endpoint. Use either an IPv4 or IPv6 address \""},{"line_number":46,"context_line":"                              \"that resides on one of the host network \""}],"source_content_type":"text/x-python","patch_set":8,"id":"7ffa3b31_d2749838","line":43,"updated":"2017-04-20 11:14:55.000000000","message":"see comment in ovs_conf, same applies here","commit_id":"96eb6a6ddfe1e043274f989fa9dc66a836e6e8ad"}],"neutron/conf/plugins/ml2/drivers/ovs_conf.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f283bd2e239b133855e92bd6f8b3e284fba53788","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    cfg.StrOpt(\u0027tun_peer_patch_port\u0027, default\u003d\u0027patch-int\u0027,"},{"line_number":42,"context_line":"               help\u003d_(\"Peer patch port in tunnel bridge for integration \""},{"line_number":43,"context_line":"                      \"bridge.\")),"},{"line_number":44,"context_line":"    cfg.HostAddressOpt(\u0027local_ip\u0027,"},{"line_number":45,"context_line":"                       help\u003d_(\"IP address of local overlay (tunnel) network \""},{"line_number":46,"context_line":"                              \"endpoint. Use either an IPv4 or IPv6 address \""},{"line_number":47,"context_line":"                              \"that resides on one of the host network \""}],"source_content_type":"text/x-python","patch_set":8,"id":"7ffa3b31_127fa015","line":44,"updated":"2017-04-20 11:14:55.000000000","message":"We can\u0027t allow host addresses here because we have calls like\n \u0027if (netaddr.IPAddress(self.local_ip).version\u0027 which will fail if there is a hostname in there.","commit_id":"96eb6a6ddfe1e043274f989fa9dc66a836e6e8ad"},{"author":{"_account_id":24564,"name":"qtlu","email":"qtlu@fiberhome.com","username":"qtlu"},"change_message_id":"643ab2d09fb9b085466d4a2440bb343a703bb7ab","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    cfg.StrOpt(\u0027tun_peer_patch_port\u0027, default\u003d\u0027patch-int\u0027,"},{"line_number":42,"context_line":"               help\u003d_(\"Peer patch port in tunnel bridge for integration \""},{"line_number":43,"context_line":"                      \"bridge.\")),"},{"line_number":44,"context_line":"    cfg.HostAddressOpt(\u0027local_ip\u0027,"},{"line_number":45,"context_line":"                       help\u003d_(\"IP address of local overlay (tunnel) network \""},{"line_number":46,"context_line":"                              \"endpoint. Use either an IPv4 or IPv6 address \""},{"line_number":47,"context_line":"                              \"that resides on one of the host network \""}],"source_content_type":"text/x-python","patch_set":8,"id":"7ffa3b31_15de6a6c","line":44,"in_reply_to":"7ffa3b31_127fa015","updated":"2017-04-20 11:29:58.000000000","message":"Got it, thanks","commit_id":"96eb6a6ddfe1e043274f989fa9dc66a836e6e8ad"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f283bd2e239b133855e92bd6f8b3e284fba53788","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                      \"userspace datapath set this value to \u0027netdev\u0027.\")),"},{"line_number":82,"context_line":"    cfg.StrOpt(\u0027vhostuser_socket_dir\u0027, default\u003dconstants.VHOST_USER_SOCKET_DIR,"},{"line_number":83,"context_line":"               help\u003d_(\"OVS vhost-user socket directory.\")),"},{"line_number":84,"context_line":"    cfg.HostAddressOpt(\u0027of_listen_address\u0027, default\u003d\u0027127.0.0.1\u0027,"},{"line_number":85,"context_line":"                       help\u003d_(\"Address to listen on for OpenFlow connections. \""},{"line_number":86,"context_line":"                              \"Used only for \u0027native\u0027 driver.\")),"},{"line_number":87,"context_line":"    cfg.PortOpt(\u0027of_listen_port\u0027, default\u003d6633,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7ffa3b31_f27b1425","line":84,"updated":"2017-04-20 11:14:55.000000000","message":"it\u0027s not clear that OVS can be configured with a hostname as a listen address, can you confirm this? Otherwise we are allowing operators to pass something that might just crash the vswitch.","commit_id":"96eb6a6ddfe1e043274f989fa9dc66a836e6e8ad"}]}
