)]}'
{"neutron/plugins/ml2/drivers/mech_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1fc82f9c8df4b4d45d2cd6d8f755fcf2e292dbcb","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        else:"},{"line_number":176,"context_line":"            return False"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def get_vif_type(self, context, agent, segment):"},{"line_number":179,"context_line":"        \"\"\"Return the vif type appropriate for the agent and segment.\"\"\""},{"line_number":180,"context_line":"        return self.vif_type"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_d5fe4bad","line":178,"updated":"2017-05-17 16:21:06.000000000","message":"In the OVS mech driver there is:\n\n    def get_vif_type(self, agent, context):\n\nwhich is a sub-class, seems this definition should change to be consistent, and that should take an additional arg even if unused?","commit_id":"02f5f3de94ab6156c3a45a76b743d0729c1dcc60"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"adb5160f485baa38881944470edad98bd5b30459","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        else:"},{"line_number":176,"context_line":"            return False"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def get_vif_type(self, context, agent, segment):"},{"line_number":179,"context_line":"        \"\"\"Return the vif type appropriate for the agent and segment.\"\"\""},{"line_number":180,"context_line":"        return self.vif_type"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_6218d880","line":178,"in_reply_to":"ff0f0b1f_d5fe4bad","updated":"2017-05-17 22:50:55.000000000","message":"Done, moved the refactor to a parent patch.","commit_id":"02f5f3de94ab6156c3a45a76b743d0729c1dcc60"}]}
