)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c5c549563b65bc9d68e6ff58ff085ab932f585c8","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Also Fix the unit test that was testing for this, so that"},{"line_number":13,"context_line":"it checks the IP for the new updated port (it was checking"},{"line_number":14,"context_line":"the port befor the update)."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I0a83efa7b8dfa1f6979566846195fb349547018a"},{"line_number":17,"context_line":"Closes-Bug: #1671548"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bff0334d_9c686bb9","line":14,"range":{"start_line":14,"start_character":9,"end_line":14,"end_character":14},"updated":"2017-04-10 12:06:15.000000000","message":"before","commit_id":"19430e2d6eed9c6eb1cc2666f33c386fd60615fc"}],"neutron/db/ipam_backend_mixin.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5ac14954272a22ccca432f70fdf1d48a30534e18","unresolved":false,"context_lines":[{"line_number":757,"context_line":"                    new_fixed_ips.append({})"},{"line_number":758,"context_line":"                    new_fixed_ips[-1][\u0027subnet_id\u0027] \u003d old_ip[\u0027subnet_id\u0027]"},{"line_number":759,"context_line":"                    new_fixed_ips[-1][\u0027delete_subnet\u0027] \u003d True"},{"line_number":760,"context_line":"                    need_eui64 \u003d True"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"        changes \u003d self.update_port_with_ips(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_db7832c7","line":760,"updated":"2017-03-20 17:46:25.000000000","message":"This type of logic seems like it should be in update_port_with_ips() or it\u0027s callee, _update_ips_for_port(), as it doesn\u0027t check the mac of the new and old ports have changed.","commit_id":"3f75ccfbc2f25a3f871be2f1d9f422232bbf6624"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"11328352d70163ec8b558a5ce0744b2ba7b7c49d","unresolved":false,"context_lines":[{"line_number":757,"context_line":"                    new_fixed_ips.append({})"},{"line_number":758,"context_line":"                    new_fixed_ips[-1][\u0027subnet_id\u0027] \u003d old_ip[\u0027subnet_id\u0027]"},{"line_number":759,"context_line":"                    new_fixed_ips[-1][\u0027delete_subnet\u0027] \u003d True"},{"line_number":760,"context_line":"                    need_eui64 \u003d True"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"        changes \u003d self.update_port_with_ips(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_b69384a3","line":760,"in_reply_to":"1a1ced50_db7832c7","updated":"2017-03-27 09:42:52.000000000","message":"The main reason I put it here is because (as far as I could see) the logic to assign a stateless IP was at the bottom of this method. Maybe I missed something, if you have any suggestions I\u0027d be happy to follow up on them.","commit_id":"3f75ccfbc2f25a3f871be2f1d9f422232bbf6624"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7ee0455ea930c9d17b37e1778b453dd87e6def6f","unresolved":false,"context_lines":[{"line_number":757,"context_line":"                    new_fixed_ips.append({})"},{"line_number":758,"context_line":"                    new_fixed_ips[-1][\u0027subnet_id\u0027] \u003d old_ip[\u0027subnet_id\u0027]"},{"line_number":759,"context_line":"                    new_fixed_ips[-1][\u0027delete_subnet\u0027] \u003d True"},{"line_number":760,"context_line":"                    need_eui64 \u003d True"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"        changes \u003d self.update_port_with_ips(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_56f1d86a","line":760,"in_reply_to":"ffe62b97_b69384a3","updated":"2017-03-27 09:56:38.000000000","message":"I agree with Brian to move this code to \"update_port_with_ips\" because this function was designed for this purpose, to set (and now to calculate) the IPs for a port.","commit_id":"3f75ccfbc2f25a3f871be2f1d9f422232bbf6624"}],"neutron/db/ipam_pluggable_backend.py":[{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"f46758e9619dd5723c05de9a67c2906b48aae75e","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                    if ipv6_utils.is_eui64_address(old_ip.get(\u0027ip_address\u0027)):"},{"line_number":326,"context_line":"                        assign_auto \u003d True"},{"line_number":327,"context_line":"                        new_fixed_ips \u003d new_port.setdefault(\u0027fixed_ips\u0027, [])"},{"line_number":328,"context_line":"                        new_fixed_ips.append({})"},{"line_number":329,"context_line":"                        new_fixed_ips[-1][\u0027subnet_id\u0027] \u003d old_ip[\u0027subnet_id\u0027]"},{"line_number":330,"context_line":"                        new_fixed_ips[-1][\u0027delete_subnet\u0027] \u003d True"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        if \u0027fixed_ips\u0027 in new_port:"},{"line_number":333,"context_line":"            original \u003d self._make_port_dict(db_port,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_8ebb18c3","line":330,"range":{"start_line":328,"start_character":24,"end_line":330,"end_character":65},"updated":"2017-03-30 14:24:52.000000000","message":"new_port[\u0027fixed_ips\u0027] is never set to new_fixed_ips, so this doesn\u0027t appear to be doing anything. Also, I would suggest building the dict before appending it for readability.","commit_id":"68aae786841b810e17f9d94fb0045d353bba9f18"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"dbcb77140bd09b4641fd910ed8f70748d14582f1","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                    if ipv6_utils.is_eui64_address(old_ip.get(\u0027ip_address\u0027)):"},{"line_number":326,"context_line":"                        assign_auto \u003d True"},{"line_number":327,"context_line":"                        new_fixed_ips \u003d new_port.setdefault(\u0027fixed_ips\u0027, [])"},{"line_number":328,"context_line":"                        new_fixed_ips.append({})"},{"line_number":329,"context_line":"                        new_fixed_ips[-1][\u0027subnet_id\u0027] \u003d old_ip[\u0027subnet_id\u0027]"},{"line_number":330,"context_line":"                        new_fixed_ips[-1][\u0027delete_subnet\u0027] \u003d True"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        if \u0027fixed_ips\u0027 in new_port:"},{"line_number":333,"context_line":"            original \u003d self._make_port_dict(db_port,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_13ca01a0","line":330,"range":{"start_line":328,"start_character":24,"end_line":330,"end_character":65},"in_reply_to":"dfeb2761_666d5103","updated":"2017-04-10 15:30:46.000000000","message":"Huh, TIL about that property of setdefault. Thanks.","commit_id":"68aae786841b810e17f9d94fb0045d353bba9f18"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"c884ee1ad660ee2a7d72994e01cf1b6fafc549d4","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                    if ipv6_utils.is_eui64_address(old_ip.get(\u0027ip_address\u0027)):"},{"line_number":326,"context_line":"                        assign_auto \u003d True"},{"line_number":327,"context_line":"                        new_fixed_ips \u003d new_port.setdefault(\u0027fixed_ips\u0027, [])"},{"line_number":328,"context_line":"                        new_fixed_ips.append({})"},{"line_number":329,"context_line":"                        new_fixed_ips[-1][\u0027subnet_id\u0027] \u003d old_ip[\u0027subnet_id\u0027]"},{"line_number":330,"context_line":"                        new_fixed_ips[-1][\u0027delete_subnet\u0027] \u003d True"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        if \u0027fixed_ips\u0027 in new_port:"},{"line_number":333,"context_line":"            original \u003d self._make_port_dict(db_port,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_666d5103","line":330,"range":{"start_line":328,"start_character":24,"end_line":330,"end_character":65},"in_reply_to":"ffe62b97_8ebb18c3","updated":"2017-04-03 13:52:10.000000000","message":"now building the dict before appending. new_port[\u0027fixed_ips\u0027] is new_fixed_ips which contains a single dict entry.","commit_id":"68aae786841b810e17f9d94fb0045d353bba9f18"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c5c549563b65bc9d68e6ff58ff085ab932f585c8","unresolved":false,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        assign_auto \u003d False"},{"line_number":320,"context_line":"        if new_mac:"},{"line_number":321,"context_line":"            original \u003d self._make_port_dict(db_port, process_extensions\u003dFalse)"},{"line_number":322,"context_line":"            if original.get(\u0027mac_address\u0027) !\u003d new_mac:"},{"line_number":323,"context_line":"                for old_ip in original.get(\u0027fixed_ips\u0027, []):"},{"line_number":324,"context_line":"                    if ipv6_utils.is_eui64_address(old_ip.get(\u0027ip_address\u0027)):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_5102cc0c","line":321,"updated":"2017-04-10 12:06:15.000000000","message":"nit - not really important - but maybe consider moving this out of the if here - its called below if the fixed_ips is also updated.\nSo it may save a few cycles","commit_id":"19430e2d6eed9c6eb1cc2666f33c386fd60615fc"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"b35e0882a0fef6c7bc9238bd6c628a68ad813c6e","unresolved":false,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        assign_auto \u003d False"},{"line_number":320,"context_line":"        if new_mac:"},{"line_number":321,"context_line":"            original \u003d self._make_port_dict(db_port, process_extensions\u003dFalse)"},{"line_number":322,"context_line":"            if original.get(\u0027mac_address\u0027) !\u003d new_mac:"},{"line_number":323,"context_line":"                for old_ip in original.get(\u0027fixed_ips\u0027, []):"},{"line_number":324,"context_line":"                    if ipv6_utils.is_eui64_address(old_ip.get(\u0027ip_address\u0027)):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_5b02c670","line":321,"in_reply_to":"bff0334d_5102cc0c","updated":"2017-04-11 09:44:01.000000000","message":"I think I figured it didn\u0027t need to be called in cases where neither the MAC or fixed IPs was being updated and it was unlikely both would be getting changed together. I\u0027m happy to move it out though if its likely it would be called twice.","commit_id":"19430e2d6eed9c6eb1cc2666f33c386fd60615fc"}],"neutron/tests/unit/db/test_db_base_plugin_v2.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"e09c3f7594ffd72eabc83da8353bffa7d3ded009","unresolved":false,"context_lines":[{"line_number":1385,"context_line":"                self.assertIn(\u0027port\u0027, result)"},{"line_number":1386,"context_line":"                self.assertEqual(new_mac, result[\u0027port\u0027][\u0027mac_address\u0027])"},{"line_number":1387,"context_line":"                if subnet and subnet[\u0027subnet\u0027][\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":1388,"context_line":"                    self._check_v6_auto_address_address(result, subnet)"},{"line_number":1389,"context_line":"            else:"},{"line_number":1390,"context_line":"                error \u003d self.deserialize(self.fmt, res)"},{"line_number":1391,"context_line":"                self.assertEqual(expected_error,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_4840bea5","line":1388,"updated":"2017-04-11 09:16:36.000000000","message":"This patch also adds a code to delete old_ip so we should add the check here.","commit_id":"19430e2d6eed9c6eb1cc2666f33c386fd60615fc"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"f77bcf7d60127e6ecf73fd88a6103a23fa4ae53f","unresolved":false,"context_lines":[{"line_number":1385,"context_line":"                self.assertIn(\u0027port\u0027, result)"},{"line_number":1386,"context_line":"                self.assertEqual(new_mac, result[\u0027port\u0027][\u0027mac_address\u0027])"},{"line_number":1387,"context_line":"                if subnet and subnet[\u0027subnet\u0027][\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":1388,"context_line":"                    self._check_v6_auto_address_address(result, subnet)"},{"line_number":1389,"context_line":"            else:"},{"line_number":1390,"context_line":"                error \u003d self.deserialize(self.fmt, res)"},{"line_number":1391,"context_line":"                self.assertEqual(expected_error,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_7bceaa2d","line":1388,"in_reply_to":"bff0334d_4840bea5","updated":"2017-04-11 09:49:54.000000000","message":"Now checking the length of fixed_ips in the _check.. method","commit_id":"19430e2d6eed9c6eb1cc2666f33c386fd60615fc"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"bc4ee968b65dd957f082f853eaf413b2e13ece02","unresolved":false,"context_lines":[{"line_number":1364,"context_line":"            subnet_cidr \u003d subnet[\u0027subnet\u0027][\u0027cidr\u0027]"},{"line_number":1365,"context_line":"            eui_addr \u003d str(netutils.get_ipv6_addr_by_EUI64(subnet_cidr,"},{"line_number":1366,"context_line":"                                                           port_mac))"},{"line_number":1367,"context_line":"            self.assertEqual(len(port[\u0027port\u0027][\u0027fixed_ips\u0027]), 1)"},{"line_number":1368,"context_line":"            self.assertEqual(port[\u0027port\u0027][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"},{"line_number":1369,"context_line":"                             eui_addr)"},{"line_number":1370,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_7eafb87c","line":1367,"range":{"start_line":1367,"start_character":29,"end_line":1367,"end_character":62},"updated":"2017-04-11 10:12:06.000000000","message":"It\u0027s better to use assertEqual(expected, observed).","commit_id":"47d0900debb7cf1ad9b4ee41213ef553771231bc"}]}
