)]}'
{"neutron/tests/common/net_helpers.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"43bbd21920c7ef75e1df8dc62b7249a9322afdf5","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    def _read_stream(stream, timeout):"},{"line_number":291,"context_line":"        if timeout:"},{"line_number":292,"context_line":"            poll_predicate \u003d functools.partial("},{"line_number":293,"context_line":"                select.select, [stream], [], [], 1)"},{"line_number":294,"context_line":"            common_utils.wait_until_true("},{"line_number":295,"context_line":"                lambda: poll_predicate()[0], timeout, 0.1,"},{"line_number":296,"context_line":"                RuntimeError(\u0027No output in %.2f seconds\u0027 % timeout))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_d421cffc","line":293,"range":{"start_line":293,"start_character":47,"end_line":293,"end_character":50},"updated":"2017-03-21 06:06:49.000000000","message":"if you want to preserve the original behaviour, this should be 0.001, i guess.\n\nprobably it makes more sense to remove the use of wait_until_true though.","commit_id":"f48dbeda5c4f8f34fb0f56227254ea3b8f830005"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"bed6c144d30f620af27fed00b6ec41320eb12ad6","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    def _read_stream(stream, timeout):"},{"line_number":291,"context_line":"        if timeout:"},{"line_number":292,"context_line":"            poll_predicate \u003d functools.partial("},{"line_number":293,"context_line":"                select.select, [stream], [], [], 1)"},{"line_number":294,"context_line":"            common_utils.wait_until_true("},{"line_number":295,"context_line":"                lambda: poll_predicate()[0], timeout, 0.1,"},{"line_number":296,"context_line":"                RuntimeError(\u0027No output in %.2f seconds\u0027 % timeout))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_cf593a5c","line":293,"range":{"start_line":293,"start_character":47,"end_line":293,"end_character":50},"in_reply_to":"1a1ced50_6f5cc6ed","updated":"2017-03-21 06:48:39.000000000","message":"sure.","commit_id":"f48dbeda5c4f8f34fb0f56227254ea3b8f830005"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"74244ba1004c338f51136b78058e29064f9e190d","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    def _read_stream(stream, timeout):"},{"line_number":291,"context_line":"        if timeout:"},{"line_number":292,"context_line":"            poll_predicate \u003d functools.partial("},{"line_number":293,"context_line":"                select.select, [stream], [], [], 1)"},{"line_number":294,"context_line":"            common_utils.wait_until_true("},{"line_number":295,"context_line":"                lambda: poll_predicate()[0], timeout, 0.1,"},{"line_number":296,"context_line":"                RuntimeError(\u0027No output in %.2f seconds\u0027 % timeout))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_b371c878","line":293,"range":{"start_line":293,"start_character":47,"end_line":293,"end_character":50},"in_reply_to":"1a1ced50_cf593a5c","updated":"2017-03-21 07:02:48.000000000","message":"I push a follow-up patch https://review.openstack.org/447896","commit_id":"f48dbeda5c4f8f34fb0f56227254ea3b8f830005"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"06e4322f20f21990608a6c9bc71cb922d92367f4","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    def _read_stream(stream, timeout):"},{"line_number":291,"context_line":"        if timeout:"},{"line_number":292,"context_line":"            poll_predicate \u003d functools.partial("},{"line_number":293,"context_line":"                select.select, [stream], [], [], 1)"},{"line_number":294,"context_line":"            common_utils.wait_until_true("},{"line_number":295,"context_line":"                lambda: poll_predicate()[0], timeout, 0.1,"},{"line_number":296,"context_line":"                RuntimeError(\u0027No output in %.2f seconds\u0027 % timeout))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_6f5cc6ed","line":293,"range":{"start_line":293,"start_character":47,"end_line":293,"end_character":50},"in_reply_to":"1a1ced50_d421cffc","updated":"2017-03-21 06:30:12.000000000","message":"I agree, but at least this makes neutron work. I think we can clean up later.","commit_id":"f48dbeda5c4f8f34fb0f56227254ea3b8f830005"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"81655ab2808d6e29ff4bbc5340cad8377a591612","unresolved":false,"context_lines":[{"line_number":292,"context_line":"            poll_predicate \u003d functools.partial("},{"line_number":293,"context_line":"                select.select, [stream], [], [], 1)"},{"line_number":294,"context_line":"            common_utils.wait_until_true("},{"line_number":295,"context_line":"                lambda: poll_predicate()[0], timeout, 0.1,"},{"line_number":296,"context_line":"                RuntimeError(\u0027No output in %.2f seconds\u0027 % timeout))"},{"line_number":297,"context_line":"        return stream.readline()"},{"line_number":298,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_f4eecbb2","line":295,"updated":"2017-03-21 06:04:28.000000000","message":"It would be simpler to write this down without using functools.partial as we need to use lambda anyway.","commit_id":"f48dbeda5c4f8f34fb0f56227254ea3b8f830005"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"52dea963ad07b4bfbef448b8d7f73e853ce4c6dc","unresolved":false,"context_lines":[{"line_number":292,"context_line":"            poll_predicate \u003d functools.partial("},{"line_number":293,"context_line":"                select.select, [stream], [], [], 1)"},{"line_number":294,"context_line":"            common_utils.wait_until_true("},{"line_number":295,"context_line":"                lambda: poll_predicate()[0], timeout, 0.1,"},{"line_number":296,"context_line":"                RuntimeError(\u0027No output in %.2f seconds\u0027 % timeout))"},{"line_number":297,"context_line":"        return stream.readline()"},{"line_number":298,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_c8476175","line":295,"in_reply_to":"1a1ced50_f4eecbb2","updated":"2017-03-21 13:26:48.000000000","message":"Probably. I did not have brain power to groom it.","commit_id":"f48dbeda5c4f8f34fb0f56227254ea3b8f830005"}]}
