)]}'
{"neutron/tests/common/net_helpers.py":[{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"1972888157b8ad72bdeb6988277561638dab18ef","unresolved":false,"context_lines":[{"line_number":288,"context_line":"    @staticmethod"},{"line_number":289,"context_line":"    def _read_stream(stream, timeout):"},{"line_number":290,"context_line":"        if timeout:"},{"line_number":291,"context_line":"            rready, _wready, _xready \u003d select.select([stream], [], [], timeout)"},{"line_number":292,"context_line":"            if not rready:"},{"line_number":293,"context_line":"                raise RuntimeError(\u0027No output in %.2f seconds\u0027 % timeout)"},{"line_number":294,"context_line":"        return stream.readline()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_d9bca308","line":291,"updated":"2017-03-21 07:55:25.000000000","message":"Python3.5 is okay, but from PEP 475 and select.select documentation, it seems safer to catch InterruptedError and retry.","commit_id":"a7898c54954396f8fdfe86a6445f5e5648407d5e"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"b234ae3fb298b250b2349892c2a7edbe6d84481f","unresolved":false,"context_lines":[{"line_number":288,"context_line":"    @staticmethod"},{"line_number":289,"context_line":"    def _read_stream(stream, timeout):"},{"line_number":290,"context_line":"        if timeout:"},{"line_number":291,"context_line":"            rready, _wready, _xready \u003d select.select([stream], [], [], timeout)"},{"line_number":292,"context_line":"            if not rready:"},{"line_number":293,"context_line":"                raise RuntimeError(\u0027No output in %.2f seconds\u0027 % timeout)"},{"line_number":294,"context_line":"        return stream.readline()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_2c19c9d7","line":291,"in_reply_to":"1a1ced50_d9bca308","updated":"2017-03-22 03:57:41.000000000","message":"Eventlet patches select.select, so the above comment didn\u0027t make much sense. The eventlet version of select doesn\u0027t seem to have this issue though I didn\u0027t looked into details.\n\nStill I\u0027d prefer some comments saying raw select.select might be dangerous.","commit_id":"a7898c54954396f8fdfe86a6445f5e5648407d5e"}]}
