)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"14da478fffaf6be4f232c88841e6ee3fead5a6b5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"We can support more new attributes supported in keystonemiddleware"},{"line_number":12,"context_line":"without changing our code."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1674349"},{"line_number":15,"context_line":"Closes-Bug: #1621073"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: Ieec57d9ea8d95e55499a17e2c04da5e3e78a1557"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a1ced50_fe3d852b","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":20},"updated":"2017-03-22 12:36:58.000000000","message":"This should be Partial-Bug","commit_id":"95794d3932e2148ae433d46922e56997eb55122d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4c7aba1e13b06c8e611b2a8454ac8a6d92564574","unresolved":false,"context_lines":[{"line_number":22,"context_line":"also ensures context.project_name and context.tenant_name have"},{"line_number":23,"context_line":"a same value."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Ie48aa843ca8c852b1e93e760d2e3e8aaa38aed56"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a1ced50_f38f6e72","line":25,"updated":"2017-03-22 17:35:15.000000000","message":"This will need to Depends-On the patch that will bump to the new neutron-lib version.","commit_id":"fa20d4bc66e2ca69da11226bc27f00994537d43f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9d873c3f92e6076de0a4c07a7f0297dee50507a6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"also ensures context.project_name and context.tenant_name have"},{"line_number":23,"context_line":"a same value."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Ie48aa843ca8c852b1e93e760d2e3e8aaa38aed56"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a1ced50_f22e6d41","line":25,"in_reply_to":"1a1ced50_f38f6e72","updated":"2017-03-23 09:08:13.000000000","message":"Done\n\nHonestly I wondered we need a new neutron-lib release. Context object is created only by neutron.auth code and no other code instantiate Context object. Only consumer affected by this change is someone who use \u0027tenant_name\u0027 attribute directly. But it is better to wait neutron-lib release rather than rushing something.","commit_id":"fa20d4bc66e2ca69da11226bc27f00994537d43f"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"1afb93aef16b2c2a5ff0d7eee6ea313205f79a08","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Partial-Bug: #1674349"},{"line_number":15,"context_line":"Closes-Bug: #1621073"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"In the unit test, context.tenant_name is replaced to context.project_name"},{"line_number":18,"context_line":"as it will be the recommended way to access project name now."},{"line_number":19,"context_line":"Note that equivalency of project_name and tenant_name will be ensured"},{"line_number":20,"context_line":"by a depending neutron-lib patch [1], so this change affects nobody."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a1ced50_0cce76b4","line":17,"updated":"2017-03-23 17:46:14.000000000","message":"nit: line exceeds 72 characters","commit_id":"75c34838ef7132352a34b0c224c2536a5283b1d5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"42a9c50d9f48d1f660599d5485e0f6d6e71ee1a8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Partial-Bug: #1674349"},{"line_number":15,"context_line":"Closes-Bug: #1621073"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"In the unit test, context.tenant_name is replaced to context.project_name"},{"line_number":18,"context_line":"as it will be the recommended way to access project name now."},{"line_number":19,"context_line":"Note that equivalency of project_name and tenant_name will be ensured"},{"line_number":20,"context_line":"by a depending neutron-lib patch [1], so this change affects nobody."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ffe62b97_24c2e886","line":17,"in_reply_to":"1a1ced50_0cce76b4","updated":"2017-03-24 08:24:58.000000000","message":"I know it is over 72 characters, but the last word is long and I think 73 chars is okay like some URL.","commit_id":"75c34838ef7132352a34b0c224c2536a5283b1d5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"63bf582092310c875b6d4e42190459c8804554db","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1] https://review.openstack.org/#/c/448537/"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Depends-On: Ieec57d9ea8d95e55499a17e2c04da5e3e78a1557"},{"line_number":25,"context_line":"Change-Id: Ie48aa843ca8c852b1e93e760d2e3e8aaa38aed56"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a1ced50_cda4744c","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":53},"updated":"2017-03-23 09:33:59.000000000","message":"Correct me if I\u0027m wrong, but this version of neutron-lib doesn\u0027t have context.Context.from_environ implemented.","commit_id":"75c34838ef7132352a34b0c224c2536a5283b1d5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3088bc19014c8550b5c0e9852cfbc53cc6c53a76","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1] https://review.openstack.org/#/c/448537/"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Depends-On: Ieec57d9ea8d95e55499a17e2c04da5e3e78a1557"},{"line_number":25,"context_line":"Change-Id: Ie48aa843ca8c852b1e93e760d2e3e8aaa38aed56"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a1ced50_52800a8c","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":53},"in_reply_to":"1a1ced50_5a059343","updated":"2017-03-23 16:55:20.000000000","message":"Yes, that is the essence of this change. We can easily sync with other communities in OpenStack by using a way provided by oslo :)","commit_id":"75c34838ef7132352a34b0c224c2536a5283b1d5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e3b2b4b7fa1cccdbc06e447c7a039ec2bce7cdf5","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1] https://review.openstack.org/#/c/448537/"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Depends-On: Ieec57d9ea8d95e55499a17e2c04da5e3e78a1557"},{"line_number":25,"context_line":"Change-Id: Ie48aa843ca8c852b1e93e760d2e3e8aaa38aed56"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a1ced50_5a059343","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":53},"in_reply_to":"1a1ced50_cda4744c","updated":"2017-03-23 10:57:47.000000000","message":"Sorry, it has. It\u0027s in oslo_context","commit_id":"75c34838ef7132352a34b0c224c2536a5283b1d5"}],"neutron/tests/unit/test_auth.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4c7aba1e13b06c8e611b2a8454ac8a6d92564574","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        self.assertEqual(\u0027testtenantid\u0027, self.context.tenant_id)"},{"line_number":89,"context_line":"        # neutron_lib Context ensures project_name and tenant_name"},{"line_number":90,"context_line":"        # have a same value (https://review.openstack.org/#/c/448537/)"},{"line_number":91,"context_line":"        # We check project_name here."},{"line_number":92,"context_line":"        self.assertEqual(\u0027testtenantname\u0027, self.context.project_name)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_request_id_extracted_from_env(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_53d6824f","line":91,"updated":"2017-03-22 17:35:15.000000000","message":"not sure this comment would mean much outside the scope of the change. I would prefer to just kill it.","commit_id":"fa20d4bc66e2ca69da11226bc27f00994537d43f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9d873c3f92e6076de0a4c07a7f0297dee50507a6","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        self.assertEqual(\u0027testtenantid\u0027, self.context.tenant_id)"},{"line_number":89,"context_line":"        # neutron_lib Context ensures project_name and tenant_name"},{"line_number":90,"context_line":"        # have a same value (https://review.openstack.org/#/c/448537/)"},{"line_number":91,"context_line":"        # We check project_name here."},{"line_number":92,"context_line":"        self.assertEqual(\u0027testtenantname\u0027, self.context.project_name)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_request_id_extracted_from_env(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_32348548","line":91,"in_reply_to":"1a1ced50_53d6824f","updated":"2017-03-23 09:08:13.000000000","message":"Done. Remove it.","commit_id":"fa20d4bc66e2ca69da11226bc27f00994537d43f"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"dfa7cf5c57ec36b5e90af2726543beefa8b91f07","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.assertEqual(\u0027testuserid\u0027, self.context.user_id)"},{"line_number":87,"context_line":"        self.assertEqual(\u0027testusername\u0027, self.context.user_name)"},{"line_number":88,"context_line":"        self.assertEqual(\u0027testtenantid\u0027, self.context.tenant_id)"},{"line_number":89,"context_line":"        self.assertEqual(\u0027testtenantname\u0027, self.context.project_name)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_request_id_extracted_from_env(self):"},{"line_number":92,"context_line":"        req_id \u003d \u0027dummy-request-id\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_7da9577b","line":89,"range":{"start_line":89,"start_character":8,"end_line":89,"end_character":69},"updated":"2017-03-23 17:05:59.000000000","message":"since we have both atm can we assert on both until tenant_name is completely removed ?","commit_id":"75c34838ef7132352a34b0c224c2536a5283b1d5"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"1afb93aef16b2c2a5ff0d7eee6ea313205f79a08","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.assertEqual(\u0027testuserid\u0027, self.context.user_id)"},{"line_number":87,"context_line":"        self.assertEqual(\u0027testusername\u0027, self.context.user_name)"},{"line_number":88,"context_line":"        self.assertEqual(\u0027testtenantid\u0027, self.context.tenant_id)"},{"line_number":89,"context_line":"        self.assertEqual(\u0027testtenantname\u0027, self.context.project_name)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_request_id_extracted_from_env(self):"},{"line_number":92,"context_line":"        req_id \u003d \u0027dummy-request-id\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_ecf11a03","line":89,"range":{"start_line":89,"start_character":8,"end_line":89,"end_character":69},"in_reply_to":"1a1ced50_7da9577b","updated":"2017-03-23 17:46:14.000000000","message":"+1","commit_id":"75c34838ef7132352a34b0c224c2536a5283b1d5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"42a9c50d9f48d1f660599d5485e0f6d6e71ee1a8","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.assertEqual(\u0027testuserid\u0027, self.context.user_id)"},{"line_number":87,"context_line":"        self.assertEqual(\u0027testusername\u0027, self.context.user_name)"},{"line_number":88,"context_line":"        self.assertEqual(\u0027testtenantid\u0027, self.context.tenant_id)"},{"line_number":89,"context_line":"        self.assertEqual(\u0027testtenantname\u0027, self.context.project_name)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_request_id_extracted_from_env(self):"},{"line_number":92,"context_line":"        req_id \u003d \u0027dummy-request-id\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_04c5a43c","line":89,"range":{"start_line":89,"start_character":8,"end_line":89,"end_character":69},"in_reply_to":"1a1ced50_ecf11a03","updated":"2017-03-24 08:24:58.000000000","message":"At the moment, as of neutron-lib 1.3.0, we cannot test \u0027tenant_name\u0027 because context.Context.from_environ() sets only project_name and does not set tenant_name.\n\nAs I mentioned in the commit message, a neutron-lib patch ensures project_name and tenant_name are handled equally. From this consideration, I decided to test project_name only here.\n\n  In the unit test, context.tenant_name is replaced to context.project_name\n  as it will be the recommended way to access project name now.\n  Note that equivalency of project_name and tenant_name will be ensured\n  by a depending neutron-lib patch [1], so this change affects nobody.\n\nDoes it sound a reasonable compromise?","commit_id":"75c34838ef7132352a34b0c224c2536a5283b1d5"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"9bfad601759e56b3bda4d8f1327f52c45bd4af72","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.assertEqual(\u0027testuserid\u0027, self.context.user_id)"},{"line_number":87,"context_line":"        self.assertEqual(\u0027testusername\u0027, self.context.user_name)"},{"line_number":88,"context_line":"        self.assertEqual(\u0027testtenantid\u0027, self.context.tenant_id)"},{"line_number":89,"context_line":"        self.assertEqual(\u0027testtenantname\u0027, self.context.project_name)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_request_id_extracted_from_env(self):"},{"line_number":92,"context_line":"        req_id \u003d \u0027dummy-request-id\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_bb8284c7","line":89,"range":{"start_line":89,"start_character":8,"end_line":89,"end_character":69},"in_reply_to":"ffe62b97_04c5a43c","updated":"2017-03-24 16:02:33.000000000","message":"it does !!","commit_id":"75c34838ef7132352a34b0c224c2536a5283b1d5"}]}
