)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c628cf140bdcfed2fc0f16a6d117f143e4fdb2eb","unresolved":false,"context_lines":[{"line_number":11,"context_line":"in qos_policy not being detached from network on"},{"line_number":12,"context_line":"the backend side."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"after processing update on network via extensions"},{"line_number":15,"context_line":"it was reading from db before sending data to"},{"line_number":16,"context_line":"mechanism_driver which was still stale. we can"},{"line_number":17,"context_line":"continue sending updated_network to mechanism_driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a1ced50_22c284e9","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":5},"updated":"2017-03-23 01:34:38.000000000","message":"nit: After","commit_id":"2844340665303b1041e1b3358b3400595279a3dc"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"6646212e0d6aca85f5651aa45ef6f5039704e3c5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"in qos_policy not being detached from network on"},{"line_number":12,"context_line":"the backend side."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"after processing update on network via extensions"},{"line_number":15,"context_line":"it was reading from db before sending data to"},{"line_number":16,"context_line":"mechanism_driver which was still stale. we can"},{"line_number":17,"context_line":"continue sending updated_network to mechanism_driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a1ced50_97cef4b5","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":5},"in_reply_to":"1a1ced50_22c284e9","updated":"2017-03-23 16:35:08.000000000","message":"Done","commit_id":"2844340665303b1041e1b3358b3400595279a3dc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c628cf140bdcfed2fc0f16a6d117f143e4fdb2eb","unresolved":false,"context_lines":[{"line_number":15,"context_line":"it was reading from db before sending data to"},{"line_number":16,"context_line":"mechanism_driver which was still stale. we can"},{"line_number":17,"context_line":"continue sending updated_network to mechanism_driver"},{"line_number":18,"context_line":"without fetching it from database"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I8260305567726a4f48c48ab0bb3197292e9175a8"},{"line_number":21,"context_line":"Closes-Bug: #1675135"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a1ced50_62b8fc75","line":18,"updated":"2017-03-23 01:34:38.000000000","message":"nit : \".\"","commit_id":"2844340665303b1041e1b3358b3400595279a3dc"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"6646212e0d6aca85f5651aa45ef6f5039704e3c5","unresolved":false,"context_lines":[{"line_number":15,"context_line":"it was reading from db before sending data to"},{"line_number":16,"context_line":"mechanism_driver which was still stale. we can"},{"line_number":17,"context_line":"continue sending updated_network to mechanism_driver"},{"line_number":18,"context_line":"without fetching it from database"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I8260305567726a4f48c48ab0bb3197292e9175a8"},{"line_number":21,"context_line":"Closes-Bug: #1675135"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a1ced50_d7c86cab","line":18,"in_reply_to":"1a1ced50_62b8fc75","updated":"2017-03-23 16:35:08.000000000","message":"Done","commit_id":"2844340665303b1041e1b3358b3400595279a3dc"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"d0cfa21320ec505aca866d4870e41c4fd5cff6b0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"mechanism_driver which was still stale. we can"},{"line_number":17,"context_line":"continue sending updated_network to mechanism_driver"},{"line_number":18,"context_line":"without fetching it from database"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I8260305567726a4f48c48ab0bb3197292e9175a8"},{"line_number":21,"context_line":"Closes-Bug: #1675135"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a1ced50_8a34344a","line":19,"updated":"2017-03-22 22:38:44.000000000","message":"partial-bug: #1674727","commit_id":"2844340665303b1041e1b3358b3400595279a3dc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c628cf140bdcfed2fc0f16a6d117f143e4fdb2eb","unresolved":false,"context_lines":[{"line_number":16,"context_line":"mechanism_driver which was still stale. we can"},{"line_number":17,"context_line":"continue sending updated_network to mechanism_driver"},{"line_number":18,"context_line":"without fetching it from database"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I8260305567726a4f48c48ab0bb3197292e9175a8"},{"line_number":21,"context_line":"Closes-Bug: #1675135"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a1ced50_e28dccd3","line":19,"in_reply_to":"1a1ced50_8a34344a","updated":"2017-03-23 01:34:38.000000000","message":"+1","commit_id":"2844340665303b1041e1b3358b3400595279a3dc"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"6646212e0d6aca85f5651aa45ef6f5039704e3c5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"mechanism_driver which was still stale. we can"},{"line_number":17,"context_line":"continue sending updated_network to mechanism_driver"},{"line_number":18,"context_line":"without fetching it from database"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I8260305567726a4f48c48ab0bb3197292e9175a8"},{"line_number":21,"context_line":"Closes-Bug: #1675135"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a1ced50_b73a1097","line":19,"in_reply_to":"1a1ced50_e28dccd3","updated":"2017-03-23 16:35:08.000000000","message":"why partial ? since this was just for network and it fixes it.","commit_id":"2844340665303b1041e1b3358b3400595279a3dc"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"d0cfa21320ec505aca866d4870e41c4fd5cff6b0","unresolved":false,"context_lines":[{"line_number":811,"context_line":"            self.type_manager.extend_network_dict_provider(context,"},{"line_number":812,"context_line":"                                                           updated_network)"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"            updated_network \u003d self.get_network(context, id)"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"            kwargs \u003d {\u0027context\u0027: context, \u0027network\u0027: updated_network,"},{"line_number":817,"context_line":"                      \u0027original_network\u0027: original_network}"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_e55cfb4c","side":"PARENT","line":814,"range":{"start_line":814,"start_character":12,"end_line":814,"end_character":59},"updated":"2017-03-22 22:38:44.000000000","message":"As we\u0027re seeing not-commited data. session flush?","commit_id":"71d96a8306e89d66ec7891aea7ba9d17933d4dd1"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c503e07dfc11ce80cbdc42b34ac089a96bb7b245","unresolved":false,"context_lines":[{"line_number":811,"context_line":"            self.type_manager.extend_network_dict_provider(context,"},{"line_number":812,"context_line":"                                                           updated_network)"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"            updated_network \u003d self.get_network(context, id)"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"            kwargs \u003d {\u0027context\u0027: context, \u0027network\u0027: updated_network,"},{"line_number":817,"context_line":"                      \u0027original_network\u0027: original_network}"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_59db351a","side":"PARENT","line":814,"range":{"start_line":814,"start_character":12,"end_line":814,"end_character":59},"in_reply_to":"1a1ced50_97db5421","updated":"2017-03-27 16:53:24.000000000","message":"expire_all() will work","commit_id":"71d96a8306e89d66ec7891aea7ba9d17933d4dd1"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c628cf140bdcfed2fc0f16a6d117f143e4fdb2eb","unresolved":false,"context_lines":[{"line_number":811,"context_line":"            self.type_manager.extend_network_dict_provider(context,"},{"line_number":812,"context_line":"                                                           updated_network)"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"            updated_network \u003d self.get_network(context, id)"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"            kwargs \u003d {\u0027context\u0027: context, \u0027network\u0027: updated_network,"},{"line_number":817,"context_line":"                      \u0027original_network\u0027: original_network}"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_229b6419","side":"PARENT","line":814,"range":{"start_line":814,"start_character":12,"end_line":814,"end_character":59},"in_reply_to":"1a1ced50_e55cfb4c","updated":"2017-03-23 01:34:38.000000000","message":"I agree , we should ideally flush the data to the DB, because if we dont, then it is possible that we face similar issue somehwere else","commit_id":"71d96a8306e89d66ec7891aea7ba9d17933d4dd1"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"6646212e0d6aca85f5651aa45ef6f5039704e3c5","unresolved":false,"context_lines":[{"line_number":811,"context_line":"            self.type_manager.extend_network_dict_provider(context,"},{"line_number":812,"context_line":"                                                           updated_network)"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"            updated_network \u003d self.get_network(context, id)"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"            kwargs \u003d {\u0027context\u0027: context, \u0027network\u0027: updated_network,"},{"line_number":817,"context_line":"                      \u0027original_network\u0027: original_network}"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_97db5421","side":"PARENT","line":814,"range":{"start_line":814,"start_character":12,"end_line":814,"end_character":59},"in_reply_to":"1a1ced50_e55cfb4c","updated":"2017-03-23 16:35:08.000000000","message":"I am not sure about the sql alchemy\u0027s behavior, but with context.session.flush() I still see stale data when a get is done after that","commit_id":"71d96a8306e89d66ec7891aea7ba9d17933d4dd1"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"0869641b71c38e042e786f046e813093e21a8420","unresolved":false,"context_lines":[{"line_number":811,"context_line":"            self.type_manager.extend_network_dict_provider(context,"},{"line_number":812,"context_line":"                                                           updated_network)"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"            # NOTE(manjeets) expire the session and get new one so that"},{"line_number":815,"context_line":"            # data fetch returns updated data"},{"line_number":816,"context_line":"            context.session.expire_all()"},{"line_number":817,"context_line":"            updated_network \u003d self.get_network(context, id)"},{"line_number":818,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_bfea1e72","line":815,"range":{"start_line":814,"start_character":12,"end_line":815,"end_character":45},"updated":"2017-03-27 18:19:52.000000000","message":"So does this mean that neutron/db/qos/api.py or neutorn/object/qos/polcy.py should include appropreate expire for network/port orm object?","commit_id":"8a602b29a6708ba85de8a20da579f23e75e05aeb"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"38f91295ccea31915c47c3c8ca820aae2beb7ab8","unresolved":false,"context_lines":[{"line_number":811,"context_line":"            self.type_manager.extend_network_dict_provider(context,"},{"line_number":812,"context_line":"                                                           updated_network)"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"            # NOTE(manjeets) expire the session and get new one so that"},{"line_number":815,"context_line":"            # data fetch returns updated data"},{"line_number":816,"context_line":"            context.session.expire_all()"},{"line_number":817,"context_line":"            updated_network \u003d self.get_network(context, id)"},{"line_number":818,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_a7ce88b1","line":815,"range":{"start_line":814,"start_character":12,"end_line":815,"end_character":45},"in_reply_to":"ffe62b97_128d7cd2","updated":"2017-03-27 23:06:57.000000000","message":"I\u0027ve manually tested ports without this, i don\u0027t see any qos_data when policy from port is detached. http://paste.openstack.org/show/604392/","commit_id":"8a602b29a6708ba85de8a20da579f23e75e05aeb"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"fde6141deed684db8f2294f45fffc9baf1792cd7","unresolved":false,"context_lines":[{"line_number":811,"context_line":"            self.type_manager.extend_network_dict_provider(context,"},{"line_number":812,"context_line":"                                                           updated_network)"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"            # NOTE(manjeets) expire the session and get new one so that"},{"line_number":815,"context_line":"            # data fetch returns updated data"},{"line_number":816,"context_line":"            context.session.expire_all()"},{"line_number":817,"context_line":"            updated_network \u003d self.get_network(context, id)"},{"line_number":818,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_128d7cd2","line":815,"range":{"start_line":814,"start_character":12,"end_line":815,"end_character":45},"in_reply_to":"ffe62b97_bfea1e72","updated":"2017-03-27 19:51:10.000000000","message":"I think ports may require that not qos, because we just want to update references for qos-policy when network or port is updated.","commit_id":"8a602b29a6708ba85de8a20da579f23e75e05aeb"}]}
