)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"c360fe948173d351a8005c26f98cdc849ac618d0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is a fatal error in networking-ovn in some case, so I port"},{"line_number":10,"context_line":"idlutils.get_schema_helper from ovsdbapp to neutron and add some unit"},{"line_number":11,"context_line":"tests. Networking-ovn will pass try_add_manager\u003dFlase to it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I12461c96f7a2845b3155fd587fb1fcc84ecf85f0"},{"line_number":14,"context_line":"Closes-Bug: #1672590"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ffe62b97_7863e5dd","line":11,"range":{"start_line":11,"start_character":48,"end_line":11,"end_character":53},"updated":"2017-03-24 14:45:31.000000000","message":"typo","commit_id":"9a5ee20f253d65680a188488b48c6f4ce96aabc7"},{"author":{"_account_id":23458,"name":"Dong Jun","email":"dongjun.01@bytedance.com","username":"Dongj"},"change_message_id":"ed1d61a9eb8c1191d54ad8c5c121dd42c9f6c2b5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is a fatal error in networking-ovn in some case, so I port"},{"line_number":10,"context_line":"idlutils.get_schema_helper from ovsdbapp to neutron and add some unit"},{"line_number":11,"context_line":"tests. Networking-ovn will pass try_add_manager\u003dFlase to it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I12461c96f7a2845b3155fd587fb1fcc84ecf85f0"},{"line_number":14,"context_line":"Closes-Bug: #1672590"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ffe62b97_7892acf8","line":11,"range":{"start_line":11,"start_character":48,"end_line":11,"end_character":53},"in_reply_to":"ffe62b97_7863e5dd","updated":"2017-03-25 06:45:57.000000000","message":"Thanks","commit_id":"9a5ee20f253d65680a188488b48c6f4ce96aabc7"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"c360fe948173d351a8005c26f98cdc849ac618d0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"tests. Networking-ovn will pass try_add_manager\u003dFlase to it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I12461c96f7a2845b3155fd587fb1fcc84ecf85f0"},{"line_number":14,"context_line":"Closes-Bug: #1672590"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ffe62b97_981ea90a","line":14,"range":{"start_line":14,"start_character":13,"end_line":14,"end_character":20},"updated":"2017-03-24 14:45:31.000000000","message":"I\u0027ve merged two bugs into one. Please change this to #1674889","commit_id":"9a5ee20f253d65680a188488b48c6f4ce96aabc7"},{"author":{"_account_id":23458,"name":"Dong Jun","email":"dongjun.01@bytedance.com","username":"Dongj"},"change_message_id":"ed1d61a9eb8c1191d54ad8c5c121dd42c9f6c2b5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"tests. Networking-ovn will pass try_add_manager\u003dFlase to it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I12461c96f7a2845b3155fd587fb1fcc84ecf85f0"},{"line_number":14,"context_line":"Closes-Bug: #1672590"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ffe62b97_38be6465","line":14,"range":{"start_line":14,"start_character":13,"end_line":14,"end_character":20},"in_reply_to":"ffe62b97_981ea90a","updated":"2017-03-25 06:45:57.000000000","message":"OK. Will revise this field","commit_id":"9a5ee20f253d65680a188488b48c6f4ce96aabc7"}],"neutron/agent/ovsdb/native/idlutils.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"c360fe948173d351a8005c26f98cdc849ac618d0","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    try:"},{"line_number":123,"context_line":"        return _get_schema_helper(connection, schema_name)"},{"line_number":124,"context_line":"    except Exception:"},{"line_number":125,"context_line":"        with excutils.save_and_reraise_exception(reraise\u003dFalse) as ctx:"},{"line_number":126,"context_line":"            if not retry:"},{"line_number":127,"context_line":"                ctx.reraise \u003d True"},{"line_number":128,"context_line":"            # We may have failed due to set-manager not being called"},{"line_number":129,"context_line":"            helpers.enable_connection_uri(connection, set_timeout\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_d8af9192","side":"PARENT","line":126,"range":{"start_line":125,"start_character":0,"end_line":126,"end_character":25},"updated":"2017-03-24 14:45:31.000000000","message":"Why did you remove that?","commit_id":"44a51b8c09f5aed2823e9c90fe7cf512041f73b1"},{"author":{"_account_id":23458,"name":"Dong Jun","email":"dongjun.01@bytedance.com","username":"Dongj"},"change_message_id":"ed1d61a9eb8c1191d54ad8c5c121dd42c9f6c2b5","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    try:"},{"line_number":123,"context_line":"        return _get_schema_helper(connection, schema_name)"},{"line_number":124,"context_line":"    except Exception:"},{"line_number":125,"context_line":"        with excutils.save_and_reraise_exception(reraise\u003dFalse) as ctx:"},{"line_number":126,"context_line":"            if not retry:"},{"line_number":127,"context_line":"                ctx.reraise \u003d True"},{"line_number":128,"context_line":"            # We may have failed due to set-manager not being called"},{"line_number":129,"context_line":"            helpers.enable_connection_uri(connection, set_timeout\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_ba6029a7","side":"PARENT","line":126,"range":{"start_line":125,"start_character":0,"end_line":126,"end_character":25},"in_reply_to":"ffe62b97_d8af9192","updated":"2017-03-25 06:45:57.000000000","message":"There is a bug here, if retry is False, still go to the following tenacity.retry dealing, it should exit and raise, thus save_and_reraise_exception is not necessary.\novsdbapp[1] fixed this bug, I port it to here and add new unit tests. \n[1]https://github.com/openstack/ovsdbapp/blob/master/ovsdbapp/native/idlutils.py#L123-L125","commit_id":"44a51b8c09f5aed2823e9c90fe7cf512041f73b1"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"c360fe948173d351a8005c26f98cdc849ac618d0","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        if not retry:"},{"line_number":126,"context_line":"            raise"},{"line_number":127,"context_line":"        # We may have failed due to set-manager not being called"},{"line_number":128,"context_line":"        if try_add_manager:"},{"line_number":129,"context_line":"            helpers.enable_connection_uri(connection, set_timeout\u003dTrue)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # There is a small window for a race, so retry up to a second"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_b8cf2d7e","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":27},"updated":"2017-03-24 14:45:31.000000000","message":"I\u0027m not quite sure, how it supposed to networking-ovn? Does it mean, ovn won\u0027t use enable_connection_uri?","commit_id":"9a5ee20f253d65680a188488b48c6f4ce96aabc7"},{"author":{"_account_id":23458,"name":"Dong Jun","email":"dongjun.01@bytedance.com","username":"Dongj"},"change_message_id":"ed1d61a9eb8c1191d54ad8c5c121dd42c9f6c2b5","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        if not retry:"},{"line_number":126,"context_line":"            raise"},{"line_number":127,"context_line":"        # We may have failed due to set-manager not being called"},{"line_number":128,"context_line":"        if try_add_manager:"},{"line_number":129,"context_line":"            helpers.enable_connection_uri(connection, set_timeout\u003dTrue)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # There is a small window for a race, so retry up to a second"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_9a6325b2","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":27},"in_reply_to":"ffe62b97_b8cf2d7e","updated":"2017-03-25 06:45:57.000000000","message":"Networking-ovn connects to two OVSDBs, OVN_Northbound and OVN_Southbound, they are also OVSDBs having different schema with Open_vSwitch OVSDB.\nManager is the table only included in Open_vSwitch DB, networking-ovn should not set it.","commit_id":"9a5ee20f253d65680a188488b48c6f4ce96aabc7"}]}
