)]}'
{"neutron/agent/linux/ovs_lib.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e19abae88d9dfa34c2d6f66ad4af1b287e45e5a2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from neutron.openstack.common import jsonutils"},{"line_number":26,"context_line":"from neutron.openstack.common import log as logging"},{"line_number":27,"context_line":"from neutron.plugins.common import constants as p_const"},{"line_number":28,"context_line":"#  TODO(JLH) Should we remove the explicit include of the ovs plugin here"},{"line_number":29,"context_line":"from neutron.plugins.openvswitch.common import constants"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2FXoo%3D","line":28,"updated":"2013-11-08 03:37:24.000000000","message":"Maybe file a bug to handle this rather than a TODO item in the code.","commit_id":"9650ddc6c2946b1921c07d6ac3820147e1f39f1d"},{"author":{"_account_id":2967,"name":"ljjjustin","email":"iamljj@gmail.com","username":"ljjjustin"},"change_message_id":"13a0ea9b8970ae4b1045912ad499d47515efaaea","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from neutron.openstack.common import jsonutils"},{"line_number":26,"context_line":"from neutron.openstack.common import log as logging"},{"line_number":27,"context_line":"from neutron.plugins.common import constants as p_const"},{"line_number":28,"context_line":"#  TODO(JLH) Should we remove the explicit include of the ovs plugin here"},{"line_number":29,"context_line":"from neutron.plugins.openvswitch.common import constants"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2FXEY%3D","line":28,"in_reply_to":"AAAATn%2F%2FXoo%3D","updated":"2013-11-08 08:08:31.000000000","message":"yes. I have fired a bug for this already.\nhttps://bugs.launchpad.net/neutron/+bug/1248017","commit_id":"9650ddc6c2946b1921c07d6ac3820147e1f39f1d"}],"neutron/plugins/hyperv/common/constants.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"98b17dfe0886c97a991f38f160bcdb3a423b76a6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"FLAT_VLAN_ID \u003d -1"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Values for network_type"},{"line_number":26,"context_line":"TYPE_NVGRE \u003d \u0027gre\u0027  # TODO(JLH) RENAME TO TYPE_GRE"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2Fe%2B8%3D","line":26,"updated":"2013-09-04 08:35:24.000000000","message":"seems it\u0027s not used anywhere and can be removed","commit_id":"d6be5c8e15983a35f3ede3a37b50de5e78af584e"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"6fb662e65325414e8b47efe7c69b9c9100c0d9e2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"FLAT_VLAN_ID \u003d -1"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Values for network_type"},{"line_number":26,"context_line":"TYPE_NVGRE \u003d \u0027gre\u0027  # TODO(JLH) RENAME TO TYPE_GRE"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATX%2F%2F%2F7s%3D","line":26,"updated":"2013-10-23 04:23:52.000000000","message":"Why rename? Can you assign it to TYPE_GRE?","commit_id":"61702e5876c0a0c124334584771504cec42943b4"},{"author":{"_account_id":5127,"name":"Justin Hammond","email":"runningempty@gmail.com","username":"justin-hammond"},"change_message_id":"ff5b063d59751f0091384c8ca5ab203d626911db","unresolved":false,"context_lines":[{"line_number":23,"context_line":"FLAT_VLAN_ID \u003d -1"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Values for network_type"},{"line_number":26,"context_line":"TYPE_NVGRE \u003d \u0027gre\u0027  # TODO(JLH) RENAME TO TYPE_GRE"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATX%2F%2F97M%3D","line":26,"in_reply_to":"AAAATX%2F%2F%2F7s%3D","updated":"2013-10-23 14:50:19.000000000","message":"as per the discussion at the bug https://bugs.launchpad.net/neutron/+bug/1196170 it was recommended that I minimize the scope of the change. Oleg had the same concerns as you so I\u0027m going to go ahead and make the change.","commit_id":"61702e5876c0a0c124334584771504cec42943b4"}],"neutron/plugins/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e19abae88d9dfa34c2d6f66ad4af1b287e45e5a2","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        self.setup_integration_br()"},{"line_number":201,"context_line":"        self.setup_physical_bridges(bridge_mappings)"},{"line_number":202,"context_line":"        self.local_vlan_map \u003d {}"},{"line_number":203,"context_line":"        self.tun_br_ofports \u003d {p_const.TYPE_GRE: set(),"},{"line_number":204,"context_line":"                               p_const.TYPE_VXLAN: set()}"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        self.polling_interval \u003d polling_interval"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2FXnk%3D","line":203,"updated":"2013-11-08 03:37:24.000000000","message":"Changing from {} to set() seems to be outside the scope of this patch. Keep patches focused on their defined purpose.","commit_id":"9650ddc6c2946b1921c07d6ac3820147e1f39f1d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3f06a9a6300869cf6781232dc4809d44300d6096","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        self.setup_integration_br()"},{"line_number":201,"context_line":"        self.setup_physical_bridges(bridge_mappings)"},{"line_number":202,"context_line":"        self.local_vlan_map \u003d {}"},{"line_number":203,"context_line":"        self.tun_br_ofports \u003d {p_const.TYPE_GRE: set(),"},{"line_number":204,"context_line":"                               p_const.TYPE_VXLAN: set()}"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        self.polling_interval \u003d polling_interval"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2FHko%3D","line":203,"in_reply_to":"AAAATn%2F%2FXnk%3D","updated":"2013-11-14 07:57:23.000000000","message":"Done","commit_id":"9650ddc6c2946b1921c07d6ac3820147e1f39f1d"}],"neutron/plugins/openvswitch/common/constants.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"6fb662e65325414e8b47efe7c69b9c9100c0d9e2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Special vlan_id value in ovs_vlan_allocations table indicating flat network"},{"line_number":17,"context_line":"from neutron.plugins.common import constants as p_const"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATX%2F%2F%2F7Y%3D","line":16,"updated":"2013-10-23 04:23:52.000000000","message":"This comment is now in the wrong place. Needs to L19.","commit_id":"61702e5876c0a0c124334584771504cec42943b4"}],"neutron/tests/unit/openvswitch/test_ovs_tunnel.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e19abae88d9dfa34c2d6f66ad4af1b287e45e5a2","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                                          self.VETH_MTU)"},{"line_number":196,"context_line":"        self.mox.VerifyAll()"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def testProvisionLocalVlan(self):"},{"line_number":199,"context_line":"        ofports \u003d \u0027,\u0027.join(TUN_OFPORTS[p_const.TYPE_GRE].values())"},{"line_number":200,"context_line":"        self.mock_tun_bridge.mod_flow(table\u003dconstants.FLOOD_TO_TUN,"},{"line_number":201,"context_line":"                                      priority\u003d1,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2FXmY%3D","line":198,"updated":"2013-11-08 03:37:24.000000000","message":"Why change the name here?  Tests should be named_with_underscores_and_lower_case rather than WithCamelCase.","commit_id":"9650ddc6c2946b1921c07d6ac3820147e1f39f1d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3f06a9a6300869cf6781232dc4809d44300d6096","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                                          self.VETH_MTU)"},{"line_number":196,"context_line":"        self.mox.VerifyAll()"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def testProvisionLocalVlan(self):"},{"line_number":199,"context_line":"        ofports \u003d \u0027,\u0027.join(TUN_OFPORTS[p_const.TYPE_GRE].values())"},{"line_number":200,"context_line":"        self.mock_tun_bridge.mod_flow(table\u003dconstants.FLOOD_TO_TUN,"},{"line_number":201,"context_line":"                                      priority\u003d1,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2FHkk%3D","line":198,"in_reply_to":"AAAATn%2F%2FXmY%3D","updated":"2013-11-14 07:57:23.000000000","message":"Done","commit_id":"9650ddc6c2946b1921c07d6ac3820147e1f39f1d"}]}