)]}'
{"neutron/agent/l2/extensions/qos.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e0ff7717718bd62b117de2bdb9d5a28273b3a3fb","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    def _process_reset_port(self, port):"},{"line_number":277,"context_line":"        try:"},{"line_number":278,"context_line":"            self.qos_driver.delete(port)"},{"line_number":279,"context_line":"            self.policy_map.clean_by_port(port)"},{"line_number":280,"context_line":"        except exceptions.PortNotFound:"},{"line_number":281,"context_line":"            LOG.info(_LI(\"QoS extension did not have information on port %s\"),"},{"line_number":282,"context_line":"                     port[\u0027port_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_7494098c","line":279,"range":{"start_line":279,"start_character":12,"end_line":279,"end_character":47},"updated":"2017-03-24 16:55:37.000000000","message":"If the agent is restarted, won\u0027t have \"self.port_policies\" dict complete. To raise an exception in \"clean_by_port\" is excessive, especially when we are going to handle this in the next line.\n\nMy suggestion:\n- Move the info message inside \"clean_by_port\" function, instead of throwing an exception.\n- Remove L277 \"try\" and L280-282. No qos driver extension is going to throw a PortNotFound exception (there is no one inside neutron.plugins.ml2.drivers)\n- Revert the order: \"clean_by_port\" and deletion. If \"qos_driver.delete\" throws an exception, something wrong is happening there but the policy should be deleted from self.policy_map because at this point the service plugin will have deleted the policy from the DB.","commit_id":"e5e7f61fb105da5820b5dfd387fc0e5f051526f7"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"c119a09987fd30e3e8dd5160c8f9ffd1a9adc146","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    def _process_reset_port(self, port):"},{"line_number":277,"context_line":"        try:"},{"line_number":278,"context_line":"            self.qos_driver.delete(port)"},{"line_number":279,"context_line":"            self.policy_map.clean_by_port(port)"},{"line_number":280,"context_line":"        except exceptions.PortNotFound:"},{"line_number":281,"context_line":"            LOG.info(_LI(\"QoS extension did not have information on port %s\"),"},{"line_number":282,"context_line":"                     port[\u0027port_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_5dc1f02d","line":279,"range":{"start_line":279,"start_character":12,"end_line":279,"end_character":47},"in_reply_to":"ffe62b97_7494098c","updated":"2017-03-27 12:20:36.000000000","message":"Done","commit_id":"e5e7f61fb105da5820b5dfd387fc0e5f051526f7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7abb97f90a6f67ab11f71cfc8dc517ab0e9dfc53","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            self.policy_map.clean_by_port(port)"},{"line_number":280,"context_line":"        except exceptions.PortNotFound:"},{"line_number":281,"context_line":"            LOG.info(_LI(\"QoS extension did not have information on port %s\"),"},{"line_number":282,"context_line":"                     port[\u0027port_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_59c94076","line":282,"updated":"2017-03-24 16:44:13.000000000","message":"nit: this probably can be moved to line above","commit_id":"e5e7f61fb105da5820b5dfd387fc0e5f051526f7"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"fc75b3b9351d3cfba1639dc516dda1f8b78271e4","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            self.policy_map.clean_by_port(port)"},{"line_number":280,"context_line":"        except exceptions.PortNotFound:"},{"line_number":281,"context_line":"            LOG.info(_LI(\"QoS extension did not have information on port %s\"),"},{"line_number":282,"context_line":"                     port[\u0027port_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_996c6837","line":282,"in_reply_to":"ffe62b97_59c94076","updated":"2017-03-24 16:46:09.000000000","message":"Line above is 78 characters long I think.","commit_id":"e5e7f61fb105da5820b5dfd387fc0e5f051526f7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6f85bffd5d31e086b30ca432f6bc78e08eba7451","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                    if not port_dict:"},{"line_number":168,"context_line":"                        self._clean_policy_info(qos_policy_id)"},{"line_number":169,"context_line":"                    return"},{"line_number":170,"context_line":"        LOG.info(_LI(\"QoS extension did not have information on port %s\"),"},{"line_number":171,"context_line":"                 port[\u0027port_id\u0027])"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def _clean_policy_info(self, qos_policy_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_5d4b30af","line":170,"range":{"start_line":170,"start_character":8,"end_line":170,"end_character":16},"updated":"2017-03-27 12:23:37.000000000","message":"can you please change this to LOG.debug. Not sure what value the info has here","commit_id":"859c46f4ddb43ecca833202574cda83e76a849a1"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"4b19ed98b2014a4f7488f142645b1a9fe5225a9b","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                    if not port_dict:"},{"line_number":168,"context_line":"                        self._clean_policy_info(qos_policy_id)"},{"line_number":169,"context_line":"                    return"},{"line_number":170,"context_line":"        LOG.info(_LI(\"QoS extension did not have information on port %s\"),"},{"line_number":171,"context_line":"                 port[\u0027port_id\u0027])"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def _clean_policy_info(self, qos_policy_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_000f7b89","line":170,"range":{"start_line":170,"start_character":8,"end_line":170,"end_character":16},"in_reply_to":"ffe62b97_5d4b30af","updated":"2017-03-27 12:40:12.000000000","message":"Done","commit_id":"859c46f4ddb43ecca833202574cda83e76a849a1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"399cd71b6c9db4b7a40bec8dfa1eb08bd512c05d","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                    if not port_dict:"},{"line_number":168,"context_line":"                        self._clean_policy_info(qos_policy_id)"},{"line_number":169,"context_line":"                    return"},{"line_number":170,"context_line":"        LOG.debug(_LI(\"QoS extension did not have information on port %s\"),"},{"line_number":171,"context_line":"                 port_id)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def _clean_policy_info(self, qos_policy_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_56ec2df2","line":170,"range":{"start_line":170,"start_character":17,"end_line":170,"end_character":21},"updated":"2017-03-27 13:11:06.000000000","message":"Remove the translation","commit_id":"d3c8c9b60ec12cde2cda7eb0c25c3ee25fa5ac29"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"e2207c781977704cccfea71edaaa2719d560df53","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                    if not port_dict:"},{"line_number":168,"context_line":"                        self._clean_policy_info(qos_policy_id)"},{"line_number":169,"context_line":"                    return"},{"line_number":170,"context_line":"        LOG.debug(_LI(\"QoS extension did not have information on port %s\"),"},{"line_number":171,"context_line":"                 port_id)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def _clean_policy_info(self, qos_policy_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_2c2f18f7","line":170,"range":{"start_line":170,"start_character":17,"end_line":170,"end_character":21},"in_reply_to":"ffe62b97_56ec2df2","updated":"2017-03-27 13:55:04.000000000","message":"Good spot, Done.","commit_id":"d3c8c9b60ec12cde2cda7eb0c25c3ee25fa5ac29"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"399cd71b6c9db4b7a40bec8dfa1eb08bd512c05d","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                        self._clean_policy_info(qos_policy_id)"},{"line_number":169,"context_line":"                    return"},{"line_number":170,"context_line":"        LOG.debug(_LI(\"QoS extension did not have information on port %s\"),"},{"line_number":171,"context_line":"                 port_id)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def _clean_policy_info(self, qos_policy_id):"},{"line_number":174,"context_line":"        del self.qos_policy_ports[qos_policy_id]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_761cd111","line":171,"updated":"2017-03-27 13:11:06.000000000","message":"I think you need to add a space","commit_id":"d3c8c9b60ec12cde2cda7eb0c25c3ee25fa5ac29"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"e2207c781977704cccfea71edaaa2719d560df53","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                        self._clean_policy_info(qos_policy_id)"},{"line_number":169,"context_line":"                    return"},{"line_number":170,"context_line":"        LOG.debug(_LI(\"QoS extension did not have information on port %s\"),"},{"line_number":171,"context_line":"                 port_id)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def _clean_policy_info(self, qos_policy_id):"},{"line_number":174,"context_line":"        del self.qos_policy_ports[qos_policy_id]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_2c1838d1","line":171,"in_reply_to":"ffe62b97_761cd111","updated":"2017-03-27 13:55:04.000000000","message":"I added it and it threw pep8 complaints, seems fine without it.","commit_id":"d3c8c9b60ec12cde2cda7eb0c25c3ee25fa5ac29"}]}
