)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"05646ef60bbffb3125c8bffe40f1856695cb7654","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Isaku Yamahata \u003cisaku.yamahata@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-24 11:36:45 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"update result before calling network_create_precommit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The values of MTU and AZ aren\u0027t passed to network_create_precommit."},{"line_number":10,"context_line":"Call network_create_precommit after updarting those parameter."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffe62b97_d50b7ed3","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":53},"updated":"2017-03-27 20:05:00.000000000","message":"That\u0027s vague. Should probably be: \u0027Pass MTU and AZ into network_create_precommit\u0027","commit_id":"3421f85c3949d5f0ebd1703ade4031a03b40140b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"99a22ca7c864fc540b6a7221579c514c3fc9a9ed","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Isaku Yamahata \u003cisaku.yamahata@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-24 11:36:45 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"update result before calling network_create_precommit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The values of MTU and AZ aren\u0027t passed to network_create_precommit."},{"line_number":10,"context_line":"Call network_create_precommit after updarting those parameter."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffe62b97_cf5c904c","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":53},"in_reply_to":"ffe62b97_d50b7ed3","updated":"2017-03-30 06:39:45.000000000","message":"+1","commit_id":"3421f85c3949d5f0ebd1703ade4031a03b40140b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"99a22ca7c864fc540b6a7221579c514c3fc9a9ed","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"update result before calling network_create_precommit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The values of MTU and AZ aren\u0027t passed to network_create_precommit."},{"line_number":10,"context_line":"Call network_create_precommit after updarting those parameter."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If966a4158db727091bf2bcc6ba4d48fa9294a96c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffe62b97_4a04ee14","line":9,"range":{"start_line":9,"start_character":66,"end_line":9,"end_character":67},"updated":"2017-03-30 06:39:45.000000000","message":"thus never reach the Mechanism driver.","commit_id":"3421f85c3949d5f0ebd1703ade4031a03b40140b"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"19c90ab29887cf8ce0852aadc233308a01a6a949","unresolved":false,"context_lines":[{"line_number":7,"context_line":"update result before calling network_create_precommit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The values of MTU and AZ aren\u0027t passed to network_create_precommit."},{"line_number":10,"context_line":"Call network_create_precommit after updarting those parameter."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If966a4158db727091bf2bcc6ba4d48fa9294a96c"},{"line_number":13,"context_line":"Closes-Bug: #1675891"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffe62b97_9799a87a","line":10,"range":{"start_line":10,"start_character":36,"end_line":10,"end_character":45},"updated":"2017-03-27 04:14:21.000000000","message":"nit: /s/updarting/updating","commit_id":"3421f85c3949d5f0ebd1703ade4031a03b40140b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"05646ef60bbffb3125c8bffe40f1856695cb7654","unresolved":false,"context_lines":[{"line_number":7,"context_line":"update result before calling network_create_precommit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The values of MTU and AZ aren\u0027t passed to network_create_precommit."},{"line_number":10,"context_line":"Call network_create_precommit after updarting those parameter."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If966a4158db727091bf2bcc6ba4d48fa9294a96c"},{"line_number":13,"context_line":"Closes-Bug: #1675891"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffe62b97_f561e2aa","line":10,"range":{"start_line":10,"start_character":52,"end_line":10,"end_character":61},"updated":"2017-03-27 20:05:00.000000000","message":"parameters","commit_id":"3421f85c3949d5f0ebd1703ade4031a03b40140b"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"279c7aa1005709173250d1291a3c7ca7908e4769","unresolved":false,"context_lines":[{"line_number":773,"context_line":"            mech_context \u003d driver_context.NetworkContext(self, context,"},{"line_number":774,"context_line":"                                                         result)"},{"line_number":775,"context_line":"            self.mechanism_manager.create_network_precommit(mech_context)"},{"line_number":776,"context_line":"            self._apply_dict_extend_functions(\u0027networks\u0027, result, net_db)"},{"line_number":777,"context_line":"        return result, mech_context"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"    @utils.transaction_guard"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_d66a467f","line":776,"updated":"2017-04-05 07:35:36.000000000","message":"should we not be invoking the callback after the extend?","commit_id":"115523cd19304394a250c6c9e09ba73df9b6912b"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"77923de81dbc74578bc94c4e8e226003565bf10b","unresolved":false,"context_lines":[{"line_number":773,"context_line":"            mech_context \u003d driver_context.NetworkContext(self, context,"},{"line_number":774,"context_line":"                                                         result)"},{"line_number":775,"context_line":"            self.mechanism_manager.create_network_precommit(mech_context)"},{"line_number":776,"context_line":"            self._apply_dict_extend_functions(\u0027networks\u0027, result, net_db)"},{"line_number":777,"context_line":"        return result, mech_context"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"    @utils.transaction_guard"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_720d5636","line":776,"in_reply_to":"dfeb2761_d66a467f","updated":"2017-04-05 18:14:13.000000000","message":"it make sense to send the extended network data to mech_driver, i\u0027ll move it.","commit_id":"115523cd19304394a250c6c9e09ba73df9b6912b"}],"neutron/tests/unit/plugins/ml2/test_plugin.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"bf2f0d9443ca84dfd9d07a9f4ea38b3b38870e43","unresolved":false,"context_lines":[{"line_number":2494,"context_line":"                mtu.return_value \u003d 1100"},{"line_number":2495,"context_line":"                with self.network() as network:"},{"line_number":2496,"context_line":"                    self.assertIn(\u0027mtu\u0027, network[\u0027network\u0027])"},{"line_number":2497,"context_line":"        all_args \u003d bmp.call_args_list"},{"line_number":2498,"context_line":"        mech_context \u003d all_args[0][0][0]"},{"line_number":2499,"context_line":"        self.assertEqual(1100, mech_context.__dict__[\u0027_network\u0027][\u0027mtu\u0027])"},{"line_number":2500,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bff0334d_ce7f2f64","line":2497,"range":{"start_line":2497,"start_character":8,"end_line":2497,"end_character":37},"updated":"2017-04-11 13:23:25.000000000","message":"This is out of with-statement for bmp. I think that it\u0027s expected to be before __exit__() of the with-statement is called.","commit_id":"3baa61fa0278e31d8d0cb088f0c0ad47f2d82f7f"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"618e4c7043d07abc8f46bb962768ae38067c00bd","unresolved":false,"context_lines":[{"line_number":2494,"context_line":"                mtu.return_value \u003d 1100"},{"line_number":2495,"context_line":"                with self.network() as network:"},{"line_number":2496,"context_line":"                    self.assertIn(\u0027mtu\u0027, network[\u0027network\u0027])"},{"line_number":2497,"context_line":"        all_args \u003d bmp.call_args_list"},{"line_number":2498,"context_line":"        mech_context \u003d all_args[0][0][0]"},{"line_number":2499,"context_line":"        self.assertEqual(1100, mech_context.__dict__[\u0027_network\u0027][\u0027mtu\u0027])"},{"line_number":2500,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_f2097031","line":2497,"range":{"start_line":2497,"start_character":8,"end_line":2497,"end_character":37},"in_reply_to":"7ffa3b31_526ca407","updated":"2017-04-13 23:05:23.000000000","message":"np, I kept it that, thinking it is not gonna make any difference. thanks for reviews","commit_id":"3baa61fa0278e31d8d0cb088f0c0ad47f2d82f7f"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c4dc32e43f4d64cd5c9abff0f8c374d8b2992757","unresolved":false,"context_lines":[{"line_number":2494,"context_line":"                mtu.return_value \u003d 1100"},{"line_number":2495,"context_line":"                with self.network() as network:"},{"line_number":2496,"context_line":"                    self.assertIn(\u0027mtu\u0027, network[\u0027network\u0027])"},{"line_number":2497,"context_line":"        all_args \u003d bmp.call_args_list"},{"line_number":2498,"context_line":"        mech_context \u003d all_args[0][0][0]"},{"line_number":2499,"context_line":"        self.assertEqual(1100, mech_context.__dict__[\u0027_network\u0027][\u0027mtu\u0027])"},{"line_number":2500,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ff52f3f_aeaa5082","line":2497,"range":{"start_line":2497,"start_character":8,"end_line":2497,"end_character":37},"in_reply_to":"9ff52f3f_2b12c459","updated":"2017-04-13 15:31:57.000000000","message":"even though that\u0027s not gonna make any difference, most of the assertions to check if it called once are outside the transaction in the test code, so i followed the same, i\u0027ll just move it within transaction.","commit_id":"3baa61fa0278e31d8d0cb088f0c0ad47f2d82f7f"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"ad1cc874feaf702c7bf5d596afc5fbe989a1daad","unresolved":false,"context_lines":[{"line_number":2494,"context_line":"                mtu.return_value \u003d 1100"},{"line_number":2495,"context_line":"                with self.network() as network:"},{"line_number":2496,"context_line":"                    self.assertIn(\u0027mtu\u0027, network[\u0027network\u0027])"},{"line_number":2497,"context_line":"        all_args \u003d bmp.call_args_list"},{"line_number":2498,"context_line":"        mech_context \u003d all_args[0][0][0]"},{"line_number":2499,"context_line":"        self.assertEqual(1100, mech_context.__dict__[\u0027_network\u0027][\u0027mtu\u0027])"},{"line_number":2500,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ff52f3f_2b12c459","line":2497,"range":{"start_line":2497,"start_character":8,"end_line":2497,"end_character":37},"in_reply_to":"9ff52f3f_68b7b288","updated":"2017-04-13 07:00:42.000000000","message":"I understand what does this test doing. I didn\u0027t know what does __exit__() of mock.patch.object doing to bmp although you may know. I thought the __exit__() might close, clean or doing something to bmp. I now guess that __exit__() call doesn\u0027t affect bmp and just stops patch baucase I read source code of mock[1].\n\nI just want L2497-2499 to be in \"with mock.patch.object(mech_test.TestMechanismDriver\u0027create_network_precommit\u0027) as bmp:\". Is it difficult for you? It\u0027s just pushing tab-key 3 times.\n\n[1]: https://github.com/testing-cabal/mock/blob/master/mock/mock.py#L1474-L1495","commit_id":"3baa61fa0278e31d8d0cb088f0c0ad47f2d82f7f"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"2dd830519085ddd781896bdc661efd8e8457fab0","unresolved":false,"context_lines":[{"line_number":2494,"context_line":"                mtu.return_value \u003d 1100"},{"line_number":2495,"context_line":"                with self.network() as network:"},{"line_number":2496,"context_line":"                    self.assertIn(\u0027mtu\u0027, network[\u0027network\u0027])"},{"line_number":2497,"context_line":"        all_args \u003d bmp.call_args_list"},{"line_number":2498,"context_line":"        mech_context \u003d all_args[0][0][0]"},{"line_number":2499,"context_line":"        self.assertEqual(1100, mech_context.__dict__[\u0027_network\u0027][\u0027mtu\u0027])"},{"line_number":2500,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_526ca407","line":2497,"range":{"start_line":2497,"start_character":8,"end_line":2497,"end_character":37},"in_reply_to":"9ff52f3f_aeaa5082","updated":"2017-04-13 23:01:02.000000000","message":"In the test_plugin at least, it seems that the check is almost in the transaction. Well, sorry for bothering you","commit_id":"3baa61fa0278e31d8d0cb088f0c0ad47f2d82f7f"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"348c48c405b07cd90ebdc34b82c149d2c5997f73","unresolved":false,"context_lines":[{"line_number":2494,"context_line":"                mtu.return_value \u003d 1100"},{"line_number":2495,"context_line":"                with self.network() as network:"},{"line_number":2496,"context_line":"                    self.assertIn(\u0027mtu\u0027, network[\u0027network\u0027])"},{"line_number":2497,"context_line":"        all_args \u003d bmp.call_args_list"},{"line_number":2498,"context_line":"        mech_context \u003d all_args[0][0][0]"},{"line_number":2499,"context_line":"        self.assertEqual(1100, mech_context.__dict__[\u0027_network\u0027][\u0027mtu\u0027])"},{"line_number":2500,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ff52f3f_68b7b288","line":2497,"range":{"start_line":2497,"start_character":8,"end_line":2497,"end_character":37},"in_reply_to":"9ff52f3f_e82062fa","updated":"2017-04-13 05:53:52.000000000","message":"isn\u0027t it simple enough ?? test case is to check whether precommit call gets mtu data or not which is wrapped inside context object passed to that event. call_args_list is inbuilt to fetch the arguments to function which in this case is just mechcontext.","commit_id":"3baa61fa0278e31d8d0cb088f0c0ad47f2d82f7f"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"acc256dddd36e88a9056169f5d69be6ba85c5312","unresolved":false,"context_lines":[{"line_number":2494,"context_line":"                mtu.return_value \u003d 1100"},{"line_number":2495,"context_line":"                with self.network() as network:"},{"line_number":2496,"context_line":"                    self.assertIn(\u0027mtu\u0027, network[\u0027network\u0027])"},{"line_number":2497,"context_line":"        all_args \u003d bmp.call_args_list"},{"line_number":2498,"context_line":"        mech_context \u003d all_args[0][0][0]"},{"line_number":2499,"context_line":"        self.assertEqual(1100, mech_context.__dict__[\u0027_network\u0027][\u0027mtu\u0027])"},{"line_number":2500,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ff52f3f_e82062fa","line":2497,"range":{"start_line":2497,"start_character":8,"end_line":2497,"end_character":37},"in_reply_to":"bff0334d_9975e4fc","updated":"2017-04-13 05:44:23.000000000","message":"However it actually confused me. I\u0027d like to encourage developers to be meticulous to make the code safer and readable.","commit_id":"3baa61fa0278e31d8d0cb088f0c0ad47f2d82f7f"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a6385a6f1287ab4ea8b8aa837eea3e589a9ad8e6","unresolved":false,"context_lines":[{"line_number":2494,"context_line":"                mtu.return_value \u003d 1100"},{"line_number":2495,"context_line":"                with self.network() as network:"},{"line_number":2496,"context_line":"                    self.assertIn(\u0027mtu\u0027, network[\u0027network\u0027])"},{"line_number":2497,"context_line":"        all_args \u003d bmp.call_args_list"},{"line_number":2498,"context_line":"        mech_context \u003d all_args[0][0][0]"},{"line_number":2499,"context_line":"        self.assertEqual(1100, mech_context.__dict__[\u0027_network\u0027][\u0027mtu\u0027])"},{"line_number":2500,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bff0334d_9975e4fc","line":2497,"range":{"start_line":2497,"start_character":8,"end_line":2497,"end_character":37},"in_reply_to":"bff0334d_ce7f2f64","updated":"2017-04-11 19:46:36.000000000","message":"bmp call is recorded, I am just checking upon the arguments to it, which have context and making sure it has mtu data in it.","commit_id":"3baa61fa0278e31d8d0cb088f0c0ad47f2d82f7f"}]}