)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"ac023fe238b70cf424c69464fb0818a4fcb3594f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the QoS bandwidth limit rule. It will allow the creation"},{"line_number":11,"context_line":"of bandwidth limit rules for either ingress or egress"},{"line_number":12,"context_line":"traffic. For backwards compatibility the default direction"},{"line_number":13,"context_line":"will be egress."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact: Ingress bandwidth limit available for QoS"},{"line_number":16,"context_line":"APIImpact: New type of parameter for QoS rule in neutron API"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"5ff73747_4e975192","line":13,"updated":"2017-04-24 06:07:28.000000000","message":"how an api user can figure out if this is supported for a deployment?  extension doesn\u0027t seem to be enough as it doesn\u0027t say anything about actual drivers being used.\ni guess supported_parameters equiv should be exposed via api, if we extend the api this way.  how do you think?","commit_id":"5183951904b3a272d14df6f3b9440a20fba49067"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"523e257975229b4b5f6dfc1b84d26b56be6fc47f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the QoS bandwidth limit rule. It will allow the creation"},{"line_number":11,"context_line":"of bandwidth limit rules for either ingress or egress"},{"line_number":12,"context_line":"traffic. For backwards compatibility the default direction"},{"line_number":13,"context_line":"will be egress."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact: Ingress bandwidth limit available for QoS"},{"line_number":16,"context_line":"APIImpact: New type of parameter for QoS rule in neutron API"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"5ff73747_5f125db3","line":13,"in_reply_to":"5ff73747_4e975192","updated":"2017-04-24 08:44:33.000000000","message":"currently if existing driver will not support it, user will get error when applying qos-policy with such unsupported parameter to port/network (see https://review.openstack.org/#/c/426946/)\n\nI agree that we should maybe change API to return maybe supported parameters for each rule but I think it should be separate RFE reported for that. I will report it on launchpad soon.","commit_id":"5183951904b3a272d14df6f3b9440a20fba49067"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"5b06a2903263b2a640a7915eb1634bc97d8fadb0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the QoS bandwidth limit rule. It will allow the creation"},{"line_number":11,"context_line":"of bandwidth limit rules for either ingress or egress"},{"line_number":12,"context_line":"traffic. For backwards compatibility the default direction"},{"line_number":13,"context_line":"will be egress."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact: Ingress bandwidth limit available for QoS"},{"line_number":16,"context_line":"APIImpact: New type of parameter for QoS rule in neutron API"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"5ff73747_85b1b4e4","line":13,"in_reply_to":"5ff73747_5f125db3","updated":"2017-04-24 09:33:09.000000000","message":"ok, a separate RFE makes sense.","commit_id":"5183951904b3a272d14df6f3b9440a20fba49067"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"44d05ea91a18c3b344103c782daae4628706a81a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the QoS bandwidth limit rule. It will allow the creation"},{"line_number":11,"context_line":"of bandwidth limit rules for either ingress or egress"},{"line_number":12,"context_line":"traffic. For backwards compatibility the default direction"},{"line_number":13,"context_line":"will be egress."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact: Ingress bandwidth limit available for QoS"},{"line_number":16,"context_line":"APIImpact: New type of parameter for QoS rule in neutron API"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"5ff73747_bbe39005","line":13,"in_reply_to":"5ff73747_85b1b4e4","updated":"2017-04-25 07:37:07.000000000","message":"I made this new RFE: https://bugs.launchpad.net/neutron/+bug/1686035\nIs it fine for You?","commit_id":"5183951904b3a272d14df6f3b9440a20fba49067"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"4dce975be7973cac798e067614c741e9568c3b8c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the QoS bandwidth limit rule. It will allow the creation"},{"line_number":11,"context_line":"of bandwidth limit rules for either ingress or egress"},{"line_number":12,"context_line":"traffic. For backwards compatibility the default direction"},{"line_number":13,"context_line":"will be egress."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact: Ingress bandwidth limit available for QoS"},{"line_number":16,"context_line":"APIImpact: New type of parameter for QoS rule in neutron API"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"5ff73747_07cc63ba","line":13,"in_reply_to":"5ff73747_bbe39005","updated":"2017-04-25 09:28:10.000000000","message":"yes, it looks fine.\nwell, i\u0027m not sure if agree about details but RFE is not about details anyway.","commit_id":"5183951904b3a272d14df6f3b9440a20fba49067"}],"neutron/db/migration/alembic_migrations/versions/pike/expand/2b42d90729da_qos_add_direction_to_bw_limit_rule_table.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"947186d2fc3404885c2bbe8917815a3d3f6119ed","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def expand_drop_exceptions():"},{"line_number":60,"context_line":"    \"\"\""},{"line_number":61,"context_line":"    Drop the existing QoS policy foreign key uniq constraint and then replace"},{"line_number":62,"context_line":"    it with new unique constraint for pair (policy_id, direction)."},{"line_number":63,"context_line":"    \"\"\""},{"line_number":64,"context_line":"    return {"},{"line_number":65,"context_line":"        sa.Constraint: [bw_limit_table_name]"}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_7075d5ca","line":62,"range":{"start_line":61,"start_character":4,"end_line":62,"end_character":66},"updated":"2017-04-10 07:03:57.000000000","message":"Does it really safe for expand to do this?","commit_id":"c7082a71399089defe15c17c4b82bd2457a8905a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bcfe76e28e36f305cc2946da98b0814c6efc4bf0","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def expand_drop_exceptions():"},{"line_number":60,"context_line":"    \"\"\""},{"line_number":61,"context_line":"    Drop the existing QoS policy foreign key uniq constraint and then replace"},{"line_number":62,"context_line":"    it with new unique constraint for pair (policy_id, direction)."},{"line_number":63,"context_line":"    \"\"\""},{"line_number":64,"context_line":"    return {"},{"line_number":65,"context_line":"        sa.Constraint: [bw_limit_table_name]"}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_0bf1b701","line":62,"range":{"start_line":61,"start_character":4,"end_line":62,"end_character":66},"in_reply_to":"bff0334d_7075d5ca","updated":"2017-04-10 10:56:17.000000000","message":"I discussed about that with Ihar and that was his advice in fact :)\nThis foreign key is recreated but without unique constraint in same function so it should be save IMHO","commit_id":"c7082a71399089defe15c17c4b82bd2457a8905a"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"947186d2fc3404885c2bbe8917815a3d3f6119ed","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    it with new unique constraint for pair (policy_id, direction)."},{"line_number":63,"context_line":"    \"\"\""},{"line_number":64,"context_line":"    return {"},{"line_number":65,"context_line":"        sa.Constraint: [bw_limit_table_name]"},{"line_number":66,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_708715b7","line":65,"range":{"start_line":65,"start_character":24,"end_line":65,"end_character":43},"updated":"2017-04-10 07:03:57.000000000","message":"here should be name of the unique constraint - https://github.com/openstack/neutron/blob/master/neutron/db/migration/alembic_migrations/versions/ocata/expand/a9c43481023c_extend_ml2_port_bindings.py#L70","commit_id":"c7082a71399089defe15c17c4b82bd2457a8905a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bcfe76e28e36f305cc2946da98b0814c6efc4bf0","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    it with new unique constraint for pair (policy_id, direction)."},{"line_number":63,"context_line":"    \"\"\""},{"line_number":64,"context_line":"    return {"},{"line_number":65,"context_line":"        sa.Constraint: [bw_limit_table_name]"},{"line_number":66,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_cb998fc4","line":65,"range":{"start_line":65,"start_character":24,"end_line":65,"end_character":43},"in_reply_to":"bff0334d_708715b7","updated":"2017-04-10 10:56:17.000000000","message":"this is already changed and fixed already in PS7","commit_id":"c7082a71399089defe15c17c4b82bd2457a8905a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"eff6138b714522a398fd4575580259cdd8d0949e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                server_default\u003dconstants.EGRESS_DIRECTION,"},{"line_number":52,"context_line":"                                nullable\u003dFalse))"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        op.create_unique_constraint(\u0027unique_rule0direction0policy\u0027,"},{"line_number":55,"context_line":"                                    bw_limit_table_name,"},{"line_number":56,"context_line":"                                    [\u0027qos_policy_id\u0027, \u0027direction\u0027])"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_16dfacd6","line":54,"range":{"start_line":54,"start_character":36,"end_line":54,"end_character":65},"updated":"2017-04-09 09:02:38.000000000","message":"I know this is a nit. In min_bw we are using the following string:\n\nqos_minimum_bandwidth_rules0qos_policy_id0direction\n\nMaybe you can use:\n\nqos_bandwidth_limit_rules0qos_policy_id0direction","commit_id":"fc0898f300f0b559dbecdc6c25ab716ae84fa306"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"37be2d4795c415790df178142494ab94a3912d19","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                server_default\u003dconstants.EGRESS_DIRECTION,"},{"line_number":52,"context_line":"                                nullable\u003dFalse))"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        op.create_unique_constraint(\u0027unique_rule0direction0policy\u0027,"},{"line_number":55,"context_line":"                                    bw_limit_table_name,"},{"line_number":56,"context_line":"                                    [\u0027qos_policy_id\u0027, \u0027direction\u0027])"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_8b48275c","line":54,"range":{"start_line":54,"start_character":36,"end_line":54,"end_character":65},"in_reply_to":"bff0334d_16dfacd6","updated":"2017-04-10 13:15:29.000000000","message":"Done","commit_id":"fc0898f300f0b559dbecdc6c25ab716ae84fa306"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"eff6138b714522a398fd4575580259cdd8d0949e","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        op.create_unique_constraint(\u0027unique_rule0direction0policy\u0027,"},{"line_number":55,"context_line":"                                    bw_limit_table_name,"},{"line_number":56,"context_line":"                                    [\u0027qos_policy_id\u0027, \u0027direction\u0027])"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def expand_drop_exceptions():"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_b6e7e0ac","line":56,"range":{"start_line":56,"start_character":35,"end_line":56,"end_character":66},"updated":"2017-04-09 09:02:38.000000000","message":"In the constrain string you wrote in the following order \"direction\" and then \"policy\". You should mantain the same order.","commit_id":"fc0898f300f0b559dbecdc6c25ab716ae84fa306"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"37be2d4795c415790df178142494ab94a3912d19","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        op.create_unique_constraint(\u0027unique_rule0direction0policy\u0027,"},{"line_number":55,"context_line":"                                    bw_limit_table_name,"},{"line_number":56,"context_line":"                                    [\u0027qos_policy_id\u0027, \u0027direction\u0027])"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def expand_drop_exceptions():"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_4b9d7fba","line":56,"range":{"start_line":56,"start_character":35,"end_line":56,"end_character":66},"in_reply_to":"bff0334d_b6e7e0ac","updated":"2017-04-10 13:15:29.000000000","message":"ok, I will use (qos_policy_id, direction) everywhere","commit_id":"fc0898f300f0b559dbecdc6c25ab716ae84fa306"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"62fb0245f619b5ef130476d171c6dd8ce4dce9d8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                                nullable\u003dFalse))"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        op.create_unique_constraint("},{"line_number":55,"context_line":"            \u0027qos_bandwidth_rules0qos_policy_id0direction\u0027,"},{"line_number":56,"context_line":"            bw_limit_table_name,"},{"line_number":57,"context_line":"            [\u0027qos_policy_id\u0027, \u0027direction\u0027])"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"7ffa3b31_0ce3e3da","line":55,"range":{"start_line":55,"start_character":12,"end_line":55,"end_character":57},"updated":"2017-04-21 09:26:43.000000000","message":"op.f(\u0027qos_bandwidth_rules0qos_policy_id0direction\u0027)","commit_id":"218ba325af3e549c372584ee60c71b25d3bf829b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7aaecad844fbc749126b93ac5d5b87996591b5ff","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                                nullable\u003dFalse))"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        op.create_unique_constraint("},{"line_number":55,"context_line":"            \u0027qos_bandwidth_rules0qos_policy_id0direction\u0027,"},{"line_number":56,"context_line":"            bw_limit_table_name,"},{"line_number":57,"context_line":"            [\u0027qos_policy_id\u0027, \u0027direction\u0027])"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"7ffa3b31_5092994d","line":55,"range":{"start_line":55,"start_character":12,"end_line":55,"end_character":57},"in_reply_to":"7ffa3b31_0ce3e3da","updated":"2017-04-21 13:32:45.000000000","message":"Done","commit_id":"218ba325af3e549c372584ee60c71b25d3bf829b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"9abae8db9de8c5a5f57207ad202e7e6a0f989573","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    \"\"\""},{"line_number":68,"context_line":"    return {"},{"line_number":69,"context_line":"        sa.ForeignKeyConstraint: ["},{"line_number":70,"context_line":"            \"qos_bandwidth_limit_rules_ibfk_1\",  # MySQL name"},{"line_number":71,"context_line":"            \"qos_bandwidth_limit_rules_qos_policy_id_fkey\"  # PGSQL name"},{"line_number":72,"context_line":"        ],"},{"line_number":73,"context_line":"        sa.UniqueConstraint: ["}],"source_content_type":"text/x-python","patch_set":26,"id":"7ffa3b31_2f87b164","line":70,"updated":"2017-04-21 09:38:36.000000000","message":"Would you recommend to do that to be safer?","commit_id":"218ba325af3e549c372584ee60c71b25d3bf829b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"aa162726939ba3d4931da038b9ac5d5f93d70f8d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    \"\"\""},{"line_number":68,"context_line":"    return {"},{"line_number":69,"context_line":"        sa.ForeignKeyConstraint: ["},{"line_number":70,"context_line":"            \"qos_bandwidth_limit_rules_ibfk_1\",  # MySQL name"},{"line_number":71,"context_line":"            \"qos_bandwidth_limit_rules_qos_policy_id_fkey\"  # PGSQL name"},{"line_number":72,"context_line":"        ],"},{"line_number":73,"context_line":"        sa.UniqueConstraint: ["}],"source_content_type":"text/x-python","patch_set":26,"id":"7ffa3b31_c90a8d1e","line":70,"updated":"2017-04-21 08:33:34.000000000","message":"don\u0027t we have some tooling that gets these names automatically?","commit_id":"218ba325af3e549c372584ee60c71b25d3bf829b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7aaecad844fbc749126b93ac5d5b87996591b5ff","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    \"\"\""},{"line_number":68,"context_line":"    return {"},{"line_number":69,"context_line":"        sa.ForeignKeyConstraint: ["},{"line_number":70,"context_line":"            \"qos_bandwidth_limit_rules_ibfk_1\",  # MySQL name"},{"line_number":71,"context_line":"            \"qos_bandwidth_limit_rules_qos_policy_id_fkey\"  # PGSQL name"},{"line_number":72,"context_line":"        ],"},{"line_number":73,"context_line":"        sa.UniqueConstraint: ["}],"source_content_type":"text/x-python","patch_set":26,"id":"7ffa3b31_f0852508","line":70,"in_reply_to":"7ffa3b31_2f92114d","updated":"2017-04-21 13:32:45.000000000","message":"yes, but when I wanted to use this reflection.Inspector to get constraint names (as You wrote above) I had error:\n\n    NameError: Can\u0027t invoke function \u0027get_bind\u0027, as the proxy object has not yet been established for the Alembic \u0027Operations\u0027 class.  Try placing this code inside a callable.\n\nSo I decided that it should be fine to use hardcoded names here as it\u0027s used only in functional tests.\nBut if You know what I did wrong, maybe I can change it with Your help :)","commit_id":"218ba325af3e549c372584ee60c71b25d3bf829b"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"f36852c6f0f4f39e9c072bf989fb2f845576185b","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    \"\"\""},{"line_number":68,"context_line":"    return {"},{"line_number":69,"context_line":"        sa.ForeignKeyConstraint: ["},{"line_number":70,"context_line":"            \"qos_bandwidth_limit_rules_ibfk_1\",  # MySQL name"},{"line_number":71,"context_line":"            \"qos_bandwidth_limit_rules_qos_policy_id_fkey\"  # PGSQL name"},{"line_number":72,"context_line":"        ],"},{"line_number":73,"context_line":"        sa.UniqueConstraint: ["}],"source_content_type":"text/x-python","patch_set":26,"id":"5ff73747_f169628b","line":70,"in_reply_to":"7ffa3b31_3d47ddbe","updated":"2017-04-24 07:07:51.000000000","message":"Thanks!","commit_id":"218ba325af3e549c372584ee60c71b25d3bf829b"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"77bc6852c20d2ed3db5adba0a088d55435680c9f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    \"\"\""},{"line_number":68,"context_line":"    return {"},{"line_number":69,"context_line":"        sa.ForeignKeyConstraint: ["},{"line_number":70,"context_line":"            \"qos_bandwidth_limit_rules_ibfk_1\",  # MySQL name"},{"line_number":71,"context_line":"            \"qos_bandwidth_limit_rules_qos_policy_id_fkey\"  # PGSQL name"},{"line_number":72,"context_line":"        ],"},{"line_number":73,"context_line":"        sa.UniqueConstraint: ["}],"source_content_type":"text/x-python","patch_set":26,"id":"7ffa3b31_2f92114d","line":70,"in_reply_to":"7ffa3b31_6cab8774","updated":"2017-04-21 09:51:20.000000000","message":"Yes, getting name is better practice. Here expand_drop_exceptions needs only for testing(it executed only in functional test_migration), but better not have hardcoded name anyway.\n\nP.S.\nThe same should be applied for unique constraint names.","commit_id":"218ba325af3e549c372584ee60c71b25d3bf829b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0b86eb188cfadf8be85417279d601bd17799698a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    \"\"\""},{"line_number":68,"context_line":"    return {"},{"line_number":69,"context_line":"        sa.ForeignKeyConstraint: ["},{"line_number":70,"context_line":"            \"qos_bandwidth_limit_rules_ibfk_1\",  # MySQL name"},{"line_number":71,"context_line":"            \"qos_bandwidth_limit_rules_qos_policy_id_fkey\"  # PGSQL name"},{"line_number":72,"context_line":"        ],"},{"line_number":73,"context_line":"        sa.UniqueConstraint: ["}],"source_content_type":"text/x-python","patch_set":26,"id":"7ffa3b31_3d47ddbe","line":70,"in_reply_to":"7ffa3b31_bcce5657","updated":"2017-04-21 20:07:08.000000000","message":"bug reported: https://bugs.launchpad.net/neutron/+bug/1685352\n\nTODO note added","commit_id":"218ba325af3e549c372584ee60c71b25d3bf829b"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"62fb0245f619b5ef130476d171c6dd8ce4dce9d8","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    \"\"\""},{"line_number":68,"context_line":"    return {"},{"line_number":69,"context_line":"        sa.ForeignKeyConstraint: ["},{"line_number":70,"context_line":"            \"qos_bandwidth_limit_rules_ibfk_1\",  # MySQL name"},{"line_number":71,"context_line":"            \"qos_bandwidth_limit_rules_qos_policy_id_fkey\"  # PGSQL name"},{"line_number":72,"context_line":"        ],"},{"line_number":73,"context_line":"        sa.UniqueConstraint: ["}],"source_content_type":"text/x-python","patch_set":26,"id":"7ffa3b31_6cab8774","line":70,"in_reply_to":"7ffa3b31_c90a8d1e","updated":"2017-04-21 09:26:43.000000000","message":"If the name was not set during creation, we can get name of the key with \nhttp://docs.sqlalchemy.org/en/latest/core/reflection.html#sqlalchemy.engine.reflection.Inspector.get_foreign_keys\n\nSomething like:\n\n    inspector \u003d reflection.Inspector.from_engine(op.get_bind())\n    fk_names \u003d [i[\u0027name\u0027] for i in inspector.get_foreign_keys(TABLE_NAME)]","commit_id":"218ba325af3e549c372584ee60c71b25d3bf829b"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"ea0cbbeff01323e95fbc9c5347a37b9140740b74","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    \"\"\""},{"line_number":68,"context_line":"    return {"},{"line_number":69,"context_line":"        sa.ForeignKeyConstraint: ["},{"line_number":70,"context_line":"            \"qos_bandwidth_limit_rules_ibfk_1\",  # MySQL name"},{"line_number":71,"context_line":"            \"qos_bandwidth_limit_rules_qos_policy_id_fkey\"  # PGSQL name"},{"line_number":72,"context_line":"        ],"},{"line_number":73,"context_line":"        sa.UniqueConstraint: ["}],"source_content_type":"text/x-python","patch_set":26,"id":"7ffa3b31_bcce5657","line":70,"in_reply_to":"7ffa3b31_f0852508","updated":"2017-04-21 15:25:34.000000000","message":"I guess we need to change test_branches test, so that this will be possible. Could you please file bug about this and add TODO here with mention on that bug?","commit_id":"218ba325af3e549c372584ee60c71b25d3bf829b"}],"neutron/db/qos/models.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6bcf5e9577e9150ceef2f109d5d52f07c8865155","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                                  constants.INGRESS_DIRECTION,"},{"line_number":89,"context_line":"                                  name\u003d\"bandwidth_limit_direction\"),"},{"line_number":90,"context_line":"                          default\u003dconstants.EGRESS_DIRECTION,"},{"line_number":91,"context_line":"                          server_default\u003dconstants.EGRESS_DIRECTION,"},{"line_number":92,"context_line":"                          nullable\u003dFalse)"},{"line_number":93,"context_line":"    __table_args__ \u003d ("},{"line_number":94,"context_line":"        sa.UniqueConstraint(qos_policy_id, direction,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_e51b9718","line":91,"range":{"start_line":91,"start_character":26,"end_line":91,"end_character":39},"updated":"2017-03-27 07:41:33.000000000","message":"this is a value for Albemic migration, not for table creation","commit_id":"14d52825f939fbc4314837c810889b835896ae8a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"48ff90875c8ab8278cbc522d12480a9345215da1","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                                  constants.INGRESS_DIRECTION,"},{"line_number":89,"context_line":"                                  name\u003d\"bandwidth_limit_direction\"),"},{"line_number":90,"context_line":"                          default\u003dconstants.EGRESS_DIRECTION,"},{"line_number":91,"context_line":"                          server_default\u003dconstants.EGRESS_DIRECTION,"},{"line_number":92,"context_line":"                          nullable\u003dFalse)"},{"line_number":93,"context_line":"    __table_args__ \u003d ("},{"line_number":94,"context_line":"        sa.UniqueConstraint(qos_policy_id, direction,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_e8c5ae3d","line":91,"range":{"start_line":91,"start_character":26,"end_line":91,"end_character":39},"in_reply_to":"ffe62b97_e51b9718","updated":"2017-03-27 08:04:28.000000000","message":"If the model definition here doesn\u0027t match with the migration definition, will fail during checks.\n\n\"server_dafult\" is needed to match both definitions.","commit_id":"14d52825f939fbc4314837c810889b835896ae8a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"50b86b5f9d0947fe64306049d1053bc4de81bb94","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                                  constants.INGRESS_DIRECTION,"},{"line_number":89,"context_line":"                                  name\u003d\"bandwidth_limit_direction\"),"},{"line_number":90,"context_line":"                          default\u003dconstants.EGRESS_DIRECTION,"},{"line_number":91,"context_line":"                          server_default\u003dconstants.EGRESS_DIRECTION,"},{"line_number":92,"context_line":"                          nullable\u003dFalse)"},{"line_number":93,"context_line":"    __table_args__ \u003d ("},{"line_number":94,"context_line":"        sa.UniqueConstraint(qos_policy_id, direction,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_e8e48eae","line":91,"range":{"start_line":91,"start_character":26,"end_line":91,"end_character":39},"in_reply_to":"ffe62b97_e8c5ae3d","updated":"2017-03-27 08:07:08.000000000","message":"yep. server_default represents value which is set as default for this column on database\u0027s side.","commit_id":"14d52825f939fbc4314837c810889b835896ae8a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"eff6138b714522a398fd4575580259cdd8d0949e","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                              sa.ForeignKey(\u0027qos_policies.id\u0027,"},{"line_number":80,"context_line":"                                            ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":81,"context_line":"                              nullable\u003dFalse,"},{"line_number":82,"context_line":"                              unique\u003dFalse)"},{"line_number":83,"context_line":"    max_kbps \u003d sa.Column(sa.Integer)"},{"line_number":84,"context_line":"    max_burst_kbps \u003d sa.Column(sa.Integer)"},{"line_number":85,"context_line":"    revises_on_change \u003d (\u0027qos_policy\u0027, )"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_d69b8415","line":82,"updated":"2017-04-09 09:02:38.000000000","message":"By default unique is False. You can skip this.","commit_id":"fc0898f300f0b559dbecdc6c25ab716ae84fa306"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"37be2d4795c415790df178142494ab94a3912d19","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                              sa.ForeignKey(\u0027qos_policies.id\u0027,"},{"line_number":80,"context_line":"                                            ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":81,"context_line":"                              nullable\u003dFalse,"},{"line_number":82,"context_line":"                              unique\u003dFalse)"},{"line_number":83,"context_line":"    max_kbps \u003d sa.Column(sa.Integer)"},{"line_number":84,"context_line":"    max_burst_kbps \u003d sa.Column(sa.Integer)"},{"line_number":85,"context_line":"    revises_on_change \u003d (\u0027qos_policy\u0027, )"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_cbc74f96","line":82,"in_reply_to":"bff0334d_d69b8415","updated":"2017-04-10 13:15:29.000000000","message":"Done","commit_id":"fc0898f300f0b559dbecdc6c25ab716ae84fa306"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"eff6138b714522a398fd4575580259cdd8d0949e","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    qos_policy \u003d sa.orm.relationship(QosPolicy, load_on_pending\u003dTrue)"},{"line_number":87,"context_line":"    direction \u003d sa.Column(sa.Enum(constants.EGRESS_DIRECTION,"},{"line_number":88,"context_line":"                                  constants.INGRESS_DIRECTION,"},{"line_number":89,"context_line":"                                  name\u003d\"bandwidth_limit_direction\"),"},{"line_number":90,"context_line":"                          default\u003dconstants.EGRESS_DIRECTION,"},{"line_number":91,"context_line":"                          server_default\u003dconstants.EGRESS_DIRECTION,"},{"line_number":92,"context_line":"                          nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_768a78bf","line":89,"range":{"start_line":89,"start_character":40,"end_line":89,"end_character":65},"updated":"2017-04-09 09:02:38.000000000","message":"In min_bw, this name is jut \"directions\". I don\u0027t think we should use this specific name for this enum.","commit_id":"fc0898f300f0b559dbecdc6c25ab716ae84fa306"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"37be2d4795c415790df178142494ab94a3912d19","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    qos_policy \u003d sa.orm.relationship(QosPolicy, load_on_pending\u003dTrue)"},{"line_number":87,"context_line":"    direction \u003d sa.Column(sa.Enum(constants.EGRESS_DIRECTION,"},{"line_number":88,"context_line":"                                  constants.INGRESS_DIRECTION,"},{"line_number":89,"context_line":"                                  name\u003d\"bandwidth_limit_direction\"),"},{"line_number":90,"context_line":"                          default\u003dconstants.EGRESS_DIRECTION,"},{"line_number":91,"context_line":"                          server_default\u003dconstants.EGRESS_DIRECTION,"},{"line_number":92,"context_line":"                          nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_8b6b8783","line":89,"range":{"start_line":89,"start_character":40,"end_line":89,"end_character":65},"in_reply_to":"bff0334d_768a78bf","updated":"2017-04-10 13:15:29.000000000","message":"changed","commit_id":"fc0898f300f0b559dbecdc6c25ab716ae84fa306"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"eff6138b714522a398fd4575580259cdd8d0949e","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    direction \u003d sa.Column(sa.Enum(constants.EGRESS_DIRECTION,"},{"line_number":88,"context_line":"                                  constants.INGRESS_DIRECTION,"},{"line_number":89,"context_line":"                                  name\u003d\"bandwidth_limit_direction\"),"},{"line_number":90,"context_line":"                          default\u003dconstants.EGRESS_DIRECTION,"},{"line_number":91,"context_line":"                          server_default\u003dconstants.EGRESS_DIRECTION,"},{"line_number":92,"context_line":"                          nullable\u003dFalse)"},{"line_number":93,"context_line":"    __table_args__ \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_369070ed","line":90,"range":{"start_line":90,"start_character":26,"end_line":90,"end_character":61},"updated":"2017-04-09 09:02:38.000000000","message":"Just a question: are we going to make this parameter optional? I mean, if we put here a \"default\" parameter, that means this parameter could be optional.\n\nI don\u0027t mind having this parameter as optional.","commit_id":"fc0898f300f0b559dbecdc6c25ab716ae84fa306"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"37be2d4795c415790df178142494ab94a3912d19","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    direction \u003d sa.Column(sa.Enum(constants.EGRESS_DIRECTION,"},{"line_number":88,"context_line":"                                  constants.INGRESS_DIRECTION,"},{"line_number":89,"context_line":"                                  name\u003d\"bandwidth_limit_direction\"),"},{"line_number":90,"context_line":"                          default\u003dconstants.EGRESS_DIRECTION,"},{"line_number":91,"context_line":"                          server_default\u003dconstants.EGRESS_DIRECTION,"},{"line_number":92,"context_line":"                          nullable\u003dFalse)"},{"line_number":93,"context_line":"    __table_args__ \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_cb23cf55","line":90,"range":{"start_line":90,"start_character":26,"end_line":90,"end_character":61},"in_reply_to":"bff0334d_369070ed","updated":"2017-04-10 13:15:29.000000000","message":"I thought to make it optional to make it compatible with older releases where it is by default \"egress\"","commit_id":"fc0898f300f0b559dbecdc6c25ab716ae84fa306"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"eff6138b714522a398fd4575580259cdd8d0949e","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                          server_default\u003dconstants.EGRESS_DIRECTION,"},{"line_number":92,"context_line":"                          nullable\u003dFalse)"},{"line_number":93,"context_line":"    __table_args__ \u003d ("},{"line_number":94,"context_line":"        sa.UniqueConstraint(qos_policy_id, direction,"},{"line_number":95,"context_line":"                            name\u003d\"unique_rule0direction0policy\"),"},{"line_number":96,"context_line":"        model_base.BASEV2.__table_args__"},{"line_number":97,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_b69c800e","line":94,"range":{"start_line":94,"start_character":27,"end_line":94,"end_character":53},"updated":"2017-04-09 09:02:38.000000000","message":"Keep the same order as the string name.","commit_id":"fc0898f300f0b559dbecdc6c25ab716ae84fa306"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"37be2d4795c415790df178142494ab94a3912d19","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                          server_default\u003dconstants.EGRESS_DIRECTION,"},{"line_number":92,"context_line":"                          nullable\u003dFalse)"},{"line_number":93,"context_line":"    __table_args__ \u003d ("},{"line_number":94,"context_line":"        sa.UniqueConstraint(qos_policy_id, direction,"},{"line_number":95,"context_line":"                            name\u003d\"unique_rule0direction0policy\"),"},{"line_number":96,"context_line":"        model_base.BASEV2.__table_args__"},{"line_number":97,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_0bdbf74e","line":94,"range":{"start_line":94,"start_character":27,"end_line":94,"end_character":53},"in_reply_to":"bff0334d_b69c800e","updated":"2017-04-10 13:15:29.000000000","message":"name of constraint changed already","commit_id":"fc0898f300f0b559dbecdc6c25ab716ae84fa306"}],"neutron/extensions/qos.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"eff6138b714522a398fd4575580259cdd8d0949e","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                                  \u0027is_visible\u0027: True, \u0027default\u0027: 0,"},{"line_number":90,"context_line":"                                  \u0027validate\u0027: {\u0027type:range\u0027: [0,"},{"line_number":91,"context_line":"                                  common_constants.DB_INTEGER_MAX_VALUE]}},"},{"line_number":92,"context_line":"                              \u0027direction\u0027: {"},{"line_number":93,"context_line":"                                  \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":94,"context_line":"                                  \u0027is_visible\u0027: True,"},{"line_number":95,"context_line":"                                  \u0027default\u0027: common_constants.EGRESS_DIRECTION,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_f6bfa85e","line":92,"updated":"2017-04-09 09:02:38.000000000","message":"If you are increasing the API, you should create a new API file, like \"qos_max_bw_direction\". Is the way to expose the user you modified it. Please, take a look at https://review.openstack.org/#/c/428304/44//COMMIT_MSG\n\nAlso please ping Kevin to confirm that.","commit_id":"fc0898f300f0b559dbecdc6c25ab716ae84fa306"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ebd7ff37d0811cbf62d8afd5736cf989d563b81b","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                                  \u0027is_visible\u0027: True, \u0027default\u0027: 0,"},{"line_number":90,"context_line":"                                  \u0027validate\u0027: {\u0027type:range\u0027: [0,"},{"line_number":91,"context_line":"                                  common_constants.DB_INTEGER_MAX_VALUE]}},"},{"line_number":92,"context_line":"                              \u0027direction\u0027: {"},{"line_number":93,"context_line":"                                  \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":94,"context_line":"                                  \u0027is_visible\u0027: True,"},{"line_number":95,"context_line":"                                  \u0027default\u0027: common_constants.EGRESS_DIRECTION,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_291fce5b","line":92,"in_reply_to":"bff0334d_ebb453d3","updated":"2017-04-10 21:10:14.000000000","message":"Done in PS9","commit_id":"fc0898f300f0b559dbecdc6c25ab716ae84fa306"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"37be2d4795c415790df178142494ab94a3912d19","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                                  \u0027is_visible\u0027: True, \u0027default\u0027: 0,"},{"line_number":90,"context_line":"                                  \u0027validate\u0027: {\u0027type:range\u0027: [0,"},{"line_number":91,"context_line":"                                  common_constants.DB_INTEGER_MAX_VALUE]}},"},{"line_number":92,"context_line":"                              \u0027direction\u0027: {"},{"line_number":93,"context_line":"                                  \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":94,"context_line":"                                  \u0027is_visible\u0027: True,"},{"line_number":95,"context_line":"                                  \u0027default\u0027: common_constants.EGRESS_DIRECTION,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_ebb453d3","line":92,"in_reply_to":"bff0334d_f6bfa85e","updated":"2017-04-10 13:15:29.000000000","message":"ok, I will do it ASAP","commit_id":"fc0898f300f0b559dbecdc6c25ab716ae84fa306"}],"neutron/extensions/qos_bw_limit_direction.py":[{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"e13132cefffc7d282be177b16ee69c5ad637b502","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.api import extensions"},{"line_number":20,"context_line":"from neutron.api.v2 import base"},{"line_number":21,"context_line":"from neutron.api.v2 import resource_helper"},{"line_number":22,"context_line":"from neutron.common import constants as common_constants"},{"line_number":23,"context_line":"from neutron.extensions import qos"},{"line_number":24,"context_line":"from neutron.plugins.common import constants"}],"source_content_type":"text/x-python","patch_set":16,"id":"7ffa3b31_aa4b6485","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":42},"updated":"2017-04-14 11:00:27.000000000","message":"This module isn\u0027t used, it should be removed.","commit_id":"466b182d05c6112897eca2c69922f56f52a6d26e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6ea881e91af5ebf9f43299d10f8038cecf0ce38b","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.api import extensions"},{"line_number":20,"context_line":"from neutron.api.v2 import base"},{"line_number":21,"context_line":"from neutron.api.v2 import resource_helper"},{"line_number":22,"context_line":"from neutron.common import constants as common_constants"},{"line_number":23,"context_line":"from neutron.extensions import qos"},{"line_number":24,"context_line":"from neutron.plugins.common import constants"}],"source_content_type":"text/x-python","patch_set":16,"id":"7ffa3b31_96b68bd9","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":42},"in_reply_to":"7ffa3b31_aa4b6485","updated":"2017-04-14 20:37:26.000000000","message":"it\u0027s removed in next PR","commit_id":"466b182d05c6112897eca2c69922f56f52a6d26e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00b8b4fb19c10cda701c60074da9ceb9c25836c1","unresolved":false,"context_lines":[{"line_number":53,"context_line":"}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class Qos_bw_limit_direction(api_extensions.ExtensionDescriptor):"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @classmethod"},{"line_number":59,"context_line":"    def get_name(cls):"}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_e37c8084","line":56,"range":{"start_line":56,"start_character":5,"end_line":56,"end_character":28},"updated":"2017-04-19 17:39:25.000000000","message":"nit: we don\u0027t usually use _ in class names (CamelCase is more common).","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"218338dc9ee993006b2f43285433138939df7295","unresolved":false,"context_lines":[{"line_number":53,"context_line":"}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class Qos_bw_limit_direction(api_extensions.ExtensionDescriptor):"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @classmethod"},{"line_number":59,"context_line":"    def get_name(cls):"}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_e9fd7e6e","line":56,"range":{"start_line":56,"start_character":5,"end_line":56,"end_character":28},"in_reply_to":"7ffa3b31_e37c8084","updated":"2017-04-20 09:08:51.000000000","message":"But shouldn\u0027t it be named same as extension file? Also please note that similar convention is already done in trunk_details, extra_dhcp_opt (and maybe others).","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"}],"neutron/objects/qos/policy.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"eff6138b714522a398fd4575580259cdd8d0949e","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            names.append(rule_obj_impl.QosBandwidthLimitRule.obj_name())"},{"line_number":244,"context_line":"        if _target_version \u003e\u003d (1, 1):"},{"line_number":245,"context_line":"            names.append(rule_obj_impl.QosDscpMarkingRule.obj_name())"},{"line_number":246,"context_line":"        if _target_version \u003e\u003d (1, 2):"},{"line_number":247,"context_line":"            names.append(rule_obj_impl.QosMinimumBandwidthRule.obj_name())"},{"line_number":248,"context_line":"        if \u0027rules\u0027 in primitive and names:"},{"line_number":249,"context_line":"            primitive[\u0027rules\u0027] \u003d filter_rules(names, primitive[\u0027rules\u0027])"},{"line_number":250,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_b6b5a080","line":247,"range":{"start_line":246,"start_character":0,"end_line":247,"end_character":74},"updated":"2017-04-09 09:02:38.000000000","message":"I know this is a mistake, but is out of scope. Also I\u0027m addressing this change in https://review.openstack.org/454220","commit_id":"fc0898f300f0b559dbecdc6c25ab716ae84fa306"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"37be2d4795c415790df178142494ab94a3912d19","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            names.append(rule_obj_impl.QosBandwidthLimitRule.obj_name())"},{"line_number":244,"context_line":"        if _target_version \u003e\u003d (1, 1):"},{"line_number":245,"context_line":"            names.append(rule_obj_impl.QosDscpMarkingRule.obj_name())"},{"line_number":246,"context_line":"        if _target_version \u003e\u003d (1, 2):"},{"line_number":247,"context_line":"            names.append(rule_obj_impl.QosMinimumBandwidthRule.obj_name())"},{"line_number":248,"context_line":"        if \u0027rules\u0027 in primitive and names:"},{"line_number":249,"context_line":"            primitive[\u0027rules\u0027] \u003d filter_rules(names, primitive[\u0027rules\u0027])"},{"line_number":250,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_2b96bb40","line":247,"range":{"start_line":246,"start_character":0,"end_line":247,"end_character":74},"in_reply_to":"bff0334d_b6b5a080","updated":"2017-04-10 13:15:29.000000000","message":"Do You think that it\u0027s worth to propose it as separate patch (small) and have it in master quickly? If Yes, I will propose such patch ASAP","commit_id":"fc0898f300f0b559dbecdc6c25ab716ae84fa306"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"e13132cefffc7d282be177b16ee69c5ad637b502","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                                          qosport.port_id, policy_id))"},{"line_number":220,"context_line":"        return set(bound_tenants)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":223,"context_line":"        def filter_rules(obj_names, rules):"},{"line_number":224,"context_line":"            return [rule for rule in rules if"},{"line_number":225,"context_line":"                    rule[\u0027versioned_object.name\u0027] in obj_names]"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        def filter_ingress_bandwidth_limit_rules(rules):"},{"line_number":228,"context_line":"            bwlimit_obj_name \u003d rule_obj_impl.QosBandwidthLimitRule.obj_name()"},{"line_number":229,"context_line":"            filtered_rules \u003d []"},{"line_number":230,"context_line":"            for rule in rules:"},{"line_number":231,"context_line":"                if rule[\u0027versioned_object.name\u0027] \u003d\u003d bwlimit_obj_name:"},{"line_number":232,"context_line":"                    direction \u003d rule[\u0027versioned_object.data\u0027].get(\"direction\")"},{"line_number":233,"context_line":"                    if direction \u003d\u003d n_const.EGRESS_DIRECTION:"},{"line_number":234,"context_line":"                        rule[\u0027versioned_object.data\u0027].pop(\u0027direction\u0027)"},{"line_number":235,"context_line":"                        filtered_rules.append(rule)"},{"line_number":236,"context_line":"                else:"},{"line_number":237,"context_line":"                    filtered_rules.append(rule)"},{"line_number":238,"context_line":"            return filtered_rules"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":241,"context_line":"        names \u003d []"},{"line_number":242,"context_line":"        if _target_version \u003e\u003d (1, 0):"},{"line_number":243,"context_line":"            names.append(rule_obj_impl.QosBandwidthLimitRule.obj_name())"},{"line_number":244,"context_line":"        if _target_version \u003e\u003d (1, 1):"},{"line_number":245,"context_line":"            names.append(rule_obj_impl.QosDscpMarkingRule.obj_name())"},{"line_number":246,"context_line":"        if _target_version \u003e\u003d (1, 2):"},{"line_number":247,"context_line":"            names.append(rule_obj_impl.QosMinimumBandwidthRule.obj_name())"},{"line_number":248,"context_line":"        if \u0027rules\u0027 in primitive and names:"},{"line_number":249,"context_line":"            primitive[\u0027rules\u0027] \u003d filter_rules(names, primitive[\u0027rules\u0027])"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        if _target_version \u003c (1, 3):"},{"line_number":252,"context_line":"            standard_fields \u003d [\u0027revision_number\u0027, \u0027created_at\u0027, \u0027updated_at\u0027]"},{"line_number":253,"context_line":"            for f in standard_fields:"},{"line_number":254,"context_line":"                primitive.pop(f)"},{"line_number":255,"context_line":"            if primitive[\u0027description\u0027] is None:"},{"line_number":256,"context_line":"                # description was not nullable before"},{"line_number":257,"context_line":"                raise exception.IncompatibleObjectVersion("},{"line_number":258,"context_line":"                    objver\u003dtarget_version, objname\u003d\u0027QoSPolicy\u0027)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        if _target_version \u003c (1, 4):"},{"line_number":261,"context_line":"            primitive[\u0027tenant_id\u0027] \u003d primitive.pop(\u0027project_id\u0027)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        if _target_version \u003c (1, 5):"},{"line_number":264,"context_line":"            if \u0027rules\u0027 in primitive:"},{"line_number":265,"context_line":"                primitive[\u0027rules\u0027] \u003d filter_ingress_bandwidth_limit_rules("},{"line_number":266,"context_line":"                    primitive[\u0027rules\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"7ffa3b31_cc36cdb5","line":266,"range":{"start_line":222,"start_character":0,"end_line":266,"end_character":39},"updated":"2017-04-14 11:00:27.000000000","message":"Should this patch be rebased on top of https://review.openstack.org/#/c/456637/4 ?","commit_id":"466b182d05c6112897eca2c69922f56f52a6d26e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6ea881e91af5ebf9f43299d10f8038cecf0ce38b","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                                          qosport.port_id, policy_id))"},{"line_number":220,"context_line":"        return set(bound_tenants)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":223,"context_line":"        def filter_rules(obj_names, rules):"},{"line_number":224,"context_line":"            return [rule for rule in rules if"},{"line_number":225,"context_line":"                    rule[\u0027versioned_object.name\u0027] in obj_names]"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        def filter_ingress_bandwidth_limit_rules(rules):"},{"line_number":228,"context_line":"            bwlimit_obj_name \u003d rule_obj_impl.QosBandwidthLimitRule.obj_name()"},{"line_number":229,"context_line":"            filtered_rules \u003d []"},{"line_number":230,"context_line":"            for rule in rules:"},{"line_number":231,"context_line":"                if rule[\u0027versioned_object.name\u0027] \u003d\u003d bwlimit_obj_name:"},{"line_number":232,"context_line":"                    direction \u003d rule[\u0027versioned_object.data\u0027].get(\"direction\")"},{"line_number":233,"context_line":"                    if direction \u003d\u003d n_const.EGRESS_DIRECTION:"},{"line_number":234,"context_line":"                        rule[\u0027versioned_object.data\u0027].pop(\u0027direction\u0027)"},{"line_number":235,"context_line":"                        filtered_rules.append(rule)"},{"line_number":236,"context_line":"                else:"},{"line_number":237,"context_line":"                    filtered_rules.append(rule)"},{"line_number":238,"context_line":"            return filtered_rules"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":241,"context_line":"        names \u003d []"},{"line_number":242,"context_line":"        if _target_version \u003e\u003d (1, 0):"},{"line_number":243,"context_line":"            names.append(rule_obj_impl.QosBandwidthLimitRule.obj_name())"},{"line_number":244,"context_line":"        if _target_version \u003e\u003d (1, 1):"},{"line_number":245,"context_line":"            names.append(rule_obj_impl.QosDscpMarkingRule.obj_name())"},{"line_number":246,"context_line":"        if _target_version \u003e\u003d (1, 2):"},{"line_number":247,"context_line":"            names.append(rule_obj_impl.QosMinimumBandwidthRule.obj_name())"},{"line_number":248,"context_line":"        if \u0027rules\u0027 in primitive and names:"},{"line_number":249,"context_line":"            primitive[\u0027rules\u0027] \u003d filter_rules(names, primitive[\u0027rules\u0027])"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        if _target_version \u003c (1, 3):"},{"line_number":252,"context_line":"            standard_fields \u003d [\u0027revision_number\u0027, \u0027created_at\u0027, \u0027updated_at\u0027]"},{"line_number":253,"context_line":"            for f in standard_fields:"},{"line_number":254,"context_line":"                primitive.pop(f)"},{"line_number":255,"context_line":"            if primitive[\u0027description\u0027] is None:"},{"line_number":256,"context_line":"                # description was not nullable before"},{"line_number":257,"context_line":"                raise exception.IncompatibleObjectVersion("},{"line_number":258,"context_line":"                    objver\u003dtarget_version, objname\u003d\u0027QoSPolicy\u0027)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        if _target_version \u003c (1, 4):"},{"line_number":261,"context_line":"            primitive[\u0027tenant_id\u0027] \u003d primitive.pop(\u0027project_id\u0027)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        if _target_version \u003c (1, 5):"},{"line_number":264,"context_line":"            if \u0027rules\u0027 in primitive:"},{"line_number":265,"context_line":"                primitive[\u0027rules\u0027] \u003d filter_ingress_bandwidth_limit_rules("},{"line_number":266,"context_line":"                    primitive[\u0027rules\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"7ffa3b31_56c80354","line":266,"range":{"start_line":222,"start_character":0,"end_line":266,"end_character":39},"in_reply_to":"7ffa3b31_cc36cdb5","updated":"2017-04-14 20:37:26.000000000","message":"yes, it will be :)","commit_id":"466b182d05c6112897eca2c69922f56f52a6d26e"}],"neutron/objects/qos/rule.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"eff6138b714522a398fd4575580259cdd8d0949e","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":118,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":119,"context_line":"        if _target_version \u003c (1, 3):"},{"line_number":120,"context_line":"            direction \u003d primitive.get(\u0027direction\u0027)"},{"line_number":121,"context_line":"            if direction \u003d\u003d n_const.EGRESS_DIRECTION:"},{"line_number":122,"context_line":"                primitive.pop(\u0027direction\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_d652643b","line":119,"range":{"start_line":119,"start_character":8,"end_line":119,"end_character":35},"updated":"2017-04-09 09:02:38.000000000","message":"if _target_version \u003c (1, 3) and \u0027direction\u0027 in primitive:","commit_id":"fc0898f300f0b559dbecdc6c25ab716ae84fa306"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"37be2d4795c415790df178142494ab94a3912d19","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":118,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":119,"context_line":"        if _target_version \u003c (1, 3):"},{"line_number":120,"context_line":"            direction \u003d primitive.get(\u0027direction\u0027)"},{"line_number":121,"context_line":"            if direction \u003d\u003d n_const.EGRESS_DIRECTION:"},{"line_number":122,"context_line":"                primitive.pop(\u0027direction\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_b76b48b5","line":119,"range":{"start_line":119,"start_character":8,"end_line":119,"end_character":35},"in_reply_to":"bff0334d_d652643b","updated":"2017-04-10 13:15:29.000000000","message":"Done","commit_id":"fc0898f300f0b559dbecdc6c25ab716ae84fa306"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"eff6138b714522a398fd4575580259cdd8d0949e","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":118,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":119,"context_line":"        if _target_version \u003c (1, 3):"},{"line_number":120,"context_line":"            direction \u003d primitive.get(\u0027direction\u0027)"},{"line_number":121,"context_line":"            if direction \u003d\u003d n_const.EGRESS_DIRECTION:"},{"line_number":122,"context_line":"                primitive.pop(\u0027direction\u0027)"},{"line_number":123,"context_line":"            elif direction \u003d\u003d n_const.INGRESS_DIRECTION:"},{"line_number":124,"context_line":"                raise exception.IncompatibleObjectVersion("},{"line_number":125,"context_line":"                    objver\u003dtarget_version,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_167b2cbe","line":122,"range":{"start_line":120,"start_character":0,"end_line":122,"end_character":42},"updated":"2017-04-09 09:02:38.000000000","message":"You can write this in one line:\n\ndirection \u003d primitive.pop(\u0027direction\u0027)\nif direction \u003d\u003d n_const.INGRESS_DIRECTION:\n                raise exception.IncompatibleObjectVersion(\n                    objver\u003dtarget_version,\n                    objtype\u003d\"QosBandwidthLimitRule\")","commit_id":"fc0898f300f0b559dbecdc6c25ab716ae84fa306"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"37be2d4795c415790df178142494ab94a3912d19","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":118,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":119,"context_line":"        if _target_version \u003c (1, 3):"},{"line_number":120,"context_line":"            direction \u003d primitive.get(\u0027direction\u0027)"},{"line_number":121,"context_line":"            if direction \u003d\u003d n_const.EGRESS_DIRECTION:"},{"line_number":122,"context_line":"                primitive.pop(\u0027direction\u0027)"},{"line_number":123,"context_line":"            elif direction \u003d\u003d n_const.INGRESS_DIRECTION:"},{"line_number":124,"context_line":"                raise exception.IncompatibleObjectVersion("},{"line_number":125,"context_line":"                    objver\u003dtarget_version,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_976844b9","line":122,"range":{"start_line":120,"start_character":0,"end_line":122,"end_character":42},"in_reply_to":"bff0334d_167b2cbe","updated":"2017-04-10 13:15:29.000000000","message":"Done","commit_id":"fc0898f300f0b559dbecdc6c25ab716ae84fa306"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"e13132cefffc7d282be177b16ee69c5ad637b502","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    rule_type \u003d qos_consts.RULE_TYPE_BANDWIDTH_LIMIT"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":118,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":119,"context_line":"        if _target_version \u003c (1, 3) and \u0027direction\u0027 in primitive:"},{"line_number":120,"context_line":"            direction \u003d primitive.pop(\u0027direction\u0027)"},{"line_number":121,"context_line":"            if direction \u003d\u003d n_const.INGRESS_DIRECTION:"},{"line_number":122,"context_line":"                raise exception.IncompatibleObjectVersion("},{"line_number":123,"context_line":"                    objver\u003dtarget_version,"},{"line_number":124,"context_line":"                    objtype\u003d\"QosBandwidthLimitRule\")"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"@obj_base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":16,"id":"7ffa3b31_2c477120","line":124,"range":{"start_line":117,"start_character":0,"end_line":124,"end_character":52},"updated":"2017-04-14 11:00:27.000000000","message":"This should be okay to put on top of Ihar\u0027s patch I think, but maybe his feedback on this might be good.","commit_id":"466b182d05c6112897eca2c69922f56f52a6d26e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6ea881e91af5ebf9f43299d10f8038cecf0ce38b","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    rule_type \u003d qos_consts.RULE_TYPE_BANDWIDTH_LIMIT"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":118,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":119,"context_line":"        if _target_version \u003c (1, 3) and \u0027direction\u0027 in primitive:"},{"line_number":120,"context_line":"            direction \u003d primitive.pop(\u0027direction\u0027)"},{"line_number":121,"context_line":"            if direction \u003d\u003d n_const.INGRESS_DIRECTION:"},{"line_number":122,"context_line":"                raise exception.IncompatibleObjectVersion("},{"line_number":123,"context_line":"                    objver\u003dtarget_version,"},{"line_number":124,"context_line":"                    objtype\u003d\"QosBandwidthLimitRule\")"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"@obj_base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":16,"id":"7ffa3b31_b6e627e8","line":124,"range":{"start_line":117,"start_character":0,"end_line":124,"end_character":52},"in_reply_to":"7ffa3b31_2c477120","updated":"2017-04-14 20:37:26.000000000","message":"yes, this will be rebased","commit_id":"466b182d05c6112897eca2c69922f56f52a6d26e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00b8b4fb19c10cda701c60074da9ceb9c25836c1","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    fields \u003d {"},{"line_number":110,"context_line":"        \u0027max_kbps\u0027: obj_fields.IntegerField(nullable\u003dTrue),"},{"line_number":111,"context_line":"        \u0027max_burst_kbps\u0027: obj_fields.IntegerField(nullable\u003dTrue),"},{"line_number":112,"context_line":"        \u0027direction\u0027: common_types.FlowDirectionEnumField()"},{"line_number":113,"context_line":"    }"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    rule_type \u003d qos_consts.RULE_TYPE_BANDWIDTH_LIMIT"}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_a3ad589c","line":112,"updated":"2017-04-19 17:39:25.000000000","message":"add default\u003d here too? Then you may omit it in several unit tests.","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"218338dc9ee993006b2f43285433138939df7295","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    fields \u003d {"},{"line_number":110,"context_line":"        \u0027max_kbps\u0027: obj_fields.IntegerField(nullable\u003dTrue),"},{"line_number":111,"context_line":"        \u0027max_burst_kbps\u0027: obj_fields.IntegerField(nullable\u003dTrue),"},{"line_number":112,"context_line":"        \u0027direction\u0027: common_types.FlowDirectionEnumField()"},{"line_number":113,"context_line":"    }"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    rule_type \u003d qos_consts.RULE_TYPE_BANDWIDTH_LIMIT"}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_29648649","line":112,"in_reply_to":"7ffa3b31_a3ad589c","updated":"2017-04-20 09:08:51.000000000","message":"Done","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"}],"neutron/services/qos/drivers/openvswitch/driver.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"c89d22f327cfaac0b5859f1d73dc73c1a4c5d53b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            \u0027type:range\u0027: [0, constants.DB_INTEGER_MAX_VALUE]},"},{"line_number":31,"context_line":"        qos_consts.MAX_BURST: {"},{"line_number":32,"context_line":"            \u0027type:range\u0027: [0, constants.DB_INTEGER_MAX_VALUE]},"},{"line_number":33,"context_line":"        qos_consts.DIRECTION: {"},{"line_number":34,"context_line":"            \u0027type:values\u0027: [constants.EGRESS_DIRECTION]}"},{"line_number":35,"context_line":"    },"},{"line_number":36,"context_line":"    qos_consts.RULE_TYPE_DSCP_MARKING: {"},{"line_number":37,"context_line":"        qos_consts.DSCP_MARK: {\u0027type:values\u0027: constants.VALID_DSCP_MARKS}"}],"source_content_type":"text/x-python","patch_set":29,"id":"5ff73747_c7dafbe7","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":56},"updated":"2017-04-25 09:47:59.000000000","message":"this needs to be added to all out of tree drivers which support RULE_TYPE_BANDWIDTH_LIMIT?","commit_id":"5183951904b3a272d14df6f3b9440a20fba49067"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"67e09348b95b3882aa96eaa44a163dc639d49b0b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            \u0027type:range\u0027: [0, constants.DB_INTEGER_MAX_VALUE]},"},{"line_number":31,"context_line":"        qos_consts.MAX_BURST: {"},{"line_number":32,"context_line":"            \u0027type:range\u0027: [0, constants.DB_INTEGER_MAX_VALUE]},"},{"line_number":33,"context_line":"        qos_consts.DIRECTION: {"},{"line_number":34,"context_line":"            \u0027type:values\u0027: [constants.EGRESS_DIRECTION]}"},{"line_number":35,"context_line":"    },"},{"line_number":36,"context_line":"    qos_consts.RULE_TYPE_DSCP_MARKING: {"},{"line_number":37,"context_line":"        qos_consts.DSCP_MARK: {\u0027type:values\u0027: constants.VALID_DSCP_MARKS}"}],"source_content_type":"text/x-python","patch_set":29,"id":"5ff73747_b884ad5f","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":56},"in_reply_to":"5ff73747_428a591b","updated":"2017-04-25 11:40:58.000000000","message":"yes, it will be like that if there will be added key \"qos_const.DIRECTION\" without \"egress\" value as supported.\nBut as I checked now in code https://github.com/openstack/neutron/blob/master/neutron/services/qos/drivers/base.py#L71 it looks that if there is no key at all then validation will pass. Maybe that is different bug which I made in validation rules and it should be reported on launchpad also - I will talk about it on today\u0027s QoS meeting also","commit_id":"5183951904b3a272d14df6f3b9440a20fba49067"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"057ec719d2670780e9b7fb79bc5cb27a6514f799","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            \u0027type:range\u0027: [0, constants.DB_INTEGER_MAX_VALUE]},"},{"line_number":31,"context_line":"        qos_consts.MAX_BURST: {"},{"line_number":32,"context_line":"            \u0027type:range\u0027: [0, constants.DB_INTEGER_MAX_VALUE]},"},{"line_number":33,"context_line":"        qos_consts.DIRECTION: {"},{"line_number":34,"context_line":"            \u0027type:values\u0027: [constants.EGRESS_DIRECTION]}"},{"line_number":35,"context_line":"    },"},{"line_number":36,"context_line":"    qos_consts.RULE_TYPE_DSCP_MARKING: {"},{"line_number":37,"context_line":"        qos_consts.DSCP_MARK: {\u0027type:values\u0027: constants.VALID_DSCP_MARKS}"}],"source_content_type":"text/x-python","patch_set":29,"id":"5ff73747_5b5c687d","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":56},"in_reply_to":"5ff73747_b2e6f843","updated":"2017-04-26 01:47:23.000000000","message":"my suggestion is to add it to every out of tree qos drivers before landing this patch.  there are not too many of them.\n\nalso, a heads-up might be nice for possible non-public drivers.","commit_id":"5183951904b3a272d14df6f3b9440a20fba49067"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"5d1356933c4df2857c48016f51f4b09966bde8ab","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            \u0027type:range\u0027: [0, constants.DB_INTEGER_MAX_VALUE]},"},{"line_number":31,"context_line":"        qos_consts.MAX_BURST: {"},{"line_number":32,"context_line":"            \u0027type:range\u0027: [0, constants.DB_INTEGER_MAX_VALUE]},"},{"line_number":33,"context_line":"        qos_consts.DIRECTION: {"},{"line_number":34,"context_line":"            \u0027type:values\u0027: [constants.EGRESS_DIRECTION]}"},{"line_number":35,"context_line":"    },"},{"line_number":36,"context_line":"    qos_consts.RULE_TYPE_DSCP_MARKING: {"},{"line_number":37,"context_line":"        qos_consts.DSCP_MARK: {\u0027type:values\u0027: constants.VALID_DSCP_MARKS}"}],"source_content_type":"text/x-python","patch_set":29,"id":"5ff73747_f8da3515","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":56},"in_reply_to":"5ff73747_b884ad5f","updated":"2017-04-25 11:51:47.000000000","message":"i guess the validation code was done that way for compatibility reasons.  (supported_rules used to be a list)\n\nanyway, i want to avoid the situation where api users can configure rules which is ignored by the backend.","commit_id":"5183951904b3a272d14df6f3b9440a20fba49067"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d47aab661e83532a92e31fc5f89eef8986bd5de6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            \u0027type:range\u0027: [0, constants.DB_INTEGER_MAX_VALUE]},"},{"line_number":31,"context_line":"        qos_consts.MAX_BURST: {"},{"line_number":32,"context_line":"            \u0027type:range\u0027: [0, constants.DB_INTEGER_MAX_VALUE]},"},{"line_number":33,"context_line":"        qos_consts.DIRECTION: {"},{"line_number":34,"context_line":"            \u0027type:values\u0027: [constants.EGRESS_DIRECTION]}"},{"line_number":35,"context_line":"    },"},{"line_number":36,"context_line":"    qos_consts.RULE_TYPE_DSCP_MARKING: {"},{"line_number":37,"context_line":"        qos_consts.DSCP_MARK: {\u0027type:values\u0027: constants.VALID_DSCP_MARKS}"}],"source_content_type":"text/x-python","patch_set":29,"id":"5ff73747_e22605b8","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":56},"in_reply_to":"5ff73747_c7dafbe7","updated":"2017-04-25 09:54:49.000000000","message":"if it will be not added to driver than is_rule_supported() method will not check it at all:\nhttps://github.com/openstack/neutron/blob/master/neutron/services/qos/drivers/base.py#L71","commit_id":"5183951904b3a272d14df6f3b9440a20fba49067"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"190e1a3d3604b6f4946f027c23b231fc7b39cb01","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            \u0027type:range\u0027: [0, constants.DB_INTEGER_MAX_VALUE]},"},{"line_number":31,"context_line":"        qos_consts.MAX_BURST: {"},{"line_number":32,"context_line":"            \u0027type:range\u0027: [0, constants.DB_INTEGER_MAX_VALUE]},"},{"line_number":33,"context_line":"        qos_consts.DIRECTION: {"},{"line_number":34,"context_line":"            \u0027type:values\u0027: [constants.EGRESS_DIRECTION]}"},{"line_number":35,"context_line":"    },"},{"line_number":36,"context_line":"    qos_consts.RULE_TYPE_DSCP_MARKING: {"},{"line_number":37,"context_line":"        qos_consts.DSCP_MARK: {\u0027type:values\u0027: constants.VALID_DSCP_MARKS}"}],"source_content_type":"text/x-python","patch_set":29,"id":"5ff73747_428a591b","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":56},"in_reply_to":"5ff73747_e22605b8","updated":"2017-04-25 10:09:38.000000000","message":"in an earlier comment you said \"currently if existing driver will not support it, user will get error when applying qos-policy with such unsupported parameter to port/network\".\nto make it work, this needs to be added to those drivers. right?","commit_id":"5183951904b3a272d14df6f3b9440a20fba49067"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0e2a23a364880a8bd6cc2a1e8856e62aa903e34b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            \u0027type:range\u0027: [0, constants.DB_INTEGER_MAX_VALUE]},"},{"line_number":31,"context_line":"        qos_consts.MAX_BURST: {"},{"line_number":32,"context_line":"            \u0027type:range\u0027: [0, constants.DB_INTEGER_MAX_VALUE]},"},{"line_number":33,"context_line":"        qos_consts.DIRECTION: {"},{"line_number":34,"context_line":"            \u0027type:values\u0027: [constants.EGRESS_DIRECTION]}"},{"line_number":35,"context_line":"    },"},{"line_number":36,"context_line":"    qos_consts.RULE_TYPE_DSCP_MARKING: {"},{"line_number":37,"context_line":"        qos_consts.DSCP_MARK: {\u0027type:values\u0027: constants.VALID_DSCP_MARKS}"}],"source_content_type":"text/x-python","patch_set":29,"id":"5ff73747_b2e6f843","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":56},"in_reply_to":"5ff73747_f8da3515","updated":"2017-04-25 19:45:49.000000000","message":"so what I should do now in Your opinion?","commit_id":"5183951904b3a272d14df6f3b9440a20fba49067"}],"neutron/services/qos/qos_plugin.py":[{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"e13132cefffc7d282be177b16ee69c5ad637b502","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def __init__(self):"},{"line_number":41,"context_line":"        super(QoSPlugin, self).__init__()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        # TODO(mangelajo): remove notification_driver_manager in Pike"},{"line_number":44,"context_line":"        self.notification_driver_manager \u003d ("},{"line_number":45,"context_line":"            driver_mgr.QosServiceNotificationDriverManager())"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        self.driver_manager \u003d manager.QosServiceDriverManager(enable_rpc\u003d("},{"line_number":48,"context_line":"                self.notification_driver_manager.has_message_queue_driver))"}],"source_content_type":"text/x-python","patch_set":16,"id":"7ffa3b31_6c13390f","line":45,"range":{"start_line":43,"start_character":0,"end_line":45,"end_character":61},"updated":"2017-04-14 11:00:27.000000000","message":"Also rebase on top of this patch: https://review.openstack.org/#/c/441177/\nBoth seem close to merging so it may save future rebasing.","commit_id":"466b182d05c6112897eca2c69922f56f52a6d26e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6ea881e91af5ebf9f43299d10f8038cecf0ce38b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def __init__(self):"},{"line_number":41,"context_line":"        super(QoSPlugin, self).__init__()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        # TODO(mangelajo): remove notification_driver_manager in Pike"},{"line_number":44,"context_line":"        self.notification_driver_manager \u003d ("},{"line_number":45,"context_line":"            driver_mgr.QosServiceNotificationDriverManager())"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        self.driver_manager \u003d manager.QosServiceDriverManager(enable_rpc\u003d("},{"line_number":48,"context_line":"                self.notification_driver_manager.has_message_queue_driver))"}],"source_content_type":"text/x-python","patch_set":16,"id":"7ffa3b31_96eb2baf","line":45,"range":{"start_line":43,"start_character":0,"end_line":45,"end_character":61},"in_reply_to":"7ffa3b31_6c13390f","updated":"2017-04-14 20:37:26.000000000","message":"ok","commit_id":"466b182d05c6112897eca2c69922f56f52a6d26e"}],"neutron/tests/tempest/api/base.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6bcf5e9577e9150ceef2f109d5d52f07c8865155","unresolved":false,"context_lines":[{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    @classmethod"},{"line_number":377,"context_line":"    def create_qos_bandwidth_limit_rule(cls, policy_id, max_kbps,"},{"line_number":378,"context_line":"                                        max_burst_kbps, direction\u003dNone):"},{"line_number":379,"context_line":"        \"\"\"Wrapper utility that returns a test QoS bandwidth limit rule.\"\"\""},{"line_number":380,"context_line":"        body \u003d cls.admin_client.create_bandwidth_limit_rule("},{"line_number":381,"context_line":"            policy_id, max_kbps, max_burst_kbps, direction)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_a5a10fac","line":378,"range":{"start_line":378,"start_character":66,"end_line":378,"end_character":69},"updated":"2017-03-27 07:41:33.000000000","message":"Can this be egress instead of None ?","commit_id":"14d52825f939fbc4314837c810889b835896ae8a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fb57a29c55eb4aaff2ad30aa27e6a7565f84d04e","unresolved":false,"context_lines":[{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    @classmethod"},{"line_number":377,"context_line":"    def create_qos_bandwidth_limit_rule(cls, policy_id, max_kbps,"},{"line_number":378,"context_line":"                                        max_burst_kbps, direction\u003dNone):"},{"line_number":379,"context_line":"        \"\"\"Wrapper utility that returns a test QoS bandwidth limit rule.\"\"\""},{"line_number":380,"context_line":"        body \u003d cls.admin_client.create_bandwidth_limit_rule("},{"line_number":381,"context_line":"            policy_id, max_kbps, max_burst_kbps, direction)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_14fbbac0","line":378,"range":{"start_line":378,"start_character":66,"end_line":378,"end_character":69},"in_reply_to":"ffe62b97_a5a10fac","updated":"2017-03-29 21:10:00.000000000","message":"I think it can be :)","commit_id":"14d52825f939fbc4314837c810889b835896ae8a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00b8b4fb19c10cda701c60074da9ceb9c25836c1","unresolved":false,"context_lines":[{"line_number":376,"context_line":"    @classmethod"},{"line_number":377,"context_line":"    def create_qos_bandwidth_limit_rule(cls, policy_id, max_kbps,"},{"line_number":378,"context_line":"                                        max_burst_kbps,"},{"line_number":379,"context_line":"                                        direction\u003dconstants.EGRESS_DIRECTION):"},{"line_number":380,"context_line":"        \"\"\"Wrapper utility that returns a test QoS bandwidth limit rule.\"\"\""},{"line_number":381,"context_line":"        body \u003d cls.admin_client.create_bandwidth_limit_rule("},{"line_number":382,"context_line":"            policy_id, max_kbps, max_burst_kbps, direction)"}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_438fb474","line":379,"updated":"2017-04-19 17:39:25.000000000","message":"you may want to have a test that checks that no direction set \u003d\u003d EGRESS, and with the change, you can\u0027t do it.","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"218338dc9ee993006b2f43285433138939df7295","unresolved":false,"context_lines":[{"line_number":376,"context_line":"    @classmethod"},{"line_number":377,"context_line":"    def create_qos_bandwidth_limit_rule(cls, policy_id, max_kbps,"},{"line_number":378,"context_line":"                                        max_burst_kbps,"},{"line_number":379,"context_line":"                                        direction\u003dconstants.EGRESS_DIRECTION):"},{"line_number":380,"context_line":"        \"\"\"Wrapper utility that returns a test QoS bandwidth limit rule.\"\"\""},{"line_number":381,"context_line":"        body \u003d cls.admin_client.create_bandwidth_limit_rule("},{"line_number":382,"context_line":"            policy_id, max_kbps, max_burst_kbps, direction)"}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_89d95af4","line":379,"in_reply_to":"7ffa3b31_438fb474","updated":"2017-04-20 09:08:51.000000000","message":"I can pass None as direction and then admin_client.create_bandwidth_limit_rule should not pass it to server","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"}],"neutron/tests/tempest/api/test_qos.py":[{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"e13132cefffc7d282be177b16ee69c5ad637b502","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":389,"context_line":"                                        description\u003d\u0027test policy\u0027,"},{"line_number":390,"context_line":"                                        shared\u003dFalse)"},{"line_number":391,"context_line":"        rule \u003d self.create_qos_bandwidth_limit_rule("},{"line_number":392,"context_line":"            policy_id\u003dpolicy[\u0027id\u0027],"},{"line_number":393,"context_line":"            max_kbps\u003d200,"},{"line_number":394,"context_line":"            max_burst_kbps\u003d1337,"}],"source_content_type":"text/x-python","patch_set":16,"id":"7ffa3b31_0f1ca768","line":391,"range":{"start_line":391,"start_character":20,"end_line":391,"end_character":51},"updated":"2017-04-14 11:00:27.000000000","message":"This function needs to be modified in neutron/tests/tempest/api/base to accept \u0027direction\u0027 as a parameter.","commit_id":"466b182d05c6112897eca2c69922f56f52a6d26e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6ea881e91af5ebf9f43299d10f8038cecf0ce38b","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":389,"context_line":"                                        description\u003d\u0027test policy\u0027,"},{"line_number":390,"context_line":"                                        shared\u003dFalse)"},{"line_number":391,"context_line":"        rule \u003d self.create_qos_bandwidth_limit_rule("},{"line_number":392,"context_line":"            policy_id\u003dpolicy[\u0027id\u0027],"},{"line_number":393,"context_line":"            max_kbps\u003d200,"},{"line_number":394,"context_line":"            max_burst_kbps\u003d1337,"}],"source_content_type":"text/x-python","patch_set":16,"id":"7ffa3b31_f605cf7b","line":391,"range":{"start_line":391,"start_character":20,"end_line":391,"end_character":51},"in_reply_to":"7ffa3b31_0f1ca768","updated":"2017-04-14 20:37:26.000000000","message":"it is already modified, no?","commit_id":"466b182d05c6112897eca2c69922f56f52a6d26e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00b8b4fb19c10cda701c60074da9ceb9c25836c1","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    ]"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    @classmethod"},{"line_number":374,"context_line":"    @test.requires_ext(extension\u003d\"qos\", service\u003d\"network\")"},{"line_number":375,"context_line":"    @base.require_qos_rule_type(qos_consts.RULE_TYPE_BANDWIDTH_LIMIT)"},{"line_number":376,"context_line":"    def resource_setup(cls):"},{"line_number":377,"context_line":"        super(QosBandwidthLimitRuleTestJSON, cls).resource_setup()"}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_63c4f091","line":374,"updated":"2017-04-19 17:39:25.000000000","message":"don\u0027t you need to depend on the new extension here?","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"218338dc9ee993006b2f43285433138939df7295","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    ]"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    @classmethod"},{"line_number":374,"context_line":"    @test.requires_ext(extension\u003d\"qos\", service\u003d\"network\")"},{"line_number":375,"context_line":"    @base.require_qos_rule_type(qos_consts.RULE_TYPE_BANDWIDTH_LIMIT)"},{"line_number":376,"context_line":"    def resource_setup(cls):"},{"line_number":377,"context_line":"        super(QosBandwidthLimitRuleTestJSON, cls).resource_setup()"}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_49a6b255","line":374,"in_reply_to":"7ffa3b31_63c4f091","updated":"2017-04-20 09:08:51.000000000","message":"this one no because it\u0027s class with tests for QoS policy, but below there is class for bandwidth limit tests and it should depend on new extension.\nI added it now.","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00b8b4fb19c10cda701c60074da9ceb9c25836c1","unresolved":false,"context_lines":[{"line_number":544,"context_line":"        rules_ids \u003d [r[\u0027id\u0027] for r in rules]"},{"line_number":545,"context_line":"        self.assertIn(rule1[\u0027id\u0027], rules_ids)"},{"line_number":546,"context_line":"        self.assertNotIn(rule2[\u0027id\u0027], rules_ids)"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"class RbacSharedQosPoliciesTest(base.BaseAdminNetworkTest):"},{"line_number":550,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_03d40c47","line":547,"updated":"2017-04-19 17:39:25.000000000","message":"you now don\u0027t have a single test case that would create a rule without direction attribute specified. Maybe that should be another set of scenarios.","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"218338dc9ee993006b2f43285433138939df7295","unresolved":false,"context_lines":[{"line_number":544,"context_line":"        rules_ids \u003d [r[\u0027id\u0027] for r in rules]"},{"line_number":545,"context_line":"        self.assertIn(rule1[\u0027id\u0027], rules_ids)"},{"line_number":546,"context_line":"        self.assertNotIn(rule2[\u0027id\u0027], rules_ids)"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"class RbacSharedQosPoliciesTest(base.BaseAdminNetworkTest):"},{"line_number":550,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_697e0eb0","line":547,"in_reply_to":"7ffa3b31_03d40c47","updated":"2017-04-20 09:08:51.000000000","message":"I added such scenario","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"041bba538128a17b5e01b802edd4c6ce091c1408","unresolved":false,"context_lines":[{"line_number":390,"context_line":"            return None"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    @decorators.idempotent_id(\u00278a59b00b-3e9c-4787-92f8-93a5cdf5e378\u0027)"},{"line_number":393,"context_line":"    def test_rule_create(self):"},{"line_number":394,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":395,"context_line":"                                        description\u003d\u0027test policy\u0027,"},{"line_number":396,"context_line":"                                        shared\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":29,"id":"5ff73747_b344991c","line":393,"updated":"2017-04-26 16:58:36.000000000","message":"this test case was once executed for implementations that haven\u0027t implemented qos-bw-limit-direction extension, but not anymore. Isn\u0027t it a problem? Same concern for other test cases in the class that don\u0027t seem to be direction specific.","commit_id":"5183951904b3a272d14df6f3b9440a20fba49067"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9bd243841916c0e58e3959fd16be96911a4dd4ab","unresolved":false,"context_lines":[{"line_number":390,"context_line":"            return None"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    @decorators.idempotent_id(\u00278a59b00b-3e9c-4787-92f8-93a5cdf5e378\u0027)"},{"line_number":393,"context_line":"    def test_rule_create(self):"},{"line_number":394,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":395,"context_line":"                                        description\u003d\u0027test policy\u0027,"},{"line_number":396,"context_line":"                                        shared\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":29,"id":"5ff73747_fe0bef79","line":393,"in_reply_to":"5ff73747_b344991c","updated":"2017-04-27 10:35:11.000000000","message":"I divided it into two separate classes and only one of them require this new extension. Second one will run with \"direction\u003dNone\" so It will not send direction attribute to neutron-server.\nIs it better for You?","commit_id":"5183951904b3a272d14df6f3b9440a20fba49067"}],"neutron/tests/tempest/services/network/json/network_client.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00b8b4fb19c10cda701c60074da9ceb9c25836c1","unresolved":false,"context_lines":[{"line_number":587,"context_line":"                \u0027max_burst_kbps\u0027: max_burst_kbps"},{"line_number":588,"context_line":"            }"},{"line_number":589,"context_line":"        }"},{"line_number":590,"context_line":"        if direction:"},{"line_number":591,"context_line":"            post_data[\u0027bandwidth_limit_rule\u0027][\u0027direction\u0027] \u003d direction"},{"line_number":592,"context_line":"        resp, body \u003d self.post(uri, self.serialize(post_data))"},{"line_number":593,"context_line":"        self.expected_success(201, resp.status)"}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_a3431813","line":590,"updated":"2017-04-19 17:39:25.000000000","message":"it\u0027s not clear where the None case is actually used in the tree.","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"218338dc9ee993006b2f43285433138939df7295","unresolved":false,"context_lines":[{"line_number":587,"context_line":"                \u0027max_burst_kbps\u0027: max_burst_kbps"},{"line_number":588,"context_line":"            }"},{"line_number":589,"context_line":"        }"},{"line_number":590,"context_line":"        if direction:"},{"line_number":591,"context_line":"            post_data[\u0027bandwidth_limit_rule\u0027][\u0027direction\u0027] \u003d direction"},{"line_number":592,"context_line":"        resp, body \u003d self.post(uri, self.serialize(post_data))"},{"line_number":593,"context_line":"        self.expected_success(201, resp.status)"}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_24394ba3","line":590,"in_reply_to":"7ffa3b31_a3431813","updated":"2017-04-20 09:08:51.000000000","message":"I\u0027m passing direction\u003dNone in neutron/tests/tempest/api/test_qos.py in \"default\" scenario","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"}],"neutron/tests/unit/objects/qos/test_policy.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00b8b4fb19c10cda701c60074da9ceb9c25836c1","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        return self.objs[0]"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def _create_test_policy_with_rules(self, rule_type, reload_rules\u003dFalse,"},{"line_number":137,"context_line":"                                       rule_direction\u003dNone):"},{"line_number":138,"context_line":"        policy_obj \u003d self._create_test_policy()"},{"line_number":139,"context_line":"        rules \u003d []"},{"line_number":140,"context_line":"        for obj_cls in (RULE_OBJ_CLS.get(rule_type)"}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_6349902f","line":137,"range":{"start_line":137,"start_character":39,"end_line":137,"end_character":53},"updated":"2017-04-19 17:39:25.000000000","message":"maybe bwlimit_direction?","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"218338dc9ee993006b2f43285433138939df7295","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        return self.objs[0]"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def _create_test_policy_with_rules(self, rule_type, reload_rules\u003dFalse,"},{"line_number":137,"context_line":"                                       rule_direction\u003dNone):"},{"line_number":138,"context_line":"        policy_obj \u003d self._create_test_policy()"},{"line_number":139,"context_line":"        rules \u003d []"},{"line_number":140,"context_line":"        for obj_cls in (RULE_OBJ_CLS.get(rule_type)"}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_84e5bf0b","line":137,"range":{"start_line":137,"start_character":39,"end_line":137,"end_character":53},"in_reply_to":"7ffa3b31_6349902f","updated":"2017-04-20 09:08:51.000000000","message":"good idea, changed. Thx","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00b8b4fb19c10cda701c60074da9ceb9c25836c1","unresolved":false,"context_lines":[{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        policy_obj_v1_0 \u003d self._policy_through_version(policy_obj, \u00271.0\u0027)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        # NOTE(slaweq): Bandwidth limit rule in version \u003c 1.5 hasn\u0027t got"},{"line_number":412,"context_line":"        # direction field and it is not same rule as was created and it can\u0027t"},{"line_number":413,"context_line":"        # be compared with assertIn. Because of that required is to check if"},{"line_number":414,"context_line":"        # bandwidth_limit rule type is in policy rules"}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_23682885","line":411,"updated":"2017-04-19 17:39:25.000000000","message":"you could just copy.copy the dict, then pop direction from it, and use the result for comparison. In that way, you would make sure that other fields are there, and intact.","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"218338dc9ee993006b2f43285433138939df7295","unresolved":false,"context_lines":[{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        policy_obj_v1_0 \u003d self._policy_through_version(policy_obj, \u00271.0\u0027)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        # NOTE(slaweq): Bandwidth limit rule in version \u003c 1.5 hasn\u0027t got"},{"line_number":412,"context_line":"        # direction field and it is not same rule as was created and it can\u0027t"},{"line_number":413,"context_line":"        # be compared with assertIn. Because of that required is to check if"},{"line_number":414,"context_line":"        # bandwidth_limit rule type is in policy rules"}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_a6c31538","line":411,"in_reply_to":"7ffa3b31_23682885","updated":"2017-04-20 09:08:51.000000000","message":"After I set default\u003d\"egress\" in https://review.openstack.org/#/c/449831/24/neutron/objects/qos/rule.py I don\u0027t need to do anything else here because direction is set to egress by default (even if it\u0027s removed by obj_make_compatible() method","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00b8b4fb19c10cda701c60074da9ceb9c25836c1","unresolved":false,"context_lines":[{"line_number":479,"context_line":"        # bandwidth_limit rule type is not in policy rules at all"},{"line_number":480,"context_line":"        policy_v1_4_rule_types \u003d ["},{"line_number":481,"context_line":"            rule.rule_type for rule in policy_obj_v1_4.rules]"},{"line_number":482,"context_line":"        self.assertNotIn(rule_objs[0].rule_type, policy_v1_4_rule_types)"},{"line_number":483,"context_line":"        self.assertIn(rule_objs[1], policy_obj_v1_4.rules)"},{"line_number":484,"context_line":"        self.assertIn(rule_objs[2], policy_obj_v1_4.rules)"},{"line_number":485,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_4319f41f","line":482,"range":{"start_line":482,"start_character":8,"end_line":482,"end_character":72},"updated":"2017-04-19 17:39:25.000000000","message":"that line would pass even if the rule would be there, just with e.g. direction dropped, which is not smth we would want to see here. Consider making the check more strict. (Like also checking no other rules except expected two are present.)","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"218338dc9ee993006b2f43285433138939df7295","unresolved":false,"context_lines":[{"line_number":479,"context_line":"        # bandwidth_limit rule type is not in policy rules at all"},{"line_number":480,"context_line":"        policy_v1_4_rule_types \u003d ["},{"line_number":481,"context_line":"            rule.rule_type for rule in policy_obj_v1_4.rules]"},{"line_number":482,"context_line":"        self.assertNotIn(rule_objs[0].rule_type, policy_v1_4_rule_types)"},{"line_number":483,"context_line":"        self.assertIn(rule_objs[1], policy_obj_v1_4.rules)"},{"line_number":484,"context_line":"        self.assertIn(rule_objs[2], policy_obj_v1_4.rules)"},{"line_number":485,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_a6aaf56d","line":482,"range":{"start_line":482,"start_character":8,"end_line":482,"end_character":72},"in_reply_to":"7ffa3b31_4319f41f","updated":"2017-04-20 09:08:51.000000000","message":"it\u0027s changed now, according to my comment above","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"}],"neutron/tests/unit/objects/qos/test_rule.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00b8b4fb19c10cda701c60074da9ceb9c25836c1","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        dict_ \u003d obj.to_dict()"},{"line_number":119,"context_line":"        self.assertEqual(qos_consts.RULE_TYPE_BANDWIDTH_LIMIT, dict_[\u0027type\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def test_bandwidth_limit_object_version(self):"},{"line_number":122,"context_line":"        obj \u003d rule.QosBandwidthLimitRule(self.context, **self.db_objs[0])"},{"line_number":123,"context_line":"        prim \u003d obj.obj_to_primitive(\u00271.3\u0027)"},{"line_number":124,"context_line":"        self.assertTrue(prim)"}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_03be4cd4","line":121,"updated":"2017-04-19 17:39:25.000000000","message":"that\u0027s a silly test validating oslo code. We just killed several of those: Ice03fae1268f7d4866f7494c0184d9c30938bd57. Please remove the test case.","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"218338dc9ee993006b2f43285433138939df7295","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        dict_ \u003d obj.to_dict()"},{"line_number":119,"context_line":"        self.assertEqual(qos_consts.RULE_TYPE_BANDWIDTH_LIMIT, dict_[\u0027type\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def test_bandwidth_limit_object_version(self):"},{"line_number":122,"context_line":"        obj \u003d rule.QosBandwidthLimitRule(self.context, **self.db_objs[0])"},{"line_number":123,"context_line":"        prim \u003d obj.obj_to_primitive(\u00271.3\u0027)"},{"line_number":124,"context_line":"        self.assertTrue(prim)"}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_e6059d47","line":121,"in_reply_to":"7ffa3b31_03be4cd4","updated":"2017-04-20 09:08:51.000000000","message":"Done","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00b8b4fb19c10cda701c60074da9ceb9c25836c1","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        rule_obj \u003d rule.QosBandwidthLimitRule(self.context, **self.db_objs[0])"},{"line_number":129,"context_line":"        primitive_rule \u003d rule_obj.obj_to_primitive(\u00271.2\u0027)"},{"line_number":130,"context_line":"        self.assertTrue("},{"line_number":131,"context_line":"            \"direction\" not in primitive_rule[\u0027versioned_object.data\u0027].keys())"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        self.db_objs[0][\u0027direction\u0027] \u003d n_const.INGRESS_DIRECTION"},{"line_number":134,"context_line":"        rule_obj \u003d rule.QosBandwidthLimitRule(self.context, **self.db_objs[0])"}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_a3b8b8e4","line":131,"updated":"2017-04-19 17:39:25.000000000","message":"should we check other fields are intact?","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"218338dc9ee993006b2f43285433138939df7295","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        rule_obj \u003d rule.QosBandwidthLimitRule(self.context, **self.db_objs[0])"},{"line_number":129,"context_line":"        primitive_rule \u003d rule_obj.obj_to_primitive(\u00271.2\u0027)"},{"line_number":130,"context_line":"        self.assertTrue("},{"line_number":131,"context_line":"            \"direction\" not in primitive_rule[\u0027versioned_object.data\u0027].keys())"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        self.db_objs[0][\u0027direction\u0027] \u003d n_const.INGRESS_DIRECTION"},{"line_number":134,"context_line":"        rule_obj \u003d rule.QosBandwidthLimitRule(self.context, **self.db_objs[0])"}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_a67e75ac","line":131,"in_reply_to":"7ffa3b31_a3b8b8e4","updated":"2017-04-20 09:08:51.000000000","message":"Done","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"1e72f180e04cdf3114af81cfa5f895022019646a","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self.db_objs[0][\u0027direction\u0027] \u003d n_const.EGRESS_DIRECTION"},{"line_number":123,"context_line":"        rule_obj \u003d rule.QosBandwidthLimitRule(self.context, **self.db_objs[0])"},{"line_number":124,"context_line":"        primitive_rule \u003d rule_obj.obj_to_primitive(\u00271.2\u0027)"},{"line_number":125,"context_line":"        self.assertTrue("},{"line_number":126,"context_line":"            \"direction\" not in primitive_rule[\u0027versioned_object.data\u0027].keys())"},{"line_number":127,"context_line":"        self.assertEqual("},{"line_number":128,"context_line":"            self.db_objs[0][\u0027max_kbps\u0027],"}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_b5e86b16","line":125,"updated":"2017-04-23 19:41:40.000000000","message":"nit: assertNotIn provides nicer failure messages if it fails","commit_id":"1b676623707d8ce276cb9ddfc0c73310ffda7ee5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0627bdf57a572f37f53aacc032bbfcff7a35322a","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self.db_objs[0][\u0027direction\u0027] \u003d n_const.EGRESS_DIRECTION"},{"line_number":123,"context_line":"        rule_obj \u003d rule.QosBandwidthLimitRule(self.context, **self.db_objs[0])"},{"line_number":124,"context_line":"        primitive_rule \u003d rule_obj.obj_to_primitive(\u00271.2\u0027)"},{"line_number":125,"context_line":"        self.assertTrue("},{"line_number":126,"context_line":"            \"direction\" not in primitive_rule[\u0027versioned_object.data\u0027].keys())"},{"line_number":127,"context_line":"        self.assertEqual("},{"line_number":128,"context_line":"            self.db_objs[0][\u0027max_kbps\u0027],"}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_15f5dfcb","line":125,"in_reply_to":"5ff73747_b5e86b16","updated":"2017-04-23 20:45:38.000000000","message":"thx for tip. Changed :)","commit_id":"1b676623707d8ce276cb9ddfc0c73310ffda7ee5"}],"neutron/tests/unit/services/qos/test_qos_plugin.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00b8b4fb19c10cda701c60074da9ceb9c25836c1","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            \u0027bandwidth_limit_rule\u0027: {\u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":75,"context_line":"                                     \u0027max_kbps\u0027: 100,"},{"line_number":76,"context_line":"                                     \u0027max_burst_kbps\u0027: 150,"},{"line_number":77,"context_line":"                                     \u0027direction\u0027: n_const.EGRESS_DIRECTION},"},{"line_number":78,"context_line":"            \u0027dscp_marking_rule\u0027: {\u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":79,"context_line":"                                  \u0027dscp_mark\u0027: 16}}"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_a3867812","line":77,"updated":"2017-04-19 17:39:25.000000000","message":"you wouldn\u0027t need that if you would specify default value for the new object field in object class definition.","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0db80d617529e82e6d59b6612f89c551608ad6dc","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            \u0027bandwidth_limit_rule\u0027: {\u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":75,"context_line":"                                     \u0027max_kbps\u0027: 100,"},{"line_number":76,"context_line":"                                     \u0027max_burst_kbps\u0027: 150,"},{"line_number":77,"context_line":"                                     \u0027direction\u0027: n_const.EGRESS_DIRECTION},"},{"line_number":78,"context_line":"            \u0027dscp_marking_rule\u0027: {\u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":79,"context_line":"                                  \u0027dscp_mark\u0027: 16}}"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"5ff73747_3e64b749","line":77,"in_reply_to":"5ff73747_73f4d1cf","updated":"2017-04-27 10:35:17.000000000","message":"ok, so I will left it as it is currently :)","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00cf69a1dd5e40abdd764d057ed551f620fc5e5c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            \u0027bandwidth_limit_rule\u0027: {\u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":75,"context_line":"                                     \u0027max_kbps\u0027: 100,"},{"line_number":76,"context_line":"                                     \u0027max_burst_kbps\u0027: 150,"},{"line_number":77,"context_line":"                                     \u0027direction\u0027: n_const.EGRESS_DIRECTION},"},{"line_number":78,"context_line":"            \u0027dscp_marking_rule\u0027: {\u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":79,"context_line":"                                  \u0027dscp_mark\u0027: 16}}"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"5ff73747_73f4d1cf","line":77,"in_reply_to":"7ffa3b31_0f9c0368","updated":"2017-04-26 16:58:49.000000000","message":"I don\u0027t think it\u0027s a goal of this test class to validate specific rules. It targets qos plugin, so it shouldn\u0027t be important which payload we use, as long as it gets us far in targeting the plugin itself.","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"73976eae59ddd5a3557a080ddec427a8a747b7e6","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            \u0027bandwidth_limit_rule\u0027: {\u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":75,"context_line":"                                     \u0027max_kbps\u0027: 100,"},{"line_number":76,"context_line":"                                     \u0027max_burst_kbps\u0027: 150,"},{"line_number":77,"context_line":"                                     \u0027direction\u0027: n_const.EGRESS_DIRECTION},"},{"line_number":78,"context_line":"            \u0027dscp_marking_rule\u0027: {\u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":79,"context_line":"                                  \u0027dscp_mark\u0027: 16}}"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_0f9c0368","line":77,"in_reply_to":"7ffa3b31_6654e2fe","updated":"2017-04-20 21:41:15.000000000","message":"So Ihar, should I put direction back here? or stay like it\u0027s now without direction (default value is used)?","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"218338dc9ee993006b2f43285433138939df7295","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            \u0027bandwidth_limit_rule\u0027: {\u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":75,"context_line":"                                     \u0027max_kbps\u0027: 100,"},{"line_number":76,"context_line":"                                     \u0027max_burst_kbps\u0027: 150,"},{"line_number":77,"context_line":"                                     \u0027direction\u0027: n_const.EGRESS_DIRECTION},"},{"line_number":78,"context_line":"            \u0027dscp_marking_rule\u0027: {\u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":79,"context_line":"                                  \u0027dscp_mark\u0027: 16}}"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_d96ba6b4","line":77,"in_reply_to":"7ffa3b31_a3867812","updated":"2017-04-20 09:08:51.000000000","message":"Done","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"78c59698f32248998a8602da0f404a8cb15fb8ef","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            \u0027bandwidth_limit_rule\u0027: {\u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":75,"context_line":"                                     \u0027max_kbps\u0027: 100,"},{"line_number":76,"context_line":"                                     \u0027max_burst_kbps\u0027: 150,"},{"line_number":77,"context_line":"                                     \u0027direction\u0027: n_const.EGRESS_DIRECTION},"},{"line_number":78,"context_line":"            \u0027dscp_marking_rule\u0027: {\u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":79,"context_line":"                                  \u0027dscp_mark\u0027: 16}}"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"7ffa3b31_6654e2fe","line":77,"in_reply_to":"7ffa3b31_a3867812","updated":"2017-04-20 12:57:04.000000000","message":"That\u0027s ok, but we should be explicit in the tests. IMO, that should be there.","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"}],"releasenotes/notes/QoS-ingress-bandwidth-limit-54cea12dbea71172.yaml":[{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"e13132cefffc7d282be177b16ee69c5ad637b502","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The QoS service plugin now supports direction parameter in"},{"line_number":4,"context_line":"    bandwidth limit rule type. It allows to create rules for egress"},{"line_number":5,"context_line":"    (default) or ingress traffic."},{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  - The QoS service plugin now supports new type of rule. This new"},{"line_number":8,"context_line":"    rule is called \u0027ingress_bandwidth_limit_rule\u0027 and allow to set"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7ffa3b31_8c132567","line":5,"updated":"2017-04-14 11:00:27.000000000","message":"Mention that this is from the perspective of the port rather than the switch.","commit_id":"466b182d05c6112897eca2c69922f56f52a6d26e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6ea881e91af5ebf9f43299d10f8038cecf0ce38b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The QoS service plugin now supports direction parameter in"},{"line_number":4,"context_line":"    bandwidth limit rule type. It allows to create rules for egress"},{"line_number":5,"context_line":"    (default) or ingress traffic."},{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  - The QoS service plugin now supports new type of rule. This new"},{"line_number":8,"context_line":"    rule is called \u0027ingress_bandwidth_limit_rule\u0027 and allow to set"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7ffa3b31_36f337a1","line":5,"in_reply_to":"7ffa3b31_8c132567","updated":"2017-04-14 20:37:26.000000000","message":"Done","commit_id":"466b182d05c6112897eca2c69922f56f52a6d26e"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"e13132cefffc7d282be177b16ee69c5ad637b502","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    bandwidth limit rule type. It allows to create rules for egress"},{"line_number":5,"context_line":"    (default) or ingress traffic."},{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  - The QoS service plugin now supports new type of rule. This new"},{"line_number":8,"context_line":"    rule is called \u0027ingress_bandwidth_limit_rule\u0027 and allow to set"},{"line_number":9,"context_line":"    limits for traffic incoming to port."},{"line_number":10,"context_line":"fixes:"},{"line_number":11,"context_line":"  - Closes Bug 1560961"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7ffa3b31_cffebf04","line":8,"range":{"start_line":7,"start_character":58,"end_line":8,"end_character":49},"updated":"2017-04-14 11:00:27.000000000","message":"The patch seems to add a new parameter to the existing bandwidth_limit_rule rather than creating a new rule.","commit_id":"466b182d05c6112897eca2c69922f56f52a6d26e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6ea881e91af5ebf9f43299d10f8038cecf0ce38b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    bandwidth limit rule type. It allows to create rules for egress"},{"line_number":5,"context_line":"    (default) or ingress traffic."},{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  - The QoS service plugin now supports new type of rule. This new"},{"line_number":8,"context_line":"    rule is called \u0027ingress_bandwidth_limit_rule\u0027 and allow to set"},{"line_number":9,"context_line":"    limits for traffic incoming to port."},{"line_number":10,"context_line":"fixes:"},{"line_number":11,"context_line":"  - Closes Bug 1560961"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7ffa3b31_b634e74b","line":8,"range":{"start_line":7,"start_character":58,"end_line":8,"end_character":49},"in_reply_to":"7ffa3b31_cffebf04","updated":"2017-04-14 20:37:26.000000000","message":"right, I forgot to change it","commit_id":"466b182d05c6112897eca2c69922f56f52a6d26e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00b8b4fb19c10cda701c60074da9ceb9c25836c1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The QoS service plugin now supports direction parameter in"},{"line_number":4,"context_line":"    bandwidth limit rule type. It allows to create rules for egress"},{"line_number":5,"context_line":"    (default) or ingress, from port point of view, traffic."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7ffa3b31_e3bec0b2","line":2,"updated":"2017-04-19 17:39:25.000000000","message":"I don\u0027t think it\u0027s a major release wide note, so just leave features one.","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"218338dc9ee993006b2f43285433138939df7295","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The QoS service plugin now supports direction parameter in"},{"line_number":4,"context_line":"    bandwidth limit rule type. It allows to create rules for egress"},{"line_number":5,"context_line":"    (default) or ingress, from port point of view, traffic."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7ffa3b31_b9721a7a","line":2,"in_reply_to":"7ffa3b31_e3bec0b2","updated":"2017-04-20 09:08:51.000000000","message":"ok, I removed this section and left only \"features\"","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00b8b4fb19c10cda701c60074da9ceb9c25836c1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The QoS service plugin now supports direction parameter in"},{"line_number":4,"context_line":"    bandwidth limit rule type. It allows to create rules for egress"},{"line_number":5,"context_line":"    (default) or ingress, from port point of view, traffic."},{"line_number":6,"context_line":"features:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7ffa3b31_0391ac47","line":3,"range":{"start_line":3,"start_character":40,"end_line":3,"end_character":49},"updated":"2017-04-19 17:39:25.000000000","message":"the ``direction`` parameter","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"218338dc9ee993006b2f43285433138939df7295","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The QoS service plugin now supports direction parameter in"},{"line_number":4,"context_line":"    bandwidth limit rule type. It allows to create rules for egress"},{"line_number":5,"context_line":"    (default) or ingress, from port point of view, traffic."},{"line_number":6,"context_line":"features:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7ffa3b31_190d8ee7","line":3,"range":{"start_line":3,"start_character":40,"end_line":3,"end_character":49},"in_reply_to":"7ffa3b31_0391ac47","updated":"2017-04-20 09:08:51.000000000","message":"this section is removed now","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00b8b4fb19c10cda701c60074da9ceb9c25836c1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The QoS service plugin now supports direction parameter in"},{"line_number":4,"context_line":"    bandwidth limit rule type. It allows to create rules for egress"},{"line_number":5,"context_line":"    (default) or ingress, from port point of view, traffic."},{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  - The QoS service plugin now supports new attribute in"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7ffa3b31_2372684a","line":4,"range":{"start_line":3,"start_character":60,"end_line":4,"end_character":29},"updated":"2017-04-19 17:39:25.000000000","message":"for bandwidth limit rules","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"218338dc9ee993006b2f43285433138939df7295","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The QoS service plugin now supports direction parameter in"},{"line_number":4,"context_line":"    bandwidth limit rule type. It allows to create rules for egress"},{"line_number":5,"context_line":"    (default) or ingress, from port point of view, traffic."},{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  - The QoS service plugin now supports new attribute in"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7ffa3b31_f911c205","line":4,"range":{"start_line":3,"start_character":60,"end_line":4,"end_character":29},"in_reply_to":"7ffa3b31_2372684a","updated":"2017-04-20 09:08:51.000000000","message":"as above","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00b8b4fb19c10cda701c60074da9ceb9c25836c1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The QoS service plugin now supports direction parameter in"},{"line_number":4,"context_line":"    bandwidth limit rule type. It allows to create rules for egress"},{"line_number":5,"context_line":"    (default) or ingress, from port point of view, traffic."},{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  - The QoS service plugin now supports new attribute in"},{"line_number":8,"context_line":"    \u0027qos_bandwidth_limit_rule\u0027. This new parameter is called"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7ffa3b31_43aa1471","line":5,"range":{"start_line":5,"start_character":26,"end_line":5,"end_character":58},"updated":"2017-04-19 17:39:25.000000000","message":"I am not sure that\u0027s clear enough. You can look at the port from either sides. Maybe adopt the \u0027switch PoV\u0027 terminology.","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"218338dc9ee993006b2f43285433138939df7295","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The QoS service plugin now supports direction parameter in"},{"line_number":4,"context_line":"    bandwidth limit rule type. It allows to create rules for egress"},{"line_number":5,"context_line":"    (default) or ingress, from port point of view, traffic."},{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  - The QoS service plugin now supports new attribute in"},{"line_number":8,"context_line":"    \u0027qos_bandwidth_limit_rule\u0027. This new parameter is called"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7ffa3b31_b9f7bad3","line":5,"range":{"start_line":5,"start_character":26,"end_line":5,"end_character":58},"in_reply_to":"7ffa3b31_43aa1471","updated":"2017-04-20 09:08:51.000000000","message":"as above","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00b8b4fb19c10cda701c60074da9ceb9c25836c1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    (default) or ingress, from port point of view, traffic."},{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  - The QoS service plugin now supports new attribute in"},{"line_number":8,"context_line":"    \u0027qos_bandwidth_limit_rule\u0027. This new parameter is called"},{"line_number":9,"context_line":"    \u0027direction\u0027 and allow to set limits for traffic outgoing"},{"line_number":10,"context_line":"    or incoming to port."},{"line_number":11,"context_line":"fixes:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7ffa3b31_83cdbc67","line":8,"updated":"2017-04-19 17:39:25.000000000","message":"use ``...`` to indicate new attributes","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"218338dc9ee993006b2f43285433138939df7295","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    (default) or ingress, from port point of view, traffic."},{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  - The QoS service plugin now supports new attribute in"},{"line_number":8,"context_line":"    \u0027qos_bandwidth_limit_rule\u0027. This new parameter is called"},{"line_number":9,"context_line":"    \u0027direction\u0027 and allow to set limits for traffic outgoing"},{"line_number":10,"context_line":"    or incoming to port."},{"line_number":11,"context_line":"fixes:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7ffa3b31_b9c45a92","line":8,"in_reply_to":"7ffa3b31_83cdbc67","updated":"2017-04-20 09:08:51.000000000","message":"Done","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00b8b4fb19c10cda701c60074da9ceb9c25836c1","unresolved":false,"context_lines":[{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  - The QoS service plugin now supports new attribute in"},{"line_number":8,"context_line":"    \u0027qos_bandwidth_limit_rule\u0027. This new parameter is called"},{"line_number":9,"context_line":"    \u0027direction\u0027 and allow to set limits for traffic outgoing"},{"line_number":10,"context_line":"    or incoming to port."},{"line_number":11,"context_line":"fixes:"},{"line_number":12,"context_line":"  - Closes Bug 1560961"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7ffa3b31_43c33439","line":9,"range":{"start_line":9,"start_character":20,"end_line":9,"end_character":26},"updated":"2017-04-19 17:39:25.000000000","message":"allows","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"218338dc9ee993006b2f43285433138939df7295","unresolved":false,"context_lines":[{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  - The QoS service plugin now supports new attribute in"},{"line_number":8,"context_line":"    \u0027qos_bandwidth_limit_rule\u0027. This new parameter is called"},{"line_number":9,"context_line":"    \u0027direction\u0027 and allow to set limits for traffic outgoing"},{"line_number":10,"context_line":"    or incoming to port."},{"line_number":11,"context_line":"fixes:"},{"line_number":12,"context_line":"  - Closes Bug 1560961"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7ffa3b31_99bd1e04","line":9,"range":{"start_line":9,"start_character":20,"end_line":9,"end_character":26},"in_reply_to":"7ffa3b31_43c33439","updated":"2017-04-20 09:08:51.000000000","message":"Done","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00b8b4fb19c10cda701c60074da9ceb9c25836c1","unresolved":false,"context_lines":[{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  - The QoS service plugin now supports new attribute in"},{"line_number":8,"context_line":"    \u0027qos_bandwidth_limit_rule\u0027. This new parameter is called"},{"line_number":9,"context_line":"    \u0027direction\u0027 and allow to set limits for traffic outgoing"},{"line_number":10,"context_line":"    or incoming to port."},{"line_number":11,"context_line":"fixes:"},{"line_number":12,"context_line":"  - Closes Bug 1560961"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7ffa3b31_c3e4e4e2","line":10,"range":{"start_line":9,"start_character":33,"end_line":10,"end_character":24},"updated":"2017-04-19 17:39:25.000000000","message":"not really, it allows to \u0027specify direction of traffic for which the limit should be applied\u0027.","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"218338dc9ee993006b2f43285433138939df7295","unresolved":false,"context_lines":[{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  - The QoS service plugin now supports new attribute in"},{"line_number":8,"context_line":"    \u0027qos_bandwidth_limit_rule\u0027. This new parameter is called"},{"line_number":9,"context_line":"    \u0027direction\u0027 and allow to set limits for traffic outgoing"},{"line_number":10,"context_line":"    or incoming to port."},{"line_number":11,"context_line":"fixes:"},{"line_number":12,"context_line":"  - Closes Bug 1560961"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7ffa3b31_9952bedd","line":10,"range":{"start_line":9,"start_character":33,"end_line":10,"end_character":24},"in_reply_to":"7ffa3b31_c3e4e4e2","updated":"2017-04-20 09:08:51.000000000","message":"Done","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00b8b4fb19c10cda701c60074da9ceb9c25836c1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    \u0027direction\u0027 and allow to set limits for traffic outgoing"},{"line_number":10,"context_line":"    or incoming to port."},{"line_number":11,"context_line":"fixes:"},{"line_number":12,"context_line":"  - Closes Bug 1560961"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7ffa3b31_a3e9d8b7","line":12,"updated":"2017-04-19 17:39:25.000000000","message":"remote the section, we don\u0027t do it for RFEs.","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"218338dc9ee993006b2f43285433138939df7295","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    \u0027direction\u0027 and allow to set limits for traffic outgoing"},{"line_number":10,"context_line":"    or incoming to port."},{"line_number":11,"context_line":"fixes:"},{"line_number":12,"context_line":"  - Closes Bug 1560961"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7ffa3b31_5962f6af","line":12,"in_reply_to":"7ffa3b31_4b758a31","updated":"2017-04-20 09:08:51.000000000","message":"Done","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a70432bcea87ee9b2a5da7938ea9a81cf6e20d39","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    \u0027direction\u0027 and allow to set limits for traffic outgoing"},{"line_number":10,"context_line":"    or incoming to port."},{"line_number":11,"context_line":"fixes:"},{"line_number":12,"context_line":"  - Closes Bug 1560961"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7ffa3b31_4b758a31","line":12,"in_reply_to":"7ffa3b31_a3e9d8b7","updated":"2017-04-19 19:08:57.000000000","message":"remove","commit_id":"7202a41f6be7a65f942e15f0559b1096f4595883"}]}
